[jira] [Commented] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread mck (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473335#comment-16473335
 ] 

mck commented on CASSANDRA-13121:
-

[~ptbannister], i've put in your patches for testing (including your dtest 
change).
I'll take a closer look at the code and can commit if all looks ok.

|| Branch || uTest || aTest || dTest ||
| 
[cassandra-3.0_13121|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.0_13121]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_13121.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_13121]
 | 
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/29/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/29]
 | 
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/556/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/556]
 |
| 
[cassandra-3.11_13121|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.11_13121]
 
|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_13121.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_13121
 ]| 
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/30/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/30]
 | 
[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/557/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/557]
 |
| 
[dtest_13121|https://github.com/thelastpickle/cassandra-dtest/tree/mck/CASSANDRA-13121]
 
|[!https://circleci.com/gh/thelastpickle/workflows/cassandra-dtest/tree/mck%2FCASSANDRA-13121.svg?style=svg!|https://circleci.com/gh/thelastpickle/workflows/cassandra-dtest/tree/mck%2FCASSANDRA-13121]|
  | |

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread Patrick Bannister (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473334#comment-16473334
 ] 

Patrick Bannister commented on CASSANDRA-13121:
---

Thanks for reviewing this ticket!

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread Patrick Bannister (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407393#comment-16407393
 ] 

Patrick Bannister edited comment on CASSANDRA-13121 at 5/13/18 1:56 AM:


I've developed a patch for 3.0. The same changes should also work for 3.11.

To effectively test the patch, I recommend using the 
TestDeprecatedRepairNotifications dtest available in the CASSANDRA-13121 branch 
of https://github.com/ptbannister/cassandra-dtest. There's a pull request in 
for this dtest, but right now it's only available in my fork.


was (Author: ptbannister):
I've developed a patch for 3.0. The same changes should also work for 3.11.

To effectively test the patch, I recommend using the 
TestDeprecatedRepairNotifications dtest available in the CASSANDRA-13121 branch 
of [https://github.com/ptbannister/cassandra-dtest|[http://example.com].] 
There's a pull request in for this dtest, but right now it's only available in 
my fork.

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread mck (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-13121:

Fix Version/s: (was: 4.0)

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread mck (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-13121:

Fix Version/s: (was: 2.2.x)

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Fix For: 4.0, 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread mck (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-13121:

 Reviewer: mck
Fix Version/s: 3.11.x
   3.0.x
   2.2.x
   4.0

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Fix For: 4.0, 2.2.x, 3.0.x, 3.11.x
>
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread mck (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck reassigned CASSANDRA-13121:
---

Assignee: Patrick Bannister

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Assignee: Patrick Bannister
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13121) repair progress message breaks legacy JMX support

2018-05-12 Thread mck (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-13121:

Status: Testing  (was: Patch Available)

> repair progress message breaks legacy JMX support
> -
>
> Key: CASSANDRA-13121
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13121
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Scott Bale
>Priority: Minor
>  Labels: jmx, lhf, notifications, repair
> Attachments: 13121-3.0.txt
>
>
> The error progress message in {{RepairRunnable}} is not compliant with the 
> {{LegacyJMXProgressSupport}} class, which uses a regex to match on the text 
> of a progress event. Therefore, actual failures slip through as successes if 
> using legacy JMX for repairs.
> In {{RepairRunnable}}
> {code}
> protected void fireErrorAndComplete(String tag, int progressCount, int 
> totalProgress, String message)
> {
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.ERROR, 
> progressCount, totalProgress, message));
> fireProgressEvent(tag, new ProgressEvent(ProgressEventType.COMPLETE, 
> progressCount, totalProgress, String.format("Repair command #%d finished with 
> error", cmd)));
> }
> {code}
> Note the {{"Repair command #%d finished with error"}}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L109
> In {{LegacyJMXProgressSupport}}:
> {code}
> protected static final Pattern SESSION_FAILED_MATCHER = 
> Pattern.compile("Repair session .* for range .* failed with error .*");
> protected static final Pattern SESSION_SUCCESS_MATCHER = 
> Pattern.compile("Repair session .* for range .* finished");
> {code}
> See 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/progress/jmx/LegacyJMXProgressSupport.java#L38
> Legacy JMX support was introduced for CASSANDRA-11430 (version 2.2.6) and the 
> bug was introduced as part of CASSANDRA-12279 (version 2.2.8).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-14360) Allow nodetool toppartitions without specifying table

2018-05-12 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-14360:
---
   Resolution: Fixed
Fix Version/s: (was: 4.x)
   4.0
   Status: Resolved  (was: Ready to Commit)

You had tests and I just missed them. I explicitly ran another set 
[here|https://circleci.com/gh/jeffjirsa/cassandra/tree/14360-trunk] just to see 
the dtests.

Committed to trunk as {{45f250535a5d26011ce7d71c9c09b31d758bfd7b}}

> Allow nodetool toppartitions without specifying table
> -
>
> Key: CASSANDRA-14360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14360
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Major
> Fix For: 4.0
>
>
> It can be hard to determine even which table is the one with most issue, so 
> determining if there is a single dominate partition being updated or queried 
> would be nicer without having to specify the table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-14360) Allow nodetool toppartitions without specifying table

2018-05-12 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-14360:
---
Status: Ready to Commit  (was: Patch Available)

> Allow nodetool toppartitions without specifying table
> -
>
> Key: CASSANDRA-14360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14360
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Major
> Fix For: 4.x
>
>
> It can be hard to determine even which table is the one with most issue, so 
> determining if there is a single dominate partition being updated or queried 
> would be nicer without having to specify the table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14360) Allow nodetool toppartitions without specifying table

2018-05-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473235#comment-16473235
 ] 

ASF GitHub Bot commented on CASSANDRA-14360:


Github user asfgit closed the pull request at:

https://github.com/apache/cassandra/pull/214


> Allow nodetool toppartitions without specifying table
> -
>
> Key: CASSANDRA-14360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14360
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Observability
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Major
> Fix For: 4.x
>
>
> It can be hard to determine even which table is the one with most issue, so 
> determining if there is a single dominate partition being updated or queried 
> would be nicer without having to specify the table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

cassandra git commit: Allow noarg toppartitions

2018-05-12 Thread jjirsa 
Repository: cassandra
Updated Branches:
  refs/heads/trunk dd650c8e8 -> 45f250535


Allow noarg toppartitions

Closes #214

Patch by Chris Lohfink; Reviewed by Dinesh Joshi for CASSANDRA-14360


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/45f25053
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/45f25053
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/45f25053

Branch: refs/heads/trunk
Commit: 45f250535a5d26011ce7d71c9c09b31d758bfd7b
Parents: dd650c8
Author: Chris Lohfink 
Authored: Wed May 2 00:52:16 2018 -0700
Committer: Jeff Jirsa 
Committed: Sat May 12 11:19:22 2018 -0700

--
 CHANGES.txt |  1 +
 .../cassandra/service/StorageService.java   | 38 
 .../cassandra/service/StorageServiceMBean.java  |  5 +
 .../org/apache/cassandra/tools/NodeProbe.java   | 21 +++--
 .../cassandra/tools/nodetool/TopPartitions.java | 98 +---
 .../cassandra/tools/TopPartitionsTest.java  | 67 +
 6 files changed, 187 insertions(+), 43 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/45f25053/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index aa4ef39..01c67f4 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0
+ * Allow nodetool toppartitions without specifying table (CASSANDRA-14360)
  * Audit logging for database activity (CASSANDRA-12151)
  * Clean up build artifacts in docs container (CASSANDRA-14432)
  * Minor network authz improvements (Cassandra-14413)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/45f25053/src/java/org/apache/cassandra/service/StorageService.java
--
diff --git a/src/java/org/apache/cassandra/service/StorageService.java 
b/src/java/org/apache/cassandra/service/StorageService.java
index dd2f178..a62af6f 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -33,9 +33,13 @@ import java.util.stream.StreamSupport;
 
 import javax.annotation.Nullable;
 import javax.management.*;
+import javax.management.openmbean.CompositeData;
+import javax.management.openmbean.CompositeDataSupport;
+import javax.management.openmbean.OpenDataException;
 import javax.management.openmbean.TabularData;
 import javax.management.openmbean.TabularDataSupport;
 
+import com.clearspring.analytics.stream.Counter;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Predicate;
@@ -76,6 +80,7 @@ import org.apache.cassandra.io.sstable.SSTableLoader;
 import org.apache.cassandra.io.util.FileUtils;
 import org.apache.cassandra.locator.*;
 import org.apache.cassandra.metrics.StorageMetrics;
+import org.apache.cassandra.metrics.TableMetrics.Sampler;
 import org.apache.cassandra.net.*;
 import org.apache.cassandra.repair.*;
 import org.apache.cassandra.repair.messages.RepairOption;
@@ -99,6 +104,7 @@ import org.apache.cassandra.streaming.*;
 import org.apache.cassandra.tracing.TraceKeyspace;
 import org.apache.cassandra.transport.ProtocolVersion;
 import org.apache.cassandra.utils.*;
+import org.apache.cassandra.utils.TopKSampler.SamplerResult;
 import org.apache.cassandra.utils.logging.LoggingSupportFactory;
 import org.apache.cassandra.utils.progress.ProgressEvent;
 import org.apache.cassandra.utils.progress.ProgressEventType;
@@ -5269,6 +5275,38 @@ public class StorageService extends 
NotificationBroadcasterSupport implements IE
 return sampledKeys;
 }
 
+/*
+ * little hard to parse for JMX MBean requirements, but the output looks 
something like:
+ *
+ *  {"keyspace.table":
+ *{"SAMPLER": [{cardinality:i partitions: [{raw:"", string:"", 
count:i, error:i}, ...]}, ...]}
+ *  }
+ */
+@Override
+public Map> samplePartitions(long 
duration, int capacity, int count, List samplers) throws 
OpenDataException
+{
+for (String sampler : samplers)
+{
+for (ColumnFamilyStore table : ColumnFamilyStore.all())
+{
+table.beginLocalSampling(sampler, capacity);
+}
+}
+
+Uninterruptibles.sleepUninterruptibly(duration, TimeUnit.MILLISECONDS);
+ConcurrentHashMap> result = new 
ConcurrentHashMap<>();
+for (String sampler : samplers)
+{
+for (ColumnFamilyStore table : ColumnFamilyStore.all())
+{
+String name = table.keyspace.getName() + "." + table.name;
+Map

[jira] [Updated] (CASSANDRA-14416) Remove string formatting lines from hot path

2018-05-12 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-14416:
---
   Resolution: Fixed
 Reviewer: Marcus Eriksson
Fix Version/s: (was: 3.11.x)
   (was: 4.x)
   3.11.3
   4.0
   Status: Resolved  (was: Ready to Commit)

Better. Committed as 28058608f13d2a5bbc0da2af344b92d3acad7e26


> Remove string formatting lines from hot path
> 
>
> Key: CASSANDRA-14416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14416
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Minor
>  Labels: performance
> Fix For: 4.0, 3.11.3
>
>
> In the BufferPool, we have a {{NoSpamLogger}} that gets called in some 
> conditions (like when we're at or near the cap in a given pool), which has 
> some string formatting on it. In situations where that log line is invoked, 
> that string formatting gets called before the rate limiting, which becomes 
> expensive. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[2/3] cassandra git commit: Remove string formatting lines from BufferPool hot path

2018-05-12 Thread jjirsa 
Remove string formatting lines from BufferPool hot path

Patch by Jeff Jirsa; Reviewed by Marcus Eriksson for CASSANDRA-14416


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/28058608
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/28058608
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/28058608

Branch: refs/heads/trunk
Commit: 28058608f13d2a5bbc0da2af344b92d3acad7e26
Parents: 443088f
Author: Jeff Jirsa 
Authored: Tue Apr 24 23:15:13 2018 -0700
Committer: Jeff Jirsa 
Committed: Sat May 12 21:08:15 2018 +0530

--
 CHANGES.txt| 1 +
 src/java/org/apache/cassandra/utils/memory/BufferPool.java | 7 ++-
 2 files changed, 3 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/28058608/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 3e8f687..e63e5f3 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.11.3
+ * Remove string formatting lines from BufferPool hot path (CASSANDRA-14416)
  * Update metrics to 3.1.5 (CASSANDRA-12924)
  * Detect OpenJDK jvm type and architecture (CASSANDRA-12793)
  * Don't use guava collections in the non-system keyspace jmx attributes 
(CASSANDRA-12271)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/28058608/src/java/org/apache/cassandra/utils/memory/BufferPool.java
--
diff --git a/src/java/org/apache/cassandra/utils/memory/BufferPool.java 
b/src/java/org/apache/cassandra/utils/memory/BufferPool.java
index 20e6006..f9ec40c 100644
--- a/src/java/org/apache/cassandra/utils/memory/BufferPool.java
+++ b/src/java/org/apache/cassandra/utils/memory/BufferPool.java
@@ -265,8 +265,7 @@ public class BufferPool
 if (cur + MACRO_CHUNK_SIZE > MEMORY_USAGE_THRESHOLD)
 {
 noSpamLogger.info("Maximum memory usage reached ({}), 
cannot allocate chunk of {}",
-  
FBUtilities.prettyPrintMemory(MEMORY_USAGE_THRESHOLD),
-  
FBUtilities.prettyPrintMemory(MACRO_CHUNK_SIZE));
+  MEMORY_USAGE_THRESHOLD, 
MACRO_CHUNK_SIZE);
 return false;
 }
 if (memoryUsage.compareAndSet(cur, cur + MACRO_CHUNK_SIZE))
@@ -284,9 +283,7 @@ public class BufferPool
 noSpamLogger.error("Buffer pool failed to allocate chunk of 
{}, current size {} ({}). " +
"Attempting to continue; buffers will be 
allocated in on-heap memory which can degrade performance. " +
"Make sure direct memory size 
(-XX:MaxDirectMemorySize) is large enough to accommodate off-heap memtables and 
caches.",
-   
FBUtilities.prettyPrintMemory(MACRO_CHUNK_SIZE),
-   
FBUtilities.prettyPrintMemory(sizeInBytes()),
-   oom.toString());
+   MACRO_CHUNK_SIZE, sizeInBytes(), 
oom.toString());
 return false;
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[3/3] cassandra git commit: Merge branch 'cassandra-3.11' into trunk

2018-05-12 Thread jjirsa 
Merge branch 'cassandra-3.11' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dd650c8e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dd650c8e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dd650c8e

Branch: refs/heads/trunk
Commit: dd650c8e86d2f8fa831f81b6eefbdc8fdbc3
Parents: 4f1094e 2805860
Author: Jeff Jirsa 
Authored: Sat May 12 21:09:04 2018 +0530
Committer: Jeff Jirsa 
Committed: Sat May 12 21:09:50 2018 +0530

--
 CHANGES.txt| 1 +
 src/java/org/apache/cassandra/utils/memory/BufferPool.java | 7 ++-
 2 files changed, 3 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/dd650c8e/CHANGES.txt
--
diff --cc CHANGES.txt
index d2e4850,e63e5f3..aa4ef39
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,245 -1,6 +1,246 @@@
 +4.0
 + * Audit logging for database activity (CASSANDRA-12151)
 + * Clean up build artifacts in docs container (CASSANDRA-14432)
 + * Minor network authz improvements (Cassandra-14413)
 + * Automatic sstable upgrades (CASSANDRA-14197)
 + * Replace deprecated junit.framework.Assert usages with org.junit.Assert 
(CASSANDRA-14431)
 + * Cassandra-stress throws NPE if insert section isn't specified in user 
profile (CASSSANDRA-14426)
 + * List clients by protocol versions `nodetool clientstats --by-protocol` 
(CASSANDRA-14335)
 + * Improve LatencyMetrics performance by reducing write path processing 
(CASSANDRA-14281)
 + * Add network authz (CASSANDRA-13985)
 + * Use the correct IP/Port for Streaming when localAddress is left unbound 
(CASSANDRA-14389)
 + * nodetool listsnapshots is missing local system keyspace snapshots 
(CASSANDRA-14381)
 + * Remove StreamCoordinator.streamExecutor thread pool (CASSANDRA-14402)
 + * Rename nodetool --with-port to --print-port to disambiguate from --port 
(CASSANDRA-14392)
 + * Client TOPOLOGY_CHANGE messages have wrong port. (CASSANDRA-14398)
 + * Add ability to load new SSTables from a separate directory (CASSANDRA-6719)
 + * Eliminate background repair and probablistic read_repair_chance table 
options
 +   (CASSANDRA-13910)
 + * Bind to correct local address in 4.0 streaming (CASSANDRA-14362)
 + * Use standard Amazon naming for datacenter and rack in Ec2Snitch 
(CASSANDRA-7839)
 + * Fix junit failure for SSTableReaderTest (CASSANDRA-14387)
 + * Abstract write path for pluggable storage (CASSANDRA-14118)
 + * nodetool describecluster should be more informative (CASSANDRA-13853)
 + * Compaction performance improvements (CASSANDRA-14261) 
 + * Refactor Pair usage to avoid boxing ints/longs (CASSANDRA-14260)
 + * Add options to nodetool tablestats to sort and limit output 
(CASSANDRA-13889)
 + * Rename internals to reflect CQL vocabulary (CASSANDRA-14354)
 + * Add support for hybrid MIN(), MAX() speculative retry policies
 +   (CASSANDRA-14293, CASSANDRA-14338, CASSANDRA-14352)
 + * Fix some regressions caused by 14058 (CASSANDRA-14353)
 + * Abstract repair for pluggable storage (CASSANDRA-14116)
 + * Add meaningful toString() impls (CASSANDRA-13653)
 + * Add sstableloader option to accept target keyspace name (CASSANDRA-13884)
 + * Move processing of EchoMessage response to gossip stage (CASSANDRA-13713)
 + * Add coordinator write metric per CF (CASSANDRA-14232)
 + * Correct and clarify SSLFactory.getSslContext method and call sites 
(CASSANDRA-14314)
 + * Handle static and partition deletion properly on 
ThrottledUnfilteredIterator (CASSANDRA-14315)
 + * NodeTool clientstats should show SSL Cipher (CASSANDRA-14322)
 + * Add ability to specify driver name and version (CASSANDRA-14275)
 + * Abstract streaming for pluggable storage (CASSANDRA-14115)
 + * Forced incremental repairs should promote sstables if they can 
(CASSANDRA-14294)
 + * Use Murmur3 for validation compactions (CASSANDRA-14002)
 + * Comma at the end of the seed list is interpretated as localhost 
(CASSANDRA-14285)
 + * Refactor read executor and response resolver, abstract read repair 
(CASSANDRA-14058)
 + * Add optional startup delay to wait until peers are ready (CASSANDRA-13993)
 + * Add a few options to nodetool verify (CASSANDRA-14201)
 + * CVE-2017-5929 Security vulnerability and redefine default log rotation 
policy (CASSANDRA-14183)
 + * Use JVM default SSL validation algorithm instead of custom default 
(CASSANDRA-13259)
 + * Better document in code InetAddressAndPort usage post 7544, incorporate 
port into UUIDGen node (CASSANDRA-14226)
 + * Fix sstablemetadata date string for minLocalDeletionTime (CASSANDRA-14132)
 + * Make it possible to change neverPurgeTombstones during runtime 
(CASSANDRA-14214)
 + * Remove

[1/3] cassandra git commit: Remove string formatting lines from BufferPool hot path

2018-05-12 Thread jjirsa 
Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.11 443088fd1 -> 28058608f
  refs/heads/trunk 4f1094e66 -> dd650c8e8


Remove string formatting lines from BufferPool hot path

Patch by Jeff Jirsa; Reviewed by Marcus Eriksson for CASSANDRA-14416


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/28058608
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/28058608
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/28058608

Branch: refs/heads/cassandra-3.11
Commit: 28058608f13d2a5bbc0da2af344b92d3acad7e26
Parents: 443088f
Author: Jeff Jirsa 
Authored: Tue Apr 24 23:15:13 2018 -0700
Committer: Jeff Jirsa 
Committed: Sat May 12 21:08:15 2018 +0530

--
 CHANGES.txt| 1 +
 src/java/org/apache/cassandra/utils/memory/BufferPool.java | 7 ++-
 2 files changed, 3 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/28058608/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 3e8f687..e63e5f3 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.11.3
+ * Remove string formatting lines from BufferPool hot path (CASSANDRA-14416)
  * Update metrics to 3.1.5 (CASSANDRA-12924)
  * Detect OpenJDK jvm type and architecture (CASSANDRA-12793)
  * Don't use guava collections in the non-system keyspace jmx attributes 
(CASSANDRA-12271)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/28058608/src/java/org/apache/cassandra/utils/memory/BufferPool.java
--
diff --git a/src/java/org/apache/cassandra/utils/memory/BufferPool.java 
b/src/java/org/apache/cassandra/utils/memory/BufferPool.java
index 20e6006..f9ec40c 100644
--- a/src/java/org/apache/cassandra/utils/memory/BufferPool.java
+++ b/src/java/org/apache/cassandra/utils/memory/BufferPool.java
@@ -265,8 +265,7 @@ public class BufferPool
 if (cur + MACRO_CHUNK_SIZE > MEMORY_USAGE_THRESHOLD)
 {
 noSpamLogger.info("Maximum memory usage reached ({}), 
cannot allocate chunk of {}",
-  
FBUtilities.prettyPrintMemory(MEMORY_USAGE_THRESHOLD),
-  
FBUtilities.prettyPrintMemory(MACRO_CHUNK_SIZE));
+  MEMORY_USAGE_THRESHOLD, 
MACRO_CHUNK_SIZE);
 return false;
 }
 if (memoryUsage.compareAndSet(cur, cur + MACRO_CHUNK_SIZE))
@@ -284,9 +283,7 @@ public class BufferPool
 noSpamLogger.error("Buffer pool failed to allocate chunk of 
{}, current size {} ({}). " +
"Attempting to continue; buffers will be 
allocated in on-heap memory which can degrade performance. " +
"Make sure direct memory size 
(-XX:MaxDirectMemorySize) is large enough to accommodate off-heap memtables and 
caches.",
-   
FBUtilities.prettyPrintMemory(MACRO_CHUNK_SIZE),
-   
FBUtilities.prettyPrintMemory(sizeInBytes()),
-   oom.toString());
+   MACRO_CHUNK_SIZE, sizeInBytes(), 
oom.toString());
 return false;
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Resolved] (CASSANDRA-14418) Cassandra not starting when using enhanced startup scripts in windows

2018-05-12 Thread Jason Brown (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-14418.
-
   Resolution: Fixed
Fix Version/s: (was: 3.11.x)
   3.11.3
   3.0.17
   4.0

Thanks for confirming, [~djoshi3].

Looks like this line (and a similar one with the same quoting problem) was 
introduced in CASSANDRA-10939 (committed to 3.0+). I've gone ahead and fixed 
both those lines for 3.0 and up. Committed as sha 
{{b9b2a4e1a07af518cebd4441469c940d5ac0c2ea}}. Thanks, all!

> Cassandra not starting when using enhanced startup scripts in windows
> -
>
> Key: CASSANDRA-14418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14418
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Shyam Phirke
>Assignee: Shyam Phirke
>Priority: Major
> Fix For: 4.0, 3.0.17, 3.11.3
>
>
> I am using Apache Cassandra 3.11.2 with my application. 
> My application is getting installed under C:/Program Files/My 
> Application/Some Folder/.
> And cassandra C:/Program Files/My Application/Some Folder/cassandra.
> So when I am using enhanced startup scripts cassandra not getting up and 
> running and I am getting below error:
> "Error: Could not find or load main class Files\My"
> One of the solution I got is moving cassandra to another location where 
> location path does not contain spaces. But this is not good way of getting 
> this problem resolved.
> After doing detailed analysis of all the scripts I found the solution below:
> Inside file cassandra-env.ps1 at line number 380:
> Replace line:
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
> with line
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
> Fix here is the double quotes added before $env:CASSANDRA_CONF and at the end.
> At other places this case is well handled. But missed at this place.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[4/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2018-05-12 Thread jasobrown 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/443088fd
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/443088fd
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/443088fd

Branch: refs/heads/trunk
Commit: 443088fd13ce8ad71fa96389095bfb117f65c6bd
Parents: 14bfc94 b9b2a4e
Author: Jason Brown 
Authored: Sat May 12 05:29:20 2018 -0700
Committer: Jason Brown 
Committed: Sat May 12 05:31:34 2018 -0700

--
 CHANGES.txt| 1 +
 conf/cassandra-env.ps1 | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/443088fd/CHANGES.txt
--
diff --cc CHANGES.txt
index fc643ad,7c557f7..3e8f687
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,18 -1,5 +1,19 @@@
 -3.0.17
 +3.11.3
 + * Update metrics to 3.1.5 (CASSANDRA-12924)
 + * Detect OpenJDK jvm type and architecture (CASSANDRA-12793)
 + * Don't use guava collections in the non-system keyspace jmx attributes 
(CASSANDRA-12271)
 + * Allow existing nodes to use all peers in shadow round (CASSANDRA-13851)
 + * Fix cqlsh to read connection.ssl cqlshrc option again (CASSANDRA-14299)
 + * Downgrade log level to trace for CommitLogSegmentManager (CASSANDRA-14370)
 + * CQL fromJson(null) throws NullPointerException (CASSANDRA-13891)
 + * Serialize empty buffer as empty string for json output format 
(CASSANDRA-14245)
 + * Allow logging implementation to be interchanged for embedded testing 
(CASSANDRA-13396)
 + * SASI tokenizer for simple delimiter based entries (CASSANDRA-14247)
 + * Fix Loss of digits when doing CAST from varint/bigint to decimal 
(CASSANDRA-14170)
 + * RateBasedBackPressure unnecessarily invokes a lock on the Guava 
RateLimiter (CASSANDRA-14163)
 + * Fix wildcard GROUP BY queries (CASSANDRA-14209)
 +Merged from 3.0:
+  * Cassandra not starting when using enhanced startup scripts in windows 
(CASSANDRA-14418)
   * Fix progress stats and units in compactionstats (CASSANDRA-12244)
   * Better handle missing partition columns in system_schema.columns 
(CASSANDRA-14379)
   * Delay hints store excise by write timeout to avoid race with decommission 
(CASSANDRA-13740)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/443088fd/conf/cassandra-env.ps1
--
diff --cc conf/cassandra-env.ps1
index 49d03ce,74511f0..c78a3fc
--- a/conf/cassandra-env.ps1
+++ b/conf/cassandra-env.ps1
@@@ -390,9 -390,36 +390,9 @@@ Function SetCassandraEnvironmen
  if ($env:CASSANDRA_HEAPDUMP_DIR)
  {
  $unixTimestamp = [int64](([datetime]::UtcNow)-(get-date 
"1/1/1970")).TotalSeconds
- $env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"
+ $env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=""$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"""
  }
  
 -if ($env:JVM_VERSION.CompareTo("1.8.0") -eq -1 -or 
[convert]::ToInt32($env:JVM_PATCH_VERSION) -lt 40)
 -{
 -echo "Cassandra 3.0 and later require Java 8u40 or later."
 -exit
 -}
 -
 -# enable assertions.  disabling this in production will give a modest
 -# performance benefit (around 5%).
 -$env:JVM_OPTS = "$env:JVM_OPTS -ea"
 -
 -# Specifies the default port over which Cassandra will be available for
 -# JMX connections.
 -$JMX_PORT="7199"
 -
 -# store in env to check if it's avail in verification
 -$env:JMX_PORT=$JMX_PORT
 -
 -# enable thread priorities, primarily so we can give periodic tasks
 -# a lower priority to avoid interfering with client workload
 -$env:JVM_OPTS="$env:JVM_OPTS -XX:+UseThreadPriorities"
 -# allows lowering thread priority without being root on linux - probably
 -# not necessary on Windows but doesn't harm anything.
 -# see http://tech.stolsvik.com/2010/01/linux-java-thread-priorities-workar
 -$env:JVM_OPTS="$env:JVM_OPTS -XX:ThreadPriorityPolicy=42"
 -
 -$env:JVM_OPTS="$env:JVM_OPTS -XX:+HeapDumpOnOutOfMemoryError"
 -
  # stop the jvm on OutOfMemoryError as it can result in some data 
corruption
  # uncomment the preferred option
  # ExitOnOutOfMemoryError and CrashOnOutOfMemoryError require a JRE 
greater or equals to 1.7 update 101 or 1.8 update 92


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[2/6] cassandra git commit: Cassandra not starting when using enhanced startup scripts in windows

2018-05-12 Thread jasobrown 
Cassandra not starting when using enhanced startup scripts in windows

patch by Shyam Phirke; reviewed by jasobrown CASSANDRA-14418


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b9b2a4e1
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b9b2a4e1
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b9b2a4e1

Branch: refs/heads/cassandra-3.11
Commit: b9b2a4e1a07af518cebd4441469c940d5ac0c2ea
Parents: 9bf5133
Author: Shyam Phirke 
Authored: Sat May 12 05:28:20 2018 -0700
Committer: Jason Brown 
Committed: Sat May 12 05:28:20 2018 -0700

--
 CHANGES.txt| 1 +
 conf/cassandra-env.ps1 | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b9b2a4e1/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index e2f6d07..7c557f7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.17
+ * Cassandra not starting when using enhanced startup scripts in windows 
(CASSANDRA-14418)
  * Fix progress stats and units in compactionstats (CASSANDRA-12244)
  * Better handle missing partition columns in system_schema.columns 
(CASSANDRA-14379)
  * Delay hints store excise by write timeout to avoid race with decommission 
(CASSANDRA-13740)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b9b2a4e1/conf/cassandra-env.ps1
--
diff --git a/conf/cassandra-env.ps1 b/conf/cassandra-env.ps1
index 405ed92..74511f0 100644
--- a/conf/cassandra-env.ps1
+++ b/conf/cassandra-env.ps1
@@ -377,7 +377,7 @@ Function SetCassandraEnvironment
 }
 
 # provides hints to the JIT compiler
-$env:JVM_OPTS = "$env:JVM_OPTS 
-XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
+$env:JVM_OPTS = "$env:JVM_OPTS 
-XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
 
 # add the jamm javaagent
 if (($env:JVM_VENDOR -ne "OpenJDK") -or 
($env:JVM_VERSION.CompareTo("1.6.0") -eq 1) -or
@@ -390,7 +390,7 @@ Function SetCassandraEnvironment
 if ($env:CASSANDRA_HEAPDUMP_DIR)
 {
 $unixTimestamp = [int64](([datetime]::UtcNow)-(get-date 
"1/1/1970")).TotalSeconds
-$env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"
+$env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=""$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"""
 }
 
 if ($env:JVM_VERSION.CompareTo("1.8.0") -eq -1 -or 
[convert]::ToInt32($env:JVM_PATCH_VERSION) -lt 40)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[1/6] cassandra git commit: Cassandra not starting when using enhanced startup scripts in windows

2018-05-12 Thread jasobrown 
Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.0 9bf513374 -> b9b2a4e1a
  refs/heads/cassandra-3.11 14bfc9493 -> 443088fd1
  refs/heads/trunk a6bf9c535 -> 4f1094e66


Cassandra not starting when using enhanced startup scripts in windows

patch by Shyam Phirke; reviewed by jasobrown CASSANDRA-14418


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b9b2a4e1
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b9b2a4e1
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b9b2a4e1

Branch: refs/heads/cassandra-3.0
Commit: b9b2a4e1a07af518cebd4441469c940d5ac0c2ea
Parents: 9bf5133
Author: Shyam Phirke 
Authored: Sat May 12 05:28:20 2018 -0700
Committer: Jason Brown 
Committed: Sat May 12 05:28:20 2018 -0700

--
 CHANGES.txt| 1 +
 conf/cassandra-env.ps1 | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b9b2a4e1/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index e2f6d07..7c557f7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.17
+ * Cassandra not starting when using enhanced startup scripts in windows 
(CASSANDRA-14418)
  * Fix progress stats and units in compactionstats (CASSANDRA-12244)
  * Better handle missing partition columns in system_schema.columns 
(CASSANDRA-14379)
  * Delay hints store excise by write timeout to avoid race with decommission 
(CASSANDRA-13740)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b9b2a4e1/conf/cassandra-env.ps1
--
diff --git a/conf/cassandra-env.ps1 b/conf/cassandra-env.ps1
index 405ed92..74511f0 100644
--- a/conf/cassandra-env.ps1
+++ b/conf/cassandra-env.ps1
@@ -377,7 +377,7 @@ Function SetCassandraEnvironment
 }
 
 # provides hints to the JIT compiler
-$env:JVM_OPTS = "$env:JVM_OPTS 
-XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
+$env:JVM_OPTS = "$env:JVM_OPTS 
-XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
 
 # add the jamm javaagent
 if (($env:JVM_VENDOR -ne "OpenJDK") -or 
($env:JVM_VERSION.CompareTo("1.6.0") -eq 1) -or
@@ -390,7 +390,7 @@ Function SetCassandraEnvironment
 if ($env:CASSANDRA_HEAPDUMP_DIR)
 {
 $unixTimestamp = [int64](([datetime]::UtcNow)-(get-date 
"1/1/1970")).TotalSeconds
-$env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"
+$env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=""$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"""
 }
 
 if ($env:JVM_VERSION.CompareTo("1.8.0") -eq -1 -or 
[convert]::ToInt32($env:JVM_PATCH_VERSION) -lt 40)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[6/6] cassandra git commit: Merge branch 'cassandra-3.11' into trunk

2018-05-12 Thread jasobrown 
Merge branch 'cassandra-3.11' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4f1094e6
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4f1094e6
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4f1094e6

Branch: refs/heads/trunk
Commit: 4f1094e66856fde9e7bc4b77cf0b9e29696cb753
Parents: a6bf9c5 443088f
Author: Jason Brown 
Authored: Sat May 12 05:32:10 2018 -0700
Committer: Jason Brown 
Committed: Sat May 12 05:33:02 2018 -0700

--
 CHANGES.txt| 1 +
 conf/cassandra-env.ps1 | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/4f1094e6/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/4f1094e6/conf/cassandra-env.ps1
--


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[3/6] cassandra git commit: Cassandra not starting when using enhanced startup scripts in windows

2018-05-12 Thread jasobrown 
Cassandra not starting when using enhanced startup scripts in windows

patch by Shyam Phirke; reviewed by jasobrown CASSANDRA-14418


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b9b2a4e1
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b9b2a4e1
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b9b2a4e1

Branch: refs/heads/trunk
Commit: b9b2a4e1a07af518cebd4441469c940d5ac0c2ea
Parents: 9bf5133
Author: Shyam Phirke 
Authored: Sat May 12 05:28:20 2018 -0700
Committer: Jason Brown 
Committed: Sat May 12 05:28:20 2018 -0700

--
 CHANGES.txt| 1 +
 conf/cassandra-env.ps1 | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b9b2a4e1/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index e2f6d07..7c557f7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.17
+ * Cassandra not starting when using enhanced startup scripts in windows 
(CASSANDRA-14418)
  * Fix progress stats and units in compactionstats (CASSANDRA-12244)
  * Better handle missing partition columns in system_schema.columns 
(CASSANDRA-14379)
  * Delay hints store excise by write timeout to avoid race with decommission 
(CASSANDRA-13740)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b9b2a4e1/conf/cassandra-env.ps1
--
diff --git a/conf/cassandra-env.ps1 b/conf/cassandra-env.ps1
index 405ed92..74511f0 100644
--- a/conf/cassandra-env.ps1
+++ b/conf/cassandra-env.ps1
@@ -377,7 +377,7 @@ Function SetCassandraEnvironment
 }
 
 # provides hints to the JIT compiler
-$env:JVM_OPTS = "$env:JVM_OPTS 
-XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
+$env:JVM_OPTS = "$env:JVM_OPTS 
-XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
 
 # add the jamm javaagent
 if (($env:JVM_VENDOR -ne "OpenJDK") -or 
($env:JVM_VERSION.CompareTo("1.6.0") -eq 1) -or
@@ -390,7 +390,7 @@ Function SetCassandraEnvironment
 if ($env:CASSANDRA_HEAPDUMP_DIR)
 {
 $unixTimestamp = [int64](([datetime]::UtcNow)-(get-date 
"1/1/1970")).TotalSeconds
-$env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"
+$env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=""$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"""
 }
 
 if ($env:JVM_VERSION.CompareTo("1.8.0") -eq -1 -or 
[convert]::ToInt32($env:JVM_PATCH_VERSION) -lt 40)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[5/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11

2018-05-12 Thread jasobrown 
Merge branch 'cassandra-3.0' into cassandra-3.11


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/443088fd
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/443088fd
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/443088fd

Branch: refs/heads/cassandra-3.11
Commit: 443088fd13ce8ad71fa96389095bfb117f65c6bd
Parents: 14bfc94 b9b2a4e
Author: Jason Brown 
Authored: Sat May 12 05:29:20 2018 -0700
Committer: Jason Brown 
Committed: Sat May 12 05:31:34 2018 -0700

--
 CHANGES.txt| 1 +
 conf/cassandra-env.ps1 | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/443088fd/CHANGES.txt
--
diff --cc CHANGES.txt
index fc643ad,7c557f7..3e8f687
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,18 -1,5 +1,19 @@@
 -3.0.17
 +3.11.3
 + * Update metrics to 3.1.5 (CASSANDRA-12924)
 + * Detect OpenJDK jvm type and architecture (CASSANDRA-12793)
 + * Don't use guava collections in the non-system keyspace jmx attributes 
(CASSANDRA-12271)
 + * Allow existing nodes to use all peers in shadow round (CASSANDRA-13851)
 + * Fix cqlsh to read connection.ssl cqlshrc option again (CASSANDRA-14299)
 + * Downgrade log level to trace for CommitLogSegmentManager (CASSANDRA-14370)
 + * CQL fromJson(null) throws NullPointerException (CASSANDRA-13891)
 + * Serialize empty buffer as empty string for json output format 
(CASSANDRA-14245)
 + * Allow logging implementation to be interchanged for embedded testing 
(CASSANDRA-13396)
 + * SASI tokenizer for simple delimiter based entries (CASSANDRA-14247)
 + * Fix Loss of digits when doing CAST from varint/bigint to decimal 
(CASSANDRA-14170)
 + * RateBasedBackPressure unnecessarily invokes a lock on the Guava 
RateLimiter (CASSANDRA-14163)
 + * Fix wildcard GROUP BY queries (CASSANDRA-14209)
 +Merged from 3.0:
+  * Cassandra not starting when using enhanced startup scripts in windows 
(CASSANDRA-14418)
   * Fix progress stats and units in compactionstats (CASSANDRA-12244)
   * Better handle missing partition columns in system_schema.columns 
(CASSANDRA-14379)
   * Delay hints store excise by write timeout to avoid race with decommission 
(CASSANDRA-13740)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/443088fd/conf/cassandra-env.ps1
--
diff --cc conf/cassandra-env.ps1
index 49d03ce,74511f0..c78a3fc
--- a/conf/cassandra-env.ps1
+++ b/conf/cassandra-env.ps1
@@@ -390,9 -390,36 +390,9 @@@ Function SetCassandraEnvironmen
  if ($env:CASSANDRA_HEAPDUMP_DIR)
  {
  $unixTimestamp = [int64](([datetime]::UtcNow)-(get-date 
"1/1/1970")).TotalSeconds
- $env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"
+ $env:JVM_OPTS="$env:JVM_OPTS 
-XX:HeapDumpPath=""$env:CASSANDRA_HEAPDUMP_DIR\cassandra-$unixTimestamp-pid$pid.hprof"""
  }
  
 -if ($env:JVM_VERSION.CompareTo("1.8.0") -eq -1 -or 
[convert]::ToInt32($env:JVM_PATCH_VERSION) -lt 40)
 -{
 -echo "Cassandra 3.0 and later require Java 8u40 or later."
 -exit
 -}
 -
 -# enable assertions.  disabling this in production will give a modest
 -# performance benefit (around 5%).
 -$env:JVM_OPTS = "$env:JVM_OPTS -ea"
 -
 -# Specifies the default port over which Cassandra will be available for
 -# JMX connections.
 -$JMX_PORT="7199"
 -
 -# store in env to check if it's avail in verification
 -$env:JMX_PORT=$JMX_PORT
 -
 -# enable thread priorities, primarily so we can give periodic tasks
 -# a lower priority to avoid interfering with client workload
 -$env:JVM_OPTS="$env:JVM_OPTS -XX:+UseThreadPriorities"
 -# allows lowering thread priority without being root on linux - probably
 -# not necessary on Windows but doesn't harm anything.
 -# see http://tech.stolsvik.com/2010/01/linux-java-thread-priorities-workar
 -$env:JVM_OPTS="$env:JVM_OPTS -XX:ThreadPriorityPolicy=42"
 -
 -$env:JVM_OPTS="$env:JVM_OPTS -XX:+HeapDumpOnOutOfMemoryError"
 -
  # stop the jvm on OutOfMemoryError as it can result in some data 
corruption
  # uncomment the preferred option
  # ExitOnOutOfMemoryError and CrashOnOutOfMemoryError require a JRE 
greater or equals to 1.7 update 101 or 1.8 update 92


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-14418) Cassandra not starting when using enhanced startup scripts in windows

2018-05-12 Thread Jason Brown (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14418:

Summary: Cassandra not starting when using enhanced startup scripts in 
windows  (was: Cassandra not getting started when using enhanced startup 
scripts in windows)

> Cassandra not starting when using enhanced startup scripts in windows
> -
>
> Key: CASSANDRA-14418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14418
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Shyam Phirke
>Assignee: Shyam Phirke
>Priority: Major
> Fix For: 3.11.x
>
>
> I am using Apache Cassandra 3.11.2 with my application. 
> My application is getting installed under C:/Program Files/My 
> Application/Some Folder/.
> And cassandra C:/Program Files/My Application/Some Folder/cassandra.
> So when I am using enhanced startup scripts cassandra not getting up and 
> running and I am getting below error:
> "Error: Could not find or load main class Files\My"
> One of the solution I got is moving cassandra to another location where 
> location path does not contain spaces. But this is not good way of getting 
> this problem resolved.
> After doing detailed analysis of all the scripts I found the solution below:
> Inside file cassandra-env.ps1 at line number 380:
> Replace line:
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
> with line
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
> Fix here is the double quotes added before $env:CASSANDRA_CONF and at the end.
> At other places this case is well handled. But missed at this place.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-14418) Cassandra not getting started when using enhanced startup scripts in windows

2018-05-12 Thread Jason Brown (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14418:

Reviewer: Jason Brown

> Cassandra not getting started when using enhanced startup scripts in windows
> 
>
> Key: CASSANDRA-14418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14418
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Shyam Phirke
>Assignee: Shyam Phirke
>Priority: Major
> Fix For: 3.11.x
>
>
> I am using Apache Cassandra 3.11.2 with my application. 
> My application is getting installed under C:/Program Files/My 
> Application/Some Folder/.
> And cassandra C:/Program Files/My Application/Some Folder/cassandra.
> So when I am using enhanced startup scripts cassandra not getting up and 
> running and I am getting below error:
> "Error: Could not find or load main class Files\My"
> One of the solution I got is moving cassandra to another location where 
> location path does not contain spaces. But this is not good way of getting 
> this problem resolved.
> After doing detailed analysis of all the scripts I found the solution below:
> Inside file cassandra-env.ps1 at line number 380:
> Replace line:
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
> with line
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
> Fix here is the double quotes added before $env:CASSANDRA_CONF and at the end.
> At other places this case is well handled. But missed at this place.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Assigned] (CASSANDRA-14418) Cassandra not getting started when using enhanced startup scripts in windows

2018-05-12 Thread Jason Brown (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown reassigned CASSANDRA-14418:
---

Assignee: Shyam Phirke

> Cassandra not getting started when using enhanced startup scripts in windows
> 
>
> Key: CASSANDRA-14418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14418
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Shyam Phirke
>Assignee: Shyam Phirke
>Priority: Major
> Fix For: 3.11.x
>
>
> I am using Apache Cassandra 3.11.2 with my application. 
> My application is getting installed under C:/Program Files/My 
> Application/Some Folder/.
> And cassandra C:/Program Files/My Application/Some Folder/cassandra.
> So when I am using enhanced startup scripts cassandra not getting up and 
> running and I am getting below error:
> "Error: Could not find or load main class Files\My"
> One of the solution I got is moving cassandra to another location where 
> location path does not contain spaces. But this is not good way of getting 
> this problem resolved.
> After doing detailed analysis of all the scripts I found the solution below:
> Inside file cassandra-env.ps1 at line number 380:
> Replace line:
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
> with line
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
> Fix here is the double quotes added before $env:CASSANDRA_CONF and at the end.
> At other places this case is well handled. But missed at this place.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14418) Cassandra not getting started when using enhanced startup scripts in windows

2018-05-12 Thread Dinesh Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472981#comment-16472981
 ] 

Dinesh Joshi commented on CASSANDRA-14418:
--

[~sphirke] [~jasobrown] Apologies for the delay. I have been busy. I can 
confirm that the fix works. It would be useful to double check if there are 
other places in the script where we may encounter similar issues.

> Cassandra not getting started when using enhanced startup scripts in windows
> 
>
> Key: CASSANDRA-14418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14418
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Shyam Phirke
>Priority: Major
> Fix For: 3.11.x
>
>
> I am using Apache Cassandra 3.11.2 with my application. 
> My application is getting installed under C:/Program Files/My 
> Application/Some Folder/.
> And cassandra C:/Program Files/My Application/Some Folder/cassandra.
> So when I am using enhanced startup scripts cassandra not getting up and 
> running and I am getting below error:
> "Error: Could not find or load main class Files\My"
> One of the solution I got is moving cassandra to another location where 
> location path does not contain spaces. But this is not good way of getting 
> this problem resolved.
> After doing detailed analysis of all the scripts I found the solution below:
> Inside file cassandra-env.ps1 at line number 380:
> Replace line:
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=$env:CASSANDRA_CONF\hotspot_compiler"
> with line
> $env:JVM_OPTS = "$env:JVM_OPTS 
> -XX:CompileCommandFile=""$env:CASSANDRA_CONF\hotspot_compiler"""
> Fix here is the double quotes added before $env:CASSANDRA_CONF and at the end.
> At other places this case is well handled. But missed at this place.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org