[jira] [Updated] (CASSANDRA-15392) Pool Merge Iterators
[ https://issues.apache.org/jira/browse/CASSANDRA-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan West updated CASSANDRA-15392: Reviewers: Benedict Elliott Smith, Jordan West (was: Benedict Elliott Smith) > Pool Merge Iterators > > > Key: CASSANDRA-15392 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15392 > Project: Cassandra > Issue Type: Sub-task > Components: Local/Compaction >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0 > > > By pooling merge iterators, instead of creating new ones each time we need > them, we can reduce garbage on the compaction and read paths under relevant > workloads by ~4% in many cases. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14721) sstabledump displays incorrect value for "position" key
[
https://issues.apache.org/jira/browse/CASSANDRA-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004854#comment-17004854
]
Michael Semb Wever edited comment on CASSANDRA-14721 at 12/29/19 6:17 PM:
--
||branch||circleci||asf jenkins testall||asf jenkins dtests||
|[cassandra-3.0_14721|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/36/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/36/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/709/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/709]|
|[cassandra-3.11_14721|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/37/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/37/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/710/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/710]|
|[trunk_14721|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/38/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/38/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/711/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/711]|
was (Author: michaelsembwever):
||branch||circleci||asf jenkins testall||asf jenkins dtests||
|[cassandra-3.0_14721|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/36/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/36/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/709/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/709]|
|[cassandra-3.11_14721|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/37/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/37/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/710/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/710]|
|[trunk_14721|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/38/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/38/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/711/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/711]|
> sstabledump displays incorrect value for "position" key
> ---
>
> Key: CASSANDRA-14721
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14721
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Damien Stevenson
>Assignee: Cameron Zemek
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: cassandra-dump.patch
>
>
> When partitions with multiple rows are displayed using sstabledump, the
> "position" value the first row of each partition is incorrect.
> For example:
> {code:java}
> sstabledump mc-1-big-Data.db
> [
> {
> "partition" : {
> "key" : [ "1", "24" ],
> "position" : 0
> },
> "rows" : [
> {
> "type" : "row",
> "position" : 66,
> "clustering" : [ "2013-12-10 00:00:00.000Z" ],
> "liveness_info" : { "tstamp" : "2018-09-12T05:01:09.290086Z"
[jira] [Commented] (CASSANDRA-14721) sstabledump displays incorrect value for "position" key
[
https://issues.apache.org/jira/browse/CASSANDRA-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004854#comment-17004854
]
Michael Semb Wever commented on CASSANDRA-14721:
||branch||circleci||asf jenkins testall||asf jenkins dtests||
|[cassandra-3.0_14721|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/36/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/36/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/709/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/709]|
|[cassandra-3.11_14721|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/37/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/37/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/710/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/710]|
|[trunk_14721|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_14721]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_14721]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/38/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/38/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/711/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/711]|
> sstabledump displays incorrect value for "position" key
> ---
>
> Key: CASSANDRA-14721
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14721
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Damien Stevenson
>Assignee: Cameron Zemek
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: cassandra-dump.patch
>
>
> When partitions with multiple rows are displayed using sstabledump, the
> "position" value the first row of each partition is incorrect.
> For example:
> {code:java}
> sstabledump mc-1-big-Data.db
> [
> {
> "partition" : {
> "key" : [ "1", "24" ],
> "position" : 0
> },
> "rows" : [
> {
> "type" : "row",
> "position" : 66,
> "clustering" : [ "2013-12-10 00:00:00.000Z" ],
> "liveness_info" : { "tstamp" : "2018-09-12T05:01:09.290086Z" },
> "cells" : [
> { "name" : "centigrade", "value" : 8 },
> { "name" : "chanceofrain", "value" : 0.1 },
> { "name" : "feelslike", "value" : 8 },
> { "name" : "humidity", "value" : 0.76 },
> { "name" : "wind", "value" : 10.0 }
> ]
> },
> {
> "type" : "row",
> "position" : 66,
> "clustering" : [ "2013-12-11 00:00:00.000Z" ],
> "liveness_info" : { "tstamp" : "2018-09-12T05:01:09.295369Z" },
> "cells" : [
> { "name" : "centigrade", "value" : 4 },
> { "name" : "chanceofrain", "value" : 0.3 },
> { "name" : "feelslike", "value" : 4 },
> { "name" : "humidity", "value" : 0.9 },
> { "name" : "wind", "value" : 12.0 }
> ]
> },
> {
> "type" : "row",
> "position" : 105,
> "clustering" : [ "2013-12-12 00:00:00.000Z" ],
> "liveness_info" : { "tstamp" : "2018-09-12T05:01:09.300841Z" },
> "cells" : [
> { "name" : "centigrade", "value" : 3 },
> { "name" : "chanceofrain", "value" : 0.2 },
> { "name" : "feelslike", "value" : 3 },
> { "name" : "humidity", "value" : 0.68 },
> { "name" : "wind", "value" : 6.0 }
> ]
> }
> ]
> }
> ]
> {code}
> The expected output is:
> {code:java}
> [
> {
> "partition" : {
> "key" : [ "1", "24" ],
> "position" : 0
> },
> "rows" : [
> {
> "type" : "row",
> "position" : 28,
> "clustering" : [ "2013-12-10 00:00:00.000Z" ],
> "liveness_info" : { "tstamp" : "2018-09-12T05:01:09.290086Z" },
> "cells" : [
> { "name" : "centigrade", "value" : 8 },
> { "name" : "chanceofrain", "value" : 0.1 },
> { "name" : "feelslike", "value" : 8 },
> { "name" : "humidity",
[jira] [Updated] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-14306: --- Status: Review In Progress (was: Changes Suggested) > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004843#comment-17004843 ] Michael Semb Wever commented on CASSANDRA-14306: Thanks [~polo-language], am taking a look now. It can be a bit overwhelming to ensure tickets are always tackled in the correct order, appreciate the new patches. > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004830#comment-17004830 ] Angelo Polo commented on CASSANDRA-14306: - This issue predates 15090, so it was just a different choice of name for the same concept. I've attached two updated patches (of conf/cassandra-env.sh only) for the GC logs. These use the now-committed variable name CASSANDRA_LOG_DIR. * [^unified_logs_dir_v2_trunk.patch] * [^unified_logs_dir_v2_3.11.patch] > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angelo Polo updated CASSANDRA-14306: Attachment: unified_logs_dir_v2_trunk.patch unified_logs_dir_v2_3.11.patch > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-14306: --- Status: Changes Suggested (was: Review In Progress) > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[
https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004724#comment-17004724
]
Michael Semb Wever commented on CASSANDRA-14306:
In the {{bin/cassandra}} file what's the difference between the
{{CASSANDRA_LOG_DIR}} and {{CASSANDRA_LOGS}} variables?
IE why are we introducing the second? Maybe this can all be standardised just
using the existing {{CASSANDRA_LOG_DIR}} variable?
> Single config variable to specify logs path
> ---
>
> Key: CASSANDRA-14306
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14306
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Angelo Polo
>Priority: Low
> Attachments: unified_logs_dir.patch
>
>
> Motivation: All configuration should take place in bin/cassandra.in.sh (for
> non-Windows) and the various conf/ files. In particular, bin/cassandra should
> not need to be modified upon installation. In many installs, $CASSANDRA_HOME
> is not a writable location, the yaml setting 'data_file_directories' is being
> set to a non-default location, etc. It would be good to have a single
> variable in an explicit conf file to specify where logs should be written.
> For non-Windows installs, there are currently two places where the log
> directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults
> for these are both $CASSANDRA_HOME/logs. These can be unified to a single
> variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the
> intention that it would be modified once there (if not set in the
> environment) by a user running a custom installation. Then include a check in
> bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh
> doesn't get sourced on startup, and provide a default value if not. For the
> scenario that a user would prefer different paths for the logback logs and
> the GC logs, they can still go into bin/cassandra to set the second path,
> just as they would do currently. See "unified_logs_dir.patch" for a proposed
> patch.
> No change seems necessary for the Windows scripts. The two uses of
> $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within
> scrolling distance of each other (lines 278-301). They haven't been combined
> I suppose because of the different path separators in the two usages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
