[jira] [Created] (CASSANDRA-15590) Upgrade io.netty_netty-all dependency to fix security vulnerabilities
Vishwas Vijaya Kumar created CASSANDRA-15590: Summary: Upgrade io.netty_netty-all dependency to fix security vulnerabilities Key: CASSANDRA-15590 URL: https://issues.apache.org/jira/browse/CASSANDRA-15590 Project: Cassandra Issue Type: Task Components: Dependencies Reporter: Vishwas Vijaya Kumar Upgrade io.netty_netty-all dependency to fix the following CVEs: * [CVE-2019-20444|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-20444] * [CVE-2019-20445|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-20445] * [CVE-2019-16869|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-16869] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15589) Add histogram to prepared statements and expose as virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-15589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039630#comment-17039630 ] Chris Lohfink commented on CASSANDRA-15589: --- this would give you a history of which ones are the worst. the queries virtual table are the _currently running_ queries only. > Add histogram to prepared statements and expose as virtual table > - > > Key: CASSANDRA-15589 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15589 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Priority: Normal > > One of the biggest challenges as an operator is understanding what queries > are being executed and how long they take. We have the ability to take short > samples via profileload, but it’s lacking the full diagnostics that keeping > histograms on each prepared statement could give us. Having this would be a > massive benefit to most operators as they currently have no idea what > Cassandra is actually doing. > Before committing let’s be sure to record some CPU flame graphs to ensure > there isn’t noticeable performance overhead. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15589) Add histogram to prepared statements and expose as virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-15589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15589: -- Change Category: Operability Complexity: Normal Status: Open (was: Triage Needed) > Add histogram to prepared statements and expose as virtual table > - > > Key: CASSANDRA-15589 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15589 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Priority: Normal > > One of the biggest challenges as an operator is understanding what queries > are being executed and how long they take. We have the ability to take short > samples via profileload, but it’s lacking the full diagnostics that keeping > histograms on each prepared statement could give us. Having this would be a > massive benefit to most operators as they currently have no idea what > Cassandra is actually doing. > Before committing let’s be sure to record some CPU flame graphs to ensure > there isn’t noticeable performance overhead. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15589) Add histogram to prepared statements and expose as virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-15589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039626#comment-17039626 ] David Capwell commented on CASSANDRA-15589: --- bq. keeping histograms on each prepared statement could give us Is the main difference stats on how the query performed? If so what stats? > Add histogram to prepared statements and expose as virtual table > - > > Key: CASSANDRA-15589 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15589 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Priority: Normal > > One of the biggest challenges as an operator is understanding what queries > are being executed and how long they take. We have the ability to take short > samples via profileload, but it’s lacking the full diagnostics that keeping > histograms on each prepared statement could give us. Having this would be a > massive benefit to most operators as they currently have no idea what > Cassandra is actually doing. > Before committing let’s be sure to record some CPU flame graphs to ensure > there isn’t noticeable performance overhead. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15589) Add histogram to prepared statements and expose as virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-15589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039624#comment-17039624 ] David Capwell commented on CASSANDRA-15589: --- [~rustyrazorblade] [~cnlwsu] how does this relate to https://issues.apache.org/jira/browse/CASSANDRA-15241 > Add histogram to prepared statements and expose as virtual table > - > > Key: CASSANDRA-15589 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15589 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Priority: Normal > > One of the biggest challenges as an operator is understanding what queries > are being executed and how long they take. We have the ability to take short > samples via profileload, but it’s lacking the full diagnostics that keeping > histograms on each prepared statement could give us. Having this would be a > massive benefit to most operators as they currently have no idea what > Cassandra is actually doing. > Before committing let’s be sure to record some CPU flame graphs to ensure > there isn’t noticeable performance overhead. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15241) Virtual table to expose current running queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Lohfink reassigned CASSANDRA-15241:
-
Assignee: Chris Lohfink (was: Chris Lohfink)
> Virtual table to expose current running queries
> ---
>
> Key: CASSANDRA-15241
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15241
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Virtual Tables
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Normal
>
> Expose current running queries and their duration.
> {code}cqlsh> select * from system_views.queries;
> thread_id| duration_micros | task
> --+-+-
> Native-Transport-Requests-17 |6325 | QUERY
> select * from system_views.queries; [pageSize = 100]
> Native-Transport-Requests-4 | 14681 | EXECUTE
> f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE
> Native-Transport-Requests-6 | 14678 | EXECUTE
> f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE
> ReadStage-10 | 16535 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-13 | 16535 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-14 | 16535 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-19 | 11861 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-20 | 11861 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-22 |7279 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-23 |4716 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-5 | 16535 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-7 | 16535 |
>SELECT * FROM basic.wide1 LIMIT 5000
> ReadStage-8 | 16535 |
>SELECT * FROM basic.wide1 LIMIT 5000{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15589) Add histogram to prepared statements and expose as virtual table
Jon Haddad created CASSANDRA-15589: -- Summary: Add histogram to prepared statements and expose as virtual table Key: CASSANDRA-15589 URL: https://issues.apache.org/jira/browse/CASSANDRA-15589 Project: Cassandra Issue Type: Improvement Components: Observability/Metrics Reporter: Jon Haddad One of the biggest challenges as an operator is understanding what queries are being executed and how long they take. We have the ability to take short samples via profileload, but it’s lacking the full diagnostics that keeping histograms on each prepared statement could give us. Having this would be a massive benefit to most operators as they currently have no idea what Cassandra is actually doing. Before committing let’s be sure to record some CPU flame graphs to ensure there isn’t noticeable performance overhead. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-6822) Never ending batch replay after dropping column family
[ https://issues.apache.org/jira/browse/CASSANDRA-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039598#comment-17039598 ] Surbhi Gupta commented on CASSANDRA-6822: - Yes, we saw the same issue in 3.11 when we had to drop a Materialized view . After dropping materialized view our whole cluster became unstable and nodes were showing down from each other. > Never ending batch replay after dropping column family > -- > > Key: CASSANDRA-6822 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6822 > Project: Cassandra > Issue Type: Bug > Environment: Cassandra 2.0.5 >Reporter: Duncan Sands >Assignee: Aleksey Yeschenko >Priority: Normal > Fix For: 1.2.17, 2.0.7, 2.1 beta2 > > Attachments: 6822.txt > > > After dropping a column family, I got an infinite number of messages like > this: > WARN [BatchlogTasks:1] 2014-03-07 17:50:08,962 BatchlogManager.java (line > 235) Skipped batch replay of bc3916e0-a533-11e3-9c41-55f381b5 due to > org.apache.cassandra.db.UnknownColumnFamilyException: Couldn't find > cfId=2fdad07d-0cc3-373a-8aa0-15837cd9bc6c > I say an infinite number but I only waited about 12 hours before I decided I > had had enough and truncated system.batchlog. So perhaps it would have gone > away by itself. > Presumably the batch replay is skipped but not discarded, so will keep on > turning up forever. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15573) Python 3.8 fails to execute cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039583#comment-17039583
]
Dinesh Joshi commented on CASSANDRA-15573:
--
Circling back once more, this is again due to the missing version check in the
DOS Batch file ({{cqlsh.bat}}) and doesn't affect Linux-like systems.
> Python 3.8 fails to execute cqlsh
> -
>
> Key: CASSANDRA-15573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15573
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Yuki Morishita
>Priority: Normal
>
> Python 3.8 renamed sre_parse.Pattern to sre_parse.State (see
> https://bugs.python.org/issue34681 and corresponding pull request
> https://github.com/python/cpython/pull/9310)
> So when executing cqlsh with Python 3.8, it throws error:
> {code}
> Traceback (most recent call last):
> File ".\bin\cqlsh.py", line 175, in
> from cqlshlib import cql3handling, cqlhandling, pylexotron, sslhandling,
> cqlshhandling
> File "C:\Users\Yuki
> Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\cql3handling.py", line 19,
> in
> from cqlshlib.cqlhandling import CqlParsingRuleSet, Hint
> File "C:\Users\Yuki
> Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\cqlhandling.py", line 23,
> in
> from cqlshlib import pylexotron, util
> File "C:\Users\Yuki
> Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\pylexotron.py", line 342,
> in
> class ParsingRuleSet:
> File "C:\Users\Yuki
> Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\pylexotron.py", line 343,
> in ParsingRuleSet
> RuleSpecScanner = SaferScanner([
> File "C:\Users\Yuki
> Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\saferscanner.py", line 74,
> in __init__
> s = re.sre_parse.Pattern()
> AttributeError: module 'sre_parse' has no attribute 'Pattern'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15572) `object of type 'NoneType' has no len()` error in cqlsh with python 3
[
https://issues.apache.org/jira/browse/CASSANDRA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039581#comment-17039581
]
Dinesh Joshi commented on CASSANDRA-15572:
--
Yuki, there is a version check in the shell script. However, looks like that
check doesn't exist on Windows. So folks with access to a bash shell will not
see this issue. However you'll see it on Windows. Do you want to add the
version check to {{cqlsh.bat}} as part of your patch? I am not uptodate with
DOS batch file programming ;).
> `object of type 'NoneType' has no len()` error in cqlsh with python 3
> -
>
> Key: CASSANDRA-15572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15572
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Yuki Morishita
>Assignee: Yuki Morishita
>Priority: Normal
>
> Looks like in Python 3, webbrowser._tryorder can be NoneType and throw error
> like below:
> {code}
> Traceback (most recent call last):
> File ".\bin\cqlsh.py", line 99, in
> if len(webbrowser._tryorder) == 0:
> TypeError: object of type 'NoneType' has no len()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15483) Overview
[ https://issues.apache.org/jira/browse/CASSANDRA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15483: --- Fix Version/s: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/0bae5eaeccbadf27f233e50d63dc85de534e6b49 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as 0bae5eaeccbadf27f233e50d63dc85de534e6b49, thanks! > Overview > > > Key: CASSANDRA-15483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15483 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > Fix For: 4.0-alpha > > > Added page on Overview. > https://github.com/apache/cassandra/pull/412 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (44eb173 -> 0bae5ea)
This is an automated email from the ASF dual-hosted git repository. rustyrazorblade pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 44eb173 Added CDC and speculative retry documentation to DDL section. add 0bae5ea Updated overview documentation. No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + doc/source/architecture/overview.rst | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15483) Overview
[ https://issues.apache.org/jira/browse/CASSANDRA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15483: --- Status: Ready to Commit (was: Review In Progress) > Overview > > > Key: CASSANDRA-15483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15483 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added page on Overview. > https://github.com/apache/cassandra/pull/412 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15483) Overview
[ https://issues.apache.org/jira/browse/CASSANDRA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15483: --- Reviewers: Jon Haddad, Jon Haddad (was: Jon Haddad) Jon Haddad, Jon Haddad (was: Jon Haddad) Status: Review In Progress (was: Patch Available) > Overview > > > Key: CASSANDRA-15483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15483 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added page on Overview. > https://github.com/apache/cassandra/pull/412 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15338) Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039510#comment-17039510
]
Yifan Cai commented on CASSANDRA-15338:
---
The test failure reported here is caused by the flaky
{{testAcquireReleaseOutbound}} in CASSANDRA-15308.
After fixing {{testAcquireReleaseOutbound}}, all tests in {{ConnectionTest}}
can pass happily.
The repeated local runs of {{ConnectionTest}} using either Java 8 and 11 proved
the test failure as described in this ticket did not show up.
{code:java}
Switched to Java 8
12:42:00 in cassandra on CASSANDRA-15308
➜ while [[ "$(ant testclasslist -Dtest.classlistfile=<(echo
org/apache/cassandra/net/ConnectionTest.java) | grep -c 'BUILD SUCCESSFUL')" ==
"1" ]]; do echo "It was a good run."; done
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
^C%
13:10:47 in cassandra on CASSANDRA-15308 took 28m 39s
➜ j11
Switched to Java 11
13:10:49 in cassandra on CASSANDRA-15308
➜ while [[ "$(ant testclasslist -Dtest.classlistfile=<(echo
org/apache/cassandra/net/ConnectionTest.java) -Duse.jdk11=true | grep -c 'BUILD
SUCCESSFUL')" == "1" ]]; do echo "It was a good run."; done
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
It was a good run.
^C%
{code}
> Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
> ---
>
> Key: CASSANDRA-15338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15338
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example failure:
> [https://circleci.com/gh/dcapwell/cassandra/11#artifacts/containers/1]
>
> {code:java}
> Testcase: testMessagePurging(org.apache.cassandra.net.ConnectionTest): FAILED
> expected:<0> but was:<1>
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.net.ConnectionTest.lambda$testMessagePurging$38(ConnectionTest.java:625)
> at
> org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:258)
> at
> org.apache.cassandra.net.ConnectionTest.testManual(ConnectionTest.java:231)
> at
> org.apache.cassandra.net.ConnectionTest.testMessagePurging(ConnectionTest.java:584){code}
>
> Looking closer at
> org.apache.cassandra.net.OutboundConnection.Delivery#stopAndRun it seems that
> the run method is called before
> org.apache.cassandra.net.OutboundConnection.Delivery#doRun which may lead to
> a test race condition where the CountDownLatch completes before executing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039496#comment-17039496
]
David Capwell commented on CASSANDRA-15557:
---
I am hesitant to say to close since the type of error is data correctness; if
this was a time out I would be fine closing if stable so frequently.
The other annoying thing is nothing stands out in the logs
https://482-209217594-gh.circle-artifacts.com/1/logs/TEST-org.apache.cassandra.cql3.validation.operations.AlterTest.log.
We don't log the select so hard to say what happened before and after that
block (even if we did timing isn't perfect). Also when I search for
cql_test_keyspace.table_11 I see that we didn't flush the table, so this should
be local to memtable and not sstable.
> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest
> testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-15557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2
> (mycollection of type list), expected but got <[first element]>
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15213:
Status: Ready to Commit (was: Review In Progress)
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15213:
Test and Documentation Plan: Existing microbenchmarks, new cluster
benchmarks, quick theories tests
Status: Patch Available (was: Open)
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15213:
Reviewers: Benedict Elliott Smith, Jordan West (was: Chris Lohfink)
Status: Review In Progress (was: Patch Available)
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15367) Memtable memory allocations may deadlock
[
https://issues.apache.org/jira/browse/CASSANDRA-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039466#comment-17039466
]
Blake Eggleston commented on CASSANDRA-15367:
-
{quote}how you think the deadlock occurs
{quote}
It may be the same one you're referring to. Basically if a write blocks trying
to acquire the lock on the new memtable after the final commit log position is
set and before the write barrier is issued, there's a risk of deadlock.
Given op groups O1 & O2, replay positions R1 & R2, and memtables M1 & M2. M1 is
flushing with a barrier on O1, and final commit log upper bound R1 is set on
it. A new write (W1) is assigned to O1, and writes to the commit log at
position R2. It will overflow to M2, the new memtable. Before the barrier is
set on it, it blocks on a locked partition. Write W2 against O2 then acquires
the lock ahead of W1, blocks on the allocator, and we deadlock.
{quote}So, I propose a variant of my earlier approach that definitely worked
{quote}
Great, as far as I can tell, this fixes the deadlock 100% and with minimal risk
of adding new issues or disrupting system behavior. +1
> Memtable memory allocations may deadlock
>
>
> Key: CASSANDRA-15367
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15367
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log, Local/Memtable
>Reporter: Benedict Elliott Smith
>Assignee: Benedict Elliott Smith
>Priority: Normal
> Fix For: 4.0, 2.2.x, 3.0.x, 3.11.x
>
>
> * Under heavy contention, we guard modifications to a partition with a mutex,
> for the lifetime of the memtable.
> * Memtables block for the completion of all {{OpOrder.Group}} started before
> their flush began
> * Memtables permit operations from this cohort to fall-through to the
> following Memtable, in order to guarantee a precise commitLogUpperBound
> * Memtable memory limits may be lifted for operations in the first cohort,
> since they block flush (and hence block future memory allocation)
> With very unfortunate scheduling
> * A contended partition may rapidly escalate to a mutex
> * The system may reach memory limits that prevent allocations for the new
> Memtable’s cohort (C2)
> * An operation from C2 may hold the mutex when this occurs
> * Operations from a prior Memtable’s cohort (C1), for a contended partition,
> may fall-through to the next Memtable
> * The operations from C1 may execute after the above is encountered by those
> from C2
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9064) [LeveledCompactionStrategy] cqlsh can't run cql produced by its own describe table statement
[
https://issues.apache.org/jira/browse/CASSANDRA-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRA-9064:
--
Labels: cqlsh pull-request-available (was: cqlsh)
> [LeveledCompactionStrategy] cqlsh can't run cql produced by its own describe
> table statement
>
>
> Key: CASSANDRA-9064
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9064
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
> Environment: cassandra 2.1.3 on mac os x
>Reporter: Sujeet Gholap
>Assignee: Benjamin Lerer
>Priority: Normal
> Labels: cqlsh, pull-request-available
> Fix For: 2.1.8, 2.2.0 rc2
>
>
> Here's how to reproduce:
> 1) Create a table with LeveledCompactionStrategy
> CREATE keyspace foo WITH REPLICATION = {'class': 'SimpleStrategy',
> 'replication_factor' : 3};
> CREATE TABLE foo.bar (
> spam text PRIMARY KEY
> ) WITH compaction = {'class': 'LeveledCompactionStrategy'};
> 2) Describe the table and save the output
> cqlsh -e "describe table foo.bar"
> Output should be something like
> CREATE TABLE foo.bar (
> spam text PRIMARY KEY
> ) WITH bloom_filter_fp_chance = 0.1
> AND caching = '{"keys":"ALL", "rows_per_partition":"NONE"}'
> AND comment = ''
> AND compaction = {'min_threshold': '4', 'class':
> 'org.apache.cassandra.db.compaction.LeveledCompactionStrategy',
> 'max_threshold': '32'}
> AND compression = {'sstable_compression':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99.0PERCENTILE';
> 3) Save the output to repro.cql
> 4) Drop the table foo.bar
> cqlsh -e "drop table foo.bar"
> 5) Run the create table statement we saved
> cqlsh -f "repro.cql"
> 6) Expected: normal execution without an error
> 7) Reality:
> ConfigurationException: configuration issue] message="Properties specified [min_threshold,
> max_threshold] are not understood by LeveledCompactionStrategy">
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039461#comment-17039461 ] David Capwell commented on CASSANDRA-13158: --- thanks! Looking at the file I don't see -Dcassandra.partitioner= showing up, so only makes sense if it throws. We should improve the logic so we know what the root cause is > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > Attachments: error.txt > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15492) DDL update
[ https://issues.apache.org/jira/browse/CASSANDRA-15492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15492: --- Fix Version/s: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/44eb173245c2644fc3ef76115bcf4123c14a1655 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as 44eb173245c2644fc3ef76115bcf4123c14a1655, thanks! > DDL update > -- > > Key: CASSANDRA-15492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15492 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > Fix For: 4.0-alpha > > > - Added more detail and examples to some sections such as Speculative retry > - Added table option 'cdc' > https://github.com/apache/cassandra/pull/420 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (4e0fccc -> 44eb173)
This is an automated email from the ASF dual-hosted git repository. rustyrazorblade pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 4e0fccc Fix missing Keyspaces in cqlsh describe output add 44eb173 Added CDC and speculative retry documentation to DDL section. No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + doc/source/cql/ddl.rst | 100 doc/source/new/Figure_1.jpg | Bin 0 -> 27827 bytes doc/source/new/Figure_2.jpg | Bin 0 -> 36650 bytes 4 files changed, 83 insertions(+), 18 deletions(-) create mode 100644 doc/source/new/Figure_1.jpg create mode 100644 doc/source/new/Figure_2.jpg - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15492) DDL update
[ https://issues.apache.org/jira/browse/CASSANDRA-15492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15492: --- Status: Ready to Commit (was: Review In Progress) > DDL update > -- > > Key: CASSANDRA-15492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15492 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > - Added more detail and examples to some sections such as Speculative retry > - Added table option 'cdc' > https://github.com/apache/cassandra/pull/420 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15492) DDL update
[ https://issues.apache.org/jira/browse/CASSANDRA-15492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15492: --- Reviewers: Jon Haddad, Jon Haddad (was: Jon Haddad) Jon Haddad, Jon Haddad (was: Jon Haddad) Status: Review In Progress (was: Patch Available) > DDL update > -- > > Key: CASSANDRA-15492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15492 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > - Added more detail and examples to some sections such as Speculative retry > - Added table option 'cdc' > https://github.com/apache/cassandra/pull/420 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch master updated: Update ASF-slaves.txt
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git The following commit(s) were added to refs/heads/master by this push: new c4df9d4 Update ASF-slaves.txt c4df9d4 is described below commit c4df9d498acf5b2d3db74e5574a44da6c132ff34 Author: Michael Shuler AuthorDate: Tue Feb 18 14:24:34 2020 -0600 Update ASF-slaves.txt --- ASF-slaves.txt | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/ASF-slaves.txt b/ASF-slaves.txt index aa68ebe..d9ae4cd 100644 --- a/ASF-slaves.txt +++ b/ASF-slaves.txt @@ -29,17 +29,10 @@ Add ssh pub key from puppet deployment repo: -ONLINE Slaves: +Slaves for build.apache.org: 'cassandra' label slaves (16G RAM) -OFFLINE - cassandra1 - 163.172.83.157 - Ubuntu 16.04 LTS amd64, 16G RAM, donated by Datastax -OFFLINE - cassandra2 - 163.172.83.159 - Ubuntu 16.04 LTS amd64, 16G RAM, donated by Datastax -OFFLINE - cassandra3 - 163.172.83.161 - Ubuntu 16.04 LTS amd64, 16G RAM, donated by Datastax -OFFLINE - cassandra4 - 163.172.83.163 - Ubuntu 16.04 LTS amd64, 16G RAM, donated by Datastax -OFFLINE - cassandra5 - 163.172.83.175 - Ubuntu 16.04 LTS amd64, 16G RAM, donated by Datastax -OFFLINE - cassandra6 - 163.172.71.128 - Ubuntu 16.04 LTS amd64, 32G RAM, donated by Datastax -OFFLINE - cassandra7 - 163.172.71.129 - Ubuntu 16.04 LTS amd64, 32G RAM, donated by Datastax cassandra8 - 35.160.175.252 - Ubuntu 16.04 LTS amd64, 16G RAM, 4 cores, donated by instaclustr cassandra9 - 34.210.158.175 - Ubuntu 16.04 LTS amd64, 16G RAM, 4 cores, donated by instaclustr cassandra10 - 35.165.114.131 - Ubuntu 16.04 LTS amd64, 16G RAM, 4 cores, donated by instaclustr @@ -52,10 +45,23 @@ cassandra16 - 54.148.184.162 - Ubuntu 16.04 LTS amd64, 16G RAM, 4 cores, donated +Slaves for ci-cassandra.apache.org: + +'cassandra' label slaves (32G RAM) (IN PROGRESS: INFRA-19867) + +cassandra1 - 163.172.73.141 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax +cassandra2 - 163.172.73.156 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax +cassandra3 - 163.172.4.20 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax +cassandra4 - 163.172.4.140 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax +cassandra5 - 163.172.4.150 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax +cassandra6 - 163.172.4.175 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax +cassandra7 - 163.172.4.184 - Ubuntu 18.04 LTS amd64, 32G RAM, donated by Datastax + + + Contacts for system donators, when console hands may be needed by INFRA: Datastax: Joshua McKenzie -alternative group list: cassandra...@datastax.com Instaclustr: Ben Bromhead alternative group list: ad...@instaclustr.com - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039394#comment-17039394 ] Stefan Miklosovic edited comment on CASSANDRA-13158 at 2/18/20 7:35 PM: I uploaded error.txt file. this cassandra.config.loader = com.instaclustr.cassandra.k8s.ConcatenatedYamlConfigurationLoader is this: [https://github.com/instaclustr/cassandra-operator/blob/master/java/cassandra-4-k8s-addons/src/main/java/com/instaclustr/cassandra/k8s/ConcatenatedYamlConfigurationLoader.java] It basically just concatenates yaml fragments from multiple files into one file. I do not want to go into this here (if it is not important). >From the console output I see it is using Murmur partitioner. was (Author: stefan.miklosovic): I uploaded error.txt file. this cassandra.config.loader = com.instaclustr.cassandra.k8s.ConcatenatedYamlConfigurationLoader is this: [https://github.com/instaclustr/cassandra-operator/blob/master/java/cassandra-4-k8s-addons/src/main/java/com/instaclustr/cassandra/k8s/ConcatenatedYamlConfigurationLoader.java] It basically just concatenates yaml fragments from multiple files into one file. I do not want to go into this here (if it is not important). > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > Attachments: error.txt > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15576: - Since Version: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/4e0fccc3ed1fded5ad72dfdfcad37a5ccdfc9a24 Resolution: Fixed Status: Resolved (was: Ready to Commit) Thanks [~rustyrazorblade] and [~dcapwell]. Committed to both [cassandra|https://github.com/apache/cassandra/commit/4e0fccc3ed1fded5ad72dfdfcad37a5ccdfc9a24] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/467192eb1e5b350e8b89009884b7c1acf9501470]. > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039394#comment-17039394 ] Stefan Miklosovic commented on CASSANDRA-13158: --- I uploaded error.txt file. this cassandra.config.loader = com.instaclustr.cassandra.k8s.ConcatenatedYamlConfigurationLoader is this: [https://github.com/instaclustr/cassandra-operator/blob/master/java/cassandra-4-k8s-addons/src/main/java/com/instaclustr/cassandra/k8s/ConcatenatedYamlConfigurationLoader.java] It basically just concatenates yaml fragments from multiple files into one file. I do not want to go into this here (if it is not important). > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > Attachments: error.txt > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15576: - Status: Ready to Commit (was: Review In Progress) > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (d979836 -> 4e0fccc)
This is an automated email from the ASF dual-hosted git repository. djoshi pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from d979836 Fix multi DC nodetool status output add 4e0fccc Fix missing Keyspaces in cqlsh describe output No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + bin/cqlsh.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch master updated: Add test to ensure default keyspaces are present in cqlsh output
This is an automated email from the ASF dual-hosted git repository.
djoshi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/master by this push:
new 467192e Add test to ensure default keyspaces are present in cqlsh
output
467192e is described below
commit 467192eb1e5b350e8b89009884b7c1acf9501470
Author: Dinesh A. Joshi
AuthorDate: Mon Feb 17 16:39:32 2020 -0800
Add test to ensure default keyspaces are present in cqlsh output
Patch by Dinesh Joshi; reviewed by Jon Haddad and David Capwell for
CASSANDRA-15576
---
cqlsh_tests/test_cqlsh.py | 21 +
1 file changed, 21 insertions(+)
diff --git a/cqlsh_tests/test_cqlsh.py b/cqlsh_tests/test_cqlsh.py
index c9a11e2..ed93d9d 100644
--- a/cqlsh_tests/test_cqlsh.py
+++ b/cqlsh_tests/test_cqlsh.py
@@ -879,6 +879,27 @@ CREATE AGGREGATE test.average(int)
# describe aggregate functions
self.execute(cql='DESCRIBE AGGREGATE test.average',
expected_output=describe_aggregate_expected)
+@since('4.0')
+def test_default_keyspaces_exist(self):
+self.cluster.populate(1)
+self.cluster.start(wait_for_binary_proto=True)
+node1, = self.cluster.nodelist()
+
+# Describe keyspaces
+expected_keyspaces = ['system_schema', 'system', 'system_traces',
'system_views',
+ 'system_auth', 'system_distributed',
'system_virtual_schema']
+
+node1, = self.cluster.nodelist()
+output, err = self.run_cqlsh(node1, "DESCRIBE KEYSPACES")
+
+if err:
+assert False, err
+
+stripped_response = re.sub("(\n|\t|\s+)", " ", output).strip()
+keyspaces = stripped_response.split(" ")
+
+assert sorted(keyspaces) == sorted(expected_keyspaces)
+
def test_describe_types(self):
"""Test DESCRIBE statements for user defined datatypes"""
self.cluster.populate(1)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-13158: -- Attachment: error.txt > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > Attachments: error.txt > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039382#comment-17039382 ] David Capwell commented on CASSANDRA-15576: --- +1 to the test I am ok closing this and having CASSANDRA-14872 fix this issue. > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039366#comment-17039366 ] Brandon Williams edited comment on CASSANDRA-13158 at 2/18/20 7:11 PM: --- You could also probably just change the partitioner in the yaml. Can you also show us your yaml, [~stefan.miklosovic]? was (Author: brandon.williams): You could also probably copy sstables from a cluster with a different partitioner. > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039369#comment-17039369
]
David Capwell commented on CASSANDRA-15557:
---
Don't have a lot of history on trunk in CI, but of the history I can look at I
have not seen it fail normally; the only sample I see is that Circle CI run.
Here is the test in question
{code}
@Test
public void testDropListAndAddListWithSameName() throws Throwable
{
createTable("CREATE TABLE %s (id text PRIMARY KEY, content text,
myCollection list);");
execute("INSERT INTO %s (id, content , myCollection) VALUES ('test',
'first test', ['first element']);");
execute("ALTER TABLE %s DROP myCollection;");
execute("ALTER TABLE %s ADD myCollection list;");
assertRows(execute("SELECT * FROM %s;"), row("test", "first test",
null));
execute("UPDATE %s set myCollection = ['second element'] WHERE id =
'test';");
assertRows(execute("SELECT * FROM %s;"), row("test", "first test",
list("second element")));
}
{code}
> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest
> testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-15557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2
> (mycollection of type list), expected but got <[first element]>
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039366#comment-17039366 ] Brandon Williams commented on CASSANDRA-13158: -- You could also probably copy sstables from a cluster with a different partitioner. > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[
https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039359#comment-17039359
]
David Capwell commented on CASSANDRA-13158:
---
[~stefan.miklosovic] could you run the following
{code}
JVM_OPTS='-XshowSettings:properties' ./bin/nodetool cleanup system_distributed
{code}
I can only replicate this if the system property is set; that will print out
all system properties
> Nodetool cleanup throwing exception
> ---
>
> Key: CASSANDRA-13158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13158
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Environment: Fedora 25 x86
>Reporter: Tomas Repik
>Assignee: Eduard Tudenhoefner
>Priority: Normal
> Fix For: 4.0
>
>
> After running nodetool cleanup I get this exception:
> error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner
> -- StackTrace --
> org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner
> class org.apache.cassandra.dht.Murmur3Partitioner
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383)
> at
> org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125)
> at
> org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84)
> at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411)
> at
> org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240)
> at
> org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88)
> at org.apache.cassandra.config.Schema.(Schema.java:107)
> at org.apache.cassandra.config.Schema.(Schema.java:55)
> at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50)
> at
> org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251)
> at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039346#comment-17039346 ] David Capwell commented on CASSANDRA-13158: --- bq. Too bad that we are not propagaing underlying exception in that first ConfigurationException throw ... fully agree with that! > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[
https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039345#comment-17039345
]
David Capwell commented on CASSANDRA-13158:
---
Thanks [~stefan.miklosovic] for the new stack trace!
Yeah, that looks weird. I can only replicate it doing the following
{code}
$ ./bin/nodetool cleanup system_distributed
$ JAVA_TOOL_OPTIONS='-Dcassandra.partitioner=mwhahaha' ./bin/nodetool cleanup
system_distributed
Picked up JAVA_TOOL_OPTIONS: -Dcassandra.partitioner=mwhahaha
error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner
-- StackTrace --
org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner
class org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.config.DatabaseDescriptor.applyPartitioner(DatabaseDescriptor.java:1117)
at
org.apache.cassandra.config.DatabaseDescriptor.toolInitialization(DatabaseDescriptor.java:218)
at
org.apache.cassandra.config.DatabaseDescriptor.toolInitialization(DatabaseDescriptor.java:185)
at org.apache.cassandra.tools.NodeProbe.checkJobs(NodeProbe.java:291)
at
org.apache.cassandra.tools.NodeProbe.forceKeyspaceCleanup(NodeProbe.java:298)
at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:55)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:341)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.accept(NodeTool.java:326)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.accept(NodeTool.java:300)
at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:237)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:84)
{code}
The other bad part is that the root exception is dropped it looks very
misleading.
> Nodetool cleanup throwing exception
> ---
>
> Key: CASSANDRA-13158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13158
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Environment: Fedora 25 x86
>Reporter: Tomas Repik
>Assignee: Eduard Tudenhoefner
>Priority: Normal
> Fix For: 4.0
>
>
> After running nodetool cleanup I get this exception:
> error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner
> -- StackTrace --
> org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner
> class org.apache.cassandra.dht.Murmur3Partitioner
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383)
> at
> org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125)
> at
> org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84)
> at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411)
> at
> org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240)
> at
> org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88)
> at org.apache.cassandra.config.Schema.(Schema.java:107)
> at org.apache.cassandra.config.Schema.(Schema.java:55)
> at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50)
> at
> org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251)
> at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[
https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039343#comment-17039343
]
Stefan Miklosovic commented on CASSANDRA-13158:
---
I followed the code code and quickly ...
{code:java}
// definitely not safe for tools + clients - implicitly instantiates schema
public static void applyPartitioner()
{
/* Hashing strategy */
if (conf.partitioner == null)
{
throw new ConfigurationException("Missing directive: partitioner",
false);
}
try
{
partitioner =
FBUtilities.newPartitioner(System.getProperty(Config.PROPERTY_PREFIX +
"partitioner", conf.partitioner));
}
catch (Exception e)
{
// IT THROWS THIS so try is bad
throw new ConfigurationException("Invalid partitioner class " +
conf.partitioner, false);
}
paritionerName = partitioner.getClass().getCanonicalName();
}
{code}
newPartitioner in FBUtilities does this:
{code:java}
static IPartitioner newPartitioner(String partitionerClassName,
Optional> comparator) throws ConfigurationException
{
if (!partitionerClassName.contains("."))
partitionerClassName = "org.apache.cassandra.dht." +
partitionerClassName;
if
(partitionerClassName.equals("org.apache.cassandra.dht.LocalPartitioner"))
{
assert comparator.isPresent() : "Expected a comparator for local
partitioner";
return new LocalPartitioner(comparator.get());
}
return FBUtilities.instanceOrConstruct(partitionerClassName, "partitioner");
}
{code}
Hence finally, it constructs it like this:
{code:java}
public static T instanceOrConstruct(String classname, String readable)
throws ConfigurationException
{
Class cls = FBUtilities.classForName(classname, readable);
try
{
Field instance = cls.getField("instance");
return cls.cast(instance.get(null));
}
catch (NoSuchFieldException | SecurityException | IllegalArgumentException
| IllegalAccessException e)
{
// Could not get instance field. Try instantiating.
return construct(cls, classname, readable);
}
}
{code}
The only place where it can throw is either in classForName, or in getField or
in cast and finally in construct method. I would bet that it is not in
"cls.getField" because that field exists on murmur instance and it points to
object so it it can not call construct but why? Too bad that we are not
propagaing underlying exception in that first ConfigurationException throw ...
> Nodetool cleanup throwing exception
> ---
>
> Key: CASSANDRA-13158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13158
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Environment: Fedora 25 x86
>Reporter: Tomas Repik
>Assignee: Eduard Tudenhoefner
>Priority: Normal
> Fix For: 4.0
>
>
> After running nodetool cleanup I get this exception:
> error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner
> -- StackTrace --
> org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner
> class org.apache.cassandra.dht.Murmur3Partitioner
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383)
> at
> org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125)
> at
> org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84)
> at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411)
> at
> org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240)
> at
> org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88)
> at org.apache.cassandra.config.Schema.(Schema.java:107)
> at org.apache.cassandra.config.Schema.(Schema.java:55)
> at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50)
> at
> org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251)
> at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15353) GSoD Documentation - Cassandra 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15353: -- Fix Version/s: 4.0-rc > GSoD Documentation - Cassandra 4.0 > -- > > Key: CASSANDRA-15353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15353 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: Deepak Vohra >Priority: Normal > Fix For: 4.0-rc > > > Please review, and add comments to, some of the documentation preview for > Apache Cassandra 4.0. > New Features > --- > *Audit Logging* > https://docs.google.com/document/d/1WsQYjDQ9UZ7f8P3eAATht6Vz5oNibTmhsH8cu9viLTk/edit?usp=sharing > *Full Query Logging* > https://docs.google.com/document/d/1ZNfs68ZNJXqDc_2XGM6W-tpvnejUfSh8HmkbG8u35Es/edit?usp=sharing > *Support for Java 11* > https://docs.google.com/document/d/1v7ffccqk_5Son4iwfuwZae8YUam41quewKi_6Z_PQGw/edit?usp=sharing > *Transient Replication and Cheap Quorums* > https://docs.google.com/document/d/1GyJVCmwoMb7OO9NkbGdk26YxHi9fWtfzuTBTiIEpli8/edit?usp=sharing > *Virtual Tables* > https://docs.google.com/document/d/1U8qAzQnA2HcoIzTg5IXFUySUZXD1tEIl2bam-514we8/edit?usp=sharing > Improvements > > *Improved Streaming* > https://docs.google.com/document/d/1zd6AuHBgC82v598cuDtVIkxJVDV9c0A2rrMEVFHyB4Y/edit?usp=sharing > *Improved Internode Messaging* > https://docs.google.com/document/d/1ub2DBHE7hNEKe4tuCOpdbCZ7qGqCdMAYvSTC-YamuMA/edit?usp=sharing -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15588) 4.0 quality testing: Cluster Upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15588: -- Reviewers: Tommy Stendahl > 4.0 quality testing: Cluster Upgrade > > > Key: CASSANDRA-15588 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15588 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-rc > > > We've historically had numerous bugs concerning upgrading clusters from one > version to the other. Let's establish the supported upgrade path and ensure > that users can safely perform the upgrades in production. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15588) 4.0 quality testing: Cluster Upgrade
Josh McKenzie created CASSANDRA-15588: - Summary: 4.0 quality testing: Cluster Upgrade Key: CASSANDRA-15588 URL: https://issues.apache.org/jira/browse/CASSANDRA-15588 Project: Cassandra Issue Type: Task Components: Test/dtest Reporter: Josh McKenzie We've historically had numerous bugs concerning upgrading clusters from one version to the other. Let's establish the supported upgrade path and ensure that users can safely perform the upgrades in production. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15587) 4.0 quality testing: Platforms and Runtimes
[ https://issues.apache.org/jira/browse/CASSANDRA-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15587: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Platforms and Runtimes > --- > > Key: CASSANDRA-15587 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15587 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-rc > > > CASSANDRA-9608 introduces support for Java 11. We'll want to verify that > Cassandra under Java 11 meets expectations of stability. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15588) 4.0 quality testing: Cluster Upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15588: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Cluster Upgrade > > > Key: CASSANDRA-15588 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15588 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-rc > > > We've historically had numerous bugs concerning upgrading clusters from one > version to the other. Let's establish the supported upgrade path and ensure > that users can safely perform the upgrades in production. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15586) 4.0 quality testing: Cluster Setup and Maintenance
Josh McKenzie created CASSANDRA-15586: - Summary: 4.0 quality testing: Cluster Setup and Maintenance Key: CASSANDRA-15586 URL: https://issues.apache.org/jira/browse/CASSANDRA-15586 Project: Cassandra Issue Type: Task Components: Test/dtest Reporter: Josh McKenzie We want 4.0 to be easy for users to setup out of the box and just work. This means having low friction when users download the Cassandra package and start running it. For example, users should be able to easily configure and start new 4.0 clusters and have tokens distributed evenly. Another example is packaging, it should be easy to install Cassandra on all supported platforms (e.g. packaging) and have Cassandra use standard platform integrations. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15586) 4.0 quality testing: Cluster Setup and Maintenance
[ https://issues.apache.org/jira/browse/CASSANDRA-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15586: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Cluster Setup and Maintenance > -- > > Key: CASSANDRA-15586 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15586 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-rc > > > We want 4.0 to be easy for users to setup out of the box and just work. This > means having low friction when users download the Cassandra package and start > running it. For example, users should be able to easily configure and start > new 4.0 clusters and have tokens distributed evenly. Another example is > packaging, it should be easy to install Cassandra on all supported platforms > (e.g. packaging) and have Cassandra use standard platform integrations. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15587) 4.0 quality testing: Platforms and Runtimes
Josh McKenzie created CASSANDRA-15587: - Summary: 4.0 quality testing: Platforms and Runtimes Key: CASSANDRA-15587 URL: https://issues.apache.org/jira/browse/CASSANDRA-15587 Project: Cassandra Issue Type: Task Components: Test/dtest Reporter: Josh McKenzie CASSANDRA-9608 introduces support for Java 11. We'll want to verify that Cassandra under Java 11 meets expectations of stability. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15585) 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation
[ https://issues.apache.org/jira/browse/CASSANDRA-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15585: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation > - > > Key: CASSANDRA-15585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15585 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Jordan West >Priority: Normal > Fix For: 4.0-rc > > > This area refers to contributions to test frameworks/tooling (e.g., dtests, > QuickTheories, CASSANDRA-14821), and automation enabling those tools to be > applied at scale (e.g., replay testing via Spark-based replay of captured FQL > logs). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15585) 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation
Josh McKenzie created CASSANDRA-15585: - Summary: 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation Key: CASSANDRA-15585 URL: https://issues.apache.org/jira/browse/CASSANDRA-15585 Project: Cassandra Issue Type: Task Components: Test/dtest Reporter: Josh McKenzie Assignee: Jordan West This area refers to contributions to test frameworks/tooling (e.g., dtests, QuickTheories, CASSANDRA-14821), and automation enabling those tools to be applied at scale (e.g., replay testing via Spark-based replay of captured FQL logs). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15584) 4.0 quality testing: Tooling - External Ecosystem
[ https://issues.apache.org/jira/browse/CASSANDRA-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15584: -- Reviewers: Sumanth Pasupuleti > 4.0 quality testing: Tooling - External Ecosystem > - > > Key: CASSANDRA-15584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15584 > Project: Cassandra > Issue Type: Task >Reporter: Josh McKenzie >Assignee: Sam Tunnicliffe >Priority: Normal > Fix For: 4.0-rc > > > Many users of Apache Cassandra employ open source tooling to automate > Cassandra configuration, runtime management, and repair scheduling. Prior to > release, we need to confirm that popular third-party tools such as Reaper, > Priam, etc. function properly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15584) 4.0 quality testing: Tooling - External Ecosystem
Josh McKenzie created CASSANDRA-15584: - Summary: 4.0 quality testing: Tooling - External Ecosystem Key: CASSANDRA-15584 URL: https://issues.apache.org/jira/browse/CASSANDRA-15584 Project: Cassandra Issue Type: Task Reporter: Josh McKenzie Assignee: Sam Tunnicliffe Many users of Apache Cassandra employ open source tooling to automate Cassandra configuration, runtime management, and repair scheduling. Prior to release, we need to confirm that popular third-party tools such as Reaper, Priam, etc. function properly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15583: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Sam Tunnicliffe >Priority: Normal > Fix For: 4.0-rc > > > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15584) 4.0 quality testing: Tooling - External Ecosystem
[ https://issues.apache.org/jira/browse/CASSANDRA-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15584: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Tooling - External Ecosystem > - > > Key: CASSANDRA-15584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15584 > Project: Cassandra > Issue Type: Task >Reporter: Josh McKenzie >Assignee: Sam Tunnicliffe >Priority: Normal > Fix For: 4.0-rc > > > Many users of Apache Cassandra employ open source tooling to automate > Cassandra configuration, runtime management, and repair scheduling. Prior to > release, we need to confirm that popular third-party tools such as Reaper, > Priam, etc. function properly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15583: -- Reviewers: Vinay Chella > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Sam Tunnicliffe >Priority: Normal > Fix For: 4.0-rc > > > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15582) 4.0 quality testing: metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15582: -- Component/s: Test/dtest Reviewers: Romain Hardouin > 4.0 quality testing: metrics > > > Key: CASSANDRA-15582 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15582 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-rc > > > In past releases we've unknowingly broken metrics integrations and introduced > performance regressions in metrics collection and reporting. We strive in 4.0 > to not do that. Metrics should work well! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15582) 4.0 quality testing: metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15582: -- Fix Version/s: 4.0-rc > 4.0 quality testing: metrics > > > Key: CASSANDRA-15582 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15582 > Project: Cassandra > Issue Type: Task >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-rc > > > In past releases we've unknowingly broken metrics integrations and introduced > performance regressions in metrics collection and reporting. We strive in 4.0 > to not do that. Metrics should work well! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039334#comment-17039334 ] Brandon Williams commented on CASSANDRA-13158: -- This seems to indicate the partitioner has been changed (which is not something that should/can be done.) > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
Josh McKenzie created CASSANDRA-15583: - Summary: 4.0 quality testing: Tooling, Bundled and First Party Key: CASSANDRA-15583 URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 Project: Cassandra Issue Type: Task Components: Test/dtest Reporter: Josh McKenzie Assignee: Sam Tunnicliffe Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15582) 4.0 quality testing: metrics
Josh McKenzie created CASSANDRA-15582: - Summary: 4.0 quality testing: metrics Key: CASSANDRA-15582 URL: https://issues.apache.org/jira/browse/CASSANDRA-15582 Project: Cassandra Issue Type: Task Reporter: Josh McKenzie In past releases we've unknowingly broken metrics integrations and introduced performance regressions in metrics collection and reporting. We strive in 4.0 to not do that. Metrics should work well! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15579) 4.0 quality testing: Distributed Read/Write Path: Coordination, Replication, and Read Repair
[ https://issues.apache.org/jira/browse/CASSANDRA-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15579: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Distributed Read/Write Path: Coordination, Replication, > and Read Repair > > > Key: CASSANDRA-15579 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15579 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Josh McKenzie >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0-rc > > > Testing in this area focuses on non-node-local aspects of the read-write > path: coordination, replication, read repair, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15581) 4.0 quality testing: Compaction
[ https://issues.apache.org/jira/browse/CASSANDRA-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15581: -- Reviewers: Jordan West > 4.0 quality testing: Compaction > --- > > Key: CASSANDRA-15581 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15581 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-rc > > > Alongside the local and distributed read/write paths, we'll also want to > validate compaction. CASSANDRA-6696 introduced substantial > changes/improvements that require testing (esp. JBOD). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15580) 4.0 quality testing: Repair
[ https://issues.apache.org/jira/browse/CASSANDRA-15580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15580: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Repair > --- > > Key: CASSANDRA-15580 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15580 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0-rc > > > We aim for 4.0 to have the first fully functioning incremental repair > solution (CASSANDRA-9143)! Furthermore we aim to verify that all types of > repair: (full range, sub range, incremental) function as expected as well as > ensuring community tools such as Reaper work. CASSANDRA-3200 adds an > experimental option to reduce the amount of data streamed during repair, we > should write more tests and see how it works with big nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15581) 4.0 quality testing: Compaction
Josh McKenzie created CASSANDRA-15581: - Summary: 4.0 quality testing: Compaction Key: CASSANDRA-15581 URL: https://issues.apache.org/jira/browse/CASSANDRA-15581 Project: Cassandra Issue Type: Task Components: Test/dtest Reporter: Josh McKenzie Assignee: Marcus Eriksson Alongside the local and distributed read/write paths, we'll also want to validate compaction. CASSANDRA-6696 introduced substantial changes/improvements that require testing (esp. JBOD). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15581) 4.0 quality testing: Compaction
[ https://issues.apache.org/jira/browse/CASSANDRA-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15581: -- Fix Version/s: 4.0-rc > 4.0 quality testing: Compaction > --- > > Key: CASSANDRA-15581 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15581 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-rc > > > Alongside the local and distributed read/write paths, we'll also want to > validate compaction. CASSANDRA-6696 introduced substantial > changes/improvements that require testing (esp. JBOD). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15580) 4.0 quality testing: Repair
[ https://issues.apache.org/jira/browse/CASSANDRA-15580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15580: -- Component/s: Test/dtest Reviewers: Marcus Eriksson, Vinay Chella > 4.0 quality testing: Repair > --- > > Key: CASSANDRA-15580 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15580 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Blake Eggleston >Priority: Normal > > We aim for 4.0 to have the first fully functioning incremental repair > solution (CASSANDRA-9143)! Furthermore we aim to verify that all types of > repair: (full range, sub range, incremental) function as expected as well as > ensuring community tools such as Reaper work. CASSANDRA-3200 adds an > experimental option to reduce the amount of data streamed during repair, we > should write more tests and see how it works with big nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15580) 4.0 quality testing: Repair
Josh McKenzie created CASSANDRA-15580: - Summary: 4.0 quality testing: Repair Key: CASSANDRA-15580 URL: https://issues.apache.org/jira/browse/CASSANDRA-15580 Project: Cassandra Issue Type: Task Reporter: Josh McKenzie Assignee: Blake Eggleston We aim for 4.0 to have the first fully functioning incremental repair solution (CASSANDRA-9143)! Furthermore we aim to verify that all types of repair: (full range, sub range, incremental) function as expected as well as ensuring community tools such as Reaper work. CASSANDRA-3200 adds an experimental option to reduce the amount of data streamed during repair, we should write more tests and see how it works with big nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15579) 4.0 quality testing: Distributed Read/Write Path: Coordination, Replication, and Read Repair
Josh McKenzie created CASSANDRA-15579: - Summary: 4.0 quality testing: Distributed Read/Write Path: Coordination, Replication, and Read Repair Key: CASSANDRA-15579 URL: https://issues.apache.org/jira/browse/CASSANDRA-15579 Project: Cassandra Issue Type: Task Components: Test/unit Reporter: Josh McKenzie Assignee: Blake Eggleston Testing in this area focuses on non-node-local aspects of the read-write path: coordination, replication, read repair, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[
https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039324#comment-17039324
]
Stefan Miklosovic commented on CASSANDRA-13158:
---
[~dcapwell] here you go
{code}
error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner
-- StackTrace --
org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner
class org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.config.DatabaseDescriptor.applyPartitioner(DatabaseDescriptor.java:1108)
at
org.apache.cassandra.config.DatabaseDescriptor.toolInitialization(DatabaseDescriptor.java:218)
at
org.apache.cassandra.config.DatabaseDescriptor.toolInitialization(DatabaseDescriptor.java:185)
at org.apache.cassandra.tools.NodeProbe.checkJobs(NodeProbe.java:291)
at
org.apache.cassandra.tools.NodeProbe.forceKeyspaceCleanup(NodeProbe.java:298)
at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:55)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:341)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.accept(NodeTool.java:326)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.accept(NodeTool.java:300)
at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:237)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:84)
{code}
> Nodetool cleanup throwing exception
> ---
>
> Key: CASSANDRA-13158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13158
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Environment: Fedora 25 x86
>Reporter: Tomas Repik
>Assignee: Eduard Tudenhoefner
>Priority: Normal
> Fix For: 4.0
>
>
> After running nodetool cleanup I get this exception:
> error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner
> -- StackTrace --
> org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner
> class org.apache.cassandra.dht.Murmur3Partitioner
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383)
> at
> org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125)
> at
> org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84)
> at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411)
> at
> org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240)
> at
> org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88)
> at org.apache.cassandra.config.Schema.(Schema.java:107)
> at org.apache.cassandra.config.Schema.(Schema.java:55)
> at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50)
> at
> org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251)
> at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039318#comment-17039318
]
Brandon Williams commented on CASSANDRA-15557:
--
So I started this test in a while loop, and forgot about it over the long (US)
weekend. The net effect is I ran this _many_ thousands of times without
failure on java 8. Is this still an issue?
> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest
> testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-15557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2
> (mycollection of type list), expected but got <[first element]>
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
[
https://issues.apache.org/jira/browse/CASSANDRA-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Joshi updated CASSANDRA-15578:
-
Resolution: Duplicate
Status: Resolved (was: Triage Needed)
Thanks for testing! This is dup and should be fixed when we fix 14872.
> Describe keyspace does not work for keyspaces with transient replication
>
>
> Key: CASSANDRA-15578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Priority: Normal
> Labels: 4.0
>
> I can not describe a keyspace which is using transient replication.
> {code:java}
> admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
> 'NetworkTopologyStrategy', 'dc1': '3/1'};
> admin@cqlsh> DESCRIBE KEYSPACE bar;
> 'NoneType' object has no attribute 'export_for_schema'
> {code}
> I am sorry in case this is a duplicate but I have not found similar issue yet.
>
> This was tried on 4.0-alpha3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
[
https://issues.apache.org/jira/browse/CASSANDRA-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039298#comment-17039298
]
David Capwell commented on CASSANDRA-15578:
---
Never mind, doesn't look like a python3 regression; this is what I get in alpha2
{code}
cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
'NetworkTopologyStrategy', 'datacenter1': '3/1'};
cqlsh> DESCRIBE KEYSPACE bar;
'NoneType' object has no attribute 'export_for_schema'
{code}
> Describe keyspace does not work for keyspaces with transient replication
>
>
> Key: CASSANDRA-15578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Priority: Normal
> Labels: 4.0
>
> I can not describe a keyspace which is using transient replication.
> {code:java}
> admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
> 'NetworkTopologyStrategy', 'dc1': '3/1'};
> admin@cqlsh> DESCRIBE KEYSPACE bar;
> 'NoneType' object has no attribute 'export_for_schema'
> {code}
> I am sorry in case this is a duplicate but I have not found similar issue yet.
>
> This was tried on 4.0-alpha3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039297#comment-17039297
]
Jordan West commented on CASSANDRA-15213:
-
Updated the default and the commit message.
[branch|https://github.com/jrwest/cassandra/commits/jwest/15213]
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039294#comment-17039294 ] Dinesh Joshi commented on CASSANDRA-15576: -- The driver fixes is a bigger issue which I will tackle as a follow on. For this specific issue, the test ensures that the current set of system keyspaces exist in the cqlsh output. If someone adds a new table without updating the test, it will break the test and they would need to update it. If you don't have any other issues, I'll go ahead and close this and address the driver issue as a follow up to this. > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
[
https://issues.apache.org/jira/browse/CASSANDRA-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039288#comment-17039288
]
David Capwell commented on CASSANDRA-15578:
---
This looks to be a regression caused by the patch for python 3.6 support and
impacts vtables as well
{code}
cqlsh:system> use system_views;
cqlsh:system_views> describe keyspace;
'NoneType' object has no attribute 'export_for_schema'
{code}
> Describe keyspace does not work for keyspaces with transient replication
>
>
> Key: CASSANDRA-15578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Priority: Normal
> Labels: 4.0
>
> I can not describe a keyspace which is using transient replication.
> {code:java}
> admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
> 'NetworkTopologyStrategy', 'dc1': '3/1'};
> admin@cqlsh> DESCRIBE KEYSPACE bar;
> 'NoneType' object has no attribute 'export_for_schema'
> {code}
> I am sorry in case this is a duplicate but I have not found similar issue yet.
>
> This was tried on 4.0-alpha3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[
https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039285#comment-17039285
]
David Capwell commented on CASSANDRA-15576:
---
In testing it looks like this isn't enough
{code}
$ ./bin/cqlsh
Connected to Test Cluster at 127.0.0.1:9042.
[cqlsh 5.0.1 | Cassandra 4.0-alpha4-SNAPSHOT | CQL spec 3.4.5 | Native protocol
v4]
Use HELP for help.
cqlsh> describe keyspace;
Not in any keyspace.
cqlsh> describe keyspaces;
system_traces system_auth system_distributed system_views
system_schema system system_virtual_schema
cqlsh> use system_views;
cqlsh:system_views> describe keyspace;
'NoneType' object has no attribute 'export_for_schema'
{code}
This looks like the other jira CASSANDRA-14872. Now, looking at that JIRA the
TODO implies that upgrading would actually fix the issue.
[~djoshi] is the intent that this is to unblock trunk until CASSANDRA-14872
happens? Kinda feel it would be best to have one JIRA which makes sure vtables
work with cqlsh.
> CQLSH missing virtual keyspaces on DESCRIBE call
>
>
> Key: CASSANDRA-15576
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15576
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest
> to avoid future regressions.
> [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh],
>
> [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh]
> and
> [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039275#comment-17039275 ] David Capwell commented on CASSANDRA-15576: --- Code LGTM, the test LGTM; will this prevent a regression if we add a third type? No, but fixing that is a much larger change. Going to start testing this now. > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15576: - Description: cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest to avoid future regressions. [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] and [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. (was: cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest to avoid future regressions. [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] and [CI|https://circleci.com/workflow-run/af946cf6-f9d6-40e8-a19b-fa8506cfde31].) > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/b978fe37-98a8-482b-89bf-f7b6c8c41a40]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15576: - Description: cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest to avoid future regressions. [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] and [CI|https://circleci.com/workflow-run/af946cf6-f9d6-40e8-a19b-fa8506cfde31]. (was: cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest to avoid future regressions. [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh] and [CI|https://circleci.com/workflow-run/af946cf6-f9d6-40e8-a19b-fa8506cfde31].) > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/af946cf6-f9d6-40e8-a19b-fa8506cfde31]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039265#comment-17039265 ] Dinesh Joshi commented on CASSANDRA-15576: -- [~rustyrazorblade] thanks for the review. Forgot to link the dtest. Can you please take a look? > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh], > > [DTests|https://github.com/dineshjoshi/cassandra-dtest-1/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/af946cf6-f9d6-40e8-a19b-fa8506cfde31]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039264#comment-17039264 ] David Capwell edited comment on CASSANDRA-13158 at 2/18/20 5:27 PM: bq. Why is this even happening? That error is very strange. [~stefan.miklosovic] here is what I see. The stack trace points to this [line here|https://github.com/apache/cassandra/blob/cassandra-4.0-alpha3/src/java/org/apache/cassandra/tools/nodetool/Cleanup.java#L50]. That line calls [this function|https://github.com/apache/cassandra/blob/cassandra-4.0-alpha3/src/java/org/apache/cassandra/schema/SchemaConstants.java#L75] and the whole class does not depend on Schema (the stack trace says otherwise); if I look at 3.11 I see the same behavior (linked JIRA is marked 3.10). Now, if I look at 3.0 I see the behavior in the stack trace; [this|https://github.com/apache/cassandra/blob/cassandra-3.0.20/src/java/org/apache/cassandra/tools/nodetool/Cleanup.java#L50] calls to the Schema class (matches stack trace). bq. What does murmur have in common with some cleanup? Dont you know why is this a thing in the first place? The main reason is because Schema class depends on the configuration for the node but nodetool shouldn't depend on the configuration (cassandra.yml). This is also coupled with the fact the error message could actually mean -Dcassandra.partitioner is set in nodetool for some reason; if you look at https://github.com/apache/cassandra/blob/cassandra-3.0.20/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L380 you will see the error always prints what is in the yaml but -Dcassandra.partitioner=thiswillfail will cause that exception. Now, the correct behavior is that nodetool shouldn't depend on the configuration and that is what I see in 4.0. I don't see any dependency on the Schema class with regard to Cleanup (or on the configs), and only see it compare against constants class. So without a new stack trace from 4.0 I can't say why the behavior is seen since I am unable to replicate and the reported stack trace has been fixed to not depend on Schema class. [~stefan.miklosovic] if you have more details I would be glad to help. was (Author: dcapwell): bq. Why is this even happening? That error is very strange. [~stefan.miklosovic] here is what I see. The stack trace points to this line here https://github.com/apache/cassandra/blob/cassandra-4.0-alpha3/src/java/org/apache/cassandra/tools/nodetool/Cleanup.java#L50. That line calls this function https://github.com/apache/cassandra/blob/cassandra-4.0-alpha3/src/java/org/apache/cassandra/schema/SchemaConstants.java#L75 and the whole class does not depend on Schema (the stack trace says otherwise); if I look at 3.11 I see the same behavior (linked JIRA is marked 3.10). Now, if I look at 3.0 I see the behavior in the stack trace; https://github.com/apache/cassandra/blob/cassandra-3.0.20/src/java/org/apache/cassandra/tools/nodetool/Cleanup.java#L50 this calls to the Schema class (matches stack trace). bq. What does murmur have in common with some cleanup? Dont you know why is this a thing in the first place? The main reason is because Schema class depends on the configuration for the node but nodetool shouldn't depend on the configuration (cassandra.yml). This is also coupled with the fact the error message could actually mean -Dcassandra.partitioner is set in nodetool for some reason; if you look at https://github.com/apache/cassandra/blob/cassandra-3.0.20/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L380 you will see the error always prints what is in the yaml but -Dcassandra.partitioner=thiswillfail will cause that exception. Now, the correct behavior is that nodetool shouldn't depend on the configuration and that is what I see in 4.0. I don't see any dependency on the Schema class with regard to Cleanup (or on the configs), and only see it compare against constants class. So without a new stack trace from 4.0 I can't say why the behavior is seen since I am unable to replicate and the reported stack trace has been fixed to not depend on Schema class. [~stefan.miklosovic] if you have more details I would be glad to help. > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exception
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039264#comment-17039264 ] David Capwell commented on CASSANDRA-13158: --- bq. Why is this even happening? That error is very strange. [~stefan.miklosovic] here is what I see. The stack trace points to this line here https://github.com/apache/cassandra/blob/cassandra-4.0-alpha3/src/java/org/apache/cassandra/tools/nodetool/Cleanup.java#L50. That line calls this function https://github.com/apache/cassandra/blob/cassandra-4.0-alpha3/src/java/org/apache/cassandra/schema/SchemaConstants.java#L75 and the whole class does not depend on Schema (the stack trace says otherwise); if I look at 3.11 I see the same behavior (linked JIRA is marked 3.10). Now, if I look at 3.0 I see the behavior in the stack trace; https://github.com/apache/cassandra/blob/cassandra-3.0.20/src/java/org/apache/cassandra/tools/nodetool/Cleanup.java#L50 this calls to the Schema class (matches stack trace). bq. What does murmur have in common with some cleanup? Dont you know why is this a thing in the first place? The main reason is because Schema class depends on the configuration for the node but nodetool shouldn't depend on the configuration (cassandra.yml). This is also coupled with the fact the error message could actually mean -Dcassandra.partitioner is set in nodetool for some reason; if you look at https://github.com/apache/cassandra/blob/cassandra-3.0.20/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L380 you will see the error always prints what is in the yaml but -Dcassandra.partitioner=thiswillfail will cause that exception. Now, the correct behavior is that nodetool shouldn't depend on the configuration and that is what I see in 4.0. I don't see any dependency on the Schema class with regard to Cleanup (or on the configs), and only see it compare against constants class. So without a new stack trace from 4.0 I can't say why the behavior is seen since I am unable to replicate and the reported stack trace has been fixed to not depend on Schema class. [~stefan.miklosovic] if you have more details I would be glad to help. > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15576) CQLSH missing virtual keyspaces on DESCRIBE call
[ https://issues.apache.org/jira/browse/CASSANDRA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039235#comment-17039235 ] Jon Haddad commented on CASSANDRA-15576: Looks simple enough, very nice. Could you add a test to prevent a future regression? > CQLSH missing virtual keyspaces on DESCRIBE call > > > Key: CASSANDRA-15576 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15576 > Project: Cassandra > Issue Type: Bug > Components: Tool/cqlsh >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 4.0-alpha > > > cqlsh is missing virtual keyspaces. This patch fixes it. It also adds a dtest > to avoid future regressions. > [Branch|https://github.com/dineshjoshi/cassandra/tree/fix-missing-keyspace-issue-cqlsh] > and > [CI|https://circleci.com/workflow-run/af946cf6-f9d6-40e8-a19b-fa8506cfde31]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039092#comment-17039092
]
Benedict Elliott Smith commented on CASSANDRA-15213:
[~jrwest] we discussed (somewhere) maybe reducing the default value to 2, at
least initially? I don't mind using 4, but I think doubling the memory we use
here is probably a good first stab at balancing improvement for larger users
(who are ordinarily better able to reconfigure) against the cost for users with
smaller nodes?
Also, patch message formatting norms sign off:
patch by A, B; reviewed by C, D for CASSANDRA-X
This is particularly helpful if using awk for analysis, since this is the only
standard we've ever followed almost consistently, so it's helpful to retain it.
Otherwise LGTM
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14748) Recycler$WeakOrderQueue occupies Heap
[ https://issues.apache.org/jira/browse/CASSANDRA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039026#comment-17039026 ] Benedict Elliott Smith commented on CASSANDRA-14748: Thanks [~yifanc], that's probably good enough since we've not seen any other reproductions, and I would expect any issue with the recycling itself to show up more reliably. > Recycler$WeakOrderQueue occupies Heap > - > > Key: CASSANDRA-14748 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14748 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core > Environment: The netty Cassandra using is netty-all-4.0.39.Final.jar >Reporter: HX >Priority: Normal > Fix For: 4.0, 3.11.x, 4.0-rc > > > Heap constantly high on some of the nodes in the cluster, I dump the heap and > open it through Eclipse Memory Analyzer, looks like Recycler$WeakOrderQueue > occupies most of the heap. > > ||Package||Retained Heap||Retained Heap, %||# Top Dominators|| > |!/jira/icons/i5.gif! |7,078,140,136|100.00%|379,627| > |io|5,665,035,800|80.04%|13,306| > |netty|5,665,035,800|80.04%|13,306| > |util|5,568,107,344|78.67%|2,965| > |Recycler$WeakOrderQueue|4,950,021,544|69.93%|2,169| -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15353) GSoD Documentation - Cassandra 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038965#comment-17038965 ] DeepakVohra commented on CASSANDRA-15353: - The username has to be unique and follow a certain syntax. DeepakVohra is taken by another user. Deepak Vohra does not follow the syntax requirements "Username may only contain alphanumeric characters or single hyphens, and cannot begin or end with a hyphen.". > GSoD Documentation - Cassandra 4.0 > -- > > Key: CASSANDRA-15353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15353 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: Deepak Vohra >Priority: Normal > > Please review, and add comments to, some of the documentation preview for > Apache Cassandra 4.0. > New Features > --- > *Audit Logging* > https://docs.google.com/document/d/1WsQYjDQ9UZ7f8P3eAATht6Vz5oNibTmhsH8cu9viLTk/edit?usp=sharing > *Full Query Logging* > https://docs.google.com/document/d/1ZNfs68ZNJXqDc_2XGM6W-tpvnejUfSh8HmkbG8u35Es/edit?usp=sharing > *Support for Java 11* > https://docs.google.com/document/d/1v7ffccqk_5Son4iwfuwZae8YUam41quewKi_6Z_PQGw/edit?usp=sharing > *Transient Replication and Cheap Quorums* > https://docs.google.com/document/d/1GyJVCmwoMb7OO9NkbGdk26YxHi9fWtfzuTBTiIEpli8/edit?usp=sharing > *Virtual Tables* > https://docs.google.com/document/d/1U8qAzQnA2HcoIzTg5IXFUySUZXD1tEIl2bam-514we8/edit?usp=sharing > Improvements > > *Improved Streaming* > https://docs.google.com/document/d/1zd6AuHBgC82v598cuDtVIkxJVDV9c0A2rrMEVFHyB4Y/edit?usp=sharing > *Improved Internode Messaging* > https://docs.google.com/document/d/1ub2DBHE7hNEKe4tuCOpdbCZ7qGqCdMAYvSTC-YamuMA/edit?usp=sharing -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
[
https://issues.apache.org/jira/browse/CASSANDRA-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038924#comment-17038924
]
Stefan Miklosovic commented on CASSANDRA-15578:
---
Hi [~aweisberg], I merely remember you were the one most active behind
transient replication so I guess mentioning you here is a good idea to achieve
some visibility to this issue.
> Describe keyspace does not work for keyspaces with transient replication
>
>
> Key: CASSANDRA-15578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Priority: Normal
> Labels: 4.0
>
> I can not describe a keyspace which is using transient replication.
> {code:java}
> admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
> 'NetworkTopologyStrategy', 'dc1': '3/1'};
> admin@cqlsh> DESCRIBE KEYSPACE bar;
> 'NoneType' object has no attribute 'export_for_schema'
> {code}
> I am sorry in case this is a duplicate but I have not found similar issue yet.
>
> This was tried on 4.0-alpha3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
[
https://issues.apache.org/jira/browse/CASSANDRA-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-15578:
--
Description:
I can not describe a keyspace which is using transient replication.
{code:java}
admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
'NetworkTopologyStrategy', 'dc1': '3/1'};
admin@cqlsh> DESCRIBE KEYSPACE bar;
'NoneType' object has no attribute 'export_for_schema'
{code}
I am sorry in case this is a duplicate but I have not found similar issue yet.
This was tried on 4.0-alpha3
was:
I can not describe a keyspace which is using transient replication.
{code}
admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
'NetworkTopologyStrategy', 'dc1': '3/1'};
admin@cqlsh> DESCRIBE KEYSPACE bar;
'NoneType' object has no attribute 'export_for_schema'
{code}
I am sorry in case this is a duplicate but I have not found similar issue yet.
> Describe keyspace does not work for keyspaces with transient replication
>
>
> Key: CASSANDRA-15578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Priority: Normal
> Labels: 4.0
>
> I can not describe a keyspace which is using transient replication.
> {code:java}
> admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
> 'NetworkTopologyStrategy', 'dc1': '3/1'};
> admin@cqlsh> DESCRIBE KEYSPACE bar;
> 'NoneType' object has no attribute 'export_for_schema'
> {code}
> I am sorry in case this is a duplicate but I have not found similar issue yet.
>
> This was tried on 4.0-alpha3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
Stefan Miklosovic created CASSANDRA-15578:
-
Summary: Describe keyspace does not work for keyspaces with
transient replication
Key: CASSANDRA-15578
URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
Project: Cassandra
Issue Type: Bug
Components: CQL/Interpreter
Reporter: Stefan Miklosovic
I can not describe a keyspace which is using transient replication.
{code}
admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
'NetworkTopologyStrategy', 'dc1': '3/1'};
admin@cqlsh> DESCRIBE KEYSPACE bar;
'NoneType' object has no attribute 'export_for_schema'
{code}
I am sorry in case this is a duplicate but I have not found similar issue yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15578) Describe keyspace does not work for keyspaces with transient replication
[
https://issues.apache.org/jira/browse/CASSANDRA-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-15578:
--
Labels: 4.0 (was: )
> Describe keyspace does not work for keyspaces with transient replication
>
>
> Key: CASSANDRA-15578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15578
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Priority: Normal
> Labels: 4.0
>
> I can not describe a keyspace which is using transient replication.
> {code}
> admin@cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
> 'NetworkTopologyStrategy', 'dc1': '3/1'};
> admin@cqlsh> DESCRIBE KEYSPACE bar;
> 'NoneType' object has no attribute 'export_for_schema'
> {code}
> I am sorry in case this is a duplicate but I have not found similar issue yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038895#comment-17038895 ] Stefan Miklosovic edited comment on CASSANDRA-13158 at 2/18/20 8:49 AM: [~dcapwell] I have to admit I am using some "custom" scripts for invoking nodetool but I was trying to be as close as possible to out-of-the-box setting and it is happening. I can try to give you the exact / raw command this issue occurs with once I get to it. Why is this even happening? That error is very strange. What does murmur have in common with some cleanup? Dont you know _why_ is this a thing in the first place? was (Author: stefan.miklosovic): [~dcapwell] I have to admit I am using some "custom" scripts for invoking nodetool but I was trying to be as close as possible to out-of-the-box setting and it is happening. I can try to give you the exact / raw command this issue occurs with once I get to it. Why is this even happening? That error is very strange. What does have murmur in common with some cleanup? Dont you know _why_ is this a thing in the first place? > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13158) Nodetool cleanup throwing exception
[ https://issues.apache.org/jira/browse/CASSANDRA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038895#comment-17038895 ] Stefan Miklosovic commented on CASSANDRA-13158: --- [~dcapwell] I have to admit I am using some "custom" scripts for invoking nodetool but I was trying to be as close as possible to out-of-the-box setting and it is happening. I can try to give you the exact / raw command this issue occurs with once I get to it. Why is this even happening? That error is very strange. What does have murmur in common with some cleanup? Dont you know _why_ is this a thing in the first place? > Nodetool cleanup throwing exception > --- > > Key: CASSANDRA-13158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13158 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Environment: Fedora 25 x86 >Reporter: Tomas Repik >Assignee: Eduard Tudenhoefner >Priority: Normal > Fix For: 4.0 > > > After running nodetool cleanup I get this exception: > error: Invalid partitioner class org.apache.cassandra.dht.Murmur3Partitioner > -- StackTrace -- > org.apache.cassandra.exceptions.ConfigurationException: Invalid partitioner > class org.apache.cassandra.dht.Murmur3Partitioner > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:383) > at > org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:125) > at > org.apache.cassandra.cql3.QueryProcessor.(QueryProcessor.java:84) > at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:411) > at > org.apache.cassandra.schema.SchemaKeyspace.compile(SchemaKeyspace.java:240) > at > org.apache.cassandra.schema.SchemaKeyspace.(SchemaKeyspace.java:88) > at org.apache.cassandra.config.Schema.(Schema.java:107) > at org.apache.cassandra.config.Schema.(Schema.java:55) > at org.apache.cassandra.tools.nodetool.Cleanup.execute(Cleanup.java:50) > at > org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:251) > at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:165) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15577) There is a spelling mistake in system_auth.resource_role_permissons_index
[ https://issues.apache.org/jira/browse/CASSANDRA-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-15577: Resolution: Duplicate Status: Resolved (was: Triage Needed) > There is a spelling mistake in system_auth.resource_role_permissons_index > - > > Key: CASSANDRA-15577 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15577 > Project: Cassandra > Issue Type: Bug > Components: CQL/Syntax >Reporter: Jay Narale >Priority: Normal > > The system_auth keyspace has an error in a table named as > resource_role_permissons_index. Should be > resource_role_permissions_index(missing i in permissions) > cqlsh 5.0.1 | Cassandra 3.11.5 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
