[jira] [Updated] (CASSANDRA-15800) BinLog deadlock on stopping when the sample queue is full
[ https://issues.apache.org/jira/browse/CASSANDRA-15800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-15800: -- Bug Category: Parent values: Degradation(12984)Level 1 values: Resource Management(12995) Complexity: Normal Discovered By: Code Inspection Severity: Normal > BinLog deadlock on stopping when the sample queue is full > - > > Key: CASSANDRA-15800 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15800 > Project: Cassandra > Issue Type: Bug > Components: Observability/Logging >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > > A deadlock can happen when 1) the BinLog is being stoped and 2) the BinLog's > internal sample queue is full. > When stopping, BinLog first set the flag shouldContinue to false, so that the > internal consumer thread stop consuming. It is possible to leave the queue > being full. > Then, the BinLog puts one extra object NO_OP into the sample queue. However, > the queue is already full, so the put operation blocks, and the stop method > never returns. > Therefore, we got a deadlock. > BinLog is used by Cassandra 40 new features such as audit logging and full > query logging. > If such deadlock happens, the thread cannot be not joined and the referenced > items in the queue are never released, hence memory leak. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15800) BinLog deadlock on stopping when the sample queue is full
[ https://issues.apache.org/jira/browse/CASSANDRA-15800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-15800: -- Status: Open (was: Triage Needed) > BinLog deadlock on stopping when the sample queue is full > - > > Key: CASSANDRA-15800 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15800 > Project: Cassandra > Issue Type: Bug > Components: Observability/Logging >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > > A deadlock can happen when 1) the BinLog is being stoped and 2) the BinLog's > internal sample queue is full. > When stopping, BinLog first set the flag shouldContinue to false, so that the > internal consumer thread stop consuming. It is possible to leave the queue > being full. > Then, the BinLog puts one extra object NO_OP into the sample queue. However, > the queue is already full, so the put operation blocks, and the stop method > never returns. > Therefore, we got a deadlock. > BinLog is used by Cassandra 40 new features such as audit logging and full > query logging. > If such deadlock happens, the thread cannot be not joined and the referenced > items in the queue are never released, hence memory leak. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15800) BinLog deadlock on stopping when the sample queue is full
Yifan Cai created CASSANDRA-15800: - Summary: BinLog deadlock on stopping when the sample queue is full Key: CASSANDRA-15800 URL: https://issues.apache.org/jira/browse/CASSANDRA-15800 Project: Cassandra Issue Type: Bug Components: Observability/Logging Reporter: Yifan Cai Assignee: Yifan Cai A deadlock can happen when 1) the BinLog is being stoped and 2) the BinLog's internal sample queue is full. When stopping, BinLog first set the flag shouldContinue to false, so that the internal consumer thread stop consuming. It is possible to leave the queue being full. Then, the BinLog puts one extra object NO_OP into the sample queue. However, the queue is already full, so the put operation blocks, and the stop method never returns. Therefore, we got a deadlock. BinLog is used by Cassandra 40 new features such as audit logging and full query logging. If such deadlock happens, the thread cannot be not joined and the referenced items in the queue are never released, hence memory leak. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-13047) Point cqlsh help to the new doc
[ https://issues.apache.org/jira/browse/CASSANDRA-13047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Bannister reassigned CASSANDRA-13047: - Assignee: (was: Patrick Bannister) > Point cqlsh help to the new doc > --- > > Key: CASSANDRA-13047 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13047 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Sylvain Lebresne >Priority: Normal > Fix For: 4.0 > > > Cqlsh still points to the "old" textile CQL doc, but that's not really > maintain anymore now that we have the new doc (which include everything the > old doc had and more). We should update cqlsh to point to the new doc so we > can remove the old one completely. > Any takers? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13047) Point cqlsh help to the new doc
[ https://issues.apache.org/jira/browse/CASSANDRA-13047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103311#comment-17103311 ] Patrick Bannister commented on CASSANDRA-13047: --- It looks like the versioned docs website has progressed enough that this ticket could be completed. However, I should hand it off to somebody with more free time to work on it. > Point cqlsh help to the new doc > --- > > Key: CASSANDRA-13047 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13047 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Sylvain Lebresne >Assignee: Patrick Bannister >Priority: Normal > Fix For: 4.0 > > > Cqlsh still points to the "old" textile CQL doc, but that's not really > maintain anymore now that we have the new doc (which include everything the > old doc had and more). We should update cqlsh to point to the new doc so we > can remove the old one completely. > Any takers? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
