[jira] [Updated] (CASSANDRA-16074) Add metric for client concurrent byte throttle
[ https://issues.apache.org/jira/browse/CASSANDRA-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16074: --- Fix Version/s: 4.0-beta > Add metric for client concurrent byte throttle > -- > > Key: CASSANDRA-16074 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16074 > Project: Cassandra > Issue Type: New Feature > Components: Messaging/Client, Observability/Metrics >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Normal > Fix For: 4.0-beta > > > Add a metric to expose the current bytes and bytes per ip used that is used > in the existing throttle so its possible to determine what to set it to. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-12734) Materialized View schema file for snapshots created as tables
[ https://issues.apache.org/jira/browse/CASSANDRA-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yang reassigned CASSANDRA-12734: - Assignee: Zhao Yang > Materialized View schema file for snapshots created as tables > - > > Key: CASSANDRA-12734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12734 > Project: Cassandra > Issue Type: Bug > Components: Feature/Materialized Views, Legacy/Tools >Reporter: Hau Phan >Assignee: Zhao Yang >Priority: Normal > Fix For: 3.0.x > > > The materialized view schema file that gets created and stored with the > sstables is created as a table instead of a materialized view. > Can the materialized view be created and added to the corresponding table's > schema file? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-15164: --- Status: Open (was: Resolved) > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201359#comment-17201359 ] Benjamin Lerer commented on CASSANDRA-15164: We should also commit that patch into 3.0 and 3.11. > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch master updated: remove redundant param wait_other_notice=True from Node.start calls
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/master by this push:
new ee5dc59 remove redundant param wait_other_notice=True from Node.start
calls
ee5dc59 is described below
commit ee5dc59b4cf20be24dd32407369f2ce822914bd7
Author: Christopher Lambert
AuthorDate: Wed Sep 23 14:25:55 2020 +0200
remove redundant param wait_other_notice=True from Node.start calls
Since https://github.com/riptano/ccm/pull/464 ccm Node.start() defaults to:
wait_other_notice=True
Since the presence could suggest that this is a non-default value, we
clean up the code by removing it.
patch by Christopher Lambert; reviewed by Mick Semb Wever
---
batch_test.py| 4 +--
bootstrap_test.py| 22 +++---
concurrent_schema_changes_test.py| 2 +-
consistency_test.py | 38
consistent_bootstrap_test.py | 4 +--
counter_test.py | 4 +--
fqltool_test.py | 2 +-
hintedhandoff_test.py| 4 +--
legacy_sstables_test.py | 2 +-
materialized_views_test.py | 44 ++--
pushed_notifications_test.py | 6 ++--
rebuild_test.py | 6 ++--
repair_tests/incremental_repair_test.py | 12
repair_tests/preview_repair_test.py | 4 +--
repair_tests/repair_test.py | 22 +++---
replace_address_test.py | 2 +-
replica_side_filtering_test.py | 2 +-
secondary_indexes_test.py| 6 ++--
seed_test.py | 2 +-
transient_replication_ring_test.py | 16 +-
upgrade_crc_check_chance_test.py | 2 +-
upgrade_internal_auth_test.py| 2 +-
upgrade_tests/regression_test.py | 2 +-
upgrade_tests/repair_test.py | 2 +-
upgrade_tests/storage_engine_upgrade_test.py | 2 +-
upgrade_tests/thrift_upgrade_test.py | 2 +-
upgrade_tests/upgrade_base.py| 2 +-
upgrade_tests/upgrade_compact_storage.py | 2 +-
upgrade_tests/upgrade_supercolumns_test.py | 2 +-
29 files changed, 111 insertions(+), 111 deletions(-)
diff --git a/batch_test.py b/batch_test.py
index f67a8d7..f10b78a 100644
--- a/batch_test.py
+++ b/batch_test.py
@@ -193,7 +193,7 @@ class TestBatch(Tester):
""", consistency_level=ConsistencyLevel.ONE)
session.execute(query)
-self.cluster.nodelist()[-1].start(wait_for_binary_proto=True,
wait_other_notice=True)
+self.cluster.nodelist()[-1].start(wait_for_binary_proto=True)
assert_all(session, "SELECT * FROM users", [[1, 'Will', 'Turner'], [0,
'Jack', 'Sparrow']],
cl=ConsistencyLevel.ALL)
@@ -505,4 +505,4 @@ class TestBatch(Tester):
remove_perf_disable_shared_mem(node)
# Restart nodes on new version
logger.debug('Starting {} on new version ({})'.format(node.name,
node.get_cassandra_version()))
-node.start(wait_other_notice=True, wait_for_binary_proto=True,
jvm_args=['-Dcassandra.disable_max_protocol_auto_override=true'])
+node.start(wait_for_binary_proto=True,
jvm_args=['-Dcassandra.disable_max_protocol_auto_override=true'])
diff --git a/bootstrap_test.py b/bootstrap_test.py
index 540aa5c..20e2545 100644
--- a/bootstrap_test.py
+++ b/bootstrap_test.py
@@ -212,7 +212,7 @@ class TestBootstrap(Tester):
# Bootstrapping a new node
node3 = new_node(cluster)
-node3.start(wait_for_binary_proto=True, wait_other_notice=True)
+node3.start(wait_for_binary_proto=True)
assert_bootstrap_state(self, node3, 'COMPLETED')
@@ -252,7 +252,7 @@ class TestBootstrap(Tester):
node1 = cluster.nodelist()[0]
logger.debug("Start node 1")
- node1.start(wait_for_binary_proto=True, wait_other_notice=True)
+ node1.start(wait_for_binary_proto=True)
logger.debug("Insert 10k rows")
node1.stress(['write', 'n=10K', 'no-warmup', '-rate',
'threads=8', '-schema', 'replication(factor=2)'])
@@ -260,7 +260,7 @@ class TestBootstrap(Tester):
logger.debug("Bootstrap node 2 with delay")
node2 = new_node(cluster, byteman_port='4200')
node2.update_startup_byteman_script('./byteman/bootstrap_5s_sleep.btm')
- node2.start(wait_for_binary_proto=True, wait_other_notice=True)
+ node2.start(wait_for_binary_proto=True)
assert_bootstrap_state(self, node2, 'COMPLETED')
assert node2.grep_log('Bootstrap
[jira] [Updated] (CASSANDRA-16117) Improve docs about frozen types and invert UDT/Tuple order
[ https://issues.apache.org/jira/browse/CASSANDRA-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16117: --- Reviewers: Benedict Elliott Smith, Benjamin Lerer > Improve docs about frozen types and invert UDT/Tuple order > -- > > Key: CASSANDRA-16117 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16117 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Fábio Takeo Ueno >Assignee: Fábio Takeo Ueno >Priority: Low > Fix For: 4.0, 4.0-beta > > Time Spent: 1h > Remaining Estimate: 0h > > Currently, there's no documentation regarding frozen/non-frozen types. > Also, a tuple is mentioned after the definition of UDT: "tuples can be though > as anonymous UDT with anonymous fields". Since in the code base a UDT is an > extension of a tuple, it would be nice to invert these in the docs. > This issue addresses both topics. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16117) Improve docs about frozen types and invert UDT/Tuple order
[ https://issues.apache.org/jira/browse/CASSANDRA-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16117: --- Reviewers: Benedict Elliott Smith, Benjamin Lerer, Benjamin Lerer (was: Benedict Elliott Smith, Benjamin Lerer) Benedict Elliott Smith, Benjamin Lerer, Benjamin Lerer (was: Benedict Elliott Smith, Benjamin Lerer) Status: Review In Progress (was: Patch Available) > Improve docs about frozen types and invert UDT/Tuple order > -- > > Key: CASSANDRA-16117 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16117 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Fábio Takeo Ueno >Assignee: Fábio Takeo Ueno >Priority: Low > Fix For: 4.0, 4.0-beta > > Time Spent: 1h > Remaining Estimate: 0h > > Currently, there's no documentation regarding frozen/non-frozen types. > Also, a tuple is mentioned after the definition of UDT: "tuples can be though > as anonymous UDT with anonymous fields". Since in the code base a UDT is an > extension of a tuple, it would be nice to invert these in the docs. > This issue addresses both topics. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-15164: --- Status: Patch Available (was: In Progress) > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15854) Truncation should fail any ongoing repairs
[ https://issues.apache.org/jira/browse/CASSANDRA-15854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201439#comment-17201439 ] Marcus Eriksson commented on CASSANDRA-15854: - Rewrote the test again, ran it in a loop 80 times with lower resources, no failures Noticed that we stream even if the repair fails right before we get the validation response, that might have been what caused your failure. > Truncation should fail any ongoing repairs > -- > > Key: CASSANDRA-15854 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15854 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta > > > Truncation may race with ongoing repairs, making it possible to clear data on > one node but then stream data its truncation would have deleted from another > node. We should abort any ongoing preview repairs if we get a truncation > request. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch master updated: upgrade jolokia agent to 1.6.2 and drop remove_perf_disable_shared_mem workaround
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/master by this push:
new 92385ca upgrade jolokia agent to 1.6.2 and drop
remove_perf_disable_shared_mem workaround
92385ca is described below
commit 92385ca4e8392bec5247af58f274491673ea0036
Author: Christopher Lambert
AuthorDate: Thu Sep 24 09:17:05 2020 +0200
upgrade jolokia agent to 1.6.2 and drop remove_perf_disable_shared_mem
workaround
https://github.com/rhuss/jolokia/issues/198 has been fixed since jolokia
1.3.7,
so there is no reason to keep the remove_perf_disable_shared_mem workaround
anymore.
It is assumed that the '-XX:-PerfDisableSharedMem' usage was added
exclusively for
jolokia as well.
patch by Christopher Lambert; reviewed by Mick Semb Wever
---
README.md | 2 --
auth_test.py | 4 +---
batch_test.py | 9 +---
configuration_test.py | 7 +-
consistency_test.py| 3 +--
cql_tracing_test.py| 3 +--
deletion_test.py | 7 +-
disk_balance_test.py | 4 +---
dtest_setup.py | 1 -
jmx_test.py| 7 +-
lib/jolokia-jvm-1.2.3-agent.jar| Bin 395172 -> 0 bytes
lib/jolokia-jvm-1.6.2-agent.jar| Bin 0 -> 465081 bytes
...ent.jar.txt => jolokia-jvm-1.6.2-agent.jar.txt} | 0
materialized_views_test.py | 5 +
nodetool_test.py | 3 +--
repair_tests/deprecated_repair_test.py | 4 +---
repair_tests/incremental_repair_test.py| 3 +--
snitch_test.py | 5 +
thrift_hsha_test.py| 3 +--
tools/jmxutils.py | 24 +
upgrade_tests/regression_test.py | 2 +-
upgrade_tests/upgrade_base.py | 9
22 files changed, 16 insertions(+), 89 deletions(-)
diff --git a/README.md b/README.md
index 4e64587..219 100644
--- a/README.md
+++ b/README.md
@@ -101,8 +101,6 @@ JAVA7_HOME and JAVA8_HOME, respectively.
Writing Tests
-
-- If you're using JMX via [the `tools.jmxutils` module](tools/jmxutils.py),
make sure to call `remove_perf_disable_shared_mem` on the node or nodes you
want to query with JMX _before starting the nodes_.
`remove_perf_disable_shared_mem` disables a JVM option that's incompatible with
JMX (see [this JMX ticket](https://github.com/rhuss/jolokia/issues/198)). It
works by performing a string replacement in the node's Cassandra startup
script, so changes will only propagate to the node at star [...]
-
If you'd like to know what to expect during a code review, please see the
included [CONTRIBUTING file](CONTRIBUTING.md).
Debugging Tests
diff --git a/auth_test.py b/auth_test.py
index 4f12175..1061b17 100644
--- a/auth_test.py
+++ b/auth_test.py
@@ -17,8 +17,7 @@ from dtest import Tester
from tools.assertions import (assert_all, assert_exception, assert_invalid,
assert_length_equal, assert_one,
assert_unauthorized)
-from tools.jmxutils import (JolokiaAgent, make_mbean,
-remove_perf_disable_shared_mem)
+from tools.jmxutils import (JolokiaAgent, make_mbean)
from tools.metadata_wrapper import UpdatingKeyspaceMetadataWrapper
from tools.misc import ImmutableMapping
@@ -1056,7 +1055,6 @@ class TestAuth(Tester):
cluster.set_datadir_count(1)
cluster.populate(1)
[node] = cluster.nodelist()
-remove_perf_disable_shared_mem(node)
cluster.start()
with JolokiaAgent(node) as jmx:
diff --git a/batch_test.py b/batch_test.py
index f10b78a..4091974 100644
--- a/batch_test.py
+++ b/batch_test.py
@@ -9,8 +9,7 @@ from cassandra.query import SimpleStatement
from dtest import Tester, create_ks
from tools.assertions import (assert_all, assert_invalid, assert_one,
assert_unavailable)
-from tools.jmxutils import (JolokiaAgent, make_mbean,
-remove_perf_disable_shared_mem)
+from tools.jmxutils import (JolokiaAgent, make_mbean)
since = pytest.mark.since
logger = logging.getLogger(__name__)
@@ -438,10 +437,6 @@ class TestBatch(Tester):
logger.debug("Set cassandra dir to
{}".format(self.cluster.get_install_dir()))
self.cluster.populate(nodes, install_byteman=install_byteman)
-
-for n in self.cluster.nodelist():
-r
[jira] [Comment Edited] (CASSANDRA-15854) Truncation should fail any ongoing repairs
[
https://issues.apache.org/jira/browse/CASSANDRA-15854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201439#comment-17201439
]
Marcus Eriksson edited comment on CASSANDRA-15854 at 9/24/20, 11:09 AM:
Rewrote the test again, ran it in a loop 80 times with lower resources, no
failures
Noticed that we stream even if the repair fails right before we get the
validation response, that might have been what caused your failure.
cci run:
https://app.circleci.com/pipelines/github/krummas/cassandra/541/workflows/8d3cbf9c-6556-45d9-b993-e258b3211323
seems {{IncrementalRepairCoordinatorTimeoutTest}} failed, looks unrelated and
passes locally
was (Author: krummas):
Rewrote the test again, ran it in a loop 80 times with lower resources, no
failures
Noticed that we stream even if the repair fails right before we get the
validation response, that might have been what caused your failure.
> Truncation should fail any ongoing repairs
> --
>
> Key: CASSANDRA-15854
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15854
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Truncation may race with ongoing repairs, making it possible to clear data on
> one node but then stream data its truncation would have deleted from another
> node. We should abort any ongoing preview repairs if we get a truncation
> request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16128) Jenkins: dsl for website build, logging repo SHAs, and using nightlies.a.o instead of archiving
[ https://issues.apache.org/jira/browse/CASSANDRA-16128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16128: --- Fix Version/s: 3.11.x 3.0.x 2.2.x > Jenkins: dsl for website build, logging repo SHAs, and using nightlies.a.o > instead of archiving > --- > > Key: CASSANDRA-16128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16128 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Jenkins improvements > 1. Add the cassandra-website job into cassandra_job_dsl.seed.groovy (so we > don't lose it next time the Jenkins master is corrupted) > 2. Print the SHAs of the different git repos used during the build process. > Also store them in the .head files (so the pipeline can print them out too). > 3. Instead of archiving artefacts, ssh them to > https://nightlies.apache.org/cassandra/ > (Disk usage on agents is largely under control, but disk usage on master was > the new problem. The suspicion here is the Cassandra-*-artifact's artefacts > was the disk usage culprit, though we have to evidence to support it.) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso reassigned CASSANDRA-16093: -- Assignee: Anthony Grasso (was: Michael Semb Wever) > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16093: --- Reviewers: Anthony Grasso, Anthony Grasso (was: Anthony Grasso) Anthony Grasso, Anthony Grasso (was: Anthony Grasso) Status: Review In Progress (was: Patch Available) > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201460#comment-17201460 ] Anthony Grasso commented on CASSANDRA-16093: Reviewing In-tree patch > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201463#comment-17201463 ] Anthony Grasso commented on CASSANDRA-16093: Change in commit [df54117|https://github.com/apache/cassandra/commit/df54117e9ef4f07d84592a925d6a0a92489d68ac] looks good to me. > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16093: --- Authors: Michael Semb Wever (was: Anthony Grasso) > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201466#comment-17201466 ] Benjamin Lerer commented on CASSANDRA-16093: +1 > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Cassandra website is building/including the wrong versioned nodetool docs
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 3db6444 Cassandra website is building/including the wrong versioned nodetool docs 3db6444 is described below commit 3db64445f90e6fdb5ef550fc37dd7e8cd1161561 Author: Mick Semb Wever AuthorDate: Wed Sep 2 18:15:54 2020 +0200 Cassandra website is building/including the wrong versioned nodetool docs patch by Mick Semb Wever; reviewed by Anthony Grasso, Benjamin Lerer for CASSANDRA-16093 --- build.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/build.xml b/build.xml index 8c9c49d..b3ba554 100644 --- a/build.xml +++ b/build.xml @@ -381,6 +381,7 @@ +
[jira] [Updated] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16093: --- Status: Ready to Commit (was: Review In Progress) > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16093) Cassandra website is building/including the wrong versioned nodetool docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16093: --- Source Control Link: https://github.com/apache/cassandra-website/commit/6ac702768d90421c4b8b1eb0762a4f3cca65bb1e https://github.com/apache/cassandra/commit/3db64445f90e6fdb5ef550fc37dd7e8cd1161561 (was: https://github.com/apache/cassandra-website/commit/6ac702768d90421c4b8b1eb0762a4f3cca65bb1e) Resolution: Fixed Status: Resolved (was: Ready to Commit) In-tree patch committed with [3db64445f90e6fdb5ef550fc37dd7e8cd1161561|https://github.com/apache/cassandra/commit/3db64445f90e6fdb5ef550fc37dd7e8cd1161561]. > Cassandra website is building/including the wrong versioned nodetool docs > - > > Key: CASSANDRA-16093 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16093 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > Fix For: 3.11.9, 4.0-beta3 > > > For example > https://cassandra.apache.org/doc/3.11/tools/nodetool/enablefullquerylog.html > shouldn't be under the 3.11 documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15958) org.apache.cassandra.net.ConnectionTest testMessagePurging
[ https://issues.apache.org/jira/browse/CASSANDRA-15958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201511#comment-17201511 ] Ekaterina Dimitrova commented on CASSANDRA-15958: - Is a second reviewer needed? > org.apache.cassandra.net.ConnectionTest testMessagePurging > -- > > Key: CASSANDRA-15958 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15958 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Adam Holmberg >Priority: Normal > Fix For: 4.0-beta > > > Build: > https://ci-cassandra.apache.org/job/Cassandra-trunk-test/196/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessagePurging/ > Build: > https://ci-cassandra.apache.org/job/Cassandra-trunk-test/194/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessagePurging/ > java.util.concurrent.TimeoutException > at org.apache.cassandra.net.AsyncPromise.get(AsyncPromise.java:258) > at org.apache.cassandra.net.FutureDelegate.get(FutureDelegate.java:143) > at > org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:268) > at > org.apache.cassandra.net.ConnectionTest.testManual(ConnectionTest.java:236) > at > org.apache.cassandra.net.ConnectionTest.testMessagePurging(ConnectionTest.java:679) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14157) [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
[
https://issues.apache.org/jira/browse/CASSANDRA-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-14157:
Fix Version/s: 4.0-beta3
> [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
> -
>
> Key: CASSANDRA-14157
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14157
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Kjellman
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Labels: dtest
> Fix For: 4.0-beta3
>
>
> test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed it's assertion once today in a
> circleci run. the dtests were running against trunk.
> Although it has failed once so far, a quick read of the comments in the test
> seems to indicate that the assertion failing this way might mean that
> CASSANDRA-13964 didn't fully fix the issue.
> {code:python}
> if jmx.has_mbean(rr_count):
> # expect 0 digest mismatches
> > assert 0 == jmx.read_attribute(rr_count, 'Count')
> E AssertionError: assert 0 == 1
> E+ where 1 = 0x7f62d4156898>>('org.apache.cassandra.metrics:type=ReadRepair,name=RepairedBlocking',
> 'Count')
> E+where > =
> .read_attribute
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14157) [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
[
https://issues.apache.org/jira/browse/CASSANDRA-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201517#comment-17201517
]
Ekaterina Dimitrova commented on CASSANDRA-14157:
-
Hi [~samt], do you plan to work on this ticket?
I saw this failure again today:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77/jobs/2116
> [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
> -
>
> Key: CASSANDRA-14157
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14157
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Kjellman
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Labels: dtest
> Fix For: 4.0-beta3
>
>
> test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed it's assertion once today in a
> circleci run. the dtests were running against trunk.
> Although it has failed once so far, a quick read of the comments in the test
> seems to indicate that the assertion failing this way might mean that
> CASSANDRA-13964 didn't fully fix the issue.
> {code:python}
> if jmx.has_mbean(rr_count):
> # expect 0 digest mismatches
> > assert 0 == jmx.read_attribute(rr_count, 'Count')
> E AssertionError: assert 0 == 1
> E+ where 1 = 0x7f62d4156898>>('org.apache.cassandra.metrics:type=ReadRepair,name=RepairedBlocking',
> 'Count')
> E+where > =
> .read_attribute
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16063) Fix user experience when upgrading to 4.0 with compact tables
[
https://issues.apache.org/jira/browse/CASSANDRA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201519#comment-17201519
]
Ekaterina Dimitrova commented on CASSANDRA-16063:
-
Detailed code review showed the error I was getting as not being related. Empty
segments should be skipped on startup.
I recreated my test environment. Managed to fix my issues with running the
upgrade tests locally.
No flag is needed.
This is how the solution works now:
These are the four branches I worked on for this patch:
[C*
3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.0]
| [C*
3.11|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.11]
| [trunk
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063]|
[DTests|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-16063]
1) Check SSTables for latest version before dropping compact storage commits -
[3.0|https://github.com/ekaterinadimitrova2/cassandra/commit/9ff9130808c751c9253bdecaa27c453bb5e7a71c]
and
[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/c0c43e90644b28b9b363fa7aba55adbf95dd5bd7]
2) Move compact storage [validation
|https://github.com/ekaterinadimitrova2/cassandra/commit/1a8b3ea2823d8424e2018c686fb2d6e5d67270f7#diff-a5df240149285ae528cdd3c41aa59360R104]
is moved earlier in startup process.
4) Two new upgrade tests created and an old one was fixed
[here|https://github.com/ekaterinadimitrova2/cassandra-dtest/commits/CASSANDRA-16063]
Trunk CI run:
[java
8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77]
and [Java
11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77]
CI runs did not show any new issues introduced. The two failing tests already
have opened corresponding tickets:
_test_tracing_does_not_interfere_with_digest_calculation -
cql_tracing_test.TestCqlTracing - CASSANDRA-14157_
_testMessagePurging - org.apache.cassandra.net.ConnectionTest -
CASSANDRA-15958_
Attached is the log of the upgrade tests successfully passing
[~slebresne] do you have time to review it again? Or maybe [~adelapena] can
help here?
> Fix user experience when upgrading to 4.0 with compact tables
> -
>
> Key: CASSANDRA-16063
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16063
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Sylvain Lebresne
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Compact_storage_upgrade_tests.txt
>
>
> The code to handle compact tables has been removed from 4.0, and the intended
> upgrade path to 4.0 for users having compact tables on 3.x is that they must
> execute {{ALTER ... DROP COMPACT STORAGE}} on all of their compact tables
> *before* attempting the upgrade.
> Obviously, some users won't read the upgrade instructions (or miss a table)
> and may try upgrading despite still having compact tables. If they do so, the
> intent is that the node will _not_ start, with a message clearly indicating
> the pre-upgrade step the user has missed. The user will then downgrade back
> the node(s) to 3.x, run the proper {{ALTER ... DROP COMPACT STORAGE}}, and
> then upgrade again.
> But while 4.0 does currently fail startup when finding any compact tables
> with a decent message, I believe the check is done too late during startup.
> Namely, that check is done as we read the tables schema, so within
> [{{Schema.instance.loadFromDisk()}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/CassandraDaemon.java#L241].
> But by then, we've _at least_ called
> {{SystemKeyspace.persistLocalMetadata()}}} and
> {{SystemKeyspaceMigrator40.migrate()}}, which will get into the commit log,
> and even possibly flush new {{na}} format sstables. As a results, a user
> might not be able to seemlessly restart the node on 3.x (to drop compact
> storage on the appropriate tables).
> Basically, we should make sure the check for compact tables done at 4.0
> startup is done as a {{StartupCheck}}, before the node does anything.
> We should also add a test for this (checking that if you try upgrading to 4.0
> with compact storage, you can downgrade back with no intervention whatsoever).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16063) Fix user experience when upgrading to 4.0 with compact tables
[
https://issues.apache.org/jira/browse/CASSANDRA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16063:
Attachment: Compact_storage_upgrade_tests.txt
> Fix user experience when upgrading to 4.0 with compact tables
> -
>
> Key: CASSANDRA-16063
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16063
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Sylvain Lebresne
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Compact_storage_upgrade_tests.txt
>
>
> The code to handle compact tables has been removed from 4.0, and the intended
> upgrade path to 4.0 for users having compact tables on 3.x is that they must
> execute {{ALTER ... DROP COMPACT STORAGE}} on all of their compact tables
> *before* attempting the upgrade.
> Obviously, some users won't read the upgrade instructions (or miss a table)
> and may try upgrading despite still having compact tables. If they do so, the
> intent is that the node will _not_ start, with a message clearly indicating
> the pre-upgrade step the user has missed. The user will then downgrade back
> the node(s) to 3.x, run the proper {{ALTER ... DROP COMPACT STORAGE}}, and
> then upgrade again.
> But while 4.0 does currently fail startup when finding any compact tables
> with a decent message, I believe the check is done too late during startup.
> Namely, that check is done as we read the tables schema, so within
> [{{Schema.instance.loadFromDisk()}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/CassandraDaemon.java#L241].
> But by then, we've _at least_ called
> {{SystemKeyspace.persistLocalMetadata()}}} and
> {{SystemKeyspaceMigrator40.migrate()}}, which will get into the commit log,
> and even possibly flush new {{na}} format sstables. As a results, a user
> might not be able to seemlessly restart the node on 3.x (to drop compact
> storage on the appropriate tables).
> Basically, we should make sure the check for compact tables done at 4.0
> startup is done as a {{StartupCheck}}, before the node does anything.
> We should also add a test for this (checking that if you try upgrading to 4.0
> with compact storage, you can downgrade back with no intervention whatsoever).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16074) Add metric for client concurrent byte throttle
[ https://issues.apache.org/jira/browse/CASSANDRA-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-16074: -- Status: Review In Progress (was: Changes Suggested) > Add metric for client concurrent byte throttle > -- > > Key: CASSANDRA-16074 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16074 > Project: Cassandra > Issue Type: New Feature > Components: Messaging/Client, Observability/Metrics >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Normal > Fix For: 4.0-beta > > > Add a metric to expose the current bytes and bytes per ip used that is used > in the existing throttle so its possible to determine what to set it to. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16063) Fix user experience when upgrading to 4.0 with compact tables
[ https://issues.apache.org/jira/browse/CASSANDRA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201519#comment-17201519 ] Ekaterina Dimitrova edited comment on CASSANDRA-16063 at 9/24/20, 1:28 PM: --- Detailed code review showed the error I was getting as not being related. Empty segments should be skipped on startup. I recreated my test environment. Managed to fix my issues with running the upgrade tests locally. No flag is needed. This is how the solution works now: These are the four branches I worked on for this patch: [C* 3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.0] | [C* 3.11|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.11] | [trunk |https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063]| [DTests|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-16063] 1) Check SSTables for latest version before dropping compact storage commits - [3.0|https://github.com/ekaterinadimitrova2/cassandra/commit/9ff9130808c751c9253bdecaa27c453bb5e7a71c] and [3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/c0c43e90644b28b9b363fa7aba55adbf95dd5bd7] 2) Move compact storage [validation |https://github.com/ekaterinadimitrova2/cassandra/commit/1a8b3ea2823d8424e2018c686fb2d6e5d67270f7#diff-a5df240149285ae528cdd3c41aa59360R104] earlier in the startup process. 4) Two new upgrade tests created and an old one was fixed [here|https://github.com/ekaterinadimitrova2/cassandra-dtest/commits/CASSANDRA-16063] Trunk CI run: [java 8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] and [Java 11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] CI runs did not show any new issues introduced. The two failing tests already have opened corresponding tickets: _test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing - CASSANDRA-14157_ _testMessagePurging - org.apache.cassandra.net.ConnectionTest - CASSANDRA-15958_ Attached is the log of the upgrade tests successfully passing [~slebresne] do you have time to review it again? Or maybe [~adelapena] can help here? was (Author: e.dimitrova): Detailed code review showed the error I was getting as not being related. Empty segments should be skipped on startup. I recreated my test environment. Managed to fix my issues with running the upgrade tests locally. No flag is needed. This is how the solution works now: These are the four branches I worked on for this patch: [C* 3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.0] | [C* 3.11|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.11] | [trunk |https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063]| [DTests|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-16063] 1) Check SSTables for latest version before dropping compact storage commits - [3.0|https://github.com/ekaterinadimitrova2/cassandra/commit/9ff9130808c751c9253bdecaa27c453bb5e7a71c] and [3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/c0c43e90644b28b9b363fa7aba55adbf95dd5bd7] 2) Move compact storage [validation |https://github.com/ekaterinadimitrova2/cassandra/commit/1a8b3ea2823d8424e2018c686fb2d6e5d67270f7#diff-a5df240149285ae528cdd3c41aa59360R104] is moved earlier in startup process. 4) Two new upgrade tests created and an old one was fixed [here|https://github.com/ekaterinadimitrova2/cassandra-dtest/commits/CASSANDRA-16063] Trunk CI run: [java 8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] and [Java 11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] CI runs did not show any new issues introduced. The two failing tests already have opened corresponding tickets: _test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing - CASSANDRA-14157_ _testMessagePurging - org.apache.cassandra.net.ConnectionTest - CASSANDRA-15958_ Attached is the log of the upgrade tests successfully passing [~slebresne] do you have time to review it again? Or maybe [~adelapena] can help here? > Fix user experience when upgrading to 4.0 with compact tables > - > > Key: CASSANDRA-16063 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16063 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Sylvain Lebresne >Assignee: Ekaterina Dimitrova >Priority: Normal >
[jira] [Comment Edited] (CASSANDRA-16063) Fix user experience when upgrading to 4.0 with compact tables
[ https://issues.apache.org/jira/browse/CASSANDRA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201519#comment-17201519 ] Ekaterina Dimitrova edited comment on CASSANDRA-16063 at 9/24/20, 1:29 PM: --- Detailed code review showed the error I was getting as not being related. Empty segments should be skipped on startup. I recreated my test environment. Managed to fix my issues with running the upgrade tests locally. No flag is needed. This is how the solution works now: These are the four branches I worked on for this patch: [C* 3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.0] | [C* 3.11|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.11] | [trunk |https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063]| [DTests|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-16063] 1) Check SSTables for latest version before dropping compact storage commits - [3.0|https://github.com/ekaterinadimitrova2/cassandra/commit/9ff9130808c751c9253bdecaa27c453bb5e7a71c] and [3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/c0c43e90644b28b9b363fa7aba55adbf95dd5bd7] 2) Move compact storage [validation |https://github.com/ekaterinadimitrova2/cassandra/commit/1a8b3ea2823d8424e2018c686fb2d6e5d67270f7#diff-a5df240149285ae528cdd3c41aa59360R104] earlier in the startup process. 4) Two new upgrade tests created and an old one was fixed [here|https://github.com/ekaterinadimitrova2/cassandra-dtest/commits/CASSANDRA-16063] Trunk CI run: [Java 8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] and [Java 11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] CI runs did not show any new issues introduced. The two failing tests already have opened corresponding tickets: _test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing - CASSANDRA-14157_ _testMessagePurging - org.apache.cassandra.net.ConnectionTest - CASSANDRA-15958_ Attached is the log of the upgrade tests successfully passing [~slebresne] do you have time to review it again? Or maybe [~adelapena] can help here? was (Author: e.dimitrova): Detailed code review showed the error I was getting as not being related. Empty segments should be skipped on startup. I recreated my test environment. Managed to fix my issues with running the upgrade tests locally. No flag is needed. This is how the solution works now: These are the four branches I worked on for this patch: [C* 3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.0] | [C* 3.11|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063-3.11] | [trunk |https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-16063]| [DTests|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-16063] 1) Check SSTables for latest version before dropping compact storage commits - [3.0|https://github.com/ekaterinadimitrova2/cassandra/commit/9ff9130808c751c9253bdecaa27c453bb5e7a71c] and [3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/c0c43e90644b28b9b363fa7aba55adbf95dd5bd7] 2) Move compact storage [validation |https://github.com/ekaterinadimitrova2/cassandra/commit/1a8b3ea2823d8424e2018c686fb2d6e5d67270f7#diff-a5df240149285ae528cdd3c41aa59360R104] earlier in the startup process. 4) Two new upgrade tests created and an old one was fixed [here|https://github.com/ekaterinadimitrova2/cassandra-dtest/commits/CASSANDRA-16063] Trunk CI run: [java 8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] and [Java 11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/349/workflows/04bccc52-4e3e-41e2-9c04-93501ea4ce77] CI runs did not show any new issues introduced. The two failing tests already have opened corresponding tickets: _test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing - CASSANDRA-14157_ _testMessagePurging - org.apache.cassandra.net.ConnectionTest - CASSANDRA-15958_ Attached is the log of the upgrade tests successfully passing [~slebresne] do you have time to review it again? Or maybe [~adelapena] can help here? > Fix user experience when upgrading to 4.0 with compact tables > - > > Key: CASSANDRA-16063 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16063 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Sylvain Lebresne >Assignee: Ekaterina Dimitrova >Priority: Normal >
[jira] [Updated] (CASSANDRA-16063) Fix user experience when upgrading to 4.0 with compact tables
[
https://issues.apache.org/jira/browse/CASSANDRA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16063:
Test and Documentation Plan:
https://issues.apache.org/jira/browse/CASSANDRA-16063?focusedCommentId=17201519&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17201519
(was:
https://issues.apache.org/jira/browse/CASSANDRA-16063?focusedCommentId=17186245&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17186245)
Status: Patch Available (was: In Progress)
> Fix user experience when upgrading to 4.0 with compact tables
> -
>
> Key: CASSANDRA-16063
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16063
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Sylvain Lebresne
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Compact_storage_upgrade_tests.txt
>
>
> The code to handle compact tables has been removed from 4.0, and the intended
> upgrade path to 4.0 for users having compact tables on 3.x is that they must
> execute {{ALTER ... DROP COMPACT STORAGE}} on all of their compact tables
> *before* attempting the upgrade.
> Obviously, some users won't read the upgrade instructions (or miss a table)
> and may try upgrading despite still having compact tables. If they do so, the
> intent is that the node will _not_ start, with a message clearly indicating
> the pre-upgrade step the user has missed. The user will then downgrade back
> the node(s) to 3.x, run the proper {{ALTER ... DROP COMPACT STORAGE}}, and
> then upgrade again.
> But while 4.0 does currently fail startup when finding any compact tables
> with a decent message, I believe the check is done too late during startup.
> Namely, that check is done as we read the tables schema, so within
> [{{Schema.instance.loadFromDisk()}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/CassandraDaemon.java#L241].
> But by then, we've _at least_ called
> {{SystemKeyspace.persistLocalMetadata()}}} and
> {{SystemKeyspaceMigrator40.migrate()}}, which will get into the commit log,
> and even possibly flush new {{na}} format sstables. As a results, a user
> might not be able to seemlessly restart the node on 3.x (to drop compact
> storage on the appropriate tables).
> Basically, we should make sure the check for compact tables done at 4.0
> startup is done as a {{StartupCheck}}, before the node does anything.
> We should also add a test for this (checking that if you try upgrading to 4.0
> with compact storage, you can downgrade back with no intervention whatsoever).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14157) [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
[
https://issues.apache.org/jira/browse/CASSANDRA-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201559#comment-17201559
]
Sam Tunnicliffe commented on CASSANDRA-14157:
-
Hey [~e.dimitrova], I'm afraid I don't have capacity to pick it up right now,
so feel free to take it if you like.
> [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
> -
>
> Key: CASSANDRA-14157
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14157
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Kjellman
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Labels: dtest
> Fix For: 4.0-beta3
>
>
> test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed it's assertion once today in a
> circleci run. the dtests were running against trunk.
> Although it has failed once so far, a quick read of the comments in the test
> seems to indicate that the assertion failing this way might mean that
> CASSANDRA-13964 didn't fully fix the issue.
> {code:python}
> if jmx.has_mbean(rr_count):
> # expect 0 digest mismatches
> > assert 0 == jmx.read_attribute(rr_count, 'Count')
> E AssertionError: assert 0 == 1
> E+ where 1 = 0x7f62d4156898>>('org.apache.cassandra.metrics:type=ReadRepair,name=RepairedBlocking',
> 'Count')
> E+where > =
> .read_attribute
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14157) [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
[
https://issues.apache.org/jira/browse/CASSANDRA-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova reassigned CASSANDRA-14157:
---
Assignee: (was: Sam Tunnicliffe)
> [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
> -
>
> Key: CASSANDRA-14157
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14157
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Kjellman
>Priority: Normal
> Labels: dtest
> Fix For: 4.0-beta3
>
>
> test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed it's assertion once today in a
> circleci run. the dtests were running against trunk.
> Although it has failed once so far, a quick read of the comments in the test
> seems to indicate that the assertion failing this way might mean that
> CASSANDRA-13964 didn't fully fix the issue.
> {code:python}
> if jmx.has_mbean(rr_count):
> # expect 0 digest mismatches
> > assert 0 == jmx.read_attribute(rr_count, 'Count')
> E AssertionError: assert 0 == 1
> E+ where 1 = 0x7f62d4156898>>('org.apache.cassandra.metrics:type=ReadRepair,name=RepairedBlocking',
> 'Count')
> E+where > =
> .read_attribute
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14157) [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
[
https://issues.apache.org/jira/browse/CASSANDRA-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201560#comment-17201560
]
Ekaterina Dimitrova commented on CASSANDRA-14157:
-
Thanks for confirming [~samt] . I left it unassigned In case someone is
interested, otherwise, probably I will try to look into it next week.
> [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
> -
>
> Key: CASSANDRA-14157
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14157
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Kjellman
>Priority: Normal
> Labels: dtest
> Fix For: 4.0-beta3
>
>
> test_tracing_does_not_interfere_with_digest_calculation -
> cql_tracing_test.TestCqlTracing failed it's assertion once today in a
> circleci run. the dtests were running against trunk.
> Although it has failed once so far, a quick read of the comments in the test
> seems to indicate that the assertion failing this way might mean that
> CASSANDRA-13964 didn't fully fix the issue.
> {code:python}
> if jmx.has_mbean(rr_count):
> # expect 0 digest mismatches
> > assert 0 == jmx.read_attribute(rr_count, 'Count')
> E AssertionError: assert 0 == 1
> E+ where 1 = 0x7f62d4156898>>('org.apache.cassandra.metrics:type=ReadRepair,name=RepairedBlocking',
> 'Count')
> E+where > =
> .read_attribute
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 created (now 3db6444)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. at 3db6444 Cassandra website is building/including the wrong versioned nodetool docs No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15160) Add flag to ignore unreplicated keyspaces during repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201566#comment-17201566
]
Marcus Eriksson commented on CASSANDRA-15160:
-
ran 2.2 cci against the dtest branch
[here|https://app.circleci.com/pipelines/github/krummas/cassandra/542/workflows/1a3f6d7c-53ad-4683-81b9-8a9f2ffc4259]
- unclear what is going on with TestCqlsh, but no failures in
deprecated_repair_test.py
> Add flag to ignore unreplicated keyspaces during repair
> ---
>
> Key: CASSANDRA-15160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15160
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
>
> When a repair is triggered on a node in 'dc2' for a keyspace with replication
> factor {'dc1':3, 'dc2':0} we just ignore the repair in versions < 3. In 3.0+
> we fail the repair to make sure the operator does not think the keyspace is
> fully repaired.
> There might be tooling that relies on the old behaviour though, so we should
> add a flag to ignore those unreplicated keyspaces
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[
https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-15164:
Test and Documentation Plan: new tests to verify EstimatedHistogram
overflow clearing and overflowed histograms instats deserialization (was:
minor new unit test to verify changes to the logic in {{StatsMetadata}})
> Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
> ---
>
> Key: CASSANDRA-15164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15164
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Ankur Jha
>Assignee: Caleb Rackliffe
>Priority: Urgent
> Labels: compaction, partition
> Fix For: 4.0-beta
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Hi, we are running 6 node Cassandra cluster in production with 3 seed node
> but from last night one of our seed nodes is continuously throwing an error
> like this;-
> cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max
> when histogram overflowed">
> For a cluster to be up and running I Drained this node.
> Can somebody help me out with this?
>
> Any help or lead would be appreciated
>
> Note : We are using Cassandra version 3.7
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15164: -- Fix Version/s: 3.11.9 3.0.23 > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta, 3.0.23, 3.11.9 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16134) Fix architecture docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201576#comment-17201576 ] Fábio Takeo Ueno commented on CASSANDRA-16134: -- [~polandll], i see. Sorry, I didn't know about this... Should I drop this issue? How should I proceed? > Fix architecture docs > - > > Key: CASSANDRA-16134 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16134 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Fábio Takeo Ueno >Assignee: Fábio Takeo Ueno >Priority: Normal > > There are minor issues like formatting and punctuation in docs about > architecture. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated: Avoid failing compactions with very large partitions
This is an automated email from the ASF dual-hosted git repository.
clohfink pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.11 by this push:
new 0361d53 Avoid failing compactions with very large partitions
0361d53 is described below
commit 0361d53f4c9d350654fbf733cfdb208d17922027
Author: Caleb Rackliffe
AuthorDate: Thu Sep 24 10:56:14 2020 -0500
Avoid failing compactions with very large partitions
Patch by Caleb Rackliffe; Reviewed by Chris Lohfink and Benjamin Lerer for
CASSANDRA-15164
---
CHANGES.txt| 1 +
.../io/sstable/metadata/MetadataCollector.java | 4 +--
.../io/sstable/metadata/StatsMetadata.java | 25 +
.../apache/cassandra/utils/EstimatedHistogram.java | 31 +++---
.../sstable/metadata/MetadataSerializerTest.java | 29
.../cassandra/utils/EstimatedHistogramTest.java| 12 +
.../apache/cassandra/utils/SerializationsTest.java | 2 +-
7 files changed, 98 insertions(+), 6 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 99083b1..b5b0cbc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.11.9
+ * Avoid failing compactions with very large partitions (CASSANDRA-15164)
* Make sure LCS handles duplicate sstable added/removed notifications
correctly (CASSANDRA-14103)
3.11.8
diff --git
a/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
b/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
index ea88a3f..3354e2b 100644
--- a/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
+++ b/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
@@ -51,8 +51,8 @@ public class MetadataCollector implements
PartitionStatisticsCollector
static EstimatedHistogram defaultCellPerPartitionCountHistogram()
{
-// EH of 114 can track a max value of 2395318855, i.e., > 2B columns
-return new EstimatedHistogram(114);
+// EH of 118 can track a max value of 4139110981, i.e., > 4B cells
+return new EstimatedHistogram(118);
}
static EstimatedHistogram defaultPartitionSizeHistogram()
diff --git
a/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
b/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
index 94e8d41..042e6d3 100644
--- a/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
+++ b/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
@@ -26,6 +26,9 @@ import org.apache.cassandra.io.ISerializer;
import org.apache.cassandra.io.sstable.format.Version;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.apache.cassandra.db.TypeSizes;
import org.apache.cassandra.db.commitlog.CommitLogPosition;
import org.apache.cassandra.db.commitlog.IntervalSet;
@@ -230,6 +233,8 @@ public class StatsMetadata extends MetadataComponent
public static class StatsMetadataSerializer implements
IMetadataComponentSerializer
{
+private static final Logger logger =
LoggerFactory.getLogger(StatsMetadataSerializer.class);
+
public int serializedSize(Version version, StatsMetadata component)
throws IOException
{
int size = 0;
@@ -302,9 +307,29 @@ public class StatsMetadata extends MetadataComponent
public StatsMetadata deserialize(Version version, DataInputPlus in)
throws IOException
{
EstimatedHistogram partitionSizes =
EstimatedHistogram.serializer.deserialize(in);
+
+if (partitionSizes.isOverflowed())
+{
+logger.warn("Deserialized partition size histogram with {}
values greater than the maximum of {}. " +
+"Clearing the overflow bucket to allow for
degraded mean and percentile calculations...",
+partitionSizes.overflowCount(),
partitionSizes.getLargestBucketOffset());
+
+partitionSizes.clearOverflow();
+}
+
EstimatedHistogram columnCounts =
EstimatedHistogram.serializer.deserialize(in);
+if (columnCounts.isOverflowed())
+{
+logger.warn("Deserialized partition cell count histogram with
{} values greater than the maximum of {}. " +
+"Clearing the overflow bucket to allow for
degraded mean and percentile calculations...",
+columnCounts.overflowCount(),
columnCounts.getLargestBucketOffset());
+
+columnCounts.clearOverflow();
+}
+
CommitLogPosition commitLogLowerBound = CommitLogPosition.NONE,
commitLogUpperBound;
commitLogUpperBound = CommitLogPosition
[cassandra] branch cassandra-3.0 updated: Avoid failing compactions with very large partitions
This is an automated email from the ASF dual-hosted git repository.
clohfink pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 5a39ff4 Avoid failing compactions with very large partitions
5a39ff4 is described below
commit 5a39ff40780029c4d2125504b41fc7bf8e7fffe3
Author: Caleb Rackliffe
AuthorDate: Thu Sep 24 10:56:14 2020 -0500
Avoid failing compactions with very large partitions
Patch by Caleb Rackliffe; Reviewed by Chris Lohfink and Benjamin Lerer for
CASSANDRA-15164
---
CHANGES.txt| 1 +
.../io/sstable/metadata/MetadataCollector.java | 4 +--
.../io/sstable/metadata/StatsMetadata.java | 25 +
.../apache/cassandra/utils/EstimatedHistogram.java | 31 +++---
.../sstable/metadata/MetadataSerializerTest.java | 30 +
.../cassandra/utils/EstimatedHistogramTest.java| 12 +
.../apache/cassandra/utils/SerializationsTest.java | 2 +-
7 files changed, 99 insertions(+), 6 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 93e7a87..f3df5d0 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.23:
+ * Avoid failing compactions with very large partitions (CASSANDRA-15164)
* Use IF NOT EXISTS for index and UDT create statements in snapshot schema
files (CASSANDRA-13935)
3.0.22:
diff --git
a/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
b/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
index 867e9a1..ff4b06f 100644
--- a/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
+++ b/src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java
@@ -49,8 +49,8 @@ public class MetadataCollector implements
PartitionStatisticsCollector
static EstimatedHistogram defaultCellPerPartitionCountHistogram()
{
-// EH of 114 can track a max value of 2395318855, i.e., > 2B columns
-return new EstimatedHistogram(114);
+// EH of 118 can track a max value of 4139110981, i.e., > 4B cells
+return new EstimatedHistogram(118);
}
static EstimatedHistogram defaultPartitionSizeHistogram()
diff --git
a/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
b/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
index 1994bca..be6b430 100644
--- a/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
+++ b/src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
@@ -26,6 +26,9 @@ import org.apache.cassandra.io.ISerializer;
import org.apache.cassandra.io.sstable.format.Version;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.apache.cassandra.db.TypeSizes;
import org.apache.cassandra.db.commitlog.IntervalSet;
import org.apache.cassandra.db.commitlog.ReplayPosition;
@@ -230,6 +233,8 @@ public class StatsMetadata extends MetadataComponent
public static class StatsMetadataSerializer implements
IMetadataComponentSerializer
{
+private static final Logger logger =
LoggerFactory.getLogger(StatsMetadataSerializer.class);
+
public int serializedSize(Version version, StatsMetadata component)
throws IOException
{
int size = 0;
@@ -302,9 +307,29 @@ public class StatsMetadata extends MetadataComponent
public StatsMetadata deserialize(Version version, DataInputPlus in)
throws IOException
{
EstimatedHistogram partitionSizes =
EstimatedHistogram.serializer.deserialize(in);
+
+if (partitionSizes.isOverflowed())
+{
+logger.warn("Deserialized partition size histogram with {}
values greater than the maximum of {}. " +
+"Clearing the overflow bucket to allow for
degraded mean and percentile calculations...",
+partitionSizes.overflowCount(),
partitionSizes.getLargestBucketOffset());
+
+partitionSizes.clearOverflow();
+}
+
EstimatedHistogram columnCounts =
EstimatedHistogram.serializer.deserialize(in);
+if (columnCounts.isOverflowed())
+{
+logger.warn("Deserialized partition cell count histogram with
{} values greater than the maximum of {}. " +
+"Clearing the overflow bucket to allow for
degraded mean and percentile calculations...",
+columnCounts.overflowCount(),
columnCounts.getLargestBucketOffset());
+
+columnCounts.clearOverflow();
+}
+
ReplayPosition commitLogLowerBound = ReplayPosition.NONE,
commitLogUpperBound;
commitLogUpperBound = ReplayPosition.serialize
[jira] [Commented] (CASSANDRA-15160) Add flag to ignore unreplicated keyspaces during repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201619#comment-17201619
]
David Capwell commented on CASSANDRA-15160:
---
thats a known issue [~djoshi] said he would look into; a test runs in 2.2 but
uses a config added in 3.0, these tests have been failing for a long time now.
[~marcuse] thanks for running, can commit or ill commit it later today.
> Add flag to ignore unreplicated keyspaces during repair
> ---
>
> Key: CASSANDRA-15160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15160
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
>
> When a repair is triggered on a node in 'dc2' for a keyspace with replication
> factor {'dc1':3, 'dc2':0} we just ignore the repair in versions < 3. In 3.0+
> we fail the repair to make sure the operator does not think the keyspace is
> fully repaired.
> There might be tooling that relies on the old behaviour though, so we should
> add a flag to ignore those unreplicated keyspaces
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15854) Truncation should fail any ongoing repairs
[
https://issues.apache.org/jira/browse/CASSANDRA-15854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201623#comment-17201623
]
David Capwell commented on CASSANDRA-15854:
---
thanks, ill file a jira and take that exception
{code}
Error message 'Got negative replies from endpoints [/127.0.0.2:7012]' does not
contain any of [Did not get replies from all endpoints.]
{code}
the test validates the repair fails but getting wrong message periodically it
seems, so needs to be root caused and fixed.
> Truncation should fail any ongoing repairs
> --
>
> Key: CASSANDRA-15854
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15854
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Truncation may race with ongoing repairs, making it possible to clear data on
> one node but then stream data its truncation would have deleted from another
> node. We should abort any ongoing preview repairs if we get a truncation
> request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15854) Truncation should fail any ongoing repairs
[ https://issues.apache.org/jira/browse/CASSANDRA-15854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201626#comment-17201626 ] David Capwell commented on CASSANDRA-15854: --- tests LGTM +1 > Truncation should fail any ongoing repairs > -- > > Key: CASSANDRA-15854 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15854 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta > > > Truncation may race with ongoing repairs, making it possible to clear data on > one node but then stream data its truncation would have deleted from another > node. We should abort any ongoing preview repairs if we get a truncation > request. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15457) Remove bad assert when getting active compactions for an sstable
[ https://issues.apache.org/jira/browse/CASSANDRA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15457: Status: Ready to Commit (was: Review In Progress) +1 > Remove bad assert when getting active compactions for an sstable > > > Key: CASSANDRA-15457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15457 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > CASSANDRA-14935 added a check that an sstable can only be in a single > 'compaction', this is wrong. An sstable can be in a validation and a normal > compaction at the same time for example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15457) Remove bad assert when getting active compactions for an sstable
[ https://issues.apache.org/jira/browse/CASSANDRA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15457: Reviewers: Blake Eggleston, Blake Eggleston (was: Blake Eggleston) Blake Eggleston, Blake Eggleston (was: Blake Eggleston) Status: Review In Progress (was: Patch Available) > Remove bad assert when getting active compactions for an sstable > > > Key: CASSANDRA-15457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15457 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > CASSANDRA-14935 added a check that an sstable can only be in a single > 'compaction', this is wrong. An sstable can be in a validation and a normal > compaction at the same time for example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15584) 4.0 quality testing: Tooling - External Ecosystem
[
https://issues.apache.org/jira/browse/CASSANDRA-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201695#comment-17201695
]
Stefan Miklosovic commented on CASSANDRA-15584:
---
Hi [~blerer],
speaking from Instaclustr, we have a lot of open source libraries and tooling
(published on our GitHub) which we are taking care of continuously, from my
side, so far, the stream of 4.0 releases was fine when it come to our tooling.
We might need to update sstabletools (1) and various other libraries but we
will take this privately.
Other libraries / tools are
1) Cassandra operator (builds already for 3.11.8 and 4.0-beta2)
2) Cassandra Sidecar
3) Cassandra Backup / Restore
other tooling living in our GH will be considered on the case-to-case basis
(ttl-remover needs to update, some kerberos and ldap plugins etc)
Maybe it would be nice to have a list of concrete projects you have in mind, as
I think about that, there is a lot of tooling I am sure other parties /
contributors are taking care of primarily so I do not want to step on anybody's
toes.
1) https://github.com/instaclustr/cassandra-sstable-tools
> 4.0 quality testing: Tooling - External Ecosystem
> -
>
> Key: CASSANDRA-15584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15584
> Project: Cassandra
> Issue Type: Task
> Components: Tool/external
>Reporter: Josh McKenzie
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Reference [doc from
> NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
> for context.
> *Shepherd: Benjamin Lerer*
> Many users of Apache Cassandra employ open source tooling to automate
> Cassandra configuration, runtime management, and repair scheduling. Prior to
> release, we need to confirm that popular third-party tools such function
> properly.
> Current list of tools:
> || Name || Status || Contact ||
> | [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
> [~sumanth.pasupuleti]|
> Columns descriptions:
> * *Name*: Name and link to the tool official page
> * *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any
> issue and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if
> testing 4.0 is part of your CI process.
> * *Contact*: The person acting as the contact point for that tool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201702#comment-17201702 ] Chris Lohfink commented on CASSANDRA-15164: --- Its been merged back into 3.0 and 3.11 now > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta, 3.0.23, 3.11.9 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15164: -- Resolution: Fixed Status: Resolved (was: Ready to Commit) > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta, 3.0.23, 3.11.9 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15164: -- Reviewers: Benjamin Lerer, Chris Lohfink, Chris Lohfink (was: Benjamin Lerer, Chris Lohfink) Benjamin Lerer, Chris Lohfink, Chris Lohfink (was: Benjamin Lerer, Chris Lohfink) Status: Review In Progress (was: Patch Available) > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta, 3.0.23, 3.11.9 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15164) Overflowed Partition Cell Histograms Can Prevent Compactions from Executing
[ https://issues.apache.org/jira/browse/CASSANDRA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15164: -- Status: Ready to Commit (was: Review In Progress) > Overflowed Partition Cell Histograms Can Prevent Compactions from Executing > --- > > Key: CASSANDRA-15164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15164 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Ankur Jha >Assignee: Caleb Rackliffe >Priority: Urgent > Labels: compaction, partition > Fix For: 4.0-beta, 3.0.23, 3.11.9 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Hi, we are running 6 node Cassandra cluster in production with 3 seed node > but from last night one of our seed nodes is continuously throwing an error > like this;- > cassandra.protocol.ServerError: message="java.lang.IllegalStateException: Unable to compute ceiling for max > when histogram overflowed"> > For a cluster to be up and running I Drained this node. > Can somebody help me out with this? > > Any help or lead would be appreciated > > Note : We are using Cassandra version 3.7 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15457) Remove bad assert when getting active compactions for an sstable
[
https://issues.apache.org/jira/browse/CASSANDRA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201712#comment-17201712
]
Yifan Cai commented on CASSANDRA-15457:
---
nit: {{!cis.isEmpty()}} is always true if {{cis}} is not null, according to the
current implementation. But I think keeping the emptiness check is probably
more future-proof (in case that the method can return an empty collection)
Since we are using {{StringBuilder}} already, we might just compose the entire
error message using the builder, and probably also address the {{todo}}.
> Remove bad assert when getting active compactions for an sstable
>
>
> Key: CASSANDRA-15457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15457
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.x
>
>
> CASSANDRA-14935 added a check that an sstable can only be in a single
> 'compaction', this is wrong. An sstable can be in a validation and a normal
> compaction at the same time for example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15584) 4.0 quality testing: Tooling - External Ecosystem
[
https://issues.apache.org/jira/browse/CASSANDRA-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-15584:
--
Description:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Benjamin Lerer*
Many users of Apache Cassandra employ open source tooling to automate Cassandra
configuration, runtime management, and repair scheduling. Prior to release, we
need to confirm that popular third-party tools such function properly.
Current list of tools:
|| Name || Status || Contact ||
| [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
[~sumanth.pasupuleti]|
| [sstabletools|https://github.com/instaclustr/cassandra-sstable-tools] | NOT
STARTED | [~stefan.miklosovic]|
| [cassandra-exporter]|https://github.com/instaclustr/cassandra-exporter| NOT
STARTED | [~stefan.miklosovic]]
Columns descriptions:
* *Name*: Name and link to the tool official page
* *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any issue
and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if testing 4.0 is
part of your CI process.
* *Contact*: The person acting as the contact point for that tool.
was:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Benjamin Lerer*
Many users of Apache Cassandra employ open source tooling to automate Cassandra
configuration, runtime management, and repair scheduling. Prior to release, we
need to confirm that popular third-party tools such function properly.
Current list of tools:
|| Name || Status || Contact ||
| [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
[~sumanth.pasupuleti]|
Columns descriptions:
* *Name*: Name and link to the tool official page
* *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any issue
and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if testing 4.0 is
part of your CI process.
* *Contact*: The person acting as the contact point for that tool.
> 4.0 quality testing: Tooling - External Ecosystem
> -
>
> Key: CASSANDRA-15584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15584
> Project: Cassandra
> Issue Type: Task
> Components: Tool/external
>Reporter: Josh McKenzie
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Reference [doc from
> NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
> for context.
> *Shepherd: Benjamin Lerer*
> Many users of Apache Cassandra employ open source tooling to automate
> Cassandra configuration, runtime management, and repair scheduling. Prior to
> release, we need to confirm that popular third-party tools such function
> properly.
> Current list of tools:
> || Name || Status || Contact ||
> | [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
> [~sumanth.pasupuleti]|
> | [sstabletools|https://github.com/instaclustr/cassandra-sstable-tools] | NOT
> STARTED | [~stefan.miklosovic]|
> | [cassandra-exporter]|https://github.com/instaclustr/cassandra-exporter| NOT
> STARTED | [~stefan.miklosovic]]
> Columns descriptions:
> * *Name*: Name and link to the tool official page
> * *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any
> issue and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if
> testing 4.0 is part of your CI process.
> * *Contact*: The person acting as the contact point for that tool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15584) 4.0 quality testing: Tooling - External Ecosystem
[
https://issues.apache.org/jira/browse/CASSANDRA-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-15584:
--
Description:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Benjamin Lerer*
Many users of Apache Cassandra employ open source tooling to automate Cassandra
configuration, runtime management, and repair scheduling. Prior to release, we
need to confirm that popular third-party tools such function properly.
Current list of tools:
|| Name || Status || Contact ||
| [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
[~sumanth.pasupuleti]|
| [sstabletools|https://github.com/instaclustr/cassandra-sstable-tools] | NOT
STARTED | [~stefan.miklosovic]|
| [cassandra-exporter|https://github.com/instaclustr/cassandra-exporter]| NOT
STARTED | [~stefan.miklosovic]|
Columns descriptions:
* *Name*: Name and link to the tool official page
* *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any issue
and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if testing 4.0 is
part of your CI process.
* *Contact*: The person acting as the contact point for that tool.
was:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Benjamin Lerer*
Many users of Apache Cassandra employ open source tooling to automate Cassandra
configuration, runtime management, and repair scheduling. Prior to release, we
need to confirm that popular third-party tools such function properly.
Current list of tools:
|| Name || Status || Contact ||
| [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
[~sumanth.pasupuleti]|
| [sstabletools|https://github.com/instaclustr/cassandra-sstable-tools] | NOT
STARTED | [~stefan.miklosovic]|
| [cassandra-exporter]|https://github.com/instaclustr/cassandra-exporter| NOT
STARTED | [~stefan.miklosovic]]
Columns descriptions:
* *Name*: Name and link to the tool official page
* *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any issue
and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if testing 4.0 is
part of your CI process.
* *Contact*: The person acting as the contact point for that tool.
> 4.0 quality testing: Tooling - External Ecosystem
> -
>
> Key: CASSANDRA-15584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15584
> Project: Cassandra
> Issue Type: Task
> Components: Tool/external
>Reporter: Josh McKenzie
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Reference [doc from
> NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
> for context.
> *Shepherd: Benjamin Lerer*
> Many users of Apache Cassandra employ open source tooling to automate
> Cassandra configuration, runtime management, and repair scheduling. Prior to
> release, we need to confirm that popular third-party tools such function
> properly.
> Current list of tools:
> || Name || Status || Contact ||
> | [Priam|http://netflix.github.io/Priam/] | NOT STARTED |
> [~sumanth.pasupuleti]|
> | [sstabletools|https://github.com/instaclustr/cassandra-sstable-tools] | NOT
> STARTED | [~stefan.miklosovic]|
> | [cassandra-exporter|https://github.com/instaclustr/cassandra-exporter]| NOT
> STARTED | [~stefan.miklosovic]|
> Columns descriptions:
> * *Name*: Name and link to the tool official page
> * *Status*: {{NOT STARTED}}, {{IN PROGRESS}}, {{BLOCKED}} if you hit any
> issue and have to wait for it to be solved, {{DONE}}, {{AUTOMATIC}} if
> testing 4.0 is part of your CI process.
> * *Contact*: The person acting as the contact point for that tool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16145) dtest: Fix redundant TTL overflow policy tests
Adam Holmberg created CASSANDRA-16145: - Summary: dtest: Fix redundant TTL overflow policy tests Key: CASSANDRA-16145 URL: https://issues.apache.org/jira/browse/CASSANDRA-16145 Project: Cassandra Issue Type: Bug Reporter: Adam Holmberg While looking into CASSANDRA-15996 I came across what I think is a copy/paste mistake resulting in redundant tests, and not running the other variant. Spinning out here to fix independently of the flaky test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16145) dtest: Fix redundant TTL overflow policy tests
[ https://issues.apache.org/jira/browse/CASSANDRA-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg reassigned CASSANDRA-16145: - Assignee: Adam Holmberg > dtest: Fix redundant TTL overflow policy tests > -- > > Key: CASSANDRA-16145 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16145 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Adam Holmberg >Assignee: Adam Holmberg >Priority: Normal > Fix For: 4.0-beta3 > > > While looking into CASSANDRA-15996 I came across what I think is a copy/paste > mistake resulting in redundant tests, and not running the other variant. > Spinning out here to fix independently of the flaky test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16145) dtest: Fix redundant TTL overflow policy tests
[ https://issues.apache.org/jira/browse/CASSANDRA-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-16145: -- Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear Impact(13164) Complexity: Low Hanging Fruit Component/s: Test/dtest/python Discovered By: Code Inspection Fix Version/s: 4.0-beta3 Severity: Low Status: Open (was: Triage Needed) > dtest: Fix redundant TTL overflow policy tests > -- > > Key: CASSANDRA-16145 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16145 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Adam Holmberg >Priority: Normal > Fix For: 4.0-beta3 > > > While looking into CASSANDRA-15996 I came across what I think is a copy/paste > mistake resulting in redundant tests, and not running the other variant. > Spinning out here to fix independently of the flaky test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16145) dtest: Fix redundant TTL overflow policy tests
[ https://issues.apache.org/jira/browse/CASSANDRA-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-16145: -- Test and Documentation Plan: run the updated tests Status: Patch Available (was: In Progress) > dtest: Fix redundant TTL overflow policy tests > -- > > Key: CASSANDRA-16145 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16145 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Adam Holmberg >Assignee: Adam Holmberg >Priority: Normal > Fix For: 4.0-beta3 > > > While looking into CASSANDRA-15996 I came across what I think is a copy/paste > mistake resulting in redundant tests, and not running the other variant. > Spinning out here to fix independently of the flaky test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16145) dtest: Fix redundant TTL overflow policy tests
[ https://issues.apache.org/jira/browse/CASSANDRA-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201786#comment-17201786 ] Adam Holmberg commented on CASSANDRA-16145: --- [patch|https://github.com/apache/cassandra-dtest/compare/master...aholmberg:CASSANDRA-16145?expand=1] [ci|https://app.circleci.com/pipelines/github/aholmberg/cassandra?branch=CASSANDRA-16145] [~ pauloricardomg] these are your tests. Was this your intent? > dtest: Fix redundant TTL overflow policy tests > -- > > Key: CASSANDRA-16145 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16145 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Adam Holmberg >Assignee: Adam Holmberg >Priority: Normal > Fix For: 4.0-beta3 > > > While looking into CASSANDRA-15996 I came across what I think is a copy/paste > mistake resulting in redundant tests, and not running the other variant. > Spinning out here to fix independently of the flaky test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16145) dtest: Fix redundant TTL overflow policy tests
[ https://issues.apache.org/jira/browse/CASSANDRA-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201786#comment-17201786 ] Adam Holmberg edited comment on CASSANDRA-16145 at 9/24/20, 9:48 PM: - [patch|https://github.com/apache/cassandra-dtest/compare/master...aholmberg:CASSANDRA-16145?expand=1] [ci|https://app.circleci.com/pipelines/github/aholmberg/cassandra?branch=CASSANDRA-16145] [~pauloricardomg] these are your tests. Was this your intent? was (Author: aholmber): [patch|https://github.com/apache/cassandra-dtest/compare/master...aholmberg:CASSANDRA-16145?expand=1] [ci|https://app.circleci.com/pipelines/github/aholmberg/cassandra?branch=CASSANDRA-16145] [~ pauloricardomg] these are your tests. Was this your intent? > dtest: Fix redundant TTL overflow policy tests > -- > > Key: CASSANDRA-16145 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16145 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Adam Holmberg >Assignee: Adam Holmberg >Priority: Normal > Fix For: 4.0-beta3 > > > While looking into CASSANDRA-15996 I came across what I think is a copy/paste > mistake resulting in redundant tests, and not running the other variant. > Spinning out here to fix independently of the flaky test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15996) Fix flaky python dtest test_expiration_overflow_policy_capnowarn - ttl_test.TestTTL
[
https://issues.apache.org/jira/browse/CASSANDRA-15996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201789#comment-17201789
]
Adam Holmberg commented on CASSANDRA-15996:
---
[~dcapwell] The linked CI run is on 3.11. I haven't been able to reproduce this
on trunk, and there is no evidence of flakiness in
[ci-cassandra|https://ci-cassandra.apache.org/job/Cassandra-trunk/33/testReport/dtest-novnode.ttl_test/TestTTL/test_expiration_overflow_policy_capnowarn/].
For now I'm going to leave this open, but drop it from 4.0. Please let me know
if you disagree.
> Fix flaky python dtest test_expiration_overflow_policy_capnowarn -
> ttl_test.TestTTL
> ---
>
> Key: CASSANDRA-15996
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15996
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1860
> {code}
> > assert warning, 'Log message should be print for CAP and
> > CAP_NOWARN policy'
> E AssertionError: Log message should be print for CAP and
> CAP_NOWARN policy
> E assert []
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15996) Fix flaky python dtest test_expiration_overflow_policy_capnowarn - ttl_test.TestTTL
[
https://issues.apache.org/jira/browse/CASSANDRA-15996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-15996:
--
Fix Version/s: (was: 4.0-beta)
> Fix flaky python dtest test_expiration_overflow_policy_capnowarn -
> ttl_test.TestTTL
> ---
>
> Key: CASSANDRA-15996
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15996
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: David Capwell
>Priority: Normal
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1860
> {code}
> > assert warning, 'Log message should be print for CAP and
> > CAP_NOWARN policy'
> E AssertionError: Log message should be print for CAP and
> CAP_NOWARN policy
> E assert []
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15991) 15583 - Add UX tests to intree LHF tooling
[ https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201788#comment-17201788 ] David Capwell commented on CASSANDRA-15991: --- starting review now. I am out Friday and Monday so if I don't finish today ill pick this up Tuesday. > 15583 - Add UX tests to intree LHF tooling > -- > > Key: CASSANDRA-15991 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15991 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory > params are indeed mandatory, 'help' produces an actual help, return codes etc > This ticket is an attempt to add it to those tools that classify as LHF. > Other tools such as nodetool, with many sub-commands, deserve a separate > ticket of their own -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16113) Consolidate dead nodes check in force repair
[ https://issues.apache.org/jira/browse/CASSANDRA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201793#comment-17201793 ] Caleb Rackliffe commented on CASSANDRA-16113: - +1 > Consolidate dead nodes check in force repair > > > Key: CASSANDRA-16113 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16113 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 4.0-beta > > Time Spent: 3h 20m > Remaining Estimate: 0h > > The check for dead nodes during force repair is duplicated in the normal and > incremental repair. We could consolidate those 2 checks to make the code more > dry. > The check should throw a more meaningful error message to indicate that all > neighbor nodes are down, instead of "java.lang.IllegalArgumentException: > Endpoints can not be empty" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15991) 15583 - Add UX tests to intree LHF tooling
[ https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201827#comment-17201827 ] David Capwell commented on CASSANDRA-15991: --- Overall LGTM, only very minor comments. [~brandon.williams] would be good to get your review as well. > 15583 - Add UX tests to intree LHF tooling > -- > > Key: CASSANDRA-15991 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15991 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory > params are indeed mandatory, 'help' produces an actual help, return codes etc > This ticket is an attempt to add it to those tools that classify as LHF. > Other tools such as nodetool, with many sub-commands, deserve a separate > ticket of their own -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15160) Add flag to ignore unreplicated keyspaces during repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201873#comment-17201873
]
David Capwell commented on CASSANDRA-15160:
---
Working on commit:
CI
3.0
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/41/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-cassandra-3.0-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
3.11
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/42/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-cassandra-3.11-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
trunk
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/43/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-trunk-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
> Add flag to ignore unreplicated keyspaces during repair
> ---
>
> Key: CASSANDRA-15160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15160
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
>
> When a repair is triggered on a node in 'dc2' for a keyspace with replication
> factor {'dc1':3, 'dc2':0} we just ignore the repair in versions < 3. In 3.0+
> we fail the repair to make sure the operator does not think the keyspace is
> fully repaired.
> There might be tooling that relies on the old behaviour though, so we should
> add a flag to ignore those unreplicated keyspaces
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Add flag to ignore unreplicated keyspaces during repair
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 8a4c1d7 Add flag to ignore unreplicated keyspaces during repair
8a4c1d7 is described below
commit 8a4c1d7a485bbd2c12864d27e2705133ebbaabc0
Author: Marcus Eriksson
AuthorDate: Thu Sep 24 19:31:48 2020 -0700
Add flag to ignore unreplicated keyspaces during repair
patch by Marcus Eriksson; reviewed by Blake Eggleston, David Capwell for
CASSANDRA-15160
---
CHANGES.txt| 1 +
.../apache/cassandra/repair/RepairRunnable.java| 29
.../cassandra/repair/messages/RepairOption.java| 13 +-
.../apache/cassandra/service/StorageService.java | 4 +-
.../apache/cassandra/tools/nodetool/Repair.java| 5 +
.../distributed/test/RepairOperationalTest.java| 163 +
6 files changed, 211 insertions(+), 4 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index f3df5d0..5f326ce 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
3.0.23:
* Avoid failing compactions with very large partitions (CASSANDRA-15164)
* Use IF NOT EXISTS for index and UDT create statements in snapshot schema
files (CASSANDRA-13935)
+ * Add flag to ignore unreplicated keyspaces during repair (CASSANDRA-15160)
3.0.22:
* Fix gossip shutdown order (CASSANDRA-15816)
diff --git a/src/java/org/apache/cassandra/repair/RepairRunnable.java
b/src/java/org/apache/cassandra/repair/RepairRunnable.java
index 774409f..a7c17c9 100644
--- a/src/java/org/apache/cassandra/repair/RepairRunnable.java
+++ b/src/java/org/apache/cassandra/repair/RepairRunnable.java
@@ -172,6 +172,21 @@ public class RepairRunnable extends WrappedRunnable
implements ProgressEventNoti
options.getDataCenters(),
options.getHosts());
+if (neighbors.isEmpty())
+{
+if (options.ignoreUnreplicatedKeyspaces())
+{
+logger.info("Found no neighbors for range {} for {} -
ignoring since repairing with --ignore-unreplicated-keyspaces", range,
keyspace);
+continue;
+}
+else
+{
+String errorMessage = String.format("Nothing to repair
for %s in %s - aborting", range, keyspace);
+logger.error("Repair {}", errorMessage);
+fireErrorAndComplete(tag, progress.get(),
totalProgress, errorMessage);
+return;
+}
+}
addRangeToNeighbors(commonRanges, range, neighbors);
allNeighbors.addAll(neighbors);
}
@@ -185,6 +200,20 @@ public class RepairRunnable extends WrappedRunnable
implements ProgressEventNoti
return;
}
+if (options.ignoreUnreplicatedKeyspaces() && allNeighbors.isEmpty())
+{
+String ignoreUnreplicatedMessage = String.format("Nothing to
repair for %s in %s - unreplicated keyspace is ignored since repair was called
with --ignore-unreplicated-keyspaces",
+
options.getRanges(),
+ keyspace);
+
+logger.info("Repair {}", ignoreUnreplicatedMessage);
+fireProgressEvent(tag, new
ProgressEvent(ProgressEventType.COMPLETE,
+ progress.get(),
+ totalProgress,
+
ignoreUnreplicatedMessage));
+return;
+}
+
// Validate columnfamilies
List columnFamilyStores = new ArrayList<>();
try
diff --git a/src/java/org/apache/cassandra/repair/messages/RepairOption.java
b/src/java/org/apache/cassandra/repair/messages/RepairOption.java
index 9d60ad7..5d56d3a 100644
--- a/src/java/org/apache/cassandra/repair/messages/RepairOption.java
+++ b/src/java/org/apache/cassandra/repair/messages/RepairOption.java
@@ -45,6 +45,7 @@ public class RepairOption
public static final String DATACENTERS_KEY = "dataCenters";
public static final String HOSTS_KEY = "hosts";
public static final String TRACE_KEY = "trace";
+public static final String IGNORE_UNREPLICATED_KS =
"ignoreUnreplicatedKeyspaces";
// we don't want to push nodes too much for repair
public static final int MAX_JOB_THREADS = 4;
@@ -129,6 +130,7 @@ public class RepairOption
boolean primaryRange =
Boolean.parseBoolean(options.get(PRIMARY_RANGE_KEY));
boo
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 881cff46da8f4a0369e3dcd96231535da17ec193 Merge: 3db6444 0f46c90 Author: David Capwell AuthorDate: Thu Sep 24 21:17:44 2020 -0700 Merge branch 'cassandra-3.11' into trunk CHANGES.txt| 2 + .../apache/cassandra/repair/RepairRunnable.java| 25 +++- .../cassandra/repair/messages/RepairOption.java| 14 ++- .../apache/cassandra/tools/nodetool/Repair.java| 4 + .../distributed/test/RepairOperationalTest.java| 131 + 5 files changed, 168 insertions(+), 8 deletions(-) diff --cc CHANGES.txt index 1db3ebc,189aec4..2e6715f --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,50 -1,15 +1,52 @@@ -3.11.9 +4.0-beta3 * Avoid failing compactions with very large partitions (CASSANDRA-15164) + * Prevent NPE in StreamMessage in type lookup (CASSANDRA-16131) + * Avoid invalid state transition exception during incremental repair (CASSANDRA-16067) + * Allow zero padding in timestamp serialization (CASSANDRA-16105) + * Add byte array backed cells (CASSANDRA-15393) + * Correctly handle pending ranges with adjacent range movements (CASSANDRA-14801) + * Avoid adding locahost when streaming trivial ranges (CASSANDRA-16099) + * Add nodetool getfullquerylog (CASSANDRA-15988) + * Fix yaml format and alignment in tpstats (CASSANDRA-11402) + * Avoid trying to keep track of RTs for endpoints we won't write to during read repair (CASSANDRA-16084) + * When compaction gets interrupted, the exception should include the compactionId (CASSANDRA-15954) + * Make Table/Keyspace Metric Names Consistent With Each Other (CASSANDRA-15909) + * Mutating sstable component may race with entire-sstable-streaming(ZCS) causing checksum validation failure (CASSANDRA-15861) + * NPE thrown while updating speculative execution time if keyspace is removed during task execution (CASSANDRA-15949) + * Show the progress of data streaming and index build (CASSANDRA-15406) +Merged from 3.11: + * Use IF NOT EXISTS for index and UDT create statements in snapshot schema files (CASSANDRA-13935) * Make sure LCS handles duplicate sstable added/removed notifications correctly (CASSANDRA-14103) + Merged from 3.0: + * Add flag to ignore unreplicated keyspaces during repair (CASSANDRA-15160) -3.11.8 +4.0-beta2 + * Add addition incremental repair visibility to nodetool repair_admin (CASSANDRA-14939) + * Always access system properties and environment variables via the new CassandraRelevantProperties and CassandraRelevantEnv classes (CASSANDRA-15876) + * Remove deprecated HintedHandOffManager (CASSANDRA-15939) + * Prevent repair from overrunning compaction (CASSANDRA-15817) + * fix cqlsh COPY functions in Python 3.8 on Mac (CASSANDRA-16053) + * Strip comment blocks from cqlsh input before processing statements (CASSANDRA-15802) + * Fix unicode chars error input (CASSANDRA-15990) + * Improved testability for CacheMetrics and ChunkCacheMetrics (CASSANDRA-15788) + * Handle errors in StreamSession#prepare (CASSANDRA-15852) + * FQL replay should have options to ignore DDL statements (CASSANDRA-16039) + * Remove COMPACT STORAGE internals (CASSANDRA-13994) + * Make TimestampSerializer accept fractional seconds of varying precision (CASSANDRA-15976) + * Improve cassandra-stress logging when using a profile file that doesn't exist (CASSANDRA-14425) + * Improve logging for socket connection/disconnection (CASSANDRA-15980) + * Throw FSWriteError upon write failures in order to apply DiskFailurePolicy (CASSANDRA-15928) + * Forbid altering UDTs used in partition keys (CASSANDRA-15933) + * Fix version parsing logic when upgrading from 3.0 (CASSANDRA-15973) + * Optimize NoSpamLogger use in hot paths (CASSANDRA-15766) + * Verify sstable components on startup (CASSANDRA-15945) + * Resolve JMX output inconsistencies from CASSANDRA-7544 storage-port-configurable-per-node (CASSANDRA-15937) +Merged from 3.11: * Correctly interpret SASI's `max_compaction_flush_memory_in_mb` setting in megabytes not bytes (CASSANDRA-16071) * Fix short read protection for GROUP BY queries (CASSANDRA-15459) + * stop_paranoid disk failure policy is ignored on CorruptSSTableException after node is up (CASSANDRA-15191) * Frozen RawTuple is not annotated with frozen in the toString method (CASSANDRA-15857) Merged from 3.0: - * Use IF NOT EXISTS for index and UDT create statements in snapshot schema files (CASSANDRA-13935) * Fix gossip shutdown order (CASSANDRA-15816) * Remove broken 'defrag-on-read' optimization (CASSANDRA-15432) * Check for endpoint collision with hibernating nodes (CASSANDRA-14599) diff --cc src/java/org/apache/cassandra/repair/RepairRunnable.java index e5e8e50,7a9590b..f6aa6d1 --- a/src/java/org/apache/cassandra/repair/RepairRunnable.java +++ b/src/java/org/
[cassandra] branch cassandra-3.11 updated (0361d53 -> 0f46c90)
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 0361d53 Avoid failing compactions with very large partitions add 5a39ff4 Avoid failing compactions with very large partitions new 8a4c1d7 Add flag to ignore unreplicated keyspaces during repair new 0f46c90 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 2 + .../apache/cassandra/repair/RepairRunnable.java| 29 .../cassandra/repair/messages/RepairOption.java| 13 +- .../apache/cassandra/service/StorageService.java | 4 +- .../apache/cassandra/tools/nodetool/Repair.java| 5 + .../distributed/test/RepairOperationalTest.java| 163 + 6 files changed, 212 insertions(+), 4 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/RepairOperationalTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (3db6444 -> 881cff4)
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 3db6444 Cassandra website is building/including the wrong versioned nodetool docs add 0361d53 Avoid failing compactions with very large partitions add 5a39ff4 Avoid failing compactions with very large partitions new 8a4c1d7 Add flag to ignore unreplicated keyspaces during repair new 0f46c90 Merge branch 'cassandra-3.0' into cassandra-3.11 new 881cff4 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 2 + .../apache/cassandra/repair/RepairRunnable.java| 25 +++- .../cassandra/repair/messages/RepairOption.java| 14 ++- .../apache/cassandra/tools/nodetool/Repair.java| 4 + .../distributed/test/RepairOperationalTest.java| 131 + 5 files changed, 168 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch master updated: Add flag to ignore unreplicated keyspaces during repair
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/master by this push:
new bfc739e Add flag to ignore unreplicated keyspaces during repair
bfc739e is described below
commit bfc739e67cdd1b56bcb68399d6b5b6cb3024e90c
Author: Marcus Eriksson
AuthorDate: Thu Sep 24 19:31:34 2020 -0700
Add flag to ignore unreplicated keyspaces during repair
patch by Marcus Eriksson; reviewed by Blake Eggleston, David Capwell for
CASSANDRA-15160
---
repair_tests/deprecated_repair_test.py | 2 +-
repair_tests/repair_test.py| 58 ++
2 files changed, 59 insertions(+), 1 deletion(-)
diff --git a/repair_tests/deprecated_repair_test.py
b/repair_tests/deprecated_repair_test.py
index a411a12..958fee4 100644
--- a/repair_tests/deprecated_repair_test.py
+++ b/repair_tests/deprecated_repair_test.py
@@ -166,7 +166,7 @@ class TestDeprecatedRepairAPI(Tester):
line = node1.grep_log((r"Starting repair command #1" + (r" \([^\)]+\)"
if cluster.version() >= LooseVersion("3.10") else "") +
r", repairing keyspace ks with repair options
\(parallelism: (?P\w+), primary range: (?P\w+), "
r"incremental: (?P\w+), job
threads: (?P\d+), ColumnFamilies: (?P.+), dataCenters: (?P.+), "
- r"hosts: (?P.+), # of ranges:
(?P\d+)(, pull repair: (?Ptrue|false))?\)"))
+ r"hosts: (?P.+), # of ranges:
(?P\d+)(, pull repair: (?Ptrue|false))?(, ignore
unreplicated keyspaces: (?Ptrue|false))?\)"))
assert_length_equal(line, 1)
line, m = line[0]
diff --git a/repair_tests/repair_test.py b/repair_tests/repair_test.py
index 07d4576..4b8f037 100644
--- a/repair_tests/repair_test.py
+++ b/repair_tests/repair_test.py
@@ -15,6 +15,7 @@ from ccmlib.node import ToolError
from dtest import FlakyRetryPolicy, Tester, create_ks, create_cf
from tools.data import insert_c1c2, query_c1c2
+from tools.jmxutils import JolokiaAgent, make_mbean,
remove_perf_disable_shared_mem
since = pytest.mark.since
logger = logging.getLogger(__name__)
@@ -911,6 +912,63 @@ class TestRepair(BaseRepairTest):
assert len(node2.grep_log("Receiving 0 files")) > 0
assert len(node2.grep_log("sending [1-9][0-9]* files")) > 0
+@since('4.0')
+def test_non_replicated_ks_repair(self):
+cluster = self.cluster
+cluster.populate([2, 2]).start(wait_for_binary_proto=True)
+self.fixture_dtest_setup.ignore_log_patterns.extend(["no neighbors to
repair with",
+"keyspace is
skipped since repair was called with --skip-empty"])
+_, _, node, _ = cluster.nodelist()
+session = self.patient_cql_connection(node)
+create_ks(session, "repair1", {'dc1': 2, 'dc2': 0})
+create_ks(session, "repair2", {'dc1': 2, 'dc2': 2})
+session.execute("create table repair1.t1 (id int primary key, i int)")
+
session.cluster.control_connection.wait_for_schema_agreement(wait_time=120)
+session.execute("create table repair2.t2 (id int primary key, i int)")
+
session.cluster.control_connection.wait_for_schema_agreement(wait_time=120)
+
+session.execute("insert into repair1.t1 (id, i) values (1, 1)")
+session.execute("insert into repair2.t2 (id, i) values (2, 2)")
+
+node.nodetool("repair --ignore-unreplicated-keyspaces -st 0 -et 1")
+
+assert len(node.grep_log("t2 is fully synced")) > 0
+assert len(node.grep_log("in repair1 - unreplicated keyspace is
ignored since repair was called with --ignore-unreplicated-keyspaces")) > 0
+
+try:
+self.fixture_dtest_setup.ignore_log_patterns.append("Nothing to
repair for .+ in repair1")
+node.nodetool("repair -st 0 -et 1")
+assert False, "repair should fail"
+except ToolError:
+logger.debug("got expected exception during repair")
+
+@since('4.0')
+@pytest.mark.no_vnodes
+def test_multiple_ranges_repair(self):
+cluster = self.cluster
+cluster.populate([3])
+node1, node2, node3 = cluster.nodelist()
+remove_perf_disable_shared_mem(node1) # for jmx
+cluster.start(wait_for_binary_proto=True)
+self.fixture_dtest_setup.ignore_log_patterns.extend(["Nothing to
repair for"])
+session = self.patient_cql_connection(node1)
+create_ks(session, "repair1", {'dc1': 2})
+session.execute("create table repair1.t1 (id int primary key, i int)")
+
session.cluster.control_connection.wait_for_schema_agreement(wait_time=120)
+session.execute("insert into repair1.t1 (id, i) values (1, 1)")
+with JolokiaAgent(node1) as jmx:
+repair_mbean = mak
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0f46c90d1a72f1c31c00ea617697a5565e97f30c Merge: 0361d53 8a4c1d7 Author: David Capwell AuthorDate: Thu Sep 24 21:16:53 2020 -0700 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt| 2 + .../apache/cassandra/repair/RepairRunnable.java| 29 .../cassandra/repair/messages/RepairOption.java| 13 +- .../apache/cassandra/service/StorageService.java | 4 +- .../apache/cassandra/tools/nodetool/Repair.java| 5 + .../distributed/test/RepairOperationalTest.java| 163 + 6 files changed, 212 insertions(+), 4 deletions(-) diff --cc CHANGES.txt index b5b0cbc,5f326ce..189aec4 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,13 -1,9 +1,15 @@@ -3.0.23: +3.11.9 * Avoid failing compactions with very large partitions (CASSANDRA-15164) - * Use IF NOT EXISTS for index and UDT create statements in snapshot schema files (CASSANDRA-13935) + * Make sure LCS handles duplicate sstable added/removed notifications correctly (CASSANDRA-14103) ++Merged from 3.0: + * Add flag to ignore unreplicated keyspaces during repair (CASSANDRA-15160) -3.0.22: +3.11.8 + * Correctly interpret SASI's `max_compaction_flush_memory_in_mb` setting in megabytes not bytes (CASSANDRA-16071) + * Fix short read protection for GROUP BY queries (CASSANDRA-15459) + * Frozen RawTuple is not annotated with frozen in the toString method (CASSANDRA-15857) +Merged from 3.0: + * Use IF NOT EXISTS for index and UDT create statements in snapshot schema files (CASSANDRA-13935) * Fix gossip shutdown order (CASSANDRA-15816) * Remove broken 'defrag-on-read' optimization (CASSANDRA-15432) * Check for endpoint collision with hibernating nodes (CASSANDRA-14599) diff --cc src/java/org/apache/cassandra/repair/messages/RepairOption.java index 146ab64,5d56d3a..14fff97 --- a/src/java/org/apache/cassandra/repair/messages/RepairOption.java +++ b/src/java/org/apache/cassandra/repair/messages/RepairOption.java @@@ -45,8 -45,7 +45,9 @@@ public class RepairOptio public static final String DATACENTERS_KEY = "dataCenters"; public static final String HOSTS_KEY = "hosts"; public static final String TRACE_KEY = "trace"; +public static final String SUB_RANGE_REPAIR_KEY = "sub_range_repair"; +public static final String PULL_REPAIR_KEY = "pullRepair"; + public static final String IGNORE_UNREPLICATED_KS = "ignoreUnreplicatedKeyspaces"; // we don't want to push nodes too much for repair public static final int MAX_JOB_THREADS = 4; @@@ -137,7 -130,7 +138,8 @@@ boolean primaryRange = Boolean.parseBoolean(options.get(PRIMARY_RANGE_KEY)); boolean incremental = Boolean.parseBoolean(options.get(INCREMENTAL_KEY)); boolean trace = Boolean.parseBoolean(options.get(TRACE_KEY)); +boolean pullRepair = Boolean.parseBoolean(options.get(PULL_REPAIR_KEY)); + boolean ignoreUnreplicatedKeyspaces = Boolean.parseBoolean(options.get(IGNORE_UNREPLICATED_KS)); int jobThreads = 1; if (options.containsKey(JOB_THREADS_KEY)) @@@ -175,7 -168,7 +177,7 @@@ } } - RepairOption option = new RepairOption(parallelism, primaryRange, incremental, trace, jobThreads, ranges, !ranges.isEmpty(), pullRepair); -RepairOption option = new RepairOption(parallelism, primaryRange, incremental, trace, jobThreads, ranges, !ranges.isEmpty(), ignoreUnreplicatedKeyspaces); ++RepairOption option = new RepairOption(parallelism, primaryRange, incremental, trace, jobThreads, ranges, !ranges.isEmpty(), pullRepair, ignoreUnreplicatedKeyspaces); // data centers String dataCentersStr = options.get(DATACENTERS_KEY); @@@ -250,16 -228,16 +252,17 @@@ private final boolean trace; private final int jobThreads; private final boolean isSubrangeRepair; +private final boolean pullRepair; + private final boolean ignoreUnreplicatedKeyspaces; private final Collection columnFamilies = new HashSet<>(); private final Collection dataCenters = new HashSet<>(); private final Collection hosts = new HashSet<>(); private final Collection> ranges = new HashSet<>(); - public RepairOption(RepairParallelism parallelism, boolean primaryRange, boolean incremental, boolean trace, int jobThreads, Collection> ranges, boolean isSubrangeRepair, boolean pullRepair) -public RepairOption(RepairParallelism parallelism, boolean primaryRange, boolean incremental, boolean trace, int jobThreads, Collection> ranges, boolean isSubrangeRepair, boolean ignoreUnreplicatedKeyspaces) ++public RepairOption(RepairParallelism parallelism, boolean primaryRange, boolean incremental, boolean trace, int jobThreads, Collect
[jira] [Updated] (CASSANDRA-15160) Add flag to ignore unreplicated keyspaces during repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15160:
--
Fix Version/s: 4.0-beta3
3.11.9
3.0.23
Source Control Link:
https://github.com/apache/cassandra/commit/33bd390c4cec85b9e6407fc1453b203d6b9076bd
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Add flag to ignore unreplicated keyspaces during repair
> ---
>
> Key: CASSANDRA-15160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15160
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 3.0.23, 3.11.9, 4.0-beta3
>
>
> When a repair is triggered on a node in 'dc2' for a keyspace with replication
> factor {'dc1':3, 'dc2':0} we just ignore the repair in versions < 3. In 3.0+
> we fail the repair to make sure the operator does not think the keyspace is
> fully repaired.
> There might be tooling that relies on the old behaviour though, so we should
> add a flag to ignore those unreplicated keyspaces
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15160) Add flag to ignore unreplicated keyspaces during repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201873#comment-17201873
]
David Capwell edited comment on CASSANDRA-15160 at 9/25/20, 4:21 AM:
-
Committed, only known flaky tests and a issue with python installing packages
CI
3.0
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/41/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-cassandra-3.0-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
3.11
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/42/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-cassandra-3.11-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
trunk
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/43/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-trunk-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
was (Author: dcapwell):
Working on commit:
CI
3.0
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/41/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-cassandra-3.0-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
3.11
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/42/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-cassandra-3.11-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
trunk
Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch/43/
Circle CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15160-trunk-FE679B1E-281C-44F2-8C62-9EDA039FE4C3
> Add flag to ignore unreplicated keyspaces during repair
> ---
>
> Key: CASSANDRA-15160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15160
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 3.0.23, 3.11.9, 4.0-beta3
>
>
> When a repair is triggered on a node in 'dc2' for a keyspace with replication
> factor {'dc1':3, 'dc2':0} we just ignore the repair in versions < 3. In 3.0+
> we fail the repair to make sure the operator does not think the keyspace is
> fully repaired.
> There might be tooling that relies on the old behaviour though, so we should
> add a flag to ignore those unreplicated keyspaces
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15457) Remove bad assert when getting active compactions for an sstable
[ https://issues.apache.org/jira/browse/CASSANDRA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15457: Reviewers: Blake Eggleston, Yifan Cai (was: Blake Eggleston) > Remove bad assert when getting active compactions for an sstable > > > Key: CASSANDRA-15457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15457 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.x > > > CASSANDRA-14935 added a check that an sstable can only be in a single > 'compaction', this is wrong. An sstable can be in a validation and a normal > compaction at the same time for example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Remove bad assert when getting active compactions for an sstable
This is an automated email from the ASF dual-hosted git repository.
marcuse pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 8b25cd5 Remove bad assert when getting active compactions for an
sstable
8b25cd5 is described below
commit 8b25cd58bfa646db9e6c24c51896950da02945db
Author: Marcus Eriksson
AuthorDate: Mon Sep 7 10:11:53 2020 +0200
Remove bad assert when getting active compactions for an sstable
Patch by marcuse; reviewed by Blake Eggleston and Yifan Cai for
CASSANDRA-15457
---
CHANGES.txt | 1 +
.../cassandra/db/compaction/ActiveCompactions.java | 16 +---
.../cassandra/db/repair/PendingAntiCompaction.java | 17 +++--
3 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 2e6715f..ec95e20 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-beta3
+ * Remove bad assert when getting active compactions for an sstable
(CASSANDRA-15457)
* Avoid failing compactions with very large partitions (CASSANDRA-15164)
* Prevent NPE in StreamMessage in type lookup (CASSANDRA-16131)
* Avoid invalid state transition exception during incremental repair
(CASSANDRA-16067)
diff --git a/src/java/org/apache/cassandra/db/compaction/ActiveCompactions.java
b/src/java/org/apache/cassandra/db/compaction/ActiveCompactions.java
index 5bcb06f..7b6b5bf 100644
--- a/src/java/org/apache/cassandra/db/compaction/ActiveCompactions.java
+++ b/src/java/org/apache/cassandra/db/compaction/ActiveCompactions.java
@@ -19,6 +19,7 @@
package org.apache.cassandra.db.compaction;
import java.util.ArrayList;
+import java.util.Collection;
import java.util.Collections;
import java.util.IdentityHashMap;
import java.util.List;
@@ -49,22 +50,23 @@ public class ActiveCompactions implements
ActiveCompactionsTracker
}
/**
- * Iterates over the active compactions and tries to find the
CompactionInfo for the given sstable
+ * Iterates over the active compactions and tries to find CompactionInfos
with the given compactionType for the given sstable
*
* Number of entries in compactions should be small (< 10) but avoid
calling in any time-sensitive context
*/
-public CompactionInfo getCompactionForSSTable(SSTableReader sstable)
+public Collection getCompactionsForSSTable(SSTableReader
sstable, OperationType compactionType)
{
-CompactionInfo toReturn = null;
+List toReturn = null;
synchronized (compactions)
{
for (CompactionInfo.Holder holder : compactions)
{
-if (holder.getCompactionInfo().getSSTables().contains(sstable))
+CompactionInfo compactionInfo = holder.getCompactionInfo();
+if (compactionInfo.getSSTables().contains(sstable) &&
compactionInfo.getTaskType() == compactionType)
{
-if (toReturn != null)
-throw new IllegalStateException("SSTable " + sstable +
" involved in several compactions");
-toReturn = holder.getCompactionInfo();
+if (toReturn == null)
+toReturn = new ArrayList<>();
+toReturn.add(compactionInfo);
}
}
}
diff --git a/src/java/org/apache/cassandra/db/repair/PendingAntiCompaction.java
b/src/java/org/apache/cassandra/db/repair/PendingAntiCompaction.java
index e49e76e..e0ee68d 100644
--- a/src/java/org/apache/cassandra/db/repair/PendingAntiCompaction.java
+++ b/src/java/org/apache/cassandra/db/repair/PendingAntiCompaction.java
@@ -145,14 +145,19 @@ public class PendingAntiCompaction
}
return false;
}
-CompactionInfo ci =
CompactionManager.instance.active.getCompactionForSSTable(sstable);
-if (ci != null && ci.getTaskType() == OperationType.ANTICOMPACTION)
+Collection cis =
CompactionManager.instance.active.getCompactionsForSSTable(sstable,
OperationType.ANTICOMPACTION);
+if (cis != null && !cis.isEmpty())
{
// todo: start tracking the parent repair session id that
created the anticompaction to be able to give a better error messsage here:
-String message = String.format("Prepare phase for incremental
repair session %s has failed because it encountered " +
- "intersecting sstables (%s)
belonging to another incremental repair session. This is " +
- "caused by starting multiple
conflicting incremental repairs at the same time", prsid, ci.getSSTables());
-throw new SSTableAcquisitionException(message);
+StringBuilder sb = new StringBuilder();
+
[jira] [Updated] (CASSANDRA-15457) Remove bad assert when getting active compactions for an sstable
[ https://issues.apache.org/jira/browse/CASSANDRA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15457: Fix Version/s: (was: 4.x) 4.0-beta3 Since Version: 4.0-alpha1 Source Control Link: https://github.com/apache/cassandra/commit/8b25cd58bfa646db9e6c24c51896950da02945db Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed with the string builder change The todo is still valid - we would need to start tracking which repair session that started the anticompaction causing the conflict, which we don't do now > Remove bad assert when getting active compactions for an sstable > > > Key: CASSANDRA-15457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15457 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta3 > > > CASSANDRA-14935 added a check that an sstable can only be in a single > 'compaction', this is wrong. An sstable can be in a validation and a normal > compaction at the same time for example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15854) Truncation should fail any ongoing repairs
[ https://issues.apache.org/jira/browse/CASSANDRA-15854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15854: Status: Ready to Commit (was: Changes Suggested) > Truncation should fail any ongoing repairs > -- > > Key: CASSANDRA-15854 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15854 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-beta > > > Truncation may race with ongoing repairs, making it possible to clear data on > one node but then stream data its truncation would have deleted from another > node. We should abort any ongoing preview repairs if we get a truncation > request. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
