[jira] [Updated] (CASSANDRA-16573) CQLSH copy defaults appear to be incorrect on website
[
https://issues.apache.org/jira/browse/CASSANDRA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Houser updated CASSANDRA-16573:
-
Test and Documentation Plan:
Ran make html.
Was able to validate this once made fix to license text, fix for this contained
in https://issues.apache.org/jira/browse/CASSANDRA-16727
Status: Patch Available (was: In Progress)
PR: https://github.com/apache/cassandra/pull/1052
> CQLSH copy defaults appear to be incorrect on website
> -
>
> Key: CASSANDRA-16573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16573
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation/Website
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Fix For: 3.11.11
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The documentation on the website for the defaults of CQLSH appear to be
> incorrect and contain numerous errors (at least for the latest and greatest)
> For this page:
> [https://cassandra.apache.org/doc/latest/tools/cqlsh.html]
> {{MINBATCHSIZE}} is listed as defaulting to 2. Code says this is 10.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L355
> Chunksize says 1000, actually set to 5000.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L352
> NumProcessis is also off...
> "NUMPROCESSES
> The number of child worker processes to create for COPY tasks. Defaults to a
> max of 4 for COPY FROM and 16 for COPY TO. However, at most (num_cores - 1)
> processes will be created."
> Default is the number of cores -1 or 16 which ever is smaller, and you can
> set this value to anything. See the following code
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L361
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L407
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16573) CQLSH copy defaults appear to be incorrect on website
[
https://issues.apache.org/jira/browse/CASSANDRA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360572#comment-17360572
]
Brian Houser commented on CASSANDRA-16573:
--
PR For fix : https://github.com/apache/cassandra/pull/1052
> CQLSH copy defaults appear to be incorrect on website
> -
>
> Key: CASSANDRA-16573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16573
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation/Website
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Fix For: 3.11.11
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The documentation on the website for the defaults of CQLSH appear to be
> incorrect and contain numerous errors (at least for the latest and greatest)
> For this page:
> [https://cassandra.apache.org/doc/latest/tools/cqlsh.html]
> {{MINBATCHSIZE}} is listed as defaulting to 2. Code says this is 10.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L355
> Chunksize says 1000, actually set to 5000.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L352
> NumProcessis is also off...
> "NUMPROCESSES
> The number of child worker processes to create for COPY tasks. Defaults to a
> max of 4 for COPY FROM and 16 for COPY TO. However, at most (num_cores - 1)
> processes will be created."
> Default is the number of cores -1 or 16 which ever is smaller, and you can
> set this value to anything. See the following code
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L361
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L407
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16573) CQLSH copy defaults appear to be incorrect on website
[
https://issues.apache.org/jira/browse/CASSANDRA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Houser updated CASSANDRA-16573:
-
Fix Version/s: 3.11.11
> CQLSH copy defaults appear to be incorrect on website
> -
>
> Key: CASSANDRA-16573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16573
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation/Website
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Fix For: 3.11.11
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The documentation on the website for the defaults of CQLSH appear to be
> incorrect and contain numerous errors (at least for the latest and greatest)
> For this page:
> [https://cassandra.apache.org/doc/latest/tools/cqlsh.html]
> {{MINBATCHSIZE}} is listed as defaulting to 2. Code says this is 10.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L355
> Chunksize says 1000, actually set to 5000.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L352
> NumProcessis is also off...
> "NUMPROCESSES
> The number of child worker processes to create for COPY tasks. Defaults to a
> max of 4 for COPY FROM and 16 for COPY TO. However, at most (num_cores - 1)
> processes will be created."
> Default is the number of cores -1 or 16 which ever is smaller, and you can
> set this value to anything. See the following code
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L361
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L407
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360546#comment-17360546
]
Ekaterina Dimitrova commented on CASSANDRA-16669:
-
One more comment which probably we can address in a new ticket for improvement:
{code:java}
cqlsh> CREATE ROLE role1 WITH PASSWORD = 'me' AND LOGIN = true;
InvalidRequest: Error from server: code=2200 [Invalid query]
message="org.apache.cassandra.auth.CassandraRoleManager doesn't support
PASSWORD"
cqlsh> CREATE ROLE role1;
Unauthorized: Error from server: code=2100 [Unauthorized] message="You have to
be logged in and not anonymous to perform this request"
{code}
I believe the first error message might be confusing for a user.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0-rc, 4.0.x, 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360546#comment-17360546
]
Ekaterina Dimitrova edited comment on CASSANDRA-16669 at 6/10/21, 4:30 AM:
---
One more comment which probably we can address in a new ticket for improvement:
{code:java}
cqlsh> CREATE ROLE role1 WITH PASSWORD = 'me' AND LOGIN = true;
InvalidRequest: Error from server: code=2200 [Invalid query]
message="org.apache.cassandra.auth.CassandraRoleManager doesn't support
PASSWORD"
cqlsh> CREATE ROLE role1;
Unauthorized: Error from server: code=2100 [Unauthorized] message="You have to
be logged in and not anonymous to perform this request"
{code}
I believe the first error message might be confusing for a user.
was (Author: e.dimitrova):
One more comment which probably we can address in a new ticket for improvement:
{code:java}
cqlsh> CREATE ROLE role1 WITH PASSWORD = 'me' AND LOGIN = true;
InvalidRequest: Error from server: code=2200 [Invalid query]
message="org.apache.cassandra.auth.CassandraRoleManager doesn't support
PASSWORD"
cqlsh> CREATE ROLE role1;
Unauthorized: Error from server: code=2100 [Unauthorized] message="You have to
be logged in and not anonymous to perform this request"
{code}
I believe the first error message might be confusing for a user.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0-rc, 4.0.x, 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360546#comment-17360546
]
Ekaterina Dimitrova edited comment on CASSANDRA-16669 at 6/10/21, 4:30 AM:
---
One more comment which probably we can address in a new ticket for improvement:
{code:java}
cqlsh> CREATE ROLE role1 WITH PASSWORD = 'me' AND LOGIN = true;
InvalidRequest: Error from server: code=2200 [Invalid query]
message="org.apache.cassandra.auth.CassandraRoleManager doesn't support
PASSWORD"
cqlsh> CREATE ROLE role1;
Unauthorized: Error from server: code=2100 [Unauthorized] message="You have to
be logged in and not anonymous to perform this request"
{code}
I believe the first error message might be confusing for a user.
was (Author: e.dimitrova):
One more comment which probably we can address in a new ticket for improvement:
{code:java}
cqlsh> CREATE ROLE role1 WITH PASSWORD = 'me' AND LOGIN = true;
InvalidRequest: Error from server: code=2200 [Invalid query]
message="org.apache.cassandra.auth.CassandraRoleManager doesn't support
PASSWORD"
cqlsh> CREATE ROLE role1;
Unauthorized: Error from server: code=2100 [Unauthorized] message="You have to
be logged in and not anonymous to perform this request"
{code}
I believe the first error message might be confusing for a user.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0-rc, 4.0.x, 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360535#comment-17360535
]
Ekaterina Dimitrova commented on CASSANDRA-16669:
-
Hi all,
First of all, great job.
Feedback/questions:
* I guess you opted in for the centralized solution and maybe the question is
whether we want the users to be given the chance not to obfuscate passwords if
they want to when they use FQL? Is that correct?
* The ticket is still work in progress not in review but I made a review on
the latest pull request as I see everyone was working on it lately and I had
the impression that is what was decided?
* I think we might want to add tests for the corner cases identified in the
previous comment by Stefan. (Great catch!) Also, I found one more weird corner
case which Stefan's patch took care of. If a user does an invalid batch request
including DCL - that would be logged as below with the password still being
_password_a_:
{code:java}
INFO [Native-Transport-Requests-1] 2021-06-09 23:38:05,965
FileAuditLogger.java:51 -
user:anonymous|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:63360|timestamp:1623296285965|type:REQUEST_FAILURE|category:ERROR|operation:BEGIN
BATCH CREATE ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true; CREATE
ROLE new_role; APPLY BATCH;; line 1:12 mismatched input 'CREATE' expecting
K_APPLY (BEGIN BATCH [CREATE]...){code}
I know it is highly unlikely to happen but It was there and Stefan's latest
patch takes care of it. We might want to add a test for that edge case too
* I didn't see [this question
|https://github.com/apache/cassandra/pull/1043/commits/07990ebaba79e6d9553de14733e28d89caa5e171#diff-df97ca69d481fde559e155c724ca60967a1e57222ea845d8ee8299d7b014df46R86]
being resolved
* Do we need an interface? What other implementations are planned?
* I believe the rest is nits on the PR itself.
I will make another pass tomorrow morning again
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0-rc, 4.0.x, 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
[jira] [Updated] (CASSANDRA-16728) test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16728: -- Since Version: NA Source Control Link: https://github.com/apache/cassandra-dtest/commit/964051b04767689a1a3a84493c0b4afe77d6edfc Resolution: Fixed Status: Resolved (was: Ready to Commit) > test_tombstone_failure_threshold_message assert checking if array == string, > should check for array truthiness > -- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16728) test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16728: -- Status: Ready to Commit (was: Review In Progress) > test_tombstone_failure_threshold_message assert checking if array == string, > should check for array truthiness > -- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: CASSANDRA-16728 - test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness patch by David Capwell; reviewe
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git The following commit(s) were added to refs/heads/trunk by this push: new 964051b CASSANDRA-16728 - test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness patch by David Capwell; reviewed by Yifan Cai for CASSANDRA-16728 964051b is described below commit 964051b04767689a1a3a84493c0b4afe77d6edfc Author: David Capwell AuthorDate: Wed Jun 9 16:01:18 2021 -0700 CASSANDRA-16728 - test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness patch by David Capwell; reviewed by Yifan Cai for CASSANDRA-16728 --- pushed_notifications_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pushed_notifications_test.py b/pushed_notifications_test.py index 6ab311e..a3b1bdc 100644 --- a/pushed_notifications_test.py +++ b/pushed_notifications_test.py @@ -445,7 +445,7 @@ class TestVariousNotifications(Tester): node2.grep_log(failure_msg) or node3.grep_log(failure_msg)) -assert failure == "Cannot find tombstone failure threshold error in log after failed query" +assert failure, "Cannot find tombstone failure threshold error in log after failed query" mark1 = node1.mark_log() mark2 = node2.mark_log() - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16728) test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-16728: -- Reviewers: Yifan Cai (was: Yifan Cai, Yifan Cai) > test_tombstone_failure_threshold_message assert checking if array == string, > should check for array truthiness > -- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16728) test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-16728: -- Reviewers: Yifan Cai, Yifan Cai Status: Review In Progress (was: Patch Available) +1 on the patch. > test_tombstone_failure_threshold_message assert checking if array == string, > should check for array truthiness > -- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16728) test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16728: -- Summary: test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness (was: Fix flaky test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message) > test_tombstone_failure_threshold_message assert checking if array == string, > should check for array truthiness > -- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16728) Fix flaky test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16728: -- Test and Documentation Plan: tested locally Status: Patch Available (was: Open) > Fix flaky test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > --- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16728) Fix flaky test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message
[ https://issues.apache.org/jira/browse/CASSANDRA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16728: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Low Hanging Fruit Discovered By: Unit Test Fix Version/s: NA Severity: Low Status: Open (was: Triage Needed) > Fix flaky test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > --- > > Key: CASSANDRA-16728 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > > The test > pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message > checks for the log message "Scanned over.* tombstones.* query aborted”, but > this can happen on any node, so it will timeout checking node1 then check the > other nodes; when this happens it checks that the returned result equals > "Cannot find tombstone failure threshold error in log after failed query”, > which isn’t possible as the return is matching log lines, this should be > replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16728) Fix flaky test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message
David Capwell created CASSANDRA-16728: - Summary: Fix flaky test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message Key: CASSANDRA-16728 URL: https://issues.apache.org/jira/browse/CASSANDRA-16728 Project: Cassandra Issue Type: Bug Components: Test/dtest/python Reporter: David Capwell Assignee: David Capwell The test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message checks for the log message "Scanned over.* tombstones.* query aborted”, but this can happen on any node, so it will timeout checking node1 then check the other nodes; when this happens it checks that the returned result equals "Cannot find tombstone failure threshold error in log after failed query”, which isn’t possible as the return is matching log lines, this should be replaced by checking for failure truthiness. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360416#comment-17360416
]
Stefan Miklosovic commented on CASSANDRA-16669:
---
Hi [~sumanth.pasupuleti],
I have covered one corner case here:
[https://github.com/instaclustr/cassandra/commit/1b19a8257340118aa9423d8e8bb40ed0e327ecb5]
I saw this kind of entry in audit logs:
LogMessage:
user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:49190|timestamp:1623273348839|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
USER stefan3 WITH PASSWORD = 'bleble';; line 1:33 mismatched input '='
expecting STRING_LITERAL (ALTER USER stefan3 WITH PASSWORD [=]...)
That happens when somebody executes an invalid cql statement. It should be
_without_ that "=" (interesting why it is like that though).
That statement is then not an instance of AuthenticationStatement because it
failed to be instantiated in QueryMessage#execute which means that an exception
is caught in its catch block and it is propagated to
QueryEvents.instance.notifyQueryFailure as "null".
"null" is not an instance of AuthenticationStatement so obfuscation is skipped.
My fix consists of obfuscating if statement is null every time. I also
obfuscate in AuditLogManager where log with exception is treated because there
an exception message appended to that log entry and just to be safe I rather
obfuscate it there as well.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0-rc, 4.0.x, 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16704: --- Reviewers: Michael Semb Wever, Michael Semb Wever (was: Michael Semb Wever) Michael Semb Wever, Michael Semb Wever Status: Review In Progress (was: Patch Available) > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: cleanup-imports.patch, dedup-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16669:
Reviewers: Ekaterina Dimitrova, Stefan Miklosovic, Vinay Chella (was:
Stefan Miklosovic, Vinay Chella)
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0-rc, 4.0.x, 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16679) HintedHandoffAddRemoveNodesTest is failing
[ https://issues.apache.org/jira/browse/CASSANDRA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-16679: --- Assignee: (was: Ekaterina Dimitrova) > HintedHandoffAddRemoveNodesTest is failing > -- > > Key: CASSANDRA-16679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16679 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.distributed.test/HintedHandoffAddRemoveNodesTest/shouldStreamHintsDuringDecommission/ > Java 8 > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/888e47fb-e432-47f2-97df-c34a0d33753a/jobs/4104] > > and Java 11 > > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/ce0f0690-e488-4b5b-ab82-ce92a2f336d8/jobs/4105] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16679) HintedHandoffAddRemoveNodesTest is failing
[ https://issues.apache.org/jira/browse/CASSANDRA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360315#comment-17360315 ] Ekaterina Dimitrova commented on CASSANDRA-16679: - Removing myself from assignment in case someone else has cycles to look at it in the meanwhile > HintedHandoffAddRemoveNodesTest is failing > -- > > Key: CASSANDRA-16679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16679 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.distributed.test/HintedHandoffAddRemoveNodesTest/shouldStreamHintsDuringDecommission/ > Java 8 > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/888e47fb-e432-47f2-97df-c34a0d33753a/jobs/4104] > > and Java 11 > > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/ce0f0690-e488-4b5b-ab82-ce92a2f336d8/jobs/4105] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16679) HintedHandoffAddRemoveNodesTest is failing
[ https://issues.apache.org/jira/browse/CASSANDRA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360310#comment-17360310 ] Ekaterina Dimitrova commented on CASSANDRA-16679: - Committed, thanks To https://github.com/apache/cassandra.git c7795ee62c..dfd5a0b4a5 cassandra-4.0 -> cassandra-4.0 546792169e..e151fa5b89 cassandra-4.0.0 -> cassandra-4.0.0 922872b38f..6c30261bc8 trunk -> trunk > HintedHandoffAddRemoveNodesTest is failing > -- > > Key: CASSANDRA-16679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16679 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.distributed.test/HintedHandoffAddRemoveNodesTest/shouldStreamHintsDuringDecommission/ > Java 8 > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/888e47fb-e432-47f2-97df-c34a0d33753a/jobs/4104] > > and Java 11 > > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/ce0f0690-e488-4b5b-ab82-ce92a2f336d8/jobs/4105] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 6c30261bc8d696f599a1e9ebea8a5bffbd0ac9ed Merge: 922872b dfd5a0b Author: Ekaterina Dimitrova AuthorDate: Wed Jun 9 15:30:51 2021 -0400 Merge branch 'cassandra-4.0' into trunk .../cassandra/distributed/test/HintedHandoffAddRemoveNodesTest.java | 6 ++ 1 file changed, 6 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (922872b -> 6c30261)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 922872b Merge branch 'cassandra-4.0' into trunk add e151fa5 Ignore HintedHandoffAddRemoveNodesTest patch by Ekaterina Dimitrova, reviewed by Brandon Williams for CASSANDRA-16679 add dfd5a0b Merge branch 'cassandra-4.0.0' into cassandra-4.0 new 6c30261 Merge branch 'cassandra-4.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../cassandra/distributed/test/HintedHandoffAddRemoveNodesTest.java | 6 ++ 1 file changed, 6 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (c7795ee -> dfd5a0b)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from c7795ee Merge branch 'cassandra-4.0.0' into cassandra-4.0 add e151fa5 Ignore HintedHandoffAddRemoveNodesTest patch by Ekaterina Dimitrova, reviewed by Brandon Williams for CASSANDRA-16679 add dfd5a0b Merge branch 'cassandra-4.0.0' into cassandra-4.0 No new revisions were added by this update. Summary of changes: .../cassandra/distributed/test/HintedHandoffAddRemoveNodesTest.java | 6 ++ 1 file changed, 6 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 updated (5467921 -> e151fa5)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 5467921 Init client metrics in CQLConnectionTest add e151fa5 Ignore HintedHandoffAddRemoveNodesTest patch by Ekaterina Dimitrova, reviewed by Brandon Williams for CASSANDRA-16679 No new revisions were added by this update. Summary of changes: .../cassandra/distributed/test/HintedHandoffAddRemoveNodesTest.java | 6 ++ 1 file changed, 6 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16679) HintedHandoffAddRemoveNodesTest is failing
[ https://issues.apache.org/jira/browse/CASSANDRA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360307#comment-17360307 ] Brandon Williams commented on CASSANDRA-16679: -- +1 > HintedHandoffAddRemoveNodesTest is failing > -- > > Key: CASSANDRA-16679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16679 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.distributed.test/HintedHandoffAddRemoveNodesTest/shouldStreamHintsDuringDecommission/ > Java 8 > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/888e47fb-e432-47f2-97df-c34a0d33753a/jobs/4104] > > and Java 11 > > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/ce0f0690-e488-4b5b-ab82-ce92a2f336d8/jobs/4105] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16679) HintedHandoffAddRemoveNodesTest is failing
[ https://issues.apache.org/jira/browse/CASSANDRA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360299#comment-17360299 ] Ekaterina Dimitrova commented on CASSANDRA-16679: - Until the in-jvm tests framework issue is solved I suggest [here |https://github.com/ekaterinadimitrova2/cassandra/commit/80122161d3723dea57db268e5d8f1332d084b365] we @Ignore the tests so we can have a clean CI view. The python DTests are still in place, completing successfully. [~brandon.williams], up for review/comment before I commit it? > HintedHandoffAddRemoveNodesTest is failing > -- > > Key: CASSANDRA-16679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16679 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.distributed.test/HintedHandoffAddRemoveNodesTest/shouldStreamHintsDuringDecommission/ > Java 8 > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/888e47fb-e432-47f2-97df-c34a0d33753a/jobs/4104] > > and Java 11 > > [https://app.circleci.com/pipelines/github/adelapena/cassandra/464/workflows/ce0f0690-e488-4b5b-ab82-ce92a2f336d8/jobs/4105] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16727) LICENSE Text addition to Layout.html breaks Cassandra Website rendering
[ https://issues.apache.org/jira/browse/CASSANDRA-16727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360260#comment-17360260 ] Ekaterina Dimitrova commented on CASSANDRA-16727: - Thank you [~bhouser]! I moved the ticket through the phases, hope you don't mind. > LICENSE Text addition to Layout.html breaks Cassandra Website rendering > --- > > Key: CASSANDRA-16727 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16727 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > > The newest docs contain a license agreement comment found in the layout.html > of the theme. This occurs before front matter indicator... > > [https://github.com/apache/cassandra/blob/cassandra-3.11/doc/source/_theme/cassandra_theme/layout.html] > Jekyll assumes that the front matter while be at the top "—". This causes > Jekyll to break when serving the page on the website. > There are a few other docs that seem to have this problem, and serving the > latest docs of the website breaks the rendering. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16727) LICENSE Text addition to Layout.html breaks Cassandra Website rendering
[ https://issues.apache.org/jira/browse/CASSANDRA-16727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16727: Bug Category: Parent values: Correctness(12982) Complexity: Normal Discovered By: User Report Severity: Low Status: Open (was: Triage Needed) > LICENSE Text addition to Layout.html breaks Cassandra Website rendering > --- > > Key: CASSANDRA-16727 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16727 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > > The newest docs contain a license agreement comment found in the layout.html > of the theme. This occurs before front matter indicator... > > [https://github.com/apache/cassandra/blob/cassandra-3.11/doc/source/_theme/cassandra_theme/layout.html] > Jekyll assumes that the front matter while be at the top "—". This causes > Jekyll to break when serving the page on the website. > There are a few other docs that seem to have this problem, and serving the > latest docs of the website breaks the rendering. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16695) cqlsh should prefer newer TLS version by default
[
https://issues.apache.org/jira/browse/CASSANDRA-16695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16695:
Test and Documentation Plan:
https://issues.apache.org/jira/browse/CASSANDRA-16695?focusedCommentId=17360257=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17360257
Status: Patch Available (was: In Progress)
> cqlsh should prefer newer TLS version by default
>
>
> Key: CASSANDRA-16695
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16695
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/cqlsh
>Reporter: Justin Chu
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 2.2.x, 3.0.x, 3.11.x, 4.0-rc, 4.x
>
>
> Some new JDK releases started to disable TLSv1.0 and TLSv1.1.
> [https://www.oracle.com/java/technologies/javase/8u291-relnotes.html]
>
> However, the code in:
> [https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/sslhandling.py#L56-L65]
> is defaulting to those rather old versions,
> which could lead to the following problem:
> {code:java}
> ('Unable to connect to any servers', {'10.101.34.89:9042': error(1, u"Tried
> connecting to [('10.101.34.89', 9042)]. Last error: [SSL:
> WRONG_VERSION_NUMBER] wrong version number (_ssl.c:618)")}) {code}
>
> Python2 default TLS protocol
> [https://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_TLS]
> Python3 default TLS protocol
> [https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16695) cqlsh should prefer newer TLS version by default
[
https://issues.apache.org/jira/browse/CASSANDRA-16695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360257#comment-17360257
]
Ekaterina Dimitrova commented on CASSANDRA-16695:
-
Some base tests were added
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/8438676eb6f53472b59f3e4f37c14bf101102f2e]
Circle CI runs: [Java
8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/950/workflows/848f0373-8b40-46fc-9d2c-1b50695dc4be/jobs/5668/steps]|
[Java
11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/950/workflows/5e14a77d-2741-46a8-8a8f-4909fb9c2dcc/jobs/5672]
Patch created by Kamlesh Ghoradkar with a bit of guidance from [~justinchu].
Thank you both!
The current tests assume that TLSv1 is supported in the environment they are
run, [~tomasz.lasica] expressed a concern that it is possible that some tests
will fail if a platform on which test is run does not support {{TLSv1. A
suggestion is to try to detect what is supported by the OS but in a quick check
I saw that this is done in a different ways depending on which Python version
we use. Considering that these tests are improvement, I am wondering whether we
should add them now or improve them after 4.0}}
[~mck], [~brandon.williams] - up for review and second opinion?
The tests are currently added only to the 4.0 branch, I will port them to the
other branches when we agree on the final patch.
> cqlsh should prefer newer TLS version by default
>
>
> Key: CASSANDRA-16695
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16695
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/cqlsh
>Reporter: Justin Chu
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 2.2.x, 3.0.x, 3.11.x, 4.0-rc, 4.x
>
>
> Some new JDK releases started to disable TLSv1.0 and TLSv1.1.
> [https://www.oracle.com/java/technologies/javase/8u291-relnotes.html]
>
> However, the code in:
> [https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/sslhandling.py#L56-L65]
> is defaulting to those rather old versions,
> which could lead to the following problem:
> {code:java}
> ('Unable to connect to any servers', {'10.101.34.89:9042': error(1, u"Tried
> connecting to [('10.101.34.89', 9042)]. Last error: [SSL:
> WRONG_VERSION_NUMBER] wrong version number (_ssl.c:618)")}) {code}
>
> Python2 default TLS protocol
> [https://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_TLS]
> Python3 default TLS protocol
> [https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16573) CQLSH copy defaults appear to be incorrect on website
[
https://issues.apache.org/jira/browse/CASSANDRA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360252#comment-17360252
]
Brian Houser commented on CASSANDRA-16573:
--
For sanity, I'll treat this issue separately... created this ticket to work on
the legal text issue https://issues.apache.org/jira/browse/CASSANDRA-16727
> CQLSH copy defaults appear to be incorrect on website
> -
>
> Key: CASSANDRA-16573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16573
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation/Website
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
>
> The documentation on the website for the defaults of CQLSH appear to be
> incorrect and contain numerous errors (at least for the latest and greatest)
> For this page:
> [https://cassandra.apache.org/doc/latest/tools/cqlsh.html]
> {{MINBATCHSIZE}} is listed as defaulting to 2. Code says this is 10.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L355
> Chunksize says 1000, actually set to 5000.
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L352
> NumProcessis is also off...
> "NUMPROCESSES
> The number of child worker processes to create for COPY tasks. Defaults to a
> max of 4 for COPY FROM and 16 for COPY TO. However, at most (num_cores - 1)
> processes will be created."
> Default is the number of cores -1 or 16 which ever is smaller, and you can
> set this value to anything. See the following code
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L361
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/copyutil.py#L407
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16727) LICENSE Text addition to Layout.html breaks Cassandra Website rendering
[ https://issues.apache.org/jira/browse/CASSANDRA-16727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360250#comment-17360250 ] Brian Houser commented on CASSANDRA-16727: -- Found during https://issues.apache.org/jira/browse/CASSANDRA-16573. Seems that this will work just find if the comment is placed underneath the front matter. There are other elements of the theme that have this problem. Currently working on a fix. > LICENSE Text addition to Layout.html breaks Cassandra Website rendering > --- > > Key: CASSANDRA-16727 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16727 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > > The newest docs contain a license agreement comment found in the layout.html > of the theme. This occurs before front matter indicator... > > [https://github.com/apache/cassandra/blob/cassandra-3.11/doc/source/_theme/cassandra_theme/layout.html] > Jekyll assumes that the front matter while be at the top "—". This causes > Jekyll to break when serving the page on the website. > There are a few other docs that seem to have this problem, and serving the > latest docs of the website breaks the rendering. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16727) LICENSE Text addition to Layout.html breaks Cassandra Website rendering
Brian Houser created CASSANDRA-16727: Summary: LICENSE Text addition to Layout.html breaks Cassandra Website rendering Key: CASSANDRA-16727 URL: https://issues.apache.org/jira/browse/CASSANDRA-16727 Project: Cassandra Issue Type: Bug Components: Documentation/Website Reporter: Brian Houser Assignee: Brian Houser The newest docs contain a license agreement comment found in the layout.html of the theme. This occurs before front matter indicator... [https://github.com/apache/cassandra/blob/cassandra-3.11/doc/source/_theme/cassandra_theme/layout.html] Jekyll assumes that the front matter while be at the top "—". This causes Jekyll to break when serving the page on the website. There are a few other docs that seem to have this problem, and serving the latest docs of the website breaks the rendering. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360242#comment-17360242 ] Angelo Polo commented on CASSANDRA-16704: - The patch 'cleanup-imports.patch' is simply the old patch with the change to build.xml removed. The patch 'dedup-deps.patch' contains the following changes, exclusively modifying build.xml, from my understanding of our discussion above: * Removed duplicates of test scope that are already in provided scope. * Removed duplicated scope attributes. All scope attributes are now uniformly provided in parent-pom. * Added to parent-pom. Was previously only declared in build-deps-pom. > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: cleanup-imports.patch, dedup-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angelo Polo updated CASSANDRA-16704: Attachment: (was: test-with-runtime-deps.patch) > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: cleanup-imports.patch, dedup-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angelo Polo updated CASSANDRA-16704: Attachment: cleanup-imports.patch dedup-deps.patch > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: cleanup-imports.patch, dedup-deps.patch, > test-with-runtime-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16725) Implement nodetool getauditlog command
[ https://issues.apache.org/jira/browse/CASSANDRA-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359527#comment-17359527 ] Stefan Miklosovic edited comment on CASSANDRA-16725 at 6/9/21, 5:06 PM: PR https://github.com/apache/cassandra/pull/1051/files was (Author: stefan.miklosovic): PR https://github.com/apache/cassandra/pull/1047 > Implement nodetool getauditlog command > -- > > Key: CASSANDRA-16725 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16725 > Project: Cassandra > Issue Type: New Feature > Components: Tool/auditlogging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > There is getfullquerylog already, there is not any reason why getauditlog > should not be there too. A user can not retrieve runtime configuration of > Audit log, it might be only enabled and disabled via jmx but its state can > not be queried in runtime. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16262) 4.0 Quality: Coordination & Replication Fuzz Testing
[ https://issues.apache.org/jira/browse/CASSANDRA-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360193#comment-17360193 ] Caleb Rackliffe commented on CASSANDRA-16262: - Should we move this to 4.x and close its parent, CASSANDRA-15579, which now depends only on this issue? > 4.0 Quality: Coordination & Replication Fuzz Testing > > > Key: CASSANDRA-16262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16262 > Project: Cassandra > Issue Type: Task > Components: Test/fuzz >Reporter: Caleb Rackliffe >Assignee: Alex Petrov >Priority: Normal > Fix For: 4.0-rc > > > CASSANDRA-16180, CASSANDRA-16181, and CASSANDRA-15977 have largely focused on > auditing the existing tests around coordination, replication, and > read-repair, respectively. We've expanded existing test cases, added coverage > around components that we've refactored along the way, and added in-JVM dtest > upgrade tests where possible. > What remains is verifying the distributed read and write paths in the face of > common operational events, namely node restarts, bootstrapping, decommission, > and cleanup. If we can find a way to simulate these events, > [Harry|https://github.com/apache/cassandra-harry] seems like a good candidate > to host the verification logic itself. > To keep things simple initially, I would propose that we start by testing > simple read-only and write-only workloads (the former without read repair). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16722) ClientMetrics should be initialised in CQLConnectionTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-16722:
Fix Version/s: (was: 4.0-rc)
4.0
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/546792169e7df90c905139d1a275056bbef850d4
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Thanks, committed with one additional tweak to remove a race in
{{CQLConnectionTest}} when the server closes the channel.
> ClientMetrics should be initialised in CQLConnectionTest
>
>
> Key: CASSANDRA-16722
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16722
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0
>
>
> Without a call to {{ClientMetrics.instance.init}}, client protocol errors
> cause an NPE when the server attempts to mark the relevant meter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360143#comment-17360143
]
Ekaterina Dimitrova commented on CASSANDRA-16720:
-
Thank you [~stefan.miklosovic]. Looking forward to your findings and please
reopen the ticket if you find legit bug. I don't want to ignore a valid issue.
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (f364a17 -> 922872b)
This is an automated email from the ASF dual-hosted git repository. samt pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from f364a17 Merge branch 'cassandra-4.0' into trunk new 5467921 Init client metrics in CQLConnectionTest new c7795ee Merge branch 'cassandra-4.0.0' into cassandra-4.0 new 922872b Merge branch 'cassandra-4.0' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/transport/SimpleClient.java | 2 +- .../cassandra/transport/CQLConnectionTest.java | 30 +- 2 files changed, 13 insertions(+), 19 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. samt pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 922872b38f91cdf9d70c4612281a2cb5290bf127 Merge: f364a17 c7795ee Author: Sam Tunnicliffe AuthorDate: Wed Jun 9 16:09:58 2021 +0100 Merge branch 'cassandra-4.0' into trunk .../apache/cassandra/transport/SimpleClient.java | 2 +- .../cassandra/transport/CQLConnectionTest.java | 30 +- 2 files changed, 13 insertions(+), 19 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 updated (1b24f3e -> 5467921)
This is an automated email from the ASF dual-hosted git repository. samt pushed a change to branch cassandra-4.0.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 1b24f3e Ignore in-jvm FqlReplayDDLExclusionTest in favor of python dtest. new 5467921 Init client metrics in CQLConnectionTest The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/transport/SimpleClient.java | 2 +- .../cassandra/transport/CQLConnectionTest.java | 30 +- 2 files changed, 13 insertions(+), 19 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Init client metrics in CQLConnectionTest
This is an automated email from the ASF dual-hosted git repository.
samt pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 5467921 Init client metrics in CQLConnectionTest
new c7795ee Merge branch 'cassandra-4.0.0' into cassandra-4.0
5467921 is described below
commit 546792169e7df90c905139d1a275056bbef850d4
Author: Sam Tunnicliffe
AuthorDate: Mon Jun 7 19:21:19 2021 +0100
Init client metrics in CQLConnectionTest
Patch by Sam Tunnicliffe; reviewed by Mick Semb Wever for CASSANDRA-16722
---
.../apache/cassandra/transport/SimpleClient.java | 2 +-
.../cassandra/transport/CQLConnectionTest.java | 30 +-
2 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/src/java/org/apache/cassandra/transport/SimpleClient.java
b/src/java/org/apache/cassandra/transport/SimpleClient.java
index 0ca1c58..ae89e93 100644
--- a/src/java/org/apache/cassandra/transport/SimpleClient.java
+++ b/src/java/org/apache/cassandra/transport/SimpleClient.java
@@ -719,7 +719,7 @@ public class SimpleClient implements Closeable
if (bufferSize + messageSize >= MAX_FRAMED_PAYLOAD_SIZE)
{
combiner.add(flushBuffer(ctx, buffer, bufferSize));
-buffer.clear();
+buffer = new ArrayList<>();
bufferSize = 0;
}
buffer.add(f);
diff --git a/test/unit/org/apache/cassandra/transport/CQLConnectionTest.java
b/test/unit/org/apache/cassandra/transport/CQLConnectionTest.java
index eec9fed..96f28a2 100644
--- a/test/unit/org/apache/cassandra/transport/CQLConnectionTest.java
+++ b/test/unit/org/apache/cassandra/transport/CQLConnectionTest.java
@@ -47,6 +47,7 @@ import org.apache.cassandra.auth.AllowAllNetworkAuthorizer;
import org.apache.cassandra.concurrent.NamedThreadFactory;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.cql3.QueryProcessor;
+import org.apache.cassandra.metrics.ClientMetrics;
import org.apache.cassandra.net.*;
import org.apache.cassandra.net.proxy.InboundProxyHandler;
import org.apache.cassandra.service.NativeTransportService;
@@ -500,10 +501,12 @@ public class CQLConnectionTest
private Server server(ServerConfigurator configurator)
{
-return new Server.Builder().withHost(address)
- .withPort(port)
- .withPipelineConfigurator(configurator)
- .build();
+Server server = new Server.Builder().withHost(address)
+ .withPort(port)
+ .withPipelineConfigurator(configurator)
+ .build();
+ClientMetrics.instance.init(Collections.singleton(server));
+return server;
}
private Envelope randomEnvelope(int streamId, Message.Type type)
@@ -624,18 +627,18 @@ public class CQLConnectionTest
if (flusher == null)
flusher = new SimpleClient.SimpleFlusher(frameEncoder);
-Flusher.FlushItem.Framed item =
(Flusher.FlushItem.Framed)toFlushItem.toFlushItem(channel, message,
fixedResponse);
Envelope response = Envelope.create(responseTemplate.header.type,
message.getStreamId(),
ProtocolVersion.V5,
responseTemplate.header.flags,
responseTemplate.body.copy());
-item.release();
flusher.enqueue(response);
-
// Schedule the proto-flusher to collate any messages to be served
// and flush them to the outbound pipeline
flusher.schedule(channel.pipeline().lastContext());
+// this simulates the release of the allocated resources that a
real flusher would do
+Flusher.FlushItem.Framed item =
(Flusher.FlushItem.Framed)toFlushItem.toFlushItem(channel, message,
fixedResponse);
+item.release();
}
}
@@ -1005,6 +1008,7 @@ public class CQLConnectionTest
inboundMessages.add(decoder.decode(buffer));
responsesReceived.countDown();
}
+
catch (Exception e)
{
throw new IOException(e);
@@ -1030,15 +1034,10 @@ public class CQLConnectionTest
@Override
public void exceptionCaught(final
ChannelHandlerContext ctx, Throwable cause) throws Exception
[jira] [Commented] (CASSANDRA-16681) org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360133#comment-17360133 ] Adam Holmberg commented on CASSANDRA-16681: --- bq. I have a patch with some synchronization around the release+status update that removes this flakiness. Getting back to this after some time, I'm less confident in the patch. I ported the fix without all my instrumentation and I'm back seeing flakiness. I will be looking into it more, but meanwhile I'm open to input if there are other leads. > org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky > -- > > Key: CASSANDRA-16681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16681 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Adam Holmberg >Priority: Normal > Fix For: 4.0, 4.0-rc > > Time Spent: 20m > Remaining Estimate: 0h > > Jenkins history: > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.utils.memory/LongBufferPoolTest/testPoolAllocateWithRecyclePartially/history/] > Fails being run in a loop in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/844/workflows/945011f4-00ac-4678-89f6-5c0db0a40169/jobs/5008 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360127#comment-17360127
]
Stefan Miklosovic edited comment on CASSANDRA-16720 at 6/9/21, 2:41 PM:
However, I see that "recycler" exception from time to time when Cassandra is
running long enough, seems non-deterministic at first sight ...
I will try to nail down if it is or is not happening really randomly. However,
it is already released so that is not too bad but that log is concerning.
WARN [background~resource~releaser] 2021-06-09 14:37:32,315
Slf4jExceptionHandler.java:38 - Failed in release/close
net.openhft.chronicle.core.io.ClosedIllegalStateException:
net.openhft.chronicle.bytes.MappedBytesStore already released
at
net.openhft.chronicle.core.io.VanillaReferenceCounted.callOnRelease(VanillaReferenceCounted.java:99)
at
net.openhft.chronicle.core.io.VanillaReferenceCounted.release(VanillaReferenceCounted.java:90)
at
net.openhft.chronicle.core.io.AbstractReferenceCounted.release(AbstractReferenceCounted.java:123)
at
net.openhft.chronicle.bytes.AbstractBytes.performRelease(AbstractBytes.java:341)
at net.openhft.chronicle.bytes.MappedBytes.performRelease(MappedBytes.java:535)
at
net.openhft.chronicle.core.io.BackgroundResourceReleaser.performRelease(BackgroundResourceReleaser.java:79)
at
net.openhft.chronicle.core.io.BackgroundResourceReleaser.runReleaseResources(BackgroundResourceReleaser.java:28)
at java.lang.Thread.run(Thread.java:748)
was (Author: stefan.miklosovic):
However, I see that "recycler" exception from time to time when Cassandra is
running long enough, seems non-deterministic at first sight ...
I will try to nail down if it is or is not happening really randomly. However,
it is already released so that is not too bad bad that log is concerning.
WARN [background~resource~releaser] 2021-06-09 14:37:32,315
Slf4jExceptionHandler.java:38 - Failed in release/close
net.openhft.chronicle.core.io.ClosedIllegalStateException:
net.openhft.chronicle.bytes.MappedBytesStore already released
at
net.openhft.chronicle.core.io.VanillaReferenceCounted.callOnRelease(VanillaReferenceCounted.java:99)
at
net.openhft.chronicle.core.io.VanillaReferenceCounted.release(VanillaReferenceCounted.java:90)
at
net.openhft.chronicle.core.io.AbstractReferenceCounted.release(AbstractReferenceCounted.java:123)
at
net.openhft.chronicle.bytes.AbstractBytes.performRelease(AbstractBytes.java:341)
at net.openhft.chronicle.bytes.MappedBytes.performRelease(MappedBytes.java:535)
at
net.openhft.chronicle.core.io.BackgroundResourceReleaser.performRelease(BackgroundResourceReleaser.java:79)
at
net.openhft.chronicle.core.io.BackgroundResourceReleaser.runReleaseResources(BackgroundResourceReleaser.java:28)
at java.lang.Thread.run(Thread.java:748)
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16720:
-
Since Version: 4.0-beta1
Source Control Link:
https://github.com/apache/cassandra/commit/1b24f3e1a772127c716c75b47651646087030ee0
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed and created CASSANDRA-16726 to follow up on the jvm dtest.
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360127#comment-17360127
]
Stefan Miklosovic commented on CASSANDRA-16720:
---
However, I see that "recycler" exception from time to time when Cassandra is
running long enough, seems non-deterministic at first sight ...
I will try to nail down if it is or is not happening really randomly. However,
it is already released so that is not too bad bad that log is concerning.
WARN [background~resource~releaser] 2021-06-09 14:37:32,315
Slf4jExceptionHandler.java:38 - Failed in release/close
net.openhft.chronicle.core.io.ClosedIllegalStateException:
net.openhft.chronicle.bytes.MappedBytesStore already released
at
net.openhft.chronicle.core.io.VanillaReferenceCounted.callOnRelease(VanillaReferenceCounted.java:99)
at
net.openhft.chronicle.core.io.VanillaReferenceCounted.release(VanillaReferenceCounted.java:90)
at
net.openhft.chronicle.core.io.AbstractReferenceCounted.release(AbstractReferenceCounted.java:123)
at
net.openhft.chronicle.bytes.AbstractBytes.performRelease(AbstractBytes.java:341)
at net.openhft.chronicle.bytes.MappedBytes.performRelease(MappedBytes.java:535)
at
net.openhft.chronicle.core.io.BackgroundResourceReleaser.performRelease(BackgroundResourceReleaser.java:79)
at
net.openhft.chronicle.core.io.BackgroundResourceReleaser.runReleaseResources(BackgroundResourceReleaser.java:28)
at java.lang.Thread.run(Thread.java:748)
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16720:
-
Reviewers: Ekaterina Dimitrova, Brandon Williams (was: Brandon Williams,
Ekaterina Dimitrova)
Ekaterina Dimitrova, Brandon Williams
Status: Review In Progress (was: Patch Available)
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16726) in-jvm dtest problem: org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[ https://issues.apache.org/jira/browse/CASSANDRA-16726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16726: - Bug Category: Parent values: Correctness(12982) Complexity: Normal Component/s: Test/dtest/java Discovered By: DTest Fix Version/s: 4.0.x Severity: Normal Status: Open (was: Triage Needed) > in-jvm dtest problem: > org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test > --- > > Key: CASSANDRA-16726 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16726 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0.x > > > This test is currently being ignored due to an issue in the dtest framework. > See CASSANDRA-16720. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16720:
-
Status: Ready to Commit (was: Review In Progress)
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16726) in-jvm dtest problem: org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
Brandon Williams created CASSANDRA-16726: Summary: in-jvm dtest problem: org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test Key: CASSANDRA-16726 URL: https://issues.apache.org/jira/browse/CASSANDRA-16726 Project: Cassandra Issue Type: Bug Reporter: Brandon Williams This test is currently being ignored due to an issue in the dtest framework. See CASSANDRA-16720. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Ignore in-jvm FqlReplayDDLExclusionTest in favor of python dtest.
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 1b24f3e Ignore in-jvm FqlReplayDDLExclusionTest in favor of python
dtest.
new ddccb3f Merge branch 'cassandra-4.0.0' into cassandra-4.0
1b24f3e is described below
commit 1b24f3e1a772127c716c75b47651646087030ee0
Author: Brandon Williams
AuthorDate: Wed Jun 9 09:35:27 2021 -0500
Ignore in-jvm FqlReplayDDLExclusionTest in favor of python dtest.
Patch by brandonwilliams, reviewed by edimitrova for CASSANDRA-16720
---
.../apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java| 2 ++
1 file changed, 2 insertions(+)
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java
b/test/distributed/org/apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java
index f117c51..3dbef35 100644
---
a/test/distributed/org/apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java
@@ -18,6 +18,7 @@
package org.apache.cassandra.distributed.test;
+import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
@@ -42,6 +43,7 @@ public class FqlReplayDDLExclusionTest extends TestBaseImpl
@Rule
public final TemporaryFolder temporaryFolder = new TemporaryFolder();
+@Ignore
@Test
public void test() throws Throwable
{
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit f364a17881ea96ab7ae352a75551aa0ab1bca1f1 Merge: a56bd76 ddccb3f Author: Brandon Williams AuthorDate: Wed Jun 9 09:37:30 2021 -0500 Merge branch 'cassandra-4.0' into trunk .../apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java| 2 ++ 1 file changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (a56bd76 -> f364a17)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from a56bd76 Merge branch 'cassandra-4.0' into trunk new 1b24f3e Ignore in-jvm FqlReplayDDLExclusionTest in favor of python dtest. new ddccb3f Merge branch 'cassandra-4.0.0' into cassandra-4.0 new f364a17 Merge branch 'cassandra-4.0' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java| 2 ++ 1 file changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 updated (3e153c8 -> 1b24f3e)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 3e153c8 Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits new 1b24f3e Ignore in-jvm FqlReplayDDLExclusionTest in favor of python dtest. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/distributed/test/FqlReplayDDLExclusionTest.java| 2 ++ 1 file changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Move flaky in-jvm fql dtest to python
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new e9857b8 Move flaky in-jvm fql dtest to python
e9857b8 is described below
commit e9857b82f26f0910e2d5ace67c34a1efc0509d6c
Author: Brandon Williams
AuthorDate: Wed Jun 9 08:48:08 2021 -0500
Move flaky in-jvm fql dtest to python
Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-16720
---
fqltool_test.py | 28
1 file changed, 28 insertions(+)
diff --git a/fqltool_test.py b/fqltool_test.py
index 9782650..f7e7c1a 100644
--- a/fqltool_test.py
+++ b/fqltool_test.py
@@ -132,6 +132,34 @@ class TestFQLTool(Tester):
output = self._run_fqltool_compare(node1, queries1, [results1,
results2])
assert b"MISMATCH" in output # compares two different stress
runs, should mismatch
+def test_jvmdtest(self):
+""" mimics the behavior of the in-jvm dtest, see CASSANDRA-16720 """
+self.cluster.populate(1).start()
+node1 = self.cluster.nodelist()[0]
+
+session = self.patient_cql_connection(node1)
+
+with tempfile.TemporaryDirectory() as temp_dir:
+tmpdir = tempfile.mkdtemp(dir=temp_dir)
+session.execute("CREATE KEYSPACE fql_ks WITH replication =
{'class': 'SimpleStrategy', 'replication_factor': 1};")
+node1.nodetool("enablefullquerylog --path={}".format(tmpdir))
+session.execute("CREATE TABLE fql_ks.fql_table (id int primary
key);")
+session.execute("INSERT INTO fql_ks.fql_table (id) VALUES (1)")
+node1.nodetool("disablefullquerylog")
+session.execute("DROP TABLE fql_ks.fql_table;")
+self._run_fqltool_replay(node1, [tmpdir], "127.0.0.1", None, None,
replay_ddl_statements=False)
+
+got_exception = False
+try:
+session.execute("SELECT * FROM fql_ks.fql_table;")
+except Exception:
+got_exception = True
+assert got_exception
+
+self._run_fqltool_replay(node1, [tmpdir], "127.0.0.1", None, None,
replay_ddl_statements=True)
+rs = session.execute("SELECT * FROM fql_ks.fql_table;")
+assert(len(list(rs)) == 1)
+
def _run_fqltool_replay(self, node, logdirs, target, queries, results,
replay_ddl_statements=False):
fqltool = self.fqltool(node)
args = [fqltool, "replay", "--target {}".format(target)]
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11305) Customization of the auto granting process
[
https://issues.apache.org/jira/browse/CASSANDRA-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360124#comment-17360124
]
Jonathan Koppenhofer commented on CASSANDRA-11305:
--
Reviving this older issue as there are use cases where automatic granting may
not be desired, and potentially break separation of duties concerns. You may
want to allow a user to create a table without having permissions to Authorize
on that table (which is my primary concern). Other concerns people may have is
the nee to keep DDL users separate from users that can actually read/write
data. Also, from a permissions hygiene perspective, if the user already has
keyspace level permissions, they may not want duplicative table level
permissions (can lead to confusion if permissions need revoked).
I like the thoroughness of the original Jira, but I am more inline with simply
being able to turn auto-granting on/off at the yaml level. I'm looking for
feedback on what approach others would like to see.
> Customization of the auto granting process
> --
>
> Key: CASSANDRA-11305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11305
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/CQL
> Environment: Apache Cassandra 3.3, cqlsh 5.0.1, CQL spec 3.4.0
>Reporter: Alexandre Linte
>Priority: Low
> Fix For: 4.x
>
>
> Hello,
> By default, Cassandra implements an auto granting process which is applied
> when a USER | ROLE does a CREATE KEYSPACE, CREATE TABLE, CREATE FUNCTION,
> CREATE AGGREGATE or CREATE ROLE statement. The creator is automatically
> granted all applicable permissions on the new resource.
> For example, the ROLE "toto_user" is created and has CREATE permission on its
> personal KEYSPACE "toto_keyspace". Today when toto_user create a TABLE, he is
> automatically granted the following rights:
> * ALTER
> * DROP
> * SELECT
> * MODIFY
> * AUTHORIZE
> Moreover if you want to REVOKE a permission for "toto_user" on a table, this
> table must exist.
> The idea of the issue is to improve the auto granting process. I thought
> about a modification of the REVOKE and GRANT SQL commands. You can find below
> the syntax part:
> {noformat}
> ::= GRANT ( ALL ( PERMISSIONS )? | (
> PERMISSION )? ) ON TO
> ::= CREATE | ALTER | DROP | SELECT | MODIFY | AUTHORIZE |
> DESRIBE | EXECUTE
> ::= ALL KEYSPACES
> | KEYSPACE
> | ( TABLE )?
> | ALL ROLES
> | ROLE
> | ALL FUNCTIONS ( IN KEYSPACE )?
> | FUNCTION
> ::= WHEN CREATE ( KEYSPACE | TABLE | ROLE )
> {noformat}
> {noformat}
> ::= REVOKE ( ALL ( PERMISSIONS )? | (
> PERMISSION )? ) ON FROM
> ::= CREATE | ALTER | DROP | SELECT | MODIFY | AUTHORIZE |
> DESRIBE | EXECUTE
> ::= ALL KEYSPACES
> | KEYSPACE
> | ( TABLE )?
> | ALL ROLES
> | ROLE
> | ALL FUNCTIONS ( IN KEYSPACE )?
> | FUNCTION
> ::= WHEN CREATE ( KEYSPACE | TABLE | ROLE )
> {noformat}
> And now multiple the samples part:
> {noformat}
> GRANT ALL PERMISSIONS ON KEYSPACE toto_keyspace TO toto_user;
> => default functioning, when toto_user creates a table he will be
> automatically granted all permissions.
> GRANT ALL PERMISSIONS ON KEYSPACE toto_keyspace TO toto_user WHEN CREATE
> TABLE;
> => grant all permissions to the resource (table) created by toto_user on the
> keyspace toto_keyspace.
> GRANT SELECT ON KEYSPACE toto_keyspace TO toto_user WHEN CREATE TABLE;
> => grant select permission to the resource (table) created by toto_user on
> the keyspace toto_keyspace.
> REVOKE ALL PERMISSIONS ON KEYSPACE toto_keyspace FROM toto_user;
> => default functioning, toto_user will not be able to do something on the
> keyspace toto_keyspace.
> REVOKE AUTHORIZE PERMISSION ON KEYSPACE toto_keyspace FROM toto_user WHEN
> CREATE TABLE;
> => revoke authorize permission to the resource (table) created by toto_user
> on the keyspace toto_keyspace.
> REVOKE DROP PERMISSION ALL KEYSPACES FROM toto_user WHEN CREATE ROLE;
> => revoke drop permission to the resource (role) created by toto_user on the
> keyspace toto_keyspace.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360106#comment-17360106
]
Ekaterina Dimitrova edited comment on CASSANDRA-16720 at 6/9/21, 2:16 PM:
--
+1 I was about to say that those class loaders issues seem like in-jvm
framework issue. We should fix them at some point but I would suggest this to
be post 4.0. I also don't think this is a product defect. Thanks
[~brandon.williams]
I would suggest we commit the python test and leave this ticket marked open
4.0.x maybe?
was (Author: e.dimitrova):
+1 I was about to say that those class loaders issues seem like framework
issue. We should fix them at some point but I would suggest this to be post
4.0. I also don't think this is a product defect. Thanks [~brandon.williams]
I would suggest we commit the python test and leave this ticket marked open
4.0.x maybe?
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360106#comment-17360106
]
Ekaterina Dimitrova commented on CASSANDRA-16720:
-
+1 I was about to say that those class loaders issues seem like framework
issue. We should fix them at some point but I would suggest this to be post
4.0. I also don't think this is a product defect. Thanks [~brandon.williams]
I would suggest we commit the python test and leave this ticket marked open
4.0.x maybe?
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16689) Flaky LeaveAndBootstrapTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-16689:
Assignee: Brandon Williams
> Flaky LeaveAndBootstrapTest
> ---
>
> Key: CASSANDRA-16689
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16689
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Failing in a circle run
> [here|https://app.circleci.com/pipelines/github/bereng/cassandra/309/workflows/a645b956-dcd7-431e-b109-7857af3c523f/jobs/2937]
> {noformat}
> Testcase:
> testStateJumpToNormal(org.apache.cassandra.service.LeaveAndBootstrapTest):
> Caused an ERROR
> [junit-timeout] null
> [junit-timeout] java.lang.NullPointerException
> [junit-timeout] at
> org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2418)
> [junit-timeout] at
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2756)
> [junit-timeout] at
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2299)
> [junit-timeout] at
> org.apache.cassandra.Util.createInitialRing(Util.java:236)
> [junit-timeout] at
> org.apache.cassandra.service.LeaveAndBootstrapTest.testStateJumpToNormal(LeaveAndBootstrapTest.java:550)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360097#comment-17360097
]
Brandon Williams commented on CASSANDRA-16720:
--
I copied this test's behavior to a [python
dtest|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-16720] which has
looped thousands of times without failure. Given this I'm left to conclude
we're dealing with another spooky behavior from an in-jvm dtest. I propose we
commit the python version and remove this one to retain coverage and get CI
closer to green.
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16720) Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
[
https://issues.apache.org/jira/browse/CASSANDRA-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16720:
-
Test and Documentation Plan: add dtest
Status: Patch Available (was: Open)
> Fix org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test
> -
>
> Key: CASSANDRA-16720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16720
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0-rc
>
> Attachments: fqllogs.tar.bz2
>
>
> It failed a few times in Jenkins lately. Example:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/12/testReport/junit/org.apache.cassandra.distributed.test/FqlReplayDDLExclusionTest/test/]
> {code:java}
> Error Message
> Expected: [[1]] Actual: []
> Stacktrace
> junit.framework.AssertionFailedError: Expected: [[1]] Actual: [] at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:58)
> at
> org.apache.cassandra.distributed.test.FqlReplayDDLExclusionTest.test(FqlReplayDDLExclusionTest.java:102)
> {code}
> I was also able to reproduce it locally on the latest 4.0.0 so I believe it
> is worth it to be checked.
> //CC [~stefan.miklosovic] and [~bereng] as I see you two are the only people
> who worked on that test up to now so If you have any thoughts to share, as
> usual, that will be highly appreciated :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16685) Flaky ActiveRepairServiceTest.testRejectWhenPoolFullStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-16685:
---
Reviewers: Andres de la Peña, Michael Semb Wever (was: Andres de la Peña)
> Flaky ActiveRepairServiceTest.testRejectWhenPoolFullStrategy
>
>
> Key: CASSANDRA-16685
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16685
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [ActiveRepairServiceTest.testRejectWhenPoolFullStrategy|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.service/ActiveRepairServiceTest/testRejectWhenPoolFullStrategy_compression/]
> {noformat}
> Error Message
> Task java.util.concurrent.FutureTask@63553e9f[Not completed, task =
> java.util.concurrent.Executors$RunnableAdapter@52cb52bd[Wrapped task =
> org.apache.cassandra.service.ActiveRepairServiceTest$Task@1d1c37d5]] rejected
> from
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@218df7d6[Running,
> pool size = 2, active threads = 2, queued tasks = 0, completed tasks = 0]
> Stacktrace
> java.util.concurrent.RejectedExecutionException: Task
> java.util.concurrent.FutureTask@63553e9f[Not completed, task =
> java.util.concurrent.Executors$RunnableAdapter@52cb52bd[Wrapped task =
> org.apache.cassandra.service.ActiveRepairServiceTest$Task@1d1c37d5]] rejected
> from
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@218df7d6[Running,
> pool size = 2, active threads = 2, queued tasks = 0, completed tasks = 0]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2055)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:825)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1355)
> at
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor.execute(DebuggableThreadPoolExecutor.java:176)
> at
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:118)
> at
> org.apache.cassandra.service.ActiveRepairServiceTest.testRejectWhenPoolFullStrategy(ActiveRepairServiceTest.java:380)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:04:31,694 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:04:31,698 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:04:31,807 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:04:31,827 PlatformDependent0
> ...[truncated 95289 chars]...
> andra/build/test/cassandra/data/system/local-7ad54392bcdd35a684174e047860b377/nb_txn_flush_08e70270-b825-11eb-a393-871312b17b94.log
>
> DEBUG [MemtableFlushWriter:1] 2021-05-18 22:04:36,792
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system/local-7ad54392bcdd35a684174e047860b377/nb-15-big-Data.db')]
> (1 sstables, 4.944KiB), biggest 4.944KiB, smallest 4.944KiB
> DEBUG [main] 2021-05-18 22:04:36,795 StorageService.java:1619 - NORMAL
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12519) dtest failure in offline_tools_test.TestOfflineTools.sstableofflinerelevel_test
[
https://issues.apache.org/jira/browse/CASSANDRA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359942#comment-17359942
]
Andres de la Peña commented on CASSANDRA-12519:
---
The error mentioned in the description and in the two tickets that this is a
duplicate of is about the releveling itself, and I haven't been able to
reproduce it in 4.0.
However, the error mentioned in the last comment is different. This new error
consists on a validation error in the transaction log, thrown when running
{{sstableoflinerelevel}}, at the moment of [listing the
sstables|https://github.com/apache/cassandra/blob/cassandra-4.0.0/src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java#L104].
I haven't been able to reproduce this new type of failure in 3.0 and 3.11,
although it can be reproduced in 4.0 with a few thousands of rounds in the
multiplexer.
I suspect that somehow the corruption happens in the previous call to
{{sstablelevelreset}}, so {{sstableoflinerelevel}} hits it before it actually
starts the releveling. Indeed, the failure can be reproduced by just calling
{{sstablelevelreset}} twice, without using {{sstableoflinerelevel}}.
> dtest failure in
> offline_tools_test.TestOfflineTools.sstableofflinerelevel_test
> ---
>
> Key: CASSANDRA-12519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12519
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
>Reporter: Sean McCarthy
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 3.0.x, 3.11.x, 4.x
>
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/379/testReport/offline_tools_test/TestOfflineTools/sstableofflinerelevel_test/
> {code}
> Stacktrace
> File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
> File "/home/automaton/cassandra-dtest/offline_tools_test.py", line 209, in
> sstableofflinerelevel_test
> self.assertGreater(max(final_levels), 1)
> File "/usr/lib/python2.7/unittest/case.py", line 942, in assertGreater
> self.fail(self._formatMessage(msg, standardMsg))
> File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "1 not greater than 1
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16685) Flaky ActiveRepairServiceTest.testRejectWhenPoolFullStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16685:
--
Reviewers: Andres de la Peña
> Flaky ActiveRepairServiceTest.testRejectWhenPoolFullStrategy
>
>
> Key: CASSANDRA-16685
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16685
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [ActiveRepairServiceTest.testRejectWhenPoolFullStrategy|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.service/ActiveRepairServiceTest/testRejectWhenPoolFullStrategy_compression/]
> {noformat}
> Error Message
> Task java.util.concurrent.FutureTask@63553e9f[Not completed, task =
> java.util.concurrent.Executors$RunnableAdapter@52cb52bd[Wrapped task =
> org.apache.cassandra.service.ActiveRepairServiceTest$Task@1d1c37d5]] rejected
> from
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@218df7d6[Running,
> pool size = 2, active threads = 2, queued tasks = 0, completed tasks = 0]
> Stacktrace
> java.util.concurrent.RejectedExecutionException: Task
> java.util.concurrent.FutureTask@63553e9f[Not completed, task =
> java.util.concurrent.Executors$RunnableAdapter@52cb52bd[Wrapped task =
> org.apache.cassandra.service.ActiveRepairServiceTest$Task@1d1c37d5]] rejected
> from
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@218df7d6[Running,
> pool size = 2, active threads = 2, queued tasks = 0, completed tasks = 0]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2055)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:825)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1355)
> at
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor.execute(DebuggableThreadPoolExecutor.java:176)
> at
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:118)
> at
> org.apache.cassandra.service.ActiveRepairServiceTest.testRejectWhenPoolFullStrategy(ActiveRepairServiceTest.java:380)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:04:31,694 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:04:31,698 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:04:31,807 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:04:31,827 PlatformDependent0
> ...[truncated 95289 chars]...
> andra/build/test/cassandra/data/system/local-7ad54392bcdd35a684174e047860b377/nb_txn_flush_08e70270-b825-11eb-a393-871312b17b94.log
>
> DEBUG [MemtableFlushWriter:1] 2021-05-18 22:04:36,792
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system/local-7ad54392bcdd35a684174e047860b377/nb-15-big-Data.db')]
> (1 sstables, 4.944KiB), biggest 4.944KiB, smallest 4.944KiB
> DEBUG [main] 2021-05-18 22:04:36,795 StorageService.java:1619 - NORMAL
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15269) Cassandra fails to process OperationExecutionException which causes ClassCastException
[
https://issues.apache.org/jira/browse/CASSANDRA-15269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359867#comment-17359867
]
Berenguer Blasi commented on CASSANDRA-15269:
-
[~Override] do you mind I hijack this one from you?
> Cassandra fails to process OperationExecutionException which causes
> ClassCastException
> --
>
> Key: CASSANDRA-15269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15269
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Liudmila Kornilova
>Assignee: Liudmila Kornilova
>Priority: Normal
>
> While working on CASSANDRA-15232 I noticed that OperationExecutionException
> is not processed correctly.
> How to reproduce the issue:
> 1. {{create table d (numerator decimal primary key, denominator decimal);}}
> 2. {{insert into d (numerator, denominator) values
> (123456789112345678921234567893123456, 2);}}
> 3. {{select numerator % denominator from d;}}
> What happens:
> 1. remainder operation throws ArithmeticException (BigDecimal:1854)
> 2. The exception is wrapped in OperationExecutionException
> 3. ClassCastException appears (OperationExecutionException cannot be cast to
> FunctionExecutionException at ErrorMessage.java:280)
> What should happen:
> OperationExecutionException with message "the operation 'decimal % decimal'
> failed: Division impossible" should be delivered to user
> Note that after fixing CASSANDRA-15232 {{select numerator % denominator from
> d;}} will produce correct result of remainder operation.
> Currently I am not aware of other cases when OperationExecutionException may
> be treated as FunctionExecutionException
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16715) WEBSITE - June 2021 updates
[ https://issues.apache.org/jira/browse/CASSANDRA-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melissa Logan updated CASSANDRA-16715: -- Description: Sharing a batch of HTML updates to be made to the website that includes: * Added 2 blog posts * Added folder with 2 images to img/blog for Cassandra and Kubernetes SIG update * Added Hornet logo and Cassandra Kubernetes SIG image * Added new Case Study for Hornet * Added 40 items to Ecosystem page including Cassandra Cloud Offerings, Cassandra Tools, Cassandra Kubernetes Operators, and Developer Frameworks * Updated blog site * Updated Instagram logo * Updated Community Spotlights on the homepage was: Sharing a batch of HTML updates to be made to the website that include: * 2 new blog posts * Updated blog site * Added new folder to img/blog for Cassandra and Kubernetes SIG updates > WEBSITE - June 2021 updates > --- > > Key: CASSANDRA-16715 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16715 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Melissa Logan >Assignee: Erick Ramirez >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-rc2, 4.0 > > > Sharing a batch of HTML updates to be made to the website that includes: > * Added 2 blog posts > * Added folder with 2 images to img/blog for Cassandra and Kubernetes SIG > update > * Added Hornet logo and Cassandra Kubernetes SIG image > * Added new Case Study for Hornet > * Added 40 items to Ecosystem page including Cassandra Cloud Offerings, > Cassandra Tools, Cassandra Kubernetes Operators, and Developer Frameworks > * Updated blog site > * Updated Instagram logo > * Updated Community Spotlights on the homepage > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
[ https://issues.apache.org/jira/browse/CASSANDRA-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359815#comment-17359815 ] Berenguer Blasi commented on CASSANDRA-16711: - Ah thx I understand now apologies. Thx! > Split ViewComplexTest to avoid timeouts after being moved away from 'long' > junits > - > > Key: CASSANDRA-16711 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit > section to the std one. This required splitting them to avoid timing out but > ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
[ https://issues.apache.org/jira/browse/CASSANDRA-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16711: Since Version: 4.0 Source Control Link: https://github.com/apache/cassandra/commit/3e153c88547de4227f2758d15abeadc82a7138fe Resolution: Fixed Status: Resolved (was: Ready to Commit) > Split ViewComplexTest to avoid timeouts after being moved away from 'long' > junits > - > > Key: CASSANDRA-16711 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit > section to the std one. This required splitting them to avoid timing out but > ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 3e153c8 Split ViewComplexTest to avoid timeouts after being moved
away from 'long' junits
new 558d4ed Merge branch 'cassandra-4.0.0' into cassandra-4.0
3e153c8 is described below
commit 3e153c88547de4227f2758d15abeadc82a7138fe
Author: Bereng
AuthorDate: Fri Jun 4 06:53:47 2021 +0200
Split ViewComplexTest to avoid timeouts after being moved away from 'long'
junits
patch by Berenguer Blas; reviewed by Ekaterina Dimitrova for CASSANDRA-16711
---
.../cassandra/cql3/ViewComplexDeletionsTest.java | 3 +-
.../cassandra/cql3/ViewComplexLivenessTest.java| 258
.../apache/cassandra/cql3/ViewComplexTTLTest.java | 3 +-
.../org/apache/cassandra/cql3/ViewComplexTest.java | 180 +--
.../cassandra/cql3/ViewComplexUpdatesTest.java | 3 +-
...Test.java => ViewFilteringClustering1Test.java} | 245 +--
.../cql3/ViewFilteringClustering2Test.java | 329 +
.../apache/cassandra/cql3/ViewFilteringPKTest.java | 5 +-
.../apache/cassandra/cql3/ViewFilteringTest.java | 5 +-
test/unit/org/apache/cassandra/cql3/ViewTest.java | 1 +
.../InsertUpdateIfConditionCollectionsTest.java| 2 +-
.../InsertUpdateIfConditionStaticsTest.java| 2 +-
.../operations/InsertUpdateIfConditionTest.java| 2 +-
13 files changed, 609 insertions(+), 429 deletions(-)
diff --git a/test/unit/org/apache/cassandra/cql3/ViewComplexDeletionsTest.java
b/test/unit/org/apache/cassandra/cql3/ViewComplexDeletionsTest.java
index e6662f2..e130378 100644
--- a/test/unit/org/apache/cassandra/cql3/ViewComplexDeletionsTest.java
+++ b/test/unit/org/apache/cassandra/cql3/ViewComplexDeletionsTest.java
@@ -44,12 +44,13 @@ import static
org.apache.cassandra.cql3.ViewComplexTest.updateView;
import static org.apache.cassandra.cql3.ViewComplexTest.updateViewWithFlush;
import static org.junit.Assert.assertEquals;
-/* This class been split into multiple ones bc of timeout issues
CASSANDRA-16670
+/* ViewComplexTest class has been split into multiple ones because of timeout
issues (CASSANDRA-16670)
* Any changes here check if they apply to the other classes:
* - ViewComplexUpdatesTest
* - ViewComplexDeletionsTest
* - ViewComplexTTLTest
* - ViewComplexTest
+ * - ViewComplexLivenessTest
*/
@RunWith(Parameterized.class)
public class ViewComplexDeletionsTest extends CQLTester
diff --git a/test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
b/test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
new file mode 100644
index 000..6999bef
--- /dev/null
+++ b/test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.Keyspace;
+import org.apache.cassandra.transport.ProtocolVersion;
+import org.apache.cassandra.utils.FBUtilities;
+
+import static org.apache.cassandra.cql3.ViewComplexTest.createView;
+import static org.apache.cassandra.cql3.ViewComplexTest.updateView;
+import static org.apache.cassandra.cql3.ViewComplexTest.updateViewWithFlush;
+import static org.junit.Assert.assertEquals;
+
+/* ViewComplexTest class has been split into multiple ones because of timeout
issues (CASSANDRA-16670)
+ * Any changes here check if they apply to the other classes:
+ * - ViewComplexUpdatesTest
+ * - ViewComplexDeletionsTest
+ * - ViewComplexTTLTest
+ * - ViewComplexTest
+ * - ViewComplexLivenessTest
+ */
+@RunWith(Parameterized.class)
+public class ViewComplexLivenessTest extends CQLTester
+{
+
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. bereng pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a56bd764dcb3c3fbb87a9570b94aaa2518f32cfe Merge: 3b97e4b 558d4ed Author: Bereng AuthorDate: Wed Jun 9 08:48:05 2021 +0200 Merge branch 'cassandra-4.0' into trunk .../cassandra/cql3/ViewComplexDeletionsTest.java | 3 +- .../cassandra/cql3/ViewComplexLivenessTest.java| 258 .../apache/cassandra/cql3/ViewComplexTTLTest.java | 3 +- .../org/apache/cassandra/cql3/ViewComplexTest.java | 180 +-- .../cassandra/cql3/ViewComplexUpdatesTest.java | 3 +- ...Test.java => ViewFilteringClustering1Test.java} | 245 +-- .../cql3/ViewFilteringClustering2Test.java | 329 + .../apache/cassandra/cql3/ViewFilteringPKTest.java | 5 +- .../apache/cassandra/cql3/ViewFilteringTest.java | 5 +- test/unit/org/apache/cassandra/cql3/ViewTest.java | 1 + .../InsertUpdateIfConditionCollectionsTest.java| 2 +- .../InsertUpdateIfConditionStaticsTest.java| 2 +- .../operations/InsertUpdateIfConditionTest.java| 2 +- 13 files changed, 609 insertions(+), 429 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 updated (82bd456 -> 3e153c8)
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a change to branch cassandra-4.0.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git.
from 82bd456 Merge branch 'cassandra-3.11' into cassandra-4.0.0
new 3e153c8 Split ViewComplexTest to avoid timeouts after being moved
away from 'long' junits
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../cassandra/cql3/ViewComplexDeletionsTest.java | 3 +-
.../cassandra/cql3/ViewComplexLivenessTest.java| 258
.../apache/cassandra/cql3/ViewComplexTTLTest.java | 3 +-
.../org/apache/cassandra/cql3/ViewComplexTest.java | 180 +--
.../cassandra/cql3/ViewComplexUpdatesTest.java | 3 +-
...Test.java => ViewFilteringClustering1Test.java} | 245 +--
.../cql3/ViewFilteringClustering2Test.java | 329 +
.../apache/cassandra/cql3/ViewFilteringPKTest.java | 5 +-
.../apache/cassandra/cql3/ViewFilteringTest.java | 5 +-
test/unit/org/apache/cassandra/cql3/ViewTest.java | 1 +
.../InsertUpdateIfConditionCollectionsTest.java| 2 +-
.../InsertUpdateIfConditionStaticsTest.java| 2 +-
.../operations/InsertUpdateIfConditionTest.java| 2 +-
13 files changed, 609 insertions(+), 429 deletions(-)
create mode 100644
test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
rename test/unit/org/apache/cassandra/cql3/{ViewFilteringClusteringTest.java
=> ViewFilteringClustering1Test.java} (60%)
create mode 100644
test/unit/org/apache/cassandra/cql3/ViewFilteringClustering2Test.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (3b97e4b -> a56bd76)
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.
from 3b97e4b Merge branch 'cassandra-4.0' into trunk
new 3e153c8 Split ViewComplexTest to avoid timeouts after being moved
away from 'long' junits
new 558d4ed Merge branch 'cassandra-4.0.0' into cassandra-4.0
new a56bd76 Merge branch 'cassandra-4.0' into trunk
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../cassandra/cql3/ViewComplexDeletionsTest.java | 3 +-
.../cassandra/cql3/ViewComplexLivenessTest.java| 258
.../apache/cassandra/cql3/ViewComplexTTLTest.java | 3 +-
.../org/apache/cassandra/cql3/ViewComplexTest.java | 180 +--
.../cassandra/cql3/ViewComplexUpdatesTest.java | 3 +-
...Test.java => ViewFilteringClustering1Test.java} | 245 +--
.../cql3/ViewFilteringClustering2Test.java | 329 +
.../apache/cassandra/cql3/ViewFilteringPKTest.java | 5 +-
.../apache/cassandra/cql3/ViewFilteringTest.java | 5 +-
test/unit/org/apache/cassandra/cql3/ViewTest.java | 1 +
.../InsertUpdateIfConditionCollectionsTest.java| 2 +-
.../InsertUpdateIfConditionStaticsTest.java| 2 +-
.../operations/InsertUpdateIfConditionTest.java| 2 +-
13 files changed, 609 insertions(+), 429 deletions(-)
create mode 100644
test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java
rename test/unit/org/apache/cassandra/cql3/{ViewFilteringClusteringTest.java
=> ViewFilteringClustering1Test.java} (60%)
create mode 100644
test/unit/org/apache/cassandra/cql3/ViewFilteringClustering2Test.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
