[jira] [Commented] (CASSANDRA-16471) org.apache.cassandra.io.util.DataOutputBuffer#scratchBuffer is around 50% of all memory allocations
[ https://issues.apache.org/jira/browse/CASSANDRA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369195#comment-17369195 ] David Capwell commented on CASSANDRA-16471: --- It seems I forgot about this patch... I have some things on my plate and will be gone for ~1 month... so I can likely bring this back up in august > org.apache.cassandra.io.util.DataOutputBuffer#scratchBuffer is around 50% of > all memory allocations > --- > > Key: CASSANDRA-16471 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16471 > Project: Cassandra > Issue Type: Improvement > Components: Local/Caching >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > Attachments: Screen Shot 2021-02-25 at 3.34.28 PM.png, Screen Shot > 2021-02-25 at 4.14.19 PM.png > > > While running workflows to compare 3.0 with trunk we found that allocations > and GC are significantly higher for a write mostly workload (22% read, 3% > delete, 75% write); below is what we saw for a 2h run > Allocations > 30: 1.64TB > 40: 2.99TB > GC Events > 30: 7.39k events > 40: 13.93k events > When looking at the allocation output we saw the follow for memory allocations > !https://issues.apache.org/jira/secure/attachment/13021238/Screen%20Shot%202021-02-25%20at%203.34.28%20PM.png! > Here we see that org.apache.cassandra.io.util.DataOutputBuffer#expandToFit is > around 52% of the memory allocations. When looking at this logic I see that > allocations are on-heap and constantly throw away the buffer (as a means to > allow GC to clean up). > With the patch, allocations/gc are the following > Allocations > 30: 1.64TB > 40 w/ patch: 1.77TB > 40: 2.99TB > GC Events > 30: 7.39k events > 40 w/ patch: 8k events > 40: 13.93k events > With the patch only 0.8% allocations > !https://issues.apache.org/jira/secure/attachment/13021239/Screen%20Shot%202021-02-25%20at%204.14.19%20PM.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16471) org.apache.cassandra.io.util.DataOutputBuffer#scratchBuffer is around 50% of all memory allocations
[ https://issues.apache.org/jira/browse/CASSANDRA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16471: -- Fix Version/s: 4.1 4.0.1 > org.apache.cassandra.io.util.DataOutputBuffer#scratchBuffer is around 50% of > all memory allocations > --- > > Key: CASSANDRA-16471 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16471 > Project: Cassandra > Issue Type: Improvement > Components: Local/Caching >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > Attachments: Screen Shot 2021-02-25 at 3.34.28 PM.png, Screen Shot > 2021-02-25 at 4.14.19 PM.png > > > While running workflows to compare 3.0 with trunk we found that allocations > and GC are significantly higher for a write mostly workload (22% read, 3% > delete, 75% write); below is what we saw for a 2h run > Allocations > 30: 1.64TB > 40: 2.99TB > GC Events > 30: 7.39k events > 40: 13.93k events > When looking at the allocation output we saw the follow for memory allocations > !https://issues.apache.org/jira/secure/attachment/13021238/Screen%20Shot%202021-02-25%20at%203.34.28%20PM.png! > Here we see that org.apache.cassandra.io.util.DataOutputBuffer#expandToFit is > around 52% of the memory allocations. When looking at this logic I see that > allocations are on-heap and constantly throw away the buffer (as a means to > allow GC to clean up). > With the patch, allocations/gc are the following > Allocations > 30: 1.64TB > 40 w/ patch: 1.77TB > 40: 2.99TB > GC Events > 30: 7.39k events > 40 w/ patch: 8k events > 40: 13.93k events > With the patch only 0.8% allocations > !https://issues.apache.org/jira/secure/attachment/13021239/Screen%20Shot%202021-02-25%20at%204.14.19%20PM.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16759) Avoid memoizing the wrong min cluster version during upgrades
[ https://issues.apache.org/jira/browse/CASSANDRA-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369166#comment-17369166 ] Jon Meredith commented on CASSANDRA-16759: -- I've been investigating a few of the test failures and they seem to be related to the node not waiting to receive an up to date schema and starting bootstrap with the default schema which does not contain any non-system keyspaces so does not do any streaming. In 4.0, MigrationCoordinator is responsible for awaiting having all schema and it gets told about schema versions from the StorageService.onChange listener. It only processes the ApplicationState.SCHEMA entries if the endpoint exists in TokenMetadata. Endpoints are added to TokenMetadata when StorageService.onJoin handles the STATUS or STATUS_WITH_PORT application states. The EnumMap.values() that onJoin iterates over seems to return the application states in the order they are defined in the enum, so if STATUS is present, it comes first and all is good. If STATUS is not present, like when a 4.0 cluster thinks there are no nodes with a version lower than 4.0 and gossip filters it out, then only the items in ApplicationState after STATUS_WITH_PORT (currently only SSTABLE_VERSIONS) will be processed by onChange. Then it takes a subsequent gossip of that ApplicationState to apply theother states which is making tests racy. This is all very fiddly and I'm not 100% sure that's the exact sequence, but there is definitely a change in behavior for when nodes switch to not having STATUS any more. I've pushed up a minimal change to onJoin to make it behave [on a branch|https://github.com/jonmeredith/cassandra/pull/new/marcuse/16759-fix-status-with-port], with [CircleCI Here|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=marcuse%2F16759-fix-status-with-port] A possible cleaner alternative solution would be to sort with a customer key comparator, but wasn't sure about performance during gossip storms. > Avoid memoizing the wrong min cluster version during upgrades > - > > Key: CASSANDRA-16759 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16759 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Coordination >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-rc2 > > > CASSANDRA-16525 avoids trying to calculate the cluster min version if > gossiper is not enabled. > This makes us memoize the wrong version for up to a minute causing us to send > 4.0-messages to 3.0 nodes, for example in > [ColumnFilter|https://github.com/apache/cassandra/blob/05beda90a9206db165a3997a736ecb06f8dc695e/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L210] > This was discovered by python upgrade dtests, > [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/993/workflows/2afef6f0-1356-41f6-93dc-5385ac19dca1/jobs/5977/tests#failed-test-0] > after reverting CASSANDRA-15899 in CASSANDRA-16735 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16115) New Cassandra website design, content and layout to work with Antora
[ https://issues.apache.org/jira/browse/CASSANDRA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16115: --- Resolution: Done Status: Resolved (was: Open) > New Cassandra website design, content and layout to work with Antora > > > Key: CASSANDRA-16115 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16115 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Melissa Logan >Assignee: Melissa Logan >Priority: Normal > Fix For: 4.0.x > > Attachments: Screen Shot 2020-09-03 at 09.48.53.png > > > This task is related to CASSANDRA-16066 (Update and rework the > cassandra-website material to work with Antora). The goal is to update the > front-end of the C* website (design, IA and content) to work with Antora to > help modernize the website as discussed on the [mailing > list|https://www.mail-archive.com/dev@cassandra.apache.org/msg15537.html]. > *Design Concepts:* A minimum of two homepage design concepts will be created > and shared for input, which will help standardize a brand palette for C* and > a design language for the site. This may include custom iconography and > graphics. The chosen design language will be used to develop the remaining > templates. > *Template Design*: It's estimated that 7 template designs will be needed > including the creation of several new pages: > * Homepage template > * Toplevel template - e.g. Community. > * General template - Mostly textual with some images, e.g. Intro, Quickstart > * “Library” template - A library of assets (links, downloads, logos etc) > that are sortable by metadata, e.g Resources, or Kafka's Powered By page). > * Blog landing template > * Blog single template > * Docs template > *Website Content:* Along with new design will be a need for new or updated > content to fit the new page layouts. The intention is to use as much as > possible from existing content, and augment with new content where needed. > *Template Development:* This includes the frontend development, such as any > HTML markup to achieve designs. HTML would be crafted so as to preserve any > backend/API calls, such that content is pulled in as designed. The majority > of the frontend work would come in the form of crafting CSS to bring the > designs to life, plus any minor Javascript to add subtle delights to key > pages. > *Style Guide*: Once all is complete, a Style Guide be added to GitHub for > contributors. > The [cassandra-website|https://github.com/apache/cassandra-website] > repository would need to be modified. Specific changes to be determined. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16029) Create better Apache Cassandra 4.0 docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16029: --- Resolution: Done Status: Resolved (was: Open) > Create better Apache Cassandra 4.0 docs > --- > > Key: CASSANDRA-16029 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16029 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Lorina Poland >Assignee: Lorina Poland >Priority: Normal > Fix For: 4.0.x > > Attachments: CurrentDocs.png, NewImprovedDocs.png > > > The proof of concept to create new Documentation showed that a combination of > the static site generator (SSG) Antora + Asciidoc files would provide the > most flexibility in redesigning the Apache C* OSS pages. > Current proof of concept: [https://polandll.github.io/site/Cassandra/4.0/] > To update the docs, the tools to write needed an update, too, to provide a > better UX and modern look and feel. The old tools (reStructured Text, Sphinx) > will be replaced with the new tools ([AsciiDoc|http://asciidoc.org/], > [Antora|http://antora.org/]). > See the attachments for screenshots of the current docs and the POC docs. > The advantages of asciidoc+antora: > * Rich markdown language that is directly editable. > * Good organizational structure for docs files > * Flexible build/publishing capabilities, including content from multiple > repositories and branches > * Flexible web UI, built separately from the doc files and static site. > * JS extensions that enable additional functionality. > To complete the conversion, the following steps are required: > * Pandoc used for conversion of rSt files to adoc files > ** Followed by significant manual editing to fix the errors left over after > conversion > * Creation of new antora files (site.yml, antora.yml, CSS and layout) > ** Integration with plug-ins (lunr for search, tabs for additional codeblock > capabilities) > ** Finish the UI to match current Apache C* UI, or engage designer to do a > new design > *** Put the ASF pulldown in the main header banner, like Apache Spark does > ([https://spark.apache.org/downloads.html]) > * Modification of build scripts to work with Antora > ** Modification of python scripts that generation YAML and nodetool docs > *** Make sure that these scripts are run for each version > ** Modification of cassandra/doc Makefile > ** Dockerfile and docker-entrypoint.sh files to use Docker for documentation > build > * Modification of cassandra-website to work with Antora > ** Dockerfile and docker-entrypoint.sh files to use Docker for documentation > build > * Figure out how to handle older versions that are not converted to asciidoc > now > ** Put in TBD? Copy 4.0 branch with note to rewrite later? > * Figure out why tabs-block antora extension is working locally but not in > GH pages (may or may not be important) > Other tasks: > * Complete conversion, plus editing the current docs before Apache C* 4.0 GA > * Further improvements for docs organization > ** > [https://docs.google.com/document/d/1aeNtgyPAsKcNa0GSKvl2ywlFEj30714ry4Sb5turWeE/edit?usp=sharing] > ** Get some sections out of Docs, like Developing Code info -> Community > * Solve the issue of CQL highlighting/lexer/parser issue > ** Need CQL to be submitted to pygments > * Addition of more useful documentation - tutorials, how-to guides, separate > reference guide > Current work: > [https://github.com/polandll/cassandra/blob/doc_redo_asciidoc/|https://github.com/polandll/cassandra/blob/doc_redo_asciidoc/doc/Dockerfile] > Relevant Links: > Original source for antora-ui: [https://gitlab.com/antora/antora-ui-default] > (Mozilla public license 2.0) > Current working repo for antora-ui: > [https://github.com/ianjevans/antora-ui-datastax] in oss branch > Lunr search implemented with: [https://github.com/Mogztter/antora-lunr] and > [https://github.com/Mogztter/antora-site-generator-lunr] > (MIT license) > Codeblock tabs implemented with: Dan Allen's tabs-block.js code (finding > source). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16029) Create better Apache Cassandra 4.0 docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369104#comment-17369104 ] Anthony Grasso commented on CASSANDRA-16029: Proof of concept completed. Antora will be used for the new website. Documentation content will done under CASSANDRA-16763 Closing ticket. > Create better Apache Cassandra 4.0 docs > --- > > Key: CASSANDRA-16029 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16029 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Lorina Poland >Assignee: Lorina Poland >Priority: Normal > Fix For: 4.0.x > > Attachments: CurrentDocs.png, NewImprovedDocs.png > > > The proof of concept to create new Documentation showed that a combination of > the static site generator (SSG) Antora + Asciidoc files would provide the > most flexibility in redesigning the Apache C* OSS pages. > Current proof of concept: [https://polandll.github.io/site/Cassandra/4.0/] > To update the docs, the tools to write needed an update, too, to provide a > better UX and modern look and feel. The old tools (reStructured Text, Sphinx) > will be replaced with the new tools ([AsciiDoc|http://asciidoc.org/], > [Antora|http://antora.org/]). > See the attachments for screenshots of the current docs and the POC docs. > The advantages of asciidoc+antora: > * Rich markdown language that is directly editable. > * Good organizational structure for docs files > * Flexible build/publishing capabilities, including content from multiple > repositories and branches > * Flexible web UI, built separately from the doc files and static site. > * JS extensions that enable additional functionality. > To complete the conversion, the following steps are required: > * Pandoc used for conversion of rSt files to adoc files > ** Followed by significant manual editing to fix the errors left over after > conversion > * Creation of new antora files (site.yml, antora.yml, CSS and layout) > ** Integration with plug-ins (lunr for search, tabs for additional codeblock > capabilities) > ** Finish the UI to match current Apache C* UI, or engage designer to do a > new design > *** Put the ASF pulldown in the main header banner, like Apache Spark does > ([https://spark.apache.org/downloads.html]) > * Modification of build scripts to work with Antora > ** Modification of python scripts that generation YAML and nodetool docs > *** Make sure that these scripts are run for each version > ** Modification of cassandra/doc Makefile > ** Dockerfile and docker-entrypoint.sh files to use Docker for documentation > build > * Modification of cassandra-website to work with Antora > ** Dockerfile and docker-entrypoint.sh files to use Docker for documentation > build > * Figure out how to handle older versions that are not converted to asciidoc > now > ** Put in TBD? Copy 4.0 branch with note to rewrite later? > * Figure out why tabs-block antora extension is working locally but not in > GH pages (may or may not be important) > Other tasks: > * Complete conversion, plus editing the current docs before Apache C* 4.0 GA > * Further improvements for docs organization > ** > [https://docs.google.com/document/d/1aeNtgyPAsKcNa0GSKvl2ywlFEj30714ry4Sb5turWeE/edit?usp=sharing] > ** Get some sections out of Docs, like Developing Code info -> Community > * Solve the issue of CQL highlighting/lexer/parser issue > ** Need CQL to be submitted to pygments > * Addition of more useful documentation - tutorials, how-to guides, separate > reference guide > Current work: > [https://github.com/polandll/cassandra/blob/doc_redo_asciidoc/|https://github.com/polandll/cassandra/blob/doc_redo_asciidoc/doc/Dockerfile] > Relevant Links: > Original source for antora-ui: [https://gitlab.com/antora/antora-ui-default] > (Mozilla public license 2.0) > Current working repo for antora-ui: > [https://github.com/ianjevans/antora-ui-datastax] in oss branch > Lunr search implemented with: [https://github.com/Mogztter/antora-lunr] and > [https://github.com/Mogztter/antora-site-generator-lunr] > (MIT license) > Codeblock tabs implemented with: Dan Allen's tabs-block.js code (finding > source). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16763) Create Cassandra documentation content for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso reassigned CASSANDRA-16763: -- Assignee: Lorina Poland > Create Cassandra documentation content for new website > -- > > Key: CASSANDRA-16763 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16763 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Lorina Poland >Priority: Normal > > We need create the content (asciidoc) to render the Cassandra documentation > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > * Website UI components are done - CASSANDRA-16762 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16763) Create Cassandra documentation content for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16763: --- Change Category: Operability Complexity: Normal Priority: High (was: Normal) Status: Open (was: Triage Needed) > Create Cassandra documentation content for new website > -- > > Key: CASSANDRA-16763 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16763 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Lorina Poland >Priority: High > > We need create the content (asciidoc) to render the Cassandra documentation > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > * Website UI components are done - CASSANDRA-16762 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16762) Create content and UI components for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso reassigned CASSANDRA-16762: -- Assignee: Paul Au > Create content and UI components for new website > > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Paul Au >Priority: Normal > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16762) Create content and UI components for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16762: --- Change Category: Operability Complexity: Challenging Priority: High (was: Normal) Status: Open (was: Triage Needed) > Create content and UI components for new website > > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Paul Au >Priority: High > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14325) Java executable check succeeds despite no java on PATH
[ https://issues.apache.org/jira/browse/CASSANDRA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14325: - Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams) Brandon Williams, Brandon Williams Status: Review In Progress (was: Patch Available) Looks good to me, +1. > Java executable check succeeds despite no java on PATH > -- > > Key: CASSANDRA-14325 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14325 > Project: Cassandra > Issue Type: Bug > Components: Local/Startup and Shutdown >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Low > Fix For: 3.0.x, 3.11.x, 4.0.x > > Attachments: bin_cassandra.patch > > > The check -z $JAVA on line 102 of bin/cassandra currently always succeeds if > JAVA_HOME is not set since in this case JAVA gets set directly to 'java'. The > error message "_Unable to find java executable. Check JAVA_HOME and PATH > environment variables._" will never be echoed on a PATH misconfiguration. If > java isn't on the PATH the failure will instead occur on line 95 of > cassandra-env.sh at the java version check. > It would be better to check consistently for the java executable in one place > in bin/cassandra. Also we don't want users to mistakenly think they have a > java version problem when they in fact have a PATH problem. > See proposed patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14325) Java executable check succeeds despite no java on PATH
[ https://issues.apache.org/jira/browse/CASSANDRA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14325: - Fix Version/s: 4.0.x 3.11.x 3.0.x > Java executable check succeeds despite no java on PATH > -- > > Key: CASSANDRA-14325 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14325 > Project: Cassandra > Issue Type: Bug > Components: Local/Startup and Shutdown >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Low > Fix For: 3.0.x, 3.11.x, 4.0.x > > Attachments: bin_cassandra.patch > > > The check -z $JAVA on line 102 of bin/cassandra currently always succeeds if > JAVA_HOME is not set since in this case JAVA gets set directly to 'java'. The > error message "_Unable to find java executable. Check JAVA_HOME and PATH > environment variables._" will never be echoed on a PATH misconfiguration. If > java isn't on the PATH the failure will instead occur on line 95 of > cassandra-env.sh at the java version check. > It would be better to check consistently for the java executable in one place > in bin/cassandra. Also we don't want users to mistakenly think they have a > java version problem when they in fact have a PATH problem. > See proposed patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Ninja fix all occurences of non-existent self.fail to pytest.fail
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new bca1834 Ninja fix all occurences of non-existent self.fail to
pytest.fail
bca1834 is described below
commit bca1834dc7075ced5ebaeda15afcf691bcd30ab1
Author: Brandon Williams
AuthorDate: Thu Jun 24 16:44:08 2021 -0500
Ninja fix all occurences of non-existent self.fail to pytest.fail
---
auth_test.py | 8
cdc_test.py| 2 +-
cfid_test.py | 3 ++-
compaction_test.py | 2 +-
cqlsh_tests/test_cqlsh.py | 2 +-
materialized_views_test.py | 6 +++---
mixed_version_test.py | 6 +++---
native_transport_ssl_test.py | 4 ++--
nodetool_test.py | 2 +-
paging_test.py | 4 ++--
pushed_notifications_test.py | 4 ++--
secondary_indexes_test.py | 6 +++---
ttl_test.py| 2 +-
upgrade_tests/cql_tests.py | 2 +-
upgrade_tests/drop_compact_storage_upgrade_test.py | 2 +-
upgrade_tests/upgrade_through_versions_test.py | 2 +-
16 files changed, 29 insertions(+), 28 deletions(-)
diff --git a/auth_test.py b/auth_test.py
index 6d92ff5..df57fb0 100644
--- a/auth_test.py
+++ b/auth_test.py
@@ -845,7 +845,7 @@ class TestAuth(Tester):
def check_caching(attempt=0):
attempt += 1
if attempt > 3:
-self.fail("Unable to verify cache expiry in 3 attempts,
failing")
+pytest.fail("Unable to verify cache expiry in 3 attempts,
failing")
logger.debug("Attempting to verify cache expiry, attempt
#{i}".format(i=attempt))
# grant SELECT to cathy
@@ -866,7 +866,7 @@ class TestAuth(Tester):
check_caching(attempt)
else:
# legit failure
-self.fail("Expecting query to raise an exception, but
nothing was raised.")
+pytest.fail("Expecting query to raise an exception,
but nothing was raised.")
except Unauthorized as e:
assert re.search("User cathy has no SELECT permission on
or any of its parents", str(e))
@@ -2742,7 +2742,7 @@ class TestAuthUnavailable(Tester):
try:
self.patient_exclusive_cql_connection(node0, timeout=2,
user='cassandra', password='cassandra')
-self.fail("Expected login attempt to raise an exception.")
+pytest.fail("Expected login attempt to raise an exception.")
except NoHostAvailable as e:
# From driver
assert isinstance(list(e.errors.values())[0], AuthenticationFailed)
@@ -2781,7 +2781,7 @@ class TestAuthUnavailable(Tester):
try:
self.patient_exclusive_cql_connection(node0, timeout=2,
user='cassandra', password='cassandra')
-self.fail("Expected login attempt to raise an exception.")
+pytest.fail("Expected login attempt to raise an exception.")
except NoHostAvailable as e:
# From driver
assert isinstance(list(e.errors.values())[0], AuthenticationFailed)
diff --git a/cdc_test.py b/cdc_test.py
index 1dbe1fc..79166a9 100644
--- a/cdc_test.py
+++ b/cdc_test.py
@@ -530,7 +530,7 @@ class TestCDC(Tester):
print('Set Two:')
for idx_two in rd_two:
print(' {},{},{},{}'.format(idx_two.name, idx_two.completed,
idx_two.offset, idx_two.log_name))
-self.fail(msg)
+pytest.fail(msg)
def _init_new_loading_node(self, ks_name, create_stmt, use_thrift=False):
loading_node = Node(
diff --git a/cfid_test.py b/cfid_test.py
index 3ad53e8..ec0a6d6 100644
--- a/cfid_test.py
+++ b/cfid_test.py
@@ -1,5 +1,6 @@
import os
import logging
+import pytest
from dtest import Tester, create_ks, create_cf
@@ -31,7 +32,7 @@ class TestCFID(Tester):
try:
cfs = os.listdir(node1.get_path() + "/data0/ks")
except OSError:
-self.fail("Path to sstables not valid.")
+pytest.fail("Path to sstables not valid.")
# check that there are 5 unique directories
assert len(cfs) == 5
diff --git a/compaction_test.py b/compaction_test.py
index d84b5dc..55fa016 100644
--- a/compaction_test.py
+++ b/compaction_test.py
@@ -189,7 +189,7 @@ class TestCompaction(Tester):
assert not "Data" in afile, afile
except OSError:
-self.fail("Path to sstables not valid.")
+pytest.fail("Path t
[jira] [Updated] (CASSANDRA-14155) [TRUNK] Gossiper somewhat frequently hitting an NPE on node startup with dtests at org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
[
https://issues.apache.org/jira/browse/CASSANDRA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14155:
-
Resolution: Duplicate
Status: Resolved (was: Open)
Closing since we resolved this in CASSANDRA-16588
> [TRUNK] Gossiper somewhat frequently hitting an NPE on node startup with
> dtests at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
>
>
> Key: CASSANDRA-14155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14155
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown, Test/dtest/python
>Reporter: Michael Kjellman
>Assignee: Jason Brown
>Priority: Normal
> Labels: dtest
>
> Gossiper is somewhat frequently hitting an NPE on node startup with dtests at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> {code}
> test teardown failure
> Unexpected error found in node logs (see stdout for full details). Errors:
> [ERROR [main] 2018-01-08 21:41:01,832 CassandraDaemon.java:675 - Exception
> encountered during startup
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:511)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:761)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:621)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:568)
> ~[main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:360)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:658)
> [main/:na], ERROR [main] 2018-01-08 21:41:01,832 CassandraDaemon.java:675 -
> Exception encountered during startup
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:511)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:761)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:621)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:568)
> ~[main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:360)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:658)
> [main/:na]]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14155) [TRUNK] Gossiper somewhat frequently hitting an NPE on node startup with dtests at org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
[
https://issues.apache.org/jira/browse/CASSANDRA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14155:
-
Status: Open (was: Patch Available)
> [TRUNK] Gossiper somewhat frequently hitting an NPE on node startup with
> dtests at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
>
>
> Key: CASSANDRA-14155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14155
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown, Test/dtest/python
>Reporter: Michael Kjellman
>Assignee: Jason Brown
>Priority: Normal
> Labels: dtest
>
> Gossiper is somewhat frequently hitting an NPE on node startup with dtests at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> {code}
> test teardown failure
> Unexpected error found in node logs (see stdout for full details). Errors:
> [ERROR [main] 2018-01-08 21:41:01,832 CassandraDaemon.java:675 - Exception
> encountered during startup
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:511)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:761)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:621)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:568)
> ~[main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:360)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:658)
> [main/:na], ERROR [main] 2018-01-08 21:41:01,832 CassandraDaemon.java:675 -
> Exception encountered during startup
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:511)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:761)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:621)
> ~[main/:na]
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:568)
> ~[main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:360)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
> [main/:na]
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:658)
> [main/:na]]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16066) Create tooling and update repository layout to render new website
[
https://issues.apache.org/jira/browse/CASSANDRA-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Grasso updated CASSANDRA-16066:
---
Summary: Create tooling and update repository layout to render new website
(was: Update and rework cassandra-website material to work with Antora)
> Create tooling and update repository layout to render new website
> -
>
> Key: CASSANDRA-16066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16066
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Website
>Reporter: Anthony Grasso
>Assignee: Anthony Grasso
>Priority: Normal
> Attachments: image-2020-09-05-13-24-13-606.png,
> image-2020-09-06-07-17-14-705.png
>
>
> *We want to modernise the way the website is built*
> Rework the cassandra-website repository to generate a UI bundle containing
> resources that Antora will use when generating the Cassandra documents and
> website.
> *The existing method is starting to become dated*
> The documentation and website templates are currently in markdown format.
> Sphinx is used to generate the Cassandra documentation and Jekyll generates
> the website content. One of the major issues with the existing website
> tooling is that the live preview server (render site as it is being updated)
> is really slow. There is a preview server that is really fast, however it is
> unable to detect changes to the content and render automatically.
> *We are migrating the docs to be rendered with Antora*
> The work in CASSANDRA-16029 is converting the document templates to AsciiDoc
> format. Sphinx is being replaced by Antora to generate the documentation
> content. This change has two advantages:
> * More flexibility if the Apache Cassandra documentation look and feel needs
> to be updated or redesigned.
> * More modern look and feel to the documentation.
> *We can use Antora to generate the website as well*
> Antora could also be used to generate the Cassandra website content. As
> suggested on the [mailing
> list|https://www.mail-archive.com/dev@cassandra.apache.org/msg15577.html]
> this would require the existing markdown templates to be converted to
> AsciiDoc as well.
> *Antora needs a UI bundle to style content*
> For Antora to generate the document content and potentially the website
> content it requires a UI bundle (ui-bundle.zip). The UI bundle contains the
> HTML templates (layouts, partials, and helpers), CSS, JavaScript, fonts, and
> (site-wide) images. As such, it provides both the visual theme and user
> interactions for the documentation. Effectively the UI bundle is the
> templates and styling that are applied to the documentation and website
> content.
> *The [cassandra-website|https://github.com/apache/cassandra-website]
> repository can be used to generate the UI bundle*
> All the resources associated with templating and styling the documentation
> and website can be placed in the
> [cassandra-website|https://github.com/apache/cassandra-website] repository.
> In this case the repository would serve two purposes;
> * Generation of the UI bundle resources.
> * Serve the production website content.
> *The [cassandra|https://github.com/apache/cassandra] repository would contain
> the documentation material, while the rest of the non-versioned pages would
> contain that material*
> * All other material that is used to generate documentation would live in
> the [cassandra|https://github.com/apache/cassandra] repository. In this case
> Antora would run on the
> [cassandra/doc|https://github.com/apache/cassandra/doc] directory and pull in
> a UI bundle released on the GitHub
> [cassandra-website|https://github.com/apache/cassandra-website] repository.
> The content generated by Antora using the site.yml file located in this repo
> can be used to preview the docs for review.
> * All other non-versioned material, such as the blogs, development
> instructions, and third-party page would live in the GitHub
> [cassandra-website|https://github.com/apache/cassandra-website] repository.
> Antora will generate the full website using the site.yml located in this
> repo, using both as content sources the material located in both the
> [cassandra|https://github.com/apache/cassandra] and
> [cassandra-website|https://github.com/apache/cassandra-website] repositories.
> *Design, content, and layout would remain the same*
> This proposal means the roles of each repository will change. In addition,
> the workflow to publish material will change as well. However, the website
> design, content, and layout will remain the same.
> As an added bonus the tooling would allow for a live preview server that is
> fast and responsive. However, the time to build and generate the {{nodeto
[jira] [Updated] (CASSANDRA-16763) Create Cassandra documentation content for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16763: --- Description: We need create the content (asciidoc) to render the Cassandra documentation using Antora. This work can commence once the following has happened: * Website and documentation proof of concept is done - CASSANDRA-16029 * Website design and concept is done - CASSANDRA-16115 * Website and document tooling is done - CASSANDRA-16066 * Website UI components are done - CASSANDRA-16762 was: We need create the asciidoc content to render the Cassandra documentation using Antora. This work can commence once the following has happened: * Website and documentation proof of concept is done - CASSANDRA-16029 * Website design and concept is done - CASSANDRA-16115 * Website and document tooling is done - CASSANDRA-16066 * Website UI components are done - CASSANDRA-16762 > Create Cassandra documentation content for new website > -- > > Key: CASSANDRA-16763 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16763 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Priority: Normal > > We need create the content (asciidoc) to render the Cassandra documentation > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > * Website UI components are done - CASSANDRA-16762 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16762) Create content and UI components for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16762: --- Summary: Create content and UI components for new website (was: Create asciidoc content for new website) > Create content and UI components for new website > > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Priority: Normal > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16763) Create Cassandra documentation content for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16763: --- Summary: Create Cassandra documentation content for new website (was: Create asciidoc content for documentation) > Create Cassandra documentation content for new website > -- > > Key: CASSANDRA-16763 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16763 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Priority: Normal > > We need create the asciidoc content to render the Cassandra documentation > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > * Website UI components are done - CASSANDRA-16762 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16762) Create asciidoc content for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso updated CASSANDRA-16762: --- Description: We need create the content (asciidoc) and UI components to render the website using Antora. This work can commence once the following has happened: * Website and documentation proof of concept is done - CASSANDRA-16029 * Website design and concept is done - CASSANDRA-16115 * Website and document tooling is done - CASSANDRA-16066 was: We need create the asciidoc content to render the website using Antora. This work can commence once the following has happened: * Website and documentation proof of concept is done - CASSANDRA-16029 * Website design and concept is done - CASSANDRA-16115 * Website and document tooling is done CASSANDRA-16066 > Create asciidoc content for new website > --- > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Priority: Normal > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16763) Create asciidoc content for documentation
Anthony Grasso created CASSANDRA-16763: -- Summary: Create asciidoc content for documentation Key: CASSANDRA-16763 URL: https://issues.apache.org/jira/browse/CASSANDRA-16763 Project: Cassandra Issue Type: Task Components: Documentation/Website Reporter: Anthony Grasso We need create the asciidoc content to render the Cassandra documentation using Antora. This work can commence once the following has happened: * Website and documentation proof of concept is done - CASSANDRA-16029 * Website design and concept is done - CASSANDRA-16115 * Website and document tooling is done - CASSANDRA-16066 * Website UI components are done - CASSANDRA-16762 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16762) Create asciidoc content for new website
Anthony Grasso created CASSANDRA-16762: -- Summary: Create asciidoc content for new website Key: CASSANDRA-16762 URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 Project: Cassandra Issue Type: Task Components: Documentation/Website Reporter: Anthony Grasso We need create the asciidoc content to render the website using Antora. This work can commence once the following has happened: * Website and documentation proof of concept is done - CASSANDRA-16029 * Website design and concept is done - CASSANDRA-16115 * Website and document tooling is done CASSANDRA-16066 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16761) New Cassandra Website and Documentation
Anthony Grasso created CASSANDRA-16761: -- Summary: New Cassandra Website and Documentation Key: CASSANDRA-16761 URL: https://issues.apache.org/jira/browse/CASSANDRA-16761 Project: Cassandra Issue Type: Epic Components: Documentation/Website Reporter: Anthony Grasso Assignee: Anthony Grasso This epic captures the work associated with the development of the new Cassandra website and documentation. Work to create the new website and documentation will be broken up as follows: * Proof of concept - CASSANDRA-16029 * Website concept and design - CASSANDRA-16115 * Develop tooling to render new website and documentation - CASSANDRA-16066 * Create website content that will be rendered by new tooling * Create Cassandra documentation content that will be rendered by new tooling It is expected that the new website and documentation will be in asciidoc format and rendered using Antora. Antora is purpose built for rendering versioned documentation to HTML. In addition it allows rendering customisations via Java Script which may be useful when rending the website. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14608) Confirm correctness of windows scripts post-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14608: - Status: Open (was: Patch Available) > Confirm correctness of windows scripts post-9608 > > > Key: CASSANDRA-14608 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14608 > Project: Cassandra > Issue Type: Task > Environment: Windows >Reporter: Jason Brown >Priority: Urgent > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > In CASSANDRA-9608, we chose to defer making all the changes to Windows > scripts. This ticket is to ensure that we do that work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14608) Confirm correctness of windows scripts post-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14608: - Resolution: Won't Fix Status: Resolved (was: Open) Closing this since we decided not to support windows in 4.0 and later. > Confirm correctness of windows scripts post-9608 > > > Key: CASSANDRA-14608 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14608 > Project: Cassandra > Issue Type: Task > Environment: Windows >Reporter: Jason Brown >Priority: Urgent > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > In CASSANDRA-9608, we chose to defer making all the changes to Windows > scripts. This ticket is to ensure that we do that work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16677) Fix flaky ConnectionTest.testMessageDeliveryOnReconnect
[ https://issues.apache.org/jira/browse/CASSANDRA-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369066#comment-17369066 ] Ekaterina Dimitrova commented on CASSANDRA-16677: - I didn't manage to find anything more interesting and I am not able even to reproduce all errors you mentioned. I will be off big part of the next 10 days so I unassigned it in case someone wants to give it a try in the meanwhile. > Fix flaky ConnectionTest.testMessageDeliveryOnReconnect > --- > > Key: CASSANDRA-16677 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16677 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0 > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessageDeliveryOnReconnect_compression/ > https://app.circleci.com/pipelines/github/adelapena/cassandra/460/workflows/cf7dcec6-612c-45d1-8471-623bde481dca/jobs/4069 > https://app.circleci.com/pipelines/github/adelapena/cassandra/460/workflows/b750cd38-0263-4b5e-9bb8-a8be98214378/jobs/4065 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16677) Fix flaky ConnectionTest.testMessageDeliveryOnReconnect
[ https://issues.apache.org/jira/browse/CASSANDRA-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-16677: --- Assignee: (was: Ekaterina Dimitrova) > Fix flaky ConnectionTest.testMessageDeliveryOnReconnect > --- > > Key: CASSANDRA-16677 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16677 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0 > > > https://ci-cassandra.apache.org/job/Cassandra-devbranch/785/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessageDeliveryOnReconnect_compression/ > https://app.circleci.com/pipelines/github/adelapena/cassandra/460/workflows/cf7dcec6-612c-45d1-8471-623bde481dca/jobs/4069 > https://app.circleci.com/pipelines/github/adelapena/cassandra/460/workflows/b750cd38-0263-4b5e-9bb8-a8be98214378/jobs/4065 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14811) RPC_READY flag handled inconsistently
[
https://issues.apache.org/jira/browse/CASSANDRA-14811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369017#comment-17369017
]
Brandon Williams commented on CASSANDRA-14811:
--
This looks good. Would you be willing to also add tests to cover these
scenarios to prevent future regressions?
> RPC_READY flag handled inconsistently
> -
>
> Key: CASSANDRA-14811
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14811
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tibor Repasi
>Assignee: Rens Groothuijsen
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With version 3.0.17 we experience an inconsistent handling of the RPC_READY
> flag. We identified 3 scenarios with an unexpected behaviour.
> # Using {{nodetool disablebinary}} on a node in normal operation
> ** Observed behaviour:
> *** (/) the CQL listener is closed and Netty shut down
> *** (x) gossipinfo still contain the {{RPC_READY}} *true* advertisement.
> ** Expected behaviour: gossip announcement of the {{RPC_READY}} flag should
> switch to *false.* This is what we observe with version 2.2.13
> # Starting up a node with JVM option
> {{-Dcassandra.start_native_transport=false}}
> ** Observed behaviour:
> *** (/) Netty is not started to listen for CQL clients
> *** (/) logging {{cassandra[1765]: INFO 13:58:46 Not starting native
> transport as requested. Use JMX (StorageService->startNativeTransport()) or
> nodetool (enablebinary) to start it}}
> *** (?) the gossipinfo does not contain the {{RPC_READY}} flag at all,
> however, this is also observed on 2.2.13.
> # Issuing {{nodetool enablebinary}} command on a node started with
> {{-Dcassandra.start_native_transport=false}}
> ** Observed behaviour:
> *** (/) Netty is started up and open the CQL port for listening
> *** (x) the {{RPC_READY}} flag is not announced for this node any more,
> causing clients to not consider this node up and not trying to connect.
> ** Expected behaviour: gossip flag {{RPC_READY}} should be added to announce
> *true*, as observed with version 2.2.13.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14811) RPC_READY flag handled inconsistently
[
https://issues.apache.org/jira/browse/CASSANDRA-14811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14811:
-
Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams)
Brandon Williams, Brandon Williams
Status: Review In Progress (was: Patch Available)
> RPC_READY flag handled inconsistently
> -
>
> Key: CASSANDRA-14811
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14811
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tibor Repasi
>Assignee: Rens Groothuijsen
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With version 3.0.17 we experience an inconsistent handling of the RPC_READY
> flag. We identified 3 scenarios with an unexpected behaviour.
> # Using {{nodetool disablebinary}} on a node in normal operation
> ** Observed behaviour:
> *** (/) the CQL listener is closed and Netty shut down
> *** (x) gossipinfo still contain the {{RPC_READY}} *true* advertisement.
> ** Expected behaviour: gossip announcement of the {{RPC_READY}} flag should
> switch to *false.* This is what we observe with version 2.2.13
> # Starting up a node with JVM option
> {{-Dcassandra.start_native_transport=false}}
> ** Observed behaviour:
> *** (/) Netty is not started to listen for CQL clients
> *** (/) logging {{cassandra[1765]: INFO 13:58:46 Not starting native
> transport as requested. Use JMX (StorageService->startNativeTransport()) or
> nodetool (enablebinary) to start it}}
> *** (?) the gossipinfo does not contain the {{RPC_READY}} flag at all,
> however, this is also observed on 2.2.13.
> # Issuing {{nodetool enablebinary}} command on a node started with
> {{-Dcassandra.start_native_transport=false}}
> ** Observed behaviour:
> *** (/) Netty is started up and open the CQL port for listening
> *** (x) the {{RPC_READY}} flag is not announced for this node any more,
> causing clients to not consider this node up and not trying to connect.
> ** Expected behaviour: gossip flag {{RPC_READY}} should be added to announce
> *true*, as observed with version 2.2.13.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14811) RPC_READY flag handled inconsistently
[
https://issues.apache.org/jira/browse/CASSANDRA-14811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14811:
-
Status: Changes Suggested (was: Review In Progress)
> RPC_READY flag handled inconsistently
> -
>
> Key: CASSANDRA-14811
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14811
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tibor Repasi
>Assignee: Rens Groothuijsen
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With version 3.0.17 we experience an inconsistent handling of the RPC_READY
> flag. We identified 3 scenarios with an unexpected behaviour.
> # Using {{nodetool disablebinary}} on a node in normal operation
> ** Observed behaviour:
> *** (/) the CQL listener is closed and Netty shut down
> *** (x) gossipinfo still contain the {{RPC_READY}} *true* advertisement.
> ** Expected behaviour: gossip announcement of the {{RPC_READY}} flag should
> switch to *false.* This is what we observe with version 2.2.13
> # Starting up a node with JVM option
> {{-Dcassandra.start_native_transport=false}}
> ** Observed behaviour:
> *** (/) Netty is not started to listen for CQL clients
> *** (/) logging {{cassandra[1765]: INFO 13:58:46 Not starting native
> transport as requested. Use JMX (StorageService->startNativeTransport()) or
> nodetool (enablebinary) to start it}}
> *** (?) the gossipinfo does not contain the {{RPC_READY}} flag at all,
> however, this is also observed on 2.2.13.
> # Issuing {{nodetool enablebinary}} command on a node started with
> {{-Dcassandra.start_native_transport=false}}
> ** Observed behaviour:
> *** (/) Netty is started up and open the CQL port for listening
> *** (x) the {{RPC_READY}} flag is not announced for this node any more,
> causing clients to not consider this node up and not trying to connect.
> ** Expected behaviour: gossip flag {{RPC_READY}} should be added to announce
> *true*, as observed with version 2.2.13.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14975) cqlsh dtests are not running in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14975: - Fix Version/s: (was: 3.11.x) (was: 4.x) (was: 3.0.x) > cqlsh dtests are not running in CircleCI > > > Key: CASSANDRA-14975 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14975 > Project: Cassandra > Issue Type: Improvement > Components: CI, Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Labels: CI > > Right now the dtests skip these tests because most don't pass. Originally > they weren't being collected because the test files end in_tests.py instead > of _test.py, but I fixed that by adding _tests.py to the list of recognized > patterns. > Get them all running in CircleCI. Nothing special they will be part of the > existing dtest jobs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14975) cqlsh dtests are not running in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14975: - Resolution: Fixed Status: Resolved (was: Open) Closing as duplicate of the ticket Berenguer mentioned, cricle definitely runs the dtests now either from that or multiple others since. > cqlsh dtests are not running in CircleCI > > > Key: CASSANDRA-14975 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14975 > Project: Cassandra > Issue Type: Improvement > Components: CI, Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Labels: CI > Fix For: 3.0.x, 3.11.x, 4.x > > > Right now the dtests skip these tests because most don't pass. Originally > they weren't being collected because the test files end in_tests.py instead > of _test.py, but I fixed that by adding _tests.py to the list of recognized > patterns. > Get them all running in CircleCI. Nothing special they will be part of the > existing dtest jobs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14975) cqlsh dtests are not running in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14975: - Status: Open (was: Patch Available) > cqlsh dtests are not running in CircleCI > > > Key: CASSANDRA-14975 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14975 > Project: Cassandra > Issue Type: Improvement > Components: CI, Test/dtest/python >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > Labels: CI > Fix For: 3.0.x, 3.11.x, 4.x > > > Right now the dtests skip these tests because most don't pass. Originally > they weren't being collected because the test files end in_tests.py instead > of _test.py, but I fixed that by adding _tests.py to the list of recognized > patterns. > Get them all running in CircleCI. Nothing special they will be part of the > existing dtest jobs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16278) Bootstrapping nodes can become unreplaceable
[ https://issues.apache.org/jira/browse/CASSANDRA-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16278: - Resolution: Not A Problem Status: Resolved (was: Open) Based on the comments, I'm resolving this. > Bootstrapping nodes can become unreplaceable > > > Key: CASSANDRA-16278 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16278 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Bootstrapping nodes (including replacements) don't gossip their tokens until > after they've received their schema. If the node experiences a failure before > gossiping tokens, it causes the same problem CASSNDRA-15335 fixed for normal > nodes - they cannot be replaced without gossiped tokens. Including tokens in > the initial gossip round prevents nodes from getting into this state, > although we still have to wait for the schema when the node is configured to > allocate tokens for a keyspace. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16278) Bootstrapping nodes can become unreplaceable
[ https://issues.apache.org/jira/browse/CASSANDRA-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16278: - Status: Open (was: Patch Available) > Bootstrapping nodes can become unreplaceable > > > Key: CASSANDRA-16278 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16278 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Bootstrapping nodes (including replacements) don't gossip their tokens until > after they've received their schema. If the node experiences a failure before > gossiping tokens, it causes the same problem CASSNDRA-15335 fixed for normal > nodes - they cannot be replaced without gossiped tokens. Including tokens in > the initial gossip round prevents nodes from getting into this state, > although we still have to wait for the schema when the node is configured to > allocate tokens for a keyspace. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16535) Fail to init Cassandra Startup with an API connected with other cluster machines (3.11.9 version)
[ https://issues.apache.org/jira/browse/CASSANDRA-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368928#comment-17368928 ] Brandon Williams commented on CASSANDRA-16535: -- Are you still intending to review, [~yukim]? > Fail to init Cassandra Startup with an API connected with other cluster > machines (3.11.9 version) > - > > Key: CASSANDRA-16535 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16535 > Project: Cassandra > Issue Type: Bug > Components: Local/Startup and Shutdown >Reporter: Aramis >Assignee: Aramis >Priority: Normal > Fix For: 3.11.11 > > Attachments: cassandra_modified.ps1, > image-2021-03-24-21-12-32-709.png, image-2021-03-24-21-13-46-704.png > > > The code in the function "VerifyPortsAreAvailable", look for the ports: 7000, > 9042, 7199 and 9160 in the "netstat -an" command output. > > If we have an API connected to the cluster in a node, and we try to start the > execution of cassandra (with that API working, accesing ports 9042 of the > other cluster machines), the output of that command return us that the port > is already in use, and Cassandra´s startup process fails, showing the output > message : "port already in use" in the .log file. > Thus, if we change the code of the function, adding the line: " -and $line > -match "LISTENING" ", just next to the "$line -match "TCP" ", we will only > interrupt the execution if the load port is in the state: "LISTENING", but no > if it´s an active connection on the other node of the cluster. > !image-2021-03-24-21-12-32-709.png|width=470,height=159! > !image-2021-03-24-21-13-46-704.png|width=526,height=119! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16759) Avoid memoizing the wrong min cluster version during upgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368804#comment-17368804
]
Marcus Eriksson edited comment on CASSANDRA-16759 at 6/24/21, 3:25 PM:
---
by clearing out the memoized minVersion in {{start()}} we might call
{{upgradeFromVersionSupplier}} before we know anything about the cluster
pushed a new patch which makes sure we don't memoize anything before we
actually have {{endpointStateMap}} populated with something usable, tests
running (edit: still broken)
was (Author: krummas):
by clearing out the memoized minVersion in {{start()}} we might call
{{upgradeFromVersionSupplier}} before we know anything about the cluster
pushed a new patch which makes sure we don't memoize anything before we
actually have {{endpointStateMap}} populated with something usable, tests
running
> Avoid memoizing the wrong min cluster version during upgrades
> -
>
> Key: CASSANDRA-16759
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16759
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-rc2
>
>
> CASSANDRA-16525 avoids trying to calculate the cluster min version if
> gossiper is not enabled.
> This makes us memoize the wrong version for up to a minute causing us to send
> 4.0-messages to 3.0 nodes, for example in
> [ColumnFilter|https://github.com/apache/cassandra/blob/05beda90a9206db165a3997a736ecb06f8dc695e/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L210]
> This was discovered by python upgrade dtests,
> [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/993/workflows/2afef6f0-1356-41f6-93dc-5385ac19dca1/jobs/5977/tests#failed-test-0]
> after reverting CASSANDRA-15899 in CASSANDRA-16735
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15663) DESCRIBE KEYSPACE does not properly quote table names
[
https://issues.apache.org/jira/browse/CASSANDRA-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-15663:
-
Status: Patch Available (was: Review In Progress)
> DESCRIBE KEYSPACE does not properly quote table names
> -
>
> Key: CASSANDRA-15663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15663
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Syntax
>Reporter: Oskar Liljeblad
>Assignee: Aleksandr Sorokoumov
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.11.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> How to reproduce (3.11.6) - cqlsh:
> {code}
> CREATE KEYSPACE test1 WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': '1'} AND durable_writes = true;
> CREATE TABLE test1."default" (id text PRIMARY KEY, data text, etag text);
> DESCRIBE KEYSPACE test1;
> {code}
> Output will be:
> {code}
> CREATE TABLE test1.default (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> Output should be:
> {code}
> CREATE TABLE test1."default" (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> If you try to run {{CREATE TABLE test1.default [..]}} you will get an error
> SyntaxException: line 1:19 no viable alternative at input 'default' (CREATE
> TABLE test1.[default]...)
> Oskar Liljeblad
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15663) DESCRIBE KEYSPACE does not properly quote table names
[
https://issues.apache.org/jira/browse/CASSANDRA-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368913#comment-17368913
]
Aleksandr Sorokoumov edited comment on CASSANDRA-15663 at 6/24/21, 3:05 PM:
Python driver 3.25.0 with fixed
[PYTHON-1269|https://datastax-oss.atlassian.net/browse/PYTHON-1269] was
released a while ago. Unfortunately, with the new driver version Cassandra
server logs the following errors in dtests:
{noformat}
Protocol exception with client networking:
org.apache.cassandra.transport.ProtocolException: Beta version of the protocol
used (5/v5-beta), but USE_BETA flag is unset
{noformat}
AFAIU this happens because 3.11 classifies V5 as beta while 3.25.0 considers it
stable.
I don't think it is a good idea to introduce protocol-level warnings in the
trivial bug fix, therefore I cherry-picked
[PYTHON-1269|https://datastax-oss.atlassian.net/browse/PYTHON-1269] into
3.24.0. Patches:
* PR to update python driver in Cassandra 3.11 -
https://github.com/apache/cassandra/pull/654
* PR to fix {{test_describe_functions}} broken by the driver upgrade -
https://github.com/apache/cassandra-dtest/pull/148
[~adelapena] Can you please review?
was (Author: ge):
Python driver 3.25.0 with fixed
[PYTHON-1269|https://datastax-oss.atlassian.net/browse/PYTHON-1269] was
released a while ago. Unfortunately, with the new driver version Cassandra
server logs the following errors in dtests:
{noformat}
Protocol exception with client networking:
org.apache.cassandra.transport.ProtocolException: Beta version of the protocol
used (5/v5-beta), but USE_BETA flag is unset
{noformat}
AFAIU this happens because 3.11 classifies V5 as beta while 3.25.0 considers it
stable.
I don't think it is a good idea to introduce protocol-level warnings in the
trivial bug fix, therefore I cherry-picked
[PYTHON-1269|https://datastax-oss.atlassian.net/browse/PYTHON-1269] into 3.24.0.
[~adelapena] Can you please review?
> DESCRIBE KEYSPACE does not properly quote table names
> -
>
> Key: CASSANDRA-15663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15663
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Syntax
>Reporter: Oskar Liljeblad
>Assignee: Aleksandr Sorokoumov
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.11.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> How to reproduce (3.11.6) - cqlsh:
> {code}
> CREATE KEYSPACE test1 WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': '1'} AND durable_writes = true;
> CREATE TABLE test1."default" (id text PRIMARY KEY, data text, etag text);
> DESCRIBE KEYSPACE test1;
> {code}
> Output will be:
> {code}
> CREATE TABLE test1.default (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> Output should be:
> {code}
> CREATE TABLE test1."default" (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> If you try to run {{CREATE TABLE test1.default [..]}} you will get an error
> SyntaxException: line 1:19 no viable alternative at input 'default' (CREATE
> TABLE test1.[default]...)
> Oskar Liljeblad
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15663) DESCRIBE KEYSPACE does not properly quote table names
[
https://issues.apache.org/jira/browse/CASSANDRA-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Sorokoumov updated CASSANDRA-15663:
-
Status: Review In Progress (was: Changes Suggested)
> DESCRIBE KEYSPACE does not properly quote table names
> -
>
> Key: CASSANDRA-15663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15663
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Syntax
>Reporter: Oskar Liljeblad
>Assignee: Aleksandr Sorokoumov
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.11.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> How to reproduce (3.11.6) - cqlsh:
> {code}
> CREATE KEYSPACE test1 WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': '1'} AND durable_writes = true;
> CREATE TABLE test1."default" (id text PRIMARY KEY, data text, etag text);
> DESCRIBE KEYSPACE test1;
> {code}
> Output will be:
> {code}
> CREATE TABLE test1.default (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> Output should be:
> {code}
> CREATE TABLE test1."default" (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> If you try to run {{CREATE TABLE test1.default [..]}} you will get an error
> SyntaxException: line 1:19 no viable alternative at input 'default' (CREATE
> TABLE test1.[default]...)
> Oskar Liljeblad
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15663) DESCRIBE KEYSPACE does not properly quote table names
[
https://issues.apache.org/jira/browse/CASSANDRA-15663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368913#comment-17368913
]
Aleksandr Sorokoumov commented on CASSANDRA-15663:
--
Python driver 3.25.0 with fixed
[PYTHON-1269|https://datastax-oss.atlassian.net/browse/PYTHON-1269] was
released a while ago. Unfortunately, with the new driver version Cassandra
server logs the following errors in dtests:
{noformat}
Protocol exception with client networking:
org.apache.cassandra.transport.ProtocolException: Beta version of the protocol
used (5/v5-beta), but USE_BETA flag is unset
{noformat}
AFAIU this happens because 3.11 classifies V5 as beta while 3.25.0 considers it
stable.
I don't think it is a good idea to introduce protocol-level warnings in the
trivial bug fix, therefore I cherry-picked
[PYTHON-1269|https://datastax-oss.atlassian.net/browse/PYTHON-1269] into 3.24.0.
[~adelapena] Can you please review?
> DESCRIBE KEYSPACE does not properly quote table names
> -
>
> Key: CASSANDRA-15663
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15663
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Syntax
>Reporter: Oskar Liljeblad
>Assignee: Aleksandr Sorokoumov
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.11.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> How to reproduce (3.11.6) - cqlsh:
> {code}
> CREATE KEYSPACE test1 WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': '1'} AND durable_writes = true;
> CREATE TABLE test1."default" (id text PRIMARY KEY, data text, etag text);
> DESCRIBE KEYSPACE test1;
> {code}
> Output will be:
> {code}
> CREATE TABLE test1.default (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> Output should be:
> {code}
> CREATE TABLE test1."default" (
> id text PRIMARY KEY,
> data text,
> etag text
> ) WITH [..]
> {code}
> If you try to run {{CREATE TABLE test1.default [..]}} you will get an error
> SyntaxException: line 1:19 no viable alternative at input 'default' (CREATE
> TABLE test1.[default]...)
> Oskar Liljeblad
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16759) Avoid memoizing the wrong min cluster version during upgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368804#comment-17368804
]
Marcus Eriksson commented on CASSANDRA-16759:
-
by clearing out the memoized minVersion in {{start()}} we might call
{{upgradeFromVersionSupplier}} before we know anything about the cluster
pushed a new patch which makes sure we don't memoize anything before we
actually have {{endpointStateMap}} populated with something usable, tests
running
> Avoid memoizing the wrong min cluster version during upgrades
> -
>
> Key: CASSANDRA-16759
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16759
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-rc2
>
>
> CASSANDRA-16525 avoids trying to calculate the cluster min version if
> gossiper is not enabled.
> This makes us memoize the wrong version for up to a minute causing us to send
> 4.0-messages to 3.0 nodes, for example in
> [ColumnFilter|https://github.com/apache/cassandra/blob/05beda90a9206db165a3997a736ecb06f8dc695e/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L210]
> This was discovered by python upgrade dtests,
> [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/993/workflows/2afef6f0-1356-41f6-93dc-5385ac19dca1/jobs/5977/tests#failed-test-0]
> after reverting CASSANDRA-15899 in CASSANDRA-16735
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
