[jira] [Commented] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436196#comment-17436196 ] Paulo Motta commented on CASSANDRA-16308: - Hi thanks for working on this ticket [~tejavadali]. Instructions on how to prepare a patch (ie. how to format commit messages) can be found [on this doc|https://cassandra.apache.org/_/development/patches.html]. When you have a patch ready please submit a PR to the [github mirror|https://github.com/apache/cassandra] with this ticket number + short description (CASSANDRA-16308) and it will automagically link to this ticket and set the JIRA status to Patch Available. I can take a look and submit CI if it looks good to test. > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Krishna Vadali >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17055) Forbid other Future implementations with checkstyle
[ https://issues.apache.org/jira/browse/CASSANDRA-17055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436181#comment-17436181 ] David Capwell commented on CASSANDRA-17055: --- * https://github.com/belliottsmith/cassandra/commit/cff0985864d997274098f04553c68c7e3818a5bb#diff-b36112ff71ee5b411c9149781cee470c6413dbf498272fa70eb00b8b7555207fR54 if you take the changes in CASSANDRA-17069 you can replace "RegexpSinglelineJava" with blockSystemClock, so this check can't be used with executors Other than that, LGTM +1. Tested locally as well > Forbid other Future implementations with checkstyle > --- > > Key: CASSANDRA-17055 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17055 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17055) Forbid other Future implementations with checkstyle
[ https://issues.apache.org/jira/browse/CASSANDRA-17055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17055: -- Status: Ready to Commit (was: Review In Progress) > Forbid other Future implementations with checkstyle > --- > > Key: CASSANDRA-17055 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17055 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16801:
Status: Needs Committer (was: Patch Available)
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17086) Fix python dtest upgrade tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17086:
-
Resolution: Fixed
Status: Resolved (was: Open)
> Fix python dtest upgrade tests
> --
>
> Key: CASSANDRA-17086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17086
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> Several tests are failing in python dtest upgrade
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7095
> upgrade_tests/drop_compact_storage_upgrade_test.py::TestDropCompactStorage::
> drop_compact_storage
> {code}
> assert 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.' in 'Error from
> server: code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as
> some nodes in the cluster ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+
> yet. Please upgrade those nodes and run `upgradesstables` before retrying."'
> + where 'Error from server: code=2200 [Invalid query] message="Cannot DROP
> COMPACT STORAGE as some nodes in the cluster ([/1271:7000,
> /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those nodes and run
> `upgradesstables` before retrying."' = str(InvalidRequest('Error from server:
> code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as some nodes
> in the...:7000, /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those
> nodes and run `upgradesstables` before retrying."',))
> {code}
> bootstrap_test.py::TestBootstrapUpgrade::
> test_bootstrap_with_reset_bootstrap_state
> This is likely related to CASSANDRA-17055
> {code}
> > node1.start()
> bootstrap_test.py:483:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:895: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:664: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:592: in watch_log_for
> head=reads[:50], tail="..."+reads[len(reads)-150:]))
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> start = 1635454559.2164426, timeout = 120
> msg = "Missing: ['127.0.0.1:7000.* is now UP'] not found in system.log:\n
> Head: \n Tail: ..."
> node = 'node3'
> @staticmethod
> def raise_if_passed(start, timeout, msg, node=None):
> if start + timeout < time.time():
> > raise TimeoutError.create(start, timeout, msg, node)
> E ccmlib.node.TimeoutError: 28 Oct 2021 20:57:59 [node3] after
> 120.13/120 seconds Missing: ['127.0.0.1:7000.* is now UP'] not found in
> system.log:
> EHead:
> ETail: ...
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X::
> test_rolling_upgrade
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD::
> test_rolling_upgrade_with_internode_ssl
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD::
> test_rolling_upgrade
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X::
> test_rolling_upgrade_with_internode_ssl
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (CASSANDRA-17088) Fix test org.apache.cassandra.net.MessagingServiceTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17088:
-
Resolution: Fixed
Status: Resolved (was: Open)
> Fix test org.apache.cassandra.net.MessagingServiceTest
> --
>
> Key: CASSANDRA-17088
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17088
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
> at
> org.apache.cassandra.net.MessagingServiceTest.listenRequiredSecureConnection(MessagingServiceTest.java:277)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> And
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
> at
> org.apache.cassandra.net.MessagingServiceTest.listenOptionalSecureConnection(MessagingServiceTest.java:315)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17087) Fix test org.apache.cassandra.repair.RepairJobTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17087:
-
Resolution: Duplicate
Status: Resolved (was: Open)
> Fix test org.apache.cassandra.repair.RepairJobTest
> --
>
> Key: CASSANDRA-17087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17087
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
> {code}
> junit.framework.AssertionFailedError:
> Expecting:
> <1L>
> to be less than:
> <1L>
> at
> org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:283)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The test seems to only fail on jdk11, but it consistently fails on jdk11
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17085) Fix python dtests bootstrap_test.py::TestBootstrap
[
https://issues.apache.org/jira/browse/CASSANDRA-17085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17085:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.x
Severity: Normal
Status: Open (was: Triage Needed)
> Fix python dtests bootstrap_test.py::TestBootstrap
> --
>
> Key: CASSANDRA-17085
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17085
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> Right now bootstrap tests are failing every time we run, this work is to
> debug and fix the underling issue.
> Examples:
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7089
> {code}
> > node3.nodetool('bootstrap resume')
> bootstrap_test.py:1014:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:1005: in nodetool
> return handle_external_tool_process(p, ['nodetool', '-h', 'localhost',
> '-p', str(self.jmx_port)] + shlex.split(cmd))
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> process =
> cmd_args = ['nodetool', '-h', 'localhost', '-p', '7300', 'bootstrap', ...]
> def handle_external_tool_process(process, cmd_args):
> out, err = process.communicate()
> if (out is not None) and isinstance(out, bytes):
> out = out.decode()
> if (err is not None) and isinstance(err, bytes):
> err = err.decode()
> rc = process.returncode
>
> if rc != 0:
> > raise ToolError(cmd_args, rc, out, err)
> E ccmlib.node.ToolError: Subprocess ['nodetool', '-h', 'localhost',
> '-p', '7300', 'bootstrap', 'resume'] exited with non-zero status; exit
> status: 1;
> E stderr: nodetool: Failed to connect to 'localhost:7300' -
> EOFException: 'null'.
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:2305: ToolError
> {code}
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7087
> {code}
> > node1.start()
> bootstrap_test.py:483:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:895: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:664: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:592: in watch_log_for
> head=reads[:50], tail="..."+reads[len(reads)-150:]))
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> start = 1635453190.3118386, timeout = 120
> msg = "Missing: ['127.0.0.1:7000.* is now UP'] not found in system.log:\n
> Head: \n Tail: ..."
> node = 'node3'
> @staticmethod
> def raise_if_passed(start, timeout, msg, node=None):
> if start + timeout < time.time():
> > raise TimeoutError.create(start, timeout, msg, node)
> E ccmlib.node.TimeoutError: 28 Oct 2021 20:35:10 [node3] after
> 120.12/120 seconds Missing: ['127.0.0.1:7000.* is now UP'] not found in
> system.log:
> EHead:
> ETail: ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17086) Fix python dtest upgrade tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17086:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.x
Severity: Normal
Status: Open (was: Triage Needed)
> Fix python dtest upgrade tests
> --
>
> Key: CASSANDRA-17086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17086
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> Several tests are failing in python dtest upgrade
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7095
> upgrade_tests/drop_compact_storage_upgrade_test.py::TestDropCompactStorage::
> drop_compact_storage
> {code}
> assert 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.' in 'Error from
> server: code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as
> some nodes in the cluster ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+
> yet. Please upgrade those nodes and run `upgradesstables` before retrying."'
> + where 'Error from server: code=2200 [Invalid query] message="Cannot DROP
> COMPACT STORAGE as some nodes in the cluster ([/1271:7000,
> /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those nodes and run
> `upgradesstables` before retrying."' = str(InvalidRequest('Error from server:
> code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as some nodes
> in the...:7000, /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those
> nodes and run `upgradesstables` before retrying."',))
> {code}
> bootstrap_test.py::TestBootstrapUpgrade::
> test_bootstrap_with_reset_bootstrap_state
> This is likely related to CASSANDRA-17055
> {code}
> > node1.start()
> bootstrap_test.py:483:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:895: in start
> node.watch_log_for_alive(self, from_mark=mark)
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:664: in
> watch_log_for_alive
> self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
> filename=filename)
> ../env3.6/lib/python3.6/site-packages/ccmlib/node.py:592: in watch_log_for
> head=reads[:50], tail="..."+reads[len(reads)-150:]))
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> start = 1635454559.2164426, timeout = 120
> msg = "Missing: ['127.0.0.1:7000.* is now UP'] not found in system.log:\n
> Head: \n Tail: ..."
> node = 'node3'
> @staticmethod
> def raise_if_passed(start, timeout, msg, node=None):
> if start + timeout < time.time():
> > raise TimeoutError.create(start, timeout, msg, node)
> E ccmlib.node.TimeoutError: 28 Oct 2021 20:57:59 [node3] after
> 120.13/120 seconds Missing: ['127.0.0.1:7000.* is now UP'] not found in
> system.log:
> EHead:
> ETail: ...
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X::
> test_rolling_upgrade
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD::
> test_rolling_upgrade_with_internode_ssl
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD::
> test_rolling_upgrade
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> {code}
> upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X::
> test_rolling_upgrade_with_internode_ssl
> {code}
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True),
[jira] [Updated] (CASSANDRA-17088) Fix test org.apache.cassandra.net.MessagingServiceTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17088:
--
Description:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
{code}
junit.framework.AssertionFailedError
at
org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
at
org.apache.cassandra.net.MessagingServiceTest.listenRequiredSecureConnection(MessagingServiceTest.java:277)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
And
{code}
junit.framework.AssertionFailedError
at
org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
at
org.apache.cassandra.net.MessagingServiceTest.listenOptionalSecureConnection(MessagingServiceTest.java:315)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
was:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
junit.framework.AssertionFailedError
at
org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
at
org.apache.cassandra.net.MessagingServiceTest.listenRequiredSecureConnection(MessagingServiceTest.java:277)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
And
junit.framework.AssertionFailedError
at
org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
at
org.apache.cassandra.net.MessagingServiceTest.listenOptionalSecureConnection(MessagingServiceTest.java:315)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Fix test org.apache.cassandra.net.MessagingServiceTest
> --
>
> Key: CASSANDRA-17088
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17088
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
> at
> org.apache.cassandra.net.MessagingServiceTest.listenRequiredSecureConnection(MessagingServiceTest.java:277)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> And
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343)
> at
> org.apache.cassandra.net.MessagingServiceTest.listenOptionalSecureConnection(MessagingServiceTest.java:315)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17088) Fix test org.apache.cassandra.net.MessagingServiceTest
[ https://issues.apache.org/jira/browse/CASSANDRA-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17088: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: Unit Test Fix Version/s: 4.x Severity: Normal Status: Open (was: Triage Needed) > Fix test org.apache.cassandra.net.MessagingServiceTest > -- > > Key: CASSANDRA-17088 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17088 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Priority: Normal > Fix For: 4.x > > > https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084 > junit.framework.AssertionFailedError > at > org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343) > at > org.apache.cassandra.net.MessagingServiceTest.listenRequiredSecureConnection(MessagingServiceTest.java:277) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > And > junit.framework.AssertionFailedError > at > org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343) > at > org.apache.cassandra.net.MessagingServiceTest.listenOptionalSecureConnection(MessagingServiceTest.java:315) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17087) Fix test org.apache.cassandra.repair.RepairJobTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17087:
--
Description:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
{code}
junit.framework.AssertionFailedError:
Expecting:
<1L>
to be less than:
<1L>
at
org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:283)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
The test seems to only fail on jdk11, but it consistently fails on jdk11
was:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
junit.framework.AssertionFailedError:
Expecting:
<1L>
to be less than:
<1L>
at
org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:283)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
The test seems to only fail on jdk11, but it consistently fails on jdk11
> Fix test org.apache.cassandra.repair.RepairJobTest
> --
>
> Key: CASSANDRA-17087
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17087
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084
> {code}
> junit.framework.AssertionFailedError:
> Expecting:
> <1L>
> to be less than:
> <1L>
> at
> org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:283)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The test seems to only fail on jdk11, but it consistently fails on jdk11
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17087) Fix test org.apache.cassandra.repair.RepairJobTest
[ https://issues.apache.org/jira/browse/CASSANDRA-17087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17087: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: Unit Test Fix Version/s: 4.x Severity: Normal Status: Open (was: Triage Needed) > Fix test org.apache.cassandra.repair.RepairJobTest > -- > > Key: CASSANDRA-17087 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17087 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Priority: Normal > Fix For: 4.x > > > https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084 > junit.framework.AssertionFailedError: > Expecting: > <1L> > to be less than: > <1L> > at > org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:283) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > The test seems to only fail on jdk11, but it consistently fails on jdk11 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17088) Fix test org.apache.cassandra.net.MessagingServiceTest
David Capwell created CASSANDRA-17088: - Summary: Fix test org.apache.cassandra.net.MessagingServiceTest Key: CASSANDRA-17088 URL: https://issues.apache.org/jira/browse/CASSANDRA-17088 Project: Cassandra Issue Type: Bug Components: Test/unit Reporter: David Capwell https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084 junit.framework.AssertionFailedError at org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343) at org.apache.cassandra.net.MessagingServiceTest.listenRequiredSecureConnection(MessagingServiceTest.java:277) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) And junit.framework.AssertionFailedError at org.apache.cassandra.net.MessagingServiceTest.listen(MessagingServiceTest.java:343) at org.apache.cassandra.net.MessagingServiceTest.listenOptionalSecureConnection(MessagingServiceTest.java:315) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17087) Fix test org.apache.cassandra.repair.RepairJobTest
David Capwell created CASSANDRA-17087: - Summary: Fix test org.apache.cassandra.repair.RepairJobTest Key: CASSANDRA-17087 URL: https://issues.apache.org/jira/browse/CASSANDRA-17087 Project: Cassandra Issue Type: Bug Components: Test/unit Reporter: David Capwell https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/3642831f-81d0-4c4f-8bb7-9444e11b58b4/jobs/7084 junit.framework.AssertionFailedError: Expecting: <1L> to be less than: <1L> at org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:283) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) The test seems to only fail on jdk11, but it consistently fails on jdk11 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17086) Fix python dtest upgrade tests
David Capwell created CASSANDRA-17086:
-
Summary: Fix python dtest upgrade tests
Key: CASSANDRA-17086
URL: https://issues.apache.org/jira/browse/CASSANDRA-17086
Project: Cassandra
Issue Type: Bug
Components: Test/dtest/python
Reporter: David Capwell
Several tests are failing in python dtest upgrade
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7095
upgrade_tests/drop_compact_storage_upgrade_test.py::TestDropCompactStorage::
drop_compact_storage
{code}
assert 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade those
nodes and run `upgradesstables` before retrying.' in 'Error from server:
code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as some nodes in
the cluster ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+ yet. Please
upgrade those nodes and run `upgradesstables` before retrying."' + where
'Error from server: code=2200 [Invalid query] message="Cannot DROP COMPACT
STORAGE as some nodes in the cluster ([/1271:7000, /127.0.0.2:7000]) are
not on 4.0+ yet. Please upgrade those nodes and run `upgradesstables` before
retrying."' = str(InvalidRequest('Error from server: code=2200 [Invalid query]
message="Cannot DROP COMPACT STORAGE as some nodes in the...:7000,
/127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those nodes and run
`upgradesstables` before retrying."',))
{code}
bootstrap_test.py::TestBootstrapUpgrade::
test_bootstrap_with_reset_bootstrap_state
This is likely related to CASSANDRA-17055
{code}
> node1.start()
bootstrap_test.py:483:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:895: in start
node.watch_log_for_alive(self, from_mark=mark)
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:664: in watch_log_for_alive
self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
filename=filename)
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:592: in watch_log_for
head=reads[:50], tail="..."+reads[len(reads)-150:]))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
start = 1635454559.2164426, timeout = 120
msg = "Missing: ['127.0.0.1:7000.* is now UP'] not found in system.log:\n Head:
\n Tail: ..."
node = 'node3'
@staticmethod
def raise_if_passed(start, timeout, msg, node=None):
if start + timeout < time.time():
> raise TimeoutError.create(start, timeout, msg, node)
E ccmlib.node.TimeoutError: 28 Oct 2021 20:57:59 [node3] after
120.13/120 seconds Missing: ['127.0.0.1:7000.* is now UP'] not found in
system.log:
EHead:
ETail: ...
{code}
upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X::
test_rolling_upgrade
{code}
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
{code}
upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD::
test_rolling_upgrade_with_internode_ssl
{code}
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
{code}
upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD::
test_rolling_upgrade
{code}
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
{code}
upgrade_tests/upgrade_through_versions_test.py::TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X::
test_rolling_upgrade_with_internode_ssl
{code}
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17085) Fix python dtests bootstrap_test.py::TestBootstrap
David Capwell created CASSANDRA-17085:
-
Summary: Fix python dtests bootstrap_test.py::TestBootstrap
Key: CASSANDRA-17085
URL: https://issues.apache.org/jira/browse/CASSANDRA-17085
Project: Cassandra
Issue Type: Bug
Components: Test/dtest/python
Reporter: David Capwell
Right now bootstrap tests are failing every time we run, this work is to debug
and fix the underling issue.
Examples:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7089
{code}
> node3.nodetool('bootstrap resume')
bootstrap_test.py:1014:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:1005: in nodetool
return handle_external_tool_process(p, ['nodetool', '-h', 'localhost',
'-p', str(self.jmx_port)] + shlex.split(cmd))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
process =
cmd_args = ['nodetool', '-h', 'localhost', '-p', '7300', 'bootstrap', ...]
def handle_external_tool_process(process, cmd_args):
out, err = process.communicate()
if (out is not None) and isinstance(out, bytes):
out = out.decode()
if (err is not None) and isinstance(err, bytes):
err = err.decode()
rc = process.returncode
if rc != 0:
> raise ToolError(cmd_args, rc, out, err)
E ccmlib.node.ToolError: Subprocess ['nodetool', '-h', 'localhost',
'-p', '7300', 'bootstrap', 'resume'] exited with non-zero status; exit status:
1;
E stderr: nodetool: Failed to connect to 'localhost:7300' -
EOFException: 'null'.
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:2305: ToolError
{code}
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1062/workflows/ba3e6395-ef22-4724-8424-0549e65d8cff/jobs/7087
{code}
> node1.start()
bootstrap_test.py:483:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:895: in start
node.watch_log_for_alive(self, from_mark=mark)
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:664: in watch_log_for_alive
self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout,
filename=filename)
../env3.6/lib/python3.6/site-packages/ccmlib/node.py:592: in watch_log_for
head=reads[:50], tail="..."+reads[len(reads)-150:]))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
start = 1635453190.3118386, timeout = 120
msg = "Missing: ['127.0.0.1:7000.* is now UP'] not found in system.log:\n Head:
\n Tail: ..."
node = 'node3'
@staticmethod
def raise_if_passed(start, timeout, msg, node=None):
if start + timeout < time.time():
> raise TimeoutError.create(start, timeout, msg, node)
E ccmlib.node.TimeoutError: 28 Oct 2021 20:35:10 [node3] after
120.12/120 seconds Missing: ['127.0.0.1:7000.* is now UP'] not found in
system.log:
EHead:
ETail: ...
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17084) startup fails if directories do not exist
[
https://issues.apache.org/jira/browse/CASSANDRA-17084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436139#comment-17436139
]
Brandon Williams commented on CASSANDRA-17084:
--
Previously we could get past DD.daemonInitialization and then in setup() when
initializing the commitlog it ends up calling DD.createAllDirectories, but this
is now too late. I don't think calling createAllDirectories sooner now is the
solution though, since we use daemonInitialization extensively in tests, and
probably don't want the side effect of it creating directories.
> startup fails if directories do not exist
> -
>
> Key: CASSANDRA-17084
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17084
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 4.1
>
>
> Prior to CASSANDRA-16926, having commitlog and data dirs defined that did not
> exist would be created on startup, but now we throw:
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable check disk space in
> 'bin/../data/commitlog'. Perhaps the Cassandra user does not have the
> necessary permissions
> org.apache.cassandra.exceptions.ConfigurationException: Unable check disk
> space in 'bin/../data/commitlog'. Perhaps the Cassandra user does not have
> the necessary permissions
> at
> org.apache.cassandra.config.DatabaseDescriptor.lambda$tryGetSpace$3(DatabaseDescriptor.java:1188)
> at
> org.apache.cassandra.io.util.PathUtils.tryOnFileStore(PathUtils.java:639)
> at
> org.apache.cassandra.io.util.PathUtils.tryGetSpace(PathUtils.java:665)
> at
> org.apache.cassandra.config.DatabaseDescriptor.tryGetSpace(DatabaseDescriptor.java:1188)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySimpleConfig(DatabaseDescriptor.java:553)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:350)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:178)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:162)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:800)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:736)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:871)
> {noformat}
> This was at least convenient for development, but also may be relied upon by
> some tooling/automation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13981) Enable Cassandra for Persistent Memory
[ https://issues.apache.org/jira/browse/CASSANDRA-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436124#comment-17436124 ] shylaja kokoori commented on CASSANDRA-13981: - The code is under active development. The implementation has been modified to make use of the pluggable memtable interface introduced by CEP11. We are in the process of making the code feature complete while we wait for resolution of following JIRAs. CASSANDRA-17034 CEP-11: Memtable API implementation CASSANDRA-6936 Make all byte representations of types comparable by their unsigned byte representation only > Enable Cassandra for Persistent Memory > --- > > Key: CASSANDRA-13981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13981 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Core >Reporter: Preetika Tyagi >Assignee: Preetika Tyagi >Priority: Normal > Fix For: 4.x > > Attachments: in-mem-cassandra-1.0.patch, in-mem-cassandra-2.0.patch, > in-mem-cassandra-2.1.patch, readme.txt, readme2.1.txt, readme2_0.txt > > > Currently, Cassandra relies on disks for data storage and hence it needs data > serialization, compaction, bloom filters and partition summary/index for > speedy access of the data. However, with persistent memory, data can be > stored directly in the form of Java objects and collections, which can > greatly simplify the retrieval mechanism of the data. What we are proposing > is to make use of faster and scalable B+ tree-based data collections built > for persistent memory in Java (PCJ: https://github.com/pmem/pcj) and enable a > complete in-memory version of Cassandra, while still keeping the data > persistent. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Vadali updated CASSANDRA-16308: --- Status: In Progress (was: Patch Available) > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Krishna Vadali >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16308) Add droppable tombstone metrics to nodetool tablestats
[ https://issues.apache.org/jira/browse/CASSANDRA-16308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Vadali updated CASSANDRA-16308: --- Mentor: Paulo Motta Test and Documentation Plan: Followed the below steps to test: 1. ccm create test --install-dir=./cassandra (cassandra source directory with changes) 2. ccm populate -n 1 3. ccm start 4. ccm node1 nodetool tablestats: I could verify `Droppable tombstone ratio` as part of the output for each table in the output. Status: Patch Available (was: Open) > Add droppable tombstone metrics to nodetool tablestats > -- > > Key: CASSANDRA-16308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16308 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Krishna Vadali >Priority: Low > > This is a useful metric to troubleshoot tombstone cleanup problems and is not > currently exposed on table stats. > While we're at it we should add the JMX metric to the table metrics > documentation because it's currently missing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17034) CEP-11: Memtable API implementation
[
https://issues.apache.org/jira/browse/CASSANDRA-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436054#comment-17436054
]
Branimir Lambov edited comment on CASSANDRA-17034 at 10/29/21, 4:17 PM:
Patch uploaded here:
[branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17034] [pull
request|https://github.com/apache/cassandra/pull/1295]
For reviewers it will be better to look at the individual commits. The first
one is sizeable but trivial, adding the flush reason to all places that request
a flush. The second is the bulk of the work, which splits {{Memtable}} into an
interface and hierarchy of classes that add pieces of memtable functionality,
ending in {{SkipListMemtable}} which is the current implementation; flushing
functionality is moved outside of {{ColumnFamilyStore}}, and new functionality
to write temporary sstables for streaming from long-lived memtables is added.
The rest of the commits add a mechanism for providing shard boundaries that
split the owned space equally, and a basic common interface for reading
memtables and sstables.
Usages of the API, i.e. alternative memtable implementations, will be provided
soon.
was (Author: blambov):
Patch uploaded here:
[branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17034] [pull
request|https://github.com/apache/cassandra/pull/1295]
For reviewers it will be better to look at the individual commits. The first
one is sizeable but trivial, adding the flush reason to all places that request
a flush. The second is the bulk of the work, which splits {{Memtable}} into an
interface and hierarchy of classes that add pieces of memtable functionality,
ending in {{SkipListMemtable}} which is the current implementation. The rest of
the commits add a mechanism for providing shard boundaries that split the owned
space equally, and a basic common interface for reading memtables and sstables.
> CEP-11: Memtable API implementation
> ---
>
> Key: CASSANDRA-17034
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17034
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Memtable
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pluggable memtable API as described in
> [CEP-11|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-11%3A+Pluggable+memtable+implementations].
>
> Initial version is already available in [this
> branch|https://github.com/datastax/cassandra/tree/memtable-api], and needs to
> be updated to the changes in trunk. Two additional features suggested by CEP
> reviewers are also to be implemented:
> * Sharding support: extending the memtable owner interface to supply
> suitable shard boundaries that split the owned token space and are in
> agreement with disk boundaries.
> * Shared read API with sstables: defining a common interface for reading
> partitions from memtables and sstables; this is to include filters to avoid
> unnecessary copying.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17034) CEP-11: Memtable API implementation
[
https://issues.apache.org/jira/browse/CASSANDRA-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-17034:
Impacts: Docs (was: None)
Test and Documentation Plan:
Existing memtable implementation is tested as before. New implementations will
need to also perform all memtable tests in addition to implementation-specific
unit tests.
New configuration options need to be added to the documentation.
Status: Patch Available (was: In Progress)
Patch uploaded here:
[branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17034] [pull
request|https://github.com/apache/cassandra/pull/1295]
For reviewers it will be better to look at the individual commits. The first
one is sizeable but trivial, adding the flush reason to all places that request
a flush. The second is the bulk of the work, which splits {{Memtable}} into an
interface and hierarchy of classes that add pieces of memtable functionality,
ending in {{SkipListMemtable}} which is the current implementation. The rest of
the commits add a mechanism for providing shard boundaries that split the owned
space equally, and a basic common interface for reading memtables and sstables.
> CEP-11: Memtable API implementation
> ---
>
> Key: CASSANDRA-17034
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17034
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Memtable
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pluggable memtable API as described in
> [CEP-11|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-11%3A+Pluggable+memtable+implementations].
>
> Initial version is already available in [this
> branch|https://github.com/datastax/cassandra/tree/memtable-api], and needs to
> be updated to the changes in trunk. Two additional features suggested by CEP
> reviewers are also to be implemented:
> * Sharding support: extending the memtable owner interface to supply
> suitable shard boundaries that split the owned token space and are in
> agreement with disk boundaries.
> * Shared read API with sstables: defining a common interface for reading
> partitions from memtables and sstables; this is to include filters to avoid
> unnecessary copying.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17084) startup fails if directories do not exist
[
https://issues.apache.org/jira/browse/CASSANDRA-17084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17084:
-
Bug Category: Parent values: Availability(12983)
Complexity: Normal
Component/s: Local/Startup and Shutdown
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> startup fails if directories do not exist
> -
>
> Key: CASSANDRA-17084
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17084
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 4.1
>
>
> Prior to CASSANDRA-16926, having commitlog and data dirs defined that did not
> exist would be created on startup, but now we throw:
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable check disk space in
> 'bin/../data/commitlog'. Perhaps the Cassandra user does not have the
> necessary permissions
> org.apache.cassandra.exceptions.ConfigurationException: Unable check disk
> space in 'bin/../data/commitlog'. Perhaps the Cassandra user does not have
> the necessary permissions
> at
> org.apache.cassandra.config.DatabaseDescriptor.lambda$tryGetSpace$3(DatabaseDescriptor.java:1188)
> at
> org.apache.cassandra.io.util.PathUtils.tryOnFileStore(PathUtils.java:639)
> at
> org.apache.cassandra.io.util.PathUtils.tryGetSpace(PathUtils.java:665)
> at
> org.apache.cassandra.config.DatabaseDescriptor.tryGetSpace(DatabaseDescriptor.java:1188)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySimpleConfig(DatabaseDescriptor.java:553)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:350)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:178)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:162)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:800)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:736)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:871)
> {noformat}
> This was at least convenient for development, but also may be relied upon by
> some tooling/automation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17084) startup fails if directories do not exist
[
https://issues.apache.org/jira/browse/CASSANDRA-17084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17084:
-
Fix Version/s: 4.1
> startup fails if directories do not exist
> -
>
> Key: CASSANDRA-17084
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17084
> Project: Cassandra
> Issue Type: Bug
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 4.1
>
>
> Prior to CASSANDRA-16926, having commitlog and data dirs defined that did not
> exist would be created on startup, but now we throw:
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable check disk space in
> 'bin/../data/commitlog'. Perhaps the Cassandra user does not have the
> necessary permissions
> org.apache.cassandra.exceptions.ConfigurationException: Unable check disk
> space in 'bin/../data/commitlog'. Perhaps the Cassandra user does not have
> the necessary permissions
> at
> org.apache.cassandra.config.DatabaseDescriptor.lambda$tryGetSpace$3(DatabaseDescriptor.java:1188)
> at
> org.apache.cassandra.io.util.PathUtils.tryOnFileStore(PathUtils.java:639)
> at
> org.apache.cassandra.io.util.PathUtils.tryGetSpace(PathUtils.java:665)
> at
> org.apache.cassandra.config.DatabaseDescriptor.tryGetSpace(DatabaseDescriptor.java:1188)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySimpleConfig(DatabaseDescriptor.java:553)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:350)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:178)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:162)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:800)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:736)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:871)
> {noformat}
> This was at least convenient for development, but also may be relied upon by
> some tooling/automation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17084) startup fails if directories do not exist
Brandon Williams created CASSANDRA-17084:
Summary: startup fails if directories do not exist
Key: CASSANDRA-17084
URL: https://issues.apache.org/jira/browse/CASSANDRA-17084
Project: Cassandra
Issue Type: Bug
Reporter: Brandon Williams
Prior to CASSANDRA-16926, having commitlog and data dirs defined that did not
exist would be created on startup, but now we throw:
{noformat}
Exception (org.apache.cassandra.exceptions.ConfigurationException) encountered
during startup: Unable check disk space in 'bin/../data/commitlog'. Perhaps the
Cassandra user does not have the necessary permissions
org.apache.cassandra.exceptions.ConfigurationException: Unable check disk space
in 'bin/../data/commitlog'. Perhaps the Cassandra user does not have the
necessary permissions
at
org.apache.cassandra.config.DatabaseDescriptor.lambda$tryGetSpace$3(DatabaseDescriptor.java:1188)
at
org.apache.cassandra.io.util.PathUtils.tryOnFileStore(PathUtils.java:639)
at
org.apache.cassandra.io.util.PathUtils.tryGetSpace(PathUtils.java:665)
at
org.apache.cassandra.config.DatabaseDescriptor.tryGetSpace(DatabaseDescriptor.java:1188)
at
org.apache.cassandra.config.DatabaseDescriptor.applySimpleConfig(DatabaseDescriptor.java:553)
at
org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:350)
at
org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:178)
at
org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:162)
at
org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:800)
at
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:736)
at
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:871)
{noformat}
This was at least convenient for development, but also may be relied upon by
some tooling/automation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17055) Forbid other Future implementations with checkstyle
[ https://issues.apache.org/jira/browse/CASSANDRA-17055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17055: -- Reviewers: David Capwell Status: Review In Progress (was: Patch Available) first pass and LGTM, will look closer later today > Forbid other Future implementations with checkstyle > --- > > Key: CASSANDRA-17055 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17055 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436023#comment-17436023
]
Andres de la Peña commented on CASSANDRA-17070:
---
[Here|https://app.circleci.com/pipelines/github/adelapena/cassandra/1101/workflows/c335ffa0-1513-40a1-b925-292e0d03cee3/jobs/10214]
are other 500 rounds of the tests without the duplicated cleanup. There is a
single error in
{{ViewComplexUpdatesTest.testUpdateWithColumnTimestampSmallerThanPk}},
apparently due to a query timeout (see the bottom of the
[stdout|https://circle-production-customer-artifacts.s3.amazonaws.com/picard/52e11c3bf7d0f78c41388745/617bdf2aa30bc2444e1c8dda-15-build/artifacts/stdout/fails/05/test-ViewComplex%2ATest.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256=20211029T144933Z=host=60=AKIAJR3Q6CR467H7Z55A%2F20211029%2Fus-east-1%2Fs3%2Faws4_request=033813c3f1bc4bd9485bd06dad36099d61616fc505b8ae03d71cba4e41cf7844]
file).
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Issue Comment Deleted] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16801:
Comment: was deleted
(was: Info for the reviewer:
Luckily antlr was already moving the password around in a DTO {{RoleOptions}}.
So the new logic is applied whenever possible and uses the previous logic as a
fallback.
Interesting corner case I found where {{testp}} is being revealed #justfyi
{noformat}
Type: audit
LogMessage:
user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:41278|timestamp:1635328638577|type:REQUEST_FAILURE|category:ERROR|operation:create
user 'test' with password ***; line 1:33 mismatched input 'testp'
expecting STRING_LITERAL (create user 'test' with password ***
{noformat}
)
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch trunk updated: [maven-release-plugin] prepare for next development iteration
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/trunk by this push: new be0c128 [maven-release-plugin] prepare for next development iteration be0c128 is described below commit be0c1289bd7710a26a78025d29879642afde0e96 Author: mck AuthorDate: Fri Oct 29 14:19:40 2021 +0200 [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 6722af4..ae48a32 100644 --- a/pom.xml +++ b/pom.xml @@ -27,7 +27,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.11 +0.0.12-SNAPSHOT In JVM Test API In JVM Test API @@ -158,7 +158,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git -0.0.11 +HEAD - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] annotated tag 0.0.11 created (now 6ffb0dd)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to annotated tag 0.0.11 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. at 6ffb0dd (tag) tagging cbe7e89dc166cf4f2f94a11c7b3e867494f62ac0 (commit) replaces 0.0.10 by mck on Fri Oct 29 14:19:36 2021 +0200 - Log - [maven-release-plugin] copy for tag 0.0.11 --- No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch trunk updated: [maven-release-plugin] prepare release 0.0.11
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/trunk by this push: new cbe7e89 [maven-release-plugin] prepare release 0.0.11 cbe7e89 is described below commit cbe7e89dc166cf4f2f94a11c7b3e867494f62ac0 Author: mck AuthorDate: Fri Oct 29 14:19:32 2021 +0200 [maven-release-plugin] prepare release 0.0.11 --- pom.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 55d0e13..6722af4 100644 --- a/pom.xml +++ b/pom.xml @@ -27,7 +27,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.11-SNAPSHOT +0.0.11 In JVM Test API In JVM Test API @@ -158,6 +158,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git +0.0.11 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch trunk updated: Revert "[maven-release-plugin] prepare release"
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/trunk by this push: new b7136e0 Revert "[maven-release-plugin] prepare release" b7136e0 is described below commit b7136e02893f49b0b0959bb14193041dcf2e676b Author: mck AuthorDate: Fri Oct 29 14:16:39 2021 +0200 Revert "[maven-release-plugin] prepare release" This reverts commit c29a4b938efd4e783fbbb3e3c53bf313632e8b4b. --- pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index ae5cf76..55d0e13 100644 --- a/pom.xml +++ b/pom.xml @@ -27,7 +27,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.11 +0.0.11-SNAPSHOT In JVM Test API In JVM Test API @@ -158,7 +158,6 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git - - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch trunk updated: [maven-release-plugin] prepare release
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/trunk by this push: new c29a4b9 [maven-release-plugin] prepare release c29a4b9 is described below commit c29a4b938efd4e783fbbb3e3c53bf313632e8b4b Author: mck AuthorDate: Fri Oct 29 14:12:07 2021 +0200 [maven-release-plugin] prepare release --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index c0b8efc..ae5cf76 100644 --- a/pom.xml +++ b/pom.xml @@ -27,7 +27,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.11-SNAPSHOT +0.0.11 In JVM Test API In JVM Test API @@ -158,7 +158,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git -0.0.10 + - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-accord] branch trunk created (now 210ff37)
This is an automated email from the ASF dual-hosted git repository. benedict pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git. at 210ff37 KeyRange refactor This branch includes the following new commits: new 93533f5 initial commit new 210ff37 KeyRange refactor The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-accord] 02/02: KeyRange refactor
This is an automated email from the ASF dual-hosted git repository.
benedict pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
commit 210ff37b75fc07603b5f655171f6c49cf75805da
Author: Blake Eggleston
AuthorDate: Tue Sep 14 13:52:17 2021 -0700
KeyRange refactor
---
accord-core/src/main/java/accord/api/KeyRange.java | 163 +
accord-core/src/main/java/accord/api/Read.java | 2 +-
accord-core/src/main/java/accord/api/Write.java| 2 +-
.../src/main/java/accord/topology/KeyRanges.java | 48 ++
.../src/main/java/accord/topology/Shard.java | 13 +-
.../src/main/java/accord/topology/Shards.java | 16 +-
.../src/main/java/accord/topology/Topology.java| 118 +--
accord-core/src/main/java/accord/txn/Keys.java | 62 ++--
accord-core/src/main/java/accord/txn/Txn.java | 14 +-
accord-core/src/main/java/accord/txn/Writes.java | 2 +-
.../src/main/java/accord/utils/KeyRange.java | 20 ---
.../src/test/java/accord/impl/IntHashKey.java | 19 ++-
accord-core/src/test/java/accord/impl/IntKey.java | 43 +-
.../src/test/java/accord/impl/TopologyFactory.java | 4 +-
.../src/test/java/accord/impl/list/ListRead.java | 14 +-
.../src/test/java/accord/impl/list/ListWrite.java | 8 +-
.../test/java/accord/impl/mock/MockCluster.java| 5 +-
.../src/test/java/accord/impl/mock/MockStore.java | 4 +-
.../test/java/accord/topology/TopologyTest.java| 77 ++
.../src/test/java/accord/utils/KeyRangeTest.java | 150 +++
.../src/test/java/accord/utils/KeyRangesTest.java | 31
.../main/java/accord/maelstrom/MaelstromKey.java | 9 ++
.../main/java/accord/maelstrom/MaelstromRead.java | 14 +-
.../main/java/accord/maelstrom/MaelstromWrite.java | 8 +-
.../java/accord/maelstrom/TopologyFactory.java | 19 ++-
25 files changed, 644 insertions(+), 221 deletions(-)
diff --git a/accord-core/src/main/java/accord/api/KeyRange.java
b/accord-core/src/main/java/accord/api/KeyRange.java
new file mode 100644
index 000..9e6b850
--- /dev/null
+++ b/accord-core/src/main/java/accord/api/KeyRange.java
@@ -0,0 +1,163 @@
+package accord.api;
+
+import accord.txn.Keys;
+import com.google.common.base.Preconditions;
+
+import java.util.Objects;
+
+/**
+ * A range of keys
+ * @param
+ */
+public abstract class KeyRange>
+{
+public static abstract class EndInclusive> extends
KeyRange
+{
+public EndInclusive(K start, K end)
+{
+super(start, end);
+}
+
+@Override
+public int compareKey(K key)
+{
+if (key.compareTo(start()) <= 0)
+return -1;
+if (key.compareTo(end()) > 0)
+return 1;
+return 0;
+}
+
+@Override
+public boolean startInclusive()
+{
+return false;
+}
+
+@Override
+public boolean endInclusive()
+{
+return true;
+}
+}
+
+public static abstract class StartInclusive> extends
KeyRange
+{
+public StartInclusive(K start, K end)
+{
+super(start, end);
+}
+
+@Override
+public int compareKey(K key)
+{
+if (key.compareTo(start()) < 0)
+return -1;
+if (key.compareTo(end()) >= 0)
+return 1;
+return 0;
+}
+
+@Override
+public boolean startInclusive()
+{
+return true;
+}
+
+@Override
+public boolean endInclusive()
+{
+return false;
+}
+}
+
+private final K start;
+private final K end;
+
+private KeyRange(K start, K end)
+{
+Preconditions.checkArgument(start.compareTo(end) < 0);
+this.start = start;
+this.end = end;
+}
+
+public final K start()
+{
+return start;
+}
+
+public final K end()
+{
+return end;
+}
+
+public abstract boolean startInclusive();
+
+public abstract boolean endInclusive();
+
+@Override
+public boolean equals(Object o)
+{
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+KeyRange that = (KeyRange) o;
+return Objects.equals(start, that.start) && Objects.equals(end,
that.end);
+}
+
+@Override
+public int hashCode()
+{
+return Objects.hash(start, end);
+}
+
+@Override
+public String toString()
+{
+return "Range[" + start + ", " + end + ']';
+}
+
+/**
+ * Returns a negative integer, zero, or a positive integer as the provided
key is less than, contained by,
+ * or greater than this range.
+ */
+public abstract int compareKey(K key);
+
+public boolean containsKey(K key)
+{
+return compareKey(key) == 0;
[jira] [Commented] (CASSANDRA-17050) Upgrade tests fail with InvocationTargetException
[ https://issues.apache.org/jira/browse/CASSANDRA-17050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435931#comment-17435931 ] Benedict Elliott Smith commented on CASSANDRA-17050: I just wonder if we should consider nested git repositories containing the library code, or some other approach to reduce the friction. This will become more acute over time as Accord will want to use the utilities from Cassandra (so that it's consistent with it), so we might end up with three or more projects that are dependencies for building Cassandra, so it feels like we should aim to support them all within the same IDE and commit flow. I guess I should raise a DISCUSS thread about it. > Upgrade tests fail with InvocationTargetException > - > > Key: CASSANDRA-17050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17050 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Urgent > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > Upgrade tests are currently failing due to the new dtest-api changes and > their integration with trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17050) Upgrade tests fail with InvocationTargetException
[ https://issues.apache.org/jira/browse/CASSANDRA-17050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435930#comment-17435930 ] Michael Semb Wever commented on CASSANDRA-17050: bq. So is the idea that we'll merge with a SNAPSHOT dependency, or that we'll first release dtest-api? That we'll first release dtest-api. I know it's not ideal, we can revisit this, though one can say it fits into a stable trunk practice, but it is overhead… > Upgrade tests fail with InvocationTargetException > - > > Key: CASSANDRA-17050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17050 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Urgent > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > Upgrade tests are currently failing due to the new dtest-api changes and > their integration with trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch trunk updated (e283e1a -> 7253659)
This is an automated email from the ASF dual-hosted git repository. benedict pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. from e283e1a Update CHANGES.txt new 8c07c70 17050 - fix UnsupportedOperationException new 7253659 17064 - support blank gossip The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 2 +- src/main/java/org/apache/cassandra/distributed/api/Feature.java | 2 +- .../java/org/apache/cassandra/distributed/api/IInstanceInitializer.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] 01/02: 17050 - fix UnsupportedOperationException
This is an automated email from the ASF dual-hosted git repository.
benedict pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git
commit 8c07c7045852356d4da8da0db2f7646e7da06496
Author: Benedict Elliott Smith
AuthorDate: Mon Oct 25 13:37:31 2021 +0100
17050 - fix UnsupportedOperationException
---
pom.xml | 2 +-
.../java/org/apache/cassandra/distributed/api/IInstanceInitializer.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index a1ff2f8..c0b8efc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -27,7 +27,7 @@
4.0.0
org.apache.cassandra
dtest-api
-0.0.10-SNAPSHOT
+0.0.11-SNAPSHOT
In JVM Test API
In JVM Test API
diff --git
a/src/main/java/org/apache/cassandra/distributed/api/IInstanceInitializer.java
b/src/main/java/org/apache/cassandra/distributed/api/IInstanceInitializer.java
index 5acc067..eebaea4 100644
---
a/src/main/java/org/apache/cassandra/distributed/api/IInstanceInitializer.java
+++
b/src/main/java/org/apache/cassandra/distributed/api/IInstanceInitializer.java
@@ -20,7 +20,7 @@ package org.apache.cassandra.distributed.api;
public interface IInstanceInitializer
{
-default void initialise(ClassLoader classLoader, int num) { throw new
UnsupportedOperationException(); }
+default void initialise(ClassLoader classLoader, int num) {
initialise(classLoader, null, num, 1); }
void initialise(ClassLoader classLoader, ThreadGroup threadGroup, int num,
int generation);
default void beforeStartup(IInstance instance) {}
default void afterStartup(IInstance instance) {}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] 02/02: 17064 - support blank gossip
This is an automated email from the ASF dual-hosted git repository.
benedict pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git
commit 7253659507f247aaf8f03a9dd75cc9c9054a7d28
Author: Benedict Elliott Smith
AuthorDate: Mon Oct 25 13:51:47 2021 +0100
17064 - support blank gossip
---
src/main/java/org/apache/cassandra/distributed/api/Feature.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/cassandra/distributed/api/Feature.java
b/src/main/java/org/apache/cassandra/distributed/api/Feature.java
index b4ba036..6ba4a43 100644
--- a/src/main/java/org/apache/cassandra/distributed/api/Feature.java
+++ b/src/main/java/org/apache/cassandra/distributed/api/Feature.java
@@ -20,5 +20,5 @@ package org.apache.cassandra.distributed.api;
public enum Feature
{
-NETWORK, GOSSIP, NATIVE_PROTOCOL
+NETWORK, GOSSIP, NATIVE_PROTOCOL, BLANK_GOSSIP
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17050) Upgrade tests fail with InvocationTargetException
[ https://issues.apache.org/jira/browse/CASSANDRA-17050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435928#comment-17435928 ] Benedict Elliott Smith commented on CASSANDRA-17050: So is the idea that we'll merge with a SNAPSHOT dependency, or that we'll first release dtest-api? I can look into modifying build.xml to use different dependencies for release, though we end up in a weird release chain where we cannot release cassandra without first releasing dtest-api (and any other dependencies). I'll merge dtest-api changes for now anyway, thanks. > Upgrade tests fail with InvocationTargetException > - > > Key: CASSANDRA-17050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17050 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Urgent > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > Upgrade tests are currently failing due to the new dtest-api changes and > their integration with trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17071) Relax schema synchronization when opening a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-17071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-17071: -- Description: Extracted this as a separate ticket per discussion on CASSANDRA-17044 In short, there are two purposes of this change: # Move the code around to the more appropriate places (for example, CFS specific code for dropping table was moved from SM class to CFS class) # Relax the synchronization when adding/removing keyspace instances in SM - instead of synchronizing the whole collection of keyspace instances, we only synchronize the related item (the original idea authored by [~blambov]). The current implementation works because a certain order of opening keyspaces is assumed. If a keyspace is already initialized, it is just returned without sync and sync is done only to initialize the keyspace. When synchronization is extended to the whole method, the system finds itself in a deadlock. This means that some keyspace is tried to be opened during initiazation. Currently it works fine because the keyspace which is not initialized yet is never tried to be opened asynchronously while initializing some other keyspace in a different thread. Hence the conclusion about fragility of the current solution. was: Extracted this as a separate ticket per discussion on CASSANDRA-17044 In short, there are two purposes of this change: # Move the code around to the more appropriate places (for example, CFS specific code for dropping table was moved from SM class to CFS class) # Relax the synchronization when adding/removing keyspace instances in SM - instead of synchronizing the whole collection of keyspace instances, we only synchronize the related item (the original idea authored by [~blambov]) > Relax schema synchronization when opening a keyspace > > > Key: CASSANDRA-17071 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17071 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > Extracted this as a separate ticket per discussion on CASSANDRA-17044 > In short, there are two purposes of this change: > # Move the code around to the more appropriate places (for example, CFS > specific code for dropping table was moved from SM class to CFS class) > # Relax the synchronization when adding/removing keyspace instances in SM - > instead of synchronizing the whole collection of keyspace instances, we only > synchronize the related item (the original idea authored by [~blambov]). > The current implementation works because a certain order of opening keyspaces > is assumed. If a keyspace is already initialized, it is just returned without > sync and sync is done only to initialize the keyspace. When synchronization > is extended to the whole method, the system finds itself in a deadlock. This > means that some keyspace is tried to be opened during initiazation. Currently > it works fine because the keyspace which is not initialized yet is never > tried to be opened asynchronously while initializing some other keyspace in a > different thread. Hence the conclusion about fragility of the current > solution. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435921#comment-17435921
]
Berenguer Blasi edited comment on CASSANDRA-17070 at 10/29/21, 10:46 AM:
-
They didn't fail sort to speak... They show the 13200 passed tests with no
_test_ failures. It failed the run bc of the wilcard. It is easy to remove the
noise by switching to {{test}} instead of {{testsome}}.
Removing the cleanup logic breaks the {{CQLTester}} teardown when it tries to
drop tables that have attached MVs. So I want to give that a thought...
was (Author: bereng):
They didn't fail sort to speak... They show the 13200 passed tests with no
_test_ failures. It failed the run bc of the wilcard. It is easy to fix it by
switching to {{test}} instead of {{testsome}}.
Removing the cleanup logic breaks the {{CQLTester}} teardown when it tries to
drop tables that have attached MVs. So I want to give that a thought...
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435921#comment-17435921
]
Berenguer Blasi commented on CASSANDRA-17070:
-
They didn't fail sort to speak... They show the 13200 passed tests with no
_test_ failures. It failed the run bc of the wilcard. It is easy to fix it by
switching to {{test}} instead of {{testsome}}.
Removing the cleanup logic breaks the {{CQLTester}} teardown when it tries to
drop tables that have attached MVs. So I want to give that a thought...
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435885#comment-17435885
]
Andres de la Peña commented on CASSANDRA-17070:
---
It seems that the multiplexer runs have failed due to the wildcard. I think it
would work if we use {{ant test}} instead of {{ant testsome}}, with the
unqualified class name:
{code}
.circleci/generate.sh -m \
-e REPEATED_UTEST_TARGET=test \
-e REPEATED_UTEST_COUNT=500 \
-e REPEATED_UTEST_CLASS=ViewComplex*Test
{code}
The wildcard is a great idea, it would have saved me time with the above runs :)
I think we can try some more runs without the duplicated cleanup logic and see
how it goes, wdyt?
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435885#comment-17435885
]
Andres de la Peña edited comment on CASSANDRA-17070 at 10/29/21, 10:24 AM:
---
It seems that the multiplexer runs in the PR have failed due to the wildcard. I
think it would work if we use {{ant test}} instead of {{ant testsome}}, with
the unqualified class name:
{code:java}
.circleci/generate.sh -m \
-e REPEATED_UTEST_TARGET=test \
-e REPEATED_UTEST_COUNT=500 \
-e REPEATED_UTEST_CLASS=ViewComplex*Test
{code}
The wildcard is a great idea, it would have saved me time with the above runs :)
I think we can try some more runs without the duplicated cleanup logic and see
how it goes, wdyt?
was (Author: adelapena):
It seems that the multiplexer runs have failed due to the wildcard. I think it
would work if we use {{ant test}} instead of {{ant testsome}}, with the
unqualified class name:
{code}
.circleci/generate.sh -m \
-e REPEATED_UTEST_TARGET=test \
-e REPEATED_UTEST_COUNT=500 \
-e REPEATED_UTEST_CLASS=ViewComplex*Test
{code}
The wildcard is a great idea, it would have saved me time with the above runs :)
I think we can try some more runs without the duplicated cleanup logic and see
how it goes, wdyt?
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435840#comment-17435840
]
Berenguer Blasi edited comment on CASSANDRA-17070 at 10/29/21, 8:14 AM:
[~adelapena] the reason to run that code twice was that the test keeps a list
of the views. So if a cleanup failed the next one would pick up from the
failing point
But +1 to the abstract class and unique MV name. I ported your changes to my PR
but: I deleted the extra cleanup which is not needed anymore, I changed the
config to run {{ViewComplex*Test}} instead of having one commit per repeat test
and I attached results to the PR with 100 repeats and 0 failures
(CASSANDRA-17083).
I am only on the fence about the cleanup logic, which we could remove now there
are unique MV names, but on the other hand it's nice to have it. I think I am
+1 on how things are right now. Wdyt?
was (Author: bereng):
[~adelapena] the reason to run that code twice was that the test keeps a list
of the views. So if a cleanup failed the next one would pick up from the
failing point
But +1 to the abstract class and unique MV name. I ported your changes to my PR
but: I deleted the extra cleanup which is not needed anymore, I changed the
config to run {{ViewComplex*Test}} instead of having one commit per repeat test
and I attached results to the PR with 100 repeats and 0 failures.
I am only on the fence about the cleanup logic, which we could remove now there
are unique MV names, but on the other hand it's nice to have it. I think I am
+1 on how things are right now. Wdyt?
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17083) testsome target doesn't work with wildcards
[
https://issues.apache.org/jira/browse/CASSANDRA-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17083:
Fix Version/s: 4.x
4.0.x
3.11.x
> testsome target doesn't work with wildcards
> ---
>
> Key: CASSANDRA-17083
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17083
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 3.11.x, 4.0.x, 4.x
>
>
> Running {{ant test -Dtest.name=PasswordObfuscator*Test}} runs the test
> correctly. But {{ant testsome -Dtest.name=PasswordObfuscator*Test}} will make
> it fail like
> {noformat}
> [junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
> [junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec
> [junit-timeout]
> [junit-timeout] Testsuite: PasswordObfuscator*Test
> [junit-timeout] Testsuite: PasswordObfuscator*Test Tests run: 1, Failures: 0,
> Errors: 1, Skipped: 0, Time elapsed: 0 sec
> [junit-timeout]
> [junit-timeout] Null Test:Caused an ERROR
> [junit-timeout] PasswordObfuscator*Test
> [junit-timeout] java.lang.ClassNotFoundException: PasswordObfuscator*Test
> [junit-timeout] at
> java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> [junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> [junit-timeout] at
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> [junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> [junit-timeout] at java.lang.Class.forName0(Native Method)
> [junit-timeout] at java.lang.Class.forName(Class.java:348)
> [junit-timeout]
> [junit-timeout]
> [junit-timeout] Test PasswordObfuscator*Test FAILED
> {noformat}
> We should fix testsome as this is a useful feature for 'families' of tests
> such as {{ViewComplex*Test}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17083) testsome target doesn't work with wildcards
[
https://issues.apache.org/jira/browse/CASSANDRA-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17083:
Bug Category: Parent values: Correctness(12982)
Complexity: Low Hanging Fruit
Discovered By: User Report
Severity: Low
Status: Open (was: Triage Needed)
> testsome target doesn't work with wildcards
> ---
>
> Key: CASSANDRA-17083
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17083
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> Running {{ant test -Dtest.name=PasswordObfuscator*Test}} runs the test
> correctly. But {{ant testsome -Dtest.name=PasswordObfuscator*Test}} will make
> it fail like
> {noformat}
> [junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
> [junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec
> [junit-timeout]
> [junit-timeout] Testsuite: PasswordObfuscator*Test
> [junit-timeout] Testsuite: PasswordObfuscator*Test Tests run: 1, Failures: 0,
> Errors: 1, Skipped: 0, Time elapsed: 0 sec
> [junit-timeout]
> [junit-timeout] Null Test:Caused an ERROR
> [junit-timeout] PasswordObfuscator*Test
> [junit-timeout] java.lang.ClassNotFoundException: PasswordObfuscator*Test
> [junit-timeout] at
> java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> [junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> [junit-timeout] at
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> [junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> [junit-timeout] at java.lang.Class.forName0(Native Method)
> [junit-timeout] at java.lang.Class.forName(Class.java:348)
> [junit-timeout]
> [junit-timeout]
> [junit-timeout] Test PasswordObfuscator*Test FAILED
> {noformat}
> We should fix testsome as this is a useful feature for 'families' of tests
> such as {{ViewComplex*Test}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17083) testsome target doesn't work with wildcards
[
https://issues.apache.org/jira/browse/CASSANDRA-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17083:
Description:
Running {{ant test -Dtest.name=PasswordObfuscator*Test}} runs the test
correctly. But {{ant testsome -Dtest.name=PasswordObfuscator*Test}} will make
it fail like
{noformat}
[junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
[junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec
[junit-timeout]
[junit-timeout] Testsuite: PasswordObfuscator*Test
[junit-timeout] Testsuite: PasswordObfuscator*Test Tests run: 1, Failures: 0,
Errors: 1, Skipped: 0, Time elapsed: 0 sec
[junit-timeout]
[junit-timeout] Null Test: Caused an ERROR
[junit-timeout] PasswordObfuscator*Test
[junit-timeout] java.lang.ClassNotFoundException: PasswordObfuscator*Test
[junit-timeout] at
java.net.URLClassLoader.findClass(URLClassLoader.java:382)
[junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
[junit-timeout] at
sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
[junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
[junit-timeout] at java.lang.Class.forName0(Native Method)
[junit-timeout] at java.lang.Class.forName(Class.java:348)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test PasswordObfuscator*Test FAILED
{noformat}
We should fix testsome as this is a useful feature for 'families' of tests such
as {{ViewComplex*Test}}
> testsome target doesn't work with wildcards
> ---
>
> Key: CASSANDRA-17083
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17083
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> Running {{ant test -Dtest.name=PasswordObfuscator*Test}} runs the test
> correctly. But {{ant testsome -Dtest.name=PasswordObfuscator*Test}} will make
> it fail like
> {noformat}
> [junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
> [junit-timeout] Testsuite: org.apache.cassandra.cql3.PasswordObfuscatorTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec
> [junit-timeout]
> [junit-timeout] Testsuite: PasswordObfuscator*Test
> [junit-timeout] Testsuite: PasswordObfuscator*Test Tests run: 1, Failures: 0,
> Errors: 1, Skipped: 0, Time elapsed: 0 sec
> [junit-timeout]
> [junit-timeout] Null Test:Caused an ERROR
> [junit-timeout] PasswordObfuscator*Test
> [junit-timeout] java.lang.ClassNotFoundException: PasswordObfuscator*Test
> [junit-timeout] at
> java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> [junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> [junit-timeout] at
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> [junit-timeout] at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> [junit-timeout] at java.lang.Class.forName0(Native Method)
> [junit-timeout] at java.lang.Class.forName(Class.java:348)
> [junit-timeout]
> [junit-timeout]
> [junit-timeout] Test PasswordObfuscator*Test FAILED
> {noformat}
> We should fix testsome as this is a useful feature for 'families' of tests
> such as {{ViewComplex*Test}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17083) testsome target doesn't work with wildcards
[ https://issues.apache.org/jira/browse/CASSANDRA-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17083: Labels: low-hanging-fruit (was: ) > testsome target doesn't work with wildcards > --- > > Key: CASSANDRA-17083 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17083 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Berenguer Blasi >Priority: Normal > Labels: low-hanging-fruit > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17083) testsome target doesn't work with wildcards
[ https://issues.apache.org/jira/browse/CASSANDRA-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17083: Component/s: Build > testsome target doesn't work with wildcards > --- > > Key: CASSANDRA-17083 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17083 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Berenguer Blasi >Priority: Normal > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17083) testsome target doesn't work with wildcards
Berenguer Blasi created CASSANDRA-17083: --- Summary: testsome target doesn't work with wildcards Key: CASSANDRA-17083 URL: https://issues.apache.org/jira/browse/CASSANDRA-17083 Project: Cassandra Issue Type: Bug Reporter: Berenguer Blasi -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435840#comment-17435840
]
Berenguer Blasi edited comment on CASSANDRA-17070 at 10/29/21, 8:07 AM:
[~adelapena] the reason to run that code twice was that the test keeps a list
of the views. So if a cleanup failed the next one would pick up from the
failing point
But +1 to the abstract class and unique MV name. I ported your changes to my PR
but: I deleted the extra cleanup which is not needed anymore, I changed the
config to run {{ViewComplex*Test}} instead of having one commit per repeat test
and I attached results to the PR with 100 repeats and 0 failures.
I am only on the fence about the cleanup logic, which we could remove now there
are unique MV names, but on the other hand it's nice to have it. I think I am
+1 on how things are right now. Wdyt?
was (Author: bereng):
[~adelapena] the reason to run that code twice was that the test keeps a list
of the views. So if a cleanup failed the next one would pick up from the
failing point
But +1 to the abstract class and unique MV name. I ported your changes to my PR
but: I deleted the extra cleanup which is not needed anymore, I changed the
config to run {{ViewComplex*Test}} instead of having one commit per repeat test
and I attached results to the PR.
I am only on the fence about the cleanup logic, which we could remove now there
are unique MV names, but on the other hand it's nice to have it. I think I am
+1 on how things are right now. Wdyt?
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17070) ViewComplexTest hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435840#comment-17435840
]
Berenguer Blasi commented on CASSANDRA-17070:
-
[~adelapena] the reason to run that code twice was that the test keeps a list
of the views. So if a cleanup failed the next one would pick up from the
failing point
But +1 to the abstract class and unique MV name. I ported your changes to my PR
but: I deleted the extra cleanup which is not needed anymore, I changed the
config to run {{ViewComplex*Test}} instead of having one commit per repeat test
and I attached results to the PR.
I am only on the fence about the cleanup logic, which we could remove now there
are unique MV names, but on the other hand it's nice to have it. I think I am
+1 on how things are right now. Wdyt?
> ViewComplexTest hardening
> -
>
> Key: CASSANDRA-17070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout
> on test method teardown. This leaves a dirty env behind triggering the
> following test methods to fail on it. This ticket aims at hardening them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435837#comment-17435837
]
Berenguer Blasi commented on CASSANDRA-16801:
-
Oh well maybe sbdy has a better suggestion, let's wait and see what feedback
comes.
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435833#comment-17435833
]
Stefan Miklosovic commented on CASSANDRA-16801:
---
Honestly I dont remember the details. I saw it there too in RoleOptions but I
was trying to do it somehow without introducing that interface or so ... So
congrats on figuring that out :)
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435829#comment-17435829
]
Berenguer Blasi commented on CASSANDRA-16801:
-
I must be missing sthg here. Antlr already parses the password into a DTO. And
the attached PR does not delete everything after the password. It only
obfuscates the password itself leaving the rest of the CQL intact.
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435823#comment-17435823
]
Stefan Miklosovic edited comment on CASSANDRA-16801 at 10/29/21, 7:35 AM:
--
It would be ideal to see a progress towards antlr solution. Due to the
complexity of this seemingly easy task and being short of time to do that
before 4.0.0 we just went with solution Brandon mentioned. This "brutal"
approach of deleting everything after PASSWORD was done on purpose.
was (Author: stefan.miklosovic):
It would be ideal to see a progress towards antlr solution. Due to the
complexity of this seemingly easy task and being short of time to do that
before 4.0.0 we just went with solution Brandon mentioned.
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16801) PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
[
https://issues.apache.org/jira/browse/CASSANDRA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435823#comment-17435823
]
Stefan Miklosovic commented on CASSANDRA-16801:
---
It would be ideal to see a progress towards antlr solution. Due to the
complexity of this seemingly easy task and being short of time to do that
before 4.0.0 we just went with solution Brandon mentioned.
> PasswordObfuscator should not assume PASSWORD is the last item in the WITH
> clause
> -
>
> Key: CASSANDRA-16801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16801
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/auditlogging
>Reporter: Caleb Rackliffe
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> CASSANDRA-16669 introduced support for obfuscating passwords for audit log
> statements, but there are a few cases where the obfuscation logic can destroy
> some of the contents of the original/provided string.
> ex. This is perfectly valid...
> {noformat}
> WITH LOGIN = false AND PASSWORD = 'bar' AND SUPERUSER = false
> {noformat}
> ...but calling obfuscate() on it will produce...
> {noformat}
> WITH LOGIN = false AND PASSWORD ***
> {noformat}
> -We should be able to create a reasonable RegEx and use String#replaceAll()
> to both simplify and correct PasswordObfuscator#obfuscate().-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17071) Relax schema synchronization when opening a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-17071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-17071: -- Change Category: Performance Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Relax schema synchronization when opening a keyspace > > > Key: CASSANDRA-17071 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17071 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > Extracted this as a separate ticket per discussion on CASSANDRA-17044 > In short, there are two purposes of this change: > # Move the code around to the more appropriate places (for example, CFS > specific code for dropping table was moved from SM class to CFS class) > # Relax the synchronization when adding/removing keyspace instances in SM - > instead of synchronizing the whole collection of keyspace instances, we only > synchronize the related item (the original idea authored by [~blambov]) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17074) Remove custom Duration object and refactor its usages to use Duration from Java
[ https://issues.apache.org/jira/browse/CASSANDRA-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435820#comment-17435820 ] Jacek Lewandowski commented on CASSANDRA-17074: --- This probably needs to be discussed in CASSANDRA-15234 > Remove custom Duration object and refactor its usages to use Duration from > Java > --- > > Key: CASSANDRA-17074 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17074 > Project: Cassandra > Issue Type: Task > Components: Local/Other >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1 > > > Extracted this as a separate ticket per discussion on CASSANDRA-17044 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
