[jira] [Comment Edited] (CASSANDRA-15234) Standardise config and JVM parameters
[ https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447181#comment-17447181 ] Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 11/22/21, 3:58 AM: [~dcapwell],[~blerer], submitting for new round of review. I have some issue that I can't always trigger to get the newest version I push to ccm. Still it seems Jenkins has more success than CircleCI. Until I figure it out, these are the patches for initial round of review. [trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:CASSANDRA-15234-take2?expand=1] | [dtest|https://github.com/ekaterinadimitrova2/cassandra-dtest/pull/new/CASSANDRA-15234-take2] | [ccm|https://github.com/ekaterinadimitrova2/ccm/pull/new/CASSANDRA-15234] I cleaned all tests without full Jenkins confirmation of the dtests yet due to the ccm issue mentioned. Also, this patch latest rebase was also a week ago and I will rebase again when I have to do next round of review changes and I fix ccm as otherwise on every rebase something new appears as trunk is quite alive and the config is all over the place. Let me first stabilize CI and we can agree on the patch, then I will clean this. Now a few important comments: * ASCII doc migration is still not done but I will open a ticket to add docs for us for adding new config and docs for our users around the new and old types and names. * DTests were not updated to the new names and format as this will take forever. Suggestion - leave the old ones and add new tests with new ones. We can also open a follow up ticket but now this exercises the backward compatibility which is good as this is also how I figured out one more change needed for CCM. * CCM was updated to be able to handle the backward compatibility and Cassandra behavior. * I suggest not to overwhelm the patch with the reorganization of cassandra.yaml I suggested earlier on this ticket. I will pull it in a separate one and I can trigger a new discuss thread on the mailing list to confirm that. * Converter was not changed to an enum because we need generics support for that and [JEP301|http://openjdk.java.net/jeps/301] was withdrawn. * Intentionally left the commits after the old patch not squashed to provide some input and hopefully make the review a bit more easy. [~blerer] and [~dcapwell] , please, let me know if you want them in a different way for the review. * Now when 4.0 was released I had to add also Virtual Table backward compatibility and the easiest way was just to have the old names and types and the new ones both listed in the Settings table. * commitlog_sync_batch_in_ms was left for another ticket as the in-jvm upgrade tests will need work to make it possible to support it due to their nature as it seems we have the lower branch DatabaseDescriptor class loaded and it makes checks on trunk and complains if we change to the custom type. * Any new parameters added post 4.0 in trunk were/will be directly changed to support the new format as they are still not in any release. * CCM_41_YAML_OPTIONS in ccm should be well documented and people warned that they need to keep it up to date on changes in config. I hope we won't need this to happen a lot after this update but we need to ensure people are aware of it. It seems a bit clumsy but I didn't find a better way to handle ccm at this point. Open for ideas. * I can think of adding some additional test for the virtual table. * I also suggest we add a warning to the users when they start Cassandra that if they add more than once a property (even if it is the old name), the latest occurrence from the yaml file will appear. I would say we add also to the docs and we don't complicate to add checks whether we have or not more occurrences and on occurrences adding it as it seems a bit too much overhead on startup. WDYT? * There were deprecation warnings emitted more than once. I fixed this. This fix should be also ported to 4.0 where we had to make small port of the name change because of two parameters issues. (FTR - CASSANDRA-17141) was (Author: e.dimitrova): I have some issue that I can't always trigger to get the newest version I push to ccm. Still it seems Jenkins has more success than CircleCI. Until I figure it out, these are the patches for initial round of review. [trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:CASSANDRA-15234-take2?expand=1] | [dtest|https://github.com/ekaterinadimitrova2/cassandra-dtest/pull/new/CASSANDRA-15234-take2] | [ccm|https://github.com/ekaterinadimitrova2/ccm/pull/new/CASSANDRA-15234] I cleaned all tests without full Jenkins confirmation of the dtests yet due to the ccm issue mentioned. Also, this patch latest rebase was also a week ago and I will rebase again when I have to do next round of review
[jira] [Updated] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15234:
Test and Documentation Plan:
[trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:CASSANDRA-15234-take2?expand=1]
|
[dtest|https://github.com/ekaterinadimitrova2/cassandra-dtest/pull/new/CASSANDRA-15234-take2]
| [ccm|https://github.com/ekaterinadimitrova2/ccm/pull/new/CASSANDRA-15234]
The existing tests plus new unit tests added. Also, dtests exercise the
backward compatibility and test that way that ccm supports the same behavior as
Cassandra as regards to configuration parameters loading.
was:https://issues.apache.org/jira/browse/CASSANDRA-15234?focusedCommentId=17126974=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17126974
Status: Patch Available (was: In Progress)
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15234) Standardise config and JVM parameters
[ https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447181#comment-17447181 ] Ekaterina Dimitrova commented on CASSANDRA-15234: - I have some issue that I can't always trigger to get the newest version I push to ccm. Still it seems Jenkins has more success than CircleCI. Until I figure it out, these are the patches for initial round of review. [trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:CASSANDRA-15234-take2?expand=1] | [dtest|https://github.com/ekaterinadimitrova2/cassandra-dtest/pull/new/CASSANDRA-15234-take2] | [ccm|https://github.com/ekaterinadimitrova2/ccm/pull/new/CASSANDRA-15234] I cleaned all tests without full Jenkins confirmation of the dtests yet due to the ccm issue mentioned. Also, this patch latest rebase was also a week ago and I will rebase again when I have to do next round of review changes and I fix ccm as otherwise on every rebase something new appears as trunk is quite alive and the config is all over the place. Let me first stabilize CI and we can agree on the patch, then I will clean this. Now a few important comments: * ASCII doc migration is still not done but I will open a ticket to add docs for us for adding new config and docs for our users around the new and old types and names. * DTests were not updated to the new names and format as this will take forever. Suggestion - leave the old ones and add new tests with new ones. We can also open a follow up ticket but now this exercises the backward compatibility which is good as this is also how I figured out one more change needed for CCM. * CCM was updated to be able to handle the backward compatibility and Cassandra behavior. * I suggest not to overwhelm the patch with the reorganization of cassandra.yaml I suggested earlier on this ticket. I will pull it in a separate one and I can trigger a new discuss thread on the mailing list to confirm that. * Converter was not changed to an enum because we need generics support for that and [JEP301|http://openjdk.java.net/jeps/301] was withdrawn. * Intentionally left the commits after the old patch not squashed to provide some input and hopefully make the review a bit more easy. [~blerer] and [~dcapwell] , please, let me know if you want them in a different way for the review. * Now when 4.0 was released I had to add also Virtual Table backward compatibility and the easiest way was just to have the old names and types and the new ones both listed in the Settings table. * commitlog_sync_batch_in_ms was left for another ticket as the in-jvm upgrade tests will need work to make it possible to support it due to their nature as it seems we have the lower branch DatabaseDescriptor class loaded and it makes checks on trunk and complains if we change to the custom type. * Any new parameters added post 4.0 in trunk were/will be directly changed to support the new format as they are still not in any release. * CCM_41_YAML_OPTIONS in ccm should be well documented and people warned that they need to keep it up to date on changes in config. I hope we won't need this to happen a lot after this update but we need to ensure people are aware of it. It seems a bit clumsy but I didn't find a better way to handle ccm at this point. Open for ideas. * I can think of adding some additional test for the virtual table. * I also suggest we add a warning to the users when they start Cassandra that if they add more than once a property (even if it is the old name), the latest occurrence from the yaml file will appear. I would say we add also to the docs and we don't complicate to add checks whether we have or not more occurrences and on occurrences adding it as it seems a bit too much overhead on startup. WDYT? * There were deprecation warnings emitted more than once. I fixed this. This fix should be also ported to 4.0 where we had to make small port of the name change because of two parameters issues. (FTR - CASSANDRA-17141) > Standardise config and JVM parameters > - > > Key: CASSANDRA-15234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15234 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Benedict Elliott Smith >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt > > > We have a bunch of inconsistent names and config patterns in the codebase, > both from the yams and JVM properties. It would be nice to standardise the > naming (such as otc_ vs internode_) as well as the provision of values with > units - while maintaining perpetual backwards compatibility with the old > parameter names, of course. > For temporal units, I
[jira] [Updated] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
[
https://issues.apache.org/jira/browse/CASSANDRA-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-17129:
---
Reviewers: Brandon Williams, Michael Semb Wever (was: Michael Semb Wever)
> Classpath can be broken when multiple artifacts are present in build dir
>
>
> Key: CASSANDRA-17129
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.2, 4.1
>
>
> {noformat}
> $ ant artifacts
> $ ls -1 build/apache-cassandra-*.jar
> build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> build/apache-cassandra-4.1-SNAPSHOT.jar
> $ bin/cassandra -f
> ...
> Error: Could not find or load main class
> org.apache.cassandra.service.CassandraDaemon
> {noformat}
> Classpath is something like:
> {noformat}
> ...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
> {noformat}
> notice that:
> - javadoc and sources jars are on the classpath
> - classpath is broken because javadoc, sources and main jar are separated by
> blankspaces instead of colons
> The problem is in {{cassandra.in.sh}} where the main jar gets added to the
> classpath:
> {noformat}
> cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
[
https://issues.apache.org/jira/browse/CASSANDRA-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-17129:
---
Fix Version/s: 4.0.2
4.1
(was: 4.x)
(was: 4.0.x)
Since Version: 4.0-alpha1
Source Control Link:
https://github.com/apache/cassandra/commit/aaffb3b53ef85b1d06c3e4371230208d46effad6
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as
[aaffb3b53ef85b1d06c3e4371230208d46effad6|https://github.com/apache/cassandra/commit/aaffb3b53ef85b1d06c3e4371230208d46effad6].
> Classpath can be broken when multiple artifacts are present in build dir
>
>
> Key: CASSANDRA-17129
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.2, 4.1
>
>
> {noformat}
> $ ant artifacts
> $ ls -1 build/apache-cassandra-*.jar
> build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> build/apache-cassandra-4.1-SNAPSHOT.jar
> $ bin/cassandra -f
> ...
> Error: Could not find or load main class
> org.apache.cassandra.service.CassandraDaemon
> {noformat}
> Classpath is something like:
> {noformat}
> ...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
> {noformat}
> notice that:
> - javadoc and sources jars are on the classpath
> - classpath is broken because javadoc, sources and main jar are separated by
> blankspaces instead of colons
> The problem is in {{cassandra.in.sh}} where the main jar gets added to the
> classpath:
> {noformat}
> cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Fixed broken classpath when multiple jars in build directory
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-4.0 by this push: new aaffb3b Fixed broken classpath when multiple jars in build directory aaffb3b is described below commit aaffb3b53ef85b1d06c3e4371230208d46effad6 Author: Jacek Lewandowski AuthorDate: Tue Nov 9 09:42:27 2021 +0100 Fixed broken classpath when multiple jars in build directory Patch by Jacek Lewandowski reviewed by Michael Semb Wever and Brandon Williams for CASSANDRA-17129 --- CHANGES.txt | 1 + bin/cassandra.in.sh | 13 ++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 1d72c0f..fb9dfaf 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.0.2 + * Fixed broken classpath when multiple jars in build directory (CASSANDRA-17129) * DebuggableThreadPoolExecutor does not propagate client warnings (CASSANDRA-17072) * internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes have new names. Backward compatibility with the old names added (CASSANDRA-17141) * Remove unused configuration parameters from cassandra.yaml (CASSANDRA-17132) diff --git a/bin/cassandra.in.sh b/bin/cassandra.in.sh index 5d13cda..dcbd12d 100644 --- a/bin/cassandra.in.sh +++ b/bin/cassandra.in.sh @@ -30,10 +30,17 @@ CLASSPATH="$CASSANDRA_CONF" # compiled classes. NOTE: This isn't needed by the startup script, # it's just used here in constructing the classpath. if [ -d $CASSANDRA_HOME/build ] ; then -#cassandra_bin="$CASSANDRA_HOME/build/classes/main" -cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar` +jars_cnt="`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar | grep -v 'javadoc.jar' | grep -v 'sources.jar' | wc -l | xargs echo`" +if [ "$jars_cnt" -gt 1 ]; then +dir="`cd $CASSANDRA_HOME/build; pwd`" +echo "There are JAR artifacts for multiple versions in the $dir directory. Please clean the project with 'ant realclean' and build it again." 1>&2 +exit 1 +fi -CLASSPATH="$CLASSPATH:$cassandra_bin" +if [ "$jars_cnt" = "1" ]; then +cassandra_bin="`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar | grep -v javadoc | grep -v sources`" +CLASSPATH="$CLASSPATH:$cassandra_bin" +fi fi # the default location for commitlogs, sstables, and saved caches - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (dcd7b0d -> ed8571f)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from dcd7b0d repair prepare message would produce a wrong error message if network timeout happened rather than reply wait timeout new aaffb3b Fixed broken classpath when multiple jars in build directory new ed8571f Merge branch 'cassandra-4.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + bin/cassandra.in.sh | 13 ++--- 2 files changed, 11 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit ed8571fe6fd988976a3e7b91ecfc4077f4549c59 Merge: dcd7b0d aaffb3b Author: Mick Semb Wever AuthorDate: Sun Nov 21 19:53:19 2021 +0100 Merge branch 'cassandra-4.0' into trunk CHANGES.txt | 1 + bin/cassandra.in.sh | 13 ++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --cc CHANGES.txt index a362f78,fb9dfaf..c399c0d --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,66 -1,5 +1,67 @@@ -4.0.2 +4.1 + * repair prepare message would produce a wrong error message if network timeout happened rather than reply wait timeout (CASSANDRA-16992) + * Log queries that fail on timeout or unavailable errors up to once per minute by default (CASSANDRA-17159) + * Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs (CASSANDRA-17069) + * Log missing peers in StartupClusterConnectivityChecker (CASSANDRA-17130) + * Introduce separate rate limiting settings for entire SSTable streaming (CASSANDRA-17065) + * Implement Virtual Tables for Auth Caches (CASSANDRA-16914) + * Actively update auth cache in the background (CASSANDRA-16957) + * Add unix time conversion functions (CASSANDRA-17029) + * JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only (CASSANDRA-17128) + * Forbid other Future implementations with checkstyle (CASSANDRA-17055) + * commit log was switched from non-daemon to daemon threads, which causes the JVM to exit in some case as no non-daemon threads are active (CASSANDRA-17085) + * Add a Denylist to block reads and writes on specific partition keys (CASSANDRA-12106) + * v4+ protocol did not clean up client warnings, which caused leaking the state (CASSANDRA-17054) + * Remove duplicate toCQLString in ReadCommand (CASSANDRA-17023) + * Ensure hint window is persistent across restarts of a node (CASSANDRA-14309) + * Allow to GRANT or REVOKE multiple permissions in a single statement (CASSANDRA-17030) + * Allow to grant permission for all tables in a keyspace (CASSANDRA-17027) + * Log time spent writing keys during compaction (CASSANDRA-17037) + * Make nodetool compactionstats and sstable_tasks consistent (CASSANDRA-16976) + * Add metrics and logging around index summary redistribution (CASSANDRA-17036) + * Add configuration options for minimum allowable replication factor and default replication factor (CASSANDRA-14557) + * Expose information about stored hints via a nodetool command and a virtual table (CASSANDRA-14795) + * Add broadcast_rpc_address to system.local (CASSANDRA-11181) + * Add support for type casting in WHERE clause components and in the values of INSERT/UPDATE statements (CASSANDRA-14337) + * add credentials file support to CQLSH (CASSANDRA-16983) + * Skip remaining bytes in the Envelope buffer when a ProtocolException is thrown to avoid double decoding (CASSANDRA-17026) + * Allow reverse iteration of resources during permissions checking (CASSANDRA-17016) + * Add feature to verify correct ownership of attached locations on disk at startup (CASSANDRA-16879) + * Make SSLContext creation pluggable/extensible (CASSANDRA-1) + * Add soft/hard limits to local reads to protect against reading too much data in a single query (CASSANDRA-16896) + * Avoid token cache invalidation for removing a non-member node (CASSANDRA-15290) + * Allow configuration of consistency levels on auth operations (CASSANDRA-12988) + * Add number of sstables in a compaction to compactionstats output (CASSANDRA-16844) + * Upgrade Caffeine to 2.9.2 (CASSANDRA-15153) + * Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation allows it (CASSANDRA-16806) + * Include SASI components to snapshots (CASSANDRA-15134) + * Fix missed wait latencies in the output of `nodetool tpstats -F` (CASSANDRA-16938) + * Reduce native transport max frame size to 16MB (CASSANDRA-16886) + * Add support for filtering using IN restrictions (CASSANDRA-14344) + * Provide a nodetool command to invalidate auth caches (CASSANDRA-16404) + * Catch read repair timeout exceptions and add metric (CASSANDRA-16880) + * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies (CASSANDRA-16854) + * Add client warnings and abort to tombstone and coordinator reads which go past a low/high watermark (CASSANDRA-16850) + * Add TTL support to nodetool snapshots (CASSANDRA-16789) + * Allow CommitLogSegmentReader to optionally skip sync marker CRC checks (CASSANDRA-16842) + * allow blocking IPs from updating metrics about traffic (CASSANDRA-16859) + * Request-Based Native Transport Rate-Limiting (CASSANDRA-16663) + * Implement nodetool getauditlog command (CASSANDRA-16725) + * Clean up repair code (CASSANDRA-13720) + * Background schedule to clean up
[jira] [Updated] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
[
https://issues.apache.org/jira/browse/CASSANDRA-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-17129:
---
Status: Ready to Commit (was: Review In Progress)
> Classpath can be broken when multiple artifacts are present in build dir
>
>
> Key: CASSANDRA-17129
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> {noformat}
> $ ant artifacts
> $ ls -1 build/apache-cassandra-*.jar
> build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> build/apache-cassandra-4.1-SNAPSHOT.jar
> $ bin/cassandra -f
> ...
> Error: Could not find or load main class
> org.apache.cassandra.service.CassandraDaemon
> {noformat}
> Classpath is something like:
> {noformat}
> ...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
> {noformat}
> notice that:
> - javadoc and sources jars are on the classpath
> - classpath is broken because javadoc, sources and main jar are separated by
> blankspaces instead of colons
> The problem is in {{cassandra.in.sh}} where the main jar gets added to the
> classpath:
> {noformat}
> cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
