[cassandra-website] branch asf-staging updated (343bb38 -> bb7ba01)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git. discard 343bb38 generate docs for f87cab11 new bb7ba01 generate docs for f87cab11 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (343bb38) \ N -- N -- N refs/heads/asf-staging (bb7ba01) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../cassandra/configuration/cass_yaml_file.html| 2 +- .../cassandra/configuration/cass_yaml_file.html| 2 +- .../cassandra/configuration/cass_yaml_file.html| 2 +- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4740084 -> 4740084 bytes 5 files changed, 4 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498370#comment-17498370 ] Stefan Miklosovic commented on CASSANDRA-17220: --- https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1455 > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16378) Expose application_name and application_version in virtual table system_views.clients
[ https://issues.apache.org/jira/browse/CASSANDRA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498348#comment-17498348 ] Ekaterina Dimitrova edited comment on CASSANDRA-16378 at 2/25/22, 11:14 PM: I decided to start an instance of Cassandra to see how the table looks like now. Unfortunately, it became too wide and rows span in few rows. This will be hard to read. I need to think about it a bit more. I will continue on Monday. was (Author: e.dimitrova): I decided to start an instance of Cassandra to see how the table looks like now. Unfortunately, it became too wide and rows span in a few rows. This will be hard to read. I need to think about it a bit more. I will continue on Monday. > Expose application_name and application_version in virtual table > system_views.clients > - > > Key: CASSANDRA-16378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16378 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Virtual Tables >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Labels: AdventCalendar2021, gsoc2021, lhf, mentor > Time Spent: 2h 40m > Remaining Estimate: 0h > > Recent java-driver's > [com.datastax.oss.driver.api.core.session.SessionBuilder|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html] > respects properties > [ApplicationName|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationName-java.lang.String-] > and > [ApplicationVersion|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationVersion-java.lang.String-]. > It would be helpful to expose this information via virtual table > {{system_views.clients}} and with {{{}nodetool clientstats{}}}. > +Additional information for newcomers:+ > The drivers can send as part of the {{STARTUP MESSAGE}} the > {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options. Two new volatile > fields {{applicationName}} and {{applicationVersion}} need to be added to > {{ClientState}} in a similar way to {{driverName}} and {{{}driverVersion{}}}. > The {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options need to be > retrieved in {{StartupMessage#execute}} and passed to the > {{{}ClientState{}}}. > The new {{application_name}} and {{application_version}} columns need to be > added to the {{system_views.clients}} represented by the {{ClientsTable}} > class. The data then need to be retrieved from the {{ClientState}} through > {{{}ConnectedClient{}}}. > Some unit tests similat to {{SettingsTableTest}} should be added. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16378) Expose application_name and application_version in virtual table system_views.clients
[ https://issues.apache.org/jira/browse/CASSANDRA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498348#comment-17498348 ] Ekaterina Dimitrova commented on CASSANDRA-16378: - I decided to start an instance of Cassandra to see how the table looks like now. Unfortunately, it became too wide and rows span in a few rows. This will be hard to read. I need to think about it a bit more. I will continue on Monday. > Expose application_name and application_version in virtual table > system_views.clients > - > > Key: CASSANDRA-16378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16378 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Virtual Tables >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Labels: AdventCalendar2021, gsoc2021, lhf, mentor > Time Spent: 2h 40m > Remaining Estimate: 0h > > Recent java-driver's > [com.datastax.oss.driver.api.core.session.SessionBuilder|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html] > respects properties > [ApplicationName|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationName-java.lang.String-] > and > [ApplicationVersion|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationVersion-java.lang.String-]. > It would be helpful to expose this information via virtual table > {{system_views.clients}} and with {{{}nodetool clientstats{}}}. > +Additional information for newcomers:+ > The drivers can send as part of the {{STARTUP MESSAGE}} the > {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options. Two new volatile > fields {{applicationName}} and {{applicationVersion}} need to be added to > {{ClientState}} in a similar way to {{driverName}} and {{{}driverVersion{}}}. > The {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options need to be > retrieved in {{StartupMessage#execute}} and passed to the > {{{}ClientState{}}}. > The new {{application_name}} and {{application_version}} columns need to be > added to the {{system_views.clients}} represented by the {{ClientsTable}} > class. The data then need to be retrieved from the {{ClientState}} through > {{{}ConnectedClient{}}}. > Some unit tests similat to {{SettingsTableTest}} should be added. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Correct size unit to mebibypes
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new b83da7d Correct size unit to mebibypes b83da7d is described below commit b83da7d978f1bae5f289f1561dd080d48dc4505b Author: Yifan Cai AuthorDate: Fri Feb 25 14:38:43 2022 -0800 Correct size unit to mebibypes --- NEWS.txt | 2 +- conf/cassandra.yaml | 2 +- src/java/org/apache/cassandra/config/DatabaseDescriptor.java | 4 ++-- src/java/org/apache/cassandra/service/StorageProxy.java | 8 src/java/org/apache/cassandra/service/StorageProxyMBean.java | 4 ++-- test/unit/org/apache/cassandra/service/StorageProxyTest.java | 6 +++--- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/NEWS.txt b/NEWS.txt index f9626f1..05a6886 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -57,7 +57,7 @@ using the provided 'sstableupgrade' tool. New features - Support for String concatenation has been added through the + operator. -- New configuration max_hints_size_per_host to limit the size of local hints files per host in megabytes. Setting to +- New configuration max_hints_size_per_host to limit the size of local hints files per host in mebibytes. Setting to non-positive value disables the limit, which is the default behavior. Setting to a positive value to ensure the total size of the hints files per host does not exceed the limit. - Added ability to configure auth caches through corresponding `nodetool` commands. diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 0e21434..bb8cb28 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -86,7 +86,7 @@ hints_flush_period: 1ms # Maximum size for a single hints file, in megabytes. max_hints_file_size: 128MiB -# The file size limit to store hints for an unreachable host, in megabytes. +# The file size limit to store hints for an unreachable host, in mebibytes. # Once the local hints files have reached the limit, no more new hints will be created. # Set a non-positive value will disable the size limit. # max_hints_size_per_host: 0MiB diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index ced4ad3..af0b67a 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -2645,12 +2645,12 @@ public class DatabaseDescriptor return conf.max_hint_window.toMillisecondsAsInt(); } -public static void setMaxHintsSizePerHostInMb(int value) +public static void setMaxHintsSizePerHostInMiB(int value) { conf.max_hints_size_per_host = DataStorageSpec.inMebibytes(value); } -public static int getMaxHintsSizePerHostInMb() +public static int getMaxHintsSizePerHostInMiB() { return conf.max_hints_size_per_host.toMebibytesAsInt(); } diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/org/apache/cassandra/service/StorageProxy.java index 69c231d..a66ccc2 100644 --- a/src/java/org/apache/cassandra/service/StorageProxy.java +++ b/src/java/org/apache/cassandra/service/StorageProxy.java @@ -2275,14 +2275,14 @@ public class StorageProxy implements StorageProxyMBean DatabaseDescriptor.setMaxHintWindow(ms); } -public int getMaxHintsSizePerHostInMb() +public int getMaxHintsSizePerHostInMiB() { -return DatabaseDescriptor.getMaxHintsSizePerHostInMb(); +return DatabaseDescriptor.getMaxHintsSizePerHostInMiB(); } -public void setMaxHintsSizePerHostInMb(int value) +public void setMaxHintsSizePerHostInMiB(int value) { -DatabaseDescriptor.setMaxHintsSizePerHostInMb(value); +DatabaseDescriptor.setMaxHintsSizePerHostInMiB(value); } public static boolean shouldHint(Replica replica) diff --git a/src/java/org/apache/cassandra/service/StorageProxyMBean.java b/src/java/org/apache/cassandra/service/StorageProxyMBean.java index 7ac83ae..0f69032 100644 --- a/src/java/org/apache/cassandra/service/StorageProxyMBean.java +++ b/src/java/org/apache/cassandra/service/StorageProxyMBean.java @@ -32,8 +32,8 @@ public interface StorageProxyMBean public Set getHintedHandoffDisabledDCs(); public int getMaxHintWindow(); public void setMaxHintWindow(int ms); -public int getMaxHintsSizePerHostInMb(); -public void setMaxHintsSizePerHostInMb(int value); +public int getMaxHintsSizePerHostInMiB(); +public void setMaxHintsSizePerHostInMiB(int value); public int getMaxHintsInProgress(); public void setMaxHintsInProgress(int qs); public int getHintsInProgress(); diff --git a/test/unit/org/apache/cassandra/servi
[jira] [Commented] (CASSANDRA-17142) Limit the maximum hints size per host
[ https://issues.apache.org/jira/browse/CASSANDRA-17142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498338#comment-17498338 ] Yifan Cai commented on CASSANDRA-17142: --- Made a [ninja commit|https://github.com/apache/cassandra/commit/b83da7d978f1bae5f289f1561dd080d48dc4505b] to update the size unit from megabytes to mebibytes. > Limit the maximum hints size per host > - > > Key: CASSANDRA-17142 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17142 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Hints >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 4.1 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The hints system defines a time window, i.e. max_hint_window_in_ms, to store > the hints. > It defines no limit on how much data can be kept during the time window. The > hints can grow excessively and make the node running out of disk. In such > scenario, the operators have to truncate the hints manually. > I'd propose that in addition to the conventional hints window, operators > should be able to define the maximum hints size per host, i.e. > max_hints_size_per_host_in_mb, to provide an another layer of protection. A > node stops to store hints for the down node whenever it reaches to the time > cap or the size cap. In order to not surprise the users, the config should be > disabled by default. It should also be configurable via JMX. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498335#comment-17498335 ] Stefan Miklosovic commented on CASSANDRA-17220: --- if this will be settable via system property it will be -Dstartup_checks.dc instead of -Dstartup_checks.check_dc The former makes more sense to me. > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498335#comment-17498335 ] Stefan Miklosovic edited comment on CASSANDRA-17220 at 2/25/22, 10:34 PM: -- once this is settable via system property it will be -Dstartup_checks.dc.enabled=true instead of -Dstartup_checks.check_dc.enabled=true The former makes more sense to me. was (Author: smiklosovic): once this is settable via system property it will be -Dstartup_checks.dc instead of -Dstartup_checks.check_dc The former makes more sense to me. > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498335#comment-17498335 ] Stefan Miklosovic edited comment on CASSANDRA-17220 at 2/25/22, 10:34 PM: -- once this is settable via system property it will be -Dstartup_checks.dc instead of -Dstartup_checks.check_dc The former makes more sense to me. was (Author: smiklosovic): if this will be settable via system property it will be -Dstartup_checks.dc instead of -Dstartup_checks.check_dc The former makes more sense to me. > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17338) Fix flaky test - test_cqlsh_completion.TestCqlshCompletion
[ https://issues.apache.org/jira/browse/CASSANDRA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498315#comment-17498315 ] Aleksei Zotov commented on CASSANDRA-17338: --- No, I feel "1 of 38" is clear as well. I just misread your original message, sorry for confusion. > Fix flaky test - test_cqlsh_completion.TestCqlshCompletion > -- > > Key: CASSANDRA-17338 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17338 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Aleksei Zotov >Priority: Normal > Fix For: 3.0.27, 3.11.13 > > > Failed 4 times in the last 24 runs. Flakiness: 30%, Stability: 83% > A bunch of the test_completion_* tests fail occasionally with an eyebleed > inducing mismatched output. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16378) Expose application_name and application_version in virtual table system_views.clients
[ https://issues.apache.org/jira/browse/CASSANDRA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16378: Reviewers: Benjamin Lerer, Berenguer Blasi, Ekaterina Dimitrova (was: Benjamin Lerer, Berenguer Blasi) Status: Review In Progress (was: Needs Committer) > Expose application_name and application_version in virtual table > system_views.clients > - > > Key: CASSANDRA-16378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16378 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Virtual Tables >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Labels: AdventCalendar2021, gsoc2021, lhf, mentor > Time Spent: 2h 40m > Remaining Estimate: 0h > > Recent java-driver's > [com.datastax.oss.driver.api.core.session.SessionBuilder|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html] > respects properties > [ApplicationName|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationName-java.lang.String-] > and > [ApplicationVersion|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationVersion-java.lang.String-]. > It would be helpful to expose this information via virtual table > {{system_views.clients}} and with {{{}nodetool clientstats{}}}. > +Additional information for newcomers:+ > The drivers can send as part of the {{STARTUP MESSAGE}} the > {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options. Two new volatile > fields {{applicationName}} and {{applicationVersion}} need to be added to > {{ClientState}} in a similar way to {{driverName}} and {{{}driverVersion{}}}. > The {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options need to be > retrieved in {{StartupMessage#execute}} and passed to the > {{{}ClientState{}}}. > The new {{application_name}} and {{application_version}} columns need to be > added to the {{system_views.clients}} represented by the {{ClientsTable}} > class. The data then need to be retrieved from the {{ClientState}} through > {{{}ConnectedClient{}}}. > Some unit tests similat to {{SettingsTableTest}} should be added. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16349: Source Control Link: https://github.com/apache/cassandra/commit/193d4ef3a79305d9f19e26012c0cd79ea79d54fd and https://github.com/apache/cassandra/commit/a8b67e3dd92e6ca1a66a1be9b2d86961224653f5 DTest: https://github.com/apache/cassandra-dtest/commit/ce91388e533f402f076f24844 (was: https://github.com/apache/cassandra/commit/193d4ef3a79305d9f19e26012c0cd79ea79d54fd and https://github.com/apache/cassandra/commit/a8b67e3dd92e6ca1a66a1be9b2d86961224653f5) > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.1, 4.0.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:844) > {quote} > To reproduce create a cluster with ccm with more nodes than the RF, put some > data into it copy a SSTable and stream it. > > The error originates on the nodes, the following stack trace is shown in the > logs: > {quote}java.lang.IllegalStateException: Stream hasn't been read yet > at > com.google.common.base.Preconditions.checkState(Preconditions.java:507) > at > org.apache.cassandra.db.streaming.CassandraIncomingFile.getSize(CassandraIncomingFile.java:96)
[jira] [Updated] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16349: Since Version: 4.0.0 Source Control Link: https://github.com/apache/cassandra/commit/193d4ef3a79305d9f19e26012c0cd79ea79d54fd and https://github.com/apache/cassandra/commit/a8b67e3dd92e6ca1a66a1be9b2d86961224653f5 Resolution: Fixed Status: Resolved (was: Ready to Commit) > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.1, 4.0.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:844) > {quote} > To reproduce create a cluster with ccm with more nodes than the RF, put some > data into it copy a SSTable and stream it. > > The error originates on the nodes, the following stack trace is shown in the > logs: > {quote}java.lang.IllegalStateException: Stream hasn't been read yet > at > com.google.common.base.Preconditions.checkState(Preconditions.java:507) > at > org.apache.cassandra.db.streaming.CassandraIncomingFile.getSize(CassandraIncomingFile.java:96) > at > org.apache.cassandra.streaming.StreamSession.receive(StreamSession.java:789) > at > org.apache.cassandra.streaming.StreamSes
[jira] [Updated] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16349: Fix Version/s: 4.1 4.0.4 (was: 4.x) (was: 4.0.x) > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.1, 4.0.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:844) > {quote} > To reproduce create a cluster with ccm with more nodes than the RF, put some > data into it copy a SSTable and stream it. > > The error originates on the nodes, the following stack trace is shown in the > logs: > {quote}java.lang.IllegalStateException: Stream hasn't been read yet > at > com.google.common.base.Preconditions.checkState(Preconditions.java:507) > at > org.apache.cassandra.db.streaming.CassandraIncomingFile.getSize(CassandraIncomingFile.java:96) > at > org.apache.cassandra.streaming.StreamSession.receive(StreamSession.java:789) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:587) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.
[jira] [Commented] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498308#comment-17498308 ] Ekaterina Dimitrova commented on CASSANDRA-16349: - DTest committed: To https://github.com/apache/cassandra-dtest.git [8396b643..ce91388e trunk -> trunk|https://github.com/apache/cassandra-dtest/commit/ce91388e533f402f076f2484406d41bda8680316] 4.0 and trunk committed: To https://github.com/apache/cassandra.git 22a4ae16e4..a8b67e3dd9 cassandra-4.0 -> cassandra-4.0 12e2c159f8..e40f8163af trunk -> trunk > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:844) > {quote} > To reproduce create a cluster with ccm with more nodes than the RF, put some > data into it copy a SSTable and stream it. > > The error originates on the nodes, the following stack trace is shown in the > logs: > {quote}java.lang.IllegalStateException: Stream hasn't been read yet > at > com.google.common.base.Preconditions.checkState(Preconditions.java:507) > at > org.apache.cassandra.db.streaming.CassandraIncomingFile.getSize(CassandraIncomingFile.java:96) > at > org.apache.cassandra.stre
[cassandra-website] branch asf-staging updated (a8fd723 -> 343bb38)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git. discard a8fd723 generate docs for f87cab11 new 343bb38 generate docs for f87cab11 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a8fd723) \ N -- N -- N refs/heads/asf-staging (343bb38) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4740084 -> 4740084 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (22a4ae1 -> a8b67e3)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 22a4ae1 Deprecate JavaScript user-defined functions patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi and Marcus Eriksson for CASSANDRA-17280 add 193d4ef Prevent SSTableLoader from doing unnecessary work patch by Serban Teodorescu; reviewed by Aleksandr Sorokoumov, Marcus Eriksson and Zhao Yang for CASSANDRA-16349 add a8b67e3 Streaming tasks handle empty SSTables correctly patch by Aleksandr Sorokoumov; reviewed by Marcus Eriksson and Zhao Yang for CASSANDRA-16349 No new revisions were added by this update. Summary of changes: CHANGES.txt| 2 + .../db/streaming/CassandraIncomingFile.java| 2 +- .../apache/cassandra/io/sstable/SSTableLoader.java | 5 ++ .../io/sstable/format/RangeAwareSSTableWriter.java | 4 +- .../format/RangeAwareSSTableWriterTest.java| 91 ++ 5 files changed, 101 insertions(+), 3 deletions(-) create mode 100644 test/unit/org/apache/cassandra/io/sstable/format/RangeAwareSSTableWriterTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Fix CHANGES.txt
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit e40f8163af9dcc889b81265b17e66f36e25fc727 Author: Ekaterina Dimitrova AuthorDate: Fri Feb 25 16:07:33 2022 -0500 Fix CHANGES.txt --- CHANGES.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGES.txt b/CHANGES.txt index 663c461..de90a56 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -93,6 +93,8 @@ * GossiperTest.testHasVersion3Nodes didn't take into account trunk version changes, fixed to rely on latest version (CASSANDRA-16651) * Update JNA library to 5.9.0 and snappy-java to version 1.1.8.4 (CASSANDRA-17040) Merged from 4.0: + * Streaming tasks handle empty SSTables correctly (CASSANDRA-16349) + * Prevent SSTableLoader from doing unnecessary work (CASSANDRA-16349) * Deprecate otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, otc_backlog_expiration_interval_ms (CASSANDRA-17377) * Improve start up processing of Incremental Repair information read from system.repairs (CASSANDRA-17342) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 75bea27e5ef673ae7fcfac9007c1d39a68ab0b8c Merge: 12e2c15 a8b67e3 Author: Ekaterina Dimitrova AuthorDate: Fri Feb 25 15:47:43 2022 -0500 Merge branch 'cassandra-4.0' into trunk .../db/streaming/CassandraIncomingFile.java| 2 +- .../apache/cassandra/io/sstable/SSTableLoader.java | 5 ++ .../io/sstable/format/RangeAwareSSTableWriter.java | 4 +- .../format/RangeAwareSSTableWriterTest.java| 91 ++ 4 files changed, 99 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (12e2c15 -> e40f816)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 12e2c15 Forward port from cassandra-4.0(CASSANDRA-17377) - deprecation of otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, otc_backlog_expiration_interval_ms patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378 add 193d4ef Prevent SSTableLoader from doing unnecessary work patch by Serban Teodorescu; reviewed by Aleksandr Sorokoumov, Marcus Eriksson and Zhao Yang for CASSANDRA-16349 add a8b67e3 Streaming tasks handle empty SSTables correctly patch by Aleksandr Sorokoumov; reviewed by Marcus Eriksson and Zhao Yang for CASSANDRA-16349 new 75bea27 Merge branch 'cassandra-4.0' into trunk new e40f816 Fix CHANGES.txt The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 2 + .../db/streaming/CassandraIncomingFile.java| 2 +- .../apache/cassandra/io/sstable/SSTableLoader.java | 5 ++ .../io/sstable/format/RangeAwareSSTableWriter.java | 4 +- .../format/RangeAwareSSTableWriterTest.java| 91 ++ 5 files changed, 101 insertions(+), 3 deletions(-) create mode 100644 test/unit/org/apache/cassandra/io/sstable/format/RangeAwareSSTableWriterTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated (8396b64 -> ce91388)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git. from 8396b64 Fix dtest-novnode.materialized_views_test.TestMaterializedViews.test_drop_with_stopped_build add ce91388 Test sstableloader handling empty streams patch by Aleksandr Sorokoumov; reviewed by Marcus Eriksson and Zhao Yang for CASSANDRA-16349 No new revisions were added by this update. Summary of changes: sstable_generation_loading_test.py | 43 ++ 1 file changed, 43 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (b51bdbd -> a8fd723)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git. discard b51bdbd generate docs for f87cab11 new a8fd723 generate docs for f87cab11 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b51bdbd) \ N -- N -- N refs/heads/asf-staging (a8fd723) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/doc/4.0.0/cassandra/cql/functions.html | 16 +++ content/doc/4.0.1/cassandra/cql/functions.html | 16 +++ content/doc/4.0/cassandra/cql/functions.html | 16 +++ .../_images/cassandra_ssl_context_factory_pem.png | Bin 0 -> 44358 bytes content/doc/4.1/cassandra/cql/functions.html | 16 +++ content/doc/4.1/cassandra/operating/security.html | 111 +++-- .../_images/cassandra_ssl_context_factory_pem.png | Bin 0 -> 44358 bytes content/doc/latest/cassandra/cql/functions.html| 16 +++ .../doc/latest/cassandra/operating/security.html | 111 +++-- content/doc/stable/cassandra/cql/functions.html| 16 +++ .../_images/cassandra_ssl_context_factory_pem.png | Bin 0 -> 44358 bytes content/doc/trunk/cassandra/cql/functions.html | 16 +++ .../doc/trunk/cassandra/operating/security.html| 111 +++-- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4740084 -> 4740084 bytes 15 files changed, 419 insertions(+), 28 deletions(-) create mode 100644 content/doc/4.1/cassandra/_images/cassandra_ssl_context_factory_pem.png create mode 100644 content/doc/latest/cassandra/_images/cassandra_ssl_context_factory_pem.png create mode 100644 content/doc/trunk/cassandra/_images/cassandra_ssl_context_factory_pem.png - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-17220: Status: Review In Progress (was: Patch Available) > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498298#comment-17498298 ] Paulo Motta commented on CASSANDRA-17220: - {quote} Thanks mate, I am for simple configs, it is obvious it is a check. {quote} Ok, even though I still prefer {{check_dc}} and check_rack ;) Can you attach some CI results? > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-17220: Status: Ready to Commit (was: Review In Progress) > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-17220: Status: Patch Available (was: Ready to Commit) > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-17220: Status: Needs Committer (was: Patch Available) > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-17220: Status: Review In Progress (was: Needs Committer) > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498291#comment-17498291 ] Stefan Miklosovic commented on CASSANDRA-17220: --- Thanks mate, I am for simple configs, it is obvious it is a check. Yes config ticket will follow. > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17351) Pip doesn't install ccm every time
[ https://issues.apache.org/jira/browse/CASSANDRA-17351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498290#comment-17498290 ] Michael Semb Wever commented on CASSANDRA-17351: The builds are aborting atm. "clean tmp failed" is not the issue (that's quite a normal message), but rather… {noformat} 21:20:04 [resolver:resolve] Resolving artifacts 21:20:04 [resolver:resolve] Downloading https://repo1.maven.org/maven2/com/datastax/wikitext/wikitext-core-ant/1.3/wikitext-core-ant-1.3.jar 21:20:04 [resolver:resolve] Downloading https://repo1.maven.org/maven2/org/fusesource/wikitext/wikitext-core/1.3/wikitext-core-1.3.jar 21:20:04 [resolver:resolve] Downloading https://repo1.maven.org/maven2/org/fusesource/wikitext/textile-core/1.3/textile-core-1.3.jar 21:20:06 [resolver:resolve] Downloaded https://repo1.maven.org/maven2/org/fusesource/wikitext/textile-core/1.3/textile-core-1.3.jar (54 KB at 42.6 KB/sec) 21:25:06 Build timed out (after 5 minutes). Marking the build as aborted. 21:25:06 Build was aborted {noformat} which indicates a timeout and abort. > Pip doesn't install ccm every time > -- > > Key: CASSANDRA-17351 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17351 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 4.x > > > In CASSANDRA-16688 we fixed requirements.txt in DTest repo, pip install to > run without -e for ccm in order to address the moveable tag. That worked for > some time until last night. I successfully retagged and now ccm is not > re-installed in Circle CI. > Jenkins picked stuff though. But it was acting unreliably and weird so > rerunning now things there. Results pending. > Now I added -e for ccm in requirements.txt and it worked in CircleCI. Still > pending results. I don't think this will be permanent solution and I am not > sure whether it will affect also the previous branches in a way. We need to > further investigate it and test. > For now I will ask people to test with -e until we figure it out. > CC [~mck] , [~bereng] , [~dcapwell] and [~stefan.miklosovic] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17406) WEBSITE - March 2022 blog "Apache Cassandra Changelog #13"
[ https://issues.apache.org/jira/browse/CASSANDRA-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-17406: - Authors: Chris Thornett Change Category: Semantic Complexity: Normal Fix Version/s: NA Test and Documentation Plan: * Add blog post titled "Apache Cassandra Changelog #13" * Modify blog index page * Add image for blog > WEBSITE - March 2022 blog "Apache Cassandra Changelog #13" > -- > > Key: CASSANDRA-17406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17406 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Diogenese Topper >Priority: Normal > Fix For: NA > > > This ticket is to capture the work associated with publishing the March 2022 > changelog blog #13 > If this blog cannot be published by the *March 3, 2022 publish date*, please > contact me, suggest changes, or correct the date when possible in the pull > request for the appropriate time that the blog will go live (on both the > blog.adoc and the blog post's file). -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17406) WEBSITE - March 2022 blog "Apache Cassandra Changelog #13"
Diogenese Topper created CASSANDRA-17406: Summary: WEBSITE - March 2022 blog "Apache Cassandra Changelog #13" Key: CASSANDRA-17406 URL: https://issues.apache.org/jira/browse/CASSANDRA-17406 Project: Cassandra Issue Type: Task Components: Documentation/Blog Reporter: Diogenese Topper This ticket is to capture the work associated with publishing the March 2022 changelog blog #13 If this blog cannot be published by the *March 3, 2022 publish date*, please contact me, suggest changes, or correct the date when possible in the pull request for the appropriate time that the blog will go live (on both the blog.adoc and the blog post's file). -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498256#comment-17498256 ] Paulo Motta commented on CASSANDRA-17220: - We probably need to create a documentation ticket to explain what each startup check does on the documentation. > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17220) Make startup checks configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498255#comment-17498255 ] Paulo Motta commented on CASSANDRA-17220: - This looks great +1. If you agree can you incorporate [this commit|https://github.com/pauloricardomg/cassandra/commit/956f6def4f12622efa914f3f08d6747bfc278953] updating the {{cassandra.yaml}} wording? I tried to reduce the amount of text between the properties. Also, one final nitpicking before we merge: * Should we make startup check names be prefixed with {{check_}} ? Ie. {{{}check_dc{}}}, {{{}check_rack{}}}, etc (instead of simply {{dc}} or {{{}rack{}}})? This will make it easier to figure out what the startup check does. The renamed checks would be: {code:yaml} startup_checks: check_filesystem_ownership: enabled: false ownership_token: "sometoken" # (overriden by "CassandraOwnershipToken" system property) ownership_filename: ".cassandra_fs_ownership" # (overriden by "cassandra.fs_ownership_filename") check_dc: enabled: true # (overriden by cassandra.ignore_dc system property) check_rack: enabled: true # (overriden by cassandra.ignore_rack system property) {code} What do you think [~smiklosovic] [~dcapwell] ? > Make startup checks configurable > > > Key: CASSANDRA-17220 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17220 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > > This ticket was created from needs discovered in CASSANDRA-17180. We want to > be able to configure a startup check so we figured out that it is necessary > to treat all startup checks same - to be able to configure them. This ticket > is about making startup checks configurable. > Once this ticket is done, we can continue with the implementation of > CASSANDRA-17180 where the implementation of gc grace check will be done. > We have identified that there is one check currently in place which needs to > be changed to reflect this configuration implementation and that is > FileSystemOwnershipCheck. > Because startup checks were not configurable before via means of a > configuration file, they were configurable via system properties. This ticket > does not aim to get rid system properties configuration mechanism, system > properties will have precedence over settings in configuration file. Then, in > the next release, I am aiming to get rid of system properties configuration > mechanism. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498254#comment-17498254 ] Ekaterina Dimitrova commented on CASSANDRA-16349: - Tests finished successfully. (only one failure that has associated open ticket already). [~marcuse] confirmed his approval of the patch offline. Starting commit soon. > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:844) > {quote} > To reproduce create a cluster with ccm with more nodes than the RF, put some > data into it copy a SSTable and stream it. > > The error originates on the nodes, the following stack trace is shown in the > logs: > {quote}java.lang.IllegalStateException: Stream hasn't been read yet > at > com.google.common.base.Preconditions.checkState(Preconditions.java:507) > at > org.apache.cassandra.db.streaming.CassandraIncomingFile.getSize(CassandraIncomingFile.java:96) > at > org.apache.cassandra.streaming.StreamSession.receive(StreamSession.java:789) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:587) > at > org.apache.cassandra.streaming.as
[jira] [Created] (CASSANDRA-17405) Test failures: org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest
Ekaterina Dimitrova created CASSANDRA-17405: --- Summary: Test failures: org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest Key: CASSANDRA-17405 URL: https://issues.apache.org/jira/browse/CASSANDRA-17405 Project: Cassandra Issue Type: Bug Reporter: Ekaterina Dimitrova I see one failure in Jenkins but it seems more flaky this week as I have it failing in CircleCI with almost all my rung with Midres so seems like worth to check what happened. [https://ci-cassandra.apache.org/job/Cassandra-trunk/959/testReport/org.apache.cassandra.distributed.test.ring/BootstrapTest/bootstrapTest/] https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1404/workflows/5bb5412a-87a9-4b5f-94bd-ab0cd618e0b9/jobs/9205 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17405) Test failures: org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest
[ https://issues.apache.org/jira/browse/CASSANDRA-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17405: Fix Version/s: 4.x > Test failures: > org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest > - > > Key: CASSANDRA-17405 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17405 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > I see one failure in Jenkins but it seems more flaky this week as I have it > failing in CircleCI with almost all my rung with Midres so seems like worth > to check what happened. > [https://ci-cassandra.apache.org/job/Cassandra-trunk/959/testReport/org.apache.cassandra.distributed.test.ring/BootstrapTest/bootstrapTest/] > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1404/workflows/5bb5412a-87a9-4b5f-94bd-ab0cd618e0b9/jobs/9205 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17405) Test failures: org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest
[ https://issues.apache.org/jira/browse/CASSANDRA-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17405: Bug Category: Parent values: Correctness(12982) Complexity: Normal Component/s: Test/dtest/java Discovered By: User Report Severity: Normal Status: Open (was: Triage Needed) > Test failures: > org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest > - > > Key: CASSANDRA-17405 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17405 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Ekaterina Dimitrova >Priority: Normal > > I see one failure in Jenkins but it seems more flaky this week as I have it > failing in CircleCI with almost all my rung with Midres so seems like worth > to check what happened. > [https://ci-cassandra.apache.org/job/Cassandra-trunk/959/testReport/org.apache.cassandra.distributed.test.ring/BootstrapTest/bootstrapTest/] > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1404/workflows/5bb5412a-87a9-4b5f-94bd-ab0cd618e0b9/jobs/9205 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Since Version: 4.0.3 Source Control Link: https://github.com/apache/cassandra/commit/65fcc79b628a7e415b57c27c596ea1cb5e67211d and https://github.com/apache/cassandra/commit/12e2c159f86b223df1c2018c8a395a805b11956e Resolution: Fixed Status: Resolved (was: Ready to Commit) > Revert removed old deprecated parameters and revert name change of > user_defined_function_warn_timeout and user_defined_function_fail_timeout in > Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Since Version: (was: 4.0.3) > Revert removed old deprecated parameters and revert name change of > user_defined_function_warn_timeout and user_defined_function_fail_timeout in > Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498240#comment-17498240 ] Ekaterina Dimitrova commented on CASSANDRA-17378: - Committed in two patches: To https://github.com/apache/cassandra.git 769f6b3122..12e2c159f8 trunk -> trunk NOTE: CHANGES.txt and NEWS.txt are not updated, (only forward port the NEWS.txt entry from CASSANDRA-17377) as those should be documented things in CASSANDRA-15234, documentation in progress in CASSANDRA-17246, link will be added [here| https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L110-L111]. > Revert removed old deprecated parameters and revert name change of > user_defined_function_warn_timeout and user_defined_function_fail_timeout in > Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Revert removal of deprecated max_streaming_retries into Config, revert name change to user_defined_function_warn_timeout and user_defined_function_fail_timeout patch by Ekaterina Di
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 65fcc79b628a7e415b57c27c596ea1cb5e67211d Author: Ekaterina Dimitrova AuthorDate: Mon Feb 14 19:12:26 2022 -0500 Revert removal of deprecated max_streaming_retries into Config, revert name change to user_defined_function_warn_timeout and user_defined_function_fail_timeout patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378 --- src/java/org/apache/cassandra/config/Config.java| 18 +- .../apache/cassandra/config/DatabaseDescriptor.java | 21 ++--- 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/src/java/org/apache/cassandra/config/Config.java b/src/java/org/apache/cassandra/config/Config.java index 8c8ab07..4a96568 100644 --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@ -283,6 +283,12 @@ public class Config public volatile int concurrent_materialized_view_builders = 1; public volatile int reject_repair_compaction_threshold = Integer.MAX_VALUE; +/** + * @deprecated retry support removed on CASSANDRA-10992 + */ +@Deprecated +public int max_streaming_retries = 3; + @Replaces(oldName = "stream_throughput_outbound_megabits_per_sec", converter = Converters.MEGABITS_TO_MEBIBYTES_PER_SECOND_DATA_RATE, deprecated = true) public volatile DataRateSpec stream_throughput_outbound = new DataRateSpec("24MiB/s"); @Replaces(oldName = "inter_dc_stream_throughput_outbound_megabits_per_sec", converter = Converters.MEGABITS_TO_MEBIBYTES_PER_SECOND_DATA_RATE, deprecated = true) @@ -521,17 +527,19 @@ public class Config * Time in milliseconds after a warning will be emitted to the log and to the client that a UDF runs too long. * (Only valid, if user_defined_functions_threads_enabled==true) */ -//No need of unit conversion as this parameter is not exposed in the yaml file -public long user_defined_function_warn_timeout_in_ms = 500; +//TO DO: transfer below parameter to the new config framework (DurationSpec) +//Below parameter is in ms +public long user_defined_function_warn_timeout = 500; /** * Time in milliseconds after a fatal UDF run-time situation is detected and action according to * user_function_timeout_policy will take place. * (Only valid, if user_defined_functions_threads_enabled==true) */ -//No need of unit conversion as this parameter is not exposed in the yaml file -public long user_defined_function_fail_timeout_in_ms = 1500; +//TO DO: transfer below parameter to the new config framework (DurationSpec) +//Below parameter is in ms +public long user_defined_function_fail_timeout = 1500; /** - * Defines what to do when a UDF ran longer than user_defined_function_fail_timeout_in_ms. + * Defines what to do when a UDF ran longer than user_defined_function_fail_timeout. * Possible options are: * - 'die' - i.e. it is able to emit a warning to the client before the Cassandra Daemon will shut down. * - 'die_immediate' - shut down C* daemon immediately (effectively prevent the chance that the client will receive a warning). diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index ed2f0a1..ced4ad3 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -75,7 +75,6 @@ import org.apache.commons.lang3.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static java.util.concurrent.TimeUnit.MILLISECONDS; import static org.apache.cassandra.config.CassandraRelevantProperties.OS_ARCH; import static org.apache.cassandra.config.CassandraRelevantProperties.SUN_ARCH_DATA_MODEL; import static org.apache.cassandra.io.util.FileUtils.ONE_GIB; @@ -735,13 +734,13 @@ public class DatabaseDescriptor throw new ConfigurationException("index_summary_capacity option was set incorrectly to '" + conf.index_summary_capacity.toString() + "', it should be a non-negative integer.", false); -if (conf.user_defined_function_fail_timeout_in_ms < 0) -throw new ConfigurationException("user_defined_function_fail_timeout_in_ms must not be negative", false); -if (conf.user_defined_function_warn_timeout_in_ms < 0) -throw new ConfigurationException("user_defined_function_warn_timeout_in_ms must not be negative", false); +if (conf.user_defined_function_fail_timeout < 0) +throw new ConfigurationException("user_defined_function_fail_timeout must not be negative", false); +if (conf.user_defined_function_warn_timeout < 0) +
[cassandra] branch trunk updated (769f6b3 -> 12e2c15)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 769f6b3 Merge branch 'cassandra-4.0' into trunk new 65fcc79 Revert removal of deprecated max_streaming_retries into Config, revert name change to user_defined_function_warn_timeout and user_defined_function_fail_timeout patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378 new 12e2c15 Forward port from cassandra-4.0(CASSANDRA-17377) - deprecation of otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, otc_backlog_expiration_interval_ms patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: NEWS.txt | 3 ++ src/java/org/apache/cassandra/config/Config.java | 32 ++ .../cassandra/config/DatabaseDescriptor.java | 21 +++--- 3 files changed, 40 insertions(+), 16 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Forward port from cassandra-4.0(CASSANDRA-17377) - deprecation of otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, otc_backlog_expiration
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 12e2c159f86b223df1c2018c8a395a805b11956e Author: Ekaterina Dimitrova AuthorDate: Fri Feb 11 19:09:30 2022 -0500 Forward port from cassandra-4.0(CASSANDRA-17377) - deprecation of otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, otc_backlog_expiration_interval_ms patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378 --- NEWS.txt | 3 +++ src/java/org/apache/cassandra/config/Config.java | 14 ++ 2 files changed, 17 insertions(+) diff --git a/NEWS.txt b/NEWS.txt index ae56953..f9626f1 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -225,6 +225,9 @@ New features Upgrading - +- otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, + otc_backlog_expiration_interval_ms are deprecated and will be removed at earliest with next major release. + otc_coalescing_strategy is disabled since 3.11. - As part of the Internode Messaging improvement work in CASSANDRA-15066, internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes were renamed to internode_socket_send_buffer_size_in_bytes and internode_socket_receive_buffer_size_in_bytes. To support upgrades pre-4.0, we add backward compatibility and diff --git a/src/java/org/apache/cassandra/config/Config.java b/src/java/org/apache/cassandra/config/Config.java index 4a96568..910a3e8 100644 --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@ -471,6 +471,20 @@ public class Config */ public volatile ConsistencyLevel ideal_consistency_level = null; +@Deprecated +public String otc_coalescing_strategy = "DISABLED"; + +@Deprecated +public static final int otc_coalescing_window_us_default = 200; +@Deprecated +public int otc_coalescing_window_us = otc_coalescing_window_us_default; +@Deprecated +public int otc_coalescing_enough_coalesced_messages = 8; +@Deprecated +public static final int otc_backlog_expiration_interval_ms_default = 200; +@Deprecated +public volatile int otc_backlog_expiration_interval_ms = otc_backlog_expiration_interval_ms_default; + /** * Size of the CQL prepared statements cache in MiB. * Defaults to 1/256th of the heap size or 10MiB, whichever is greater. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498219#comment-17498219 ] Ekaterina Dimitrova edited comment on CASSANDRA-17378 at 2/25/22, 5:50 PM: --- There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the DTest branch I was testing with. * Upgrade tests failures are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Midres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon was (Author: e.dimitrova): There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the DTest branch I was testing with. * Upgrade tests are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Midres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon > Revert removed old deprecated parameters and revert name change of > user_defined_function_warn_timeout and user_defined_function_fail_timeout in > Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498219#comment-17498219 ] Ekaterina Dimitrova edited comment on CASSANDRA-17378 at 2/25/22, 5:49 PM: --- There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the DTest branch I was testing with. * Upgrade tests are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Midres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon was (Author: e.dimitrova): There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the branch I was testing with. * Upgrade tests are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Midres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon > Revert removed old deprecated parameters and revert name change of > user_defined_function_warn_timeout and user_defined_function_fail_timeout in > Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Summary: Revert removed old deprecated parameters and revert name change of user_defined_function_warn_timeout and user_defined_function_fail_timeout in Config (was: Revert removed old deprecated parameters and revert name change of user_defined in Config) > Revert removed old deprecated parameters and revert name change of > user_defined_function_warn_timeout and user_defined_function_fail_timeout in > Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Revert removed old deprecated parameters and revert name change of user_defined in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Summary: Revert removed old deprecated parameters and revert name change of user_defined in Config (was: Revert removed old deprecated parameters in Config) > Revert removed old deprecated parameters and revert name change of > user_defined in Config > - > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Revert removed old deprecated parameters in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Summary: Revert removed old deprecated parameters in Config (was: Deprecate a few parameters in Config) > Revert removed old deprecated parameters in Config > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Deprecate a few parameters in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Description: Based on the latest ML conversations, the following changes in Config should be reconsidered: [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms name changes were reverted and type will be changed as part of another patch, already in the making. * Cherry-pick was: Based on the latest ML conversations, the following changes in Config should be reconsidered: [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms name changes were reverted and type will be changed as part of another patch, already in the making. * > Deprecate a few parameters in Config > > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Deprecate a few parameters in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Description: Based on the latest ML conversations, the following changes in Config should be reconsidered: [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms name changes were reverted and type will be changed as part of another patch, already in the making. * Cherry-pick [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] was: Based on the latest ML conversations, the following changes in Config should be reconsidered: [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms name changes were reverted and type will be changed as part of another patch, already in the making. * Cherry-pick > Deprecate a few parameters in Config > > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * Cherry-pick > [https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Deprecate a few parameters in Config
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Summary: Deprecate a few parameters in Config (was: Add backward compatibility for a few changes done in 15234) > Deprecate a few parameters in Config > > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Add backward compatibility for a few changes done in 15234
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Description: Based on the latest ML conversations, the following changes in Config should be reconsidered: [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms name changes were reverted and type will be changed as part of another patch, already in the making. * was: Based on the latest ML conversations, the following changes in Config should be reconsidered: [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms - add @Replaces annotation and I think it is nice to transfer them to the new types too. *NOTE: Don't forget to add the backward compatibility for those two in CCM by adding entries [here|https://github.com/riptano/ccm/blob/master/ccmlib/common.py#L62-L148]; valid for any parameter that will use the new framework and we want to be backward compatible and tested properly by DTests* > Add backward compatibility for a few changes done in 15234 > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms name changes were reverted and type > will be changed as part of another patch, already in the making. > * -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17378) Add backward compatibility for a few changes done in 15234
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17378: Fix Version/s: 4.1 (was: 4.x) > Add backward compatibility for a few changes done in 15234 > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms - add @Replaces annotation and I > think it is nice to transfer them to the new types too. *NOTE: Don't forget > to add the backward compatibility for those two in CCM by adding entries > [here|https://github.com/riptano/ccm/blob/master/ccmlib/common.py#L62-L148]; > valid for any parameter that will use the new framework and we want to be > backward compatible and tested properly by DTests* -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17378) Add backward compatibility for a few changes done in 15234
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498219#comment-17498219 ] Ekaterina Dimitrova edited comment on CASSANDRA-17378 at 2/25/22, 5:18 PM: --- There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the branch I was testing with. * Upgrade tests are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Midres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon was (Author: e.dimitrova): There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the branch I was testing with. * Upgrade tests are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Moidres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon > Add backward compatibility for a few changes done in 15234 > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms - add @Replaces annotation and I > think it is nice to transfer them to the new types too. *NOTE: Don't forget > to add the backward compatibility for those two in CCM by adding entries > [here|https://github.com/riptano/ccm/blob/master/ccmlib/common.py#L62-L148]; > valid for any parameter that will use the new framework and we want to be > backward compatible and tested properly by DTests* -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17378) Add backward compatibility for a few changes done in 15234
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498219#comment-17498219 ] Ekaterina Dimitrova commented on CASSANDRA-17378: - There are a few failures but nothing related: * udf_overload was fixed but the fix is not in the branch I was testing with. * Upgrade tests are known and we have ticket - CASSANDRA-17140 * bootstrapTest - seems like flaky test and there is no open ticket. I see this failure with a few patches in CircleCI with Moidres today and I found one failure in Butler. I will raise a ticket. Unrelated to this patch. Starting commit soon > Add backward compatibility for a few changes done in 15234 > -- > > Key: CASSANDRA-17378 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17378 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > Based on the latest ML conversations, the following changes in Config should > be reconsidered: > [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23] > * max_streaming_retries - deprecated long time ago but it should be there > until at least 5.0. We need to revert this change > * user_defined_function_warn_timeout_in_ms and > user_defined_function_fail_timeout_in_ms - add @Replaces annotation and I > think it is nice to transfer them to the new types too. *NOTE: Don't forget > to add the backward compatibility for those two in CCM by adding entries > [here|https://github.com/riptano/ccm/blob/master/ccmlib/common.py#L62-L148]; > valid for any parameter that will use the new framework and we want to be > backward compatible and tested properly by DTests* -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17333) Error out on noop GRANT/REVOKE
[ https://issues.apache.org/jira/browse/CASSANDRA-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498216#comment-17498216 ] Andres de la Peña commented on CASSANDRA-17333: --- CI results: * [j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1315/workflows/b0b424e4-ee36-4e2a-ad6e-4b37310dcbfc] * [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1315/workflows/6e270574-82ce-47c0-8c03-1efd350e3c83] Looks good to me, I think we are ready to merge. > Error out on noop GRANT/REVOKE > -- > > Key: CASSANDRA-17333 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17333 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.1 > > > Currently a noop GRANT or REVOKE will just go silent which can lead to > confusion. Add a warning to the user. > Based on original works by [~snazy] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17333) Error out on noop GRANT/REVOKE
[ https://issues.apache.org/jira/browse/CASSANDRA-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-17333: -- Status: Ready to Commit (was: Review In Progress) > Error out on noop GRANT/REVOKE > -- > > Key: CASSANDRA-17333 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17333 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.1 > > > Currently a noop GRANT or REVOKE will just go silent which can lead to > confusion. Add a warning to the user. > Based on original works by [~snazy] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17333) Error out on noop GRANT/REVOKE
[ https://issues.apache.org/jira/browse/CASSANDRA-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498216#comment-17498216 ] Andres de la Peña edited comment on CASSANDRA-17333 at 2/25/22, 5:06 PM: - CI results: * [j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1315/workflows/b0b424e4-ee36-4e2a-ad6e-4b37310dcbfc] * [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1315/workflows/6e270574-82ce-47c0-8c03-1efd350e3c83] Looks good to me, I think we are ready to merge. was (Author: adelapena): CI results: * [j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1315/workflows/b0b424e4-ee36-4e2a-ad6e-4b37310dcbfc] * [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1315/workflows/6e270574-82ce-47c0-8c03-1efd350e3c83] Looks good to me, I think we are ready to merge. > Error out on noop GRANT/REVOKE > -- > > Key: CASSANDRA-17333 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17333 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.1 > > > Currently a noop GRANT or REVOKE will just go silent which can lead to > confusion. Add a warning to the user. > Based on original works by [~snazy] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498214#comment-17498214 ] Ekaterina Dimitrova commented on CASSANDRA-17280: - PS I suspect we can tweet and make some noice when it is time this actually to be released. We already told users that we plan it > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1, 4.0.4 > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498213#comment-17498213 ] Ekaterina Dimitrova commented on CASSANDRA-17280: - Committed, thanks To https://github.com/apache/cassandra.git 5bc9f7c736..22a4ae16e4 cassandra-4.0 -> cassandra-4.0 08331f474b..769f6b3122 trunk -> trunk > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17280: Fix Version/s: 4.1 4.0.4 (was: 4.x) (was: 4.0.x) Source Control Link: https://github.com/apache/cassandra/commit/22a4ae16e46639c0ecc9934352499a3ea664f8d7 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1, 4.0.4 > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (5bc9f7c -> 22a4ae1)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 5bc9f7c Merge branch 'cassandra-3.11' into cassandra-4.0 add 22a4ae1 Deprecate JavaScript user-defined functions patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi and Marcus Eriksson for CASSANDRA-17280 No new revisions were added by this update. Summary of changes: NEWS.txt | 5 + doc/modules/cassandra/pages/cql/functions.adoc | 12 ++-- src/java/org/apache/cassandra/config/DatabaseDescriptor.java | 3 +++ 3 files changed, 18 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 769f6b3122629d8422b347d13d7f573c56173c55 Merge: 08331f4 22a4ae1 Author: Ekaterina Dimitrova AuthorDate: Fri Feb 25 11:50:44 2022 -0500 Merge branch 'cassandra-4.0' into trunk NEWS.txt | 3 ++- doc/modules/cassandra/pages/cql/functions.adoc | 12 ++-- src/java/org/apache/cassandra/config/DatabaseDescriptor.java | 7 +-- 3 files changed, 17 insertions(+), 5 deletions(-) diff --cc NEWS.txt index e71d682,1dbc5b4..ae56953 --- a/NEWS.txt +++ b/NEWS.txt @@@ -395,7 -351,7 +395,8 @@@ Upgradin Deprecation --- -- ++- JavaScript user-defined functions have been deprecated. They are planned for removal ++ in the next major release. (CASSANDRA-17280) - The JMX MBean org.apache.cassandra.metrics:type=Streaming,name=ActiveOutboundStreams has been deprecated and will be removed in a subsequent major version. This metric was not updated since several version already. diff --cc src/java/org/apache/cassandra/config/DatabaseDescriptor.java index 50cda68,0bfb18e..ed2f0a1 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@@ -749,17 -761,20 +749,20 @@@ public class DatabaseDescripto if (conf.allow_extra_insecure_udfs) logger.warn("Allowing java.lang.System.* access in UDFs is dangerous and not recommended. Set allow_extra_insecure_udfs: false to disable."); -if(conf.enable_scripted_user_defined_functions) ++if(conf.scripted_user_defined_functions_enabled) + logger.warn("JavaScript user-defined functions have been deprecated. You can still use them but the plan is to remove them in the next major version. For more information - CASSANDRA-17280"); + -if (conf.commitlog_segment_size_in_mb <= 0) -throw new ConfigurationException("commitlog_segment_size_in_mb must be positive, but was " -+ conf.commitlog_segment_size_in_mb, false); -else if (conf.commitlog_segment_size_in_mb >= 2048) -throw new ConfigurationException("commitlog_segment_size_in_mb must be smaller than 2048, but was " -+ conf.commitlog_segment_size_in_mb, false); +if (conf.commitlog_segment_size.toMebibytes() == 0) +throw new ConfigurationException("commitlog_segment_size must be positive, but was " - + conf.commitlog_segment_size.toString(), false); ++ + conf.commitlog_segment_size.toString(), false); +else if (conf.commitlog_segment_size.toMebibytes() >= 2048) +throw new ConfigurationException("commitlog_segment_size must be smaller than 2048, but was " - + conf.commitlog_segment_size.toString(), false); ++ + conf.commitlog_segment_size.toString(), false); -if (conf.max_mutation_size_in_kb == null) -conf.max_mutation_size_in_kb = conf.commitlog_segment_size_in_mb * 1024 / 2; -else if (conf.commitlog_segment_size_in_mb * 1024 < 2 * conf.max_mutation_size_in_kb) -throw new ConfigurationException("commitlog_segment_size_in_mb must be at least twice the size of max_mutation_size_in_kb / 1024", false); +if (conf.max_mutation_size == null) +conf.max_mutation_size = SmallestDataStorageKibibytes.inKibibytes(conf.commitlog_segment_size.toKibibytes() / 2); +else if (conf.commitlog_segment_size.toKibibytes() < 2 * conf.max_mutation_size.toKibibytes()) +throw new ConfigurationException("commitlog_segment_size must be at least twice the size of max_mutation_size / 1024", false); // native transport encryption options if (conf.client_encryption_options != null) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (08331f4 -> 769f6b3)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 08331f4 Added doc for PEM-based SSL support in CASSANDRA-17031 add 22a4ae1 Deprecate JavaScript user-defined functions patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi and Marcus Eriksson for CASSANDRA-17280 new 769f6b3 Merge branch 'cassandra-4.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: NEWS.txt | 3 ++- doc/modules/cassandra/pages/cql/functions.adoc | 12 ++-- src/java/org/apache/cassandra/config/DatabaseDescriptor.java | 7 +-- 3 files changed, 17 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497782#comment-17497782 ] Ekaterina Dimitrova edited comment on CASSANDRA-17280 at 2/25/22, 4:44 PM: --- Pushed CI below, I will check the results later or tomorrow: [4.0|https://github.com/apache/cassandra/commit/7982a51929d422517ec47548ced0f1254285eb1a] - [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1399/workflows/7f77d598-1e93-4c8c-a8fe-372b0723d1a9], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1399/workflows/7ac71c38-8d3c-48f7-9c17-5fb4dc1e1c59] [trunk|https://github.com/ekaterinadimitrova2/cassandra/pull/new/17280-trunkk] - [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1401/workflows/111a1dfa-c5f0-4712-849b-2bc255d3e251], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1401/workflows/3136bba8-e8db-4a86-bb28-c165cf0f120b] was (Author: e.dimitrova): Pushed CI below, I will check the results later or tomorrow: [4.0|https://github.com/apache/cassandra/commit/7982a51929d422517ec47548ced0f1254285eb1a] - [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1399/workflows/7f77d598-1e93-4c8c-a8fe-372b0723d1a9], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1399/workflows/7ac71c38-8d3c-48f7-9c17-5fb4dc1e1c59] [trunk|https://github.com/ekaterinadimitrova2/cassandra/pull/new/17280-trunk] - [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1401/workflows/111a1dfa-c5f0-4712-849b-2bc255d3e251], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1401/workflows/3136bba8-e8db-4a86-bb28-c165cf0f120b] > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498186#comment-17498186 ] Ekaterina Dimitrova edited comment on CASSANDRA-16349 at 2/25/22, 3:57 PM: --- All tests look fine to me except Java 11 dtests. I suspect infra issue as we have 22 tests failing with this issue: {code:java} OSError: [Errno 98] Address already in use{code} Restarted the J11 dtests [with vnodes|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1403/workflows/07019567-d242-46e1-8efc-70221ac6b81f/jobs/9220] and [no vnodes|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1403/workflows/07019567-d242-46e1-8efc-70221ac6b81f/jobs/9221] was (Author: e.dimitrova): All tests look fine to me except Java 11 dtests. I suspect infra issue as we have 22 tests failing with this issue: Restarted the J11 dtests [with vnodes|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1403/workflows/07019567-d242-46e1-8efc-70221ac6b81f/jobs/9220] and [no vnodes|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1403/workflows/07019567-d242-46e1-8efc-70221ac6b81f/jobs/9221] > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concu
[jira] [Commented] (CASSANDRA-16349) SSTableLoader reports error when SSTable(s) do not have data for some nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498186#comment-17498186 ] Ekaterina Dimitrova commented on CASSANDRA-16349: - All tests look fine to me except Java 11 dtests. I suspect infra issue as we have 22 tests failing with this issue: Restarted the J11 dtests [with vnodes|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1403/workflows/07019567-d242-46e1-8efc-70221ac6b81f/jobs/9220] and [no vnodes|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1403/workflows/07019567-d242-46e1-8efc-70221ac6b81f/jobs/9221] > SSTableLoader reports error when SSTable(s) do not have data for some nodes > --- > > Key: CASSANDRA-16349 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16349 > Project: Cassandra > Issue Type: Bug > Components: Tool/sstable >Reporter: Serban Teodorescu >Assignee: Serban Teodorescu >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Running SSTableLoader in verbose mode will show error(s) if there are node(s) > that do not own any data from the SSTable(s). This can happen in at least 2 > cases: > # SSTableLoader is used to stream backups while keeping the same token ranges > # SSTable(s) are created with CQLSSTableWriter to match token ranges (this > can bring better performance by using ZeroCopy streaming) > Partial output of the SSTableLoader: > {quote}ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] > Remote peer /127.0.0.4:7000 failed stream session. > ERROR 02:47:47,842 [Stream #fa8e73b0-3da5-11eb-9c47-c5d27ae8fe47] Remote peer > /127.0.0.3:7000 failed stream session. > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.611KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.515KiB/s) > progress: [/127.0.0.4:7000]0:0/1 100% [/127.0.0.3:7000]0:0/1 100% > [/127.0.0.2:7000]0:7/7 100% [/127.0.0.1:7000]0:7/7 100% total: 100% > 0.000KiB/s (avg: 1.427KiB/s) > {quote} > > Stack trace: > {quote}java.util.concurrent.ExecutionException: > org.apache.cassandra.streaming.StreamException: Stream failed > at > com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:552) > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:533) > at org.apache.cassandra.tools.BulkLoader.load(BulkLoader.java:99) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:49) > Caused by: org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:88) > at > com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1056) > at > com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) > at > com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138) > at > com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:220) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:196) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:505) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:819) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:595) > at > org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:189) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:844) > {quote} > To reproduce create a cluster with ccm with more nodes than the RF, put some > data into it copy a SSTable and stream it. > > The error originates on the nodes, the following stack trace is shown in the > logs: > {quote}java.lang.IllegalStateException: Stream hasn't been read yet > at > com.google.common.base.Preconditions.checkState(Preconditions.java:507) > at > org.apache.cassandra.db.streaming.CassandraIncomingFile.getSize
[jira] [Commented] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498181#comment-17498181 ] Ekaterina Dimitrova commented on CASSANDRA-17280: - I meant to fix an issue in NEWS.txt but I will do it in another ticket where I actually cherry-pick that 4.0 patch to trunk. Starting commit soon, thanks > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17280: Fix Version/s: 4.x > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17280) Deprecate JavaScript UDF
[ https://issues.apache.org/jira/browse/CASSANDRA-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17280: Status: Ready to Commit (was: Review In Progress) > Deprecate JavaScript UDF > > > Key: CASSANDRA-17280 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17280 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > There was a [consensus > |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] that JS > UDF can be deprecated and removed with the next major release. > As part of this ticket we can add: > * Warning to the users when they use them In 4.0.2 > * Docs update > * Twitter update > * Announcement to the user mailing list -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17402) Unshared heap size excluding data calculation is broken
[ https://issues.apache.org/jira/browse/CASSANDRA-17402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498020#comment-17498020 ] Jacek Lewandowski commented on CASSANDRA-17402: --- Tests are running... > Unshared heap size excluding data calculation is broken > --- > > Key: CASSANDRA-17402 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17402 > Project: Cassandra > Issue Type: Bug > Components: Local/Memtable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1, 4.0.x > > Time Spent: 20m > Remaining Estimate: 0h > > Unshared heap size excluding data calculation is broken. > For example, it does not takes into consideration whether the buffers are > on-heap or off-heap - empty offheap buffer is 64-bytes while empty heap > buffer is 48-bytes. > It matters especially when we have offheap buffers-based memtables. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17335) Flaky testNoSuchRepairSessionAnticompaction
[ https://issues.apache.org/jira/browse/CASSANDRA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498009#comment-17498009 ] Berenguer Blasi commented on CASSANDRA-17335: - Dropped a couple comments. > Flaky testNoSuchRepairSessionAnticompaction > --- > > Key: CASSANDRA-17335 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17335 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Andres de la Peña >Assignee: Bernardo Botella Corbi >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: > 0001-Fix-Flaky-testNoSuchRepairSessionAnticompaction-trunk.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The in-JVM dtest {{RepairErrorsTest#testNoSuchRepairSessionAnticompaction}} > seems to be flaky, as it's shown by [this repeated > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1280/workflows/8a4e04cb-64cc-46a3-9e1e-c946dfafc7fa/jobs/12114] > on trunk, which hits 18 failures in 500 iterations. The config for CircleCI > was generated with: > {code} > .circleci/generate.sh -m \ > -e REPEATED_UTEST_TARGET=test-jvm-dtest-some \ > -e REPEATED_UTEST_COUNT=500 \ > -e > REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.RepairErrorsTest > {code} > This was discovered while testing CASSANDRA-16878, on [this CI > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1268/workflows/aef1c703-c816-40f8-8e07-9055027d6403/jobs/12000]. > The error consists on a failed assertion when grepping the logs in search of > an error message. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17335) Flaky testNoSuchRepairSessionAnticompaction
[ https://issues.apache.org/jira/browse/CASSANDRA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17335: Fix Version/s: 4.0.x 4.x > Flaky testNoSuchRepairSessionAnticompaction > --- > > Key: CASSANDRA-17335 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17335 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Andres de la Peña >Assignee: Bernardo Botella Corbi >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: > 0001-Fix-Flaky-testNoSuchRepairSessionAnticompaction-trunk.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The in-JVM dtest {{RepairErrorsTest#testNoSuchRepairSessionAnticompaction}} > seems to be flaky, as it's shown by [this repeated > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1280/workflows/8a4e04cb-64cc-46a3-9e1e-c946dfafc7fa/jobs/12114] > on trunk, which hits 18 failures in 500 iterations. The config for CircleCI > was generated with: > {code} > .circleci/generate.sh -m \ > -e REPEATED_UTEST_TARGET=test-jvm-dtest-some \ > -e REPEATED_UTEST_COUNT=500 \ > -e > REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.RepairErrorsTest > {code} > This was discovered while testing CASSANDRA-16878, on [this CI > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1268/workflows/aef1c703-c816-40f8-8e07-9055027d6403/jobs/12000]. > The error consists on a failed assertion when grepping the logs in search of > an error message. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17335) Flaky testNoSuchRepairSessionAnticompaction
[ https://issues.apache.org/jira/browse/CASSANDRA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17335: Reviewers: Berenguer Blasi, Yifan Cai (was: Yifan Cai) > Flaky testNoSuchRepairSessionAnticompaction > --- > > Key: CASSANDRA-17335 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17335 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Andres de la Peña >Assignee: Bernardo Botella Corbi >Priority: Normal > Attachments: > 0001-Fix-Flaky-testNoSuchRepairSessionAnticompaction-trunk.patch > > > The in-JVM dtest {{RepairErrorsTest#testNoSuchRepairSessionAnticompaction}} > seems to be flaky, as it's shown by [this repeated > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1280/workflows/8a4e04cb-64cc-46a3-9e1e-c946dfafc7fa/jobs/12114] > on trunk, which hits 18 failures in 500 iterations. The config for CircleCI > was generated with: > {code} > .circleci/generate.sh -m \ > -e REPEATED_UTEST_TARGET=test-jvm-dtest-some \ > -e REPEATED_UTEST_COUNT=500 \ > -e > REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.RepairErrorsTest > {code} > This was discovered while testing CASSANDRA-16878, on [this CI > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1268/workflows/aef1c703-c816-40f8-8e07-9055027d6403/jobs/12000]. > The error consists on a failed assertion when grepping the logs in search of > an error message. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17335) Flaky testNoSuchRepairSessionAnticompaction
[ https://issues.apache.org/jira/browse/CASSANDRA-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17335: Status: Review In Progress (was: Needs Committer) > Flaky testNoSuchRepairSessionAnticompaction > --- > > Key: CASSANDRA-17335 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17335 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Andres de la Peña >Assignee: Bernardo Botella Corbi >Priority: Normal > Attachments: > 0001-Fix-Flaky-testNoSuchRepairSessionAnticompaction-trunk.patch > > > The in-JVM dtest {{RepairErrorsTest#testNoSuchRepairSessionAnticompaction}} > seems to be flaky, as it's shown by [this repeated > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1280/workflows/8a4e04cb-64cc-46a3-9e1e-c946dfafc7fa/jobs/12114] > on trunk, which hits 18 failures in 500 iterations. The config for CircleCI > was generated with: > {code} > .circleci/generate.sh -m \ > -e REPEATED_UTEST_TARGET=test-jvm-dtest-some \ > -e REPEATED_UTEST_COUNT=500 \ > -e > REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.RepairErrorsTest > {code} > This was discovered while testing CASSANDRA-16878, on [this CI > run|https://app.circleci.com/pipelines/github/adelapena/cassandra/1268/workflows/aef1c703-c816-40f8-8e07-9055027d6403/jobs/12000]. > The error consists on a failed assertion when grepping the logs in search of > an error message. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17333) Error out on noop GRANT/REVOKE
[ https://issues.apache.org/jira/browse/CASSANDRA-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17333: Status: Review In Progress (was: Patch Available) > Error out on noop GRANT/REVOKE > -- > > Key: CASSANDRA-17333 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17333 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.1 > > > Currently a noop GRANT or REVOKE will just go silent which can lead to > confusion. Add a warning to the user. > Based on original works by [~snazy] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17287) Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
[ https://issues.apache.org/jira/browse/CASSANDRA-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17287: -- Reviewers: Brandon Williams (was: Brandon Williams, Stefan Miklosovic) > Replace cqlshlib/wcwidth.py with pypi module 'wcwidth' > -- > > Key: CASSANDRA-17287 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17287 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > Attachments: CQLSH sample query.jpg > > > The module wcwidth implements the same Markus Kuhn algorithm defined in > POSIX.1-2008 to return the number of cells a unicode string is expected to > occupy. > The module wcwidth is used by hundreds of libraries including pytest and > prompt-toolkit (used in ipython). It replaces 379 lines of bespoke code in > cqlshlib. > {quote}from wcwidth import wcswidth # at [https://pypi.org/project/wcwidth/] > print(wcswidth('コンニチハ')) > 10 > {{from cqlshlib.wcwidth import wcswidth as cql_wcswidth}} > print(cql_wcswidth('コンニチハ')) > 10 > {quote} > wcwidth appears to be used only by one line in formatting.py: > return bval if colormap is NO_COLOR_MAP else color_text(bval, colormap, > wcwidth.wcswidth(bval)) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17287) Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
[ https://issues.apache.org/jira/browse/CASSANDRA-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17287: -- Status: Patch Available (was: Review In Progress) > Replace cqlshlib/wcwidth.py with pypi module 'wcwidth' > -- > > Key: CASSANDRA-17287 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17287 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > Attachments: CQLSH sample query.jpg > > > The module wcwidth implements the same Markus Kuhn algorithm defined in > POSIX.1-2008 to return the number of cells a unicode string is expected to > occupy. > The module wcwidth is used by hundreds of libraries including pytest and > prompt-toolkit (used in ipython). It replaces 379 lines of bespoke code in > cqlshlib. > {quote}from wcwidth import wcswidth # at [https://pypi.org/project/wcwidth/] > print(wcswidth('コンニチハ')) > 10 > {{from cqlshlib.wcwidth import wcswidth as cql_wcswidth}} > print(cql_wcswidth('コンニチハ')) > 10 > {quote} > wcwidth appears to be used only by one line in formatting.py: > return bval if colormap is NO_COLOR_MAP else color_text(bval, colormap, > wcwidth.wcswidth(bval)) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17287) Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
[ https://issues.apache.org/jira/browse/CASSANDRA-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497976#comment-17497976 ] Stefan Miklosovic commented on CASSANDRA-17287: --- I tried everything I could. I have also built custom Jenkins images, I pushed it to docker hub etc ... No success. I am unable to test this. Going away from this ticket. > Replace cqlshlib/wcwidth.py with pypi module 'wcwidth' > -- > > Key: CASSANDRA-17287 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17287 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > Attachments: CQLSH sample query.jpg > > > The module wcwidth implements the same Markus Kuhn algorithm defined in > POSIX.1-2008 to return the number of cells a unicode string is expected to > occupy. > The module wcwidth is used by hundreds of libraries including pytest and > prompt-toolkit (used in ipython). It replaces 379 lines of bespoke code in > cqlshlib. > {quote}from wcwidth import wcswidth # at [https://pypi.org/project/wcwidth/] > print(wcswidth('コンニチハ')) > 10 > {{from cqlshlib.wcwidth import wcswidth as cql_wcswidth}} > print(cql_wcswidth('コンニチハ')) > 10 > {quote} > wcwidth appears to be used only by one line in formatting.py: > return bval if colormap is NO_COLOR_MAP else color_text(bval, colormap, > wcwidth.wcswidth(bval)) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16950) Documentation for: CEP-9 Make SSLContext creation pluggable
[ https://issues.apache.org/jira/browse/CASSANDRA-16950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497975#comment-17497975 ] Erick Ramirez edited comment on CASSANDRA-16950 at 2/25/22, 8:13 AM: - I'll need to chat to [~mck] when he gets back next week or [~Anthony Grasso] to find out how in-tree docs get pushed to staging so we can publish the updates to production. was (Author: JIRAUSER285101): I'll need to chat to [~mck] when he gets back next week to find out how in-tree docs get pushed to staging so we can publish the updates to production. > Documentation for: CEP-9 Make SSLContext creation pluggable > --- > > Key: CASSANDRA-16950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16950 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Low > Fix For: 4.1 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > This ticket is to specifically cover the documentation for the pluggable > SSLContext creation code changes done as part of CASSANDRA-1. As a > general agreement on that ticket, it is decided that we should separate the > documentation work from the implementation due to the parallel on-going > documentation revamp (see CASSANDRA-16763). -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16950) Documentation for: CEP-9 Make SSLContext creation pluggable
[ https://issues.apache.org/jira/browse/CASSANDRA-16950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497975#comment-17497975 ] Erick Ramirez commented on CASSANDRA-16950: --- I'll need to chat to [~mck] when he gets back next week to find out how in-tree docs get pushed to staging so we can publish the updates to production. > Documentation for: CEP-9 Make SSLContext creation pluggable > --- > > Key: CASSANDRA-16950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16950 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Low > Fix For: 4.1 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > This ticket is to specifically cover the documentation for the pluggable > SSLContext creation code changes done as part of CASSANDRA-1. As a > general agreement on that ticket, it is decided that we should separate the > documentation work from the implementation due to the parallel on-going > documentation revamp (see CASSANDRA-16763). -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17264) WEBSITE - Fix broken links
[ https://issues.apache.org/jira/browse/CASSANDRA-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497971#comment-17497971 ] Erick Ramirez edited comment on CASSANDRA-17264 at 2/25/22, 8:09 AM: - There's a merge conflict for the page {{community.adoc}} which needs to be resolved. /cc [~diotopper] was (Author: JIRAUSER285101): There's a merge conflict for the page `community.adoc` which needs to be resolved. /cc [~diotopper] > WEBSITE - Fix broken links > -- > > Key: CASSANDRA-17264 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17264 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Paul Au >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > > Scans of the Apache Cassandra website revealed some broken links. See link: > [https://lists.apache.org/thread/3qtxndr4bxw5xo9gshrl4t2vyk4ym8o1] > > These links are found in both the template files as well as the adoc files. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17264) WEBSITE - Fix broken links
[ https://issues.apache.org/jira/browse/CASSANDRA-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17264: -- Status: Changes Suggested (was: Review In Progress) There's a merge conflict for the page `community.adoc` which needs to be resolved. /cc [~diotopper] > WEBSITE - Fix broken links > -- > > Key: CASSANDRA-17264 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17264 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Paul Au >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > > Scans of the Apache Cassandra website revealed some broken links. See link: > [https://lists.apache.org/thread/3qtxndr4bxw5xo9gshrl4t2vyk4ym8o1] > > These links are found in both the template files as well as the adoc files. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org