[jira] [Comment Edited] (CASSANDRA-17310) Test Failure: org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV3XTest.testAvailability
[
https://issues.apache.org/jira/browse/CASSANDRA-17310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561777#comment-17561777
]
Andres de la Peña edited comment on CASSANDRA-17310 at 7/2/22 6:52 PM:
---
There is more to the failures than just CASSANDRA-17636, but all the issues
should be addressed at CASSANDRA-17307. I think we can close this as a
duplicate of CASSANDRA-17307.
was (Author: adelapena):
There is more to the failures than just CASSANDRA-7636, but all the issues
should be addressed at CASSANDRA-17307. I think we can close this as a
duplicate of CASSANDRA-17307.
> Test Failure:
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV3XTest.testAvailability
>
>
> Key: CASSANDRA-17310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Josh McKenzie
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-4.0/312/testReport/org.apache.cassandra.distributed.upgrade/MixedModeAvailabilityV3XTest/testAvailability/
> Failed 1 times in the last 5 runs. Flakiness: 25%, Stability: 80%
> Error Message
> Unexpected error while reading in case write-read consistency ONE-ALL with
> upgraded coordinator and 2 nodes down
> {code}
> Stacktrace
> junit.framework.AssertionFailedError: Unexpected error while reading in case
> write-read consistency ONE-ALL with upgraded coordinator and 2 nodes down
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.test(MixedModeAvailabilityTestBase.java:142)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.lambda$testAvailability$2(MixedModeAvailabilityTestBase.java:91)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:231)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:93)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:61)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:56)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV3XTest.testAvailability(MixedModeAvailabilityV3XTest.java:33)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.maybeFail(MixedModeAvailabilityTestBase.java:166)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.test(MixedModeAvailabilityTestBase.java:134)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17310) Test Failure: org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV3XTest.testAvailability
[
https://issues.apache.org/jira/browse/CASSANDRA-17310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561777#comment-17561777
]
Andres de la Peña commented on CASSANDRA-17310:
---
There is more to the failures than just CASSANDRA-7636, but all the issues
should be addressed at CASSANDRA-17307. I think we can close this as a
duplicate of CASSANDRA-17307.
> Test Failure:
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV3XTest.testAvailability
>
>
> Key: CASSANDRA-17310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Josh McKenzie
>Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-4.0/312/testReport/org.apache.cassandra.distributed.upgrade/MixedModeAvailabilityV3XTest/testAvailability/
> Failed 1 times in the last 5 runs. Flakiness: 25%, Stability: 80%
> Error Message
> Unexpected error while reading in case write-read consistency ONE-ALL with
> upgraded coordinator and 2 nodes down
> {code}
> Stacktrace
> junit.framework.AssertionFailedError: Unexpected error while reading in case
> write-read consistency ONE-ALL with upgraded coordinator and 2 nodes down
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.test(MixedModeAvailabilityTestBase.java:142)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.lambda$testAvailability$2(MixedModeAvailabilityTestBase.java:91)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:231)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:93)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:61)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:56)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV3XTest.testAvailability(MixedModeAvailabilityV3XTest.java:33)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.maybeFail(MixedModeAvailabilityTestBase.java:166)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.test(MixedModeAvailabilityTestBase.java:134)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17307) Test Failure: org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV30Test.testAvailability
[
https://issues.apache.org/jira/browse/CASSANDRA-17307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561762#comment-17561762
]
Andres de la Peña commented on CASSANDRA-17307:
---
It seems there was a mistake on the way that exceptions are handled on the
test, I've just fixed that too. With that and the splitting it survives 400
iterations on every split:
||branch||test||CI||
|4.1|MixedModeAvailabilityV30QuorumQuorumTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1891/workflows/f862c7b3-39f8-4c71-8d0b-072013209550]|
|4.1|MixedModeAvailabilityV30AllOneTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1892/workflows/f82825f4-7297-4209-896f-743c71258f17]|
|4.1|MixedModeAvailabilityV30OneAllTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1893/workflows/c973a92f-03f3-4dea-90da-cd425b303c36]|
|4.1|MixedModeAvailabilityV3XQuorumQuorumTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1894/workflows/57b2354a-548d-4d8f-ac82-cf13227aafb3]|
|4.1|MixedModeAvailabilityV3XAllOneTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1895/workflows/1398d736-bd48-47e9-baa2-2f791ace0a67]|
|4.1|MixedModeAvailabilityV3XOneAllTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1896/workflows/82499604-63c2-4b3a-a89f-dc352447ebb5]|
|trunk|MixedModeAvailabilityV30QuorumQuorumTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1897/workflows/513e1cfc-1822-4f70-8fb9-01a6aabe5915]|
|trunk|MixedModeAvailabilityV30AllOneTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1898/workflows/9d2dafbf-0ebc-4ca5-a372-41620202ccfa]|
|trunk|MixedModeAvailabilityV30OneAllTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1899/workflows/523dba84-f680-439d-ab02-f6bd2666d296]|
|trunk|MixedModeAvailabilityV3XQuorumQuorumTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1900/workflows/029384e6-be31-4c5e-8bea-a432c9437bb3]|
|trunk|MixedModeAvailabilityV3XAllOneTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1901/workflows/7b55c969-2ad0-40df-9408-8c70e368cc21]|
|trunk|MixedModeAvailabilityV3XOneAllTest|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1902/workflows/5e01a6bb-973d-4e4c-a94c-0e18b6af4e97]|
> Test Failure:
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV30Test.testAvailability
>
>
> Key: CASSANDRA-17307
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17307
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Josh McKenzie
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> No known failures. Flakiness 0%, Stability 100%
> Error Message
> Unexpected error while reading in case write-read consistency QUORUM-QUORUM
> with not upgraded coordinator and 1 nodes down
> {code}
> Stacktrace
> junit.framework.AssertionFailedError: Unexpected error while reading in case
> write-read consistency QUORUM-QUORUM with not upgraded coordinator and 1
> nodes down
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase$Tester.test(MixedModeAvailabilityTestBase.java:142)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.lambda$testAvailability$2(MixedModeAvailabilityTestBase.java:91)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:231)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:93)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:62)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:56)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV30Test.testAvailability(MixedModeAvailabilityV30Test.java:33)
> Caused by: java.lang.RuntimeException:
> org.apache.cassandra.exceptions.ReadTimeoutException: Operation timed out -
> received only 1 responses.
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor.waitOn(IsolatedExecutor.java:218)
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor.lambda$sync$5(IsolatedExecutor.java:109)
> at
> org.apache.cassandra.distributed.impl.Coordinator.executeWithResult(Coordinator.java:69)
> at
> org.apache.cassandra.distributed.api.ICoordinator.execute(ICoordinator.java:32)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase
[jira] [Updated] (CASSANDRA-17727) Remove read_repair table option from <4.0 docs, and restore read_repair_chance docs
[ https://issues.apache.org/jira/browse/CASSANDRA-17727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17727: --- Bug Category: Parent values: Documentation(13562) Complexity: Low Hanging Fruit Discovered By: User Report Fix Version/s: 3.11.x Severity: Critical Status: Open (was: Triage Needed) > Remove read_repair table option from <4.0 docs, and restore > read_repair_chance docs > --- > > Key: CASSANDRA-17727 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17727 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Michael Semb Wever >Priority: Normal > Fix For: 3.11.x > > > CASSANDRA-16763 added the read_repair docs to all versions. It should only > have been added to 4.0 onwards. > The 3.11 docs is now missing the read_repair_chance information. > See doc/modules/cassandra/pages/cql/ddl.adoc and > doc/modules/cassandra/pages/operating/read_repair.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16911) Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
[ https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561749#comment-17561749 ] Josh McKenzie commented on CASSANDRA-16911: --- bq. 2. Add new column ephemeral to nodetool listnapshots Is this a new "mandatory" column or behind a feature flag? Much like that other ticket floating around the discussion on the dev list, we want to preserve backwards compatibility as much as possible and this includes tool output. > Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest > -- > > Key: CASSANDRA-16911 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16911 > Project: Cassandra > Issue Type: Improvement > Components: Local/Snapshots >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.2 > > Time Spent: 4.5h > Remaining Estimate: 0h > > While creating an ephemeral snapshot, a marker file is created at disk in a > respective snapshot directory. This is not necessary anymore as we have > introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag > there. By putting the information if a snapshot is ephemeral or not into > SnapshotManifest, we simplify and "clean up" the snapshotting process and > related codebase. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17727) Remove read_repair table option from <4.0 docs, and restore read_repair_chance docs
Michael Semb Wever created CASSANDRA-17727: -- Summary: Remove read_repair table option from <4.0 docs, and restore read_repair_chance docs Key: CASSANDRA-17727 URL: https://issues.apache.org/jira/browse/CASSANDRA-17727 Project: Cassandra Issue Type: Bug Components: Documentation Reporter: Michael Semb Wever CASSANDRA-16763 added the read_repair docs to all versions. It should only have been added to 4.0 onwards. The 3.11 docs is now missing the read_repair_chance information. See doc/modules/cassandra/pages/cql/ddl.adoc and doc/modules/cassandra/pages/operating/read_repair.adoc -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17726) Potential Refactoring Estimate
[ https://issues.apache.org/jira/browse/CASSANDRA-17726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17726: - Resolution: Invalid Status: Resolved (was: Triage Needed) This should probably be a discussion on the dev mailing list that actionable tickets can be created from, but is too premature and not actionable for a Jira ticket itself at this point in time. https://cassandra.apache.org/_/community.html > Potential Refactoring Estimate > -- > > Key: CASSANDRA-17726 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17726 > Project: Cassandra > Issue Type: Improvement >Reporter: Alvin Tan Jian Jia >Priority: Normal > Attachments: Cassandra_4.0.4.csv > > > *Summary* > I have identified a few classes with refactoring potential along with its > estimated time to refactor, specifically BatchlogManager.java. The estimated > time is based on historical commits containing refactoring and the complexity > of the involved classes. The class was refactored once on Jun 12, 2019 along > with other classes in commit 310a48efcfdc0fb77fbd5fd6e734bf17667f617d. Given > the duration of the last refactoring, could it be possible to improve this > class further? I am probably not qualified and experienced enough to point > out the exact code needs to be refactored, given my limited knowledge of the > project and codebase. > > *Urgency* > Low priority. For maintenance of code in the long run. > > Hi, > I am currently doing some research on Estimating Time Taken for Software > Refactoring. Cassandra is one of my case studies being a highly popular > project. Would appreciate your kind feedback on the appropriateness of the > estimated time to refactor. > I am specifically looking at potential for refactoring, such as breaking > functions that are too long into shorter functions, or to remove code > duplication. Would you agree that there could be some modification to the > code to make it better in the listed classes? And if so, is the estimated > time appropriate to carry out the improvement? I will be grateful for any > help you can provide. > # BatchlogManager.java - 4 hours > # ImmediateExecutor.java - 3 hours > # DatabaseDescriptor.java - 3.5 hours > Thank you. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
