[jira] [Updated] (CASSANDRA-17910) Cassandra repo not updated with latest 4.0.6 package
[ https://issues.apache.org/jira/browse/CASSANDRA-17910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17910: -- Resolution: Not A Problem Status: Resolved (was: Triage Needed) In the [August 2022 Changelog|https://cassandra.apache.org/_/blog/Apache-Cassandra-Changelog-18-August-2022.html], we announced that the package repositories have moved (related to CASSANDRA-17748). Please follow the updated instructions in the [Download|https://cassandra.apache.org/_/download.html] section of the website, and note the new repository URLs. Cheers! > Cassandra repo not updated with latest 4.0.6 package > > > Key: CASSANDRA-17910 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17910 > Project: Cassandra > Issue Type: Bug >Reporter: deepagkanaka >Priority: Normal > > Hi Team, > > The repo is not updated with latest package -[Index of /cassandra/redhat/40x > (apache.org)|https://downloads.apache.org/cassandra/redhat/40x/] > > we are looking to download 4.0.6 from the above link but 4.0.5 package is > getting downloaded > > we are following below steps and 4.0.6 is not part of the yum repository > - [Install Cassandra In CentOS Linux - > OSTechNix|https://ostechnix.com/install-cassandra-in-centos/] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17910) Cassandra repo not updated with latest 4.0.6 package
deepagkanaka created CASSANDRA-17910: Summary: Cassandra repo not updated with latest 4.0.6 package Key: CASSANDRA-17910 URL: https://issues.apache.org/jira/browse/CASSANDRA-17910 Project: Cassandra Issue Type: Bug Reporter: deepagkanaka Hi Team, The repo is not updated with latest package -[Index of /cassandra/redhat/40x (apache.org)|https://downloads.apache.org/cassandra/redhat/40x/] we are looking to download 4.0.6 from the above link but 4.0.5 package is getting downloaded we are following below steps and 4.0.6 is not part of the yum repository - [Install Cassandra In CentOS Linux - OSTechNix|https://ostechnix.com/install-cassandra-in-centos/] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (adb0b93b -> 38146132)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard adb0b93b generate docs for 538513bd new 38146132 generate docs for 538513bd This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (adb0b93b) \ N -- N -- N refs/heads/asf-staging (38146132) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17248) Fix Prepared Statements behaviours after 15252
[
https://issues.apache.org/jira/browse/CASSANDRA-17248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607486#comment-17607486
]
Jaydeepkumar Chovatia edited comment on CASSANDRA-17248 at 9/21/22 4:30 AM:
[~ifesdjeen] I've created a patch (on 3.0 for now) that includes the following:
# It Fixes the potential root cause in which we should never ever prepare a
statement for non-fully qualified queries with null keyspace
# With this patch, collision for two keyspaces having the same schema should
never ever occur. Let's say in the worst scenario, it does happen, then it is a
bug on the Cassandra server we need to investigate. Cassandra should never
silently ignore it as it leads to a *{color:#de350b}disastrous{color}*
situation to be in. This patch throws an exception back to the user instead of
silently ignoring it.
# Additional stats that tell us prepared statement behavior, such as cache
used, empty prepared statements, etc.
# Last but not least, unit test cases that would cover collision scenarios.
The test cases added in this diff passed with 3.0.14 - fails with 3.0.26 (w/o
this patch) - but passed with this patch
Please find the 3.0 Patch here:
[https://github.com/jaydeepkumar1984/cassandra/pull/1/commits/37e60cac04df6c7042f4a83f50c046effc60ac04]
Please review it and then I will create more patches for 3.11, 4.0, and trunk.
was (Author: chovatia.jayd...@gmail.com):
[~ifesdjeen] I've created a patch (on 3.0 for now) that includes the following:
# It Fixes the potential root cause in which we should never ever prepare a
statement for non-fully qualified queries with null keyspace
# With this patch, collision for two keyspaces having the same schema should
never ever occur. Let's say in the worst scenario, it does happen, and then it
is a bug on the Cassandra server we need to investigate. Cassandra should never
silently ignore it as it leads to a *{color:#de350b}disastrous{color}*
situation to be in. This patch throws an exception back to the user instead of
silently ignoring it.
# Additional stats that tell us prepared statement behavior, such as cache
used, empty prepared statements, etc.
# Last but not least, unit test cases that would cover collision scenarios.
The test cases added in this diff passed with 3.0.14 - fails with 3.0.26 (w/o
this patch) - but passed with this patch
Please find the 3.0 Patch here:
[https://github.com/jaydeepkumar1984/cassandra/pull/1/commits/37e60cac04df6c7042f4a83f50c046effc60ac04]
Please review it and then I will create more patches for 3.11, 4.0, and trunk.
> Fix Prepared Statements behaviours after 15252
> --
>
> Key: CASSANDRA-17248
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17248
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 3.0.26, 3.11.12, 4.0.2
>
>
> [CASSANDRA-15252] has fixed an important issue: unwanted hash changes when
> preparing fully qualified prepared statements which was causing
> cluster-killing re-prepare loops. However, the fix introduced a regression:
> non-qualified statements can get prepared against one keyspace but then
> executed on another under some circumstances. This patch reconciles all
> behaviours.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17248) Fix Prepared Statements behaviours after 15252
[
https://issues.apache.org/jira/browse/CASSANDRA-17248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607486#comment-17607486
]
Jaydeepkumar Chovatia edited comment on CASSANDRA-17248 at 9/21/22 4:03 AM:
[~ifesdjeen] I've created a patch (on 3.0 for now) that includes the following:
# It Fixes the potential root cause in which we should never ever prepare a
statement for non-fully qualified queries with null keyspace
# With this patch, collision for two keyspaces having the same schema should
never ever occur. Let's say in the worst scenario, it does happen, and then it
is a bug on the Cassandra server we need to investigate. Cassandra should never
silently ignore it as it leads to a *{color:#de350b}disastrous{color}*
situation to be in. This patch throws an exception back to the user instead of
silently ignoring it.
# Additional stats that tell us prepared statement behavior, such as cache
used, empty prepared statements, etc.
# Last but not least, unit test cases that would cover collision scenarios.
The test cases added in this diff passed with 3.0.14 - fails with 3.0.26 (w/o
this patch) - but passed with this patch
Please find the 3.0 Patch here:
[https://github.com/jaydeepkumar1984/cassandra/pull/1/commits/37e60cac04df6c7042f4a83f50c046effc60ac04]
Please review it and then I will create more patches for 3.11, 4.0, and trunk.
was (Author: chovatia.jayd...@gmail.com):
[~ifesdjeen] I've created a patch (on 3.0 for now) that includes the following:
# It Fixes the potential root cause in which we should never ever prepare a
statement for non-fully qualified queries with null keyspace
# With this patch, collision for two keyspaces having the same schema should
never ever occur. Let's say in the worst scenario, it does happen, and then it
is a bug on the Cassandra server we need to investigate. Cassandra should never
silently ignore it as it leads to a *{color:#de350b}disastrous{color}*
situation to be in. This patch throws an exception back to the user instead of
silently ignoring it.
# Additional stats that tell us prepared statement behavior, such as cache
used, empty prepared statements, etc.
# Last but not least, unit test cases that would cover collision scenarios.
The test cases added in this diff passed with 3.0.14 - fails with 3.0.26 (w/o
this patch) - but passed with this patch
Please find the 3.0 Patch here:
[https://github.com/jaydeepkumar1984/cassandra/pull/1/commits/37e60cac04df6c7042f4a83f50c046effc60ac04]
Please review it and then I will create more patches for 3.11 and 4.9.
> Fix Prepared Statements behaviours after 15252
> --
>
> Key: CASSANDRA-17248
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17248
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 3.0.26, 3.11.12, 4.0.2
>
>
> [CASSANDRA-15252] has fixed an important issue: unwanted hash changes when
> preparing fully qualified prepared statements which was causing
> cluster-killing re-prepare loops. However, the fix introduced a regression:
> non-qualified statements can get prepared against one keyspace but then
> executed on another under some circumstances. This patch reconciles all
> behaviours.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17248) Fix Prepared Statements behaviours after 15252
[
https://issues.apache.org/jira/browse/CASSANDRA-17248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607486#comment-17607486
]
Jaydeepkumar Chovatia commented on CASSANDRA-17248:
---
[~ifesdjeen] I've created a patch (on 3.0 for now) that includes the following:
# It Fixes the potential root cause in which we should never ever prepare a
statement for non-fully qualified queries with null keyspace
# With this patch, collision for two keyspaces having the same schema should
never ever occur. Let's say in the worst scenario, it does happen, and then it
is a bug on the Cassandra server we need to investigate. Cassandra should never
silently ignore it as it leads to a *{color:#de350b}disastrous{color}*
situation to be in. This patch throws an exception back to the user instead of
silently ignoring it.
# Additional stats that tell us prepared statement behavior, such as cache
used, empty prepared statements, etc.
# Last but not least, unit test cases that would cover collision scenarios.
The test cases added in this diff passed with 3.0.14 - fails with 3.0.26 (w/o
this patch) - but passed with this patch
Please find the 3.0 Patch here:
[https://github.com/jaydeepkumar1984/cassandra/pull/1/commits/37e60cac04df6c7042f4a83f50c046effc60ac04]
Please review it and then I will create more patches for 3.11 and 4.9.
> Fix Prepared Statements behaviours after 15252
> --
>
> Key: CASSANDRA-17248
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17248
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 3.0.26, 3.11.12, 4.0.2
>
>
> [CASSANDRA-15252] has fixed an important issue: unwanted hash changes when
> preparing fully qualified prepared statements which was causing
> cluster-killing re-prepare loops. However, the fix introduced a regression:
> non-qualified statements can get prepared against one keyspace but then
> executed on another under some circumstances. This patch reconciles all
> behaviours.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (d4a4a438 -> adb0b93b)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d4a4a438 generate docs for 538513bd new adb0b93b generate docs for 538513bd This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d4a4a438) \ N -- N -- N refs/heads/asf-staging (adb0b93b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17901) ccm logs not being collected to nightlies
[
https://issues.apache.org/jira/browse/CASSANDRA-17901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607480#comment-17607480
]
Michael Semb Wever commented on CASSANDRA-17901:
+1
> ccm logs not being collected to nightlies
> -
>
> Key: CASSANDRA-17901
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17901
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> At least some of the time, Jenkins is failing to collect ccm logs and is
> uploading a zero byte tar archive to nightlies, for example:
> https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-dtest/1100/Cassandra-trunk-dtest/label=cassandra-dtest,split=5/
> {quote}
> 09:25:06 + tar -cJf ccm_logs.tar.xz './tmp/*/test/*/logs/*'
> 09:25:06 tar: ./tmp/*/test/*/logs/*: Cannot stat: No such file or directory
> 09:25:06 tar: Exiting with failure status due to previous errors
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Description: During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] (JDK 7) in SyncUtil. >From a very quick skim _I think_ the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at >least until we have JDK11. To be revisited. was: During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] (JDK 7) in SyncUtil. >From a very quick skim I think the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at >least until we have JDK11. To be revisited. > Clean SyncUtil from dead code > - > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17909) Clean SyncUtil from dead code
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-17909: --- Assignee: Ekaterina Dimitrova > Clean SyncUtil from dead code > - > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Description: During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] (JDK 7) in SyncUtil. >From a very quick skim I think the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at >least until we have JDK11. To be revisited. was: During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] (JDK 7) in SyncUtil. >From a very quick skim I think the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To >be revisited. > Clean SyncUtil from dead code > - > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim I think the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Description: During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] (JDK 7) in SyncUtil. >From a very quick skim I think the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To >be revisited. was: During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] in SyncUtil. >From a very quick skim I think the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To >be revisited. > Clean SyncUtil from dead code > - > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim I think the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To > be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Bug Category: Parent values: Correctness(12982) Complexity: Normal Component/s: Local/Other Discovered By: User Report Severity: Normal Status: Open (was: Triage Needed) > Clean SyncUtil from dead code > - > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Priority: Normal > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > in SyncUtil. > From a very quick skim I think the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To > be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Fix Version/s: 4.x > Clean SyncUtil from dead code > - > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > in SyncUtil. > From a very quick skim I think the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To > be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17909) Clean SyncUtil from dead code
Ekaterina Dimitrova created CASSANDRA-17909: --- Summary: Clean SyncUtil from dead code Key: CASSANDRA-17909 URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 Project: Cassandra Issue Type: Bug Reporter: Ekaterina Dimitrova During code inspection I noticed [dead code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] in SyncUtil. >From a very quick skim I think the [Java 8 >section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay. To >be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17885) Add solution for CASSANDRA-17581 to older branches for tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607456#comment-17607456 ] Ekaterina Dimitrova edited comment on CASSANDRA-17885 at 9/21/22 1:59 AM: -- Unfortunately, there are more upgrade tests to handle for [4.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1933/workflows/daffc899-bf3f-41ca-aca2-156c1b6c706b/jobs/15303], [4.1|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1934/workflows/05c39d2a-0895-4157-ad99-ccfe099cb38e] and [trunk|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1935/workflows/2374a071-a635-4c92-a3bf-343beb201f82/jobs/15392] [3.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231/jobs/15293/tests] and [3.11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2] - there are a bunch of tests with this failure, but they shouldn't run there at all, so different type of issue. And it happens only in CircleCI, those are skipped in Jenkins.(100% sure about 3.0 and still need to test 3.11 but I am 99% sure it is the same case) Not sure what the story is there. I've seen something like that before and I thought there was a ticket but I cannot find it now. was (Author: e.dimitrova): Unfortunately, there are more upgrade tests to handle for [4.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1933/workflows/daffc899-bf3f-41ca-aca2-156c1b6c706b/jobs/15303], [4.1|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1934/workflows/05c39d2a-0895-4157-ad99-ccfe099cb38e] and [trunk|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1935/workflows/2374a071-a635-4c92-a3bf-343beb201f82/jobs/15392] [3.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231/jobs/15293/tests] and [3.11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2] - there are a bunch of tests with this failure, but they shouldn't run there at all, so different type of issue. And it happens only in CircleCI, those are skipped in Jenkins. Not sure what the story is there. I've seen something like that before and I thought there was a ticket but I cannot find it now. > Add solution for CASSANDRA-17581 to older branches for tests > > > Key: CASSANDRA-17885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17885 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.1-beta, 4.1 > > > Some of our tests use old branches for the purposes of testing upgrades and > behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on > nodetool with a modern JDK. We can port this fix to those branches and > adjust the tests to use the newest version of them to solve this going > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17885) Add solution for CASSANDRA-17581 to older branches for tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607456#comment-17607456 ] Ekaterina Dimitrova commented on CASSANDRA-17885: - Unfortunately, there are more upgrade tests to handle for [4.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1933/workflows/daffc899-bf3f-41ca-aca2-156c1b6c706b/jobs/15303], [4.1|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1934/workflows/05c39d2a-0895-4157-ad99-ccfe099cb38e] and [trunk|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1935/workflows/2374a071-a635-4c92-a3bf-343beb201f82/jobs/15392] [3.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231/jobs/15293/tests] and [3.11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2] - there are a bunch of tests with this failure, but they shouldn't run there at all, so different type of issue. And it happens only in CircleCI, those are skipped in Jenkins. Not sure what the story is there. I've seen something like that before and I thought there was a ticket but I cannot find it now. > Add solution for CASSANDRA-17581 to older branches for tests > > > Key: CASSANDRA-17885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17885 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.1-beta, 4.1 > > > Some of our tests use old branches for the purposes of testing upgrades and > behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on > nodetool with a modern JDK. We can port this fix to those branches and > adjust the tests to use the newest version of them to solve this going > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17879) It is not possible to autocomplete "WITH" when creating materialized view
[
https://issues.apache.org/jira/browse/CASSANDRA-17879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607445#comment-17607445
]
Brad Schoening edited comment on CASSANDRA-17879 at 9/21/22 1:23 AM:
-
In cql3handling.py, it uses this completer_for syntax with and without a
decorator, for example:
{code:java}
@completer_for('createColumnFamilyStatement', 'wat')
def create_cf_wat_completer(ctxt, cass):
# would prefer to get rid of the "columnfamily" nomenclature in cql3
if ctxt.get_binding('partial', '') == '':
return ['TABLE']
return ['TABLE', 'COLUMNFAMILY']
{code}
{code:java}
@completer_for('createColumnFamilyStatement', 'dot')
def create_cf_ks_dot_completer(ctxt, cass):
ks = dequote_name(ctxt.get_binding('ks'))
if ks in cass.get_keyspace_names():
return ['.']
return []
{code}
{code:java}
completer_for('columnFamilyName', 'ksname')(cf_ks_name_completer)
completer_for('materializedViewName', 'ksname')(cf_ks_name_completer)
{code}
but there doesn't appear to be one for createMaterializedView:
{code:java}
% grep completer_for cql3handling.py | grep create
@completer_for('createKeyspaceStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'dot')
@completer_for('createIndexStatement', 'col')
{code}
It seems there is some cleanup and refactoring needed here to remove the
obsolete columnfamily nomenclature before replicating this for
createMaterializedView. I'm not really following the logic in the code here.
was (Author: bschoeni):
In cql3handling.py, it uses this completer_for syntax with and without a
decorator, for example:
{code:java}
@completer_for('createColumnFamilyStatement', 'wat')
def create_cf_wat_completer(ctxt, cass):
# would prefer to get rid of the "columnfamily" nomenclature in cql3
if ctxt.get_binding('partial', '') == '':
return ['TABLE']
return ['TABLE', 'COLUMNFAMILY']
{code}
{code:java}
@completer_for('createColumnFamilyStatement', 'dot')
def create_cf_ks_dot_completer(ctxt, cass):
ks = dequote_name(ctxt.get_binding('ks'))
if ks in cass.get_keyspace_names():
return ['.']
return []
{code}
{code:java}
completer_for('columnFamilyName', 'ksname')(cf_ks_name_completer)
completer_for('materializedViewName', 'ksname')(cf_ks_name_completer)
{code}
but there doesn't appear to be one for createMaterializedView:
{code:java}
% grep completer_for cql3handling.py | grep create
@completer_for('createKeyspaceStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'dot')
@completer_for('createIndexStatement', 'col')
{code}
It seems there is some cleanup and refactoring needed here to remove the
obsolete columnfamily nomenclature before replicating this for
createMaterializedView. I'm not really following the logic in the code here.
> It is not possible to autocomplete "WITH" when creating materialized view
> -
>
> Key: CASSANDRA-17879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17879
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Miklosovic
>Priority: Normal
>
> I noticed that when I type this:
> {code}
> CREATE MATERIALIZED VIEW ks.mv2 AS SELECT * FROM t WHERE k IS NOT NULL AND c1
> IS NOT NULL AND c2 IS NOT NULL PRIMARY KEY (c1,k,c2)
> {code}
> nothing happens after pressing tab, there should be options shown as for
> table case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17879) It is not possible to autocomplete "WITH" when creating materialized view
[
https://issues.apache.org/jira/browse/CASSANDRA-17879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607445#comment-17607445
]
Brad Schoening edited comment on CASSANDRA-17879 at 9/21/22 1:23 AM:
-
In cql3handling.py, it uses this completer_for syntax with and without a
decorator, for example:
{code:java}
@completer_for('createColumnFamilyStatement', 'wat')
def create_cf_wat_completer(ctxt, cass):
# would prefer to get rid of the "columnfamily" nomenclature in cql3
if ctxt.get_binding('partial', '') == '':
return ['TABLE']
return ['TABLE', 'COLUMNFAMILY']
{code}
{code:java}
@completer_for('createColumnFamilyStatement', 'dot')
def create_cf_ks_dot_completer(ctxt, cass):
ks = dequote_name(ctxt.get_binding('ks'))
if ks in cass.get_keyspace_names():
return ['.']
return []
{code}
{code:java}
completer_for('columnFamilyName', 'ksname')(cf_ks_name_completer)
completer_for('materializedViewName', 'ksname')(cf_ks_name_completer)
{code}
but there doesn't appear to be one for createMaterializedView:
{code:java}
% grep completer_for cql3handling.py | grep create
@completer_for('createKeyspaceStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'dot')
@completer_for('createIndexStatement', 'col')
{code}
It seems there is some cleanup and refactoring needed here to remove the
obsolete columnfamily nomenclature before replicating this for
createMaterializedView. I'm not really following the logic in the code here.
was (Author: bschoeni):
In cql3handling.py, it uses this @completer_for syntax, for example:
{code:java}
@completer_for('createColumnFamilyStatement', 'wat')
def create_cf_wat_completer(ctxt, cass):
# would prefer to get rid of the "columnfamily" nomenclature in cql3
if ctxt.get_binding('partial', '') == '':
return ['TABLE']
return ['TABLE', 'COLUMNFAMILY']
{code}
{code:java}
@completer_for('createColumnFamilyStatement', 'dot')
def create_cf_ks_dot_completer(ctxt, cass):
ks = dequote_name(ctxt.get_binding('ks'))
if ks in cass.get_keyspace_names():
return ['.']
return []
{code}
but there doesn't appear to be one for createMaterializedView:
{code:java}
% grep completer_for cql3handling.py | grep create
@completer_for('createKeyspaceStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'dot')
@completer_for('createIndexStatement', 'col')
{code}
It seems there is some cleanup and refactoring needed here to remove the
obsolete columnfamily nomenclature before replicating this for
createMaterializedView.
> It is not possible to autocomplete "WITH" when creating materialized view
> -
>
> Key: CASSANDRA-17879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17879
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Miklosovic
>Priority: Normal
>
> I noticed that when I type this:
> {code}
> CREATE MATERIALIZED VIEW ks.mv2 AS SELECT * FROM t WHERE k IS NOT NULL AND c1
> IS NOT NULL AND c2 IS NOT NULL PRIMARY KEY (c1,k,c2)
> {code}
> nothing happens after pressing tab, there should be options shown as for
> table case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17879) It is not possible to autocomplete "WITH" when creating materialized view
[
https://issues.apache.org/jira/browse/CASSANDRA-17879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607445#comment-17607445
]
Brad Schoening commented on CASSANDRA-17879:
In cql3handling.py, it uses this @completer_for syntax, for example:
{code:java}
@completer_for('createColumnFamilyStatement', 'wat')
def create_cf_wat_completer(ctxt, cass):
# would prefer to get rid of the "columnfamily" nomenclature in cql3
if ctxt.get_binding('partial', '') == '':
return ['TABLE']
return ['TABLE', 'COLUMNFAMILY']
{code}
{code:java}
@completer_for('createColumnFamilyStatement', 'dot')
def create_cf_ks_dot_completer(ctxt, cass):
ks = dequote_name(ctxt.get_binding('ks'))
if ks in cass.get_keyspace_names():
return ['.']
return []
{code}
but there doesn't appear to be one for createMaterializedView:
{code:java}
% grep completer_for cql3handling.py | grep create
@completer_for('createKeyspaceStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'wat')
@completer_for('createColumnFamilyStatement', 'dot')
@completer_for('createIndexStatement', 'col')
{code}
It seems there is some cleanup and refactoring needed here to remove the
obsolete columnfamily nomenclature before replicating this for
createMaterializedView.
> It is not possible to autocomplete "WITH" when creating materialized view
> -
>
> Key: CASSANDRA-17879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17879
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Miklosovic
>Priority: Normal
>
> I noticed that when I type this:
> {code}
> CREATE MATERIALIZED VIEW ks.mv2 AS SELECT * FROM t WHERE k IS NOT NULL AND c1
> IS NOT NULL AND c2 IS NOT NULL PRIMARY KEY (c1,k,c2)
> {code}
> nothing happens after pressing tab, there should be options shown as for
> table case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (6c4ccb5f -> d4a4a438)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 6c4ccb5f generate docs for 538513bd new d4a4a438 generate docs for 538513bd This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (6c4ccb5f) \ N -- N -- N refs/heads/asf-staging (d4a4a438) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14218) Deprecate Throwables.propagate usage
[
https://issues.apache.org/jira/browse/CASSANDRA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607424#comment-17607424
]
Caleb Rackliffe commented on CASSANDRA-14218:
-
[~claude] I've posted a new/rebased PR
[here|https://github.com/apache/cassandra/pull/1870]. It's just a cherry-pick
of your patch, with an extra cleanup commit. Take a look at that, and if you
have no issues w/ it (and assuming the tests in progress look good) we just
need one more committer to +1 and I can commit it for you. Thanks!
> Deprecate Throwables.propagate usage
>
>
> Key: CASSANDRA-14218
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14218
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Romain Hardouin
>Assignee: Claude Warren
>Priority: Low
> Labels: lhf
> Fix For: 4.x
>
> Attachments: 14218-trunk.txt, 14218-trunk.txt, CASSANDRA-14218.txt
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Google decided to deprecate guava {{Throwables.propagate}} method:
> * [Why we deprecated
> Throwables.propagate|https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate]
> * [Documentation
> update|https://github.com/google/guava/wiki/ThrowablesExplained/_compare/92190ee7e37d334fa5fcdb6db8d0f43a2fdf02e1...226a3060445716d479981e606f589c99eee517ca]
> We have 35 occurences in the trunk:
> {code:java}
> $ rg -c 'Throwables.propagate' *
> src/java/org/apache/cassandra/streaming/StreamReader.java:1
> src/java/org/apache/cassandra/streaming/StreamTransferTask.java:1
> src/java/org/apache/cassandra/db/SnapshotDetailsTabularData.java:1
> src/java/org/apache/cassandra/db/Memtable.java:1
> src/java/org/apache/cassandra/db/ColumnFamilyStore.java:4
> src/java/org/apache/cassandra/cache/ChunkCache.java:2
> src/java/org/apache/cassandra/utils/WrappedRunnable.java:1
> src/java/org/apache/cassandra/hints/Hint.java:1
> src/java/org/apache/cassandra/tools/LoaderOptions.java:1
> src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java:1
> src/java/org/apache/cassandra/streaming/management/ProgressInfoCompositeData.java:3
> src/java/org/apache/cassandra/streaming/management/StreamStateCompositeData.java:2
> src/java/org/apache/cassandra/streaming/management/StreamSummaryCompositeData.java:2
> src/java/org/apache/cassandra/streaming/compress/CompressedStreamReader.java:1
> src/java/org/apache/cassandra/db/compaction/Scrubber.java:1
> src/java/org/apache/cassandra/db/compaction/Verifier.java:1
> src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:1
> src/java/org/apache/cassandra/db/compaction/Upgrader.java:1
> src/java/org/apache/cassandra/io/compress/CompressionMetadata.java:1
> src/java/org/apache/cassandra/streaming/management/SessionCompleteEventCompositeData.java:2
> src/java/org/apache/cassandra/io/sstable/SSTableSimpleWriter.java:1
> src/java/org/apache/cassandra/io/sstable/ISSTableScanner.java:1
> src/java/org/apache/cassandra/streaming/management/SessionInfoCompositeData.java:3
> src/java/org/apache/cassandra/io/sstable/SSTableSimpleUnsortedWriter.java:1
> {code}
> I don't know if we want to remove all usages but we should at least check
> author's intention for each usage and refactor if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14218) Deprecate Throwables.propagate usage
[
https://issues.apache.org/jira/browse/CASSANDRA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607405#comment-17607405
]
Caleb Rackliffe commented on CASSANDRA-14218:
-
[~claude] I'll take a look, although we might still need a second committer to
+1
> Deprecate Throwables.propagate usage
>
>
> Key: CASSANDRA-14218
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14218
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Romain Hardouin
>Assignee: Claude Warren
>Priority: Low
> Labels: lhf
> Fix For: 4.x
>
> Attachments: 14218-trunk.txt, 14218-trunk.txt, CASSANDRA-14218.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Google decided to deprecate guava {{Throwables.propagate}} method:
> * [Why we deprecated
> Throwables.propagate|https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate]
> * [Documentation
> update|https://github.com/google/guava/wiki/ThrowablesExplained/_compare/92190ee7e37d334fa5fcdb6db8d0f43a2fdf02e1...226a3060445716d479981e606f589c99eee517ca]
> We have 35 occurences in the trunk:
> {code:java}
> $ rg -c 'Throwables.propagate' *
> src/java/org/apache/cassandra/streaming/StreamReader.java:1
> src/java/org/apache/cassandra/streaming/StreamTransferTask.java:1
> src/java/org/apache/cassandra/db/SnapshotDetailsTabularData.java:1
> src/java/org/apache/cassandra/db/Memtable.java:1
> src/java/org/apache/cassandra/db/ColumnFamilyStore.java:4
> src/java/org/apache/cassandra/cache/ChunkCache.java:2
> src/java/org/apache/cassandra/utils/WrappedRunnable.java:1
> src/java/org/apache/cassandra/hints/Hint.java:1
> src/java/org/apache/cassandra/tools/LoaderOptions.java:1
> src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java:1
> src/java/org/apache/cassandra/streaming/management/ProgressInfoCompositeData.java:3
> src/java/org/apache/cassandra/streaming/management/StreamStateCompositeData.java:2
> src/java/org/apache/cassandra/streaming/management/StreamSummaryCompositeData.java:2
> src/java/org/apache/cassandra/streaming/compress/CompressedStreamReader.java:1
> src/java/org/apache/cassandra/db/compaction/Scrubber.java:1
> src/java/org/apache/cassandra/db/compaction/Verifier.java:1
> src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:1
> src/java/org/apache/cassandra/db/compaction/Upgrader.java:1
> src/java/org/apache/cassandra/io/compress/CompressionMetadata.java:1
> src/java/org/apache/cassandra/streaming/management/SessionCompleteEventCompositeData.java:2
> src/java/org/apache/cassandra/io/sstable/SSTableSimpleWriter.java:1
> src/java/org/apache/cassandra/io/sstable/ISSTableScanner.java:1
> src/java/org/apache/cassandra/streaming/management/SessionInfoCompositeData.java:3
> src/java/org/apache/cassandra/io/sstable/SSTableSimpleUnsortedWriter.java:1
> {code}
> I don't know if we want to remove all usages but we should at least check
> author's intention for each usage and refactor if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14218) Deprecate Throwables.propagate usage
[
https://issues.apache.org/jira/browse/CASSANDRA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-14218:
Reviewers: Caleb Rackliffe (was: Dinesh Joshi)
Status: Review In Progress (was: Needs Committer)
> Deprecate Throwables.propagate usage
>
>
> Key: CASSANDRA-14218
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14218
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Romain Hardouin
>Assignee: Claude Warren
>Priority: Low
> Labels: lhf
> Fix For: 4.x
>
> Attachments: 14218-trunk.txt, 14218-trunk.txt, CASSANDRA-14218.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Google decided to deprecate guava {{Throwables.propagate}} method:
> * [Why we deprecated
> Throwables.propagate|https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate]
> * [Documentation
> update|https://github.com/google/guava/wiki/ThrowablesExplained/_compare/92190ee7e37d334fa5fcdb6db8d0f43a2fdf02e1...226a3060445716d479981e606f589c99eee517ca]
> We have 35 occurences in the trunk:
> {code:java}
> $ rg -c 'Throwables.propagate' *
> src/java/org/apache/cassandra/streaming/StreamReader.java:1
> src/java/org/apache/cassandra/streaming/StreamTransferTask.java:1
> src/java/org/apache/cassandra/db/SnapshotDetailsTabularData.java:1
> src/java/org/apache/cassandra/db/Memtable.java:1
> src/java/org/apache/cassandra/db/ColumnFamilyStore.java:4
> src/java/org/apache/cassandra/cache/ChunkCache.java:2
> src/java/org/apache/cassandra/utils/WrappedRunnable.java:1
> src/java/org/apache/cassandra/hints/Hint.java:1
> src/java/org/apache/cassandra/tools/LoaderOptions.java:1
> src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java:1
> src/java/org/apache/cassandra/streaming/management/ProgressInfoCompositeData.java:3
> src/java/org/apache/cassandra/streaming/management/StreamStateCompositeData.java:2
> src/java/org/apache/cassandra/streaming/management/StreamSummaryCompositeData.java:2
> src/java/org/apache/cassandra/streaming/compress/CompressedStreamReader.java:1
> src/java/org/apache/cassandra/db/compaction/Scrubber.java:1
> src/java/org/apache/cassandra/db/compaction/Verifier.java:1
> src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:1
> src/java/org/apache/cassandra/db/compaction/Upgrader.java:1
> src/java/org/apache/cassandra/io/compress/CompressionMetadata.java:1
> src/java/org/apache/cassandra/streaming/management/SessionCompleteEventCompositeData.java:2
> src/java/org/apache/cassandra/io/sstable/SSTableSimpleWriter.java:1
> src/java/org/apache/cassandra/io/sstable/ISSTableScanner.java:1
> src/java/org/apache/cassandra/streaming/management/SessionInfoCompositeData.java:3
> src/java/org/apache/cassandra/io/sstable/SSTableSimpleUnsortedWriter.java:1
> {code}
> I don't know if we want to remove all usages but we should at least check
> author's intention for each usage and refactor if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17901) ccm logs not being collected to nightlies
[
https://issues.apache.org/jira/browse/CASSANDRA-17901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17901:
-
Test and Documentation Plan: run CI
Status: Patch Available (was: Open)
> ccm logs not being collected to nightlies
> -
>
> Key: CASSANDRA-17901
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17901
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> At least some of the time, Jenkins is failing to collect ccm logs and is
> uploading a zero byte tar archive to nightlies, for example:
> https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-dtest/1100/Cassandra-trunk-dtest/label=cassandra-dtest,split=5/
> {quote}
> 09:25:06 + tar -cJf ccm_logs.tar.xz './tmp/*/test/*/logs/*'
> 09:25:06 tar: ./tmp/*/test/*/logs/*: Cannot stat: No such file or directory
> 09:25:06 tar: Exiting with failure status due to previous errors
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17901) ccm logs not being collected to nightlies
[
https://issues.apache.org/jira/browse/CASSANDRA-17901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607392#comment-17607392
]
Brandon Williams commented on CASSANDRA-17901:
--
This is only an issue when the failure is due to errors found in the logs since
that failure exists outside of the normal failure path. I have a
[branch|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-17901] that
adds a direct 'failure' boolean to cleanup_cluster that is passed to consider
the test failed, and ultimately preserves the test directory when
--keep-failed-test-dir is being passed.
||Branch||CI||
|[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17901-3.0]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra/647/workflows/a8a333ff-bec7-4d99-a893-c08b22a84552]|
|[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-17901-3.11]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra/648/workflows/dadef426-9be8-40aa-920d-ffaa1f680222]|
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17901-4.0]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra/650/workflows/d8ab7bee-f5d2-4710-a239-47f89854bf01]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17901-4.1]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra/649/workflows/a909f314-258f-41a8-9e34-3df30c97342f]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17901-trunk]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra/646/workflows/c8efcf42-3524-4451-91c0-86ecb0620527]|
> ccm logs not being collected to nightlies
> -
>
> Key: CASSANDRA-17901
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17901
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> At least some of the time, Jenkins is failing to collect ccm logs and is
> uploading a zero byte tar archive to nightlies, for example:
> https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-dtest/1100/Cassandra-trunk-dtest/label=cassandra-dtest,split=5/
> {quote}
> 09:25:06 + tar -cJf ccm_logs.tar.xz './tmp/*/test/*/logs/*'
> 09:25:06 tar: ./tmp/*/test/*/logs/*: Cannot stat: No such file or directory
> 09:25:06 tar: Exiting with failure status due to previous errors
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (3608f67076 -> 286d2ee053)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 3608f67076 Merge branch 'cassandra-4.0' into cassandra-4.1 add 286d2ee053 Rework flaky CASTests No new revisions were added by this update. Summary of changes: .../apache/cassandra/distributed/test/CASTest.java | 84 +++--- .../cassandra/distributed/test/CASTestBase.java| 13 2 files changed, 89 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 73c0f7f2af061e8b7e79566e986769a06b06412a Merge: 38a356b10c 286d2ee053 Author: Blake Eggleston AuthorDate: Tue Sep 20 12:23:48 2022 -0700 Merge branch 'cassandra-4.1' into trunk .../apache/cassandra/distributed/test/CASTest.java | 84 +++--- .../cassandra/distributed/test/CASTestBase.java| 13 2 files changed, 89 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (38a356b10c -> 73c0f7f2af)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 38a356b10c Merge branch 'cassandra-4.1' into trunk add 286d2ee053 Rework flaky CASTests new 73c0f7f2af Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/distributed/test/CASTest.java | 84 +++--- .../cassandra/distributed/test/CASTestBase.java| 13 2 files changed, 89 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17861) Update Python test framework from nose to pytest in CCM
[ https://issues.apache.org/jira/browse/CASSANDRA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607373#comment-17607373 ] Ekaterina Dimitrova commented on CASSANDRA-17861: - Ha... it seems the README is incorrect actually and tricked me - it states nose, then if we open the tests I can see unittest actually... Seems like some revision is needed anyway... > Update Python test framework from nose to pytest in CCM > --- > > Key: CASSANDRA-17861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17861 > Project: Cassandra > Issue Type: Task > Components: Tool/external >Reporter: Ekaterina Dimitrova >Priority: Low > > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > Another migration to pytest was already done in CASSANDRA-17293 and it seems > not hard but at the same time valuable. > CC [~bschoeni] > [CCM|https://github.com/riptano/ccm] repo -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17762) LWT IF col = NULL is inconsistent with SQL NULL
[
https://issues.apache.org/jira/browse/CASSANDRA-17762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607367#comment-17607367
]
Ekaterina Dimitrova commented on CASSANDRA-17762:
-
I'll be looking into this one soon.
Reading here, it seems more or less there is some consensus but I guess I still
need to send mail to the ML at least for awareness?
To summarize:
_Utilizing {{IS NULL}} and {{IS NOT NULL in LWT}} (in practice we need to do it
everywhere including for column filtering (CASSANDRA-10715))._
_Even without looking at SQL we are also not consistent within CQL where we use
x {{= null}} and x != null for LWT but {{IS NOT NULL}} for Materialized views._
_On one side to be consistent in CQL, on another consistent with SQL._
_It should also be easy to support both syntaxes ({{{}x = null{}}}/{{{}X IS
NULL{}}}) while warning the user that the first syntax is deprecated until the
next major release._
I guess the question is [~avi.kivity]'s point around NULL being valid in SQL.
Shall we deal with the change of meaning for X = NULL as part of this ticket or
just deprecate for now X = NULL and spin that part into another ticket? And
still bring that to the mailing list...
There were a few discussions in parallel around CQL syntax lately so I hope I
didn't miss any point here.
> LWT IF col = NULL is inconsistent with SQL NULL
> ---
>
> Key: CASSANDRA-17762
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17762
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Avi Kivity
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
> In SQL, any comparison with NULL is NULL, which is interpreted as FALSE in a
> condition. To test for NULLness, you use IS NULL or IS NOT NULL.
> But LWT uses IF col = NULL as a NULLness test. This is likely to confuse
> people coming from SQL and hamper attempts to extend the dialect.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17908) IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied
[
https://issues.apache.org/jira/browse/CASSANDRA-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17908:
--
Description:
org.apache.cassandra.gms.Gossiper#order was added due to sub-systems depending
on a happens-before relationship of events even though Gossip does not provide
such ordering… to help out we “order” the events discovered by gossip so we
apply them in a predictable order… This has been found to have issues where we
add the elements into the global state and under some conditions they get
mutated causing ordering to fail
{code}
ERROR 2022-09-01T19:04:24,789 [GossipStage:1]
org.apache.cassandra.service.CassandraDaemon:234 - Exception in thread
Thread[GossipStage:1,5,main]
java.lang.IllegalArgumentException: Comparison method violates its general
contract!
at java.util.TimSort.mergeLo(TimSort.java:777)
at java.util.TimSort.mergeAt(TimSort.java:514)
at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
at java.util.TimSort.sort(TimSort.java:254)
at java.util.Arrays.sort(Arrays.java:1512)
at java.util.ArrayList.sort(ArrayList.java:1464)
at java.util.Collections.sort(Collections.java:177)
at org.apache.cassandra.gms.Gossiper.order(Gossiper.java:1327)
at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1334)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:70)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:116)
at java.lang.Thread.run(Thread.java:750) [?:1.8.0_345]
{code}
was:
org.apache.cassandra.gms.Gossiper#order was added due to sub-systems depending
on a happens-before relationship of events even though Gossip does not provide
such ordering… to help out we “order” the events discovered by gossip so we
apply them in a predictable order… This has been found to have issues where we
add the elements into the global state and under some conditions they get
mutated causing ordering to fail
{code}
ERROR 2022-09-01T19:04:24,789 [GossipStage:1]
org.apache.cassandra.service.CassandraDaemon:234 - Exception in thread
Thread[GossipStage:1,5,main]
java.lang.IllegalArgumentException: Comparison method violates its general
contract!
at java.util.TimSort.mergeLo(TimSort.java:777) ~[?:1.8.0_345]
at java.util.TimSort.mergeAt(TimSort.java:514) ~[?:1.8.0_345]
at java.util.TimSort.mergeForceCollapse(TimSort.java:457) ~[?:1.8.0_345]
at java.util.TimSort.sort(TimSort.java:254) ~[?:1.8.0_345]
at java.util.Arrays.sort(Arrays.java:1512) ~[?:1.8.0_345]
at java.util.ArrayList.sort(ArrayList.java:1464) ~[?:1.8.0_345]
at java.util.Collections.sort(Collections.java:177) ~[?:1.8.0_345]
at org.apache.cassandra.gms.Gossiper.order(Gossiper.java:1327)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1334)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:70)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
~[?:1.8.0_345]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_345]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
~[?:1.8.0_345]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
~[?:1.8.0_345]
at
org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:116)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at java.lang.Thread.run(Thread.java:750) [?:1.8.0_345]
{code}
> IllegalArgumentException in Gossiper#order due to concurrent mutations to
> elements being applied
>
>
> Key: CASSANDRA-17908
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17908
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x
>
>
> org.apache.cassandra.gms.Gossiper#order was added due to sub-systems
> depending on a happens-before relationship of events even though Gossip does
> not provide such ordering… to help ou
[jira] [Commented] (CASSANDRA-17908) IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied
[
https://issues.apache.org/jira/browse/CASSANDRA-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607363#comment-17607363
]
David Capwell commented on CASSANDRA-17908:
---
does not apply to 4.1 just trunk, but its a critical bug for trunk
> IllegalArgumentException in Gossiper#order due to concurrent mutations to
> elements being applied
>
>
> Key: CASSANDRA-17908
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17908
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x
>
>
> org.apache.cassandra.gms.Gossiper#order was added due to sub-systems
> depending on a happens-before relationship of events even though Gossip does
> not provide such ordering… to help out we “order” the events discovered by
> gossip so we apply them in a predictable order… This has been found to have
> issues where we add the elements into the global state and under some
> conditions they get mutated causing ordering to fail
> {code}
> ERROR 2022-09-01T19:04:24,789 [GossipStage:1]
> org.apache.cassandra.service.CassandraDaemon:234 - Exception in thread
> Thread[GossipStage:1,5,main]
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:777) ~[?:1.8.0_345]
> at java.util.TimSort.mergeAt(TimSort.java:514) ~[?:1.8.0_345]
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457) ~[?:1.8.0_345]
> at java.util.TimSort.sort(TimSort.java:254) ~[?:1.8.0_345]
> at java.util.Arrays.sort(Arrays.java:1512) ~[?:1.8.0_345]
> at java.util.ArrayList.sort(ArrayList.java:1464) ~[?:1.8.0_345]
> at java.util.Collections.sort(Collections.java:177) ~[?:1.8.0_345]
> at org.apache.cassandra.gms.Gossiper.order(Gossiper.java:1327)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1334)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at
> org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:70)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[?:1.8.0_345]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_345]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[?:1.8.0_345]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[?:1.8.0_345]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:116)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at java.lang.Thread.run(Thread.java:750) [?:1.8.0_345]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17908) IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied
[
https://issues.apache.org/jira/browse/CASSANDRA-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17908:
--
Test and Documentation Plan: existing tests
Status: Patch Available (was: Open)
> IllegalArgumentException in Gossiper#order due to concurrent mutations to
> elements being applied
>
>
> Key: CASSANDRA-17908
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17908
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x
>
>
> org.apache.cassandra.gms.Gossiper#order was added due to sub-systems
> depending on a happens-before relationship of events even though Gossip does
> not provide such ordering… to help out we “order” the events discovered by
> gossip so we apply them in a predictable order… This has been found to have
> issues where we add the elements into the global state and under some
> conditions they get mutated causing ordering to fail
> {code}
> ERROR 2022-09-01T19:04:24,789 [GossipStage:1]
> org.apache.cassandra.service.CassandraDaemon:234 - Exception in thread
> Thread[GossipStage:1,5,main]
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:777) ~[?:1.8.0_345]
> at java.util.TimSort.mergeAt(TimSort.java:514) ~[?:1.8.0_345]
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457) ~[?:1.8.0_345]
> at java.util.TimSort.sort(TimSort.java:254) ~[?:1.8.0_345]
> at java.util.Arrays.sort(Arrays.java:1512) ~[?:1.8.0_345]
> at java.util.ArrayList.sort(ArrayList.java:1464) ~[?:1.8.0_345]
> at java.util.Collections.sort(Collections.java:177) ~[?:1.8.0_345]
> at org.apache.cassandra.gms.Gossiper.order(Gossiper.java:1327)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1334)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at
> org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:70)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[?:1.8.0_345]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_345]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[?:1.8.0_345]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[?:1.8.0_345]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:116)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at java.lang.Thread.run(Thread.java:750) [?:1.8.0_345]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17908) IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied
[
https://issues.apache.org/jira/browse/CASSANDRA-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17908:
--
Bug Category: Parent values: Availability(12983)Level 1 values: Process
Crash(12992)
Complexity: Low Hanging Fruit
Discovered By: User Report
Fix Version/s: 4.1.x
Severity: Critical
Status: Open (was: Triage Needed)
> IllegalArgumentException in Gossiper#order due to concurrent mutations to
> elements being applied
>
>
> Key: CASSANDRA-17908
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17908
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x
>
>
> org.apache.cassandra.gms.Gossiper#order was added due to sub-systems
> depending on a happens-before relationship of events even though Gossip does
> not provide such ordering… to help out we “order” the events discovered by
> gossip so we apply them in a predictable order… This has been found to have
> issues where we add the elements into the global state and under some
> conditions they get mutated causing ordering to fail
> {code}
> ERROR 2022-09-01T19:04:24,789 [GossipStage:1]
> org.apache.cassandra.service.CassandraDaemon:234 - Exception in thread
> Thread[GossipStage:1,5,main]
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeLo(TimSort.java:777) ~[?:1.8.0_345]
> at java.util.TimSort.mergeAt(TimSort.java:514) ~[?:1.8.0_345]
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457) ~[?:1.8.0_345]
> at java.util.TimSort.sort(TimSort.java:254) ~[?:1.8.0_345]
> at java.util.Arrays.sort(Arrays.java:1512) ~[?:1.8.0_345]
> at java.util.ArrayList.sort(ArrayList.java:1464) ~[?:1.8.0_345]
> at java.util.Collections.sort(Collections.java:177) ~[?:1.8.0_345]
> at org.apache.cassandra.gms.Gossiper.order(Gossiper.java:1327)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1334)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at
> org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:70)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[?:1.8.0_345]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_345]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[?:1.8.0_345]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[?:1.8.0_345]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:116)
> ~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
> at java.lang.Thread.run(Thread.java:750) [?:1.8.0_345]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17908) IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied
David Capwell created CASSANDRA-17908:
-
Summary: IllegalArgumentException in Gossiper#order due to
concurrent mutations to elements being applied
Key: CASSANDRA-17908
URL: https://issues.apache.org/jira/browse/CASSANDRA-17908
Project: Cassandra
Issue Type: Bug
Components: Cluster/Gossip
Reporter: David Capwell
Assignee: David Capwell
org.apache.cassandra.gms.Gossiper#order was added due to sub-systems depending
on a happens-before relationship of events even though Gossip does not provide
such ordering… to help out we “order” the events discovered by gossip so we
apply them in a predictable order… This has been found to have issues where we
add the elements into the global state and under some conditions they get
mutated causing ordering to fail
{code}
ERROR 2022-09-01T19:04:24,789 [GossipStage:1]
org.apache.cassandra.service.CassandraDaemon:234 - Exception in thread
Thread[GossipStage:1,5,main]
java.lang.IllegalArgumentException: Comparison method violates its general
contract!
at java.util.TimSort.mergeLo(TimSort.java:777) ~[?:1.8.0_345]
at java.util.TimSort.mergeAt(TimSort.java:514) ~[?:1.8.0_345]
at java.util.TimSort.mergeForceCollapse(TimSort.java:457) ~[?:1.8.0_345]
at java.util.TimSort.sort(TimSort.java:254) ~[?:1.8.0_345]
at java.util.Arrays.sort(Arrays.java:1512) ~[?:1.8.0_345]
at java.util.ArrayList.sort(ArrayList.java:1464) ~[?:1.8.0_345]
at java.util.Collections.sort(Collections.java:177) ~[?:1.8.0_345]
at org.apache.cassandra.gms.Gossiper.order(Gossiper.java:1327)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1334)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:70)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
~[?:1.8.0_345]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_345]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
~[?:1.8.0_345]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
~[?:1.8.0_345]
at
org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:116)
~[cie-cassandra-3.0.24.41.jar:3.0.24.41]
at java.lang.Thread.run(Thread.java:750) [?:1.8.0_345]
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17895) Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter components
[ https://issues.apache.org/jira/browse/CASSANDRA-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-17895: -- Fix Version/s: 4.0.7 4.1 4.2 (was: 4.x) (was: 4.0.x) (was: 4.1.x) Since Version: 4.0 Source Control Link: https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=22ec7eee7f340e8333055b2b10646cfe00cb6a84 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter > components > > > Key: CASSANDRA-17895 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17895 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.7, 4.1, 4.2 > > > Replacements can currently fail with a Direct buffer memory OOM; we need to > pass down transaction finish calls as mentioned in the Title to shore up a > current resource closing hole. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17895) Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter components
[ https://issues.apache.org/jira/browse/CASSANDRA-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-17895: -- Fix Version/s: 4.1-beta (was: 4.1) > Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter > components > > > Key: CASSANDRA-17895 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17895 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.7, 4.1-beta, 4.2 > > > Replacements can currently fail with a Direct buffer memory OOM; we need to > pass down transaction finish calls as mentioned in the Title to shore up a > current resource closing hole. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 3608f6707606bb940a3545568d5df634241c12e1 Merge: 1f90c9eb3d 22ec7eee7f Author: Josh McKenzie AuthorDate: Tue Sep 20 14:18:09 2022 -0400 Merge branch 'cassandra-4.0' into cassandra-4.1 CHANGES.txt | 1 + .../cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 7e164257ac,664791f43a..9025bf285b --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,50 -1,5 +1,51 @@@ +4.1-alpha2 + * We should not emit deprecation warning on startup for `key_cache_save_period`, `row_cache_save_period`, `counter_cache_save_period` (CASSANDRA-17904) + * upsert with adder support is not consistent with numbers and strings in LWT (CASSANDRA-17857) + * Fix race and return after failing connections (CASSANDRA-17618) + * Speculative execution threshold unit mismatch (CASSANDRA-17877) + * Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle (CASSANDRA-17677) + * Fix a race condition where a keyspace can be oopened while it is being removed (CASSANDRA-17658) + * DatabaseDescriptor will set the default failure detector during client initialization (CASSANDRA-17782) + * Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool (CASSANDRA-17740) + * Uncomment prepared_statements_cache_size, key_cache_size, counter_cache_size, index_summary_capacity which were + commented out by mistake in a previous patch + Fix breaking change with cache_load_timeout; cache_load_timeout_seconds <=0 and cache_load_timeout=0 are equivalent + and they both mean disabled + Deprecate public method setRate(final double throughputMbPerSec) in Compaction Manager in favor of + setRateInBytes(final double throughputBytesPerSec) + Revert breaking change removal of StressCQLSSTableWriter.Builder.withBufferSizeInMB(int size). Deprecate it in favor + of StressCQLSSTableWriter.Builder.withBufferSizeInMiB(int size) + Fix precision issues, add new -m flag (for nodetool/setstreamthroughput, nodetool/setinterdcstreamthroughput, + nodetool/getstreamthroughput and nodetoo/getinterdcstreamthroughput), add new -d flags (nodetool/getstreamthroughput, nodetool/getinterdcstreamthroughput, nodetool/getcompactionthroughput) + Fix a bug with precision in nodetool/compactionstats + Deprecate StorageService methods and add new ones for stream_throughput_outbound, inter_dc_stream_throughput_outbound, + compaction_throughput_outbound in the JMX MBean `org.apache.cassandra.db:type=StorageService` + Removed getEntireSSTableStreamThroughputMebibytesPerSec in favor of new getEntireSSTableStreamThroughputMebibytesPerSecAsDouble + in the JMX MBean `org.apache.cassandra.db:type=StorageService` + Removed getEntireSSTableInterDCStreamThroughputMebibytesPerSec in favor of getEntireSSTableInterDCStreamThroughputMebibytesPerSecAsDouble + in the JMX MBean `org.apache.cassandra.db:type=StorageService` (CASSANDRA-17725) + * Fix sstable_preemptive_open_interval disabled value. sstable_preemptive_open_interval = null backward compatible with + sstable_preemptive_open_interval_in_mb = -1 (CASSANDRA-17737) + * Remove usages of Path#toFile() in the snapshot apparatus (CASSANDRA-17769) + * Fix Settings Virtual Table to update paxos_variant after startup and rename enable_uuid_sstable_identifiers to + uuid_sstable_identifiers_enabled as per our config naming conventions (CASSANDRA-17738) + * index_summary_resize_interval_in_minutes = -1 is equivalent to index_summary_resize_interval being set to null or + disabled. JMX MBean IndexSummaryManager, setResizeIntervalInMinutes method still takes resizeIntervalInMinutes = -1 for disabled (CASSANDRA-17735) + * min_tracked_partition_size_bytes parameter from 4.1 alpha1 was renamed to min_tracked_partition_size (CASSANDRA-17733) + * Remove commons-lang dependency during build runtime (CASSANDRA-17724) + * Relax synchronization on StreamSession#onError() to avoid deadlock (CASSANDRA-17706) + * Fix AbstractCell#toString throws MarshalException for cell in collection (CASSANDRA-17695) + * Add new vtable output option to compactionstats (CASSANDRA-17683) + * Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog (CASSANDRA-17587) + * Fix widening to long in getBatchSizeFailThreshold (CASSANDRA-17650) + * Fix widening from mebibytes to bytes in IntMebibytesBound (CASSANDRA-17716) + * Revert breaking change in nodetool clientstats and expose cient options through nodetool clientstats --client-options. (CASSANDRA-17715) + * Fix missed nowInSec values in QueryProcessor (CASSANDRA-17458) + * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Buil
[cassandra] branch trunk updated (0aaad92f48 -> 38a356b10c)
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 0aaad92f48 Merge branch 'cassandra-4.1' into trunk new 22ec7eee7f Mitigate direct buffer memory OOM on replacements new 3608f67076 Merge branch 'cassandra-4.0' into cassandra-4.1 new 38a356b10c Merge branch 'cassandra-4.1' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + .../cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 38a356b10cb242d219894f9954684b8bf62fb2ac Merge: 0aaad92f48 3608f67076 Author: Josh McKenzie AuthorDate: Tue Sep 20 14:19:49 2022 -0400 Merge branch 'cassandra-4.1' into trunk CHANGES.txt | 1 + .../cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (1f90c9eb3d -> 3608f67076)
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 1f90c9eb3d Merge branch 'cassandra-4.0' into cassandra-4.1 new 22ec7eee7f Mitigate direct buffer memory OOM on replacements new 3608f67076 Merge branch 'cassandra-4.0' into cassandra-4.1 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + .../cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Mitigate direct buffer memory OOM on replacements
This is an automated email from the ASF dual-hosted git repository.
jmckenzie pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 22ec7eee7f Mitigate direct buffer memory OOM on replacements
22ec7eee7f is described below
commit 22ec7eee7f340e8333055b2b10646cfe00cb6a84
Author: Josh McKenzie
AuthorDate: Thu Sep 15 12:40:25 2022 -0400
Mitigate direct buffer memory OOM on replacements
Patch by Jon Meredith; reviewed by Josh McKenzie for CASSANDRA-17895
Co-authored-by: Jon Meredith
Co-authored-by: Josh McKenzie
---
CHANGES.txt | 1 +
.../cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java | 6 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 22bebd6e88..664791f43a 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0.7
+ * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895)
* Fix repair failure on assertion if two peers have overlapping mismatching
ranges (CASSANDRA-17900)
* Better handle null state in Gossip schema migration to avoid NPE
(CASSANDRA-17864)
* HintedHandoffAddRemoveNodesTest now accounts for the fact that
StorageMetrics.totalHints is not updated synchronously w/ writes
(CASSANDRA-16679)
diff --git
a/src/java/org/apache/cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java
b/src/java/org/apache/cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java
index f05ea94cb7..2564e966d4 100644
---
a/src/java/org/apache/cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java
+++
b/src/java/org/apache/cassandra/io/sstable/format/big/BigTableZeroCopyWriter.java
@@ -114,7 +114,7 @@ public class BigTableZeroCopyWriter extends SSTable
implements SSTableMultiWrite
out.write(buff, 0, count);
bytesRead += count;
}
-out.sync();
+out.sync(); // finish will also call sync(). Leaving here to get
stuff flushed as early as possible
}
catch (IOException e)
{
@@ -138,6 +138,10 @@ public class BigTableZeroCopyWriter extends SSTable
implements SSTableMultiWrite
public Collection finish(boolean openResult)
{
setOpenResult(openResult);
+
+for (SequentialWriter writer : componentWriters.values())
+writer.finish();
+
return finished();
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17861) Update Python test framework from nose to pytest in CCM
[ https://issues.apache.org/jira/browse/CASSANDRA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17861: Description: According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] h1. _Note to Users_ _Nose has been in maintenance mode for the past several years and will likely cease without a new person/team to take over maintainership. New projects should consider using [Nose2|https://github.com/nose-devs/nose2], [py.test|http://pytest.org/], or just plain unittest/unittest2._ Another migration to pytest was already done in CASSANDRA-17293 and it seems not hard but at the same time valuable. CC [~bschoeni] [CCM|https://github.com/riptano/ccm] repo was: According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] h1. _Note to Users_ _Nose has been in maintenance mode for the past several years and will likely cease without a new person/team to take over maintainership. New projects should consider using [Nose2|https://github.com/nose-devs/nose2], [py.test|http://pytest.org/], or just plain unittest/unittest2._ Another migration to pytest was already done in CASSANDRA-17293 and it seems not hard but at the same time valuable. CC [~bschoeni] [CCM|https://github.com/riptano/ccm] > Update Python test framework from nose to pytest in CCM > --- > > Key: CASSANDRA-17861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17861 > Project: Cassandra > Issue Type: Task > Components: Tool/external >Reporter: Ekaterina Dimitrova >Priority: Low > > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > Another migration to pytest was already done in CASSANDRA-17293 and it seems > not hard but at the same time valuable. > CC [~bschoeni] > [CCM|https://github.com/riptano/ccm] repo -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17861) Update Python test framework from nose to pytest in CCM
[ https://issues.apache.org/jira/browse/CASSANDRA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607340#comment-17607340 ] Ekaterina Dimitrova commented on CASSANDRA-17861: - It seems I forgot to link the CCM repo, apologize. Here it is - https://github.com/ekaterinadimitrova2/ccm > Update Python test framework from nose to pytest in CCM > --- > > Key: CASSANDRA-17861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17861 > Project: Cassandra > Issue Type: Task > Components: Tool/external >Reporter: Ekaterina Dimitrova >Priority: Low > > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > Another migration to pytest was already done in CASSANDRA-17293 and it seems > not hard but at the same time valuable. > CC [~bschoeni] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17861) Update Python test framework from nose to pytest in CCM
[ https://issues.apache.org/jira/browse/CASSANDRA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607340#comment-17607340 ] Ekaterina Dimitrova edited comment on CASSANDRA-17861 at 9/20/22 5:40 PM: -- It seems I forgot to link the CCM repo, apologize. Here it is - https://github.com/riptano/ccm was (Author: e.dimitrova): It seems I forgot to link the CCM repo, apologize. Here it is - https://github.com/ekaterinadimitrova2/ccm > Update Python test framework from nose to pytest in CCM > --- > > Key: CASSANDRA-17861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17861 > Project: Cassandra > Issue Type: Task > Components: Tool/external >Reporter: Ekaterina Dimitrova >Priority: Low > > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > Another migration to pytest was already done in CASSANDRA-17293 and it seems > not hard but at the same time valuable. > CC [~bschoeni] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17861) Update Python test framework from nose to pytest in CCM
[ https://issues.apache.org/jira/browse/CASSANDRA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17861: Description: According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] h1. _Note to Users_ _Nose has been in maintenance mode for the past several years and will likely cease without a new person/team to take over maintainership. New projects should consider using [Nose2|https://github.com/nose-devs/nose2], [py.test|http://pytest.org/], or just plain unittest/unittest2._ Another migration to pytest was already done in CASSANDRA-17293 and it seems not hard but at the same time valuable. CC [~bschoeni] [CCM|https://github.com/riptano/ccm] was: According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] h1. _Note to Users_ _Nose has been in maintenance mode for the past several years and will likely cease without a new person/team to take over maintainership. New projects should consider using [Nose2|https://github.com/nose-devs/nose2], [py.test|http://pytest.org/], or just plain unittest/unittest2._ Another migration to pytest was already done in CASSANDRA-17293 and it seems not hard but at the same time valuable. CC [~bschoeni] > Update Python test framework from nose to pytest in CCM > --- > > Key: CASSANDRA-17861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17861 > Project: Cassandra > Issue Type: Task > Components: Tool/external >Reporter: Ekaterina Dimitrova >Priority: Low > > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > Another migration to pytest was already done in CASSANDRA-17293 and it seems > not hard but at the same time valuable. > CC [~bschoeni] > [CCM|https://github.com/riptano/ccm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17868) Allow disabling hotness persistence, or tuning of rate limiter
[ https://issues.apache.org/jira/browse/CASSANDRA-17868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607333#comment-17607333 ] Stefan Miklosovic commented on CASSANDRA-17868: --- The added properties in config / dd have not been added into cassandra.yaml. > Allow disabling hotness persistence, or tuning of rate limiter > -- > > Key: CASSANDRA-17868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17868 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Rate Limiting >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.2 > > > The persisting of the sstables hotness when there are 10s of thousands of > sstables can have issues keeping up, and the rate limiter is hard coded. > Another option may be nice to just completely disable the feature. > When sstables super backed up (from repairs) the hotness tracking tends to > cause the STCS in L0 to make poor decisions, always grabbing the large > sstables and skipping the tiny sstables that would benefit more. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17900) Repair may fail with an assertion if two peers have overlapping mismatching ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-17900:
--
Fix Version/s: 4.0.7
4.1-beta
4.2
(was: 4.x)
(was: 4.0.x)
(was: 4.1.x)
Since Version: 4.0
Source Control Link:
https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=29c0ad80c919f02585f3ddfd7f9e0d2e80b62e2b
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Repair may fail with an assertion if two peers have overlapping mismatching
> ranges
> --
>
> Key: CASSANDRA-17900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17900
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.0.7, 4.1-beta, 4.2
>
>
> A little tweaking in {{RangeMap.java}} + a test showcasing it ought to tidy
> this up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0aaad92f48e8f5d0b5d1ed85c20edfac7de3f4d4 Merge: d80d934ed2 1f90c9eb3d Author: Josh McKenzie AuthorDate: Tue Sep 20 12:59:59 2022 -0400 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 1 + .../org/apache/cassandra/repair/asymmetric/RangeMap.java | 10 ++ .../apache/cassandra/repair/asymmetric/RangeMapTest.java | 14 -- 3 files changed, 19 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 1f90c9eb3d2063771f402450b6886f26afd81222 Merge: 4c85c6a403 29c0ad80c9 Author: Josh McKenzie AuthorDate: Tue Sep 20 12:57:51 2022 -0400 Merge branch 'cassandra-4.0' into cassandra-4.1 CHANGES.txt| 1 + .../org/apache/cassandra/repair/asymmetric/RangeMap.java | 10 ++ .../apache/cassandra/repair/asymmetric/RangeMapTest.java | 14 -- 3 files changed, 19 insertions(+), 6 deletions(-) diff --cc CHANGES.txt index afaf5d8acf,22bebd6e88..7e164257ac --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,50 -1,5 +1,51 @@@ +4.1-alpha2 + * We should not emit deprecation warning on startup for `key_cache_save_period`, `row_cache_save_period`, `counter_cache_save_period` (CASSANDRA-17904) + * upsert with adder support is not consistent with numbers and strings in LWT (CASSANDRA-17857) + * Fix race and return after failing connections (CASSANDRA-17618) + * Speculative execution threshold unit mismatch (CASSANDRA-17877) + * Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle (CASSANDRA-17677) + * Fix a race condition where a keyspace can be oopened while it is being removed (CASSANDRA-17658) + * DatabaseDescriptor will set the default failure detector during client initialization (CASSANDRA-17782) + * Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool (CASSANDRA-17740) + * Uncomment prepared_statements_cache_size, key_cache_size, counter_cache_size, index_summary_capacity which were + commented out by mistake in a previous patch + Fix breaking change with cache_load_timeout; cache_load_timeout_seconds <=0 and cache_load_timeout=0 are equivalent + and they both mean disabled + Deprecate public method setRate(final double throughputMbPerSec) in Compaction Manager in favor of + setRateInBytes(final double throughputBytesPerSec) + Revert breaking change removal of StressCQLSSTableWriter.Builder.withBufferSizeInMB(int size). Deprecate it in favor + of StressCQLSSTableWriter.Builder.withBufferSizeInMiB(int size) + Fix precision issues, add new -m flag (for nodetool/setstreamthroughput, nodetool/setinterdcstreamthroughput, + nodetool/getstreamthroughput and nodetoo/getinterdcstreamthroughput), add new -d flags (nodetool/getstreamthroughput, nodetool/getinterdcstreamthroughput, nodetool/getcompactionthroughput) + Fix a bug with precision in nodetool/compactionstats + Deprecate StorageService methods and add new ones for stream_throughput_outbound, inter_dc_stream_throughput_outbound, + compaction_throughput_outbound in the JMX MBean `org.apache.cassandra.db:type=StorageService` + Removed getEntireSSTableStreamThroughputMebibytesPerSec in favor of new getEntireSSTableStreamThroughputMebibytesPerSecAsDouble + in the JMX MBean `org.apache.cassandra.db:type=StorageService` + Removed getEntireSSTableInterDCStreamThroughputMebibytesPerSec in favor of getEntireSSTableInterDCStreamThroughputMebibytesPerSecAsDouble + in the JMX MBean `org.apache.cassandra.db:type=StorageService` (CASSANDRA-17725) + * Fix sstable_preemptive_open_interval disabled value. sstable_preemptive_open_interval = null backward compatible with + sstable_preemptive_open_interval_in_mb = -1 (CASSANDRA-17737) + * Remove usages of Path#toFile() in the snapshot apparatus (CASSANDRA-17769) + * Fix Settings Virtual Table to update paxos_variant after startup and rename enable_uuid_sstable_identifiers to + uuid_sstable_identifiers_enabled as per our config naming conventions (CASSANDRA-17738) + * index_summary_resize_interval_in_minutes = -1 is equivalent to index_summary_resize_interval being set to null or + disabled. JMX MBean IndexSummaryManager, setResizeIntervalInMinutes method still takes resizeIntervalInMinutes = -1 for disabled (CASSANDRA-17735) + * min_tracked_partition_size_bytes parameter from 4.1 alpha1 was renamed to min_tracked_partition_size (CASSANDRA-17733) + * Remove commons-lang dependency during build runtime (CASSANDRA-17724) + * Relax synchronization on StreamSession#onError() to avoid deadlock (CASSANDRA-17706) + * Fix AbstractCell#toString throws MarshalException for cell in collection (CASSANDRA-17695) + * Add new vtable output option to compactionstats (CASSANDRA-17683) + * Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog (CASSANDRA-17587) + * Fix widening to long in getBatchSizeFailThreshold (CASSANDRA-17650) + * Fix widening from mebibytes to bytes in IntMebibytesBound (CASSANDRA-17716) + * Revert breaking change in nodetool clientstats and expose cient options through nodetool clientstats --client-options. (CASSANDRA-17715) + * Fix missed nowInSec values in QueryProcessor (CASSANDRA-17458) + * R
[cassandra] branch cassandra-4.1 updated (4c85c6a403 -> 1f90c9eb3d)
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 4c85c6a403 key_cache_save_period, row_cache_save_period, counter_cache_save_period are not deprecated and we should not emit deprecation warning on startup for them Patch by Ekaterina Dimitrova; reviewed by Stefan Miklosovic for CASSANDRA-17904 new 29c0ad80c9 Fix repair failure on assertion if two peers have overlapping mismatching ranges new 1f90c9eb3d Merge branch 'cassandra-4.0' into cassandra-4.1 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/repair/asymmetric/RangeMap.java | 10 ++ .../apache/cassandra/repair/asymmetric/RangeMapTest.java | 14 -- 3 files changed, 19 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (d80d934ed2 -> 0aaad92f48)
This is an automated email from the ASF dual-hosted git repository. jmckenzie pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from d80d934ed2 Merge branch 'cassandra-4.1' into trunk new 29c0ad80c9 Fix repair failure on assertion if two peers have overlapping mismatching ranges new 1f90c9eb3d Merge branch 'cassandra-4.0' into cassandra-4.1 new 0aaad92f48 Merge branch 'cassandra-4.1' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/repair/asymmetric/RangeMap.java | 10 ++ .../apache/cassandra/repair/asymmetric/RangeMapTest.java | 14 -- 3 files changed, 19 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Fix repair failure on assertion if two peers have overlapping mismatching ranges
This is an automated email from the ASF dual-hosted git repository.
jmckenzie pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 29c0ad80c9 Fix repair failure on assertion if two peers have
overlapping mismatching ranges
29c0ad80c9 is described below
commit 29c0ad80c919f02585f3ddfd7f9e0d2e80b62e2b
Author: Josh McKenzie
AuthorDate: Fri Sep 16 15:50:44 2022 -0400
Fix repair failure on assertion if two peers have overlapping mismatching
ranges
Patch by Marcus Eriksson; reviewed by Benedict Elliott Smith and Josh
McKenzie for CASSANDRA-17900
Co-authored-by: Marcus Eriksson
Co-authored-by: Josh McKenzie
---
CHANGES.txt| 1 +
.../org/apache/cassandra/repair/asymmetric/RangeMap.java | 10 ++
.../apache/cassandra/repair/asymmetric/RangeMapTest.java | 14 --
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index c78d97d61c..22bebd6e88 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0.7
+ * Fix repair failure on assertion if two peers have overlapping mismatching
ranges (CASSANDRA-17900)
* Better handle null state in Gossip schema migration to avoid NPE
(CASSANDRA-17864)
* HintedHandoffAddRemoveNodesTest now accounts for the fact that
StorageMetrics.totalHints is not updated synchronously w/ writes
(CASSANDRA-16679)
* Avoid getting hanging repairs due to repair message timeouts
(CASSANDRA-17613)
diff --git a/src/java/org/apache/cassandra/repair/asymmetric/RangeMap.java
b/src/java/org/apache/cassandra/repair/asymmetric/RangeMap.java
index f957b1b443..224b987af1 100644
--- a/src/java/org/apache/cassandra/repair/asymmetric/RangeMap.java
+++ b/src/java/org/apache/cassandra/repair/asymmetric/RangeMap.java
@@ -156,11 +156,13 @@ public class RangeMap implements Map, T>
}
protected Map.Entry, T> computeNext()
{
-if ((currentIter == null || !currentIter.hasNext()) &&
iterators.hasNext())
+while (currentIter == null || !currentIter.hasNext())
+{
+if (!iterators.hasNext())
+return endOfData();
currentIter = iterators.next();
-if (currentIter != null && currentIter.hasNext())
-return currentIter.next();
-return endOfData();
+}
+return currentIter.next();
}
}
diff --git a/test/unit/org/apache/cassandra/repair/asymmetric/RangeMapTest.java
b/test/unit/org/apache/cassandra/repair/asymmetric/RangeMapTest.java
index 0805ea7756..a4327caa01 100644
--- a/test/unit/org/apache/cassandra/repair/asymmetric/RangeMapTest.java
+++ b/test/unit/org/apache/cassandra/repair/asymmetric/RangeMapTest.java
@@ -33,6 +33,7 @@ import org.apache.cassandra.dht.Token;
import static junit.framework.TestCase.assertEquals;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
public class RangeMapTest
{
@@ -51,8 +52,8 @@ public class RangeMapTest
for (Range range : randomRanges)
rangeMap.put(range, i++);
-long a = r.nextLong() % 10;
-long b = r.nextLong() % 10;
+long a = r.nextLong() % 100;
+long b = r.nextLong() % 100;
if (a == b) b++;
Range intersectionRange = r(a, b);
@@ -103,4 +104,13 @@ public class RangeMapTest
RangeMap rmap = new RangeMap<>();
assertFalse(rmap.intersectingEntryIterator(r(1, 10)).hasNext());
}
+
+@Test
+public void testWrap()
+{
+RangeMap rangeMap = new RangeMap<>();
+rangeMap.put(r(5, 10), 1);
+rangeMap.removeIntersecting(r(100, 50));
+assertTrue(rangeMap.isEmpty());
+}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17895) Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter components
[ https://issues.apache.org/jira/browse/CASSANDRA-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-17895: -- Reviewers: Jon Meredith, Josh McKenzie Status: Review In Progress (was: Patch Available) > Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter > components > > > Key: CASSANDRA-17895 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17895 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x, 4.1.x, 4.x > > > Replacements can currently fail with a Direct buffer memory OOM; we need to > pass down transaction finish calls as mentioned in the Title to shore up a > current resource closing hole. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17895) Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter components
[ https://issues.apache.org/jira/browse/CASSANDRA-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-17895: -- Status: Ready to Commit (was: Review In Progress) > Pass transaction finish calls from BigTableZeroCopyWriter to SequentialWriter > components > > > Key: CASSANDRA-17895 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17895 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x, 4.1.x, 4.x > > > Replacements can currently fail with a Direct buffer memory OOM; we need to > pass down transaction finish calls as mentioned in the Title to shore up a > current resource closing hole. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17837) Add pull request template
[ https://issues.apache.org/jira/browse/CASSANDRA-17837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607284#comment-17607284 ] Stefan Miklosovic commented on CASSANDRA-17837: --- This is the build I got https://ci-cassandra.apache.org/job/Cassandra-devbranch/1946/ I fixed "rat" on missing licence in that template as it was failing the build. Even though the ci run has failed quite badly (106 errors) it is all either flaky or we run out of space again (saw error like that). I run yet another build just for the sake of it but otherwise I will merge. > Add pull request template > - > > Key: CASSANDRA-17837 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17837 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Normal > Fix For: 4.x > > Time Spent: 11h 10m > Remaining Estimate: 0h > > Add pull request template something like: > - start of text > Issue resolved # CASSANDRA- > Pull request Description: > > - [ ] Commits have been squashed to remove intermediate development commit > messages. > - [ ] Key commit messages start with the issue number (CASSANDRA-) > either > - [ ] this is a trivial documentation change. (e.g. fixes a typo) > or: > - [ ] Tests are included. > - [ ] Documentation changes and/or updates are included. > By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement]([https://www.apache.org/licenses/contributor-agreements.html]). > > See the [Apache Cassandra "Contributing to Cassandra" > guide]([https://cassandra.apache.org/_/development/index.html]) and/or the > [Apache Cassandra "Working on Documentation" > guide]([https://cassandra.apache.org/_/development/documentation.html]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17901) ccm logs not being collected to nightlies
[
https://issues.apache.org/jira/browse/CASSANDRA-17901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17901:
-
Bug Category: Parent values: Correctness(12982)Level 1 values:
Unrecoverable Corruption / Loss(13161)
Complexity: Normal
Component/s: Test/dtest/python
Discovered By: User Report
Fix Version/s: 3.0.x
3.11.x
4.0.x
4.1.x
Severity: Normal
Status: Open (was: Triage Needed)
> ccm logs not being collected to nightlies
> -
>
> Key: CASSANDRA-17901
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17901
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> At least some of the time, Jenkins is failing to collect ccm logs and is
> uploading a zero byte tar archive to nightlies, for example:
> https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-dtest/1100/Cassandra-trunk-dtest/label=cassandra-dtest,split=5/
> {quote}
> 09:25:06 + tar -cJf ccm_logs.tar.xz './tmp/*/test/*/logs/*'
> 09:25:06 tar: ./tmp/*/test/*/logs/*: Cannot stat: No such file or directory
> 09:25:06 tar: Exiting with failure status due to previous errors
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17854) Add JDK17 to our test docker images
[ https://issues.apache.org/jira/browse/CASSANDRA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607257#comment-17607257 ] Ekaterina Dimitrova commented on CASSANDRA-17854: - Now when CASSANDRA-17885 is closed: [3.0|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1931/workflows/39ef5261-a6bf-4e77-a412-e750e322a231], [3.11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1932/workflows/e6ed9b0d-7723-4eff-840e-4a513c564669], 4.0 [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1933/workflows/daffc899-bf3f-41ca-aca2-156c1b6c706b] and [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1933/workflows/81102adf-fd77-45f5-98c1-d343f5d6c3e6] , 4.1 [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1934/workflows/05c39d2a-0895-4157-ad99-ccfe099cb38e] and [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1934/workflows/39e14309-a5c2-437e-a8e0-387fec1ab623], trunk [j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1935/workflows/2374a071-a635-4c92-a3bf-343beb201f82] and [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1935/workflows/d96f0a90-4c09-4b51-9584-adab3d6880e9] Let's see how those will go and I can pile Jenkins 3.11-trunk. We checked already [3.0|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1944/] > Add JDK17 to our test docker images > --- > > Key: CASSANDRA-17854 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17854 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > In preparation to support JDK 17 I want to add JDK 17 to our test images to > enable our CIs for testing with JDK 17 > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17907) Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities
[ https://issues.apache.org/jira/browse/CASSANDRA-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17907: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities > -- > > Key: CASSANDRA-17907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17907 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: deepagkanaka >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x > > > |org.yaml_snakeyaml|[CVE-2022-25857|https://nvd.nist.gov/vuln/detail/CVE-2022-25857]|Fixed > in: 1.31 > 21 days ago| |6|Impacted versions: <1.31 > Discovered: a day ago > Published: 21 days ago > The package org.yaml:snakeyaml from 0 and before 1.31 are vulnerable to > Denial of Service (DoS) due missing to nested depth limitation for > collections.| -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17907) Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities
[ https://issues.apache.org/jira/browse/CASSANDRA-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607247#comment-17607247 ] Brandon Williams commented on CASSANDRA-17907: -- CVE-2022-38750, CVE-2022-38751, CVE-2022-38752, CVE-2022-38749: DoS if parsing untrusted files CVE-2022-25857: DoS due to limitation in nested collections None of these affect us unless operators DoS themselves, so here are patches to suppress: ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-17907-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/642/workflows/b8769258-f173-4359-93ac-def3fe70ca74]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17907-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/640/workflows/b8c61e1e-4da4-4665-99dc-5022eb313b48], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/640/workflows/3dae8a21-fdf2-4b51-be44-6c490672623e]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17907-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/641/workflows/4ddc8bfd-a9f2-4eb5-b566-affcfd57bed9], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/641/workflows/753899cd-65aa-4ec0-b48c-e53f46219836]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17907-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/643/workflows/168ea9b1-cb6d-46f3-9a3d-a460b50c44da], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/643/workflows/60cb2510-17a7-4f3a-a027-9468a0889cb4]| > Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities > -- > > Key: CASSANDRA-17907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17907 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: deepagkanaka >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x > > > |org.yaml_snakeyaml|[CVE-2022-25857|https://nvd.nist.gov/vuln/detail/CVE-2022-25857]|Fixed > in: 1.31 > 21 days ago| |6|Impacted versions: <1.31 > Discovered: a day ago > Published: 21 days ago > The package org.yaml:snakeyaml from 0 and before 1.31 are vulnerable to > Denial of Service (DoS) due missing to nested depth limitation for > collections.| -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17885) Add solution for CASSANDRA-17581 to older branches for tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607225#comment-17607225 ] Brandon Williams commented on CASSANDRA-17885: -- Oh whoops. I think we've fully exercised the patch now anyway and don't think anything will pop up. > Add solution for CASSANDRA-17581 to older branches for tests > > > Key: CASSANDRA-17885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17885 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.1-beta, 4.1 > > > Some of our tests use old branches for the purposes of testing upgrades and > behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on > nodetool with a modern JDK. We can port this fix to those branches and > adjust the tests to use the newest version of them to solve this going > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17885) Add solution for CASSANDRA-17581 to older branches for tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607221#comment-17607221 ] Ekaterina Dimitrova commented on CASSANDRA-17885: - What happened to testing the rest of the branches...? :D I will pile them for the CASSANDRA-17854 anyway, I will see if something pop up there. Thanks > Add solution for CASSANDRA-17581 to older branches for tests > > > Key: CASSANDRA-17885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17885 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.1-beta, 4.1 > > > Some of our tests use old branches for the purposes of testing upgrades and > behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on > nodetool with a modern JDK. We can port this fix to those branches and > adjust the tests to use the newest version of them to solve this going > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16860) Add --older-than option to nodetool clearsnapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-16860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607191#comment-17607191
]
Stefan Miklosovic commented on CASSANDRA-16860:
---
[~paulo] I incorporated your feedback. There are still some questions I asked
in turn to which I wait for answers.
> Add --older-than option to nodetool clearsnapshot
> -
>
> Key: CASSANDRA-16860
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16860
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Snapshots, Tool/nodetool
>Reporter: Jack Casey
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> h1. Summary
> Opening this issue in reference to [this WIP
> PR|https://github.com/apache/cassandra/pull/1148]:
> This functionality allows users of Cassandra to remove snapshots ad-hoc,
> based on a TTL. This is to address the problem of snapshots accumulating. For
> example, an organization I work for aims to keep snapshots for 30 days,
> however we don't have any way to easily clean them after those 30 days are up.
> This is similar to the goals set in:
> https://issues.apache.org/jira/browse/CASSANDRA-16451 however would be
> available for Cassandra 3.x.
> h1. Functionality
> This adds a new command to NodeTool, called {{expiresnapshot}} with the
> following options:
> NAME
> nodetool expiresnapshots - Removes snapshots that are older than a TTL
> in days
> SYNOPSIS
> nodetool [(-h | --host )] [(-p | --port )]
> [(-pw | --password )]
> [(-pwf | --password-file )]
> [(-u | --username )] expiresnapshots [--dry-run]
> (-t | --ttl )
> OPTIONS
> --dry-run
> Run without actually clearing snapshots
> -h , --host
> Node hostname or ip address
> -p , --port
> Remote jmx agent port number
> -pw , --password
> Remote jmx agent password
> -pwf , --password-file
> Path to the JMX password file
> -t , --ttl
> TTL (in days) to expire snapshots
> -u , --username
> Remote jmx agent username
> The snapshot date is taken by converting the default snapshot name timestamps
> (epoch time in miliseconds). For this reason, snapshot names that don't
> contain a timestamp in this format will not be cleared.
> h1. Example Use
> This Cassandra environment has a number of snapshots, a few are recent, and a
> few outdated:
> root@cassandra001:/cassandra# nodetool listsnapshots
> Snapshot Details:
> Snapshot name Keyspace name Column family name True size Size on disk
> 1529173922063 users_keyspace users 362.03 KiB 362.89 KiB
> 1629173909461 users_keyspace users 362.03 KiB 362.89 KiB
> 1629173922063 users_keyspace users 362.03 KiB 362.89 KiB
> 1599173922063 users_keyspace users 362.03 KiB 362.89 KiB
> 1629173916816 users_keyspace users 362.03 KiB 362.89 KiB
> Total TrueDiskSpaceUsed: 1.77 MiB
> To validate the removal runs as expected, we can use the `--dry-run` option:
> root@cassandra001:/cassandra# nodetool expiresnapshots --ttl 30 --dry-run
> Starting simulated cleanup of snapshots older than 30 days
> Clearing (dry run): 1529173922063
> Clearing (dry run): 1599173922063
> Cleared (dry run): 2 snapshots
> Now that we are confident the correct snapshots will be removed, we can omit
> the {{--dry-run}} flag:
> root@cassandra001:/cassandra# nodetool expiresnapshots --ttl 30
> Starting cleanup of snapshots older than 30 days
> Clearing: 1529173922063
> Clearing: 1599173922063
> Cleared: 2 snapshots
> To confirm our changes are successful, we list the snapshots that still
> remain:
> root@cassandra001:/cassandra# nodetool listsnapshots
> Snapshot Details:
> Snapshot name Keyspace name Column family name True size Size on disk
> 1629173909461 users_keyspace users 362.03 KiB 362.89 KiB
> 1629173922063 users_keyspace users 362.03 KiB 362.89 KiB
> 1629173916816 users_keyspace users 362.03 KiB 362.89 KiB
> Total TrueDiskSpaceUsed: 1.06 MiB
> h1. Next Steps
> To be completed:
> - Tests
> - Documentation updates
> I am a new to this repository, and am fuzzy on a few details even after
> reading the contribution guide 😅 Any advice on the following would be greatly
> appreciated!
> - What branch would this type of change be merged into? Currently, I'm
> targeting {{apache:trunk}} by default
> - Is there a test strategy/pattern for this type of change? I was not able
> to find any existing tests for similar {{nodetool}} commands
> Thanks! 😄
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17221) Add Math functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607168#comment-17607168
]
Benjamin Lerer commented on CASSANDRA-17221:
Hi [~xvade],
All my apologies for the delay. I have been overly busy and stopped checking my
Jira notifications. I will make sure I look into your patch this week.
> Add Math functions
> ---
>
> Key: CASSANDRA-17221
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17221
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Simon Chess
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.x
>
>
> We should add native Maths functions for the most common operations:
> * {{abs\(x)}} returns the absolute value of the x
> * {{exp\(x)}} returns the value of e (the base of natural logarithms) raised
> to the power of x
> * {{log\(x)}} returns the natural logarithm (base e) of x
> * {{log10\(x)}} returns the base-10 logarithm of x
> * {{round\(x)}} returns the closest integer to x
> +Additional information for newcomers:+
> The new functions should be put in a new class {{MathFcts}} similar to
> {{TimeFcts}}.
> The {{MathsFcts.all()}} method should be called in
> {{SystemKeyspace.functions}}
> The unit tests for the functions should be put in a {{MathFctsTest}} similar
> to {{TimeFctsTest}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17906) Test splits generated with --only-resource-intensive-tests only work on hosts with >= 27GB memory
[ https://issues.apache.org/jira/browse/CASSANDRA-17906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17906: - Reviewers: Michael Semb Wever (was: Brandon Williams, Michael Semb Wever) > Test splits generated with --only-resource-intensive-tests only work on hosts > with >= 27GB memory > - > > Key: CASSANDRA-17906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17906 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-beta, 4.1 > > > As the title says, > [here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L87] > we use the "only resource intensive" flag to filter to just those tests, but > machines with less than 27G will fail [this > one|https://github.com/apache/cassandra-dtest/blob/trunk/conftest.py#L113]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17906) Test splits generated with --only-resource-intensive-tests only work on hosts with >= 27GB memory
[ https://issues.apache.org/jira/browse/CASSANDRA-17906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17906: - Fix Version/s: 3.0.28 3.11.14 4.0.7 4.1-beta 4.1 (was: 3.0.x) (was: 4.x) (was: 3.11.x) (was: 4.0.x) (was: 4.1.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra-builds/commit/cf4a46721c937911cbf5df10dc6d24d8826c26e4 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks. > Test splits generated with --only-resource-intensive-tests only work on hosts > with >= 27GB memory > - > > Key: CASSANDRA-17906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17906 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.0.7, 4.1-beta, 4.1 > > > As the title says, > [here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L87] > we use the "only resource intensive" flag to filter to just those tests, but > machines with less than 27G will fail [this > one|https://github.com/apache/cassandra-dtest/blob/trunk/conftest.py#L113]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17906) Test splits generated with --only-resource-intensive-tests only work on hosts with >= 27GB memory
[ https://issues.apache.org/jira/browse/CASSANDRA-17906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17906: - Status: Ready to Commit (was: Review In Progress) > Test splits generated with --only-resource-intensive-tests only work on hosts > with >= 27GB memory > - > > Key: CASSANDRA-17906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17906 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > As the title says, > [here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L87] > we use the "only resource intensive" flag to filter to just those tests, but > machines with less than 27G will fail [this > one|https://github.com/apache/cassandra-dtest/blob/trunk/conftest.py#L113]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17906) Test splits generated with --only-resource-intensive-tests only work on hosts with >= 27GB memory
[ https://issues.apache.org/jira/browse/CASSANDRA-17906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17906: - Reviewers: Michael Semb Wever, Brandon Williams Michael Semb Wever, Brandon Williams (was: Brandon Williams, Michael Semb Wever) Status: Review In Progress (was: Patch Available) > Test splits generated with --only-resource-intensive-tests only work on hosts > with >= 27GB memory > - > > Key: CASSANDRA-17906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17906 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > > As the title says, > [here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L87] > we use the "only resource intensive" flag to filter to just those tests, but > machines with less than 27G will fail [this > one|https://github.com/apache/cassandra-dtest/blob/trunk/conftest.py#L113]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: Force resource intensive tests when generating splits
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/trunk by this push:
new cf4a467 Force resource intensive tests when generating splits
cf4a467 is described below
commit cf4a46721c937911cbf5df10dc6d24d8826c26e4
Author: Brandon Williams
AuthorDate: Mon Sep 19 16:24:18 2022 -0500
Force resource intensive tests when generating splits
Patch by brandonwilliams; reviewed by mck for CASSANDRA-17906
---
build-scripts/cassandra-dtest-pytest.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/build-scripts/cassandra-dtest-pytest.sh
b/build-scripts/cassandra-dtest-pytest.sh
index 448b50c..db6f998 100755
--- a/build-scripts/cassandra-dtest-pytest.sh
+++ b/build-scripts/cassandra-dtest-pytest.sh
@@ -84,9 +84,9 @@ elif [ "${DTEST_TARGET}" = "dtest-novnode" ]; then
elif [ "${DTEST_TARGET}" = "dtest-offheap" ]; then
DTEST_ARGS="--use-vnodes --num-tokens=${NUM_TOKENS}
--use-off-heap-memtables --skip-resource-intensive-tests --keep-failed-test-dir"
elif [ "${DTEST_TARGET}" = "dtest-large" ]; then
-DTEST_ARGS="--use-vnodes --num-tokens=${NUM_TOKENS}
--only-resource-intensive-tests --keep-failed-test-dir"
+DTEST_ARGS="--use-vnodes --num-tokens=${NUM_TOKENS}
--only-resource-intensive-tests --force-resource-intensive-tests
--keep-failed-test-dir"
elif [ "${DTEST_TARGET}" = "dtest-large-novnode" ]; then
-DTEST_ARGS="--only-resource-intensive-tests --keep-failed-test-dir"
+DTEST_ARGS="--only-resource-intensive-tests
--force-resource-intensive-tests --keep-failed-test-dir"
elif [ "${DTEST_TARGET}" = "dtest-upgrade" ]; then
DTEST_ARGS="--execute-upgrade-tests-only --upgrade-target-version-only
--upgrade-version-selection all"
else
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17885) Add solution for CASSANDRA-17581 to older branches for tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17885: - Fix Version/s: 3.0.28 3.11.14 4.1-beta 4.1 (was: 3.0.x) (was: 4.x) (was: 3.11.x) (was: 4.0.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra-dtest/commit/598b44c9392c92e1fbfa183d5570bbb7206f3d35 Resolution: Fixed Status: Resolved (was: Ready to Commit) Looks good to me, committed. Thanks! > Add solution for CASSANDRA-17581 to older branches for tests > > > Key: CASSANDRA-17885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17885 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.28, 3.11.14, 4.1-beta, 4.1 > > > Some of our tests use old branches for the purposes of testing upgrades and > behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on > nodetool with a modern JDK. We can port this fix to those branches and > adjust the tests to use the newest version of them to solve this going > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17885) Add solution for CASSANDRA-17581 to older branches for tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17885: - Status: Ready to Commit (was: Review In Progress) > Add solution for CASSANDRA-17581 to older branches for tests > > > Key: CASSANDRA-17885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17885 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Some of our tests use old branches for the purposes of testing upgrades and > behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on > nodetool with a modern JDK. We can port this fix to those branches and > adjust the tests to use the newest version of them to solve this going > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Add legacy parsing for nodetool when lacking CASSANDRA-17581
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 598b44c9 Add legacy parsing for nodetool when lacking CASSANDRA-17581
598b44c9 is described below
commit 598b44c9392c92e1fbfa183d5570bbb7206f3d35
Author: Brandon Williams
AuthorDate: Tue Sep 13 10:25:19 2022 -0500
Add legacy parsing for nodetool when lacking CASSANDRA-17581
Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-17885
---
counter_test.py| 2 ++
dtest_setup.py | 13 +
legacy_sstables_test.py| 1 +
offline_tools_test.py | 2 ++
replace_address_test.py| 2 ++
secondary_indexes_test.py | 1 +
sstable_generation_loading_test.py | 2 ++
upgrade_crc_check_chance_test.py | 1 +
upgrade_internal_auth_test.py | 3 +++
upgrade_tests/drop_compact_storage_upgrade_test.py | 1 +
upgrade_tests/repair_test.py | 1 +
upgrade_tests/storage_engine_upgrade_test.py | 1 +
upgrade_tests/thrift_upgrade_test.py | 6 +-
upgrade_tests/upgrade_base.py | 1 +
14 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/counter_test.py b/counter_test.py
index 103db9e4..00fc1df0 100644
--- a/counter_test.py
+++ b/counter_test.py
@@ -32,6 +32,7 @@ class TestCounters(Tester):
#
cluster.set_install_dir(version='2.0.17')
+self.install_nodetool_legacy_parsing()
cluster.populate(3)
cluster.start()
@@ -61,6 +62,7 @@ class TestCounters(Tester):
#
cluster.set_install_dir(version='2.1.17')
+self.install_nodetool_legacy_parsing()
cluster.start()
cluster.nodetool("upgradesstables")
diff --git a/dtest_setup.py b/dtest_setup.py
index 50509e66..3d37c9d6 100644
--- a/dtest_setup.py
+++ b/dtest_setup.py
@@ -84,6 +84,19 @@ class DTestSetup(object):
self.create_cluster_func = None
self.iterations = 0
+def install_nodetool_legacy_parsing(self):
+""" Hack nodetool on old versions for legacy URL parsing, ala
CASSANDRA-17581 """
+if self.cluster.version() < LooseVersion('3.0'):
+logger.debug("hacking nodetool for legacy parsing")
+nodetool = os.path.join(self.cluster.get_install_dir(), 'bin',
'nodetool')
+with open(nodetool, 'r+') as fd:
+contents = fd.readlines()
+contents.insert(len(contents)-5, "
-Dcom.sun.jndi.rmiURLParsing=legacy \\\n")
+fd.seek(0)
+fd.writelines(contents)
+else:
+logger.debug("not modifying nodetool on version
{}".format(self.cluster.version()))
+
def set_ignore_log_patterns(self, other):
if self._ignore_log_patterns == None:
self._ignore_log_patterns = default_ignore_log_patterns()
diff --git a/legacy_sstables_test.py b/legacy_sstables_test.py
index c8c400e1..c09e4dbf 100644
--- a/legacy_sstables_test.py
+++ b/legacy_sstables_test.py
@@ -27,6 +27,7 @@ class TestLegacySSTables(Tester):
# start with 2.1.20 to generate a legacy sstable
cluster.set_install_dir(version='2.1.20')
+self.install_nodetool_legacy_parsing()
cluster.populate(1).start()
node1 = cluster.nodelist()[0]
diff --git a/offline_tools_test.py b/offline_tools_test.py
index 54c0e067..1c3d81bc 100644
--- a/offline_tools_test.py
+++ b/offline_tools_test.py
@@ -362,10 +362,12 @@ class TestOfflineTools(Tester):
elif testversion < '3.0':
logger.debug('Test version: {} - installing
github:apache/cassandra-2.1'.format(testversion))
cluster.set_install_dir(version='github:apache/cassandra-2.1')
+self.install_nodetool_legacy_parsing()
# As of 3.5, sstable format 'ma' from 3.0 is still the latest -
install 2.2 to upgrade from
elif testversion < '4.0':
logger.debug('Test version: {} - installing
github:apache/cassandra-2.2'.format(testversion))
cluster.set_install_dir(version='github:apache/cassandra-2.2')
+self.install_nodetool_legacy_parsing()
# From 4.0, one can only upgrade from 3.0
else:
logger.debug('Test version: {} - installing
github:apache/cassandra-3.0'.format(testversion))
diff --git a/replace_address_test.py b/replace_address_test.py
index bab39103..441d474d 100644
--- a/replace_address_test.py
+++ b/replace_address_test.py
@@ -62,6 +62,8 @@ class BaseReplaceAddressTest(Tester):
if mixed_versions:
logger.debug("Starting nodes on version 2.2.4")
[jira] [Comment Edited] (CASSANDRA-17907) Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities
[ https://issues.apache.org/jira/browse/CASSANDRA-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607114#comment-17607114 ] Brandon Williams edited comment on CASSANDRA-17907 at 9/20/22 11:12 AM: bq. One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '1.0': bq. snakeyaml-1.26.jar: CVE-2022-38752, CVE-2022-38751, CVE-2022-38750, CVE-2022-25857, CVE-2022-38749 was (Author: brandon.williams): bq. One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '1.0': snakeyaml-1.26.jar: CVE-2022-38752, CVE-2022-38751, CVE-2022-38750, CVE-2022-25857, CVE-2022-38749 > Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities > -- > > Key: CASSANDRA-17907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17907 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: deepagkanaka >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x > > > |org.yaml_snakeyaml|[CVE-2022-25857|https://nvd.nist.gov/vuln/detail/CVE-2022-25857]|Fixed > in: 1.31 > 21 days ago| |6|Impacted versions: <1.31 > Discovered: a day ago > Published: 21 days ago > The package org.yaml:snakeyaml from 0 and before 1.31 are vulnerable to > Denial of Service (DoS) due missing to nested depth limitation for > collections.| -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17907) Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities
[ https://issues.apache.org/jira/browse/CASSANDRA-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607114#comment-17607114 ] Brandon Williams commented on CASSANDRA-17907: -- bq. One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '1.0': snakeyaml-1.26.jar: CVE-2022-38752, CVE-2022-38751, CVE-2022-38750, CVE-2022-25857, CVE-2022-38749 > Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities > -- > > Key: CASSANDRA-17907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17907 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: deepagkanaka >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x > > > |org.yaml_snakeyaml|[CVE-2022-25857|https://nvd.nist.gov/vuln/detail/CVE-2022-25857]|Fixed > in: 1.31 > 21 days ago| |6|Impacted versions: <1.31 > Discovered: a day ago > Published: 21 days ago > The package org.yaml:snakeyaml from 0 and before 1.31 are vulnerable to > Denial of Service (DoS) due missing to nested depth limitation for > collections.| -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17907) Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities
[ https://issues.apache.org/jira/browse/CASSANDRA-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17907: - Bug Category: Parent values: Security(12985)Level 1 values: Denial of Service(13001) Complexity: Normal Component/s: Dependencies Discovered By: User Report Fix Version/s: 3.11.x 4.0.x 4.1.x Severity: Normal Status: Open (was: Triage Needed) > Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities > -- > > Key: CASSANDRA-17907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17907 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: deepagkanaka >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x > > > |org.yaml_snakeyaml|[CVE-2022-25857|https://nvd.nist.gov/vuln/detail/CVE-2022-25857]|Fixed > in: 1.31 > 21 days ago| |6|Impacted versions: <1.31 > Discovered: a day ago > Published: 21 days ago > The package org.yaml:snakeyaml from 0 and before 1.31 are vulnerable to > Denial of Service (DoS) due missing to nested depth limitation for > collections.| -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17907) Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities
[ https://issues.apache.org/jira/browse/CASSANDRA-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-17907: Assignee: Brandon Williams > Remediate CVE-2022-25857 - org.yaml_snakeyaml version 1.26 has vulnerabilities > -- > > Key: CASSANDRA-17907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17907 > Project: Cassandra > Issue Type: Bug >Reporter: deepagkanaka >Assignee: Brandon Williams >Priority: Normal > > |org.yaml_snakeyaml|[CVE-2022-25857|https://nvd.nist.gov/vuln/detail/CVE-2022-25857]|Fixed > in: 1.31 > 21 days ago| |6|Impacted versions: <1.31 > Discovered: a day ago > Published: 21 days ago > The package org.yaml:snakeyaml from 0 and before 1.31 are vulnerable to > Denial of Service (DoS) due missing to nested depth limitation for > collections.| -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17461) Test Failure: org.apache.cassandra.distributed.test.CASTest.testConflictingWritesWithStaleRingInformation
[
https://issues.apache.org/jira/browse/CASSANDRA-17461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607050#comment-17607050
]
Benedict Elliott Smith commented on CASSANDRA-17461:
Well, since it should fix it for the first operation it leaves some room for
some consistent breakage to occur that reliably breaks the first operation
(rather than infrequently).
BUT, quite evidently we don't have the time to agonise over these tests and the
alternative is probably annotating them to be ignored, and it's only a slight
weakening. So +1, let's ship 4.1
> Test Failure:
> org.apache.cassandra.distributed.test.CASTest.testConflictingWritesWithStaleRingInformation
> -
>
> Key: CASSANDRA-17461
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17461
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Andres de la Peña
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> Intermittent failures on {{org.apache.cassandra.distributed.test.CASTest}}
> for trunk:
> *
> [testConflictingWritesWithStaleRingInformation|https://ci-cassandra.apache.org/job/Cassandra-trunk/1024/testReport/org.apache.cassandra.distributed.test/CASTest/testConflictingWritesWithStaleRingInformation_3/]
> *
> [testSuccessfulWriteBeforeRangeMovement|https://ci-cassandra.apache.org/job/Cassandra-trunk/1025/testReport/org.apache.cassandra.distributed.test/CASTest/testSuccessfulWriteBeforeRangeMovement/]
> *
> [testSuccessfulWriteDuringRangeMovementFollowedByConflicting|https://ci-cassandra.apache.org/job/Cassandra-trunk/1020/testReport/org.apache.cassandra.distributed.test/CASTest/testSuccessfulWriteDuringRangeMovementFollowedByConflicting/]
> *
> [testSucccessfulWriteDuringRangeMovementFollowedByRead|https://ci-cassandra.apache.org/job/Cassandra-trunk/1020/testReport/org.apache.cassandra.distributed.test/CASTest/testSucccessfulWriteDuringRangeMovementFollowedByRead/]
> All four seem to have the same aspect:
> {code}
> Failed 2 times in the last 5 runs. Flakiness: 50%, Stability: 60%
> Error Message
> CAS operation timed out: received 1 of 2 required responses after 0
> contention retries
> Stacktrace
> org.apache.cassandra.exceptions.CasWriteTimeoutException: CAS operation timed
> out: received 1 of 2 required responses after 0 contention retries
> at
> org.apache.cassandra.service.paxos.Paxos$MaybeFailure.markAndThrowAsTimeoutOrFailure(Paxos.java:547)
> at org.apache.cassandra.service.paxos.Paxos.begin(Paxos.java:1048)
> at org.apache.cassandra.service.paxos.Paxos.cas(Paxos.java:659)
> at org.apache.cassandra.service.paxos.Paxos.cas(Paxos.java:618)
> at org.apache.cassandra.service.StorageProxy.cas(StorageProxy.java:307)
> at
> org.apache.cassandra.cql3.statements.ModificationStatement.executeWithCondition(ModificationStatement.java:500)
> at
> org.apache.cassandra.cql3.statements.ModificationStatement.execute(ModificationStatement.java:467)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:122)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
> at
> org.apache.cassandra.distributed.impl.Coordinator.lambda$executeWithResult$0(Coordinator.java:66)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:47)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:57)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Standard Output
> DEBUG [main] 2022-03-19 16:20:42,868 Reflections.java:198 - going to scan
> these urls:
> [jar:file:/home/cassandra/cassandra/build/apache-cassandra-4.1-SNAPSHOT.jar!/,
>
> jar:file:/home/cassandra/cassandra/build/test/lib/jars/simulator-bootstrap.jar!/,
>
> jar:file:/home/cassandra/cassandra/build/test/lib/jars/dtest-api-0.0.12.jar!/,
> file:/home/cassandra/cassandra/build/classes/fqltool/,
> file:/home/cassandra/cassandra/build/test/classes/,
> file:/home/cassandra/cassandra/build/classes/main/, file:/home/cass
> ...[truncated 4929659 chars]...
> gService.java:519 - Waiting for messaging service to quiesce
> INFO [node1_isolatedExecutor:10] 2022-03-19 16:21:55,223
> SubstituteLogger.java:169 - INFO [node1_isolatedExecutor:10] node1
> 2022-03-19 16:21:55,221 MessagingService.java:519 - Waiting for messaging
> service to
[jira] [Commented] (CASSANDRA-17837) Add pull request template
[ https://issues.apache.org/jira/browse/CASSANDRA-17837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607031#comment-17607031 ] Stefan Miklosovic commented on CASSANDRA-17837: --- I tested this on a separate cassandra repository (private forks). The behaviour confirms the documentation. I am not sure what you mean. What message? > Add pull request template > - > > Key: CASSANDRA-17837 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17837 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Normal > Fix For: 4.x > > Time Spent: 11h 10m > Remaining Estimate: 0h > > Add pull request template something like: > - start of text > Issue resolved # CASSANDRA- > Pull request Description: > > - [ ] Commits have been squashed to remove intermediate development commit > messages. > - [ ] Key commit messages start with the issue number (CASSANDRA-) > either > - [ ] this is a trivial documentation change. (e.g. fixes a typo) > or: > - [ ] Tests are included. > - [ ] Documentation changes and/or updates are included. > By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement]([https://www.apache.org/licenses/contributor-agreements.html]). > > See the [Apache Cassandra "Contributing to Cassandra" > guide]([https://cassandra.apache.org/_/development/index.html]) and/or the > [Apache Cassandra "Working on Documentation" > guide]([https://cassandra.apache.org/_/development/documentation.html]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (aebc7607 -> 6c4ccb5f)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard aebc7607 generate docs for 538513bd new 6c4ccb5f generate docs for 538513bd This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (aebc7607) \ N -- N -- N refs/heads/asf-staging (6c4ccb5f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17837) Add pull request template
[ https://issues.apache.org/jira/browse/CASSANDRA-17837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607012#comment-17607012 ] Claude Warren commented on CASSANDRA-17837: --- Seems like the message might be a hold over from when "master" was the default trunk name across github. Once merged does it show up? > Add pull request template > - > > Key: CASSANDRA-17837 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17837 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Normal > Fix For: 4.x > > Time Spent: 11h 10m > Remaining Estimate: 0h > > Add pull request template something like: > - start of text > Issue resolved # CASSANDRA- > Pull request Description: > > - [ ] Commits have been squashed to remove intermediate development commit > messages. > - [ ] Key commit messages start with the issue number (CASSANDRA-) > either > - [ ] this is a trivial documentation change. (e.g. fixes a typo) > or: > - [ ] Tests are included. > - [ ] Documentation changes and/or updates are included. > By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement]([https://www.apache.org/licenses/contributor-agreements.html]). > > See the [Apache Cassandra "Contributing to Cassandra" > guide]([https://cassandra.apache.org/_/development/index.html]) and/or the > [Apache Cassandra "Working on Documentation" > guide]([https://cassandra.apache.org/_/development/documentation.html]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17837) Add pull request template
[ https://issues.apache.org/jira/browse/CASSANDRA-17837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607005#comment-17607005 ] Stefan Miklosovic commented on CASSANDRA-17837: --- Based on point 6 here (1), the template is available for collaborators when it is merged to the default branch, which is trunk in our case. I go to merge it to trunk only. Also here (2) it says: "You must create templates on the repository's default branch. Templates created in other branches are not available for collaborators to use." (1) https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository (2) https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates > Add pull request template > - > > Key: CASSANDRA-17837 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17837 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Normal > Fix For: 4.x > > Time Spent: 11h 10m > Remaining Estimate: 0h > > Add pull request template something like: > - start of text > Issue resolved # CASSANDRA- > Pull request Description: > > - [ ] Commits have been squashed to remove intermediate development commit > messages. > - [ ] Key commit messages start with the issue number (CASSANDRA-) > either > - [ ] this is a trivial documentation change. (e.g. fixes a typo) > or: > - [ ] Tests are included. > - [ ] Documentation changes and/or updates are included. > By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement]([https://www.apache.org/licenses/contributor-agreements.html]). > > See the [Apache Cassandra "Contributing to Cassandra" > guide]([https://cassandra.apache.org/_/development/index.html]) and/or the > [Apache Cassandra "Working on Documentation" > guide]([https://cassandra.apache.org/_/development/documentation.html]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17837) Add pull request template
[ https://issues.apache.org/jira/browse/CASSANDRA-17837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606991#comment-17606991 ] Stefan Miklosovic commented on CASSANDRA-17837: --- I am trying to figure out what branches we should actually merge this into. I did a simple test and it seems that the template is used even though I open the PR against a different branch than trunk (where that template is not yet). It seems like it takes that template from the trunk even though I create a PR against cassandra-4.1, for example. Seems like a magic. I try to confirm this. Otherwise I would just put it into every branch we support (3.0 to trunk). > Add pull request template > - > > Key: CASSANDRA-17837 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17837 > Project: Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Normal > Fix For: 4.x > > Time Spent: 11h 10m > Remaining Estimate: 0h > > Add pull request template something like: > - start of text > Issue resolved # CASSANDRA- > Pull request Description: > > - [ ] Commits have been squashed to remove intermediate development commit > messages. > - [ ] Key commit messages start with the issue number (CASSANDRA-) > either > - [ ] this is a trivial documentation change. (e.g. fixes a typo) > or: > - [ ] Tests are included. > - [ ] Documentation changes and/or updates are included. > By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement]([https://www.apache.org/licenses/contributor-agreements.html]). > > See the [Apache Cassandra "Contributing to Cassandra" > guide]([https://cassandra.apache.org/_/development/index.html]) and/or the > [Apache Cassandra "Working on Documentation" > guide]([https://cassandra.apache.org/_/development/documentation.html]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17900) Repair may fail with an assertion if two peers have overlapping mismatching ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-17900:
Status: Ready to Commit (was: Review In Progress)
+1
> Repair may fail with an assertion if two peers have overlapping mismatching
> ranges
> --
>
> Key: CASSANDRA-17900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17900
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
>
> A little tweaking in {{RangeMap.java}} + a test showcasing it ought to tidy
> this up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17900) Repair may fail with an assertion if two peers have overlapping mismatching ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-17900:
Reviewers: Marcus Eriksson, Marcus Eriksson
Marcus Eriksson, Marcus Eriksson (was: Marcus Eriksson)
Status: Review In Progress (was: Patch Available)
> Repair may fail with an assertion if two peers have overlapping mismatching
> ranges
> --
>
> Key: CASSANDRA-17900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17900
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
>
> A little tweaking in {{RangeMap.java}} + a test showcasing it ought to tidy
> this up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
