[jira] [Commented] (CASSANDRA-18305) Enhance nodetool compactionstats with existing MBean metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698228#comment-17698228
]
Stefan Miklosovic commented on CASSANDRA-18305:
---
I do not plan to work on that. Feel free to take it.
> Enhance nodetool compactionstats with existing MBean metrics
>
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured
> {quote}concurrent compactions permitted: 2
> {quote}
> or perhaps simply add to existing 'pending tasks' line:
> {quote}2 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18201) Store min and max partition key in sstable stats metadata rather than in some index component
[ https://issues.apache.org/jira/browse/CASSANDRA-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18201: -- Resolution: Duplicate Status: Resolved (was: Triage Needed) > Store min and max partition key in sstable stats metadata rather than in some > index component > - > > Key: CASSANDRA-18201 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18201 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > Currently min and max partition key is stored in the index summary. > Firstly, that informat better fits stats metadata as there are other similar > statistics (like min and max clusterings) > Secondly, opening index summary is costly. Though, index summary and the > index itself are loaded upon opening an sstable just because we need to read > min and max partition keys. Min and max partition keys need to be know for an > sstable so that when some data are queried, we can select the sstable which > may contain that data - that is, whether the queried partition is included in > the min/max key range of the sstable. > With the proposed solution, we could postpone loading index components to the > time when the data from such sstable is really requested. It will be enough > to read lightweight stats metadata as it will be sufficient to know > everything about data ranges included in that sstable. It will also let to > save memory used by those components until data from those sstables are > requested. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18291: -- Fix Version/s: 4.1.1 (was: 4.1.x) Source Control Link: https://github.com/apache/cassandra/commit/5f7175d59da8b8d20e1081619eadad8b60867e86 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.1, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 065c671e6500a06829712ab6e2504dc33ac76ca2 Merge: 4841794028 5f7175d59d Author: Jacek Lewandowski AuthorDate: Thu Mar 9 08:13:40 2023 +0100 Merge branch 'cassandra-4.1' into trunk CHANGES.txt | 1 + src/java/org/apache/cassandra/schema/Schema.java | 20 2 files changed, 9 insertions(+), 12 deletions(-) diff --cc CHANGES.txt index b6e94ec67d,ae1a1a46e9..dd8a775565 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,118 -1,5 +1,119 @@@ -4.1.1 - * Fix too early schema version change in sysem local table (CASSANDRA-18291) +5.0 + * Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them together with local read/write ratio to tablestats (CASSANDRA-18283) + * Add more logging around CompactionManager operations (CASSANDRA-18268) + * Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue (CASSANDRA-18212) + * CEP-17: SSTable API (CASSANDRA-17056) + * Gossip stateMapOrdering does not have correct ordering when both EndpointState are in the bootstrapping set (CASSANDRA-18292) + * Snapshot only sstables containing mismatching ranges on preview repair mismatch (CASSANDRA-17561) + * More accurate skipping of sstables in read path (CASSANDRA-18134) + * Prepare for JDK17 experimental support (CASSANDRA-18179, CASSANDRA-18258) + * Remove Scripted UDFs internals; hooks to be added later in CASSANDRA-17281 (CASSANDRA-18252) + * Update JNA to 5.13.0 (CASSANDRA-18050) + * Make virtual tables decide if they implicitly enable ALLOW FILTERING (CASSANDRA-18238) + * Add row, tombstone, and sstable count to nodetool profileload (CASSANDRA-18022) + * Coordinator level metrics for read response and mutation row and column counts (CASSANDRA-18155) + * Add CQL functions for dynamic data masking (CASSANDRA-17941) + * Print friendly error when nodetool attempts to connect to uninitialized server (CASSANDRA-11537) + * Use G1GC by default, and update default G1GC settings (CASSANDRA-18027) + * SimpleSeedProvider can resolve multiple IP addresses per DNS record (CASSANDRA-14361) + * Remove mocking in InternalNodeProbe spying on StorageServiceMBean (CASSANDRA-18152) + * Add compaction_properties column to system.compaction_history table and nodetool compactionhistory command (CASSANDRA-18061) + * Remove ProtocolVersion entirely from the CollectionSerializer ecosystem (CASSANDRA-18114) + * Fix serialization error in new getsstables --show-levels option (CASSANDRA-18140) + * Use checked casts when reading vints as ints (CASSANDRA-18099) + * Add Mutation Serialization Caching (CASSANDRA-17998) + * Only reload compaction strategies if disk boundaries change (CASSANDRA-17874) + * CEP-10: Simulator Java11 Support (CASSANDRA-17178) + * Set the major compaction type correctly for compactionstats (CASSANDRA-18055) + * Print exception message without stacktrace when nodetool commands fail on probe.getOwnershipWithPort() (CASSANDRA-18079) + * Add option to print level in nodetool getsstables output (CASSANDRA-18023) + * Implement a guardrail for not having zero default_time_to_live on tables with TWCS (CASSANDRA-18042) + * Add CQL scalar functions for collection aggregation (CASSANDRA-18060) + * Make cassandra.replayList property for CommitLogReplayer possible to react on keyspaces only (CASSANDRA-18044) + * Add Mathematical functions (CASSANDRA-17221) + * Make incremental backup configurable per table (CASSANDRA-15402) + * Change shebangs of Python scripts to resolve Python 3 from env command (CASSANDRA-17832) + * Add reasons to guardrail messages and consider guardrails in the error message for needed ALLOW FILTERING (CASSANDRA-17967) + * Add support for CQL functions on collections, tuples and UDTs (CASSANDRA-17811) + * Add flag to exclude nodes from local DC when running nodetool rebuild (CASSANDRA-17870) + * Adding endpoint verification option to client_encryption_options (CASSANDRA-18034) + * Replace 'wcwidth.py' with pypi module (CASSANDRA-17287) + * Add nodetool forcecompact to remove tombstoned or ttl'd data ignoring GC grace for given table and partition keys (CASSANDRA-17711) + * Offer IF (NOT) EXISTS in cqlsh completion for CREATE TYPE, DROP TYPE, CREATE ROLE and DROP ROLE (CASSANDRA-16640) + * Nodetool bootstrap resume will now return an error if the operation fails (CASSANDRA-16491) + * Disable resumable bootstrap by default (CASSANDRA-17679) + * Include Git SHA in --verbose flag for nodetool version (CASSANDRA-17753) + * Update Byteman to 4.0.20 and Jacoco to 0.8.8 (CASSANDRA-16413) + * Add memtable option among possible tab completions for a table (CASSANDRA-17982) + * Adds a trie-based memtable implementation (CASSANDRA-17240) + * Further improv
[cassandra] branch trunk updated (4841794028 -> 065c671e65)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 4841794028 Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them together with local read/write ratio to tablestats add 5f7175d59d Small fixes around Schema management new 065c671e65 Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/schema/Schema.java | 20 2 files changed, 9 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (6adcff8f30 -> 5f7175d59d)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 6adcff8f30 Merge branch 'cassandra-4.0' into cassandra-4.1 add 5f7175d59d Small fixes around Schema management No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/schema/Schema.java | 20 2 files changed, 9 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18102) Add a virtual table to list snapshots
[
https://issues.apache.org/jira/browse/CASSANDRA-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698190#comment-17698190
]
maxwellguo edited comment on CASSANDRA-18102 at 3/9/23 7:19 AM:
[~paulo][~smiklosovic]I am so sorry that the old pr is discard due to an
operation mistake by me and I feeel very sorry. And I have create a new one .
[old pr link that discard by me, but some conversations is left
|https://github.com/apache/cassandra/pull/2117]
[the new pr that have been modify after resolved the conversations
|https://github.com/apache/cassandra/pull/2205]
[java 8
precommit|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/417/workflows/440693db-00d0-4d86-aaf8-008d94f48ed4]
[java11 precommit
|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/417/workflows/0b7c8599-2146-4f8f-83e7-347b60db5711]
java8 and java11 precommit ut are green
was (Author: maxwellguo):
[~paulo][~smiklosovic]I am so sorry that the old pr is discard due to an
operation mistake by me and I feeel very sorry. And I have create a new one .
[old pr link that discard by me, but some conversations is left
|https://github.com/apache/cassandra/pull/2117]
[the new pr that have been modify after resolved the conversations
|https://github.com/apache/cassandra/pull/2205]
[java 8
precommit|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/417/workflows/440693db-00d0-4d86-aaf8-008d94f48ed4]
[java11 precommit
|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/417/workflows/0b7c8599-2146-4f8f-83e7-347b60db5711]
> Add a virtual table to list snapshots
> -
>
> Key: CASSANDRA-18102
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18102
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Local/Snapshots
>Reporter: Paulo Motta
>Assignee: maxwellguo
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> It should be possible to query a node's snapshots via virtual tables.
> The table should expose the same fields/columns as the
> [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java]
> class.
> Something along these lines:
> {noformat}
> cqlsh> SELECT * FROM system_views.snapshots;
>
> tag | keyspace_name | table_name | table_id | is_ephemeral | created_at |
> expires_at | directories
> +---++---+--+---++
> 1670460346841 | system | compaction_info |
> 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z |
> null |
> {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698213#comment-17698213 ] Jacek Lewandowski commented on CASSANDRA-18291: --- [~smiklosovic] I've already fixed it in CASSANDRA-18308 > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698212#comment-17698212 ] Stefan Miklosovic commented on CASSANDRA-18291: --- that sstableverify test seems to failing, is that related? do we have a ticket for it? > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698003#comment-17698003 ] Jacek Lewandowski edited comment on CASSANDRA-18291 at 3/9/23 6:40 AM: --- https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/4b680424-39b6-4423-abc5-db0bb3f34b9b https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/6c19e1cf-f56c-4b9c-adfa-033b64251285 https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/605/workflows/2745566c-9141-41a2-a49a-7a9558e4cb83 was (Author: jlewandowski): https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/4b680424-39b6-4423-abc5-db0bb3f34b9b https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/6c19e1cf-f56c-4b9c-adfa-033b64251285 > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18291: -- Status: Ready to Commit (was: Review In Progress) > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698195#comment-17698195 ] Tibor Repasi commented on CASSANDRA-18307: -- Yes, 4.0.8 is now available in the repository. Thank you, [~brandon.williams]. > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Assignee: Brandon Williams >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18309) Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
[
https://issues.apache.org/jira/browse/CASSANDRA-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18309:
Reviewers: Caleb Rackliffe, Caleb Rackliffe
Caleb Rackliffe, Caleb Rackliffe (was: Caleb Rackliffe)
Status: Review In Progress (was: Patch Available)
+1
> Remove git hook for pre-push as it is redundant and causes issues when
> merging to mainline
> --
>
> Key: CASSANDRA-18309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18309
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> [cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord
> Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
> Entering 'modules/accord'
> Username for 'https://github.com':
> {code}
> This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic
> {code}
> local -r cmd='
> branch="$(git rev-parse --abbrev-ref HEAD)"
> [[ "$branch" == "HEAD" ]] && exit 0
> default_remote="$(git config --local --get branch."${branch}".remote || true)"
> remote="${default_remote:-origin}"
> git push --atomic "$remote" "$branch"
> '
> git submodule foreach --recursive "$cmd"
> {code}
> This logic was to make sure that the submodule is pushed before you push your
> changes, but this is slightly redundant as
> .build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not
> allow you to commit the submodule SHA until it can confirm its on GitHub.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18102) Add a virtual table to list snapshots
[
https://issues.apache.org/jira/browse/CASSANDRA-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698190#comment-17698190
]
maxwellguo commented on CASSANDRA-18102:
[~paulo][~smiklosovic]I am so sorry that the old pr is discard due to an
operation mistake by me and I feeel very sorry. And I have create a new one .
[old pr link that discard by me, but some conversations is left
|https://github.com/apache/cassandra/pull/2117]
[the new pr that have been modify after resolved the conversations
|https://github.com/apache/cassandra/pull/2205]
[java 8
precommit|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/417/workflows/440693db-00d0-4d86-aaf8-008d94f48ed4]
[java11 precommit
|https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/417/workflows/0b7c8599-2146-4f8f-83e7-347b60db5711]
> Add a virtual table to list snapshots
> -
>
> Key: CASSANDRA-18102
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18102
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Local/Snapshots
>Reporter: Paulo Motta
>Assignee: maxwellguo
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> It should be possible to query a node's snapshots via virtual tables.
> The table should expose the same fields/columns as the
> [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java]
> class.
> Something along these lines:
> {noformat}
> cqlsh> SELECT * FROM system_views.snapshots;
>
> tag | keyspace_name | table_name | table_id | is_ephemeral | created_at |
> expires_at | directories
> +---++---+--+---++
> 1670460346841 | system | compaction_info |
> 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z |
> null |
> {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698145#comment-17698145 ] Josh McKenzie commented on CASSANDRA-18012: --- +1. Thanks for taking this on Andres. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18305) Enhance nodetool compactionstats with existing MBean metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698140#comment-17698140
]
maxwellguo commented on CASSANDRA-18305:
nobody working on this ? [~smiklosovic] it seems that you have assigned this to
you ?
> Enhance nodetool compactionstats with existing MBean metrics
>
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured
> {quote}concurrent compactions permitted: 2
> {quote}
> or perhaps simply add to existing 'pending tasks' line:
> {quote}2 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18299) Add support for prepared statements for accord transactions
[ https://issues.apache.org/jira/browse/CASSANDRA-18299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18299: -- Fix Version/s: 5.0 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/9cd6406a7ee77e3ed44d41d6712b473b0ea5f805 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Add support for prepared statements for accord transactions > --- > > Key: CASSANDRA-18299 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18299 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0 > > Time Spent: 7h 50m > Remaining Estimate: 0h > > When you try to prepare an accord transaction we get a NullPointerException > in method > org.apache.cassandra.cql3.statements.QualifiedStatement#isFullyQualified. > This is due to TransactionStatement extending but not overriding all the > methods (and setting name to null). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18309) Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
[
https://issues.apache.org/jira/browse/CASSANDRA-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18309:
--
Test and Documentation Plan: manual test to unblock Blake's merge
Status: Patch Available (was: Open)
> Remove git hook for pre-push as it is redundant and causes issues when
> merging to mainline
> --
>
> Key: CASSANDRA-18309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18309
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> [cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord
> Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
> Entering 'modules/accord'
> Username for 'https://github.com':
> {code}
> This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic
> {code}
> local -r cmd='
> branch="$(git rev-parse --abbrev-ref HEAD)"
> [[ "$branch" == "HEAD" ]] && exit 0
> default_remote="$(git config --local --get branch."${branch}".remote || true)"
> remote="${default_remote:-origin}"
> git push --atomic "$remote" "$branch"
> '
> git submodule foreach --recursive "$cmd"
> {code}
> This logic was to make sure that the submodule is pushed before you push your
> changes, but this is slightly redundant as
> .build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not
> allow you to commit the submodule SHA until it can confirm its on GitHub.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17412) CEP-15: (Accord) Initial Cassandra Integration
[ https://issues.apache.org/jira/browse/CASSANDRA-17412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-17412: Fix Version/s: 5.x Source Control Link: https://github.com/apache/cassandra/commit/f7fb5325925754a627694ba5e0c03c9432a5c3d6 Resolution: Fixed Status: Resolved (was: Ready to Commit) > CEP-15: (Accord) Initial Cassandra Integration > -- > > Key: CASSANDRA-17412 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17412 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 5.x > > > Integrate the accord messages into Cassandra and implement a basic Cassandra > to accord topology mapping. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18309) Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
[
https://issues.apache.org/jira/browse/CASSANDRA-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18309:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: API /
Semantic Implementation(12988)
Complexity: Low Hanging Fruit
Discovered By: User Report
Fix Version/s: 5.x
Severity: Low
Status: Open (was: Triage Needed)
> Remove git hook for pre-push as it is redundant and causes issues when
> merging to mainline
> --
>
> Key: CASSANDRA-18309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18309
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> [cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord
> Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
> Entering 'modules/accord'
> Username for 'https://github.com':
> {code}
> This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic
> {code}
> local -r cmd='
> branch="$(git rev-parse --abbrev-ref HEAD)"
> [[ "$branch" == "HEAD" ]] && exit 0
> default_remote="$(git config --local --get branch."${branch}".remote || true)"
> remote="${default_remote:-origin}"
> git push --atomic "$remote" "$branch"
> '
> git submodule foreach --recursive "$cmd"
> {code}
> This logic was to make sure that the submodule is pushed before you push your
> changes, but this is slightly redundant as
> .build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not
> allow you to commit the submodule SHA until it can confirm its on GitHub.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17412) CEP-15: (Accord) Initial Cassandra Integration
[ https://issues.apache.org/jira/browse/CASSANDRA-17412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-17412: Status: Ready to Commit (was: Review In Progress) > CEP-15: (Accord) Initial Cassandra Integration > -- > > Key: CASSANDRA-17412 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17412 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Integrate the accord messages into Cassandra and implement a basic Cassandra > to accord topology mapping. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17412) CEP-15: (Accord) Initial Cassandra Integration
[ https://issues.apache.org/jira/browse/CASSANDRA-17412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-17412: Reviewers: Benedict Elliott Smith, David Capwell (was: Benedict Elliott Smith) Status: Review In Progress (was: Patch Available) > CEP-15: (Accord) Initial Cassandra Integration > -- > > Key: CASSANDRA-17412 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17412 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Integrate the accord messages into Cassandra and implement a basic Cassandra > to accord topology mapping. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18309) Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
David Capwell created CASSANDRA-18309:
-
Summary: Remove git hook for pre-push as it is redundant and
causes issues when merging to mainline
Key: CASSANDRA-18309
URL: https://issues.apache.org/jira/browse/CASSANDRA-18309
Project: Cassandra
Issue Type: Bug
Components: Accord
Reporter: David Capwell
Assignee: David Capwell
{code}
[cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord
Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
Entering 'modules/accord'
Username for 'https://github.com':
{code}
This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic
{code}
local -r cmd='
branch="$(git rev-parse --abbrev-ref HEAD)"
[[ "$branch" == "HEAD" ]] && exit 0
default_remote="$(git config --local --get branch."${branch}".remote || true)"
remote="${default_remote:-origin}"
git push --atomic "$remote" "$branch"
'
git submodule foreach --recursive "$cmd"
{code}
This logic was to make sure that the submodule is pushed before you push your
changes, but this is slightly redundant as
.build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not allow
you to commit the submodule SHA until it can confirm its on GitHub.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18192) Accord - refactor transaction state storage
[ https://issues.apache.org/jira/browse/CASSANDRA-18192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18192: Source Control Link: https://github.com/apache/cassandra/commit/3374d91c4a86bb7a77e65e67c6c45d074512fbc4 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Accord - refactor transaction state storage > --- > > Key: CASSANDRA-18192 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18192 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 5.x > > > Refactor accord state to be immutable with explicit transitions between each > state. This should also address the occasional errors encountered during > field updates -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18004) CEP-15: (C*/Accord) - remove futures
[ https://issues.apache.org/jira/browse/CASSANDRA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18004: Fix Version/s: 5.0 Source Control Link: https://github.com/apache/cassandra/commit/fa10af834e750887be53c33d3eebb6d7d3606c1b Resolution: Fixed Status: Resolved (was: Ready to Commit) > CEP-15: (C*/Accord) - remove futures > > > Key: CASSANDRA-18004 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18004 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 5.0 > > > Remove futures in favor of async chain -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18192) Accord - refactor transaction state storage
[ https://issues.apache.org/jira/browse/CASSANDRA-18192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18192: Status: Ready to Commit (was: Review In Progress) > Accord - refactor transaction state storage > --- > > Key: CASSANDRA-18192 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18192 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 5.x > > > Refactor accord state to be immutable with explicit transitions between each > state. This should also address the occasional errors encountered during > field updates -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18004) CEP-15: (C*/Accord) - remove futures
[ https://issues.apache.org/jira/browse/CASSANDRA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18004: Reviewers: Benedict Elliott Smith, David Capwell (was: Benedict Elliott Smith) Status: Review In Progress (was: Patch Available) > CEP-15: (C*/Accord) - remove futures > > > Key: CASSANDRA-18004 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18004 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Remove futures in favor of async chain -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18004) CEP-15: (C*/Accord) - remove futures
[ https://issues.apache.org/jira/browse/CASSANDRA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18004: Status: Ready to Commit (was: Review In Progress) > CEP-15: (C*/Accord) - remove futures > > > Key: CASSANDRA-18004 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18004 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Remove futures in favor of async chain -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: add AsyncChain implementations and tests
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit fa10af834e750887be53c33d3eebb6d7d3606c1b
Author: Blake Eggleston
AuthorDate: Fri Jan 27 09:41:59 2023 -0800
add AsyncChain implementations and tests
Patch by Blake Eggleston; Reviewed by David Capwell & Benedict Elliott
Smith for CASSANDRA-18004
---
.../cassandra/service/accord/AccordCommand.java| 74 +++---
.../service/accord/AccordCommandStore.java | 18 +-
.../service/accord/AccordCommandsForKey.java | 14 +-
.../cassandra/service/accord/AccordService.java| 7 +-
.../cassandra/service/accord/AccordState.java | 6 +-
.../cassandra/service/accord/AccordStateCache.java | 128 -
.../cassandra/service/accord/ReadFuture.java | 292 -
.../service/accord/async/AsyncLoader.java | 92 +++
.../service/accord/async/AsyncOperation.java | 46 +++-
.../service/accord/async/AsyncWriter.java | 63 ++---
.../cassandra/service/accord/txn/TxnNamedRead.java | 7 +-
.../cassandra/service/accord/txn/TxnRead.java | 57 +---
.../cassandra/service/accord/txn/TxnWrite.java | 21 +-
.../service/accord/AccordCommandTest.java | 36 +--
.../service/accord/AccordStateCacheTest.java | 47 ++--
.../cassandra/service/accord/AccordTestUtils.java | 8 +-
.../service/accord/async/AsyncLoaderTest.java | 21 +-
.../service/accord/async/AsyncOperationTest.java | 16 +-
18 files changed, 332 insertions(+), 621 deletions(-)
diff --git a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
index 8020b29ac7..88b39922ce 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
@@ -58,14 +58,15 @@ import accord.primitives.Writes;
import accord.utils.DeterministicIdentitySet;
import
org.apache.cassandra.service.accord.AccordCommandStore.SafeAccordCommandStore;
import org.apache.cassandra.service.accord.api.PartitionKey;
+import accord.utils.async.AsyncChain;
+import accord.utils.async.AsyncResult;
+import accord.utils.async.AsyncResults;
import org.apache.cassandra.service.accord.async.AsyncContext;
import org.apache.cassandra.service.accord.store.StoredNavigableMap;
import org.apache.cassandra.service.accord.store.StoredSet;
import org.apache.cassandra.service.accord.store.StoredValue;
import org.apache.cassandra.service.accord.txn.TxnData;
import org.apache.cassandra.utils.ObjectSizes;
-import org.apache.cassandra.utils.concurrent.AsyncPromise;
-import org.apache.cassandra.utils.concurrent.Future;
import static accord.local.Status.Durability.Local;
import static accord.local.Status.Durability.NotDurable;
@@ -83,7 +84,7 @@ public class AccordCommand extends Command implements
AccordState
public static class WriteOnly extends AccordCommand implements
AccordState.WriteOnly
{
-private Future future = null;
+private AsyncResult asyncResult = null;
public WriteOnly(TxnId txnId)
{
@@ -91,16 +92,16 @@ public class AccordCommand extends Command implements
AccordState
}
@Override
-public void future(Future future)
+public void asyncResult(AsyncResult notifier)
{
-Preconditions.checkArgument(this.future == null);
-this.future = future;
+Preconditions.checkArgument(this.asyncResult == null);
+this.asyncResult = notifier;
}
@Override
-public Future future()
+public AsyncResult asyncResult()
{
-return future;
+return asyncResult;
}
@Override
@@ -618,7 +619,7 @@ public class AccordCommand extends Command implements
AccordState
protected void postApply(SafeCommandStore safeStore)
{
AccordStateCache.Instance cache =
((SafeAccordCommandStore) safeStore).commandStore().commandCache();
-cache.cleanupWriteFuture(txnId);
+cache.cleanupWriteResult(txnId);
super.postApply(safeStore);
}
@@ -640,58 +641,69 @@ public class AccordCommand extends Command implements
AccordState
return true;
}
-private Future applyWithCorrectScope(CommandStore unsafeStore)
+private AsyncResult applyWithCorrectScope(CommandStore unsafeStore)
{
TxnId txnId = txnId();
-AsyncPromise promise = new AsyncPromise<>();
+AsyncResult.Settable result = AsyncResults.settable();
unsafeStore.execute(this, safeStore -> {
AccordCommand command = (AccordCommand) safeStore.command(txnId);
-command.apply(safeStore, false).addCallback((v, throwable) -> {
-if (throwable != null)
-promise.try
[cassandra] branch cep-15-accord updated (9cd6406a7e -> 3374d91c4a)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git from 9cd6406a7e Add support for prepared statements for accord transactions new fa10af834e add AsyncChain implementations and tests new 3374d91c4a CEP-15/Accord Immutable State Refactor The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-accord.xml| 6 + .circleci/config.yml | 10923 --- modules/accord | 2 +- .../cql3/statements/TransactionStatement.java | 3 +- .../cassandra/exceptions/ReadTimeoutException.java | 6 + .../cassandra/service/accord/AccordCommand.java| 824 -- .../service/accord/AccordCommandStore.java | 400 +- .../service/accord/AccordCommandStores.java| 7 +- .../service/accord/AccordCommandsForKey.java | 433 - .../service/accord/AccordConfigurationService.java |21 +- .../cassandra/service/accord/AccordKeyspace.java | 638 +- .../service/accord/AccordLoadingState.java | 163 + .../service/accord/AccordObjectSizes.java | 162 +- .../service/accord/AccordPartialCommand.java | 209 - .../service/accord/AccordSafeCommand.java | 124 + .../service/accord/AccordSafeCommandStore.java | 260 + .../service/accord/AccordSafeCommandsForKey.java | 125 + .../cassandra/service/accord/AccordSafeState.java |76 + .../cassandra/service/accord/AccordService.java|36 +- .../cassandra/service/accord/AccordState.java | 105 - .../cassandra/service/accord/AccordStateCache.java | 522 +- .../cassandra/service/accord/ListenerProxy.java| 275 - .../cassandra/service/accord/ReadFuture.java | 292 - .../cassandra/service/accord/api/AccordAgent.java | 7 +- .../service/accord/async/AsyncContext.java | 116 - .../service/accord/async/AsyncLoader.java | 207 +- .../service/accord/async/AsyncOperation.java | 168 +- .../service/accord/async/AsyncWriter.java | 285 +- .../accord/exceptions/ReadPreemptedException.java} |20 +- .../exceptions/WritePreemptedException.java} |19 +- .../accord/serializers/AcceptSerializers.java | 1 - .../accord/serializers/ApplySerializers.java | 3 + .../serializers/CommandsForKeySerializer.java | 207 + .../accord/serializers/ListenerSerializers.java| 151 + .../service/accord/store/AbstractStoredField.java | 152 - .../service/accord/store/StoredBoolean.java|85 - .../cassandra/service/accord/store/StoredLong.java |86 - .../service/accord/store/StoredNavigableMap.java | 224 - .../cassandra/service/accord/store/StoredSet.java | 249 - .../service/accord/store/StoredValue.java | 128 - .../cassandra/service/accord/txn/TxnNamedRead.java | 7 +- .../cassandra/service/accord/txn/TxnRead.java |57 +- .../cassandra/service/accord/txn/TxnWrite.java |34 +- .../distributed/test/accord/AccordTestBase.java| 5 +- .../cassandra/simulator/paxos/PaxosSimulation.java |21 +- .../service/accord/AccordCommandStoreTest.java | 113 +- .../service/accord/AccordCommandTest.java |53 +- .../service/accord/AccordLoadingStateTest.java | 178 + .../service/accord/AccordStateCacheTest.java | 533 +- .../cassandra/service/accord/AccordTestUtils.java | 175 +- .../service/accord/async/AsyncLoaderTest.java | 203 +- .../service/accord/async/AsyncOperationTest.java | 447 +- .../service/accord/async/AsyncWriterTest.java | 241 - .../serializers/CommandsForKeySerializerTest.java |95 + .../service/accord/store/StoredMapTest.java| 203 - .../service/accord/store/StoredSetTest.java| 202 - .../service/accord/store/StoredValueTest.java |85 - .../apache/cassandra/utils/AccordGenerators.java |84 + .../org/apache/cassandra/utils/AssertionUtils.java |31 + 59 files changed, 3676 insertions(+), 16811 deletions(-) delete mode 100644 .circleci/config.yml delete mode 100644 src/java/org/apache/cassandra/service/accord/AccordCommand.java delete mode 100644 src/java/org/apache/cassandra/service/accord/AccordCommandsForKey.java create mode 100644 src/java/org/apache/cassandra/service/accord/AccordLoadingState.java delete mode 100644 src/java/org/apache/cassandra/service/accord/AccordPartialCommand.java create mode 100644 src/java/org/apache/cassandra/service/accord/AccordSafeCommand.java create mode 100644 src/java/org/apache/cassandra/service/accord/AccordSafeCommandStore.java create mode 10
[cassandra-accord] 01/02: add AsyncChain implementations and tests
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
commit 07e351462b147b831c2d416b8568449b06ccbb51
Author: Blake Eggleston
AuthorDate: Tue Feb 21 15:47:43 2023 -0800
add AsyncChain implementations and tests
Patch by Blake Eggleston; Reviewed by David Capwell & Benedict Elliott
Smith for CASSANDRA-18004
---
accord-core/build.gradle | 2 +-
accord-core/src/main/java/accord/api/Read.java | 49 +--
accord-core/src/main/java/accord/api/Write.java| 4 +-
.../main/java/accord/coordinate/Coordinate.java| 10 +-
.../src/main/java/accord/coordinate/FetchData.java | 2 +-
.../java/accord/coordinate/InformHomeOfTxn.java| 8 +-
.../main/java/accord/coordinate/Invalidate.java| 2 +-
.../src/main/java/accord/coordinate/Recover.java | 20 +-
.../java/accord/impl/InMemoryCommandStore.java | 79 ++--
.../main/java/accord/impl/SimpleProgressLog.java | 35 +-
.../main/java/accord/local/AsyncCommandStores.java | 28 +-
.../src/main/java/accord/local/Command.java| 18 +-
.../src/main/java/accord/local/CommandStore.java | 6 +-
.../src/main/java/accord/local/CommandStores.java | 18 +-
accord-core/src/main/java/accord/local/Node.java | 45 ++-
.../main/java/accord/local/SafeCommandStore.java | 8 +-
.../src/main/java/accord/messages/Apply.java | 2 +-
.../src/main/java/accord/messages/Commit.java | 2 +-
.../java/accord/messages/InformHomeDurable.java| 2 +-
.../src/main/java/accord/messages/ReadData.java| 2 +-
.../src/main/java/accord/primitives/Txn.java | 12 +-
.../src/main/java/accord/primitives/Writes.java| 13 +-
.../main/java/accord/topology/TopologyManager.java | 21 +-
.../src/main/java/accord/utils/ReducingFuture.java | 72
.../java/accord/utils/ThreadPoolScheduler.java | 3 +-
.../java/accord/utils/async/AsyncCallbacks.java| 43 +-
.../main/java/accord/utils/async/AsyncChain.java | 58 +++
.../accord/utils/async/AsyncChainCombiner.java | 168
.../main/java/accord/utils/async/AsyncChains.java | 436 +
.../main/java/accord/utils/async/AsyncResult.java | 107 +
.../main/java/accord/utils/async/AsyncResults.java | 368 +
.../accord/burn/BurnTestConfigurationService.java | 16 +-
.../src/test/java/accord/burn/TopologyUpdates.java | 28 +-
.../java/accord/coordinate/CoordinateTest.java | 17 +-
.../java/accord/coordinate/TopologyChangeTest.java | 25 +-
.../src/test/java/accord/impl/list/ListRead.java | 12 +-
.../src/test/java/accord/impl/list/ListWrite.java | 4 +-
.../src/test/java/accord/impl/mock/EpochSync.java | 19 +-
.../accord/impl/mock/MockConfigurationService.java | 4 -
.../src/test/java/accord/impl/mock/MockStore.java | 15 +-
.../src/test/java/accord/local/CommandTest.java| 6 +-
.../src/test/java/accord/utils/MessageTask.java| 5 +-
.../java/accord/utils/async/AsyncChainsTest.java | 180 +
accord-maelstrom/build.gradle | 2 +-
.../main/java/accord/maelstrom/MaelstromRead.java | 12 +-
.../main/java/accord/maelstrom/MaelstromWrite.java | 4 +-
.../java/accord/maelstrom/SimpleConfigService.java | 3 -
47 files changed, 1598 insertions(+), 397 deletions(-)
diff --git a/accord-core/build.gradle b/accord-core/build.gradle
index c5d61cd..e92e62b 100644
--- a/accord-core/build.gradle
+++ b/accord-core/build.gradle
@@ -30,7 +30,7 @@ java {
}
dependencies {
-implementation group: 'org.apache.cassandra', name: 'cassandra-all',
version: '4.1-alpha1'
+implementation group: "com.google.guava", name: "guava", version:
"27.0-jre"
implementation group: "net.ju-n.compile-command-annotations", name:
"compile-command-annotations", version: "1.2.0"
// Dependencies we depend on that are not part of our API.
diff --git a/accord-core/src/main/java/accord/api/Read.java
b/accord-core/src/main/java/accord/api/Read.java
index deff2c6..c295226 100644
--- a/accord-core/src/main/java/accord/api/Read.java
+++ b/accord-core/src/main/java/accord/api/Read.java
@@ -20,11 +20,10 @@ package accord.api;
import accord.local.SafeCommandStore;
import accord.primitives.*;
-import org.apache.cassandra.utils.concurrent.AsyncPromise;
-import org.apache.cassandra.utils.concurrent.Future;
-
-import java.util.List;
-import java.util.function.BiConsumer;
+import accord.primitives.Ranges;
+import accord.primitives.Timestamp;
+import accord.primitives.Txn;
+import accord.utils.async.AsyncChain;
/**
@@ -33,45 +32,7 @@ import java.util.function.BiConsumer;
public interface Read
{
Seekables keys();
-Future read(Seekable key, Txn.Kind kind, SafeCommandStore
commandStore, Timestamp executeAt, DataStore store);
-
-class ReadFuture extends AsyncPromise implements BiConsumer
-{
-
[cassandra-accord] branch trunk updated (b9025e5 -> f607a05)
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
from b9025e5 CEP-15: (C*) Add git submodule for Accord (#29)
new 07e3514 add AsyncChain implementations and tests
new f607a05 CEP-15/Accord Immutable State Refactor
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
accord-core/build.gradle |2 +-
accord-core/src/main/java/accord/api/Agent.java|2 +-
accord-core/src/main/java/accord/api/Read.java | 49 +-
.../{Data.java => VisibleForImplementation.java} | 17 +-
accord-core/src/main/java/accord/api/Write.java|4 +-
.../src/main/java/accord/coordinate/CheckOn.java | 27 +-
.../main/java/accord/coordinate/Coordinate.java| 14 +-
.../src/main/java/accord/coordinate/FetchData.java |2 +-
.../java/accord/coordinate/InformHomeOfTxn.java|8 +-
.../main/java/accord/coordinate/Invalidate.java| 14 +-
.../src/main/java/accord/coordinate/Persist.java |4 +-
.../java/accord/coordinate/ReadCoordinator.java|8 +-
.../src/main/java/accord/coordinate/Recover.java | 20 +-
.../java/accord/coordinate/RecoverWithHomeKey.java |6 +-
.../coordinate/tracking/AbstractTracker.java |6 +-
.../java/accord/impl/AbstractSafeCommandStore.java | 221 +++
.../src/main/java/accord/impl/CommandsForKey.java | 458 +-
.../src/main/java/accord/impl/InMemoryCommand.java | 342
.../java/accord/impl/InMemoryCommandStore.java | 1098 -
.../java/accord/impl/InMemoryCommandStores.java| 31 +-
.../java/accord/impl/InMemoryCommandsForKey.java | 160 --
.../java/accord/impl/InMemorySafeCommand.java} | 43 +-
.../accord/impl/InMemorySafeCommandsForKey.java} | 44 +-
.../main/java/accord/impl/SafeCommandsForKey.java | 180 +++
.../ShardTracker.java => impl/SafeState.java} | 17 +-
.../main/java/accord/impl/SimpleProgressLog.java | 53 +-
.../main/java/accord/local/AsyncCommandStores.java | 92 --
.../src/main/java/accord/local/Command.java| 1643 +---
.../main/java/accord/local/CommandListener.java|2 +-
.../src/main/java/accord/local/CommandStore.java | 27 +-
.../src/main/java/accord/local/CommandStores.java | 80 +-
.../src/main/java/accord/local/Commands.java | 1094 +
.../main/java/accord/local/CommonAttributes.java | 201 +++
.../src/main/java/accord/local/Listeners.java | 67 +
accord-core/src/main/java/accord/local/Node.java | 50 +-
.../src/main/java/accord/local/PreLoadContext.java | 17 +
.../src/main/java/accord/local/SafeCommand.java| 139 ++
.../main/java/accord/local/SafeCommandStore.java | 50 +-
accord-core/src/main/java/accord/local/Status.java |4 +-
.../main/java/accord/local/SyncCommandStores.java | 114 --
.../src/main/java/accord/messages/Accept.java | 19 +-
.../src/main/java/accord/messages/Apply.java | 21 +-
.../java/accord/messages/BeginInvalidation.java|8 +-
.../main/java/accord/messages/BeginRecovery.java | 17 +-
.../src/main/java/accord/messages/CheckStatus.java |9 +-
.../src/main/java/accord/messages/Commit.java | 24 +-
.../src/main/java/accord/messages/Defer.java | 17 +-
.../main/java/accord/messages/InformDurable.java |7 +-
.../java/accord/messages/InformHomeDurable.java| 11 +-
.../main/java/accord/messages/InformOfTxnId.java |6 +-
.../src/main/java/accord/messages/PreAccept.java |4 +-
.../src/main/java/accord/messages/ReadData.java| 39 +-
.../main/java/accord/messages/WaitOnCommit.java| 14 +-
.../src/main/java/accord/primitives/Timestamp.java |2 +-
.../src/main/java/accord/primitives/Txn.java | 15 +-
.../src/main/java/accord/primitives/TxnId.java |5 +
.../src/main/java/accord/primitives/Writes.java| 13 +-
.../main/java/accord/topology/TopologyManager.java | 21 +-
.../accord/utils/DeterministicIdentitySet.java | 16 +-
.../src/main/java/accord/utils/Invariants.java | 195 ++-
.../src/main/java/accord/utils/MapReduce.java | 19 +
.../src/main/java/accord/utils/ReducingFuture.java | 72 -
.../java/accord/utils/ThreadPoolScheduler.java |3 +-
accord-core/src/main/java/accord/utils/Utils.java | 46 +
.../AsyncCallbacks.java} | 34 +-
.../main/java/accord/utils/async/AsyncChain.java | 81 +
.../accord/utils/async/AsyncChainCombiner.java | 168 ++
.../main/java/accord/utils/async/AsyncChains.java | 518 ++
.../main/java/accord/utils/async/AsyncResult.java | 96 ++
.../main/java/accord/utils/async/AsyncResults.java |
[cassandra-website] branch asf-staging updated (cae85411 -> a92ffeb3)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard cae85411 generate docs for c4206294 new a92ffeb3 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (cae85411) \ N -- N -- N refs/heads/asf-staging (a92ffeb3) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/doc/4.2/cassandra/operating/metrics.html | 13 + .../4.2/cassandra/tools/nodetool/tablestats.html | 3 ++- content/doc/trunk/cassandra/operating/metrics.html | 13 + .../trunk/cassandra/tools/nodetool/tablestats.html | 3 ++- site-ui/build/ui-bundle.zip| Bin 4796442 -> 4796442 bytes 5 files changed, 30 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698079#comment-17698079 ] Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/8/23 9:08 PM: - Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk tests in Jenkins. My past experience makes me believe that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems as they very often surprise us with differences. Thank you in advance was (Author: e.dimitrova): Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk in Jenkins. My past experience makes me believe that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems as they very often surprise us with differences. Thank you in advance > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698079#comment-17698079 ] Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/8/23 9:08 PM: - Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk tests in Jenkins. My past experience makes me believe that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems pre-commit as they very often surprise us with differences. Thank you in advance was (Author: e.dimitrova): Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk tests in Jenkins. My past experience makes me believe that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems as they very often surprise us with differences. Thank you in advance > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698079#comment-17698079 ] Ekaterina Dimitrova commented on CASSANDRA-18106: - Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk in Jenkins. My past experience makes me believer that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems as they very often surprise us with differences. Thank you in advance > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698079#comment-17698079 ] Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/8/23 9:07 PM: - Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk in Jenkins. My past experience makes me believe that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems as they very often surprise us with differences. Thank you in advance was (Author: e.dimitrova): Please run also the Python upgrade tests. I believe it is a good idea to run also at least trunk in Jenkins. My past experience makes me believer that until we have the build scripts in-tree used by both CI systems, such changes is better to be run in both CI systems as they very often surprise us with differences. Thank you in advance > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[
https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698076#comment-17698076
]
Ekaterina Dimitrova commented on CASSANDRA-17971:
-
+1 from me
{quote}only failures are in the dtest_large*, all appear unrelated.
{quote}
They seem to me to be intermittent. In my experience those tests are quite
fragile, it seems
> Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
>
>
> Key: CASSANDRA-17971
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17971
> Project: Cassandra
> Issue Type: Task
> Components: Build, Dependencies, Feature/UDF
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we
> need to revise it again before we switch fro jdk8&11 to jdk11&17
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[
https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698076#comment-17698076
]
Ekaterina Dimitrova edited comment on CASSANDRA-17971 at 3/8/23 8:40 PM:
-
+1 from me
{quote}only failures are in the dtest_large*, all appear unrelated.
{quote}
They seem to me to be intermittent failures
was (Author: e.dimitrova):
+1 from me
{quote}only failures are in the dtest_large*, all appear unrelated.
{quote}
They seem to me to be intermittent. In my experience those tests are quite
fragile, it seems
> Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
>
>
> Key: CASSANDRA-17971
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17971
> Project: Cassandra
> Issue Type: Task
> Components: Build, Dependencies, Feature/UDF
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we
> need to revise it again before we switch fro jdk8&11 to jdk11&17
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698071#comment-17698071
]
Stefan Miklosovic commented on CASSANDRA-18304:
---
I've added some nits to the PR. Thanks.
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18304:
--
Reviewers: Stefan Miklosovic, Stefan Miklosovic
Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic)
Status: Review In Progress (was: Patch Available)
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698067#comment-17698067 ] Michael Semb Wever edited comment on CASSANDRA-17971 at 3/8/23 8:13 PM: only failures are in the dtest_large*, all appear unrelated. was (Author: michaelsembwever): only failures are in the dtest_large* > Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra > > > Key: CASSANDRA-17971 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17971 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we > need to revise it again before we switch fro jdk8&11 to jdk11&17 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12937) Default setting (yaml) for SSTable compression
[
https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-12937:
--
Test and Documentation Plan: CI
Status: Patch Available (was: In Progress)
https://github.com/apache/cassandra/pull/2199
> Default setting (yaml) for SSTable compression
> --
>
> Key: CASSANDRA-12937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12937
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Michael Semb Wever
>Assignee: Claude Warren
>Priority: Low
> Labels: AdventCalendar2021, lhf
>
> In many situations the choice of compression for sstables is more relevant to
> the disks attached than to the schema and data.
> This issue is to add to cassandra.yaml a default value for sstable
> compression that new tables will inherit (instead of the defaults found in
> {{CompressionParams.DEFAULT}}.
> Examples where this can be relevant are filesystems that do on-the-fly
> compression (btrfs, zfs) or specific disk configurations or even specific C*
> versions (see CASSANDRA-10995 ).
> +Additional information for newcomers+
> Some new fields need to be added to {{cassandra.yaml}} to allow specifying
> the field required for defining the default compression parameters. In
> {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for
> the default compression. This field should be initialized in
> {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where
> {{CompressionParams.DEFAULT}} was used the code should call
> {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some
> copy of configured {{CompressionParams}}.
> Some unit test using {{OverrideConfigurationLoader}} should be used to test
> that the table schema use the new default when a new table is created (see
> CreateTest for some example).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12937) Default setting (yaml) for SSTable compression
[
https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-12937:
--
Reviewers: Stefan Miklosovic
Status: Review In Progress (was: Patch Available)
> Default setting (yaml) for SSTable compression
> --
>
> Key: CASSANDRA-12937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12937
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Michael Semb Wever
>Assignee: Claude Warren
>Priority: Low
> Labels: AdventCalendar2021, lhf
>
> In many situations the choice of compression for sstables is more relevant to
> the disks attached than to the schema and data.
> This issue is to add to cassandra.yaml a default value for sstable
> compression that new tables will inherit (instead of the defaults found in
> {{CompressionParams.DEFAULT}}.
> Examples where this can be relevant are filesystems that do on-the-fly
> compression (btrfs, zfs) or specific disk configurations or even specific C*
> versions (see CASSANDRA-10995 ).
> +Additional information for newcomers+
> Some new fields need to be added to {{cassandra.yaml}} to allow specifying
> the field required for defining the default compression parameters. In
> {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for
> the default compression. This field should be initialized in
> {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where
> {{CompressionParams.DEFAULT}} was used the code should call
> {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some
> copy of configured {{CompressionParams}}.
> Some unit test using {{OverrideConfigurationLoader}} should be used to test
> that the table schema use the new default when a new table is created (see
> CreateTest for some example).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698068#comment-17698068 ] Brandon Williams commented on CASSANDRA-18106: -- Freshly rebased, running against my dtest repo+my ccm, and trunk has JAVAx_HOME removed from the circle config, ala CASSANDRA-18293. ||Branch||CI|| |[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18106-3.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/899/workflows/5e415c0e-e75f-4165-af4a-f0661cb884f3]| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18106-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/900/workflows/2441dbb8-0451-4ae6-8112-e58a28ddf3e3]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18106-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/897/workflows/b3032740-49e9-4a64-928f-5158cec5787c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/897/workflows/d4d985cd-42e6-45ff-9b30-7a6e08b5e615]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18106-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/898/workflows/b5c55b1d-fede-4004-8a2d-38c56bba1edc], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/898/workflows/9f5587ea-651f-4753-a9a6-f3a0bf24789b]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18106-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/bbd09455-317b-4c83-be8a-4ee97ca3497e]| > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18305) Enhance nodetool compactionstats with existing MBean metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic reassigned CASSANDRA-18305:
-
Assignee: (was: Stefan Miklosovic)
> Enhance nodetool compactionstats with existing MBean metrics
>
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured
> {quote}concurrent compactions permitted: 2
> {quote}
> or perhaps simply add to existing 'pending tasks' line:
> {quote}2 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698067#comment-17698067 ] Michael Semb Wever commented on CASSANDRA-17971: only failures are in the dtest_large* > Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra > > > Key: CASSANDRA-17971 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17971 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we > need to revise it again before we switch fro jdk8&11 to jdk11&17 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698023#comment-17698023 ] Brandon Williams commented on CASSANDRA-18307: -- I think this is resolved now, [~rtib] can you check please? > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Assignee: Brandon Williams >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698003#comment-17698003 ] Jacek Lewandowski edited comment on CASSANDRA-18291 at 3/8/23 5:12 PM: --- https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/4b680424-39b6-4423-abc5-db0bb3f34b9b https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/6c19e1cf-f56c-4b9c-adfa-033b64251285 was (Author: jlewandowski): https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/4b680424-39b6-4423-abc5-db0bb3f34b9b > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698003#comment-17698003 ] Jacek Lewandowski commented on CASSANDRA-18291: --- https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/597/workflows/4b680424-39b6-4423-abc5-db0bb3f34b9b > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18308: -- Since Version: NA Source Control Link: https://github.com/apache/cassandra-dtest/commit/ddc7ca342f8a84565a01d769c4ec71502a2278d6 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.x > > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Repair the previous fix in offline_tools_test.py to work for < 4.2
This is an automated email from the ASF dual-hosted git repository.
jlewandowski pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new ddc7ca34 Repair the previous fix in offline_tools_test.py to work for
< 4.2
ddc7ca34 is described below
commit ddc7ca342f8a84565a01d769c4ec71502a2278d6
Author: Jacek Lewandowski
AuthorDate: Wed Mar 8 14:49:56 2023 +0100
Repair the previous fix in offline_tools_test.py to work for < 4.2
patch by Jacek Lewandowski, reviewed by Brandon Williams and Ekaterina
Dimitrova for CASSANDRA-18308
---
offline_tools_test.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/offline_tools_test.py b/offline_tools_test.py
index 9b1cfabc..51e28aab 100644
--- a/offline_tools_test.py
+++ b/offline_tools_test.py
@@ -311,7 +311,11 @@ class TestOfflineTools(Tester):
(out, error, rc) = node1.run_sstableverify("keyspace1",
"standard1", options=options)
assert False, "sstable verify did not fail;
rc={}\nout={}\nerr={}".format(str(rc), out, error)
except ToolError as e:
-m = re.match("(?ms).*Corrupted file: integrity check .* failed for
(?P\S+?):.*", str(e))
+m = None
+if cluster.version() >= '4.2':
+m = re.match("(?ms).*Corrupted file: integrity check .* failed
for (?P\S+?):.*", str(e))
+else:
+m = re.match("(?ms).*Corrupted SSTable : (?P\S+)",
str(e))
assert m is not None, str(e)
# MacOS might use the "private" prefix.
assert
os.path.normcase(m.group('sstable')).replace("/private/var/folders",
"/var/folders") == sstable1
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated: Add support for prepared statements for accord transactions
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cep-15-accord by this push:
new 9cd6406a7e Add support for prepared statements for accord transactions
9cd6406a7e is described below
commit 9cd6406a7ee77e3ed44d41d6712b473b0ea5f805
Author: David Capwell
AuthorDate: Fri Mar 3 11:12:53 2023 -0800
Add support for prepared statements for accord transactions
patch by David Capwell; reviewed by Alex Petrov, Caleb Rackliffe, Jacek
Lewandowski for CASSANDRA-18299
---
CHANGES.txt| 1 +
.../cassandra/config/DatabaseDescriptor.java | 5 +
.../org/apache/cassandra/cql3/CQLStatement.java| 10 +
.../org/apache/cassandra/cql3/QueryProcessor.java | 5 +-
src/java/org/apache/cassandra/cql3/ResultSet.java | 5 +-
.../cassandra/cql3/statements/BatchStatement.java | 27 +--
.../cql3/statements/QualifiedStatement.java| 46
.../cassandra/cql3/statements/SelectStatement.java | 3 +-
.../cql3/statements/TransactionStatement.java | 78 +--
.../cassandra/db/SinglePartitionReadCommand.java | 3 +-
src/java/org/apache/cassandra/db/WriteType.java| 8 +-
.../cassandra/service/accord/AccordService.java| 2 +-
.../transport/messages/ExecuteMessage.java | 5 +-
test/unit/org/apache/cassandra/Util.java | 8 +
test/unit/org/apache/cassandra/cql3/CQLTester.java | 16 +-
.../cassandra/cql3/PreparedStatementsTest.java | 257 ++---
.../unit/org/apache/cassandra/index/StubIndex.java | 8 +-
17 files changed, 395 insertions(+), 92 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 0586c9f745..2937ec238a 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
accord
+ * Add support for prepared statements for accord transactions
(CASSANDRA-18299)
* Fix statement validation against partition range queries (CASSANDRA-18240)
* Fix null value handling for static columns (CASSANDRA-18241)
* Feature Flag for Accord Transactions (CASSANDRA-18195)
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index 077183d81f..b31510145d 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -4397,6 +4397,11 @@ public class DatabaseDescriptor
return conf.accord_transactions_enabled;
}
+public static void setAccordTransactionsEnabled(boolean b)
+{
+conf.accord_transactions_enabled = b;
+}
+
public static boolean getForceNewPreparedStatementBehaviour()
{
return conf.force_new_prepared_statement_behaviour;
diff --git a/src/java/org/apache/cassandra/cql3/CQLStatement.java
b/src/java/org/apache/cassandra/cql3/CQLStatement.java
index e78f7332c3..1a371a61da 100644
--- a/src/java/org/apache/cassandra/cql3/CQLStatement.java
+++ b/src/java/org/apache/cassandra/cql3/CQLStatement.java
@@ -115,4 +115,14 @@ public interface CQLStatement
{
public String keyspace();
}
+
+interface CompositeCQLStatement extends CQLStatement
+{
+Iterable getStatements();
+}
+
+interface ReturningCQLStatement extends CQLStatement
+{
+ResultSet.ResultMetadata getResultMetadata();
+}
}
diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
index 915bb162c0..ba12a5a897 100644
--- a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
+++ b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
@@ -989,10 +989,9 @@ public class QueryProcessor implements QueryHandler
statementKsName = selectStatement.keyspace();
statementCfName = selectStatement.table();
}
-else if (statement instanceof BatchStatement)
+else if (statement instanceof CQLStatement.CompositeCQLStatement)
{
-BatchStatement batchStatement = ((BatchStatement) statement);
-for (ModificationStatement stmt :
batchStatement.getStatements())
+for (CQLStatement stmt : ((CQLStatement.CompositeCQLStatement)
statement).getStatements())
{
if (shouldInvalidate(ksName, cfName, stmt))
return true;
diff --git a/src/java/org/apache/cassandra/cql3/ResultSet.java
b/src/java/org/apache/cassandra/cql3/ResultSet.java
index de393f7310..ddb17634c1 100644
--- a/src/java/org/apache/cassandra/cql3/ResultSet.java
+++ b/src/java/org/apache/cassandra/cql3/ResultSet.java
@@ -31,7 +31,6 @@ import java.util.Objects;
import com.google.common.annotations.VisibleForTesting;
import io.netty.buffer.ByteBuf;
-import org.apache.cassandra.cql3.statements.SelectS
[jira] [Updated] (CASSANDRA-18299) Add support for prepared statements for accord transactions
[ https://issues.apache.org/jira/browse/CASSANDRA-18299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18299: -- Status: Ready to Commit (was: Review In Progress) > Add support for prepared statements for accord transactions > --- > > Key: CASSANDRA-18299 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18299 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.x > > Time Spent: 7h 40m > Remaining Estimate: 0h > > When you try to prepare an accord transaction we get a NullPointerException > in method > org.apache.cassandra.cql3.statements.QualifiedStatement#isFullyQualified. > This is due to TransactionStatement extending but not overriding all the > methods (and setting name to null). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18299) Add support for prepared statements for accord transactions
[ https://issues.apache.org/jira/browse/CASSANDRA-18299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18299: -- Reviewers: Alex Petrov, Caleb Rackliffe, Jacek Lewandowski (was: Caleb Rackliffe) > Add support for prepared statements for accord transactions > --- > > Key: CASSANDRA-18299 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18299 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.x > > Time Spent: 7h 40m > Remaining Estimate: 0h > > When you try to prepare an accord transaction we get a NullPointerException > in method > org.apache.cassandra.cql3.statements.QualifiedStatement#isFullyQualified. > This is due to TransactionStatement extending but not overriding all the > methods (and setting name to null). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18043) remove deprecated DateTieredCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697977#comment-17697977 ] Stefan Miklosovic edited comment on CASSANDRA-18043 at 3/8/23 4:02 PM: --- CI here: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2337/testReport/ branch for modified dtests here: https://github.com/apache/cassandra-dtest/pull/207 PR: https://github.com/apache/cassandra/pull/2015 was (Author: smiklosovic): CI here: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2337/testReport/ branch for modified dtests here: https://github.com/apache/cassandra-dtest/pull/207 > remove deprecated DateTieredCompactionStrategy > -- > > Key: CASSANDRA-18043 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18043 > Project: Cassandra > Issue Type: Task > Components: Local/Compaction/DTCS >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > DTCS was marked as deprecated in CASSANDRA-9666 which was released in 3.0.8 > and 3.8. If I get our deprecation policies right, we wait one major release > (4.0) and we can remove it in the next one (5.0). Having 4.1 about to be > released soon and 4.2 will be 5.0, I think nothing blocks us from removing > this strategy in trunk. > This also makes CASSANDRA-18042 easier as it would most probably have to > cover this strategy as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18043) remove deprecated DateTieredCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697977#comment-17697977 ] Stefan Miklosovic commented on CASSANDRA-18043: --- CI here: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2337/testReport/ branch for modified dtests here: https://github.com/apache/cassandra-dtest/pull/207 > remove deprecated DateTieredCompactionStrategy > -- > > Key: CASSANDRA-18043 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18043 > Project: Cassandra > Issue Type: Task > Components: Local/Compaction/DTCS >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > DTCS was marked as deprecated in CASSANDRA-9666 which was released in 3.0.8 > and 3.8. If I get our deprecation policies right, we wait one major release > (4.0) and we can remove it in the next one (5.0). Having 4.1 about to be > released soon and 4.2 will be 5.0, I think nothing blocks us from removing > this strategy in trunk. > This also makes CASSANDRA-18042 easier as it would most probably have to > cover this strategy as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them together with local read/write ratio to tablestats
This is an automated email from the ASF dual-hosted git repository.
smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 4841794028 Add MaxSSTableSize and MaxSSTableDuration metrics and
propagate them together with local read/write ratio to tablestats
4841794028 is described below
commit 48417940280021d0012b7a7db6c9f823a98086e4
Author: Stefan Miklosovic
AuthorDate: Fri Feb 24 14:56:50 2023 +0100
Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them
together with local read/write ratio to tablestats
patch by Stefan Miklosovic; reviewed by Brandon Williams and Brad Schoening
for CASSANDRA-18283
---
CHANGES.txt| 1 +
NEWS.txt | 5 +-
doc/modules/cassandra/pages/operating/metrics.adoc | 7 +++
.../org/apache/cassandra/db/ColumnFamilyStore.java | 12 +
.../cassandra/db/ColumnFamilyStoreMBean.java | 19
.../TimeWindowCompactionStrategyOptions.java | 10 ++--
.../org/apache/cassandra/metrics/TableMetrics.java | 33 ++
src/java/org/apache/cassandra/tools/NodeProbe.java | 2 +
.../cassandra/tools/nodetool/TableStats.java | 3 +-
.../cassandra/tools/nodetool/stats/StatsTable.java | 4 ++
.../tools/nodetool/stats/StatsTableComparator.java | 22 -
.../tools/nodetool/stats/TableStatsHolder.java | 53 ++
.../tools/nodetool/stats/TableStatsPrinter.java| 20 +++-
.../cassandra/tools/nodetool/TableStatsTest.java | 9 ++--
.../nodetool/stats/StatsTableComparatorTest.java | 5 ++
.../nodetool/stats/TableStatsPrinterTest.java | 35 +-
.../tools/nodetool/stats/TableStatsTestBase.java | 7 +++
17 files changed, 214 insertions(+), 33 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 28e3305bd8..b6e94ec67d 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.0
+ * Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them
together with local read/write ratio to tablestats (CASSANDRA-18283)
* Add more logging around CompactionManager operations (CASSANDRA-18268)
* Reduce memory allocations of calls to ByteBufer.duplicate() made in
org.apache.cassandra.transport.CBUtil#writeValue (CASSANDRA-18212)
* CEP-17: SSTable API (CASSANDRA-17056)
diff --git a/NEWS.txt b/NEWS.txt
index 363c2deb58..ef582b6aa2 100644
--- a/NEWS.txt
+++ b/NEWS.txt
@@ -126,7 +126,10 @@ New features
normally require it, except `system_views.system_logs`.
- More accurate skipping of sstables in read path due to better handling
of min/max clustering and lower bound;
SSTable format has been bumped to 'nc' because there are new fields in
stats metadata\
-- SSTal
+- Added MaxSSTableSize and MaxSSTableDuration metrics to TableMetrics. The
former returns the size of the biggest
+ SSTable of a table or 0 when there is not any SSTable. The latter
returns the maximum duration, computed as
+ `maxTimestamp - minTimestamp`, effectively non-zero for SSTables
produced by TimeWindowCompactionStrategy.
+- Added local read/write ratio to tablestats.
Upgrading
-
diff --git a/doc/modules/cassandra/pages/operating/metrics.adoc
b/doc/modules/cassandra/pages/operating/metrics.adoc
index c650ec1c32..0102285c37 100644
--- a/doc/modules/cassandra/pages/operating/metrics.adoc
+++ b/doc/modules/cassandra/pages/operating/metrics.adoc
@@ -144,6 +144,13 @@ this table (in bytes).
|TotalDiskSpaceUsed |Counter |Total disk space used by SSTables
belonging to this table, including obsolete ones waiting to be GC'd.
+|MaxSSTableSize |Gauge |Maximum size of SSTable of this table -
+the physical size on disk of all components for such SSTable in bytes. Equals
to
+zero if there is not any SSTable on disk.
+
+|MaxSSTableDuration |Gauge |Maximum duration in milliseconds of an
SSTable for this table,
+computed as `maxTimestamp - minTimestamp`. Equals to zero if min or max
timestamp is `Long.MAX_VALUE`.
+
|MinPartitionSize |Gauge |Size of the smallest compacted partition
(in bytes).
diff --git a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
index edfe831a8c..4c567701b3 100644
--- a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
+++ b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
@@ -3435,6 +3435,18 @@ public class ColumnFamilyStore implements
ColumnFamilyStoreMBean, Memtable.Owner
return false;
}
+@Override
+public long getMaxSSTableSize()
+{
+return metric.maxSSTableSize.getValue();
+}
+
+@Override
+public long getMaxSSTableDuration()
+{
+return metric.maxSSTableDuration.getValue();
+}
+
@Override
public Map getTopSizePartitions()
{
diff --git a/src/java/org/apache/cassandra/
[jira] [Updated] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18283: -- Fix Version/s: 5.0 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/48417940280021d0012b7a7db6c9f823a98086e4 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Enhance diagnostic nodetool tablestats output > - > > Key: CASSANDRA-18283 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18283 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Brad Schoening >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.0 > > Attachments: image-2023-02-28-08-08-24-727.png > > Time Spent: 20m > Remaining Estimate: 0h > > The nodetool tablestats command lacks some available details which would be > very useful to report upon. This is especially helpful in > database-as-a-service environments where servers and their disk files are not > directly observable by users. > 1. Currently, for LCS tablestats reports useful details about the number of > sstables in each level: > SSTable count: 6635 > SSTables in each level: [1, 9, 98, 805, 5722, 0, 0, 0, 0] > This type of additional detail about the sstables is absent from STCS and > TWCS as it only reports the table count. > 1a) For STCS, tablestats should report the max sstable file size on disk. > This is useful to know if compaction has failed due to disk space or if a > forced compaction created a jumbo table. > 1b) For TWCS, tablestats should report the min & max timestamp, and duration > of the sstables representing windows. This is useful to know if > out-of-window writes or rows w/out a TTL have lead many more sstables on disk > than expected by the time window configuration. > STCs example: > SSTable count: 6635 > SSTable STCS max size: 122,000,000,000 > STCs example: > SSTable count: 6635 > SSTables Time Window 15 DAYS, max duration : 362d 7h 16m 49s > 2. While tablestats reports both memtable and disk file sstable statistics. > It is useful these are in the same command, but it would clarify the output > to separate mem vs disk into two sections > i.e., > -- File statistics > SSTable count: 6635 > SSTables in each level: [1, 9, 98, 805, 5722, 0, 0, 0, 0] > -- Memtable statistics > Bloom filter false positives: 12184123 > Bloom filter false ratio: 0.07203 > Bloom filter space used: 16874424 > Bloom filter off heap memory used: 16821344 > Index summary off heap memory used: 7525546 > Space used (live): 1324067896238 > 3. Read / Write count should also be reported as a ratio, such as: > Local read count: 202961459 > Local write count: 40554481 > Local read/write ratio: 5:1 > Local read latency: 1.957 ms > Local write count: 40554481 > Local write latency: 0.040 ms -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697967#comment-17697967 ] Andres de la Peña commented on CASSANDRA-18012: --- Thanks for checking. [~jmckenzie] are you also ok with the changes on the other branches? They patches are identical. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697963#comment-17697963 ] Ekaterina Dimitrova commented on CASSANDRA-18308: - +1, thank you for the fix > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.x > > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18308: - Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams) Brandon Williams, Brandon Williams (was: Brandon Williams) Status: Review In Progress (was: Patch Available) > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.x > > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18308: - Status: Ready to Commit (was: Review In Progress) > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.x > > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697952#comment-17697952 ] Brandon Williams commented on CASSANDRA-18308: -- +1 > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18308: - Reviewers: Brandon Williams > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18308: - Fix Version/s: 4.1.x 5.x > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.x > > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697932#comment-17697932 ] Jacek Lewandowski commented on CASSANDRA-18308: --- [4.1|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/602/workflows/be33bf6f-2158-491a-89cf-bb7906a4712f/jobs/3441] (/) [trunk|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/603/workflows/36260c94-4c77-4a88-b254-12e388d529e8/jobs/3443] (/) > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17698) sstabledump errors when dumping data from index
[
https://issues.apache.org/jira/browse/CASSANDRA-17698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697928#comment-17697928
]
Andres de la Peña commented on CASSANDRA-17698:
---
I don't think that CASSANDRA-17056 has done a major sstable format bump to
"ga". It seem it's still "nc", as it can be seen
[here|https://github.com/apache/cassandra/blob/b7e1e44a909c3a1d11e9c387db680c74d31b879f/src/java/org/apache/cassandra/io/sstable/format/big/BigFormat.java#L366].
That hasn't changed with the bump to 5.0 either.
Regarding whether we want to make a major sstable format bump on 5.0 for this,
I think that the bug is not so serious to be the only reason to do that bump.
But we can always ask on the dev mail list and see what others think.
As for the workaround for older branches, I understand that's to be done in the
separate CASSANDRA-18254, but I don't understand why that one is closed as
"Won't Fix".
> sstabledump errors when dumping data from index
> ---
>
> Key: CASSANDRA-17698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17698
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Stefan Miklosovic
>Assignee: maxwellguo
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> {code:java}
> cqlsh> CREATE KEYSPACE ks1 WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> cqlsh> CREATE TABLE ks1.tb1 ( id text, name text, primary key (id));
> cqlsh> CREATE INDEX IF NOT EXISTS ON ks1.tb1(name);
> cqlsh> INSERT INTO ks1.tb1 (id, name ) VALUES ( '1', 'Joe');
> cqlsh> exit
> ./bin/nodetool flush
> ./tools/bin/sstabledump
> data/data/ks1/tb1-1c3c5f10ee4711ecab82eda2f44200b3/.tb1_name_idx/nb-1-big-Data.db
>
> [
> {
> "partition" : {
> "key" : [ "Joe" ],
> "position" : 0
> },
> "rows" : [
> {
> "type" : "row",
> "position" : 17,
> "clustering" : [ ] } ] } ]Exception in thread "main"
> java.lang.UnsupportedOperationException
> at
> org.apache.cassandra.db.marshal.PartitionerDefinedOrder.toJSONString(PartitionerDefinedOrder.java:87)
> at
> org.apache.cassandra.db.marshal.AbstractType.toJSONString(AbstractType.java:187)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeClustering(JsonTransformer.java:372)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:269)
> at
> org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:235)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at
> java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at
> java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
> at
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
> at
> java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
> at
> org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:113)
> at
> org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:214) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18308: -- Test and Documentation Plan: run sstableverify dtest Status: Patch Available (was: In Progress) https://github.com/apache/cassandra-dtest/pull/212 > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18305) Enhance nodetool compactionstats with existing MBean metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18305:
---
Description:
Nodetool compactionstats reports only on active compactions, if nothing is
active, you see only:
{quote}$nodetool compactionstats
pending tasks: 0
{quote}
but in the MBean Compaction/TotalCompactionsCompleted there are recent
statistic in events/second for:
* Count
* FifteenMinueRate
* FiveMinueRate
* MeanRate
* OneMinuteRate
1) It would be useful to see in addition:
{quote}pending tasks: 0
compactions completed: 20
1 minute rate: 0/second
5 minute rate: 2.3/second
15 minute rate: 4.6/second
{quote}
2) Since compaction_throughput_mb_per_sec is a throttling parameter in
cassandra.yaml (default 64 MBps), it would be nice to show the actual
compaction throughput and be able to observe if you're close to the limit.
I.e.,
{quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
{quote}
3) for completness, compactionstats should list the number of concurrent
compactors configured
{quote}concurrent compactions permitted: 2
{quote}
or perhaps simply add to existing 'pending tasks' line:
{quote}2 concurrent compactors, 0 pending tasks
{quote}
was:
Nodetool compactionstats reports only on active compactions, if nothing is
active, you see only:
{quote}$nodetool compactionstats
pending tasks: 0
{quote}
but in the MBean Compaction/TotalCompactionsCompleted there are recent
statistic in events/second for:
* Count
* FifteenMinueRate
* FiveMinueRate
* MeanRate
* OneMinuteRate
1) It would be useful to see in addition:
{quote}pending tasks: 0
compactions completed: 20
1 minute rate: 0/second
5 minute rate: 2.3/second
15 minute rate: 4.6/second
{quote}
2) Since compaction_throughput_mb_per_sec is a throttling parameter in
cassandra.yaml (default 64 MBps), it would be nice to show the actual
compaction throughput and be able to observe if you're close to the limit.
I.e.,
{quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
{quote}
3) for completness, compactionstats should list the number of concurrent
compactors configured
{quote}concurrent compactions permitted: 2
{quote}
> Enhance nodetool compactionstats with existing MBean metrics
>
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Assignee: Stefan Miklosovic
>Priority: Normal
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured
> {quote}concurrent compactions permitted: 2
> {quote}
> or perhaps simply add to existing 'pending tasks' line:
> {quote}2 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697902#comment-17697902 ] Jacek Lewandowski commented on CASSANDRA-18308: --- https://ci-cassandra.apache.org/job/Cassandra-4.1/281/testReport/dtest.offline_tools_test/TestOfflineTools/ > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18308) Fix broken sstableverify dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18308: -- Bug Category: Parent values: Code(13163) Complexity: Low Hanging Fruit Component/s: Test/dtest/python Discovered By: DTest Severity: Low Status: Open (was: Triage Needed) > Fix broken sstableverify dtest > -- > > Key: CASSANDRA-18308 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= > 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18308) Fix broken sstableverify dtest
Jacek Lewandowski created CASSANDRA-18308: - Summary: Fix broken sstableverify dtest Key: CASSANDRA-18308 URL: https://issues.apache.org/jira/browse/CASSANDRA-18308 Project: Cassandra Issue Type: Bug Reporter: Jacek Lewandowski Assignee: Jacek Lewandowski I accidentally broken sstableverify dtest in CASSANDRA-17056 for versions <= 4.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697890#comment-17697890 ] Jacek Lewandowski commented on CASSANDRA-18291: --- sure, thanks [~smiklosovic] > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697869#comment-17697869 ] Brandon Williams commented on CASSANDRA-18307: -- I don't recall anything failing and the script would've died, right? I definitely got to the end and passed the release email to Stefan. bq. let me know if you need help re-running just the jfrog upload commands off the old (voted-on) sha of dist.a.o I'll get it done, but I think we should break the monolithic scripts into discrete steps that a wrapper invokes so this is much easier in the future. > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Assignee: Brandon Williams >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-18307: Assignee: Brandon Williams > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Assignee: Brandon Williams >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697855#comment-17697855 ] Stefan Miklosovic commented on CASSANDRA-18291: --- +1. Could you provide the build as well, please? > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18291: -- Reviewers: Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic) Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic) Status: Review In Progress (was: Patch Available) > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18291: -- Status: Patch Available (was: Review In Progress) > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (571cd5ec -> cae85411)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 571cd5ec generate docs for c4206294 new cae85411 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (571cd5ec) \ N -- N -- N refs/heads/asf-staging (cae85411) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18291) Too early schema version change in system local table
[ https://issues.apache.org/jira/browse/CASSANDRA-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18291: -- Reviewers: Stefan Miklosovic, Stefan Miklosovic Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic) Status: Review In Progress (was: Patch Available) > Too early schema version change in system local table > - > > Key: CASSANDRA-18291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18291 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1.x, 5.0 > > > Schema version in the system local table is updated after the schema changes > is saved but before it is applied. > Found by [~maxtomassi] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697821#comment-17697821 ] Michael Semb Wever edited comment on CASSANDRA-18307 at 3/8/23 10:07 AM: - Thanks for the report [~rtib]. [~brandon.williams], I think you ran finish_release.sh for this? something fail when you ran it? let me know if you need help re-running just the jfrog upload commands off the old (voted-on) sha of dist.a.o was (Author: michaelsembwever): Thanks for the report [~rtib]. [~brandon.williams], I think you ran finish_release.sh for this? something fail when you ran it? > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697821#comment-17697821 ] Michael Semb Wever commented on CASSANDRA-18307: Thanks for the report [~rtib]. [~brandon.williams], I think you ran finish_release.sh for this? something fail when you ran it? > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
[ https://issues.apache.org/jira/browse/CASSANDRA-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Repasi updated CASSANDRA-18307: - Component/s: Packaging > Release 4.0.8 not available on jfrog package repositories > - > > Key: CASSANDRA-18307 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Tibor Repasi >Priority: Normal > > Release 4.0.8 was published to dist/downloads.a.o only and seems not > available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18307) Release 4.0.8 not available on jfrog package repositories
Tibor Repasi created CASSANDRA-18307: Summary: Release 4.0.8 not available on jfrog package repositories Key: CASSANDRA-18307 URL: https://issues.apache.org/jira/browse/CASSANDRA-18307 Project: Cassandra Issue Type: Bug Reporter: Tibor Repasi Release 4.0.8 was published to dist/downloads.a.o only and seems not available at apache.jfrog.io neither for Debian nor RPM. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18299) Add support for prepared statements for accord transactions
[ https://issues.apache.org/jira/browse/CASSANDRA-18299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697771#comment-17697771 ] Alex Petrov commented on CASSANDRA-18299: - +1, LGTM > Add support for prepared statements for accord transactions > --- > > Key: CASSANDRA-18299 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18299 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.x > > Time Spent: 7h 40m > Remaining Estimate: 0h > > When you try to prepare an accord transaction we get a NullPointerException > in method > org.apache.cassandra.cql3.statements.QualifiedStatement#isFullyQualified. > This is due to TransactionStatement extending but not overriding all the > methods (and setting name to null). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
