[jira] [Commented] (CASSANDRA-18580) Baseline Metrics for Accord Transactions
[ https://issues.apache.org/jira/browse/CASSANDRA-18580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750176#comment-17750176 ] Jacek Lewandowski commented on CASSANDRA-18580: --- I'll confirm that > Baseline Metrics for Accord Transactions > > > Key: CASSANDRA-18580 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18580 > Project: Cassandra > Issue Type: Improvement > Components: Accord, Observability/JMX, Observability/Metrics >Reporter: Caleb Rackliffe >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Based on some conversations w/ [~benedict] and [~dcapwell], this is the > initial set of metrics that seem both feasible to implement and useful as we > monitor the health of a cluster performing Accord transactions: > 1.) Basic latency metrics for transactions up to the point of COMMIT and rate > metrics for preemption, failure, and timeouts at the coordinator. > This has already been implemented and split into read and write-specific > metrics. Our position for now is that metrics around preemption should be > useful in place of a more difficult-to-define metric around how many > transactions are completed via recovery. > 2.) Global cache stats/metrics (i.e. aggregated for all command stores) > We could, at some point, build metrics scoped to a specific {{CommandStore}}, > but they might be awkward in MBean/JMX space, as command stores would have to > be identified by ID or key range…the latter possibly being able to change > across epochs. (An alternative would be just publishing command > store-specific stats on-demand to a virtual table instead.) > 3.) Something like a decaying histogram of the number of dependencies per > transaction (or per partial transaction). > If this is getting worse over time, it could be useful to know/be a way for > us to detect that contention is increasing. We should be able to hook this up > to {{ProgressLog}} notifications. Recording for PartialDeps/PartialTxn (which > ProgressLog gives us at pre-accept) seems acceptable, given this is a > directional metric. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750198#comment-17750198 ] Stefan Miklosovic commented on CASSANDRA-18713: --- j17 trunk https://app.circleci.com/pipelines/github/instaclustr/cassandra/2839/workflows/72100153-b461-4a1a-b7fd-80009fb601c1 j11 trunk https://app.circleci.com/pipelines/github/instaclustr/cassandra/2839/workflows/31a2e495-3be7-4ee3-a040-188625562cf5 j11 4.1 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2837/workflows/94e4fdda-0b56-4365-ae5b-6cf1a1ecc475 j8 4.1 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2837/workflows/2ce4d8f6-7b74-42de-ba2b-795994d5913e > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18719) Preparing IDE configuration should not require Accord compilation
Jacek Lewandowski created CASSANDRA-18719: - Summary: Preparing IDE configuration should not require Accord compilation Key: CASSANDRA-18719 URL: https://issues.apache.org/jira/browse/CASSANDRA-18719 Project: Cassandra Issue Type: Task Components: Accord, Build Reporter: Jacek Lewandowski -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (76dfd98e -> efac8663)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 76dfd98e generate docs for f02aa10d new efac8663 generate docs for f02aa10d This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (76dfd98e) \ N -- N -- N refs/heads/asf-staging (efac8663) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (efac8663 -> 0904fd19)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard efac8663 generate docs for f02aa10d new 0904fd19 generate docs for f02aa10d This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (efac8663) \ N -- N -- N refs/heads/asf-staging (0904fd19) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18679: - Status: Needs Committer (was: Patch Available) > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750283#comment-17750283 ] Brandon Williams commented on CASSANDRA-18679: -- 4.0 hit CASSANDRA-18366, 4.1 is clean and trunk hit CASSANDRA-17992. No new failures, everything looks good to me, +1. > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (0904fd19 -> 902b45db)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 0904fd19 generate docs for f02aa10d new 902b45db generate docs for f02aa10d This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0904fd19) \ N -- N -- N refs/heads/asf-staging (902b45db) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17534) CQLSH help topic links are broken between textile and online files
[ https://issues.apache.org/jira/browse/CASSANDRA-17534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750329#comment-17750329 ] Vineet Gali commented on CASSANDRA-17534: - [~smiklosovic] any updates on if this looks fine now? > CQLSH help topic links are broken between textile and online files > -- > > Key: CASSANDRA-17534 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17534 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > CQLSH help topics opens a generic CQL page, not the specific topic. This > happens when docs are not installed locally, and it tries to open the online > version. > The file cqlsh.py has: > {{ # default location of local CQL.html}} > {{ if os.path.exists(CASSANDRA_PATH + '/doc/cql3/CQL.html'):}} > {{ }} > {{ else:}} > {{ # fallback to online version}} > {{ CASSANDRA_CQL_HTML = CASSANDRA_CQL_HTML_FALLBACK}} > For example, > {{cqlsh> help truncate;}} > opens the page: > [https://cassandra.apache.org/doc/latest/cassandra/cql/index.html#truncateStmt] > but there is no information about 'truncate' on that page and the anchor > #truncateStmt doesn't exist. > the correct page anchor is: > [https://cassandra.apache.org/doc/latest/cassandra/cql/ddl.html#truncate-statement] > The local file anchors appear they may be incorrect as well: > [https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#truncate] > To reproduce this, 'pip install cqlsh' on a machine without a Cassandra > package install. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750335#comment-17750335 ] Timothy Tu commented on CASSANDRA-18529: [~brandon.williams] ,[~smiklosovic] does this look good or are there concerns? > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750362#comment-17750362 ] Brandon Williams edited comment on CASSANDRA-18529 at 8/2/23 2:37 PM: -- Let's see what CI thinks: ||Branch||CI|| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18529-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1160/workflows/cbf5e1e6-bb91-4de2-93be-473e0ad6e6be], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1160/workflows/85a72adb-ef43-4c58-88be-a6fa921e0838]| and...it doesn't compile, [~timothytu]. was (Author: brandon.williams): Let's see what CI thinks: ||Branch||CI|| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18529-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1160/workflows/cbf5e1e6-bb91-4de2-93be-473e0ad6e6be], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1160/workflows/85a72adb-ef43-4c58-88be-a6fa921e0838]| > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18679: Status: Review In Progress (was: Needs Committer) > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18679: Reviewers: Brandon Williams, Ekaterina Dimitrova > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18679: Status: Ready to Commit (was: Review In Progress) > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750380#comment-17750380 ] Ekaterina Dimitrova commented on CASSANDRA-18679: - +1, thank you! > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Fix NTS log message when an unrecognized strategy option is passed
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-4.0 by this push: new 8b331ddb4d Fix NTS log message when an unrecognized strategy option is passed 8b331ddb4d is described below commit 8b331ddb4db61dc71c81bf304e93004524afe949 Author: Saran Vinaiyak AuthorDate: Wed Aug 2 01:16:22 2023 +0530 Fix NTS log message when an unrecognized strategy option is passed Patch by Saran Vinaiyak; reviewed by brandonwilliams and edimitrova for CASSANDRA-18679 --- CHANGES.txt| 1 + src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 5a12109fdc..a45b6dce5d 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.0.12 + * Fix NTS log message when an unrecognized strategy option is passed (CASSANDRA-18679) * Fix BulkLoader ignoring cipher suites options (CASSANDRA-18582) * Migrate Python optparse to argparse (CASSANDRA-17914) Merged from 3.11: diff --git a/src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java b/src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java index 2b4a0eaab8..75aade85af 100644 --- a/src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java +++ b/src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java @@ -86,7 +86,6 @@ public class NetworkTopologyStrategy extends AbstractReplicationStrategy datacenters = Collections.unmodifiableMap(newDatacenters); aggregateRf = ReplicationFactor.withTransient(replicas, trans); -logger.info("Configured datacenter replicas are {}", FBUtilities.toString(datacenters)); } /** @@ -302,6 +301,7 @@ public class NetworkTopologyStrategy extends AbstractReplicationStrategy // Validate the data center names super.validateExpectedOptions(); +logger.info("Configured datacenter replicas are {}", FBUtilities.toString(datacenters)); } @Override - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 2f0adfac2b424519c13b119be05583e004157d36 Merge: 9c796dfb27 8b331ddb4d Author: Brandon Williams AuthorDate: Wed Aug 2 10:44:36 2023 -0500 Merge branch 'cassandra-4.0' into cassandra-4.1 CHANGES.txt| 1 + src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 5ce92be10e,a45b6dce5d..6bb86a057a --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,6 -1,5 +1,7 @@@ -4.0.12 +4.1.4 + * Skip ColumnFamilyStore#topPartitions initialization when client or tool mode (CASSANDRA-18697) +Merged from 4.0: + * Fix NTS log message when an unrecognized strategy option is passed (CASSANDRA-18679) * Fix BulkLoader ignoring cipher suites options (CASSANDRA-18582) * Migrate Python optparse to argparse (CASSANDRA-17914) Merged from 3.11: diff --cc src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java index 1d39bbe37f,75aade85af..56bb261781 --- a/src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java +++ b/src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java @@@ -315,15 -301,7 +314,16 @@@ public class NetworkTopologyStrategy ex // Validate the data center names super.validateExpectedOptions(); + +if (keyspaceName.equalsIgnoreCase(SchemaConstants.AUTH_KEYSPACE_NAME)) +{ +Set differenceSet = Sets.difference((Set) recognizedOptions(), configOptions.keySet()); +if (!differenceSet.isEmpty()) +{ +throw new ConfigurationException("Following datacenters have active nodes and must be present in replication options for keyspace " + SchemaConstants.AUTH_KEYSPACE_NAME + ": " + differenceSet.toString()); +} +} + logger.info("Configured datacenter replicas are {}", FBUtilities.toString(datacenters)); } @Override - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 087e92724e5ca01fe740c039bb235fbb121043be Merge: 09d9067121 2f0adfac2b Author: Brandon Williams AuthorDate: Wed Aug 2 10:46:59 2023 -0500 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 1 + src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 7665f7bca8,6bb86a057a..4f1749eb25 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,186 -1,7 +1,187 @@@ -4.1.4 +5.0 + * Fix for (unsupported) big endian unaligned architecture, eg s390x (CASSANDRA-17723) + * CIDR filtering authorizer (CASSANDRA-18592) + * Remove 3.x from the versions checked for prepared statement behaviour (CASSANDRA-18695) + * Add vector similarity functions (CASSANDRA-18640) + * Lift MessagingService.minimum_version to 40 (CASSANDRA-18314) + * Introduce pluggable crypto providers and default to AmazonCorrettoCryptoProvider (CASSANDRA-18624) + * Improved DeletionTime serialization (CASSANDRA-18648) + * CEP-7: Storage Attached Indexes (CASSANDRA-16052) + * Add equals/hashCode override for ServerEncryptionOptions (CASSANDRA-18428) + * Upgrade ECJ to version 3.33.0 (CASSANDRA-18190) + * Fix ClassCastException from jdk GaloisCounterMode when using JDK17 provider (CASSANDRA-18180) + * Drop JDK8, add JDK17 (CASSANDRA-18255) + * Remove WaitingOnFreeMemtableSpace and DroppedMutations metrics (CASSANDRA-18298) + * Upgrade Jamm version to 0.4.0 (CASSANDRA-17884, CASSANDRA-16304, CASSANDRA-18329) + * Remove legacy 3.0/3.11 buffer pool metrics (CASSANDRA-18313) + * Add AzureSnitch (CASSANDRA-18646) + * Implementation of the Unified Compaction Strategy as described in CEP-26 (CASSANDRA-18397) + * Upgrade commons cli to 1.5.0 (CASSANDRA-18659) + * Disable the deprecated keyspace/table thresholds and convert them to guardrails (CASSANDRA-18617) + * Deprecate CloudstackSnitch and remove duplicate code in snitches (CASSANDRA-18438) + * Add support for vectors in UDFs (CASSANDRA-18613) + * Improve vector value validation errors (CASSANDRA-18652) + * Upgrade Guava to 32.0.1 (CASSANDRA-18645) + * Add duration and count of partition keys to sstablemetadata (CASSANDRA-18639) + * Remove deprecated compaction_tombstone_warning_threshold and compaction_large_partition_warning_threshold from yaml (CASSANDRA-18626) + * Enhance nodetool compactionstats with additional metrics (CASSANDRA-18305) + * Added support for type VECTOR (CASSANDRA-18504) + * Expose bootstrap and decommission state to nodetool info (CASSANDRA-18555) + * Fix SSTabledump errors when dumping data from index (CASSANDRA-17698) + * Avoid unnecessary deserialization of terminal arguments when executing CQL functions (CASSANDRA-18566) + * Remove dependency on pytz library for setting CQLSH timezones on Python version >= 3.9 (CASSANDRA-17433) + * Extend maximum expiration date (CASSANDRA-14227) + * Add guardrail for partition tombstones and deprecate compaction_tombstone_warning_threshold (CASSANDRA-17194) + * Print header and statistics for cassandra-stress output with arbitrary frequency (CASSANDRA-12972) + * CEP-25: Trie-indexed SSTable format (CASSANDRA-18398) + * Make cassandra-stress able to read all credentials from a file (CASSANDRA-18544) + * Add guardrail for partition size and deprecate compaction_large_partition_warning_threshold (CASSANDRA-18500) + * Add HISTORY command for CQLSH (CASSANDRA-15046) + * Fix sstable formats configuration (CASSANDRA-18441) + * Add guardrail to bound timestamps (CASSANDRA-18352) + * Add keyspace_name column to system_views.clients (CASSANDRA-18525) + * Moved system properties and envs to CassandraRelevantProperties and CassandraRelevantEnv respectively (CASSANDRA-17797) + * Add sstablepartitions offline tool to find large partitions in sstables (CASSANDRA-8720) + * Replace usages of json-simple dependency by Jackson (CASSANDRA-16855) + * When decommissioning should set Severity to limit traffic (CASSANDRA-18430) + * For Java11 and Java17 remove -XX:-UseBiasedLocking as it is the default already (CASSANDRA-17869) + * Upgrade commons-io to 2.11.0 (CASSANDRA-17364) + * Node Draining Should Abort All Current SSTables Imports (CASSANDRA-18373) + * Use snake case for the names of CQL native functions (CASSANDRA-18037) + * Use jdk-dependent checkstyle version to check the source code (CASSANDRA-18262) + * Provide summary of failed SessionInfo's in StreamResultFuture (CASSANDRA-17199) + * CEP-20: Dynamic Data Masking (CASSANDRA-17940) + * Add system_views.snapshots virtual table (CASSANDRA-18102) + * Update OpenHFT dependencies (chronicle-queue, chronicle-core, chronicle-bytes, chronicle-wire, chronicle-threads) (CASSANDRA-18049) + * Remove org.apache.cass
[cassandra] branch trunk updated (09d9067121 -> 087e92724e)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 09d9067121 Merge branch 'cassandra-4.1' into trunk new 8b331ddb4d Fix NTS log message when an unrecognized strategy option is passed new 2f0adfac2b Merge branch 'cassandra-4.0' into cassandra-4.1 new 087e92724e Merge branch 'cassandra-4.1' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (9c796dfb27 -> 2f0adfac2b)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 9c796dfb27 Skip ColumnFamilyStore#topPartitions initialization when client or tool mode new 8b331ddb4d Fix NTS log message when an unrecognized strategy option is passed new 2f0adfac2b Merge branch 'cassandra-4.0' into cassandra-4.1 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18679) Attempted NTS creation logs even on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18679: - Fix Version/s: 4.0.12 4.1.4 5.0 (was: 5.x) (was: 4.0.x) (was: 4.1.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra/commit/8b331ddb4db61dc71c81bf304e93004524afe949 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks! > Attempted NTS creation logs even on failure > --- > > Key: CASSANDRA-18679 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18679 > Project: Cassandra > Issue Type: Bug > Components: CQL/Semantics >Reporter: Brandon Williams >Assignee: Saran Vinaiyak >Priority: Normal > Fix For: 4.0.12, 4.1.4, 5.0 > > > If you try to create a keyspace with a nonexistent DC, you will still see a > log like this: > {noformat} > INFO [Native-Transport-Requests-1] 2023-07-21 11:02:40,062 > NetworkTopologyStrategy.java:93 - Configured datacenter replicas are > DC2:rf(3), DC1:rf(1) > {noformat} > even if you receive: > {noformat} > ConfigurationException: Unrecognized strategy option {DC2} passed to > NetworkTopologyStrategy for keyspace test > {noformat} > which prevented the creation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18720) BLOG - Town Hall Replay: Monitoring Apache Cassandra Without Implementation
Diogenese Topper created CASSANDRA-18720: Summary: BLOG - Town Hall Replay: Monitoring Apache Cassandra Without Implementation Key: CASSANDRA-18720 URL: https://issues.apache.org/jira/browse/CASSANDRA-18720 Project: Cassandra Issue Type: Task Components: Documentation/Blog Reporter: Diogenese Topper This ticket is to capture the work associated with publishing the blog "Town Hall Replay: Monitoring Apache Cassandra Without Implementation" This blog can be published as soon as possible, but if it cannot be published within a week of the noted publish date *(Aug 2)*, please contact me, suggest changes, or correct the date when possible in the pull request for the appropriate time that the blog will go live (on both the blog.adoc and the blog post's file). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18720) BLOG - Town Hall Replay: Monitoring Apache Cassandra Without Implementation
[ https://issues.apache.org/jira/browse/CASSANDRA-18720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-18720: - Change Category: Semantic Complexity: Normal Status: Open (was: Triage Needed) > BLOG - Town Hall Replay: Monitoring Apache Cassandra Without Implementation > --- > > Key: CASSANDRA-18720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18720 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Diogenese Topper >Priority: Normal > > This ticket is to capture the work associated with publishing the blog "Town > Hall Replay: Monitoring Apache Cassandra Without Implementation" > This blog can be published as soon as possible, but if it cannot be published > within a week of the noted publish date *(Aug 2)*, please contact me, suggest > changes, or correct the date when possible in the pull request for the > appropriate time that the blog will go live (on both the blog.adoc and the > blog post's file). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18720) BLOG - Town Hall Replay: Monitoring Apache Cassandra Without Implementation
[ https://issues.apache.org/jira/browse/CASSANDRA-18720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-18720: - Test and Documentation Plan: * Add blog post titled "Town Hall Replay: Monitoring Apache Cassandra Without Implementation" * Modify blog index page Status: Patch Available (was: Open) https://github.com/apache/cassandra-website/pull/232 > BLOG - Town Hall Replay: Monitoring Apache Cassandra Without Implementation > --- > > Key: CASSANDRA-18720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18720 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Diogenese Topper >Priority: Normal > > This ticket is to capture the work associated with publishing the blog "Town > Hall Replay: Monitoring Apache Cassandra Without Implementation" > This blog can be published as soon as possible, but if it cannot be published > within a week of the noted publish date *(Aug 2)*, please contact me, suggest > changes, or correct the date when possible in the pull request for the > appropriate time that the blog will go live (on both the blog.adoc and the > blog post's file). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18713: -- Status: Needs Committer (was: Patch Available) > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750403#comment-17750403 ] Stefan Miklosovic commented on CASSANDRA-18713: --- tests look good, j17 trunk cqlshlib failure is some kind of a flake, I was not able to reproduce it locally. I am going to ship it. > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18713: -- Reviewers: David Capwell Status: Review In Progress (was: Needs Committer) > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18713: -- Status: Ready to Commit (was: Review In Progress) > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18713: -- Fix Version/s: 4.1.x 5.x > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18703) Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle
[ https://issues.apache.org/jira/browse/CASSANDRA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18703: Reviewers: Michael Semb Wever (was: Caleb Rackliffe, Michael Semb Wever) > Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle > -- > > Key: CASSANDRA-18703 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18703 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The utest > {{org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle}} > is consistently broken with tries at least on trunk: > * > https://app.circleci.com/pipelines/github/adelapena/cassandra/3068/workflows/17760f03-9807-41cc-9cb3-a1fdf3e60f77/jobs/64069/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15684/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15692/tests > {code} > junit.framework.AssertionFailedError: Got 4 extra row(s) and 2 missing row(s) > in result. Extra rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=4, > min_row_id=0, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=339) > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=3, > min_row_id=2, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=310) > Missing Rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=4, > min_row_id=2, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=5, > min_row_id=0, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrderInternal(CQLTester.java:1900) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrder(CQLTester.java:1834) > at > org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest.testVirtualTableThroughIndexLifeCycle(SSTablesSystemViewTest.java:133) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > {code} > The failure seems exclusive to {{test-trie}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.a
[jira] [Updated] (CASSANDRA-18703) Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle
[ https://issues.apache.org/jira/browse/CASSANDRA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18703: Status: Ready to Commit (was: Review In Progress) > Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle > -- > > Key: CASSANDRA-18703 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18703 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The utest > {{org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle}} > is consistently broken with tries at least on trunk: > * > https://app.circleci.com/pipelines/github/adelapena/cassandra/3068/workflows/17760f03-9807-41cc-9cb3-a1fdf3e60f77/jobs/64069/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15684/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15692/tests > {code} > junit.framework.AssertionFailedError: Got 4 extra row(s) and 2 missing row(s) > in result. Extra rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=4, > min_row_id=0, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=339) > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=3, > min_row_id=2, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=310) > Missing Rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=4, > min_row_id=2, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=5, > min_row_id=0, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrderInternal(CQLTester.java:1900) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrder(CQLTester.java:1834) > at > org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest.testVirtualTableThroughIndexLifeCycle(SSTablesSystemViewTest.java:133) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > {code} > The failure seems exclusive to {{test-trie}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additiona
[jira] [Updated] (CASSANDRA-18703) Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle
[ https://issues.apache.org/jira/browse/CASSANDRA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18703: Reviewers: Michael Semb Wever, Caleb Rackliffe Michael Semb Wever, Caleb Rackliffe (was: Caleb Rackliffe, Michael Semb Wever) Status: Review In Progress (was: Patch Available) > Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle > -- > > Key: CASSANDRA-18703 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18703 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The utest > {{org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle}} > is consistently broken with tries at least on trunk: > * > https://app.circleci.com/pipelines/github/adelapena/cassandra/3068/workflows/17760f03-9807-41cc-9cb3-a1fdf3e60f77/jobs/64069/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15684/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15692/tests > {code} > junit.framework.AssertionFailedError: Got 4 extra row(s) and 2 missing row(s) > in result. Extra rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=4, > min_row_id=0, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=339) > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=3, > min_row_id=2, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=310) > Missing Rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=4, > min_row_id=2, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=5, > min_row_id=0, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrderInternal(CQLTester.java:1900) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrder(CQLTester.java:1834) > at > org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest.testVirtualTableThroughIndexLifeCycle(SSTablesSystemViewTest.java:133) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > {code} > The failure seems exclusive to {{test-trie}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CASSANDRA-18703) Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle
[ https://issues.apache.org/jira/browse/CASSANDRA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750416#comment-17750416 ] Caleb Rackliffe commented on CASSANDRA-18703: - Thanks for the review [~mck]. Starting commit... > Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle > -- > > Key: CASSANDRA-18703 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18703 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The utest > {{org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle}} > is consistently broken with tries at least on trunk: > * > https://app.circleci.com/pipelines/github/adelapena/cassandra/3068/workflows/17760f03-9807-41cc-9cb3-a1fdf3e60f77/jobs/64069/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15684/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15692/tests > {code} > junit.framework.AssertionFailedError: Got 4 extra row(s) and 2 missing row(s) > in result. Extra rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=4, > min_row_id=0, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=339) > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=3, > min_row_id=2, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=310) > Missing Rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=4, > min_row_id=2, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=5, > min_row_id=0, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrderInternal(CQLTester.java:1900) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrder(CQLTester.java:1834) > at > org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest.testVirtualTableThroughIndexLifeCycle(SSTablesSystemViewTest.java:133) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > {code} > The failure seems exclusive to {{test-trie}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: co
[jira] [Assigned] (CASSANDRA-18189) Test failure in cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts
[ https://issues.apache.org/jira/browse/CASSANDRA-18189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-18189: Assignee: Brandon Williams > Test failure in > cqlsh_tests.test_cqlsh_copy.TestCqlshCopy.test_bulk_round_trip_with_timeouts > > > Key: CASSANDRA-18189 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18189 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Caleb Rackliffe >Assignee: Brandon Williams >Priority: Normal > Labels: cqlsh, dtest, python, test > Fix For: 4.0.x, 5.x > > > https://ci-cassandra.apache.org/job/Cassandra-4.0/523/testReport/dtest.cqlsh_tests.test_cqlsh_copy/TestCqlshCopy/test_bulk_round_trip_with_timeouts/ > {noformat} > assert 10 == 94764 > + where 10 = sum( TestCqlshCopy._test_bulk_round_trip.. at 0x7f8b21987b90>) > + and 94764 = sum( TestCqlshCopy._test_bulk_round_trip.. at 0x7f8b21986dc0>) > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit fe9ad77fd7842f69a03c7991b96274a7fdb3e90f Merge: 087e92724e b94436c783 Author: Stefan Miklosovic AuthorDate: Wed Aug 2 18:36:36 2023 +0200 Merge branch 'cassandra-4.1' into trunk src/java/org/apache/cassandra/config/Config.java | 2 +- .../org/apache/cassandra/config/Converters.java| 1 + test/data/config/version=3.0.0-alpha1.yml | 3 + test/data/config/version=4.0-alpha1.yml| 3 + test/data/config/version=4.1-alpha1.yml| 424 + ...e.java => ConfigCompatibilityTestGenerate.java} | 12 +- ...ilityTest.java => ConfigCompatibilityTest.java} | 19 +- 7 files changed, 452 insertions(+), 12 deletions(-) diff --cc src/java/org/apache/cassandra/config/Config.java index 34a173c8c6,8a59ca2cda..831bf93cfc --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@@ -876,16 -837,6 +876,16 @@@ public class Confi public volatile boolean compact_tables_enabled = true; public volatile boolean read_before_write_list_operations_enabled = true; public volatile boolean allow_filtering_enabled = true; +public volatile boolean simplestrategy_enabled = true; +@Replaces(oldName = "compaction_large_partition_warning_threshold_mb", converter = Converters.LONG_BYTES_DATASTORAGE_MEBIBYTES_INT, deprecated = true) +@Replaces(oldName = "compaction_large_partition_warning_threshold", converter = Converters.LONG_BYTES_DATASTORAGE_MEBIBYTES_DATASTORAGE, deprecated = true) +public volatile DataStorageSpec.LongBytesBound partition_size_warn_threshold = null; +public volatile DataStorageSpec.LongBytesBound partition_size_fail_threshold = null; - @Replaces(oldName = "compaction_tombstone_warning_threshold", converter = Converters.IDENTITY, deprecated = true) ++@Replaces(oldName = "compaction_tombstone_warning_threshold", converter = Converters.INTEGER_PRIMITIVE_LONG, deprecated = true) +public volatile long partition_tombstones_warn_threshold = -1; +public volatile long partition_tombstones_fail_threshold = -1; +public volatile DataStorageSpec.LongBytesBound column_value_size_warn_threshold = null; +public volatile DataStorageSpec.LongBytesBound column_value_size_fail_threshold = null; public volatile DataStorageSpec.LongBytesBound collection_size_warn_threshold = null; public volatile DataStorageSpec.LongBytesBound collection_size_fail_threshold = null; public volatile int items_per_collection_warn_threshold = -1; diff --cc src/java/org/apache/cassandra/config/Converters.java index 74ff7a2476,c898c08d64..c3983652e6 --- a/src/java/org/apache/cassandra/config/Converters.java +++ b/src/java/org/apache/cassandra/config/Converters.java @@@ -42,6 -40,6 +42,7 @@@ public enum Converter * able to still use the old name too. No units involved. */ IDENTITY(null, null, o -> o, o -> o), ++INTEGER_PRIMITIVE_LONG(Integer.class, long.class, Integer::longValue, Long::intValue), MILLIS_DURATION_LONG(Long.class, DurationSpec.LongMillisecondsBound.class, DurationSpec.LongMillisecondsBound::new, o -> o == null ? null : o.toMilliseconds()), diff --cc test/data/config/version=4.1-alpha1.yml index 00,00..1b53159afc new file mode 100644 --- /dev/null +++ b/test/data/config/version=4.1-alpha1.yml @@@ -1,0 -1,0 +1,424 @@@ ++--- ++columns_per_table_warn_threshold: "java.lang.Integer" ++repaired_data_tracking_for_range_reads_enabled: "java.lang.Boolean" ++cdc_block_writes: "java.lang.Boolean" ++block_for_peers_timeout_in_secs: "java.lang.Integer" ++flush_compression: "org.apache.cassandra.config.Config.FlushCompression" ++commitlog_total_space: "org.apache.cassandra.config.DataStorageSpec.IntMebibytesBound" ++audit_logging_options: ++ audit_logs_dir: "java.lang.String" ++ included_users: "java.lang.String" ++ logger: ++class_name: "java.lang.String" ++parameters: "java.util.Map" ++ excluded_categories: "java.lang.String" ++ roll_cycle: "java.lang.String" ++ enabled: "java.lang.Boolean" ++ included_categories: "java.lang.String" ++ max_archive_retries: "java.lang.Integer" ++ excluded_keyspaces: "java.lang.String" ++ archive_command: "java.lang.String" ++ included_keyspaces: "java.lang.String" ++ max_log_size: "java.lang.Long" ++ allow_nodetool_archive_command: "java.lang.Boolean" ++ block: "java.lang.Boolean" ++ excluded_users: "java.lang.String" ++ max_queue_weight: "java.lang.Integer" ++row_cache_save_period: "org.apache.cassandra.config.DurationSpec.IntSecondsBound" ++snapshot_links_per_second: "java.lang.Long" ++disk_optimization_estimate_percentile: "java.lang.Double" ++roles_update_interval: "org.apache.cassandra.config.DurationSpec.
[cassandra] branch cassandra-4.1 updated (2f0adfac2b -> b94436c783)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 2f0adfac2b Merge branch 'cassandra-4.0' into cassandra-4.1 add b94436c783 update ConfigCompatibility test No new revisions were added by this update. Summary of changes: test/data/config/version=3.0.0-alpha1.yml | 3 +++ test/data/config/version=4.0-alpha1.yml| 3 +++ ...yTestGenerate.java => ConfigCompatibilityTestGenerate.java} | 10 +- ...nfigCompatabilityTest.java => ConfigCompatibilityTest.java} | 7 --- 4 files changed, 15 insertions(+), 8 deletions(-) rename test/distributed/org/apache/cassandra/distributed/upgrade/{ConfigCompatabilityTestGenerate.java => ConfigCompatibilityTestGenerate.java} (89%) rename test/unit/org/apache/cassandra/config/{ConfigCompatabilityTest.java => ConfigCompatibilityTest.java} (98%) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (087e92724e -> fe9ad77fd7)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 087e92724e Merge branch 'cassandra-4.1' into trunk add b94436c783 update ConfigCompatibility test new fe9ad77fd7 Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/java/org/apache/cassandra/config/Config.java | 2 +- .../org/apache/cassandra/config/Converters.java| 1 + test/data/config/version=3.0.0-alpha1.yml | 3 + test/data/config/version=4.0-alpha1.yml| 3 + test/data/config/version=4.1-alpha1.yml| 424 + ...e.java => ConfigCompatibilityTestGenerate.java} | 12 +- ...ilityTest.java => ConfigCompatibilityTest.java} | 19 +- 7 files changed, 452 insertions(+), 12 deletions(-) create mode 100644 test/data/config/version=4.1-alpha1.yml rename test/distributed/org/apache/cassandra/distributed/upgrade/{ConfigCompatabilityTestGenerate.java => ConfigCompatibilityTestGenerate.java} (87%) rename test/unit/org/apache/cassandra/config/{ConfigCompatabilityTest.java => ConfigCompatibilityTest.java} (95%) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18713: -- Fix Version/s: 4.1.4 5.0 (was: 5.x) (was: 4.1.x) Source Control Link: https://github.com/apache/cassandra/commit/b94436c7831c940592653c2c5d8e3af92d5cf266 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1.4, 5.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750427#comment-17750427 ] Ekaterina Dimitrova commented on CASSANDRA-18717: - Discussion thread started here - [https://lists.apache.org/thread/dsfvmwwtbzbwm0n65gggqgfk7fszljl7] > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18714) Expand CQLSSTableWriter to write SSTable-attached secondary indexes
[ https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18714: Description: {{CQLSSTableWriter}} currently has no way of writing any secondary indexes inline as it writes the core SSTable components. With SAI, this has become tractable problem, and we should be able to enhance both it and {{SSTableImporter}} to handle cases where we might want to write SSTables somewhere in bulk (and in parallel) and then import them without waiting for index building on import. It would require the following changes: 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current table schema definition. Once added to the schema, any {{ColumnFamilyStore}} instances opened will have those 2i defined in their index managers. 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups, allowing the proper {{SSTableFlushObservers}} to be attached to {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached indexes) components will be built incrementally along w/ the SSTable data file, and will be finalized when the newly written SSTable is finalized. 3.) Provide an example (in a unit test?) of how a third-party tool might, assuming access to the right C* JAR, validate/checksum SAI components outside C* proper. 4.) {{SSTableImporter}} should have two new options: a.) an option that fails import if any SSTable-attached 2i must be built (i.e. has not already been built and brought along w/ the other new SSTable components) b.) an option that allows us to bypass full checksum validation on imported/already-built SSTable-attached indexes (assuming they have just been written by {{CQLSSTableWriter}}) was: {{CQLSSTableWriter}} currently has no way of writing any secondary indexes inline as it writes the core SSTable components. With SAI, this has become tractable problem, and we should be able to enhance both it and {{SSTableImporter}} to handle cases where we might want to write SSTables somewhere in bulk (and in parallel) and then import them without waiting for index building on import. It would require the following changes: 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current table schema definition. Once added to the schema, any {{ColumnFamilyStore}} instances opened will have those 2i defined in their index managers. 2.) All {{AbstractSSTableSimpleWrite}}r instances must register index groups, allowing the proper {{SSTableFlushObservers}} to be attached to {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached indexes) components will be built incrementally along w/ the SSTable data file, and will be finalized when the newly written SSTable is finalized. 3.) Provide an example (in a unit test?) of how a third-party tool might, assuming access to the right C* JAR, validate/checksum SAI components outside C* proper. 4.) {{SSTableImporter}} should have two new options: a.) an option that fails import if any SSTable-attached 2i must be built (i.e. has not already been built and brought along w/ the other new SSTable components) b.) an option that allows us to bypass full checksum validation on imported/already-built SSTable-attached indexes (assuming they have just been written by {{CQLSSTableWriter}}) > Expand CQLSSTableWriter to write SSTable-attached secondary indexes > --- > > Key: CASSANDRA-18714 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18714 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SAI, Tool/bulk load >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > > {{CQLSSTableWriter}} currently has no way of writing any secondary indexes > inline as it writes the core SSTable components. With SAI, this has become > tractable problem, and we should be able to enhance both it and > {{SSTableImporter}} to handle cases where we might want to write SSTables > somewhere in bulk (and in parallel) and then import them without waiting for > index building on import. It would require the following changes: > 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current > table schema definition. Once added to the schema, any {{ColumnFamilyStore}} > instances opened will have those 2i defined in their index managers. > 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups, > allowing the proper {{SSTableFlushObservers}} to be attached to > {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached > indexes) components will be built incrementally along w/ the SSTable data > file, and will be finalized when the newly written SSTable is f
[cassandra] branch trunk updated: Ensure that SSTablesSystemViewTest compacts to a single SSTable in testVirtualTableThroughIndexLifeCycle even w/ UCS
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 5bdfd790b7 Ensure that SSTablesSystemViewTest compacts to a single SSTable in testVirtualTableThroughIndexLifeCycle even w/ UCS 5bdfd790b7 is described below commit 5bdfd790b7b8cc638a96efb5c34181ece35b04a1 Author: Caleb Rackliffe AuthorDate: Tue Aug 1 14:53:07 2023 -0500 Ensure that SSTablesSystemViewTest compacts to a single SSTable in testVirtualTableThroughIndexLifeCycle even w/ UCS patch by Caleb Rackliffe; reviewed by Mick Semb Wever for CASSANDRA-18703 --- .../apache/cassandra/index/sai/virtual/SSTablesSystemViewTest.java | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/unit/org/apache/cassandra/index/sai/virtual/SSTablesSystemViewTest.java b/test/unit/org/apache/cassandra/index/sai/virtual/SSTablesSystemViewTest.java index d0a481860f..2150d356a2 100644 --- a/test/unit/org/apache/cassandra/index/sai/virtual/SSTablesSystemViewTest.java +++ b/test/unit/org/apache/cassandra/index/sai/virtual/SSTablesSystemViewTest.java @@ -20,11 +20,14 @@ package org.apache.cassandra.index.sai.virtual; import java.util.Objects; import com.google.common.collect.ImmutableList; +import com.googlecode.concurrenttrees.common.Iterables; import org.junit.BeforeClass; import org.junit.Test; +import org.apache.cassandra.Util; import org.apache.cassandra.cql3.CQLTester; import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.lifecycle.SSTableSet; import org.apache.cassandra.db.virtual.VirtualKeyspace; import org.apache.cassandra.db.virtual.VirtualKeyspaceRegistry; import org.apache.cassandra.dht.AbstractBounds; @@ -122,8 +125,10 @@ public class SSTablesSystemViewTest extends SAITester assertRowsIgnoringOrder(execute(SELECT), row1, row2, row6, row3, row4, row5, row7); // compact the table and verify that the virtual table has a single entry per index -compact(); +ColumnFamilyStore cfs = getCurrentColumnFamilyStore(); +Util.compact(cfs, Iterables.toList(cfs.getSSTables(SSTableSet.LIVE))); waitForCompactions(); + SSTableId[] ids5 = currentIdsSorted(); // Compaction may result in sstables with generation 5 or 6. Try both. // key 4, key 6 are not indexable on v1 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18703) Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle
[ https://issues.apache.org/jira/browse/CASSANDRA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18703: Since Version: 5.0 Source Control Link: https://github.com/apache/cassandra/commit/5bdfd790b7b8cc638a96efb5c34181ece35b04a1 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as https://github.com/apache/cassandra/commit/5bdfd790b7b8cc638a96efb5c34181ece35b04a1 > Test failure: SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle > -- > > Key: CASSANDRA-18703 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18703 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The utest > {{org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest#testVirtualTableThroughIndexLifeCycle}} > is consistently broken with tries at least on trunk: > * > https://app.circleci.com/pipelines/github/adelapena/cassandra/3068/workflows/17760f03-9807-41cc-9cb3-a1fdf3e60f77/jobs/64069/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15684/tests > * > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/215/workflows/efcd6699-c1d2-48c0-99de-b35544106264/jobs/15692/tests > {code} > junit.framework.AssertionFailedError: Got 4 extra row(s) and 2 missing row(s) > in result. Extra rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=1, > min_row_id=0, max_row_id=0, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=4, > min_row_id=0, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=339) > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-6-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=3, > min_row_id=2, max_row_id=4, start_token=-8982230457741691068, > end_token=5293579765126103566, per_table_disk_size=610, > per_column_disk_size=310) > Missing Rows: > row(index_name=table_00_v1_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v1, format_version=aa, cell_count=4, > min_row_id=2, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=270) > row(index_name=table_00_v2_idx, > sstable_name=/tmp/cassandra/build/test/cassandra/data/cql_test_keyspace/table_00-12e640202d2a11eea926d15115276651/da-5-bti-Data.db, > table_name=table_00, column_name=v2, format_version=aa, cell_count=5, > min_row_id=0, max_row_id=5, start_token=8213365047359667313, > end_token=8213365047359667313, per_table_disk_size=335, > per_column_disk_size=274) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrderInternal(CQLTester.java:1900) > at > org.apache.cassandra.cql3.CQLTester.assertRowsIgnoringOrder(CQLTester.java:1834) > at > org.apache.cassandra.index.sai.virtual.SSTablesSystemViewTest.testVirtualTableThroughIndexLifeCycle(SSTablesSystemViewTest.java:133) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:3
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750431#comment-17750431 ] Maxim Muzafarov commented on CASSANDRA-18704: - Share the test results that contain the fix. j11_utests_cdc, j11_utests_cdc_repeat https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/279/workflows/3961f52c-9f76-46f7-8319-6001a8362263/jobs/19285 https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/279/workflows/3961f52c-9f76-46f7-8319-6001a8362263/jobs/19286 > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750434#comment-17750434 ] Ekaterina Dimitrova commented on CASSANDRA-18713: - I guess something happened on commit as rat is now complaining for me: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2456/workflows/1fd95cb4-be9e-4868-b936-7804d967cae2/jobs/34768] > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1.4, 5.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Ninja: exclude 4-1-alpha1.yml from rat
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new f283ede913 Ninja: exclude 4-1-alpha1.yml from rat f283ede913 is described below commit f283ede913a03d5cc24c1cadaad282be65339a2a Author: Brandon Williams AuthorDate: Wed Aug 2 13:12:34 2023 -0500 Ninja: exclude 4-1-alpha1.yml from rat --- .build/build-rat.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/.build/build-rat.xml b/.build/build-rat.xml index 601b4a0a54..786f49454f 100644 --- a/.build/build-rat.xml +++ b/.build/build-rat.xml @@ -78,6 +78,7 @@ + - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750443#comment-17750443 ] Brandon Williams commented on CASSANDRA-18713: -- I think I fixed it here: https://github.com/apache/cassandra/commit/f283ede913a03d5cc24c1cadaad282be65339a2a > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1.4, 5.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18721) Wildcard rat checks for files named by version
Brandon Williams created CASSANDRA-18721: Summary: Wildcard rat checks for files named by version Key: CASSANDRA-18721 URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 Project: Cassandra Issue Type: Improvement Reporter: Brandon Williams Instead of adding a rat exclude every time we add another file with the version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-18721: Assignee: Brandon Williams > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18721: - Change Category: Semantic Complexity: Low Hanging Fruit Component/s: Build Status: Open (was: Triage Needed) > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750448#comment-17750448 ] Brandon Williams commented on CASSANDRA-18721: -- Like this: https://github.com/driftx/cassandra/tree/CASSANDRA-18721-trunk > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18721: - Fix Version/s: 5.x > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18721: - Test and Documentation Plan: run 'ant check' Status: Patch Available (was: Open) > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miklosovic updated CASSANDRA-18713: --- Attachment: signature.asc Ah thank you. I was fixing this already but it got messed up again on merge. \ > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1.4, 5.0 > > Attachments: signature.asc > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750459#comment-17750459 ] Stefan Miklosovic commented on CASSANDRA-18721: --- Great idea! +1 already if the build is ok. > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18713) Fix / align ConfigCompatabilityTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750460#comment-17750460 ] Ekaterina Dimitrova commented on CASSANDRA-18713: - Thank you both! :) > Fix / align ConfigCompatabilityTest > --- > > Key: CASSANDRA-18713 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18713 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1.4, 5.0 > > Attachments: signature.asc > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Wildcard exclude versioned files in rat
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 15c2afe21d Wildcard exclude versioned files in rat 15c2afe21d is described below commit 15c2afe21dbab24754a164ca1126a5d3b13c9523 Author: Brandon Williams AuthorDate: Wed Aug 2 13:28:08 2023 -0500 Wildcard exclude versioned files in rat Patch by brandonwilliams; reviewed by smiklosovic for CASSANDRA-18721 --- .build/build-rat.xml | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.build/build-rat.xml b/.build/build-rat.xml index 786f49454f..755b76ea58 100644 --- a/.build/build-rat.xml +++ b/.build/build-rat.xml @@ -71,14 +71,8 @@ - - - - - - - - + + - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18721: - Reviewers: Stefan Miklosovic Status: Review In Progress (was: Patch Available) > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18721: - Fix Version/s: 5.0 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/15c2afe21dbab24754a164ca1126a5d3b13c9523 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed. > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18721) Wildcard rat checks for files named by version
[ https://issues.apache.org/jira/browse/CASSANDRA-18721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18721: - Status: Ready to Commit (was: Review In Progress) > Wildcard rat checks for files named by version > -- > > Key: CASSANDRA-18721 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18721 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Instead of adding a rat exclude every time we add another file with the > version in the name, we can use a wildcard. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[ https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18710: Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina Dimitrova) Status: Review In Progress (was: Patch Available) > Test failure: > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from > org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17) > -- > > Key: CASSANDRA-18710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18710 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Seen here: > [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/] > h3. > {code:java} > Error Message > expected:<7200.0> but was:<1367.83970468544> > Stacktrace > junit.framework.AssertionFailedError: expected:<7200.0> but > was:<1367.83970468544> at > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18707) Test failure: junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
[ https://issues.apache.org/jira/browse/CASSANDRA-18707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750463#comment-17750463 ] Ekaterina Dimitrova commented on CASSANDRA-18707: - Well, I guess we need to improve the test. Didn't we have similar issue with the Python DTests? What is weird about this test is that it shows me it was run only twice in Butler (when it failed) and it wasn't run otherwise? > Test failure: > junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11 > > > > Key: CASSANDRA-18707 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18707 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > Seen here: > [https://ci-cassandra.apache.org/job/Cassandra-trunk/1650/testReport/junit.framework/TestSuite/org_apache_cassandra_distributed_test_CASMultiDCTest__jdk11/] > h3. > {code:java} > Error Message > Schema agreement not reached. Schema versions of the instances: > [ef1c8e05-a06d-388d-a46d-53cc22a94762, 6c386108-1805-3985-b48e-8016012a0207, > 6c386108-1805-3985-b48e-8016012a0207, ef1c8e05-a06d-388d-a46d-53cc22a94762] > Stacktrace > java.lang.IllegalStateException: Schema agreement not reached. Schema > versions of the instances: [ef1c8e05-a06d-388d-a46d-53cc22a94762, > 6c386108-1805-3985-b48e-8016012a0207, 6c386108-1805-3985-b48e-8016012a0207, > ef1c8e05-a06d-388d-a46d-53cc22a94762] at > org.apache.cassandra.distributed.impl.AbstractCluster$ChangeMonitor.waitForCompletion(AbstractCluster.java:907) > at > org.apache.cassandra.distributed.impl.AbstractCluster.lambda$schemaChange$8(AbstractCluster.java:836) > at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at > org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at > org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:829) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750465#comment-17750465 ] Maxim Muzafarov commented on CASSANDRA-18704: - [~e.dimitrova] Can you take a look? > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[ https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18710: Status: Ready to Commit (was: Review In Progress) > Test failure: > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from > org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17) > -- > > Key: CASSANDRA-18710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18710 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Seen here: > [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/] > h3. > {code:java} > Error Message > expected:<7200.0> but was:<1367.83970468544> > Stacktrace > junit.framework.AssertionFailedError: expected:<7200.0> but > was:<1367.83970468544> at > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[ https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750466#comment-17750466 ] Ekaterina Dimitrova commented on CASSANDRA-18710: - I am not able to reproduce the issue in CircleCI even before the patch. [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18710-trunk] But it seems reasonable to me. Also, I can see how timing in Jenkins could influence it to fail that way. I think the flush was just forgotten, +1 > Test failure: > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from > org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17) > -- > > Key: CASSANDRA-18710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18710 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Seen here: > [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/] > h3. > {code:java} > Error Message > expected:<7200.0> but was:<1367.83970468544> > Stacktrace > junit.framework.AssertionFailedError: expected:<7200.0> but > was:<1367.83970468544> at > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[ https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750466#comment-17750466 ] Ekaterina Dimitrova edited comment on CASSANDRA-18710 at 8/2/23 8:11 PM: - I am not able to reproduce the issue in CircleCI even before the patch. [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18710-trunk] But it seems reasonable to me. Also, I can see how timing in Jenkins could influence it to fail that way. I think the flush was just forgotten when the test was written, +1 was (Author: e.dimitrova): I am not able to reproduce the issue in CircleCI even before the patch. [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18710-trunk] But it seems reasonable to me. Also, I can see how timing in Jenkins could influence it to fail that way. I think the flush was just forgotten, +1 > Test failure: > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from > org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17) > -- > > Key: CASSANDRA-18710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18710 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Seen here: > [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/] > h3. > {code:java} > Error Message > expected:<7200.0> but was:<1367.83970468544> > Stacktrace > junit.framework.AssertionFailedError: expected:<7200.0> but > was:<1367.83970468544> at > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Force flush during testFlushSize
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 3ed723b870 Force flush during testFlushSize 3ed723b870 is described below commit 3ed723b8700c47026849d11fe599d4e7b48ff65e Author: Brandon Williams AuthorDate: Tue Aug 1 09:52:37 2023 -0500 Force flush during testFlushSize Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-18710 --- test/unit/org/apache/cassandra/io/DiskSpaceMetricsTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/org/apache/cassandra/io/DiskSpaceMetricsTest.java b/test/unit/org/apache/cassandra/io/DiskSpaceMetricsTest.java index 3f65d8c485..e2f49e9696 100644 --- a/test/unit/org/apache/cassandra/io/DiskSpaceMetricsTest.java +++ b/test/unit/org/apache/cassandra/io/DiskSpaceMetricsTest.java @@ -109,6 +109,7 @@ public class DiskSpaceMetricsTest extends CQLTester for (int i = 0; i < 3; i++) insertN(KEYSPACE_PER_TEST, cfs, 1000, 55); +cfs.forceBlockingFlush(ColumnFamilyStore.FlushReason.UNIT_TESTS); int totalSize = 0; final Set liveSSTables = cfs.getLiveSSTables(); for (SSTableReader rdr : liveSSTables) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750467#comment-17750467 ] Ekaterina Dimitrova commented on CASSANDRA-18704: - Yes, I will take a look tomorrow. Also, we will need 4.0 and 4.1, but I guess you wanted to confirm first one branch and the others were similar? > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750467#comment-17750467 ] Ekaterina Dimitrova edited comment on CASSANDRA-18704 at 8/2/23 8:14 PM: - Yes, I will take a look tomorrow. Also, I guess as [~mck] that we need 4.0 and 4.1, but I guess you wanted to confirm first one branch and the others were similar? was (Author: e.dimitrova): Yes, I will take a look tomorrow. Also, we will need 4.0 and 4.1, but I guess you wanted to confirm first one branch and the others were similar? > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[ https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18710: - Fix Version/s: 5.0 (was: 5.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra/commit/3ed723b8700c47026849d11fe599d4e7b48ff65e Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed. > Test failure: > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from > org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17) > -- > > Key: CASSANDRA-18710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18710 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > > Seen here: > [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/] > h3. > {code:java} > Error Message > expected:<7200.0> but was:<1367.83970468544> > Stacktrace > junit.framework.AssertionFailedError: expected:<7200.0> but > was:<1367.83970468544> at > org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750470#comment-17750470 ] Maxim Muzafarov commented on CASSANDRA-18704: - [~e.dimitrova], [~mck] The failed tests have been added here: https://issues.apache.org/jira/browse/CASSANDRA-17923, which is only relevant for the 5.0 branch. So, there is no need to cherry-pick the fix. > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750470#comment-17750470 ] Maxim Muzafarov edited comment on CASSANDRA-18704 at 8/2/23 8:20 PM: - [~e.dimitrova], [~mck] The failing tests were added here: https://issues.apache.org/jira/browse/CASSANDRA-17923, which is only relevant for the 5.0 branch. So, there is no need to cherry-pick the fix. was (Author: mmuzaf): [~e.dimitrova], [~mck] The failed tests have been added here: https://issues.apache.org/jira/browse/CASSANDRA-17923, which is only relevant for the 5.0 branch. So, there is no need to cherry-pick the fix. > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750472#comment-17750472 ] Ekaterina Dimitrova commented on CASSANDRA-18704: - Oh great! Then maybe [~jonmeredith] or [~yifanc] also want to take a look at it? > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750475#comment-17750475 ] Jon Meredith commented on CASSANDRA-18704: -- Sure, I can take a look. > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750476#comment-17750476 ] Timothy Tu commented on CASSANDRA-18529: [~brandon.williams] sorry about that, I was not compiling the right things on my end. Should work now. > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18585) Alter Type does not validate changes like Create Type does
[ https://issues.apache.org/jira/browse/CASSANDRA-18585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18585: -- Reviewers: Stefan Miklosovic, Stefan Miklosovic Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic) Status: Review In Progress (was: Patch Available) > Alter Type does not validate changes like Create Type does > -- > > Key: CASSANDRA-18585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18585 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: David Capwell >Assignee: Roman Mushchinski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Create Type attempts to block undesired field types, but this validation is > not cared over to Alter Type Add Field; which allows you to add > unexpected/desired types > {code} > Assertions.assertThatThrownBy(() -> createType("CREATE TYPE %s (f > counter)")).hasRootCauseMessage("A user type cannot contain counters"); > String type = createType(KEYSPACE, "CREATE TYPE %s (a int)"); > schemaChange(String.format("ALTER TYPE %s.%s ADD f counter", KEYSPACE, type)); > UserType udt = > Keyspace.open(KEYSPACE).getMetadata().types.get(UTF8Type.instance.decompose(type)).get(); > logger.warn("UDT: {}", udt); > {code} > {code} > UDT: > org.apache.cassandra.db.marshal.UserType(cql_test_keyspace,747970655f3031,61:org.apache.cassandra.db.marshal.Int32Type,66:org.apache.cassandra.db.marshal.CounterColumnType) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18704) Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades ClassCastException: Established -> Disconnected
[ https://issues.apache.org/jira/browse/CASSANDRA-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750479#comment-17750479 ] Jon Meredith commented on CASSANDRA-18704: -- +1 from me, thanks for fixing it. > Test Failure: HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades > ClassCastException: Established -> Disconnected > -- > > Key: CASSANDRA-18704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18704 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The following has been witnesses a number of times in repeated runs, in > different jdks and different test configurations. > {noformat} > java.lang.ClassCastException: class > org.apache.cassandra.net.OutboundConnection$Established cannot be cast to > class org.apache.cassandra.net.OutboundConnection$Disconnected > (org.apache.cassandra.net.OutboundConnection$Established and > org.apache.cassandra.net.OutboundConnection$Disconnected are in unnamed > module of loader 'app') > at > org.apache.cassandra.net.OutboundConnection$State.disconnected(OutboundConnection.java:201) > at > org.apache.cassandra.net.OutboundConnection$1Initiate.initiate(OutboundConnection.java:1248) > at > org.apache.cassandra.net.OutboundConnection.initiate(OutboundConnection.java:1254) > at > org.apache.cassandra.net.HandshakeTest.initiateOutbound(HandshakeTest.java:365) > at > org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:380) > at > org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:255) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {noformat} > ref: > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17534) CQLSH help topic links are broken between textile and online files
[ https://issues.apache.org/jira/browse/CASSANDRA-17534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750480#comment-17750480 ] Stefan Miklosovic commented on CASSANDRA-17534: --- I am sorry for the delay, I am going to look soon. > CQLSH help topic links are broken between textile and online files > -- > > Key: CASSANDRA-17534 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17534 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > CQLSH help topics opens a generic CQL page, not the specific topic. This > happens when docs are not installed locally, and it tries to open the online > version. > The file cqlsh.py has: > {{ # default location of local CQL.html}} > {{ if os.path.exists(CASSANDRA_PATH + '/doc/cql3/CQL.html'):}} > {{ }} > {{ else:}} > {{ # fallback to online version}} > {{ CASSANDRA_CQL_HTML = CASSANDRA_CQL_HTML_FALLBACK}} > For example, > {{cqlsh> help truncate;}} > opens the page: > [https://cassandra.apache.org/doc/latest/cassandra/cql/index.html#truncateStmt] > but there is no information about 'truncate' on that page and the anchor > #truncateStmt doesn't exist. > the correct page anchor is: > [https://cassandra.apache.org/doc/latest/cassandra/cql/ddl.html#truncate-statement] > The local file anchors appear they may be incorrect as well: > [https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#truncate] > To reproduce this, 'pip install cqlsh' on a machine without a Cassandra > package install. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (902b45db -> 73fc9714)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 902b45db generate docs for f02aa10d new 73fc9714 generate docs for f02aa10d This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (902b45db) \ N -- N -- N refs/heads/asf-staging (73fc9714) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (73fc9714 -> a7fd9be9)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 73fc9714 generate docs for f02aa10d new a7fd9be9 generate docs for f02aa10d This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (73fc9714) \ N -- N -- N refs/heads/asf-staging (a7fd9be9) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (a7fd9be9 -> ab80fdbb)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard a7fd9be9 generate docs for f02aa10d new ab80fdbb generate docs for f02aa10d This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a7fd9be9) \ N -- N -- N refs/heads/asf-staging (ab80fdbb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/doc/4.2/cassandra/tools/nodetool/join.html | 3 ++- .../doc/trunk/cassandra/tools/nodetool/join.html | 3 ++- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4852435 -> 4852435 bytes 4 files changed, 5 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org