[cassandra-website] branch asf-staging updated (ee5aa52b -> bf2ac307)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard ee5aa52b generate docs for ce048d19 new bf2ac307 generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ee5aa52b) \ N -- N -- N refs/heads/asf-staging (bf2ac307) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (4363ada1 -> ee5aa52b)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 4363ada1 generate docs for ce048d19 new ee5aa52b generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4363ada1) \ N -- N -- N refs/heads/asf-staging (ee5aa52b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-68) Add Metrics publisher interface to Sidecar to expose metrics for capture
[ https://issues.apache.org/jira/browse/CASSANDRASC-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-68: - Reviewers: Francisco Guerrero, Yifan Cai (was: Yifan Cai) Status: Review In Progress (was: Patch Available) > Add Metrics publisher interface to Sidecar to expose metrics for capture > > > Key: CASSANDRASC-68 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-68 > Project: Sidecar for Apache Cassandra > Issue Type: New Feature > Components: Rest API >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: High > > We need metrics publisher interface in Sidecar to capture some of the metrics > like bytes written/streamed. > PR: [https://github.com/apache/cassandra-sidecar/pull/64] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-68) Add Metrics publisher interface to Sidecar to expose metrics for capture
[ https://issues.apache.org/jira/browse/CASSANDRASC-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758773#comment-17758773 ] Yifan Cai commented on CASSANDRASC-68: -- +1 on the patch. Please post the CI link. > Add Metrics publisher interface to Sidecar to expose metrics for capture > > > Key: CASSANDRASC-68 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-68 > Project: Sidecar for Apache Cassandra > Issue Type: New Feature > Components: Rest API >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: High > > We need metrics publisher interface in Sidecar to capture some of the metrics > like bytes written/streamed. > PR: [https://github.com/apache/cassandra-sidecar/pull/64] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18572) Instance.nodetoolResult should connect to JMX if there is such feature enabled in its config
[ https://issues.apache.org/jira/browse/CASSANDRA-18572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18572: -- Fix Version/s: (was: 3.11.x) (was: 4.0.x) (was: 4.1.x) > Instance.nodetoolResult should connect to JMX if there is such feature > enabled in its config > > > Key: CASSANDRA-18572 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18572 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Attachments: fix-jmx-issue-on-shutdown.patch > > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18725) IsolatedJMX should not release all TCPEndpoints on instance shutdown
[ https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith updated CASSANDRA-18725: - Fix Version/s: 3.11.17 4.0.12 4.1.4 5.0-alpha (was: 3.11.x) (was: 4.0.x) (was: 4.1.x) (was: 5.0.x) Source Control Link: https://github.com/apache/cassandra/commit/c6d7d070c59d81db8949683d3e5670b909efb48c Resolution: Fixed Status: Resolved (was: Ready to Commit) > IsolatedJMX should not release all TCPEndpoints on instance shutdown > > > Key: CASSANDRA-18725 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18725 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 3.11.17, 4.0.12, 4.1.4, 5.0-alpha, 5.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > In the original implementation of the JMX feature, we fixed some memory leaks > by clearing some internal state in Java’s TCPEndpoint. However, that > implementation was overly aggressive and cleared the whole map, vs. just > removing the endpoints created by the individual instances. This causes > issues when you remove a node from the cluster (as all of the endpoints are > cleared, not just the ones in use by that instance). > > In stead, we should check if the endpoint was created by the instance in > question and only remove it if it was. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18725) IsolatedJMX should not release all TCPEndpoints on instance shutdown
[
https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758767#comment-17758767
]
Jon Meredith commented on CASSANDRA-18725:
--
Reviewing test failures, I don't think any are due to the changes as it should
only affect in-jvm tests and those failures are pre-existing.
{{code}}
*3.11*
j8_jvm_dtests
testReprepareMixedVersionWithoutReset - hashcollision
j8_jvm_upgrade_dtests
testDropCompactWithClusteringAndValueColumn - cannot achieve consistency
testDropCompactWithClusteringAndValueColumnWithDeletesAndWrites - unavailable
exception
org.apache.cassandra.distributed.upgrade.MixedModeReadTest - unavailable
exception
*4.0*
j11_dtest
test_move_backwards_between_and_cleanup - startup timeout
j11_jvm_dtests
org.apache.cassandra.distributed.test.FailingRepairTest:testFailingMessage -
test timeout
j11_unit_tests
testPagingWithClustering
j8_jvm_dtests
timeout in org.apache.cassandra.distributed.test.FailingRepairTest
j8_jvm_upgrade_dtests
org.apache.cassandra.distributed.upgrade.MixedModeReadTest -- cannot achieve
consistency
*4.1*
j11_dtests
ttl_test.py::TestTTL::test_insert_ttl_has_priority_on_defaut_ttl
j8_jvm_upgrade_dtests
org.apache.cassandra.distributed.upgrade.MixedModeReadTest -- cannot achieve
consistency
j8_upgrade_dtests
TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD.test_parallel_upgrade_with_internode_ssl
j8_upgrade_dtests
TestUpgrade_indev_4_1_x_To_indev_trunk.test_bootstrap_multidc
*5.0*
j11_dtests_vnode
TestSecondaryIndexes.test_failing_manual_rebuild_index
*trunk*
org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV30AllOneTest
-- failing before commit
{{code}}
> IsolatedJMX should not release all TCPEndpoints on instance shutdown
>
>
> Key: CASSANDRA-18725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18725
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In the original implementation of the JMX feature, we fixed some memory leaks
> by clearing some internal state in Java’s TCPEndpoint. However, that
> implementation was overly aggressive and cleared the whole map, vs. just
> removing the endpoints created by the individual instances. This causes
> issues when you remove a node from the cluster (as all of the endpoints are
> cleared, not just the ones in use by that instance).
>
> In stead, we should check if the endpoint was created by the instance in
> question and only remove it if it was.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 6fb82b75d5e5f04af1a0bb2f73320c86db56829d
Merge: cbaef9094e d2f8e8e105
Author: Jon Meredith
AuthorDate: Thu Aug 24 16:44:58 2023 -0600
Merge branch 'cassandra-5.0' into trunk
.build/parent-pom-template.xml | 2 +-
build.xml | 1 +
.../utils/RMIClientSocketFactoryImpl.java | 22 +-
.../apache/cassandra/utils/ReflectionUtils.java| 44 ++-
.../cassandra/distributed/impl/Instance.java | 5 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 88 ++
.../cassandra/distributed/shared/ClusterUtils.java | 34 +++--
.../distributed/test/ResourceLeakTest.java | 54 +++--
.../distributed/test/jmx/JMXFeatureTest.java | 85 ++---
.../distributed/test/jmx/JMXGetterCheckTest.java | 46 ---
.../commitlog/CommitLogSegmentManagerCDCTest.java | 2 +-
11 files changed, 261 insertions(+), 122 deletions(-)
diff --cc src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
index 62ab88fb92,5caa92cce4..81e728eeb9
--- a/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
+++ b/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
@@@ -42,7 -45,23 +45,24 @@@ public class RMIClientSocketFactoryImp
@Override
public Socket createSocket(String host, int port) throws IOException
{
- return new Socket(localAddress, port);
+ Socket socket = new Socket(localAddress, port);
+ sockets.add(socket);
+ return socket;
+ }
+
+ public void close() throws IOException
+ {
-for (Socket socket: sockets) {
++for (Socket socket: sockets)
++{
+ try
+ {
+ socket.close();
+ }
+ catch (IOException ignored)
+ {
+ // intentionally ignored
+ }
+ }
}
@Override
diff --cc
test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java
index e19e29fdb3,dd53ba4829..7812ec89f8
--- a/test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java
+++ b/test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java
@@@ -32,10 -31,12 +31,12 @@@ import javax.management.remote.JMXServi
import javax.management.remote.rmi.RMIConnectorServer;
import javax.management.remote.rmi.RMIJRMPServerImpl;
++import com.google.common.util.concurrent.Uninterruptibles;
import org.slf4j.Logger;
-import com.google.common.util.concurrent.Uninterruptibles;
import org.apache.cassandra.distributed.api.IInstance;
import org.apache.cassandra.distributed.api.IInstanceConfig;
+ import org.apache.cassandra.distributed.shared.JMXUtil;
import org.apache.cassandra.utils.JMXServerUtils;
import org.apache.cassandra.utils.MBeanWrapper;
import org.apache.cassandra.utils.RMIClientSocketFactoryImpl;
@@@ -135,36 -137,20 +137,21 @@@ public class IsolatedJm
}
}
- private void waitForJmxAvailability(String hostname, int rmiPort,
Map env) throws InterruptedException, MalformedURLException
+ private void waitForJmxAvailability(Map env)
{
- String url =
String.format("service:jmx:rmi:///jndi/rmi://%s:%d/jmxrmi", hostname, rmiPort);
- JMXServiceURL serviceURL = new JMXServiceURL(url);
- int attempts = 0;
- Throwable lastThrown = null;
- while (attempts < 20)
-try (JMXConnector ignored = JMXUtil.getJmxConnector(config, 20, env))
{
++try (JMXConnector ignored = JMXUtil.getJmxConnector(config, 20, env))
+{
- attempts++;
- try (JMXConnector ignored =
JMXConnectorFactory.connect(serviceURL, env))
- {
- inInstancelogger.info("Connected to JMX server at {} after {}
attempt(s)",
- url, attempts);
- return;
- }
- catch (MalformedURLException e)
- {
- throw new RuntimeException(e);
- }
- catch (Throwable thrown)
- {
- lastThrown = thrown;
- }
- inInstancelogger.info("Could not connect to JMX on {} after {}
attempts. Will retry.", url, attempts);
- Thread.sleep(1000);
+ // Do nothing - JMXUtil now retries
+ }
+ catch (IOException iex)
+ {
+ // If we land here, there's something more than a timeout
+ inInstancelogger.error(UNKNOWN_JMX_CONNECTION_ERROR, iex);
+ throw new RuntimeException(UNKNOWN_JMX_CONNECTION_ERROR, iex);
}
- throw new RuntimeException("Could not start JMX - unreachable after
20 attempts", lastThrown);
}
-
[cassandra] 01/01: Merge branch 'cassandra-4.1' into cassandra-5.0
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a commit to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d2f8e8e10546a229d7280e3bf70780ccdbcb7320 Merge: 410018ab16 ac3b356063 Author: Jon Meredith AuthorDate: Thu Aug 24 16:44:04 2023 -0600 Merge branch 'cassandra-4.1' into cassandra-5.0 .build/parent-pom-template.xml | 2 +- build.xml | 1 + .../utils/RMIClientSocketFactoryImpl.java | 21 +- .../apache/cassandra/utils/ReflectionUtils.java| 44 ++- .../cassandra/distributed/impl/Instance.java | 5 +- .../cassandra/distributed/impl/IsolatedJmx.java| 87 +- .../cassandra/distributed/shared/ClusterUtils.java | 34 +++-- .../distributed/test/ResourceLeakTest.java | 54 -- .../distributed/test/jmx/JMXFeatureTest.java | 85 ++--- .../distributed/test/jmx/JMXGetterCheckTest.java | 46 +--- .../commitlog/CommitLogSegmentManagerCDCTest.java | 2 +- 11 files changed, 259 insertions(+), 122 deletions(-) diff --cc .build/parent-pom-template.xml index 7d80e5160d,00..ba1e2bb5a9 mode 100644,00..100644 --- a/.build/parent-pom-template.xml +++ b/.build/parent-pom-template.xml @@@ -1,1209 -1,0 +1,1209 @@@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; xmlns="http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;> + 4.0.0 + +apache +org.apache +22 + + org.apache.cassandra + cassandra-parent + @version@ + pom + Apache Cassandra + The Apache Cassandra Project develops a highly scalable second-generation distributed database, bringing together Dynamo's fully distributed design and Bigtable's ColumnFamily-based data model. + https://cassandra.apache.org + 2009 + + + The Apache Software License, Version 2.0 + https://www.apache.org/licenses/LICENSE-2.0.txt + + + +1.12.13 +4.0.20 +0.5.1 + + +@asm.version@ +@jamm.version@ + @allocation-instrumenter.version@ +@ecj.version@ +@jacoco.version@ +@jflex.version@ + + + + adelapena + Andres de la Peña + + + alakshman + Avinash Lakshman + + + aleksey + Aleksey Yeschenko + + + amorton + Aaron Morton + + + aweisberg + Ariel Weisberg + + + bdeggleston + Blake Eggleston + + + benedict + Benedict Elliott Smith + + + benjamin + Benjamin Lerer + + + blambov + Branimir Lambov + + + brandonwilliams + Brandon Williams + + + carl + Carl Yeksigian + + + dbrosius + David Brosiusd + + + dikang + Dikang Gu + + + eevans + Eric Evans + + + edimitrova + Ekaterina Dimitrova + + + gdusbabek + Gary Dusbabek + + + goffinet + Chris Goffinet + + + ifesdjeen + Alex Petrov + + + jaakko + Laine Jaakko Olavi + + + jake + T Jake Luciani + + + jasonbrown + Jason Brown + + + jbellis + Jonathan Ellis + + + jfarrell + Jake Farrell + + + jjirsa + Jeff Jirsa + + + jkni + Joel Knighton + + + jmckenzie + Josh McKenzie + + + johan + Johan Oskarsson + + + junrao + Jun Rao + + + jzhuang + Jay Zhuang + + + kohlisankalp + Sankalp Kohli + + + marcuse + Marcus Eriksson + + + mck + Michael Semb Wever + + + mishail + Mikhail Stepura + + + mshuler + Michael Shuler + + + paulo + Paulo Motta + + + pmalik + Prashant Malik + + + rstupp + Robert Stupp + + + scode + Peter Schuller + + + beobal + Sam Tunnicliffe + + + slebresne + Sylvain Lebresne + + + stefania + Stefania Alborghetti + + + tylerhobbs + Tyler Hobbs + + + vijay + Vijay Parthasarathy + + + xedin + Pavel Yaskevich + + + yukim + Yuki Morishita + + + zznate + Nate McCall + + + smiklosovic + Stefan Miklosovic + + + + scm:https://gitbox.apache.org/repos/asf/cassandra.git + scm:https://gitbox.apache.org/repos/asf/cassandra.git +
[cassandra] branch cassandra-5.0 updated (410018ab16 -> d2f8e8e105)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 410018ab16 Fix spelling errors in the documentation for DDM new c6d7d070c5 IsolatedJMX should not release all TCPEndpoints on instance shutdown new 4034fbb6dd Merge branch 'cassandra-3.11' into cassandra-4.0 new ac3b356063 Merge branch 'cassandra-4.0' into cassandra-4.1 new d2f8e8e105 Merge branch 'cassandra-4.1' into cassandra-5.0 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/parent-pom-template.xml | 2 +- build.xml | 1 + .../utils/RMIClientSocketFactoryImpl.java | 21 +- .../apache/cassandra/utils/ReflectionUtils.java| 44 ++- .../cassandra/distributed/impl/Instance.java | 5 +- .../cassandra/distributed/impl/IsolatedJmx.java| 87 +- .../cassandra/distributed/shared/ClusterUtils.java | 34 +++-- .../distributed/test/ResourceLeakTest.java | 54 -- .../distributed/test/jmx/JMXFeatureTest.java | 85 ++--- .../distributed/test/jmx/JMXGetterCheckTest.java | 46 +--- .../commitlog/CommitLogSegmentManagerCDCTest.java | 2 +- 11 files changed, 259 insertions(+), 122 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated: IsolatedJMX should not release all TCPEndpoints on instance shutdown
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.11 by this push:
new c6d7d070c5 IsolatedJMX should not release all TCPEndpoints on instance
shutdown
c6d7d070c5 is described below
commit c6d7d070c59d81db8949683d3e5670b909efb48c
Author: Doug Rohrer
AuthorDate: Wed Aug 23 18:03:30 2023 -0600
IsolatedJMX should not release all TCPEndpoints on instance shutdown
patch by Doug Rohrer; reviewed by Jon Meredith, Stefan Miklosovic for
CASSANDRA-18725
---
build.xml | 2 +-
.../utils/RMIClientSocketFactoryImpl.java | 23 ++-
.../apache/cassandra/utils/ReflectionUtils.java| 101 +
.../cassandra/distributed/impl/Instance.java | 5 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 95 -
.../cassandra/distributed/shared/ClusterUtils.java | 226 +
.../distributed/shared/WithProperties.java | 112 ++
.../distributed/test/ResourceLeakTest.java | 54 ++---
.../distributed/test/jmx/JMXFeatureTest.java | 57 +-
.../distributed/test/jmx/JMXGetterCheckTest.java | 48 +++--
10 files changed, 627 insertions(+), 96 deletions(-)
diff --git a/build.xml b/build.xml
index c634761566..70a195f98d 100644
--- a/build.xml
+++ b/build.xml
@@ -383,7 +383,7 @@
-
+
diff --git
a/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
b/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
index 62ab88fb92..c04e934fdc 100644
--- a/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
+++ b/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
@@ -21,8 +21,11 @@ package org.apache.cassandra.utils;
import java.io.IOException;
import java.io.Serializable;
import java.net.InetAddress;
+import java.net.ServerSocket;
import java.net.Socket;
import java.rmi.server.RMIClientSocketFactory;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Objects;
/**
@@ -32,6 +35,7 @@ import java.util.Objects;
*/
public class RMIClientSocketFactoryImpl implements RMIClientSocketFactory,
Serializable
{
+List sockets = new ArrayList<>();
private final InetAddress localAddress;
public RMIClientSocketFactoryImpl(InetAddress localAddress)
@@ -42,7 +46,24 @@ public class RMIClientSocketFactoryImpl implements
RMIClientSocketFactory, Seria
@Override
public Socket createSocket(String host, int port) throws IOException
{
-return new Socket(localAddress, port);
+Socket socket = new Socket(localAddress, port);
+sockets.add(socket);
+return socket;
+}
+
+public void close() throws IOException
+{
+for (Socket socket: sockets)
+{
+try
+{
+socket.close();
+}
+catch (IOException ignored)
+{
+// intentionally ignored
+}
+}
}
@Override
diff --git a/src/java/org/apache/cassandra/utils/ReflectionUtils.java
b/src/java/org/apache/cassandra/utils/ReflectionUtils.java
new file mode 100644
index 00..3d1cc29565
--- /dev/null
+++ b/src/java/org/apache/cassandra/utils/ReflectionUtils.java
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.utils;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.function.Predicate;
+
+public class ReflectionUtils
+{
+public static Field getField(Class clazz, String fieldName) throws
NoSuchFieldException
+{
+// below code works before Java 12
+try
+{
+return clazz.getDeclaredField(fieldName);
+}
+catch (NoSuchFieldException e)
+{
+// this is mitigation for JDK 17
(https://bugs.openjdk.org/browse/JDK-8210522)
+try
+
[cassandra] branch cassandra-4.1 updated (8666265521 -> ac3b356063)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 8666265521 Merge branch 'cassandra-4.0' into cassandra-4.1 new c6d7d070c5 IsolatedJMX should not release all TCPEndpoints on instance shutdown new 4034fbb6dd Merge branch 'cassandra-3.11' into cassandra-4.0 new ac3b356063 Merge branch 'cassandra-4.0' into cassandra-4.1 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 5 +- .../utils/RMIClientSocketFactoryImpl.java | 21 +- .../apache/cassandra/utils/ReflectionUtils.java| 43 +++ .../cassandra/distributed/impl/Instance.java | 5 +- .../cassandra/distributed/impl/IsolatedJmx.java| 87 +- .../cassandra/distributed/shared/ClusterUtils.java | 34 +++-- .../distributed/test/ResourceLeakTest.java | 52 +++-- .../distributed/test/jmx/JMXFeatureTest.java | 86 ++--- .../distributed/test/jmx/JMXGetterCheckTest.java | 46 +--- 9 files changed, 259 insertions(+), 120 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit ac3b356063d38833214608c873f25ad0a27ea16e
Merge: 8666265521 4034fbb6dd
Author: Jon Meredith
AuthorDate: Thu Aug 24 16:38:53 2023 -0600
Merge branch 'cassandra-4.0' into cassandra-4.1
build.xml | 5 +-
.../utils/RMIClientSocketFactoryImpl.java | 21 +-
.../apache/cassandra/utils/ReflectionUtils.java| 43 +++
.../cassandra/distributed/impl/Instance.java | 5 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 87 +-
.../cassandra/distributed/shared/ClusterUtils.java | 34 +++--
.../distributed/test/ResourceLeakTest.java | 52 +++--
.../distributed/test/jmx/JMXFeatureTest.java | 86 ++---
.../distributed/test/jmx/JMXGetterCheckTest.java | 46 +---
9 files changed, 259 insertions(+), 120 deletions(-)
diff --cc build.xml
index 3593d4bd70,5812360e27..8d9b8f5516
--- a/build.xml
+++ b/build.xml
@@@ -153,8 -146,6 +153,8 @@@
-
++
+
diff --cc src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
index 62ab88fb92,81e728eeb9..5caa92cce4
--- a/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
+++ b/src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
@@@ -42,7 -45,24 +45,23 @@@ public class RMIClientSocketFactoryImp
@Override
public Socket createSocket(String host, int port) throws IOException
{
- return new Socket(localAddress, port);
+ Socket socket = new Socket(localAddress, port);
+ sockets.add(socket);
+ return socket;
+ }
+
+ public void close() throws IOException
+ {
-for (Socket socket: sockets)
-{
++for (Socket socket: sockets) {
+ try
+ {
+ socket.close();
+ }
+ catch (IOException ignored)
+ {
+ // intentionally ignored
+ }
+ }
}
@Override
diff --cc src/java/org/apache/cassandra/utils/ReflectionUtils.java
index bd605db3bc,e2280e66b0..07802267f1
--- a/src/java/org/apache/cassandra/utils/ReflectionUtils.java
+++ b/src/java/org/apache/cassandra/utils/ReflectionUtils.java
@@@ -20,8 -20,12 +20,11 @@@ package org.apache.cassandra.utils
import java.lang.reflect.Field;
import java.lang.reflect.Method;
+ import java.util.Iterator;
+ import java.util.Map;
+ import java.util.function.Predicate;
-public class ReflectionUtils
-{
+public class ReflectionUtils {
public static Field getField(Class clazz, String fieldName) throws
NoSuchFieldException
{
// below code works before Java 12
diff --cc test/distributed/org/apache/cassandra/distributed/impl/Instance.java
index 9975aeb9eb,39f5e980af..4b4276774b
--- a/test/distributed/org/apache/cassandra/distributed/impl/Instance.java
+++ b/test/distributed/org/apache/cassandra/distributed/impl/Instance.java
@@@ -755,9 -641,9 +755,9 @@@ public class Instance extends IsolatedE
initialized = true;
}
- private void startJmx()
+ private synchronized void startJmx()
{
-isolatedJmx = new IsolatedJmx(this, inInstancelogger);
+this.isolatedJmx = new IsolatedJmx(this, inInstancelogger);
isolatedJmx.startJmx();
}
diff --cc
test/distributed/org/apache/cassandra/distributed/test/ResourceLeakTest.java
index 794873feea,f318a1b0e0..7e4581c99c
---
a/test/distributed/org/apache/cassandra/distributed/test/ResourceLeakTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/ResourceLeakTest.java
@@@ -47,7 -48,7 +47,8 @@@ import static org.apache.cassandra.dist
import static org.apache.cassandra.distributed.api.Feature.JMX;
import static org.apache.cassandra.distributed.api.Feature.NATIVE_PROTOCOL;
import static org.apache.cassandra.distributed.api.Feature.NETWORK;
+ import static
org.apache.cassandra.distributed.test.jmx.JMXGetterCheckTest.testAllValidGetters;
+import static org.apache.cassandra.utils.FBUtilities.now;
import static org.hamcrest.Matchers.startsWith;
/* Resource Leak Test - useful when tracking down issues with in-JVM
framework cleanup.
diff --cc
test/distributed/org/apache/cassandra/distributed/test/jmx/JMXFeatureTest.java
index 83a35e594d,ea1efa8902..a1576d6e36
---
a/test/distributed/org/apache/cassandra/distributed/test/jmx/JMXFeatureTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/jmx/JMXFeatureTest.java
@@@ -18,9 -18,8 +18,9 @@@
package org.apache.cassandra.distributed.test.jmx;
- import java.io.IOException;
import java.util.HashSet;
import java.util.Set;
++
import javax.management.MBeanServerConnection;
import javax.management.remote.JMXConnector;
[cassandra] branch trunk updated (cbaef9094e -> 6fb82b75d5)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from cbaef9094e Merge branch 'cassandra-5.0' into trunk new c6d7d070c5 IsolatedJMX should not release all TCPEndpoints on instance shutdown new 4034fbb6dd Merge branch 'cassandra-3.11' into cassandra-4.0 new ac3b356063 Merge branch 'cassandra-4.0' into cassandra-4.1 new d2f8e8e105 Merge branch 'cassandra-4.1' into cassandra-5.0 new 6fb82b75d5 Merge branch 'cassandra-5.0' into trunk The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/parent-pom-template.xml | 2 +- build.xml | 1 + .../utils/RMIClientSocketFactoryImpl.java | 22 +- .../apache/cassandra/utils/ReflectionUtils.java| 44 ++- .../cassandra/distributed/impl/Instance.java | 5 +- .../cassandra/distributed/impl/IsolatedJmx.java| 88 ++ .../cassandra/distributed/shared/ClusterUtils.java | 34 +++-- .../distributed/test/ResourceLeakTest.java | 54 +++-- .../distributed/test/jmx/JMXFeatureTest.java | 85 ++--- .../distributed/test/jmx/JMXGetterCheckTest.java | 46 --- .../commitlog/CommitLogSegmentManagerCDCTest.java | 2 +- 11 files changed, 261 insertions(+), 122 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 4034fbb6dd4b9026b5227458a63c82e7e8075459
Merge: d13b3ef61b c6d7d070c5
Author: Jon Meredith
AuthorDate: Thu Aug 24 16:32:51 2023 -0600
Merge branch 'cassandra-3.11' into cassandra-4.0
build.xml | 5 +-
.../utils/RMIClientSocketFactoryImpl.java | 22 +-
.../apache/cassandra/utils/ReflectionUtils.java| 46 +++-
.../cassandra/distributed/impl/Instance.java | 5 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 87 +-
.../cassandra/distributed/shared/ClusterUtils.java | 34 +++--
.../distributed/test/ResourceLeakTest.java | 54 --
.../distributed/test/jmx/JMXFeatureTest.java | 85 ++---
.../distributed/test/jmx/JMXGetterCheckTest.java | 46 +---
9 files changed, 262 insertions(+), 122 deletions(-)
diff --cc build.xml
index 0b914175bb,70a195f98d..5812360e27
--- a/build.xml
+++ b/build.xml
@@@ -176,111 -160,6 +176,112 @@@
}
+
+
+
+
+
+
+
+
+
+
+
+
+-Djdk.attach.allowAttachSelf=true
+
+-XX:+UseConcMarkSweepGC
+-XX:+CMSParallelRemarkEnabled
+-XX:SurvivorRatio=8
+-XX:MaxTenuringThreshold=1
+-XX:CMSInitiatingOccupancyFraction=75
+-XX:+UseCMSInitiatingOccupancyOnly
+-XX:CMSWaitDuration=1
+-XX:+CMSParallelInitialMarkEnabled
+-XX:+CMSEdenChunksRecordAlways
+
+--add-exports java.base/jdk.internal.misc=ALL-UNNAMED
+--add-exports java.base/jdk.internal.ref=ALL-UNNAMED
+--add-exports java.base/sun.nio.ch=ALL-UNNAMED
+--add-exports
java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED
+--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED
+--add-exports java.rmi/sun.rmi.server=ALL-UNNAMED
++--add-exports java.rmi/sun.rmi.transport=ALL-UNNAMED
+--add-exports
java.rmi/sun.rmi.transport.tcp=ALL-UNNAMED
+--add-exports java.sql/java.sql=ALL-UNNAMED
+
+--add-opens java.base/java.lang.module=ALL-UNNAMED
+--add-opens java.base/java.net=ALL-UNNAMED
+--add-opens java.base/jdk.internal.loader=ALL-UNNAMED
+--add-opens java.base/jdk.internal.ref=ALL-UNNAMED
+--add-opens
java.base/jdk.internal.reflect=ALL-UNNAMED
+--add-opens java.base/jdk.internal.math=ALL-UNNAMED
+--add-opens java.base/jdk.internal.module=ALL-UNNAMED
+--add-opens
java.base/jdk.internal.util.jar=ALL-UNNAMED
+--add-opens
jdk.management/com.sun.management.internal=ALL-UNNAMED
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+-XX:-CMSClassUnloadingEnabled
+-Dio.netty.tryReflectionSetAccessible=true
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
@@@ -552,35 -383,30 +553,35 @@@
+
+
+
+
-
+
-
-
-
-
-
-
+
+
+
+
+
+
-
+
+
-
+
-
-
+
+
-
-
-
-
+
+
+
+
@@@ -2003,32 -1752,13 +2004,32 @@@
+
+
+
+
+
+
+
+
+
-
+
-
+
+
+
Apache Cassandra ${eclipse.project.name}
[cassandra] branch cassandra-4.0 updated (d13b3ef61b -> 4034fbb6dd)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from d13b3ef61b Merge branch 'cassandra-3.11' into cassandra-4.0 new c6d7d070c5 IsolatedJMX should not release all TCPEndpoints on instance shutdown new 4034fbb6dd Merge branch 'cassandra-3.11' into cassandra-4.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 5 +- .../utils/RMIClientSocketFactoryImpl.java | 22 +- .../apache/cassandra/utils/ReflectionUtils.java| 46 +++- .../cassandra/distributed/impl/Instance.java | 5 +- .../cassandra/distributed/impl/IsolatedJmx.java| 87 +- .../cassandra/distributed/shared/ClusterUtils.java | 34 +++-- .../distributed/test/ResourceLeakTest.java | 54 -- .../distributed/test/jmx/JMXFeatureTest.java | 85 ++--- .../distributed/test/jmx/JMXGetterCheckTest.java | 46 +--- 9 files changed, 262 insertions(+), 122 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (c03b5d639 -> 4363ada12)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard c03b5d639 generate docs for ce048d19 new 4363ada12 generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c03b5d639) \ N -- N -- N refs/heads/asf-staging (4363ada12) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[
https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758740#comment-17758740
]
Brandon Williams commented on CASSANDRA-18745:
--
Running from the src directory isn't a problem if C* has been built:
{noformat}
$ ../bin/cqlsh
Connection error: ('Unable to connect to any servers', {'127.0.0.1:9042':
ConnectionRefusedError(111, "Tried connecting to [('127.0.0.1', 9042)]. Last
error: Connection refused")})
{noformat}
I'm not against printing some warning if it can't be imported instead, but will
note this only happens with source that isn't built - binaries and packages
will have a serverversion.py since they include a compiled server.
> cqlsh should warn on server version mismatch
>
>
> Key: CASSANDRA-18745
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18745
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1
>
>
> When cqlsh is used against a different version of the server than the one
> that it shipped with, it should emit a warning so that users aren't confused
> when some things don't work correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758738#comment-17758738 ] Brad Schoening commented on CASSANDRA-18745: Yes, understand its being run from the src directory, but it doesn't seem like it needs to be a fatal error. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1 > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758736#comment-17758736 ] Brandon Williams edited comment on CASSANDRA-18745 at 8/24/23 9:43 PM: --- That is an indication your C* hasn't been built. We could make it throw a more informative error to that effect though. was (Author: brandon.williams): That is an indication your C* hasn't been built. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1 > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758736#comment-17758736 ] Brandon Williams commented on CASSANDRA-18745: -- That is an indication your C* hasn't been built. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1 > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18564) Test Failure: MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
[
https://issues.apache.org/jira/browse/CASSANDRA-18564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758735#comment-17758735
]
Caleb Rackliffe commented on CASSANDRA-18564:
-
bq. We could simply skip testing the cases where the query should timeout.
After all, those expected timeouts due to down replicas seem indistinguishable
from the timeouts produced by an overloaded CI environment. wdyt?
That seems reasonable to me.
> Test Failure:
> MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
>
>
> Key: CASSANDRA-18564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18564
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The JVM upgrade dtest
> {{MixedModeAvailabilityV3XAllOneTest.testAvailabilityCoordinatorUpgraded}}
> seems to be flaky at least in {{trunk}}:
> {code}
> junit.framework.AssertionFailedError: Error in test '4.0.11 -> [5.0]' while
> upgrading to '5.0'; successful upgrades []
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:348)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:154)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailabilityCoordinatorUpgraded(MixedModeAvailabilityTestBase.java:74)
> Caused by: java.lang.AssertionError: Unexpected error while reading in case
> write-read consistency ALL-ONE with upgraded coordinator and 2 nodes down:
> org.apache.cassandra.exceptions.ReadTimeoutException: Operation timed out -
> received only 0 responses.
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.lambda$testAvailability$6(MixedModeAvailabilityTestBase.java:145)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:339)
> Caused by: org.apache.cassandra.exceptions.ReadTimeoutException: Operation
> timed out - received only 0 responses.
> at
> org.apache.cassandra.service.reads.ReadCallback.awaitResults(ReadCallback.java:162)
> at
> org.apache.cassandra.service.reads.AbstractReadExecutor.awaitResponses(AbstractReadExecutor.java:387)
> at
> org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:2124)
> at
> org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1995)
> at
> org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1873)
> at
> org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1286)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:364)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:293)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:105)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:122)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
> at
> org.apache.cassandra.distributed.impl.Coordinator.lambda$executeWithResult$0(Coordinator.java:66)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:750)
> {code}
> This has failed 143 times in 500 iterations of this CircleCI run:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2927/workflows/fcd1cd60-826b-484a-8e81-d3ba640f7de9/jobs/47659/tests
> The failure has also recently appeared on Jenkins too:
> *
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1585/testReport/org.apache.cassandra.distributed.upgrade/MixedModeAvailabilityV3XAllOneTest/testAvailabilityCoordinatorUpgraded__jdk11/
> Given that the failure has just appeared on Jenkins and it fails relatively
> easily on CircleCI, it's likely that it has been broken by a very recent
> change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail:
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[
https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758734#comment-17758734
]
Brad Schoening commented on CASSANDRA-18745:
[~brandon.williams] would be helpful if this had a try/catch around the import
of serverversion and didn't fail outright if serververison is missing. This can
happen if you run directly from the src directory, for example:
{quote}../bin/cqlsh
Traceback (most recent call last):
File "/Users/.../cassandra/bin/cqlsh.py", line 82, in
from cqlshlib.cqlshmain import main
File "/Users/.../cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 85, in
from cqlshlib.serverversion import version as build_version
ModuleNotFoundError: No module named 'cqlshlib.serverversion'
{quote}
> cqlsh should warn on server version mismatch
>
>
> Key: CASSANDRA-18745
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18745
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1
>
>
> When cqlsh is used against a different version of the server than the one
> that it shipped with, it should emit a warning so that users aren't confused
> when some things don't work correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18796) Optionally fail when a non-partition-restricted query is issued against a storage-attached index with a backing table using LCS
Caleb Rackliffe created CASSANDRA-18796: --- Summary: Optionally fail when a non-partition-restricted query is issued against a storage-attached index with a backing table using LCS Key: CASSANDRA-18796 URL: https://issues.apache.org/jira/browse/CASSANDRA-18796 Project: Cassandra Issue Type: Improvement Components: Feature/2i Index, Feature/SAI, Local/Compaction/LCS Reporter: Caleb Rackliffe Assignee: Caleb Rackliffe With LCS, we will have potentially thousands of SSTables for a given user table. Storage-attached also means SSTable-attached, and searching thousands of attached indexes is not going to scale well at all locally, due to the sheer number of searches and amount of postings list merging involved. We should have a guardrail to prohibit this by default. Partition-restricted queries, the use-case SAI is broadly designed for, should be very efficient. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18796) Optionally fail when a non-partition-restricted query is issued against a storage-attached index with a backing table using LCS
[ https://issues.apache.org/jira/browse/CASSANDRA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18796: Change Category: Performance Complexity: Low Hanging Fruit Fix Version/s: 5.0.x 5.x Status: Open (was: Triage Needed) > Optionally fail when a non-partition-restricted query is issued against a > storage-attached index with a backing table using LCS > --- > > Key: CASSANDRA-18796 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18796 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index, Feature/SAI, Local/Compaction/LCS >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0.x, 5.x > > > With LCS, we will have potentially thousands of SSTables for a given user > table. Storage-attached also means SSTable-attached, and searching thousands > of attached indexes is not going to scale well at all locally, due to the > sheer number of searches and amount of postings list merging involved. We > should have a guardrail to prohibit this by default. > Partition-restricted queries, the use-case SAI is broadly designed for, > should be very efficient. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758711#comment-17758711
]
Ekaterina Dimitrova commented on CASSANDRA-18710:
-
This test was added as part of CASSANDRA-18397 -
https://github.com/apache/cassandra/commit/957eca2fb53477d56bdc9a97c612f1fbecfb5d41#diff-af921b889c103e8ba6c4c21566a6b1264b7ebcea8d8c374a9105252418618e6cR99
>From the PR in that ticket, it seems that there was a try to fix the flakiness
>there (that explains why it is very hard to reproduce in CircleCI)-
>[https://github.com/blambov/cassandra/commit/6b7e755db20bb1b63dd18f3a03830b8dee909672]
Maybe [~blambov] will have some hints here?
> Test failure:
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from
> org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
> --
>
> Key: CASSANDRA-18710
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18710
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/]
> h3.
> {code:java}
> Error Message
> expected:<7200.0> but was:<1367.83970468544>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<7200.0> but
> was:<1367.83970468544> at
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17884) [jamm] Test failure: o.a.c.repair.RepairJobTest.testNoTreesRetainedAfterDifference
[
https://issues.apache.org/jira/browse/CASSANDRA-17884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-17884:
Fix Version/s: (was: 5.x)
> [jamm] Test failure:
> o.a.c.repair.RepairJobTest.testNoTreesRetainedAfterDifference
> --
>
> Key: CASSANDRA-17884
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17884
> Project: Cassandra
> Issue Type: Bug
> Components: Jamm, Test/unit
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Attachments: RepairSessionTree.txt
>
>
> The unit test
> {{org.apache.cassandra.repair.RepairJobTest#testNoTreesRetainedAfterDifference}}
> seems to be slightly flaky at least in 4.0. We haven't seen it failing on
> Butler, but after [a failure on a patch
> branch|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/281/workflows/e6094c00-b611-4772-9772-205f4c76ecba/jobs/2126/tests],
> this repeated run shows a 0.28% flakiness:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2076/workflows/8adbfe99-afb5-43af-84ad-43df2a2a86e2/jobs/20816/tests
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2076/workflows/e550d8c2-7c35-4326-bd95-6909978d344b/jobs/20817/tests
> {code}
> java.lang.reflect.InaccessibleObjectException: Unable to make field private
> jdk.internal.platform.cgroupv1.SubSystem$MemorySubSystem
> jdk.internal.platform.cgroupv1.Metrics.memory accessible: module java.base
> does not "opens jdk.internal.platform.cgroupv1" to unnamed module @157853da
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:340)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:280)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:176)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:170)
> at org.github.jamm.MemoryMeter.addFieldChildren(MemoryMeter.java:330)
> at org.github.jamm.MemoryMeter.measureDeep(MemoryMeter.java:269)
> at
> org.apache.cassandra.utils.ObjectSizes.measureDeep(ObjectSizes.java:216)
> at
> org.apache.cassandra.repair.RepairJobTest.testNoTreesRetainedAfterDifference(RepairJobTest.java:271)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> Flakiness is really low but the failure is clearly reproducible in j11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758691#comment-17758691
]
Brandon Williams commented on CASSANDRA-18750:
--
bq. At most to 4.1 as that is the first branch having checkstyle.
Good point. 4.1, 5.0, and trunk make sense to me, then.
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
> Attachments: signature.asc
>
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
miklosovic updated CASSANDRA-18750:
---
Attachment: signature.asc
I was thinking this will go to 5.0 and trunk only. At most to 4.1 as that is
the first branch having checkstyle.
Given the fact 3.x is going to be dropped in few months I consider that to be
an unneccessary exercise.
Sent from ProtonMail mobile
\
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
> Attachments: signature.asc
>
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18065) Flaky test org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
[
https://issues.apache.org/jira/browse/CASSANDRA-18065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758681#comment-17758681
]
Brandon Williams commented on CASSANDRA-18065:
--
This fails on its initial commit from CASSANDRA-17821,
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/1236/workflows/44d9e1b6-ec35-4a49-b8cd-6ce440212c23/jobs/47758]:
{noformat}
[junit-timeout] Testcase:
testStartAndStopScheduledSampling(org.apache.cassandra.tools.TopPartitionsTest):
FAILED
[junit-timeout] Scheduled sampled tasks should be removed expected:<[]> but
was:<[*.*]>
[junit-timeout] junit.framework.AssertionFailedError: Scheduled sampled tasks
should be removed expected:<[]> but was:<[*.*]>
[junit-timeout] at
org.apache.cassandra.tools.TopPartitionsTest.testStartAndStopScheduledSampling(TopPartitionsTest.java:116)
[junit-timeout] at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit-timeout] at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit-timeout] at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{noformat}
/cc [~jmckenzie]
> Flaky test
> org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
> -
>
> Key: CASSANDRA-18065
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18065
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Andres de la Peña
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The test
> {{org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling}}
> is fails intermittently on trunk with CircleCI:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2508/workflows/92f054d7-9386-498f-9ba4-330181cd4782/jobs/24692
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2511/workflows/7aba8baa-0a6d-404a-b08b-c6a8078caca3/jobs/24706/tests
> The failure looks like:
> {code}
> junit.framework.AssertionFailedError: Scheduled sampled tasks should be
> removed expected:<[]> but was:<[*.*]>
> at
> org.apache.cassandra.tools.TopPartitionsTest.testStartAndStopScheduledSampling(TopPartitionsTest.java:116)
> {code}
> I haven't seen this failure on Butler/Jenkins yet, but it can be reproduced
> with the CircleCI multiplexer:
> {code}
> .circleci/generate.sh -m \
> -e REPEATED_UTESTS_COUNT=2000 \
> -e REPEATED_UTESTS=org.apache.cassandra.tools.TopPartitionsTest
> {code}
> It seems to fail 11 times on 2000 runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18564) Test Failure: MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
[
https://issues.apache.org/jira/browse/CASSANDRA-18564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758678#comment-17758678
]
Andres de la Peña commented on CASSANDRA-18564:
---
The test seems to pass in 4.1:
[https://app.circleci.com/pipelines/github/adelapena/cassandra/3141/workflows/5e7f85e7-ce66-4e8a-af8d-23f7de9d2205]
It only fails in 5.0 and trunk. This test has always been quite long and prone
to timeouts. The new v50 and v51 branches have almost doubled the number of
upgrade paths, and this probably is what is producing the timeouts.
[Increasing {{read_request_timeout}} and {{write_request_timeout}} to 30
seconds|https://github.com/apache/cassandra/commit/d7775660bfe94ab2353faab95a4a7cd0e2cf79ee]
seems to be enough to make the test survive 500 runs:
https://app.circleci.com/pipelines/github/adelapena/cassandra/3142/workflows/0c680c43-c988-4fa5-8e05-7ab81aea8ae1
However, increasing the timeouts to one minute seems to risk a CircleCI
timeout:
https://app.circleci.com/pipelines/github/adelapena/cassandra/3143/workflows/66ca0ccc-f6a0-4ba6-9376-59b9b03b57fb
The tricky bit with this test is that it runs both queries that should
succeeded and queries that should timeout. So, if we increase the timeout
thresholds for the queries that should succeed, then the queries that should
timeout make the test incredibly slow.
Maybe we can live with those 30s timeouts, even if they make the test quite
expensive. However, it occurs to me that we could relax the conditions of the
test to only verify the queries that should succeed with the expected
consistency levels and down replicas. We could simply skip testing the cases
where the query should timeout. After all, those expected timeouts due to down
replicas seem indistinguishable from the timeouts produced by an overloaded CI
environment. wdyt?
> Test Failure:
> MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
>
>
> Key: CASSANDRA-18564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18564
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The JVM upgrade dtest
> {{MixedModeAvailabilityV3XAllOneTest.testAvailabilityCoordinatorUpgraded}}
> seems to be flaky at least in {{trunk}}:
> {code}
> junit.framework.AssertionFailedError: Error in test '4.0.11 -> [5.0]' while
> upgrading to '5.0'; successful upgrades []
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:348)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:154)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailabilityCoordinatorUpgraded(MixedModeAvailabilityTestBase.java:74)
> Caused by: java.lang.AssertionError: Unexpected error while reading in case
> write-read consistency ALL-ONE with upgraded coordinator and 2 nodes down:
> org.apache.cassandra.exceptions.ReadTimeoutException: Operation timed out -
> received only 0 responses.
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.lambda$testAvailability$6(MixedModeAvailabilityTestBase.java:145)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:339)
> Caused by: org.apache.cassandra.exceptions.ReadTimeoutException: Operation
> timed out - received only 0 responses.
> at
> org.apache.cassandra.service.reads.ReadCallback.awaitResults(ReadCallback.java:162)
> at
> org.apache.cassandra.service.reads.AbstractReadExecutor.awaitResponses(AbstractReadExecutor.java:387)
> at
> org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:2124)
> at
> org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1995)
> at
> org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1873)
> at
> org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1286)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:364)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:293)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:105)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:122)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
> at
>
[cassandra-website] branch asf-staging updated (1670ede7d -> c03b5d639)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1670ede7d generate docs for ce048d19 new c03b5d639 generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1670ede7d) \ N -- N -- N refs/heads/asf-staging (c03b5d639) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18795) Compaction purger doesn't handle seeing random slices of state correctly
Ariel Weisberg created CASSANDRA-18795: -- Summary: Compaction purger doesn't handle seeing random slices of state correctly Key: CASSANDRA-18795 URL: https://issues.apache.org/jira/browse/CASSANDRA-18795 Project: Cassandra Issue Type: Bug Reporter: Ariel Weisberg Assignee: Ariel Weisberg Compaction purger was written assuming it will be compacting the latest state of the command row, but this is far from the case and it will actually be compacting a random slice of command row columns and their versions based on whatever input sstables are selected for the compaction. This is not very problematic to fix. A lot of the logic is based on just the value of the field, and the remaining can wait until enough of the command is visible to determine if cleanup is possible cleanup. Eventually durability is `universal` and we can drop the row contents based on just the `txnid` so there is always a fallback no matter how badly we have torn up the state of a command by dropping portions. We don't want to rely on that so we do drop a tombstone in the `erase` case which we can later drop when durability is `universal` without any expensive tombstone handling checks. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758650#comment-17758650
]
Brandon Williams commented on CASSANDRA-18710:
--
I don't see anything wrong with the metrics so I'm currently out of ideas here.
I did manage to repro once in
[circle|https://app.circleci.com/pipelines/github/driftx/cassandra/1220/workflows/e0c90c4a-115b-45f7-a798-c5e21dc937f9/jobs/46827/tests],
with the mistaken flush commit removed.
> Test failure:
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from
> org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
> --
>
> Key: CASSANDRA-18710
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18710
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/]
> h3.
> {code:java}
> Error Message
> expected:<7200.0> but was:<1367.83970468544>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<7200.0> but
> was:<1367.83970468544> at
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18065) Flaky test org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
[
https://issues.apache.org/jira/browse/CASSANDRA-18065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-18065:
Assignee: Brandon Williams
> Flaky test
> org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
> -
>
> Key: CASSANDRA-18065
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18065
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Andres de la Peña
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The test
> {{org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling}}
> is fails intermittently on trunk with CircleCI:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2508/workflows/92f054d7-9386-498f-9ba4-330181cd4782/jobs/24692
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2511/workflows/7aba8baa-0a6d-404a-b08b-c6a8078caca3/jobs/24706/tests
> The failure looks like:
> {code}
> junit.framework.AssertionFailedError: Scheduled sampled tasks should be
> removed expected:<[]> but was:<[*.*]>
> at
> org.apache.cassandra.tools.TopPartitionsTest.testStartAndStopScheduledSampling(TopPartitionsTest.java:116)
> {code}
> I haven't seen this failure on Butler/Jenkins yet, but it can be reproduced
> with the CircleCI multiplexer:
> {code}
> .circleci/generate.sh -m \
> -e REPEATED_UTESTS_COUNT=2000 \
> -e REPEATED_UTESTS=org.apache.cassandra.tools.TopPartitionsTest
> {code}
> It seems to fail 11 times on 2000 runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (fa54a85ca -> 1670ede7d)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard fa54a85ca generate docs for ce048d19 new 1670ede7d generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (fa54a85ca) \ N -- N -- N refs/heads/asf-staging (1670ede7d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../developing/cql/dynamic_data_masking.html | 21 +++-- .../5.0/cassandra/developing/cql/functions.html| 2 +- .../developing/cql/dynamic_data_masking.html | 21 +++-- .../5.1/cassandra/developing/cql/functions.html| 2 +- .../developing/cql/dynamic_data_masking.html | 21 +++-- .../trunk/cassandra/developing/cql/functions.html | 2 +- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4852435 -> 4852435 bytes 8 files changed, 37 insertions(+), 34 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758617#comment-17758617
]
Brandon Williams commented on CASSANDRA-18750:
--
Probably all of them. 3.0, 3.11, 4.0, 4.1, 5.0 and trunk.
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758614#comment-17758614
]
Derek Chen-Becker commented on CASSANDRA-18750:
---
Yup, sorry, I just realized I had my upstream branch set incorrectly so I
wasn't seeing updates to trunk. PR is updated and I'll start working on
backporting.
https://cassandra.apache.org/_/development/patches.html seems out of date.
Which branches should I target with this?
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[
https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758603#comment-17758603
]
Ekaterina Dimitrova commented on CASSANDRA-18717:
-
{quote}{quote}let's just not forget all the issues we put on hold
{quote}
100% agreed
{quote}
+1, thus my suggestion to help with that. I believe in teamwor. :)
Also, talking explicitly about not forgetting to push things before the release
- [~mmuzaf], how about we put those tickets on hold under a specific label or
in an umbrella epic?
> Fix errors or remove ant javadoc task
> -
>
> Key: CASSANDRA-18717
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18717
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation/Javadoc
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> As discussed on CASSANDRA-17687, the javadoc task completes successfully, but
> there are errors that deserve to be fixed if we keep the task around.
> If we do not plan to use it, we should remove it and reduce the clutter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18789) Update commons-lang3 to 3.13.0
[
https://issues.apache.org/jira/browse/CASSANDRA-18789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758599#comment-17758599
]
Ekaterina Dimitrova commented on CASSANDRA-18789:
-
{quote}If we're not being religious about his, which is what I gather from the
ML, I think we can go ahead with 5.0.
{quote}
Indeed. I will wait today to see if someone joins with an additional/different
opinion, and I can announce a consensus tomorrow and move on.
> Update commons-lang3 to 3.13.0
> --
>
> Key: CASSANDRA-18789
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18789
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Low
> Fix For: 5.0.x, 5.x
>
>
> It seems we are on a version that was testing up to Java 11 - 3.11.0
> In the latest one the community goes up to JDK21 so I think it is good to
> update, hopefully also on cassandra-5.0
> Below are the release notes:
> https://commons.apache.org/proper/commons-lang/changes-report.html#a3.12.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758598#comment-17758598 ] Ekaterina Dimitrova edited comment on CASSANDRA-18688 at 8/24/23 1:41 PM: -- bq. This was almost ready. Is anything pending I am blocking as a reviewer? I see an ongoing discussion between [~skokoori] and [~mck] in regard: bq. -J option is inline with -R, f etc. we already provide for bin/cassandra. By env var, I assume you mean something like what we had to enable JDK11 in 4.x, with a -D. I am still not clear on which of the two options we go for: bq. The options after this patch are: bq. 1) Leave it that way and add the J flag only for 17+ if anyone wants to run Cassandra experimentally on any of the newer versions. bq. 2) Change it to the J flag suggested (same as 17+). Reject running on those versions in general, give the people the chance to run Cassandra experimentally on version 11-17 and 17+ by using the J flag Also, [~skokoori] is off these days was (Author: e.dimitrova): bq. This was almost ready. Is anything pending I am blocking as a reviewer? I see an ongoing discussion between [~skokoori] and [~mck] in regard: bq. -J option is inline with -R, f etc. we already provide for bin/cassandra. By env var, I assume you mean something like what we had to enable JDK11 in 4.x, with a -D. I am still not clear on which of the two options we go for: bq. The options after this patch are: 1) Leave it that way and add the J flag only for 17+ if anyone wants to run Cassandra experimentally on any of the newer versions. 2) Change it to the J flag suggested (same as 17+). Reject running on those versions in general, give the people the chance to run Cassandra experimentally on version 11-17 and 17+ by using the J flag Also, [~skokoori] is off these days > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758598#comment-17758598 ] Ekaterina Dimitrova commented on CASSANDRA-18688: - bq. This was almost ready. Is anything pending I am blocking as a reviewer? I see an ongoing discussion between [~skokoori] and [~mck] in regard: bq. -J option is inline with -R, f etc. we already provide for bin/cassandra. By env var, I assume you mean something like what we had to enable JDK11 in 4.x, with a -D. I am still not clear on which of the two options we go for: bq. The options after this patch are: 1) Leave it that way and add the J flag only for 17+ if anyone wants to run Cassandra experimentally on any of the newer versions. 2) Change it to the J flag suggested (same as 17+). Reject running on those versions in general, give the people the chance to run Cassandra experimentally on version 11-17 and 17+ by using the J flag Also, [~skokoori] is off these days > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758596#comment-17758596
]
Brandon Williams commented on CASSANDRA-18750:
--
Yep, just ignore bcprov.
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758595#comment-17758595
]
Stefan Miklosovic commented on CASSANDRA-18750:
---
CVE in bcprov was fixed by this,
https://issues.apache.org/jira/browse/CASSANDRA-18729?focusedCommentId=17752323=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17752323
Your trunk is just too much behind.
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758590#comment-17758590
]
Derek Chen-Becker commented on CASSANDRA-18750:
---
Before (tested against current trunk):
{code}
...
[checkstyle] [ERROR]
/ssdhome/software/projects/cassandra/test/unit/org/apache/cassandra/streaming/StreamSessionTest.java:79:
Please do not hardcode /tmp for test files and directories. Use
Files.createTempDirectory to create a base test directory instead.
[hardcodeTmpDirectoryUsage]
BUILD FAILED
/ssdhome/software/projects/cassandra/build.xml:521: The following error
occurred while executing this line:
/ssdhome/software/projects/cassandra/.build/build-checkstyle.xml:57: Got 30
errors and 0 warnings.
{code}
After the change it still failed, but on a CVE vulnerability in {{bcprov}}.
Total runtime with the new rule was 2:42.
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758581#comment-17758581
]
Derek Chen-Becker commented on CASSANDRA-18750:
---
It takes ripgrep all of 30ms to check the entire codebase, so hopefully
checkstyle can come within an order of magnitude or two :) Let me add the rule
and test.
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18765) Add CASSANDRA-14227 to 5.0 new features page
[ https://issues.apache.org/jira/browse/CASSANDRA-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758527#comment-17758527 ] Berenguer Blasi commented on CASSANDRA-18765: - Ah good call! > Add CASSANDRA-14227 to 5.0 new features page > > > Key: CASSANDRA-18765 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18765 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0, 5.0.x > > > The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] > listing the 5.0 new features is not mentioning the extended TTL implemented > in CASSANDRA-14227 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18564) Test Failure: MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
[
https://issues.apache.org/jira/browse/CASSANDRA-18564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña reassigned CASSANDRA-18564:
-
Assignee: Andres de la Peña
> Test Failure:
> MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
>
>
> Key: CASSANDRA-18564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18564
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The JVM upgrade dtest
> {{MixedModeAvailabilityV3XAllOneTest.testAvailabilityCoordinatorUpgraded}}
> seems to be flaky at least in {{trunk}}:
> {code}
> junit.framework.AssertionFailedError: Error in test '4.0.11 -> [5.0]' while
> upgrading to '5.0'; successful upgrades []
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:348)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailability(MixedModeAvailabilityTestBase.java:154)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.testAvailabilityCoordinatorUpgraded(MixedModeAvailabilityTestBase.java:74)
> Caused by: java.lang.AssertionError: Unexpected error while reading in case
> write-read consistency ALL-ONE with upgraded coordinator and 2 nodes down:
> org.apache.cassandra.exceptions.ReadTimeoutException: Operation timed out -
> received only 0 responses.
> at
> org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityTestBase.lambda$testAvailability$6(MixedModeAvailabilityTestBase.java:145)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:339)
> Caused by: org.apache.cassandra.exceptions.ReadTimeoutException: Operation
> timed out - received only 0 responses.
> at
> org.apache.cassandra.service.reads.ReadCallback.awaitResults(ReadCallback.java:162)
> at
> org.apache.cassandra.service.reads.AbstractReadExecutor.awaitResponses(AbstractReadExecutor.java:387)
> at
> org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:2124)
> at
> org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1995)
> at
> org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1873)
> at
> org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1286)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:364)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:293)
> at
> org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:105)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:122)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
> at
> org.apache.cassandra.distributed.impl.Coordinator.lambda$executeWithResult$0(Coordinator.java:66)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:750)
> {code}
> This has failed 143 times in 500 iterations of this CircleCI run:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2927/workflows/fcd1cd60-826b-484a-8e81-d3ba640f7de9/jobs/47659/tests
> The failure has also recently appeared on Jenkins too:
> *
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1585/testReport/org.apache.cassandra.distributed.upgrade/MixedModeAvailabilityV3XAllOneTest/testAvailabilityCoordinatorUpgraded__jdk11/
> Given that the failure has just appeared on Jenkins and it fails relatively
> easily on CircleCI, it's likely that it has been broken by a very recent
> change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18750) Make unit tests compatible with the tmp.dir property
[
https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758513#comment-17758513
]
Brandon Williams commented on CASSANDRA-18750:
--
I think it makes sense and is easy enough to do. I just worry about checkstyle
suddenly blowing up to 15 minutes of runtime when we change it. :)
> Make unit tests compatible with the tmp.dir property
>
>
> Key: CASSANDRA-18750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18750
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
>
> Several unit tests hard-code file paths under the "/tmp" directory, which
> means they do not honor the {{tmp.dir}} ant build property. These should be
> updated so that when the user specifies {{tmp.dir}}, they can be certain that
> any files or directories created by the unit tests will be in their specified
> location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16999) system.peers and system.peers_v2 do not contain the native_transport and/or native_transport_port_ssl
[ https://issues.apache.org/jira/browse/CASSANDRA-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758512#comment-17758512 ] Brandon Williams commented on CASSANDRA-16999: -- [~absurdfarce] ping again, 5.0 alpha1 is slated to release soon. > system.peers and system.peers_v2 do not contain the native_transport and/or > native_transport_port_ssl > - > > Key: CASSANDRA-16999 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16999 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Steve Lacerda >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > system.peers_v2 includes a “native_port” but has no notion of > native_transport_port vs. native_transport_port_ssl. Given this limited > information, there’s no clear way for the driver to know that different ports > are being used for SSL vs. non-SSL or which of those two ports is identified > by “native_port”. > > The issue we ran into is that the java driver, since it has no notion of the > transport port SSL, the driver was only using the contact points and was not > load balancing. > > The customer had both set: > native_transport_port: 9042 > native_transport_port_ssl: 9142 > > They were attempting to connect to 9142, but that was failing. They could > only use 9042, and so their applications load balancing was failing. We found > that any node that was a contact point was connecting, but the other nodes > were never acting as coordinators. > > There are still issues in the driver, for which I have created JAVA-2967, > which also refers to JAVA-2638, but the system.peers and system.peers_v2 > tables should both contain native_transport_port and > native_transport_port_ssl. > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (3bc6a8391 -> fa54a85ca)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 3bc6a8391 generate docs for ce048d19 new fa54a85ca generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (3bc6a8391) \ N -- N -- N refs/heads/asf-staging (fa54a85ca) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18794) Add missing features to 5.0 new features page
[ https://issues.apache.org/jira/browse/CASSANDRA-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758501#comment-17758501 ] Stefan Miklosovic commented on CASSANDRA-18794: --- LGTM > Add missing features to 5.0 new features page > - > > Key: CASSANDRA-18794 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18794 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] > listing the 5.0 new features is not mentioning multiple new features like > trie sstables, unified compaction strategy, dynamic data masking, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18790) Fix spelling errors in the documentation for DDM
[ https://issues.apache.org/jira/browse/CASSANDRA-18790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18790: -- Fix Version/s: 5.0 5.1 (was: 5.x) (was: 5.0.x) Since Version: 5.0-alpha1 Source Control Link: https://github.com/apache/cassandra/commit/410018ab165b54c378648d52fb4ec815c557e80e Resolution: Fixed Status: Resolved (was: Ready to Commit) > Fix spelling errors in the documentation for DDM > > > Key: CASSANDRA-18790 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18790 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0, 5.1 > > Time Spent: 20m > Remaining Estimate: 0h > > [~polandll] has pointed out multiple spelling errors on the documentation for > dynamic data masking. This ticket aims to fix them. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18790) Fix spelling errors in the documentation for DDM
[
https://issues.apache.org/jira/browse/CASSANDRA-18790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758500#comment-17758500
]
Andres de la Peña commented on CASSANDRA-18790:
---
Thanks for the review.
Committed to {{cassandra-5.0}} as
[410018ab165b54c378648d52fb4ec815c557e80e|https://github.com/apache/cassandra/commit/410018ab165b54c378648d52fb4ec815c557e80e]
and merged to
[{{trunk}}|https://github.com/apache/cassandra/commit/cbaef9094e83364e6812c65b8411ff7dbffaf9c6].
> Fix spelling errors in the documentation for DDM
>
>
> Key: CASSANDRA-18790
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18790
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [~polandll] has pointed out multiple spelling errors on the documentation for
> dynamic data masking. This ticket aims to fix them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated: Fix spelling errors in the documentation for DDM
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-5.0 by this push: new 410018ab16 Fix spelling errors in the documentation for DDM 410018ab16 is described below commit 410018ab165b54c378648d52fb4ec815c557e80e Author: Andrés de la Peña AuthorDate: Wed Aug 23 10:54:11 2023 +0100 Fix spelling errors in the documentation for DDM patch by Andrés de la Peña; reviewed by Brandon Williams for CASSANDRA-18790 Co-authored-by: Andrés de la Peña Co-authored-by: Lorina Poland --- .../pages/developing/cql/dynamic_data_masking.adoc| 19 ++- doc/modules/cassandra/partials/masking_functions.adoc | 2 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/doc/modules/cassandra/pages/developing/cql/dynamic_data_masking.adoc b/doc/modules/cassandra/pages/developing/cql/dynamic_data_masking.adoc index 8f523ac2ed..16599c9053 100644 --- a/doc/modules/cassandra/pages/developing/cql/dynamic_data_masking.adoc +++ b/doc/modules/cassandra/pages/developing/cql/dynamic_data_masking.adoc @@ -1,7 +1,7 @@ = Dynamic Data Masking Dynamic data masking (DDM) allows to obscure sensitive information while still allowing access to the masked columns. -DDM doesn't change the stored data. Instead, it just presents the data on their obscured form during `SELECT` queries. +DDM doesn't change the stored data. Instead, it just presents the data in its obscured form during `SELECT` queries. This aims to provide some degree of protection against accidental data exposure. However, it's important to know that anyone with direct access to the sstable files will be able to read the clear data. @@ -20,10 +20,10 @@ include::example$CQL/select_with_mask_functions.cql[] == Attaching masking functions to table columns -The masking functions can be permanently attached to the columns of a table. -In that case, `SELECT` queries will always return the column values in their masked form. -The masking will be transparent for the users running `SELECT` queries, -so their only way to know that a column is masked will be consulting the table definition. +The masking functions can be permanently attached to any column of a table. +If a masking columns is defined, `SELECT` queries will always return the column values in their masked form. +The masking will be transparent to the users running `SELECT` queries, +so their only way to know that a column is masked will be to consult the table definition. This is an optional feature that should be enabled with the `dynamic_data_masking_enabled` property in `cassandra.yaml`, since it's disabled by default. @@ -74,8 +74,9 @@ include::example$CQL/ddm_drop_mask.cql[] == Permissions The `UNMASK` permission allows users to retrieve the unmasked values of masked columns. -The masks will only be applied to the results of a `SELECT` query if the user doesn't have the `UNMASK` permission. -Ordinary users are created without the `UNMASK` permission, whereas superusers do have it. +Ordinary users are created without the `UNMASK` permission and will see masked values. +Superusers are created with the `UNMASK` permission, +and will be able to see the unmasked values in a SELECT query results. As an example, suppose that we have a table with masked columns: @@ -104,7 +105,7 @@ the users: include::example$CQL/ddm_create_users.cql[] -We can now see that the user with the `UNMASK` permission can see the clear data, without any masking: +We can now see that the user with the `UNMASK` permission can see the clear data, unmasked: [source,cql] @@ -130,7 +131,7 @@ Since it includes the `UNMASK` permission, that anonymous user will always see t In other words, attaching data masking functions to columns only makes sense if authentication is enabled. Users without the `UNMASK` permission are not allowed to use masked columns in the `WHERE` clause of a `SELECT` query. -This prevents malicious users from figuring out the clear data by running exhaustive queries. For instance: +This prevents malicious users from figuring out the clear data by running exhaustive queries. For example: [source,cql] diff --git a/doc/modules/cassandra/partials/masking_functions.adoc b/doc/modules/cassandra/partials/masking_functions.adoc index afadcd001e..43fb25c38d 100644 --- a/doc/modules/cassandra/partials/masking_functions.adoc +++ b/doc/modules/cassandra/partials/masking_functions.adoc @@ -2,7 +2,7 @@ |=== |Function | Description -| `mask_null(value)` | Replaces the first argument by a `null` column. The returned value is always an absent column, as it didn't exist, and not a not-null column representing a `null` value. +| `mask_null(value)` | Replaces the first argument with a `null` column. The returned value is always a
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit cbaef9094e83364e6812c65b8411ff7dbffaf9c6 Merge: 4226cbbec6 410018ab16 Author: Andrés de la Peña AuthorDate: Thu Aug 24 11:23:23 2023 +0100 Merge branch 'cassandra-5.0' into trunk .../pages/developing/cql/dynamic_data_masking.adoc| 19 ++- doc/modules/cassandra/partials/masking_functions.adoc | 2 +- 2 files changed, 11 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (4226cbbec6 -> cbaef9094e)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 4226cbbec6 Merge branch 'cassandra-5.0' into trunk new 410018ab16 Fix spelling errors in the documentation for DDM new cbaef9094e Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../pages/developing/cql/dynamic_data_masking.adoc| 19 ++- doc/modules/cassandra/partials/masking_functions.adoc | 2 +- 2 files changed, 11 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18794) Add missing features to 5.0 new features page
[ https://issues.apache.org/jira/browse/CASSANDRA-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18794: -- Test and Documentation Plan: This is a doc change Status: Patch Available (was: Open) > Add missing features to 5.0 new features page > - > > Key: CASSANDRA-18794 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18794 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] > listing the 5.0 new features is not mentioning multiple new features like > trie sstables, unified compaction strategy, dynamic data masking, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18765) Add CASSANDRA-14227 to 5.0 new features page
[ https://issues.apache.org/jira/browse/CASSANDRA-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758493#comment-17758493 ] Andres de la Peña commented on CASSANDRA-18765: --- Created CASSANDRA-18794 for adding the rest of the missing features (sstable tries, DDM, UCS, etc.) > Add CASSANDRA-14227 to 5.0 new features page > > > Key: CASSANDRA-18765 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18765 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0, 5.0.x > > > The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] > listing the 5.0 new features is not mentioning the extended TTL implemented > in CASSANDRA-14227 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18794) Add missing features to 5.0 new features page
[ https://issues.apache.org/jira/browse/CASSANDRA-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18794: -- Bug Category: Parent values: Documentation(13562) Complexity: Low Hanging Fruit Discovered By: Code Inspection Fix Version/s: 5.0.x 5.x Severity: Normal Status: Open (was: Triage Needed) > Add missing features to 5.0 new features page > - > > Key: CASSANDRA-18794 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18794 > Project: Cassandra > Issue Type: Bug > Components: Documentation >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] > listing the 5.0 new features is not mentioning multiple new features like > trie sstables, unified compaction strategy, dynamic data masking, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18794) Add missing features to 5.0 new features page
[
https://issues.apache.org/jira/browse/CASSANDRA-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758492#comment-17758492
]
Andres de la Peña commented on CASSANDRA-18794:
---
I understand that [that
page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] doesn't
need to contain all the entries in
[{{NEWS.txt}}|https://github.com/apache/cassandra/blob/cassandra-5.0/NEWS.txt#L69-L188]
but only relatively major things. [This
PR|https://github.com/apache/cassandra/pull/2629] tries to do that. Please let
me know if something is missing or if some entries are not needed.
> Add missing features to 5.0 new features page
> -
>
> Key: CASSANDRA-18794
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18794
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html]
> listing the 5.0 new features is not mentioning multiple new features like
> trie sstables, unified compaction strategy, dynamic data masking, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18794) Add missing features to 5.0 new features page
Andres de la Peña created CASSANDRA-18794: - Summary: Add missing features to 5.0 new features page Key: CASSANDRA-18794 URL: https://issues.apache.org/jira/browse/CASSANDRA-18794 Project: Cassandra Issue Type: Bug Components: Documentation Reporter: Andres de la Peña Assignee: Andres de la Peña The [page|https://cassandra.apache.org/doc/trunk/cassandra/new/index.html] listing the 5.0 new features is not mentioning multiple new features like trie sstables, unified compaction strategy, dynamic data masking, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18786) Javadoc BigFormat
[ https://issues.apache.org/jira/browse/CASSANDRA-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758475#comment-17758475 ] Berenguer Blasi commented on CASSANDRA-18786: - I found out individual serializers and components to have javadoc already or be easy to parse the code. My main difficulty was in lifting a sensible big picture of the structure, what each component did and what role they played. I hope this javadoc eases the ramp-up to this section of the code. > Javadoc BigFormat > - > > Key: CASSANDRA-18786 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18786 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Javadoc >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x > > > This ticket intends to go through the current sstables code and javadoc the > format at high-level. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18786) Javadoc BigFormat
[ https://issues.apache.org/jira/browse/CASSANDRA-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18786: Test and Documentation Plan: Tested javadoc in IDE Status: Patch Available (was: In Progress) > Javadoc BigFormat > - > > Key: CASSANDRA-18786 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18786 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Javadoc >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x > > > This ticket intends to go through the current sstables code and javadoc the > format at high-level. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18782) Forbid analyzed SAI indexes on primary key columns
[
https://issues.apache.org/jira/browse/CASSANDRA-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18782:
--
Fix Version/s: 5.0
5.1
(was: 5.x)
(was: 5.0.x)
Since Version: 5.0-alpha1
Source Control Link:
https://github.com/apache/cassandra/commit/b265b4658e007b6943d543a11c609b7ba5fd979f
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Forbid analyzed SAI indexes on primary key columns
> --
>
> Key: CASSANDRA-18782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18782
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0, 5.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Queries using SAI indexes don't find any results when the index is on a
> primary key column, the indexing uses analysis, and the queried value is
> different to the exact value of the column. For example:
> {code:java}
> CREATE TABLE t(k int, c text, PRIMARY KEY (k, c));
> CREATE INDEX ON t(c) USING 'sai' WITH OPTIONS = { 'case_sensitive' : false };
> INSERT INTO t(k, c) VALUES (1, 'A');
> SELECT * FROM t WHERE c = 'a'; -- no results found!!!
> {code}
> This happens because the {{ClusteringIndexFilter}} for the query doesn't take
> analysis into account. Thus, when that filter is applied by
> [{{QueryController#doesNotSelect(PrimaryKey)}}|https://github.com/apache/cassandra/blob/655a2455ac29395b0a303e6ad7fc4d458b18932d/src/java/org/apache/cassandra/index/sai/plan/QueryController.java#L194-L210]
> it rejects the results that have been correctly found by the index.
> An initial approach to solve this problem could be making
> {{ClusteringIndexFilter}} aware of the index analysis options. However, this
> would be problematic for paging. The first page of the query contains a
> restriction in the clustering that requires analysis. But subsequent queries
> will contain the last seen clustering, and we don’t want analysis in that
> case.
> Another approach would be not adding a {{ClusteringIndexFilter}} to the query
> restrictions when it contains this type of restriction on columns. However,
> this approach would create a weird situation where adding an index might make
> {{ALLOW FILTERING}} necessary in queries that wouldn’t need it without the
> index. This is the opposite of the natural way of things, where more indexes
> mean less AF needed. For example:
> {code:java}
> CREATE TABLE t(k int, c1 text, c2 int, PRIMARY KEY (k, c1, c2));
> CREATE INDEX idx ON t(c1) USING 'sai' WITH OPTIONS = { 'case_sensitive' :
> false };
> SELECT * FROM t WHERE k = 0 AND c1 = 'a' AND c2 = 0 ALLOW FILTERING;
> {code}
> The query would need AF because it has been translated into an index query
> without a clustering filter, and {{c2}} is not indexed.
> I think there is an ambiguity in the query, and it's not clear if it should
> use the secondary index filter and use analysis, or it should be a primary
> index query and not use analysis. Although we can default to one or another
> interpretation, both can serve different use cases. We will probably need
> some new CQL syntax to allow users to specify whether they want to use the
> secondary index or not.
> We can work on those CQL improvements during the second phase of SAI. In the
> meantime, I think we should simply forbid the creation of analyzed indexes on
> primary key columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18782) Forbid analyzed SAI indexes on primary key columns
[
https://issues.apache.org/jira/browse/CASSANDRA-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758471#comment-17758471
]
Andres de la Peña commented on CASSANDRA-18782:
---
Committed to {{cassandra-5.0}} as
[b265b4658e007b6943d543a11c609b7ba5fd979f|https://github.com/apache/cassandra/commit/b265b4658e007b6943d543a11c609b7ba5fd979f]
and merged to
[{{trunk}}|https://github.com/apache/cassandra/commit/4226cbbec6c2ac92ed8d3834140f8ea3e3260e59]
> Forbid analyzed SAI indexes on primary key columns
> --
>
> Key: CASSANDRA-18782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18782
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Queries using SAI indexes don't find any results when the index is on a
> primary key column, the indexing uses analysis, and the queried value is
> different to the exact value of the column. For example:
> {code:java}
> CREATE TABLE t(k int, c text, PRIMARY KEY (k, c));
> CREATE INDEX ON t(c) USING 'sai' WITH OPTIONS = { 'case_sensitive' : false };
> INSERT INTO t(k, c) VALUES (1, 'A');
> SELECT * FROM t WHERE c = 'a'; -- no results found!!!
> {code}
> This happens because the {{ClusteringIndexFilter}} for the query doesn't take
> analysis into account. Thus, when that filter is applied by
> [{{QueryController#doesNotSelect(PrimaryKey)}}|https://github.com/apache/cassandra/blob/655a2455ac29395b0a303e6ad7fc4d458b18932d/src/java/org/apache/cassandra/index/sai/plan/QueryController.java#L194-L210]
> it rejects the results that have been correctly found by the index.
> An initial approach to solve this problem could be making
> {{ClusteringIndexFilter}} aware of the index analysis options. However, this
> would be problematic for paging. The first page of the query contains a
> restriction in the clustering that requires analysis. But subsequent queries
> will contain the last seen clustering, and we don’t want analysis in that
> case.
> Another approach would be not adding a {{ClusteringIndexFilter}} to the query
> restrictions when it contains this type of restriction on columns. However,
> this approach would create a weird situation where adding an index might make
> {{ALLOW FILTERING}} necessary in queries that wouldn’t need it without the
> index. This is the opposite of the natural way of things, where more indexes
> mean less AF needed. For example:
> {code:java}
> CREATE TABLE t(k int, c1 text, c2 int, PRIMARY KEY (k, c1, c2));
> CREATE INDEX idx ON t(c1) USING 'sai' WITH OPTIONS = { 'case_sensitive' :
> false };
> SELECT * FROM t WHERE k = 0 AND c1 = 'a' AND c2 = 0 ALLOW FILTERING;
> {code}
> The query would need AF because it has been translated into an index query
> without a clustering filter, and {{c2}} is not indexed.
> I think there is an ambiguity in the query, and it's not clear if it should
> use the secondary index filter and use analysis, or it should be a primary
> index query and not use analysis. Although we can default to one or another
> interpretation, both can serve different use cases. We will probably need
> some new CQL syntax to allow users to specify whether they want to use the
> secondary index or not.
> We can work on those CQL improvements during the second phase of SAI. In the
> meantime, I think we should simply forbid the creation of analyzed indexes on
> primary key columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated: Forbid SAI indexes with analysis options on primary key columns
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-5.0 by this push:
new b265b4658e Forbid SAI indexes with analysis options on primary key
columns
b265b4658e is described below
commit b265b4658e007b6943d543a11c609b7ba5fd979f
Author: Andrés de la Peña
AuthorDate: Wed Jul 19 17:40:50 2023 +0100
Forbid SAI indexes with analysis options on primary key columns
patch by Andrés de la Peña; reviewed by Caleb Rackliffe for CASSANDRA-18782
---
CHANGES.txt| 1 +
.../cassandra/index/sai/StorageAttachedIndex.java | 11 +++-
.../index/sai/analyzer/AbstractAnalyzer.java | 12 ++---
.../index/sai/analyzer/NonTokenizingOptions.java | 5
.../index/sai/cql/StorageAttachedIndexDDLTest.java | 31 ++
5 files changed, 56 insertions(+), 4 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 262a2edcb6..68515312fe 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.0-alpha2
+ * Forbid SAI indexes with analysis options on primary key columns
(CASSANDRA-18782)
Merged from 4.1:
Merged from 4.0:
Merged from 3.11:
diff --git a/src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java
b/src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java
index e8c4b53f4e..805a6b65e1 100644
--- a/src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java
+++ b/src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java
@@ -48,6 +48,7 @@ import org.slf4j.LoggerFactory;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.cql3.CQL3Type;
+import org.apache.cassandra.cql3.CqlBuilder;
import org.apache.cassandra.cql3.Operator;
import org.apache.cassandra.cql3.statements.schema.IndexTarget;
import org.apache.cassandra.db.CassandraWriteContext;
@@ -96,6 +97,9 @@ import org.apache.cassandra.utils.concurrent.OpOrder;
public class StorageAttachedIndex implements Index
{
public static final String NAME = "sai";
+
+@VisibleForTesting
+public static final String ANALYSIS_ON_KEY_COLUMNS_MESSAGE = "Analysis
options are not supported on primary key columns, but found ";
private static final Logger logger =
LoggerFactory.getLogger(StorageAttachedIndex.class);
@@ -253,7 +257,12 @@ public class StorageAttachedIndex implements Index
throw new InvalidRequestException("Unsupported type: " +
type.asCQL3Type());
}
-AbstractAnalyzer.fromOptions(type, options);
+Map analysisOptions =
AbstractAnalyzer.getAnalyzerOptions(options);
+if (target.left.isPrimaryKeyColumn() && !analysisOptions.isEmpty())
+{
+throw new InvalidRequestException(ANALYSIS_ON_KEY_COLUMNS_MESSAGE
+ new CqlBuilder().append(analysisOptions));
+}
+AbstractAnalyzer.fromOptions(type, analysisOptions);
return Collections.emptyMap();
}
diff --git
a/src/java/org/apache/cassandra/index/sai/analyzer/AbstractAnalyzer.java
b/src/java/org/apache/cassandra/index/sai/analyzer/AbstractAnalyzer.java
index 1f5e339657..da0b2a4d19 100644
--- a/src/java/org/apache/cassandra/index/sai/analyzer/AbstractAnalyzer.java
+++ b/src/java/org/apache/cassandra/index/sai/analyzer/AbstractAnalyzer.java
@@ -22,6 +22,7 @@ import java.nio.ByteBuffer;
import java.util.Iterator;
import java.util.Map;
import java.util.NoSuchElementException;
+import java.util.stream.Collectors;
import org.apache.cassandra.db.marshal.AbstractType;
import org.apache.cassandra.db.marshal.StringType;
@@ -103,9 +104,14 @@ public abstract class AbstractAnalyzer implements
Iterator
private static boolean hasNonTokenizingOptions(Map options)
{
-return options.get(NonTokenizingOptions.ASCII) != null ||
- options.containsKey(NonTokenizingOptions.CASE_SENSITIVE) ||
- options.containsKey(NonTokenizingOptions.NORMALIZE);
+return
options.keySet().stream().anyMatch(NonTokenizingOptions::hasOption);
+}
+
+public static Map getAnalyzerOptions(Map
options)
+{
+return options.entrySet().stream()
+ .filter(e -> NonTokenizingOptions.hasOption(e.getKey()))
+ .collect(Collectors.toMap(Map.Entry::getKey,
Map.Entry::getValue));
}
}
diff --git
a/src/java/org/apache/cassandra/index/sai/analyzer/NonTokenizingOptions.java
b/src/java/org/apache/cassandra/index/sai/analyzer/NonTokenizingOptions.java
index ab6485acf5..66c7740a53 100644
--- a/src/java/org/apache/cassandra/index/sai/analyzer/NonTokenizingOptions.java
+++ b/src/java/org/apache/cassandra/index/sai/analyzer/NonTokenizingOptions.java
@@ -65,6 +65,11 @@ public class NonTokenizingOptions
this.normalized = normalized;
}
+static boolean hasOption(String option)
+
[jira] [Updated] (CASSANDRA-18786) Javadoc BigFormat
[ https://issues.apache.org/jira/browse/CASSANDRA-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18786: Summary: Javadoc BigFormat (was: Javadoc sstable format) > Javadoc BigFormat > - > > Key: CASSANDRA-18786 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18786 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Javadoc >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x > > > This ticket intends to go through the current sstables code and javadoc the > format at high-level. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (77cf2185b6 -> 4226cbbec6)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 77cf2185b6 Add jmh microbenchmarks to eclipse IDE new b265b4658e Forbid SAI indexes with analysis options on primary key columns new 4226cbbec6 Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../cassandra/index/sai/StorageAttachedIndex.java | 11 +++- .../index/sai/analyzer/AbstractAnalyzer.java | 12 ++--- .../index/sai/analyzer/NonTokenizingOptions.java | 5 .../index/sai/cql/StorageAttachedIndexDDLTest.java | 31 ++ 5 files changed, 56 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4226cbbec6c2ac92ed8d3834140f8ea3e3260e59 Merge: 77cf2185b6 b265b4658e Author: Andrés de la Peña AuthorDate: Thu Aug 24 10:14:40 2023 +0100 Merge branch 'cassandra-5.0' into trunk CHANGES.txt| 1 + .../cassandra/index/sai/StorageAttachedIndex.java | 11 +++- .../index/sai/analyzer/AbstractAnalyzer.java | 12 ++--- .../index/sai/analyzer/NonTokenizingOptions.java | 5 .../index/sai/cql/StorageAttachedIndexDDLTest.java | 31 ++ 5 files changed, 56 insertions(+), 4 deletions(-) diff --cc CHANGES.txt index cfc0a9aace,68515312fe..a412b7a8d9 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,5 -1,12 +1,6 @@@ -5.0-alpha2 +5.1 +Merged from 5.0: + * Forbid SAI indexes with analysis options on primary key columns (CASSANDRA-18782) -Merged from 4.1: -Merged from 4.0: -Merged from 3.11: -Merged from 3.0: - * Make alternation of a user type validate the same way as creation of a user type does (CASSANDRA-18585) - -5.0-alpha1 * Expose bootstrap failure state via JMX and nodetool info (CASSANDRA-18749) * Reduce size of per-SSTable index components for SAI (CASSANDRA-18673) * Remove unnecessary Netty dependencies after upgrade to version 4.1.96 (CASSANDRA-18729) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (343e4f5af -> 3bc6a8391)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 343e4f5af generate docs for ce048d19 new 3bc6a8391 generate docs for ce048d19 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (343e4f5af) \ N -- N -- N refs/heads/asf-staging (3bc6a8391) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4852435 -> 4852435 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18782) Forbid analyzed SAI indexes on primary key columns
[
https://issues.apache.org/jira/browse/CASSANDRA-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758448#comment-17758448
]
Andres de la Peña commented on CASSANDRA-18782:
---
CI looks good:
* {{testLoadingIncompleteSSTable}} is CASSANDRA-18737
* {{testStartAndStopScheduledSampling}} is CASSANDRA-18065
> Forbid analyzed SAI indexes on primary key columns
> --
>
> Key: CASSANDRA-18782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18782
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Queries using SAI indexes don't find any results when the index is on a
> primary key column, the indexing uses analysis, and the queried value is
> different to the exact value of the column. For example:
> {code:java}
> CREATE TABLE t(k int, c text, PRIMARY KEY (k, c));
> CREATE INDEX ON t(c) USING 'sai' WITH OPTIONS = { 'case_sensitive' : false };
> INSERT INTO t(k, c) VALUES (1, 'A');
> SELECT * FROM t WHERE c = 'a'; -- no results found!!!
> {code}
> This happens because the {{ClusteringIndexFilter}} for the query doesn't take
> analysis into account. Thus, when that filter is applied by
> [{{QueryController#doesNotSelect(PrimaryKey)}}|https://github.com/apache/cassandra/blob/655a2455ac29395b0a303e6ad7fc4d458b18932d/src/java/org/apache/cassandra/index/sai/plan/QueryController.java#L194-L210]
> it rejects the results that have been correctly found by the index.
> An initial approach to solve this problem could be making
> {{ClusteringIndexFilter}} aware of the index analysis options. However, this
> would be problematic for paging. The first page of the query contains a
> restriction in the clustering that requires analysis. But subsequent queries
> will contain the last seen clustering, and we don’t want analysis in that
> case.
> Another approach would be not adding a {{ClusteringIndexFilter}} to the query
> restrictions when it contains this type of restriction on columns. However,
> this approach would create a weird situation where adding an index might make
> {{ALLOW FILTERING}} necessary in queries that wouldn’t need it without the
> index. This is the opposite of the natural way of things, where more indexes
> mean less AF needed. For example:
> {code:java}
> CREATE TABLE t(k int, c1 text, c2 int, PRIMARY KEY (k, c1, c2));
> CREATE INDEX idx ON t(c1) USING 'sai' WITH OPTIONS = { 'case_sensitive' :
> false };
> SELECT * FROM t WHERE k = 0 AND c1 = 'a' AND c2 = 0 ALLOW FILTERING;
> {code}
> The query would need AF because it has been translated into an index query
> without a clustering filter, and {{c2}} is not indexed.
> I think there is an ambiguity in the query, and it's not clear if it should
> use the secondary index filter and use analysis, or it should be a primary
> index query and not use analysis. Although we can default to one or another
> interpretation, both can serve different use cases. We will probably need
> some new CQL syntax to allow users to specify whether they want to use the
> secondary index or not.
> We can work on those CQL improvements during the second phase of SAI. In the
> meantime, I think we should simply forbid the creation of analyzed indexes on
> primary key columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18782) Forbid analyzed SAI indexes on primary key columns
[
https://issues.apache.org/jira/browse/CASSANDRA-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18782:
--
Status: Ready to Commit (was: Review In Progress)
> Forbid analyzed SAI indexes on primary key columns
> --
>
> Key: CASSANDRA-18782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18782
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Queries using SAI indexes don't find any results when the index is on a
> primary key column, the indexing uses analysis, and the queried value is
> different to the exact value of the column. For example:
> {code:java}
> CREATE TABLE t(k int, c text, PRIMARY KEY (k, c));
> CREATE INDEX ON t(c) USING 'sai' WITH OPTIONS = { 'case_sensitive' : false };
> INSERT INTO t(k, c) VALUES (1, 'A');
> SELECT * FROM t WHERE c = 'a'; -- no results found!!!
> {code}
> This happens because the {{ClusteringIndexFilter}} for the query doesn't take
> analysis into account. Thus, when that filter is applied by
> [{{QueryController#doesNotSelect(PrimaryKey)}}|https://github.com/apache/cassandra/blob/655a2455ac29395b0a303e6ad7fc4d458b18932d/src/java/org/apache/cassandra/index/sai/plan/QueryController.java#L194-L210]
> it rejects the results that have been correctly found by the index.
> An initial approach to solve this problem could be making
> {{ClusteringIndexFilter}} aware of the index analysis options. However, this
> would be problematic for paging. The first page of the query contains a
> restriction in the clustering that requires analysis. But subsequent queries
> will contain the last seen clustering, and we don’t want analysis in that
> case.
> Another approach would be not adding a {{ClusteringIndexFilter}} to the query
> restrictions when it contains this type of restriction on columns. However,
> this approach would create a weird situation where adding an index might make
> {{ALLOW FILTERING}} necessary in queries that wouldn’t need it without the
> index. This is the opposite of the natural way of things, where more indexes
> mean less AF needed. For example:
> {code:java}
> CREATE TABLE t(k int, c1 text, c2 int, PRIMARY KEY (k, c1, c2));
> CREATE INDEX idx ON t(c1) USING 'sai' WITH OPTIONS = { 'case_sensitive' :
> false };
> SELECT * FROM t WHERE k = 0 AND c1 = 'a' AND c2 = 0 ALLOW FILTERING;
> {code}
> The query would need AF because it has been translated into an index query
> without a clustering filter, and {{c2}} is not indexed.
> I think there is an ambiguity in the query, and it's not clear if it should
> use the secondary index filter and use analysis, or it should be a primary
> index query and not use analysis. Although we can default to one or another
> interpretation, both can serve different use cases. We will probably need
> some new CQL syntax to allow users to specify whether they want to use the
> secondary index or not.
> We can work on those CQL improvements during the second phase of SAI. In the
> meantime, I think we should simply forbid the creation of analyzed indexes on
> primary key columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18065) Flaky test org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
[
https://issues.apache.org/jira/browse/CASSANDRA-18065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758445#comment-17758445
]
Andres de la Peña commented on CASSANDRA-18065:
---
I saw it on {{trunk}} at the time of opening the ticket (22/Nov/22).
I have just hit it on 5.0:
https://app.circleci.com/pipelines/github/adelapena/cassandra/3134/workflows/53f427a0-3303-40ee-810e-69141f35174d/jobs/71095/tests
> Flaky test
> org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
> -
>
> Key: CASSANDRA-18065
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18065
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The test
> {{org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling}}
> is fails intermittently on trunk with CircleCI:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2508/workflows/92f054d7-9386-498f-9ba4-330181cd4782/jobs/24692
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2511/workflows/7aba8baa-0a6d-404a-b08b-c6a8078caca3/jobs/24706/tests
> The failure looks like:
> {code}
> junit.framework.AssertionFailedError: Scheduled sampled tasks should be
> removed expected:<[]> but was:<[*.*]>
> at
> org.apache.cassandra.tools.TopPartitionsTest.testStartAndStopScheduledSampling(TopPartitionsTest.java:116)
> {code}
> I haven't seen this failure on Butler/Jenkins yet, but it can be reproduced
> with the CircleCI multiplexer:
> {code}
> .circleci/generate.sh -m \
> -e REPEATED_UTESTS_COUNT=2000 \
> -e REPEATED_UTESTS=org.apache.cassandra.tools.TopPartitionsTest
> {code}
> It seems to fail 11 times on 2000 runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18793) Fix or remove nodetool compaction completion time estimate
[ https://issues.apache.org/jira/browse/CASSANDRA-18793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758428#comment-17758428 ] Stefan Miklosovic commented on CASSANDRA-18793: --- I see that [~cam1982] is logging the current compaction throughput as part of his debug logging in this ticket. Maybe we can just extract that, refactor a little bit and call it a day. (1) https://issues.apache.org/jira/browse/CASSANDRA-18773 > Fix or remove nodetool compaction completion time estimate > -- > > Key: CASSANDRA-18793 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18793 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Jonathan Ellis >Priority: Normal > Fix For: 5.x > > > It looks like many years ago the author of this code thought that the > compactionthroughput from the server was the current rate when it is actually > the configured maximum. So using it to estimate time remaining is not useful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18778:
--
Reviewers: Jon Meredith, Stefan Miklosovic, Stefan Miklosovic (was: Jon
Meredith)
Jon Meredith, Stefan Miklosovic, Stefan Miklosovic (was: Jon
Meredith, Stefan Miklosovic)
Status: Review In Progress (was: Patch Available)
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.x, 5.0.x
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow generating keystores with empty passwords, it
> does support reading them. It is not uncommon to use PKCS12 certificates
> generated by other tools (eg. openssl) that do not enforce passwords.
> The fix for this should be pretty straightforward, which should involve
> changing
> [FileBasedSslContextFactory.validatePassword|https://github.com/apache/cassandra/blob/cassandra-4.1.2/src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java#L128-L135]
> to only disallow null passwords (which would be consistent with previous
> versions). I will create pull requests against the relevant branches shortly.
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Failed to initialize SSL
> org.apache.cassandra.exceptions.ConfigurationException: Failed to initialize
> SSL
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1155)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:390)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:204)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:188)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:804)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:747)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875)
> Caused by: java.io.IOException: Failed to create SSL context using Native
> transport
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:405)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1150)
> ... 6 more
> Caused by: java.lang.IllegalArgumentException: 'keystore_password' must be
> specified
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.validatePassword(FileBasedSslContextFactory.java:133)
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.buildKeyManagerFactory(FileBasedSslContextFactory.java:151)
> at
> org.apache.cassandra.security.AbstractSslContextFactory.createNettySslContext(AbstractSslContextFactory.java:181)
> at
> org.apache.cassandra.security.SSLFactory.createNettySslContext(SSLFactory.java:168)
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:355)
> ... 7 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18778:
--
Test and Documentation Plan: CI
Status: Patch Available (was: In Progress)
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.x, 5.0.x
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow generating keystores with empty passwords, it
> does support reading them. It is not uncommon to use PKCS12 certificates
> generated by other tools (eg. openssl) that do not enforce passwords.
> The fix for this should be pretty straightforward, which should involve
> changing
> [FileBasedSslContextFactory.validatePassword|https://github.com/apache/cassandra/blob/cassandra-4.1.2/src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java#L128-L135]
> to only disallow null passwords (which would be consistent with previous
> versions). I will create pull requests against the relevant branches shortly.
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Failed to initialize SSL
> org.apache.cassandra.exceptions.ConfigurationException: Failed to initialize
> SSL
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1155)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:390)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:204)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:188)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:804)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:747)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875)
> Caused by: java.io.IOException: Failed to create SSL context using Native
> transport
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:405)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1150)
> ... 6 more
> Caused by: java.lang.IllegalArgumentException: 'keystore_password' must be
> specified
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.validatePassword(FileBasedSslContextFactory.java:133)
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.buildKeyManagerFactory(FileBasedSslContextFactory.java:151)
> at
> org.apache.cassandra.security.AbstractSslContextFactory.createNettySslContext(AbstractSslContextFactory.java:181)
> at
> org.apache.cassandra.security.SSLFactory.createNettySslContext(SSLFactory.java:168)
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:355)
> ... 7 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758395#comment-17758395 ] Berenguer Blasi commented on CASSANDRA-18688: - This was almost ready. Is anything pending I am blocking as a reviewer? > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18702) Add jmh microbenchmarks to eclipse IDE
[ https://issues.apache.org/jira/browse/CASSANDRA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18702: Fix Version/s: 5.0.x (was: 5.x) Since Version: 5.0 Source Control Link: https://github.com/apache/cassandra/commit/77cf2185b6c6261f3a6c3a2e3c8047b028190e8c Resolution: Fixed Status: Resolved (was: Ready to Commit) > Add jmh microbenchmarks to eclipse IDE > -- > > Key: CASSANDRA-18702 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18702 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x > > > Currently jmh tests are not being picked up by the Eclipse IDE. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18702) Add jmh microbenchmarks to eclipse IDE
[ https://issues.apache.org/jira/browse/CASSANDRA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18702: Status: Ready to Commit (was: Review In Progress) > Add jmh microbenchmarks to eclipse IDE > -- > > Key: CASSANDRA-18702 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18702 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.x > > > Currently jmh tests are not being picked up by the Eclipse IDE. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Add jmh microbenchmarks to eclipse IDE
This is an automated email from the ASF dual-hosted git repository. bereng pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 77cf2185b6 Add jmh microbenchmarks to eclipse IDE 77cf2185b6 is described below commit 77cf2185b6c6261f3a6c3a2e3c8047b028190e8c Author: Bereng AuthorDate: Fri Jul 28 08:05:46 2023 +0200 Add jmh microbenchmarks to eclipse IDE patch by Berenguer Blasi; reviewed by Benjamin Lerer, Maxim Muzafarov for CASSANDRA-18702 --- build.xml | 4 ide/idea-iml-file.xml | 1 + 2 files changed, 5 insertions(+) diff --git a/build.xml b/build.xml index bc9d6eedc5..7c9c68555f 100644 --- a/build.xml +++ b/build.xml @@ -1978,6 +1978,10 @@ + + + + diff --git a/ide/idea-iml-file.xml b/ide/idea-iml-file.xml index e6860f8e0b..01c071a728 100644 --- a/ide/idea-iml-file.xml +++ b/ide/idea-iml-file.xml @@ -35,6 +35,7 @@ + - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18789) Update commons-lang3 to 3.13.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758381#comment-17758381 ] Berenguer Blasi commented on CASSANDRA-18789: - If we're not being religious about his, which is what I gather from the ML, I think we can go ahead with 5.0. > Update commons-lang3 to 3.13.0 > -- > > Key: CASSANDRA-18789 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18789 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Low > Fix For: 5.0.x, 5.x > > > It seems we are on a version that was testing up to Java 11 - 3.11.0 > In the latest one the community goes up to JDK21 so I think it is good to > update, hopefully also on cassandra-5.0 > Below are the release notes: > https://commons.apache.org/proper/commons-lang/changes-report.html#a3.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
