[jira] [Updated] (CASSANDRA-18361) Test Failure: secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index
[
https://issues.apache.org/jira/browse/CASSANDRA-18361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18361:
--
Reviewers: Andres de la Peña
> Test Failure:
> secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index
>
>
> Key: CASSANDRA-18361
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18361
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The Python dtest
> {{secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index}}
> is flaky, at least for trunk:
> *
> https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/secondary_indexes_test/TestSecondaryIndexes/test_failing_manual_rebuild_index
> *
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1501/testReport/dtest.secondary_indexes_test/TestSecondaryIndexes/test_failing_manual_rebuild_index/
> {code}
> Error Message
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node1] 'ERROR [Reference-Reaper] 2023-03-23
> 00:23:43,597 Ref.java:237 - LEAK DETECTED: a reference (class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db)
> to class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db
> was not released before the reference was garbage collected']"
> Stacktrace
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[node1] 'ERROR [Reference-Reaper] 2023-03-23 00:23:43,597 Ref.java:237 -
> LEAK DETECTED: a reference (class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db)
> to class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db
> was not released before the reference was garbage collected']
> {code}
> The failure can be reproduced in CircleCI:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2732/workflows/829434ab-2d1a-4e1c-8c7f-42449fcfda22
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_DTESTS_COUNT=200 \
> -e
> REPEATED_DTESTS=secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18884) Test failure: org.apache.cassandra.db.compaction.LongCompactionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18884: -- Fix Version/s: 5.0 5.1 (was: 5.x) (was: 5.0.x) Since Version: 5.0-alpha1 Source Control Link: https://github.com/apache/cassandra/commit/6de90bf75c2a5138f4ed72ff6ed588dc180e8a9d Resolution: Fixed Status: Resolved (was: Ready to Commit) > Test failure: org.apache.cassandra.db.compaction.LongCompactionsTest > - > > Key: CASSANDRA-18884 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18884 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Stefan Miklosovic >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 5.0, 5.1 > > Time Spent: 40m > Remaining Estimate: 0h > > org.apache.cassandra.db.compaction.LongCompactionsTest in "long" tests is > broken. This seems to be a regression after CASSANDRA-18737 > If I checkout the code one merge before (CASSANDRA-18871), these tests do not > fail there. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18884) Test failure: org.apache.cassandra.db.compaction.LongCompactionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18884: -- Status: Ready to Commit (was: Review In Progress) > Test failure: org.apache.cassandra.db.compaction.LongCompactionsTest > - > > Key: CASSANDRA-18884 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18884 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Stefan Miklosovic >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > org.apache.cassandra.db.compaction.LongCompactionsTest in "long" tests is > broken. This seems to be a regression after CASSANDRA-18737 > If I checkout the code one merge before (CASSANDRA-18871), these tests do not > fail there. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (164fa7949d -> 6de90bf75c)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 164fa7949d Add support for repair coordinator to retry messages that timeout add 6de90bf75c Fix LongCompactionTest No new revisions were added by this update. Summary of changes: .../apache/cassandra/io/sstable/SSTableUtils.java | 26 +++--- 1 file changed, 8 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d1158bfd8ea6b05e008c1af538ef622d3f2ae0d0 Merge: c96185f188 6de90bf75c Author: Jacek Lewandowski AuthorDate: Thu Sep 28 08:01:12 2023 +0200 Merge branch 'cassandra-5.0' into trunk * cassandra-5.0: Fix LongCompactionTest .../apache/cassandra/io/sstable/SSTableUtils.java | 26 +++--- 1 file changed, 8 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (c96185f188 -> d1158bfd8e)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from c96185f188 Merge branch 'cassandra-5.0' into trunk add 6de90bf75c Fix LongCompactionTest new d1158bfd8e Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/io/sstable/SSTableUtils.java | 26 +++--- 1 file changed, 8 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18707) Test failure: junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
[
https://issues.apache.org/jira/browse/CASSANDRA-18707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769894#comment-17769894
]
Berenguer Blasi commented on CASSANDRA-18707:
-
bq. 4.0 is a stable branch where we do not see many changes
Correct. The problem is that we have no insight as to what is happening in
jenkins at the time. It might hit it as well
bq. we see this timeout with a specific test, and not with many, which makes it
suspicious.
I disagree here. I have seen schema changes many times go over 60s in jenkins.
That was a common scenario when we were on the 4.0 flaky fixing frenzy and
that's why at the time I did already propose to raise timeouts already. That
was declined and I found myself debugging through logs the same problem 2 or 3
extra times. This is just another one.
bq. not waste time from scratch
Correct. But you you just have an indication of what have happened. You still
have to wade through logs to confirm it is indeed the same scenario.
bq. In Python DTests we opted to raise the timeout
Correct and I think it was a good move. I will change the 140s to 120s for
consistency and OCD lol
Thanks I'll put PRs up
> Test failure:
> junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
>
>
>
> Key: CASSANDRA-18707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18707
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: TESTS-TestSuites.xml.xz
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1650/testReport/junit.framework/TestSuite/org_apache_cassandra_distributed_test_CASMultiDCTest__jdk11/]
> h3.
> {code:java}
> Error Message
> Schema agreement not reached. Schema versions of the instances:
> [ef1c8e05-a06d-388d-a46d-53cc22a94762, 6c386108-1805-3985-b48e-8016012a0207,
> 6c386108-1805-3985-b48e-8016012a0207, ef1c8e05-a06d-388d-a46d-53cc22a94762]
> Stacktrace
> java.lang.IllegalStateException: Schema agreement not reached. Schema
> versions of the instances: [ef1c8e05-a06d-388d-a46d-53cc22a94762,
> 6c386108-1805-3985-b48e-8016012a0207, 6c386108-1805-3985-b48e-8016012a0207,
> ef1c8e05-a06d-388d-a46d-53cc22a94762] at
> org.apache.cassandra.distributed.impl.AbstractCluster$ChangeMonitor.waitForCompletion(AbstractCluster.java:907)
> at
> org.apache.cassandra.distributed.impl.AbstractCluster.lambda$schemaChange$8(AbstractCluster.java:836)
> at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
> org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
> org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18889) DDM's mask_default function should support vectors
[
https://issues.apache.org/jira/browse/CASSANDRA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-18889:
Reviewers: Maxwell Guo
> DDM's mask_default function should support vectors
> --
>
> Key: CASSANDRA-18889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Dynamic Data Masking, Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> DDM uses the CQL function {{mask_default}} as the default masking function.
> This function supports all CQL data types except for {{vector}}, which didn't
> exist when DDM was added.
> We should make {{mask_default}} (and thereof default masking) work with
> vector columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18876) The vector data type shouldn't support empty value
[ https://issues.apache.org/jira/browse/CASSANDRA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxwell Guo updated CASSANDRA-18876: Reviewers: David Capwell, Maxwell Guo (was: David Capwell) > The vector data type shouldn't support empty value > -- > > Key: CASSANDRA-18876 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18876 > Project: Cassandra > Issue Type: Bug > Components: Feature/Vector Search >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on [the mail > list|https://lists.apache.org/thread/qq0jkm6rlkd2slfmhgz7om14tbpys891], the > vector data type shouldn't allow empty values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18798) Appending to list in Accord transactions uses insertion timestamp
[
https://issues.apache.org/jira/browse/CASSANDRA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769861#comment-17769861
]
Henrik Ingo edited comment on CASSANDRA-18798 at 9/28/23 1:05 AM:
--
[~kijanowski] When you wake up, can you try this:
{code}
diff --git
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
index 1be3d54558..3b0d7b78cc 100644
--- a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
@@ -230,7 +230,7 @@ public class UnfilteredRowIteratorSerializer
final SerializationHeader sHeader = header.sHeader;
return new AbstractUnfilteredRowIterator(metadata, header.key,
header.partitionDeletion, sHeader.columns(), header.staticRow,
header.isReversed, sHeader.stats())
{
-private final Row.Builder builder = BTreeRow.sortedBuilder();
+private final Row.Builder builder = BTreeRow.unsortedBuilder();
protected Unfiltered computeNext()
{
diff --git a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
index d528a70a18..22bdbc745b 100644
--- a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
@@ -455,7 +455,7 @@ public class UnfilteredSerializer
throws IOException
{
// It wouldn't be wrong per-se to use an unsorted builder, but it
would be inefficient so make sure we don't do it by mistake
-assert builder.isSorted();
+//assert builder.isSorted();
int flags = in.readUnsignedByte();
if (isEndOfPartition(flags))
{code}
Note the funny naming:
sortedBuilder = data is already sorted, builder not sorting
unsortedBuilder = data is not sorted, builder makes it sorted
was (Author: henrik.ingo):
[~kijanowski] When you wake up, can you try this:
{code}
diff --git
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
index 1be3d54558..3b0d7b78cc 100644
--- a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
@@ -230,7 +230,7 @@ public class UnfilteredRowIteratorSerializer
final SerializationHeader sHeader = header.sHeader;
return new AbstractUnfilteredRowIterator(metadata, header.key,
header.partitionDeletion, sHeader.columns(), header.staticRow,
header.isReversed, sHeader.stats())
{
-private final Row.Builder builder = BTreeRow.sortedBuilder();
+private final Row.Builder builder = BTreeRow.unsortedBuilder();
protected Unfiltered computeNext()
{
diff --git a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
index d528a70a18..22bdbc745b 100644
--- a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
@@ -455,7 +455,7 @@ public class UnfilteredSerializer
throws IOException
{
// It wouldn't be wrong per-se to use an unsorted builder, but it
would be inefficient so make sure we don't do it by mistake
-assert builder.isSorted();
+//assert builder.isSorted();
int flags = in.readUnsignedByte();
if (isEndOfPartition(flags))
{code}
> Appending to list in Accord transactions uses insertion timestamp
> -
>
> Key: CASSANDRA-18798
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18798
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: Jaroslaw Kijanowski
>Assignee: Henrik Ingo
>Priority: Normal
> Attachments: image-2023-09-26-20-05-25-846.png
>
>
> Given the following schema:
> {code:java}
> CREATE KEYSPACE IF NOT EXISTS accord WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 3};
> CREATE TABLE IF NOT EXISTS accord.list_append(id int PRIMARY KEY,contents
> LIST);
> TRUNCATE accord.list_append;{code}
> And the following two possible queries executed by 10 threads in parallel:
> {code:java}
> BEGIN TRANSACTION
> LET row = (SELECT * FROM list_append WHERE id = ?);
> SELECT row.contents;
> COMMIT TRANSACTION;"
> BEGIN TRANSACTION
> UPDATE list_append SET contents += ? WHERE id = ?;
> COMMIT TRANSACTION;"
> {code}
> there seems to be an issue with transaction guarantees. Here's
[jira] [Comment Edited] (CASSANDRA-18798) Appending to list in Accord transactions uses insertion timestamp
[
https://issues.apache.org/jira/browse/CASSANDRA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769861#comment-17769861
]
Henrik Ingo edited comment on CASSANDRA-18798 at 9/28/23 1:03 AM:
--
[~kijanowski] When you wake up, can you try this:
{code}
diff --git
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
index 1be3d54558..3b0d7b78cc 100644
--- a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
@@ -230,7 +230,7 @@ public class UnfilteredRowIteratorSerializer
final SerializationHeader sHeader = header.sHeader;
return new AbstractUnfilteredRowIterator(metadata, header.key,
header.partitionDeletion, sHeader.columns(), header.staticRow,
header.isReversed, sHeader.stats())
{
-private final Row.Builder builder = BTreeRow.sortedBuilder();
+private final Row.Builder builder = BTreeRow.unsortedBuilder();
protected Unfiltered computeNext()
{
diff --git a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
index d528a70a18..22bdbc745b 100644
--- a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
@@ -455,7 +455,7 @@ public class UnfilteredSerializer
throws IOException
{
// It wouldn't be wrong per-se to use an unsorted builder, but it
would be inefficient so make sure we don't do it by mistake
-assert builder.isSorted();
+//assert builder.isSorted();
int flags = in.readUnsignedByte();
if (isEndOfPartition(flags))
{code}
was (Author: henrik.ingo):
[~kijanowski] When you wake up, can you try this:
{{diff --git
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java }}
{{index 1be3d54558..3b0d7b78cc 100644 }}
{{---
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java }}
{{+++
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java }}
{{@@ -230,7 +230,7 @@ public class UnfilteredRowIteratorSerializer }}
{{final SerializationHeader sHeader = header.sHeader; }}
{{return new AbstractUnfilteredRowIterator(metadata, header.key,
header.partitionDeletion, sHeader.columns(), header.staticRow,
header.isReversed, sHeader.stats()) }}
{{{ }}
{{- private final Row.Builder builder = BTreeRow.sortedBuilder(); }}
{{+ private final Row.Builder builder = BTreeRow.unsortedBuilder();
}}
{{ }}
{{protected Unfiltered computeNext() }}
{{{ }}
{{diff --git a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java }}
{{index d528a70a18..22bdbc745b 100644 }}
{{--- a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java }}
{{+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java }}
{{@@ -455,7 +455,7 @@ public class UnfilteredSerializer }}
{{throws IOException }}
{{{ }}
{{// It wouldn't be wrong per-se to use an unsorted builder, but it
would be inefficient so make sure we don't do it by mistake }}
{{- assert builder.isSorted(); }}
{{+ //assert builder.isSorted(); }}
{{ }}
{{int flags = in.readUnsignedByte(); }}
{{if (isEndOfPartition(flags))}}
{{}}
> Appending to list in Accord transactions uses insertion timestamp
> -
>
> Key: CASSANDRA-18798
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18798
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: Jaroslaw Kijanowski
>Assignee: Henrik Ingo
>Priority: Normal
> Attachments: image-2023-09-26-20-05-25-846.png
>
>
> Given the following schema:
> {code:java}
> CREATE KEYSPACE IF NOT EXISTS accord WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 3};
> CREATE TABLE IF NOT EXISTS accord.list_append(id int PRIMARY KEY,contents
> LIST);
> TRUNCATE accord.list_append;{code}
> And the following two possible queries executed by 10 threads in parallel:
> {code:java}
> BEGIN TRANSACTION
> LET row = (SELECT * FROM list_append WHERE id = ?);
> SELECT row.contents;
> COMMIT TRANSACTION;"
> BEGIN TRANSACTION
> UPDATE list_append SET contents += ? WHERE id = ?;
> COMMIT TRANSACTION;"
> {code}
> there seems to be an issue with transaction guarantees. Here's an excerpt in
> the edn format from
[jira] [Commented] (CASSANDRA-18798) Appending to list in Accord transactions uses insertion timestamp
[
https://issues.apache.org/jira/browse/CASSANDRA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769861#comment-17769861
]
Henrik Ingo commented on CASSANDRA-18798:
-
[~kijanowski] When you wake up, can you try this:
{{diff --git
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java }}
{{index 1be3d54558..3b0d7b78cc 100644 }}
{{---
a/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java }}
{{+++
b/src/java/org/apache/cassandra/db/rows/UnfilteredRowIteratorSerializer.java }}
{{@@ -230,7 +230,7 @@ public class UnfilteredRowIteratorSerializer }}
{{final SerializationHeader sHeader = header.sHeader; }}
{{return new AbstractUnfilteredRowIterator(metadata, header.key,
header.partitionDeletion, sHeader.columns(), header.staticRow,
header.isReversed, sHeader.stats()) }}
{{{ }}
{{- private final Row.Builder builder = BTreeRow.sortedBuilder(); }}
{{+ private final Row.Builder builder = BTreeRow.unsortedBuilder();
}}
{{ }}
{{protected Unfiltered computeNext() }}
{{{ }}
{{diff --git a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java }}
{{index d528a70a18..22bdbc745b 100644 }}
{{--- a/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java }}
{{+++ b/src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java }}
{{@@ -455,7 +455,7 @@ public class UnfilteredSerializer }}
{{throws IOException }}
{{{ }}
{{// It wouldn't be wrong per-se to use an unsorted builder, but it
would be inefficient so make sure we don't do it by mistake }}
{{- assert builder.isSorted(); }}
{{+ //assert builder.isSorted(); }}
{{ }}
{{int flags = in.readUnsignedByte(); }}
{{if (isEndOfPartition(flags))}}
{{}}
> Appending to list in Accord transactions uses insertion timestamp
> -
>
> Key: CASSANDRA-18798
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18798
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: Jaroslaw Kijanowski
>Assignee: Henrik Ingo
>Priority: Normal
> Attachments: image-2023-09-26-20-05-25-846.png
>
>
> Given the following schema:
> {code:java}
> CREATE KEYSPACE IF NOT EXISTS accord WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 3};
> CREATE TABLE IF NOT EXISTS accord.list_append(id int PRIMARY KEY,contents
> LIST);
> TRUNCATE accord.list_append;{code}
> And the following two possible queries executed by 10 threads in parallel:
> {code:java}
> BEGIN TRANSACTION
> LET row = (SELECT * FROM list_append WHERE id = ?);
> SELECT row.contents;
> COMMIT TRANSACTION;"
> BEGIN TRANSACTION
> UPDATE list_append SET contents += ? WHERE id = ?;
> COMMIT TRANSACTION;"
> {code}
> there seems to be an issue with transaction guarantees. Here's an excerpt in
> the edn format from a test.
> {code:java}
> {:type :invoke :process 8 :value [[:append 5 352]] :tid 3 :n 52
> :time 1692607285967116627}
> {:type :invoke :process 9 :value [[:r 5 nil]] :tid 1 :n 54
> :time 1692607286078732473}
> {:type :invoke :process 6 :value [[:append 5 553]] :tid 5 :n 53
> :time 1692607286133833428}
> {:type :invoke :process 7 :value [[:append 5 455]] :tid 4 :n 55
> :time 1692607286149702511}
> {:type :ok :process 8 :value [[:append 5 352]] :tid 3 :n 52
> :time 1692607286156314099}
> {:type :invoke :process 5 :value [[:r 5 nil]] :tid 9 :n 52
> :time 1692607286167090389}
> {:type :ok :process 9 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352]]] :tid 1 :n 54 :time 1692607286168657534}
> {:type :invoke :process 1 :value [[:r 5 nil]] :tid 0 :n 51
> :time 1692607286201762938}
> {:type :ok :process 7 :value [[:append 5 455]] :tid 4 :n 55
> :time 1692607286245571513}
> {:type :invoke :process 7 :value [[:r 5 nil]] :tid 4 :n 56
> :time 1692607286245655775}
> {:type :ok :process 5 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 455]]] :tid 9 :n 52 :time 1692607286253928906}
> {:type :invoke :process 5 :value [[:r 5 nil]] :tid 9 :n 53
> :time 1692607286254095215}
> {:type :ok :process 6 :value
[cassandra-website] branch asf-staging updated (1c29e1743 -> 819a63098)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1c29e1743 generate docs for bc8bfc13 new 819a63098 generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1c29e1743) \ N -- N -- N refs/heads/asf-staging (819a63098) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../managing/configuration/cass_yaml_file.html | 19 ++- .../managing/configuration/cass_yaml_file.html | 19 ++- .../managing/configuration/cass_yaml_file.html | 19 ++- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4881412 -> 4881412 bytes 5 files changed, 55 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18816: -- Fix Version/s: 5.0-alpha2 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/164fa7949d1437528363465d14ed20898f1daa9e Resolution: Fixed Status: Resolved (was: Ready to Commit) > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0-alpha2 > > Time Spent: 13h 10m > Remaining Estimate: 0h > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit c96185f18878abcb47ec49f3daa87796007f955f
Merge: a0eecdb996 164fa7949d
Author: David Capwell
AuthorDate: Wed Sep 27 16:21:37 2023 -0700
Merge branch 'cassandra-5.0' into trunk
CHANGES.txt|1 +
conf/cassandra.yaml| 11 +
.../org/apache/cassandra/concurrent/Stage.java |6 +
src/java/org/apache/cassandra/config/Config.java |2 +
.../cassandra/config/DatabaseDescriptor.java | 11 +
.../org/apache/cassandra/config/RepairConfig.java | 24 +
.../apache/cassandra/config/RepairRetrySpec.java | 43 +
.../org/apache/cassandra/config/RetrySpec.java | 165 +++
.../org/apache/cassandra/cql3/QueryProcessor.java |2 +-
.../org/apache/cassandra/db/ColumnFamilyStore.java |2 +-
src/java/org/apache/cassandra/db/Keyspace.java |2 +-
src/java/org/apache/cassandra/db/ReadCommand.java |4 +-
.../cassandra/db/compaction/CompactionManager.java |5 +-
.../db/compaction/ICompactionManager.java | 24 +
.../db/compaction/PendingRepairManager.java|4 +-
.../db/repair/CassandraTableRepairManager.java | 12 +-
.../db/repair/CassandraValidationIterator.java | 13 +-
.../cassandra/db/repair/PendingAntiCompaction.java |2 +-
.../cassandra/db/virtual/LocalRepairTables.java| 19 +-
.../cassandra/exceptions/RepairException.java | 10 +-
src/java/org/apache/cassandra/gms/Gossiper.java| 12 +-
src/java/org/apache/cassandra/gms/IGossiper.java | 39 +
src/java/org/apache/cassandra/net/Message.java | 12 +-
.../org/apache/cassandra/net/MessageDelivery.java | 31 +
.../org/apache/cassandra/net/MessagingService.java | 72 +-
src/java/org/apache/cassandra/net/Verb.java| 43 +-
.../cassandra/repair/AbstractRepairTask.java | 44 +-
.../cassandra/repair/AsymmetricRemoteSyncTask.java |7 +-
.../cassandra/repair/IValidationManager.java | 28 +
.../cassandra/repair/IncrementalRepairTask.java| 17 +-
.../org/apache/cassandra/repair/LocalSyncTask.java | 12 +-
.../apache/cassandra/repair/NormalRepairTask.java |7 +-
.../apache/cassandra/repair/PreviewRepairTask.java |7 +-
...{RepairRunnable.java => RepairCoordinator.java} | 162 +--
.../org/apache/cassandra/repair/RepairJob.java | 76 +-
.../org/apache/cassandra/repair/RepairJobDesc.java | 11 +-
.../cassandra/repair/RepairMessageVerbHandler.java | 250 +++-
.../org/apache/cassandra/repair/RepairSession.java | 151 ++-
.../org/apache/cassandra/repair/SharedContext.java | 165 +++
.../org/apache/cassandra/repair/SnapshotTask.java | 11 +-
.../apache/cassandra/repair/StreamExecutor.java| 27 +
.../cassandra/repair/StreamingRepairTask.java | 24 +-
.../cassandra/repair/SymmetricRemoteSyncTask.java |7 +-
src/java/org/apache/cassandra/repair/SyncTask.java | 18 +-
.../apache/cassandra/repair/ValidationManager.java | 16 +-
.../apache/cassandra/repair/ValidationTask.java| 61 +-
.../org/apache/cassandra/repair/Validator.java | 25 +-
.../repair/consistent/ConsistentSession.java |9 +
.../repair/consistent/CoordinatorSession.java | 38 +-
.../repair/consistent/CoordinatorSessions.java | 13 +-
.../cassandra/repair/consistent/LocalSession.java | 13 +-
.../cassandra/repair/consistent/LocalSessions.java | 36 +-
.../cassandra/repair/messages/CleanupMessage.java |6 +
.../cassandra/repair/messages/PrepareMessage.java |6 +
.../cassandra/repair/messages/RepairMessage.java | 179 ++-
.../repair/state/AbstractCompletable.java | 28 +-
.../cassandra/repair/state/AbstractState.java | 69 +-
.../apache/cassandra/repair/state/Completable.java | 33 +-
.../cassandra/repair/state/CoordinatorState.java | 41 +-
.../apache/cassandra/repair/state/JobState.java|5 +-
.../cassandra/repair/state/ParticipateState.java | 160 ++-
.../cassandra/repair/state/SessionState.java | 21 +-
.../apache/cassandra/repair/state/SyncState.java | 85 ++
.../cassandra/repair/state/ValidationState.java| 13 +-
src/java/org/apache/cassandra/schema/Tables.java |2 +-
.../cassandra/service/ActiveRepairService.java | 270 ++--
.../apache/cassandra/service/CassandraDaemon.java |2 +-
.../apache/cassandra/service/StorageService.java | 24 +-
.../cassandra/service/StorageServiceMBean.java |2 +-
.../apache/cassandra/streaming/PreviewKind.java|2 +-
.../org/apache/cassandra/streaming/StreamPlan.java | 16 +
.../apache/cassandra/streaming/StreamSession.java |6 +-
.../apache/cassandra/tools/nodetool/Repair.java| 85 +-
src/java/org/apache/cassandra/utils/Backoff.java | 96 ++
src/java/org/apache/cassandra/utils/Clock.java |
[cassandra] branch trunk updated (a0eecdb996 -> c96185f188)
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from a0eecdb996 Merge branch 'cassandra-5.0' into trunk
new 164fa7949d Add support for repair coordinator to retry messages that
timeout
new c96185f188 Merge branch 'cassandra-5.0' into trunk
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt|1 +
conf/cassandra.yaml| 11 +
.../org/apache/cassandra/concurrent/Stage.java |6 +
src/java/org/apache/cassandra/config/Config.java |2 +
.../cassandra/config/DatabaseDescriptor.java | 11 +
.../org/apache/cassandra/config/RepairConfig.java | 24 +
.../apache/cassandra/config/RepairRetrySpec.java | 43 +
.../org/apache/cassandra/config/RetrySpec.java | 165 +++
.../org/apache/cassandra/cql3/QueryProcessor.java |2 +-
.../org/apache/cassandra/db/ColumnFamilyStore.java |2 +-
src/java/org/apache/cassandra/db/Keyspace.java |2 +-
src/java/org/apache/cassandra/db/ReadCommand.java |4 +-
.../cassandra/db/compaction/CompactionManager.java |5 +-
.../db/compaction/ICompactionManager.java | 24 +
.../db/compaction/PendingRepairManager.java|4 +-
.../db/repair/CassandraTableRepairManager.java | 12 +-
.../db/repair/CassandraValidationIterator.java | 13 +-
.../cassandra/db/repair/PendingAntiCompaction.java |2 +-
.../cassandra/db/virtual/LocalRepairTables.java| 19 +-
.../cassandra/exceptions/RepairException.java | 10 +-
src/java/org/apache/cassandra/gms/Gossiper.java| 12 +-
src/java/org/apache/cassandra/gms/IGossiper.java | 39 +
src/java/org/apache/cassandra/net/Message.java | 12 +-
.../org/apache/cassandra/net/MessageDelivery.java | 31 +
.../org/apache/cassandra/net/MessagingService.java | 72 +-
src/java/org/apache/cassandra/net/Verb.java| 43 +-
.../cassandra/repair/AbstractRepairTask.java | 44 +-
.../cassandra/repair/AsymmetricRemoteSyncTask.java |7 +-
.../cassandra/repair/IValidationManager.java | 28 +
.../cassandra/repair/IncrementalRepairTask.java| 17 +-
.../org/apache/cassandra/repair/LocalSyncTask.java | 12 +-
.../apache/cassandra/repair/NormalRepairTask.java |7 +-
.../apache/cassandra/repair/PreviewRepairTask.java |7 +-
...{RepairRunnable.java => RepairCoordinator.java} | 162 +--
.../org/apache/cassandra/repair/RepairJob.java | 76 +-
.../org/apache/cassandra/repair/RepairJobDesc.java | 11 +-
.../cassandra/repair/RepairMessageVerbHandler.java | 250 +++-
.../org/apache/cassandra/repair/RepairSession.java | 151 ++-
.../org/apache/cassandra/repair/SharedContext.java | 165 +++
.../org/apache/cassandra/repair/SnapshotTask.java | 11 +-
.../apache/cassandra/repair/StreamExecutor.java| 27 +
.../cassandra/repair/StreamingRepairTask.java | 24 +-
.../cassandra/repair/SymmetricRemoteSyncTask.java |7 +-
src/java/org/apache/cassandra/repair/SyncTask.java | 18 +-
.../apache/cassandra/repair/ValidationManager.java | 16 +-
.../apache/cassandra/repair/ValidationTask.java| 61 +-
.../org/apache/cassandra/repair/Validator.java | 25 +-
.../repair/consistent/ConsistentSession.java |9 +
.../repair/consistent/CoordinatorSession.java | 38 +-
.../repair/consistent/CoordinatorSessions.java | 13 +-
.../cassandra/repair/consistent/LocalSession.java | 13 +-
.../cassandra/repair/consistent/LocalSessions.java | 36 +-
.../cassandra/repair/messages/CleanupMessage.java |6 +
.../cassandra/repair/messages/PrepareMessage.java |6 +
.../cassandra/repair/messages/RepairMessage.java | 179 ++-
.../repair/state/AbstractCompletable.java | 28 +-
.../cassandra/repair/state/AbstractState.java | 69 +-
.../apache/cassandra/repair/state/Completable.java | 33 +-
.../cassandra/repair/state/CoordinatorState.java | 41 +-
.../apache/cassandra/repair/state/JobState.java|5 +-
.../cassandra/repair/state/ParticipateState.java | 160 ++-
.../cassandra/repair/state/SessionState.java | 21 +-
.../apache/cassandra/repair/state/SyncState.java | 85 ++
.../cassandra/repair/state/ValidationState.java| 13 +-
src/java/org/apache/cassandra/schema/Tables.java |2 +-
.../cassandra/service/ActiveRepairService.java | 270 ++--
.../apache/cassandra/service/CassandraDaemon.java |2 +-
.../apache/cassandra/service/StorageService.java | 24 +-
.../cassandra/service/StorageServiceMBean.java |2 +-
.../apache/cassandra/streaming/PreviewKind.java|2 +-
.../org/apache/cassandra/st
[jira] [Updated] (CASSANDRA-18885) Remove paxos uncommitted data for dropped tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18885: Test and Documentation Plan: circle Status: Patch Available (was: Open) | [4.1|https://github.com/bdeggleston/cassandra/tree/C18885-dropped-table-paxos-data-4.1] | [circle|https://app.circleci.com/pipelines/github/bdeggleston/cassandra?branch=C18885-dropped-table-paxos-data-4.1] | | [5.0|https://github.com/bdeggleston/cassandra/tree/C18885-dropped-table-paxos-data-5.0] | [circle|https://app.circleci.com/pipelines/github/bdeggleston/cassandra?branch=C18885-dropped-table-paxos-data-5.0] | | [trunk|https://github.com/bdeggleston/cassandra/tree/C18885-dropped-table-paxos-data-trunk] | [circle|https://app.circleci.com/pipelines/github/bdeggleston/cassandra?branch=C18885-dropped-table-paxos-data-trunk] | > Remove paxos uncommitted data for dropped tables > > > Key: CASSANDRA-18885 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18885 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Lightweight Transactions >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.1.x > > > Paxos uncommitted data is not removed once a table has been dropped -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18889) DDM's mask_default function should support vectors
[
https://issues.apache.org/jira/browse/CASSANDRA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18889:
--
Test and Documentation Plan:
||PR||CI||
|[5.0
|https://github.com/apache/cassandra/pull/2747]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/4e603e90-3d03-4b3c-ac64-bae8cac93e67]
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/30fc83cf-ad2f-4f0b-bad9-1be31fba0cad]|
Status: Patch Available (was: In Progress)
> DDM's mask_default function should support vectors
> --
>
> Key: CASSANDRA-18889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Dynamic Data Masking, Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DDM uses the CQL function {{mask_default}} as the default masking function.
> This function supports all CQL data types except for {{vector}}, which didn't
> exist when DDM was added.
> We should make {{mask_default}} (and thereof default masking) work with
> vector columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18889) DDM's mask_default function should support vectors
[
https://issues.apache.org/jira/browse/CASSANDRA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18889:
--
Fix Version/s: 5.0.x
5.x
> DDM's mask_default function should support vectors
> --
>
> Key: CASSANDRA-18889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Dynamic Data Masking, Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DDM uses the CQL function {{mask_default}} as the default masking function.
> This function supports all CQL data types except for {{vector}}, which didn't
> exist when DDM was added.
> We should make {{mask_default}} (and thereof default masking) work with
> vector columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769833#comment-17769833 ] Brandon Williams commented on CASSANDRA-18742: -- The upgrade tests passed, which is a little worrisome given Maxim's point. > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17092) CEP-15: Accord Beta
[ https://issues.apache.org/jira/browse/CASSANDRA-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769827#comment-17769827 ] Caleb Rackliffe commented on CASSANDRA-17092: - CC [~jlewandowski] > CEP-15: Accord Beta > --- > > Key: CASSANDRA-17092 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17092 > Project: Cassandra > Issue Type: Epic > Components: Accord >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17092) CEP-15: Accord Beta
[
https://issues.apache.org/jira/browse/CASSANDRA-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769824#comment-17769824
]
Caleb Rackliffe edited comment on CASSANDRA-17092 at 9/27/23 9:41 PM:
--
After a long pause, during which a significant amount of unmerged work had
accumulated, I've picked back up the Accord/TCM rebase. [This
PR|https://github.com/apache/cassandra/pull/2227] now contains a branch that
a.) is fully up-to-date w/ {{cep-21-tcm}} and b.) has pulled in all publicly
uncommitted Accord work. Once we have [reasonably clean
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/769/workflows/797ebdb7-7dfe-49c4-9bcc-77175fb7d6d7]
and {{cep-15-accord}} is reset to this new branch, {{cep-15-accord}} will be
able to accept new work, including CASSANDRA-18355 and CASSANDRA-18580.
was (Author: maedhroz):
After a long pause, during which a significant amount of unmerged work had
accumulated, I've picked back up the Accord/TCM rebase. [This
PR|https://github.com/apache/cassandra/pull/2227] now contains a branch that
a.) is fully up-to-date w/ {{cep-21-tcm}} and b.) has pulled in all publicly
uncommitted Accord work. Once we have [reasonably clean
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/768/workflows/d2c10a30-c256-4192-9947-b73a882ac334]
and {{cep-15-accord}} is reset to this new branch, {{cep-15-accord}} will be
able to accept new work, including CASSANDRA-18355 and CASSANDRA-18580.
> CEP-15: Accord Beta
> ---
>
> Key: CASSANDRA-17092
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17092
> Project: Cassandra
> Issue Type: Epic
> Components: Accord
>Reporter: Benedict Elliott Smith
>Assignee: Benedict Elliott Smith
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17092) CEP-15: Accord Beta
[
https://issues.apache.org/jira/browse/CASSANDRA-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769824#comment-17769824
]
Caleb Rackliffe commented on CASSANDRA-17092:
-
After a long pause, during which a significant amount of unmerged work had
accumulated, I've picked back up the Accord/TCM rebase. [This
PR|https://github.com/apache/cassandra/pull/2227] now contains a branch that
a.) is fully up-to-date w/ {{cep-21-tcm}} and b.) has pulled in all publicly
uncommitted Accord work. Once we have [reasonably clean
tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/768/workflows/d2c10a30-c256-4192-9947-b73a882ac334]
and {{cep-15-accord}} is reset to this new branch, {{cep-15-accord}} will be
able to accept new work, including CASSANDRA-18355 and CASSANDRA-18580.
> CEP-15: Accord Beta
> ---
>
> Key: CASSANDRA-17092
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17092
> Project: Cassandra
> Issue Type: Epic
> Components: Accord
>Reporter: Benedict Elliott Smith
>Assignee: Benedict Elliott Smith
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-73) Update token-ranges endpoint to return additional instance metadata
[ https://issues.apache.org/jira/browse/CASSANDRASC-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769823#comment-17769823 ] Yifan Cai commented on CASSANDRASC-73: -- +1 on the patch. > Update token-ranges endpoint to return additional instance metadata > --- > > Key: CASSANDRASC-73 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-73 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Labels: pull-request-available > > Sidecar `token-range-replicas` endpoint to return the following additional > metadata for each instance: > * State. eg Normal, Joining, Leaving > * Status. eg. Up, Down > * Address: Replica host and port > * Name: Node name resolved from the above IP address -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-73) Update token-ranges endpoint to return additional instance metadata
[ https://issues.apache.org/jira/browse/CASSANDRASC-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-73: - Reviewers: Francisco Guerrero, Yifan Cai Status: Review In Progress (was: Patch Available) > Update token-ranges endpoint to return additional instance metadata > --- > > Key: CASSANDRASC-73 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-73 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Labels: pull-request-available > > Sidecar `token-range-replicas` endpoint to return the following additional > metadata for each instance: > * State. eg Normal, Joining, Leaving > * Status. eg. Up, Down > * Address: Replica host and port > * Name: Node name resolved from the above IP address -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-73) Update token-ranges endpoint to return additional instance metadata
[ https://issues.apache.org/jira/browse/CASSANDRASC-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769821#comment-17769821 ] Francisco Guerrero commented on CASSANDRASC-73: --- +1, thanks for the patch > Update token-ranges endpoint to return additional instance metadata > --- > > Key: CASSANDRASC-73 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-73 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Labels: pull-request-available > > Sidecar `token-range-replicas` endpoint to return the following additional > metadata for each instance: > * State. eg Normal, Joining, Leaving > * Status. eg. Up, Down > * Address: Replica host and port > * Name: Node name resolved from the above IP address -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18889) DDM's mask_default function should support vectors
[
https://issues.apache.org/jira/browse/CASSANDRA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769809#comment-17769809
]
Andres de la Peña edited comment on CASSANDRA-18889 at 9/27/23 9:01 PM:
The fix is as easy as making {{VectorType}} override
{{{}AbstractType#getMaskedValue{}}}:
||PR||CI||
|[5.0
|https://github.com/apache/cassandra/pull/2747]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/4e603e90-3d03-4b3c-ac64-bae8cac93e67]
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/30fc83cf-ad2f-4f0b-bad9-1be31fba0cad]|
was (Author: adelapena):
||PR||CI||
|[5.0
|https://github.com/apache/cassandra/pull/2747]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/4e603e90-3d03-4b3c-ac64-bae8cac93e67]
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/30fc83cf-ad2f-4f0b-bad9-1be31fba0cad]|
> DDM's mask_default function should support vectors
> --
>
> Key: CASSANDRA-18889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Dynamic Data Masking, Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DDM uses the CQL function {{mask_default}} as the default masking function.
> This function supports all CQL data types except for {{vector}}, which didn't
> exist when DDM was added.
> We should make {{mask_default}} (and thereof default masking) work with
> vector columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18889) DDM's mask_default function should support vectors
[
https://issues.apache.org/jira/browse/CASSANDRA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769809#comment-17769809
]
Andres de la Peña commented on CASSANDRA-18889:
---
||PR||CI||
|[5.0
|https://github.com/apache/cassandra/pull/2747]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/4e603e90-3d03-4b3c-ac64-bae8cac93e67]
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3217/workflows/30fc83cf-ad2f-4f0b-bad9-1be31fba0cad]|
> DDM's mask_default function should support vectors
> --
>
> Key: CASSANDRA-18889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Dynamic Data Masking, Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DDM uses the CQL function {{mask_default}} as the default masking function.
> This function supports all CQL data types except for {{vector}}, which didn't
> exist when DDM was added.
> We should make {{mask_default}} (and thereof default masking) work with
> vector columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18889) DDM's mask_default function should support vectors
[
https://issues.apache.org/jira/browse/CASSANDRA-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18889:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: API /
Semantic Implementation(12988)
Complexity: Low Hanging Fruit
Discovered By: Code Inspection
Severity: Normal
Status: Open (was: Triage Needed)
> DDM's mask_default function should support vectors
> --
>
> Key: CASSANDRA-18889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Dynamic Data Masking, Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> DDM uses the CQL function {{mask_default}} as the default masking function.
> This function supports all CQL data types except for {{vector}}, which didn't
> exist when DDM was added.
> We should make {{mask_default}} (and thereof default masking) work with
> vector columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18889) DDM's mask_default function should support vectors
Andres de la Peña created CASSANDRA-18889:
-
Summary: DDM's mask_default function should support vectors
Key: CASSANDRA-18889
URL: https://issues.apache.org/jira/browse/CASSANDRA-18889
Project: Cassandra
Issue Type: Bug
Components: Feature/Dynamic Data Masking, Feature/Vector Search
Reporter: Andres de la Peña
Assignee: Andres de la Peña
DDM uses the CQL function {{mask_default}} as the default masking function.
This function supports all CQL data types except for {{vector}}, which didn't
exist when DDM was added.
We should make {{mask_default}} (and thereof default masking) work with vector
columns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769785#comment-17769785 ] Brandon Williams commented on CASSANDRA-18742: -- Started [upgrade tests|https://app.circleci.com/pipelines/github/driftx/cassandra/1314/workflows/2acf15d3-5654-4e69-bf04-57c23138330c]. > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18876) The vector data type shouldn't support empty value
[ https://issues.apache.org/jira/browse/CASSANDRA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769716#comment-17769716 ] Andres de la Peña edited comment on CASSANDRA-18876 at 9/27/23 8:31 PM: Thanks for the reviews. I have rebased and created the PR for trunk. The patch applies without any conflicts. CI is running: ||PR||CI|| |[5.0|https://github.com/apache/cassandra/pull/2723]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3216/workflows/0ce8f9de-bf46-4bb9-b58c-c6fe5a36cea8] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3216/workflows/f457eda4-e714-426d-8cee-8f7f8548a08a]| |[trunk|https://github.com/apache/cassandra/pull/2746]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3215/workflows/94b7215d-c544-462d-9076-dfa7cc7207e6] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3215/workflows/2f2b28a2-fe20-47a6-aae9-050119cbcf56]| was (Author: adelapena): Thanks for the reviews. I have rebased and created the PR for trunk. The patch applies without any conflicts. CI is running: ||PR||CI|| |[5.0|https://github.com/apache/cassandra/pull/2723]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3213/workflows/726ef03b-176b-4d60-81d4-8c1eed38cce3] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3213/workflows/c179cc69-1921-4d50-ab55-624ad50afc95]| |[trunk|https://github.com/apache/cassandra/pull/2746]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3214/workflows/69d0a58e-1503-4dca-9fa4-3745634fef74] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3214/workflows/9ad7e8d2-d5eb-43fb-bc70-630872001174]| > The vector data type shouldn't support empty value > -- > > Key: CASSANDRA-18876 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18876 > Project: Cassandra > Issue Type: Bug > Components: Feature/Vector Search >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > As discussed on [the mail > list|https://lists.apache.org/thread/qq0jkm6rlkd2slfmhgz7om14tbpys891], the > vector data type shouldn't allow empty values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769779#comment-17769779 ] Stefan Miklosovic commented on CASSANDRA-14667: --- 18882 is done. I think I need to answer some questions around java driver dependencies / exclusions. I will return to this shortly, hopefully. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Attachments: signature.asc, signature.asc, signature.asc, > signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769777#comment-17769777 ] Stefan Miklosovic edited comment on CASSANDRA-18742 at 9/27/23 8:13 PM: the flaky one is this one CASSANDRA-18360 OK will run upgrade and I ll provide the links here once done. was (Author: smiklosovic): the flaky one is this one CASSANDRA-18360 > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769777#comment-17769777 ] Stefan Miklosovic commented on CASSANDRA-18742: --- the flaky one is this one CASSANDRA-18360 > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769775#comment-17769775 ] Brandon Williams commented on CASSANDRA-18742: -- I see, that makes sense. We should probably also run the upgrade tests for this, WDYT? > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769773#comment-17769773 ] Stefan Miklosovic edited comment on CASSANDRA-18742 at 9/27/23 8:09 PM: The flaky test is a test method in AlterTest (1). This patch was modifying AlterTest to be aligned with the proposed changes. Then, upon build, as our CircleCI scripting makes modified test classes to run in a loop, that unrelated test method was executed in a loop too. We have basically discovered a flaky test. We have not modified that test method in particular. (1) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3154/workflows/abf98f42-b2b3-4dfd-ab4b-37bd4c24e102/jobs/118172/tests#failed-test-0 was (Author: smiklosovic): The flaky test is a test method in AlterTest (1). This patch was modifying AlterTest to be aligned with the proposed changes. Then, upon build, as our CircleCI scripting makes modified test classes to run in a loop, that unrelated test method was executed in a loop too. We have basically discovered a flaky test. We have not modifying that test method in particular. (1) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3154/workflows/abf98f42-b2b3-4dfd-ab4b-37bd4c24e102/jobs/118172/tests#failed-test-0 > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769773#comment-17769773 ] Stefan Miklosovic commented on CASSANDRA-18742: --- The flaky test is a test method in AlterTest (1). This patch was modifying AlterTest to be aligned with the proposed changes. Then, upon build, as our CircleCI scripting makes modified test classes to run in a loop, that unrelated test method was executed in a loop too. We have basically discovered a flaky test. We have not modifying that test method in particular. (1) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3154/workflows/abf98f42-b2b3-4dfd-ab4b-37bd4c24e102/jobs/118172/tests#failed-test-0 > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18886) snappy-java-1.1.10.1 vulnerability: CVE-2023-43642
[ https://issues.apache.org/jira/browse/CASSANDRA-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769772#comment-17769772 ] Brandon Williams commented on CASSANDRA-18886: -- All good, thank you. > snappy-java-1.1.10.1 vulnerability: CVE-2023-43642 > -- > > Key: CASSANDRA-18886 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18886 > Project: Cassandra > Issue Type: Bug > Components: Feature/Compression >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > https://nvd.nist.gov/vuln/detail/CVE-2023-43642 > Another DoS which is probably not a huge deal, but we can upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18886) snappy-java-1.1.10.1 vulnerability: CVE-2023-43642
[ https://issues.apache.org/jira/browse/CASSANDRA-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769770#comment-17769770 ] Maxim Muzafarov commented on CASSANDRA-18886: - I had to reopen the issue to close it with the correct resolution reason as it could affect a result if someone prepared a jira search query based on the fix-version tag. I hope you don't mind. > snappy-java-1.1.10.1 vulnerability: CVE-2023-43642 > -- > > Key: CASSANDRA-18886 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18886 > Project: Cassandra > Issue Type: Bug > Components: Feature/Compression >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > https://nvd.nist.gov/vuln/detail/CVE-2023-43642 > Another DoS which is probably not a huge deal, but we can upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769765#comment-17769765 ] Maxim Muzafarov commented on CASSANDRA-18878: - Folks, thank you so much for the review! > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.30, 3.11.17, 4.0.12, 4.1.4, 5.0-alpha2, 5.1 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18886) snappy-java-1.1.10.1 vulnerability: CVE-2023-43642
[ https://issues.apache.org/jira/browse/CASSANDRA-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18886: Resolution: (was: Fixed) Status: Open (was: Resolved) > snappy-java-1.1.10.1 vulnerability: CVE-2023-43642 > -- > > Key: CASSANDRA-18886 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18886 > Project: Cassandra > Issue Type: Bug > Components: Feature/Compression >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > https://nvd.nist.gov/vuln/detail/CVE-2023-43642 > Another DoS which is probably not a huge deal, but we can upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18886) snappy-java-1.1.10.1 vulnerability: CVE-2023-43642
[ https://issues.apache.org/jira/browse/CASSANDRA-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18886: Resolution: Duplicate Status: Resolved (was: Open) > snappy-java-1.1.10.1 vulnerability: CVE-2023-43642 > -- > > Key: CASSANDRA-18886 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18886 > Project: Cassandra > Issue Type: Bug > Components: Feature/Compression >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > https://nvd.nist.gov/vuln/detail/CVE-2023-43642 > Another DoS which is probably not a huge deal, but we can upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769764#comment-17769764 ] Brandon Williams commented on CASSANDRA-18742: -- Looks good to me, but I'm not sure we should be modifying a flaky test if we aren't solving it. > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (b628c65ee -> 1c29e1743)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git omit b628c65ee generate docs for bc8bfc13 new 1c29e1743 generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b628c65ee) \ N -- N -- N refs/heads/asf-staging (1c29e1743) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../doc/5.1/cassandra/managing/tools/cqlsh.html| 32 + .../doc/trunk/cassandra/managing/tools/cqlsh.html | 32 + site-ui/build/ui-bundle.zip| Bin 4881412 -> 4881412 bytes 3 files changed, 64 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a0eecdb996963398049fbf5c1ee048f8d804a474 Merge: 60314f2d6a 449343138d Author: Stefan Miklosovic AuthorDate: Wed Sep 27 21:02:09 2023 +0200 Merge branch 'cassandra-5.0' into trunk .build/parent-pom-template.xml | 2 +- CHANGES.txt| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 22ca1d0621,863b99740c..20588112aa --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -17,12 -12,14 +17,13 @@@ Merged from 4.1 * Internode legacy SSL storage port certificate is not hot reloaded on update (CASSANDRA-18681) * Nodetool paxos-only repair is no longer incremental (CASSANDRA-18466) Merged from 4.0: - * JMH improvements - faster build and async profiler (CASSANDRA-18871) * Enable 3rd party JDK installations for Debian package (CASSANDRA-18844) Merged from 3.11: + * Revert CASSANDRA-18543 (CASSANDRA-18854) Merged from 3.0: + * Upgrade snappy-java to 1.1.10.4 (CASSANDRA-18878) * Add cqlshrc.sample and credentials.sample into Debian package (CASSANDRA-18818) - 5.0-alpha1 * Fix rpm installations to work with jdk17 (CASSANDRA-18817) * Fix Depends and Build-Depends for Java for Debian packages (CASSANDRA-18809) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (a580b79d16 -> 449343138d)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from a580b79d16 Upgrade slf4j-api to 1.7.36 add dc7234134c Upgrade snappy-java to 1.1.10.4 add 058621a446 Merge branch 'cassandra-3.0' into cassandra-3.11 add b039f72e6b Merge branch 'cassandra-3.11' into cassandra-4.0 add 27fe757636 Merge branch 'cassandra-4.0' into cassandra-4.1 add 449343138d Merge branch 'cassandra-4.1' into cassandra-5.0 No new revisions were added by this update. Summary of changes: .build/parent-pom-template.xml | 2 +- CHANGES.txt| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (b9586501a6 -> 27fe757636)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from b9586501a6 Internode legacy SSL storage port certificate is not hot reloaded on update add dc7234134c Upgrade snappy-java to 1.1.10.4 add 058621a446 Merge branch 'cassandra-3.0' into cassandra-3.11 add b039f72e6b Merge branch 'cassandra-3.11' into cassandra-4.0 add 27fe757636 Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + build.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (87c2af85c1 -> 058621a446)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 87c2af85c1 Fix delayed SSTable release with unsafe_aggressive_sstable_expiration add dc7234134c Upgrade snappy-java to 1.1.10.4 add 058621a446 Merge branch 'cassandra-3.0' into cassandra-3.11 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + build.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18878: -- Fix Version/s: 3.0.30 3.11.17 4.0.12 4.1.4 5.0-alpha2 5.1 (was: 3.0.x) (was: 3.11.x) (was: 5.x) (was: 4.0.x) (was: 4.1.x) (was: 5.0.x) Source Control Link: https://github.com/apache/cassandra/commit/dc7234134cb20af4f10b41eab57bd5312fd0e6f1 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.30, 3.11.17, 4.0.12, 4.1.4, 5.0-alpha2, 5.1 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (60314f2d6a -> a0eecdb996)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 60314f2d6a Resolve deprecations in pylib add dc7234134c Upgrade snappy-java to 1.1.10.4 add 058621a446 Merge branch 'cassandra-3.0' into cassandra-3.11 add b039f72e6b Merge branch 'cassandra-3.11' into cassandra-4.0 add 27fe757636 Merge branch 'cassandra-4.0' into cassandra-4.1 add 449343138d Merge branch 'cassandra-4.1' into cassandra-5.0 new a0eecdb996 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/parent-pom-template.xml | 2 +- CHANGES.txt| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (3658ba58c7 -> b039f72e6b)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 3658ba58c7 JMH improvements - faster build and async profiler add dc7234134c Upgrade snappy-java to 1.1.10.4 add 058621a446 Merge branch 'cassandra-3.0' into cassandra-3.11 add b039f72e6b Merge branch 'cassandra-3.11' into cassandra-4.0 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + build.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (65ee0d082c -> dc7234134c)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 65ee0d082c Ninja fix for CASSANDRA-18745 add dc7234134c Upgrade snappy-java to 1.1.10.4 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + build.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769745#comment-17769745
]
Stefan Miklosovic commented on CASSANDRA-18827:
---
+1
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18827:
--
Fix Version/s: 5.1
(was: 5.x)
Source Control Link:
https://github.com/apache/cassandra/commit/60314f2d6a03b6226e37b0d9daf67f1b4204ad5c
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
--
[jira] [Updated] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18827:
--
Status: Ready to Commit (was: Review In Progress)
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Resolve deprecations in pylib
This is an automated email from the ASF dual-hosted git repository.
smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 60314f2d6a Resolve deprecations in pylib
60314f2d6a is described below
commit 60314f2d6a03b6226e37b0d9daf67f1b4204ad5c
Author: Brad Schoening
AuthorDate: Wed Sep 27 11:17:15 2023 -0400
Resolve deprecations in pylib
patch by Brad Schoening; reviewed by Stefan Miklosovic and Brandon Williams
for CASSANDRA-18827
---
pylib/cassandra-cqlsh-tests.sh | 18 +--
pylib/cqlshlib/copyutil.py | 2 +-
pylib/cqlshlib/test/cassconnect.py | 6 ++--
pylib/cqlshlib/test/test_cqlsh_completion.py | 4 +--
pylib/cqlshlib/test/test_cqlsh_output.py | 46 ++--
pylib/cqlshlib/test/test_unicode.py | 10 +++---
pylib/setup.py | 2 +-
7 files changed, 35 insertions(+), 53 deletions(-)
diff --git a/pylib/cassandra-cqlsh-tests.sh b/pylib/cassandra-cqlsh-tests.sh
index 71bb4a10ea..758a9ec615 100755
--- a/pylib/cassandra-cqlsh-tests.sh
+++ b/pylib/cassandra-cqlsh-tests.sh
@@ -84,23 +84,7 @@ fi
ccm remove test || true # in case an old ccm cluster is left behind
ccm create test -n 1 --install-dir=${CASSANDRA_DIR}
ccm updateconf "user_defined_functions_enabled: true"
-
-version_from_build=$(ccm node1 versionfrombuild)
-export pre_or_post_cdc=$(python -c """from distutils.version import
LooseVersion
-print (\"postcdc\" if LooseVersion(\"${version_from_build}\") >= \"3.8\" else
\"precdc\")
-""")
-case "${pre_or_post_cdc}" in
-postcdc)
-ccm updateconf "cdc_enabled: true"
-;;
-precdc)
-:
-;;
-*)
-echo "${pre_or_post_cdc}" is an invalid value.
-exit 1
-;;
-esac
+ccm updateconf "cdc_enabled: true"
ccm start --wait-for-binary-proto
diff --git a/pylib/cqlshlib/copyutil.py b/pylib/cqlshlib/copyutil.py
index 2a8a11d1bf..1183bddc88 100644
--- a/pylib/cqlshlib/copyutil.py
+++ b/pylib/cqlshlib/copyutil.py
@@ -144,7 +144,7 @@ class SendingChannel(object):
printmsg('%s: %s' % (e.__class__.__name__, e.message if
hasattr(e, 'message') else str(e)))
feeding_thread = threading.Thread(target=feed)
-feeding_thread.setDaemon(True)
+feeding_thread.daemon = True
feeding_thread.start()
def send(self, obj):
diff --git a/pylib/cqlshlib/test/cassconnect.py
b/pylib/cqlshlib/test/cassconnect.py
index 0118e07799..3ed93e4197 100644
--- a/pylib/cqlshlib/test/cassconnect.py
+++ b/pylib/cqlshlib/test/cassconnect.py
@@ -161,8 +161,7 @@ class DEFAULTVAL:
pass
-__TEST__ = False
-def testrun_cqlsh(keyspace=DEFAULTVAL, **kwargs):
+def cqlsh_testrun(keyspace=DEFAULTVAL, **kwargs):
# use a positive default sentinel so that keyspace=None can be used
# to override the default behavior
if keyspace is DEFAULTVAL:
@@ -170,8 +169,7 @@ def testrun_cqlsh(keyspace=DEFAULTVAL, **kwargs):
return run_cqlsh(keyspace=keyspace, **kwargs)
-__TEST__ = False
-def testcall_cqlsh(keyspace=None, **kwargs):
+def cqlsh_testcall(keyspace=None, **kwargs):
if keyspace is None:
keyspace = get_keyspace()
if 'input' in kwargs.keys() and isinstance(kwargs['input'], str):
diff --git a/pylib/cqlshlib/test/test_cqlsh_completion.py
b/pylib/cqlshlib/test/test_cqlsh_completion.py
index 2d01bdb0ae..ab00ea482c 100644
--- a/pylib/cqlshlib/test/test_cqlsh_completion.py
+++ b/pylib/cqlshlib/test/test_cqlsh_completion.py
@@ -22,7 +22,7 @@ import locale
import os
import re
from .basecase import BaseTestCase
-from .cassconnect import create_db, remove_db, testrun_cqlsh
+from .cassconnect import create_db, remove_db, cqlsh_testrun
from .run_cqlsh import TimeoutError
from cqlshlib.cql3handling import CqlRuleSet
@@ -54,7 +54,7 @@ class CqlshCompletionCase(BaseTestCase):
env['COLUMNS'] = '10'
if (locale.getpreferredencoding() != 'UTF-8'):
env['LC_CTYPE'] = 'en_US.utf8'
-self.cqlsh_runner = testrun_cqlsh(cqlver=None, env=env)
+self.cqlsh_runner = cqlsh_testrun(cqlver=None, env=env)
self.cqlsh = self.cqlsh_runner.__enter__()
def tearDown(self):
diff --git a/pylib/cqlshlib/test/test_cqlsh_output.py
b/pylib/cqlshlib/test/test_cqlsh_output.py
index 75f272b348..24af3bd965 100644
--- a/pylib/cqlshlib/test/test_cqlsh_output.py
+++ b/pylib/cqlshlib/test/test_cqlsh_output.py
@@ -26,7 +26,7 @@ from .basecase import (BaseTestCase, TEST_HOST, TEST_PORT,
at_a_time, cqlshlog, dedent)
from .cassconnect import (cassandra_cursor, create_db, get_keyspace,
quote_name, remove_db, split_cql_commands,
- testcall_cqlsh, testrun_cqlsh)
+ cqlsh_testcall, cqlsh_testrun)
from .ansi_colors import (Col
[jira] [Commented] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769744#comment-17769744
]
Maxim Muzafarov commented on CASSANDRA-18882:
-
Thank you all for the review!
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0-alpha2, 5.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18882:
-
Fix Version/s: 5.0-alpha2
5.1
(was: 5.x)
(was: 5.0.x)
Source Control Link:
https://github.com/apache/cassandra/commit/a580b79d1668ddbe4d462bf6fcac07835a72a9f3
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed, thanks folks!
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0-alpha2, 5.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 07fcac4547acd38f2d34e870ca3ef9434e9edc53 Merge: 32cf1ea33d a580b79d16 Author: Brandon Williams AuthorDate: Wed Sep 27 13:31:47 2023 -0500 Merge branch 'cassandra-5.0' into trunk .build/parent-pom-template.xml | 6 +++--- CHANGES.txt| 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --cc CHANGES.txt index a4ec2293d5,aa43ff1b18..22ca1d0621 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,11 -1,7 +1,12 @@@ -5.0-alpha2 +5.1 + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Upgrade slf4j-api to 1.7.36 (CASSANDRA-18882) * Make the output of ON/OFF commands in cqlsh consistent (CASSANDRA-18547) * Do not create sstable files before registering in txn (CASSANDRA-18737) + * Remove wrong assertion in SSTableLoader (CASSANDRA-18840) * Do not log stacktrace on mismatched cache and schema version and checksum error in AutoSavingCache (CASSANDRA-18862) * Remove wrong assertion in SSTableLoader (CASSANDRA-18840) * Fix accessing java.nio.Bits.TOTAL_CAPACITY in Java17 (CASSANDRA-18848) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-site updated (03a9058ac -> b628c65ee)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 03a9058ac generate docs for ba5f9001 add cb0375515 BLOG - Updated author for Audit Logging blog post add bc8bfc13b Fix build website on arm64 add b628c65ee generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (03a9058ac) \ N -- N -- N refs/heads/asf-site (b628c65ee) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../blog/Audit-Logging-in-Apache-Cassandra-4.html |2 +- .../4.0.0/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.0/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.1/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.1/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.10/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.10/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.11/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.11/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.2/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.2/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.3/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.3/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.4/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.4/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.5/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.5/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.6/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.6/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.7/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.7/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.8/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.8/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0.9/cassandra/tools/nodetool/bootstrap.html |6 +- .../4.0.9/cassandra/tools/nodetool/nodetool.html |8 +- .../cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.0/cassandra/tools/nodetool/bootstrap.html|6 +- .../doc/4.0/cassandra/tools/nodetool/nodetool.html |8 +- .../4.0/cassandra/tools/nodetool/repair_admin.html | 54 +- .../4.1.0/cassandra/tools/nodetool/bootstrap.html |6 +- .../doc/4.1.0/cassandra/tools/nodetool/import.html |6 +- .../4.1.0/cassandra/tools/nodetool/nodetool.html |6 +- .../cassandra/tools/nodetool/repair_admin.html | 82 +- .../4.1.1/cassandra/tools/nodetool/bootstrap.html |6 +- .../doc/4.1.1/cassandra/tools/nodetool/import.html |6 +- .../4.1.1/cassandra/tools/nodetool/nodetool.html |6 +- .../cassandra/tools/nodetool/repair_admin.html | 82 +- .../4.1.2/cassandra/tools/nodetool/bootstrap.html |6 +- .../doc/4.1.2/cassandra/tools/nodetool/import.html |6 +- .../4.1.2/cassandra/tools/nodetool/nodetool.html |6 +- .../cassandra/tools/nodetool/repair_admin.html | 82 +- .../4.1.3/cassandra/tools/nodetool/bootstrap.html |6 +- .../doc/4.1.3/cassandra/tools/nodetool/import.html |6 +- .../4.1.3/cassandra/tools/nodetool/nodetool.html |6 +- .../cassandra/tools/nodetool/repair_admin.html | 82 +- .../4.1/cassandra/tools/nodetool/bootstrap.html|6 +- .../doc/4.1/cassandra/tools/nodetool/import.html |6 +- .../doc/4.1/cassandra/tools/nodetool/nodetool.html |6 +- .../4.1/cassandra/tools/nodetool/repair_admin.html | 82 +- .../5.0/cassandra/_images/sai/dmlCompaction.png| Bin 0 -> 282703 bytes .../_images/sai/saiAge44StateCAExample.png
[cassandra] branch trunk updated (32cf1ea33d -> 07fcac4547)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 32cf1ea33d Add ELAPSED command to cqlsh new a580b79d16 Upgrade slf4j-api to 1.7.36 new 07fcac4547 Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/parent-pom-template.xml | 6 +++--- CHANGES.txt| 1 + 2 files changed, 4 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated: Upgrade slf4j-api to 1.7.36
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-5.0 by this push: new a580b79d16 Upgrade slf4j-api to 1.7.36 a580b79d16 is described below commit a580b79d1668ddbe4d462bf6fcac07835a72a9f3 Author: Maxim Muzafarov AuthorDate: Mon Sep 25 16:42:22 2023 +0200 Upgrade slf4j-api to 1.7.36 Patch by mmuzaf; reviewed by brandonwilliams and edimitrova for CASSANDRA-18882 --- .build/parent-pom-template.xml | 6 +++--- CHANGES.txt| 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.build/parent-pom-template.xml b/.build/parent-pom-template.xml index 136cf3a9e9..ecbff798b7 100644 --- a/.build/parent-pom-template.xml +++ b/.build/parent-pom-template.xml @@ -403,17 +403,17 @@ org.slf4j slf4j-api -1.7.25 +1.7.36 org.slf4j log4j-over-slf4j -1.7.25 +1.7.36 org.slf4j jcl-over-slf4j -1.7.25 +1.7.36 ch.qos.logback diff --git a/CHANGES.txt b/CHANGES.txt index 7c9237d78b..aa43ff1b18 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 5.0-alpha2 + * Upgrade slf4j-api to 1.7.36 (CASSANDRA-18882) * Make the output of ON/OFF commands in cqlsh consistent (CASSANDRA-18547) * Do not create sstable files before registering in txn (CASSANDRA-18737) * Do not log stacktrace on mismatched cache and schema version and checksum error in AutoSavingCache (CASSANDRA-18862) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18827:
--
Reviewers: Brandon Williams, Stefan Miklosovic (was: Brandon Williams)
Status: Review In Progress (was: Needs Committer)
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For addit
[jira] [Commented] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769728#comment-17769728 ] Stefan Miklosovic commented on CASSANDRA-18878: --- Looks just fine. +1. > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18878: -- Status: Ready to Commit (was: Review In Progress) > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18861) add time elapsed for simple CQL statement in the cql shell
[ https://issues.apache.org/jira/browse/CASSANDRA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18861: -- Authors: Ling Mao, Stefan Miklosovic (was: Ling Mao) Fix Version/s: 5.1 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/32cf1ea33ddac0eed694b018de3b5be4d7da053c Resolution: Fixed Status: Resolved (was: Ready to Commit) > add time elapsed for simple CQL statement in the cql shell > -- > > Key: CASSANDRA-18861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18861 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Ling Mao >Assignee: Ling Mao >Priority: Low > Fix For: 5.1 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Add ELAPSED command to cqlsh
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 32cf1ea33d Add ELAPSED command to cqlsh 32cf1ea33d is described below commit 32cf1ea33ddac0eed694b018de3b5be4d7da053c Author: maoling AuthorDate: Mon Sep 18 23:00:00 2023 +0800 Add ELAPSED command to cqlsh patch by Ling Mao; reviewed by Stefan Miklosovic, Brandon Williams for CASSANDRA-18861 Co-authored-by: Stefan Miklosovic --- CHANGES.txt| 1 + .../cassandra/pages/managing/tools/cqlsh.adoc | 29 ++ pylib/cqlshlib/cqlshhandling.py| 8 ++ pylib/cqlshlib/cqlshmain.py| 28 +++-- pylib/cqlshlib/test/test_cqlsh_completion.py | 4 +-- 5 files changed, 66 insertions(+), 4 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index c207f7bfb2..a4ec2293d5 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 5.1 + * Add ELAPSED command to cqlsh (CASSANDRA-18861) * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) Merged from 5.0: diff --git a/doc/modules/cassandra/pages/managing/tools/cqlsh.adoc b/doc/modules/cassandra/pages/managing/tools/cqlsh.adoc index 70b8846009..0afa06dba5 100644 --- a/doc/modules/cassandra/pages/managing/tools/cqlsh.adoc +++ b/doc/modules/cassandra/pages/managing/tools/cqlsh.adoc @@ -322,6 +322,35 @@ EXPAND ON EXPAND OFF +=== `ELAPSED` + +Enables or disables the printing of the elapsed time for a query. Except a quick evalution +of how long a CQL statement took, this is also a complementary output to `TRACING` (if enabled). +A user can debug if there is a communication delay to a node or not comparing the timestamps as `TRACING` tracks +the time elapsed only on the server side. + +`Usage`: + +[source,none] + +cqlsh> ELAPSED ON +ELAPSED set to ON +cqlsh> select * from myks.mytb limit 5; + + id | age ++- + 5 | 10 + 10 | 10 + 11 | 10 + 1 | 10 + 8 | 10 + +(5 rows) +(6ms elapsed) +cqlsh> DROP KEYSPACE myks ; +(510ms elapsed) + + === `LOGIN` Authenticate as a specified Cassandra user for the current session. diff --git a/pylib/cqlshlib/cqlshhandling.py b/pylib/cqlshlib/cqlshhandling.py index e6a121fd80..ad515e63c0 100644 --- a/pylib/cqlshlib/cqlshhandling.py +++ b/pylib/cqlshlib/cqlshhandling.py @@ -33,6 +33,7 @@ my_commands_ending_with_newline = ( 'debug', 'tracing', 'expand', +'elapsed', 'paging', 'exit', 'quit', @@ -71,6 +72,7 @@ cqlsh_special_cmd_command_syntax_rules = r''' | | | + | | | | @@ -194,6 +196,11 @@ cqlsh_paging_cmd_syntax_rules = r''' ; ''' +cqlsh_elapsed_cmd_syntax_rules = r''' + ::= "ELAPSED" ( switch=( "ON" | "OFF" ) )? + ; +''' + cqlsh_login_cmd_syntax_rules = r''' ::= "LOGIN" username= (password=)? ; @@ -236,6 +243,7 @@ cqlsh_extra_syntax_rules = cqlsh_cmd_syntax_rules + \ cqlsh_tracing_cmd_syntax_rules + \ cqlsh_expand_cmd_syntax_rules + \ cqlsh_paging_cmd_syntax_rules + \ +cqlsh_elapsed_cmd_syntax_rules + \ cqlsh_login_cmd_syntax_rules + \ cqlsh_exit_cmd_syntax_rules + \ cqlsh_clear_cmd_syntax_rules + \ diff --git a/pylib/cqlshlib/cqlshmain.py b/pylib/cqlshlib/cqlshmain.py index 1c47af576e..be3465035a 100755 --- a/pylib/cqlshlib/cqlshmain.py +++ b/pylib/cqlshlib/cqlshmain.py @@ -23,6 +23,7 @@ import os import re import subprocess import sys +import time import traceback import warnings import webbrowser @@ -329,7 +330,7 @@ class Shell(cmd.Cmd): default_page_size = 100 def __init__(self, hostname, port, color=False, - username=None, encoding=None, stdin=None, tty=True, + username=None, encoding=None, elapsed_enabled=False, stdin=None, tty=True, completekey=DEFAULT_COMPLETEKEY, browser=None, use_conn=None, cqlver=None, keyspace=None, tracing_enabled=False, expand_enabled=False, @@ -412,6 +413,7 @@ class Shell(cmd.Cmd): self.tty = tty self.encoding = encoding +self.elapsed_enabled = elapsed_enabled self.output_codec = codecs.lookup(encoding) @@ -970,6 +972,7 @@ class Shell(cmd.Cmd): if not statement: return False, None +start_time = time.time() future = self.session.execute_async(statement, trace=self.tracing_enabled) result = None try: @@ -990,6 +993,8 @@ class Shell(cmd.Cmd): "nodes in system.local a
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18882:
Reviewers: Brandon Williams, Ekaterina Dimitrova (was: Brandon Williams)
Status: Review In Progress (was: Needs Committer)
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18784) CEP-15: Accord - reduce command deps
[ https://issues.apache.org/jira/browse/CASSANDRA-18784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769726#comment-17769726 ] Blake Eggleston commented on CASSANDRA-18784: - After some discussion with Benedict, I've rewritten the previously posted patch here: https://github.com/belliottsmith/cassandra-accord/pull/7 This complements eviction by actively removing commands from CommandsForKeys so they don't have to be loaded, which should improve loading times and allocations significantly in workloads with high contention. Most of this patch is refactoring commands for keys into a small TimestampsForKey object and 2 sets of CommandsForKey. One that includes all unevicted commands, for use with recovery, and another containing only the commands needed to calculate deps for new operations. PreLoadContext has been updated to support specifying which command timeseries, if any, needs to be loaded for an operation. The command timeseries component is no longer directly updateable, but is updated via a CommandsForKey updater, which can target one or both subsets. On the Cassandra side, this will enable caching blind updates from the CFK listener and flushing to disk when appropriate, without having to first load them into memory. > CEP-15: Accord - reduce command deps > > > Key: CASSANDRA-18784 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18784 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > Commands do not need to list every known command as a dependency, by taking > deps on the most recently committed commands, and the chain of deps between > them and any uncommitted commands. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18882:
Status: Ready to Commit (was: Review In Progress)
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769724#comment-17769724
]
Ekaterina Dimitrova edited comment on CASSANDRA-18882 at 9/27/23 5:45 PM:
--
+1, I looked already into the changelog in another ticket where we were
discussing it
was (Author: e.dimitrova):
+1
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18882:
-
Status: Needs Committer (was: Review In Progress)
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769723#comment-17769723
]
Brandon Williams commented on CASSANDRA-18882:
--
No failures except the infamous ConnectionTest, +1.
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769724#comment-17769724
]
Ekaterina Dimitrova commented on CASSANDRA-18882:
-
+1
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18861) add time elapsed for simple CQL statement in the cql shell
[ https://issues.apache.org/jira/browse/CASSANDRA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18861: - Reviewers: Brandon Williams Status: Review In Progress (was: Needs Committer) > add time elapsed for simple CQL statement in the cql shell > -- > > Key: CASSANDRA-18861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18861 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Ling Mao >Assignee: Ling Mao >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18861) add time elapsed for simple CQL statement in the cql shell
[ https://issues.apache.org/jira/browse/CASSANDRA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18861: - Status: Ready to Commit (was: Review In Progress) > add time elapsed for simple CQL statement in the cql shell > -- > > Key: CASSANDRA-18861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18861 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Ling Mao >Assignee: Ling Mao >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18861) add time elapsed for simple CQL statement in the cql shell
[ https://issues.apache.org/jira/browse/CASSANDRA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769717#comment-17769717 ] Brandon Williams commented on CASSANDRA-18861: -- As mentioned on slack, that test is failing without this patch for whatever reason now, so we don't need to block this on it (and it's clearly unrelated anyway.) +1 > add time elapsed for simple CQL statement in the cql shell > -- > > Key: CASSANDRA-18861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18861 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Ling Mao >Assignee: Ling Mao >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18876) The vector data type shouldn't support empty value
[ https://issues.apache.org/jira/browse/CASSANDRA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769716#comment-17769716 ] Andres de la Peña commented on CASSANDRA-18876: --- Thanks for the reviews. I have rebased and created the PR for trunk. The patch applies without any conflicts. CI is running: ||PR||CI|| |[5.0|https://github.com/apache/cassandra/pull/2723]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3213/workflows/726ef03b-176b-4d60-81d4-8c1eed38cce3] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3213/workflows/c179cc69-1921-4d50-ab55-624ad50afc95]| |[trunk|https://github.com/apache/cassandra/pull/2746]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3214/workflows/69d0a58e-1503-4dca-9fa4-3745634fef74] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3214/workflows/9ad7e8d2-d5eb-43fb-bc70-630872001174]| > The vector data type shouldn't support empty value > -- > > Key: CASSANDRA-18876 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18876 > Project: Cassandra > Issue Type: Bug > Components: Feature/Vector Search >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > As discussed on [the mail > list|https://lists.apache.org/thread/qq0jkm6rlkd2slfmhgz7om14tbpys891], the > vector data type shouldn't allow empty values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18861) add time elapsed for simple CQL statement in the cql shell
[ https://issues.apache.org/jira/browse/CASSANDRA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18861: -- Status: Needs Committer (was: Patch Available) > add time elapsed for simple CQL statement in the cql shell > -- > > Key: CASSANDRA-18861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18861 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Ling Mao >Assignee: Ling Mao >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18878: -- Reviewers: Brandon Williams, Stefan Miklosovic (was: Brandon Williams) Status: Review In Progress (was: Needs Committer) > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18861) add time elapsed for simple CQL statement in the cql shell
[ https://issues.apache.org/jira/browse/CASSANDRA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769712#comment-17769712 ] Stefan Miklosovic commented on CASSANDRA-18861: --- PR https://github.com/apache/cassandra/pull/2740 j17 pre-commit https://app.circleci.com/pipelines/github/instaclustr/cassandra/3262/workflows/f8c7dea8-cc30-4270-9819-0082e3b25b53 This is supposed to go only to trunk. [~brandon.williams] would you mind to take a look, please? I am not sure about that failed test though. I am looking at it. > add time elapsed for simple CQL statement in the cql shell > -- > > Key: CASSANDRA-18861 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18861 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Ling Mao >Assignee: Ling Mao >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18799) Remove org.caffinitas.ohc:ohc-core-j8 dependency
[ https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769710#comment-17769710 ] Maxim Muzafarov commented on CASSANDRA-18799: - [~brandon.williams] I promise not to bother you with the dependency upgrades in the next reasonable time frame, I think this is the last one :-) We already have +1 here from Ekaterina, and the test results look good. I have also analyzed the commits that can cause a problem for us to mitigate the risks, and it seems everything is good from this side as well. Would you mind taking a look? > Remove org.caffinitas.ohc:ohc-core-j8 dependency > > > Key: CASSANDRA-18799 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18799 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the > Cassandra project moved away from JDK8 support. The changes are here: > CASSANDRA-18255 > We can remove it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (d58b73581 -> b628c65ee)
This is an automated email from the ASF dual-hosted git repository.
git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git
discard d58b73581 generate docs for bc8bfc13
new b628c65ee generate docs for bc8bfc13
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (d58b73581)
\
N -- N -- N refs/heads/asf-staging (b628c65ee)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../5.0/cassandra/_images/sai/dmlCompaction.png| Bin 0 -> 282703 bytes
.../_images/sai/saiAge44StateCAExample.png | Bin 0 -> 83863 bytes
...ordinatorRangeReadEstimateConcurrencyFactor.png | Bin 0 -> 128019 bytes
.../sai/saiCoordinatorRangeReadUntilLimit.png | Bin 0 -> 188137 bytes
...CoordinatorRangeReadUpdateConcurrencyFactor.png | Bin 0 -> 157400 bytes
.../_images/sai/saiOnDiskStructureWithOffsets.png | Bin 0 -> 79735 bytes
.../cassandra/_images/sai/saiReadpathOverview.png | Bin 0 -> 106178 bytes
.../doc/5.0/cassandra/_images/sai/saiWritePath.png | Bin 0 -> 42427 bytes
.../5.0/cassandra/_images/sai/saiWritePathFlow.png | Bin 0 -> 221450 bytes
content/doc/5.0/cassandra/architecture/dynamo.html | 437 ++--
.../doc/5.0/cassandra/architecture/guarantees.html | 437 ++--
content/doc/5.0/cassandra/architecture/index.html | 437 ++--
.../doc/5.0/cassandra/architecture/messaging.html | 437 ++--
.../doc/5.0/cassandra/architecture/overview.html | 437 ++--
.../5.0/cassandra/architecture/storage-engine.html | 437 ++--
.../doc/5.0/cassandra/architecture/streaming.html | 437 ++--
content/doc/5.0/cassandra/developing/cql/SASI.html | 482 +++--
.../5.0/cassandra/developing/cql/appendices.html | 442 ++--
.../doc/5.0/cassandra/developing/cql/changes.html | 440 ++--
.../cql/collections/collection-create.html}| 557 ++---
.../cql/collections/collections-overview.html} | 518 ++---
.../cql/collections/list.html} | 572 ++---
.../cql/collections/map.html} | 573 ++---
.../cql/collections/set.html} | 583 ++---
.../cassandra/developing/cql/cql_singlefile.html | 442 ++--
..._data_masking.html => create-custom-index.html} | 1162 ++
.../developing/cql/{mvs.html => create-index.html} | 839
content/doc/5.0/cassandra/developing/cql/ddl.html | 444 ++--
.../5.0/cassandra/developing/cql/definitions.html | 440 ++--
content/doc/5.0/cassandra/developing/cql/dml.html | 442 ++--
.../cql/{triggers.html => drop-index.html} | 503 ++---
.../developing/cql/dynamic_data_masking.html | 437 ++--
.../5.0/cassandra/developing/cql/functions.html| 442 ++--
.../doc/5.0/cassandra/developing/cql/index.html| 442 ++--
.../doc/5.0/cassandra/developing/cql/indexes.html | 443 ++--
.../indexing/2i/2i-concepts.html} | 653 +++---
.../indexing/2i/2i-overview.html} | 666 +++---
.../cql/indexing/2i/2i-when-to-use.html} | 711 +++
.../cql/indexing/2i/2i-working-with.html | 1456 +
.../indexing/2i/operations/2i-build.html} | 655 +++---
.../cql/indexing/indexing-concepts.html} | 587 +++--
.../cql/indexing/sai/operations/configuring.html | 1114 ++
.../cql/indexing/sai/operations/monitoring.html| 1515 +
.../indexing/sai/operations/sai-operations.html} | 607 +++---
.../developing/cql/indexing/sai/sai-concepts.html | 1413
.../developing/cql/indexing/sai/sai-faq.html | 1679 +++
.../indexing/sai/sai-overview.html}| 718 +++
.../cql/indexing/sai/sai-working-with.html | 2248
content/doc/5.0/cassandra/developing/cql/json.html | 444 ++--
content/doc/5.0/cassandra/developing/cql/mvs.html | 442 ++--
.../5.0/cassandra/developing/cql/operators.html| 442 ++--
.../doc/5.0/cassandra/developing/cql/security.html | 442 ++--
.../doc/5.0/cassandra/developing/cql/triggers.html | 440 ++--
.../doc/5.0/cassandra/developing/cql/types.html| 442 ++--
.../data-modeling/data-modeling_conceptual.html| 444 ++--
.../data-modeling/data-modeling
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18882:
Description:
{color:red}colored text{color}The proposed update is 1.7.25 (current) > 1.7.36
(latest)
The following commits are included in the newer slf4j-api and that currently
look very useful for us:
- [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
Potential memory leaks if there is no underlying implementation
- [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add
test for all happy flow cases
-
[SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
EventRecodingLogger debug logs as TRACE
was:
The proposed update is 1.7.24 (current) > 1.7.36 (latest)
The following commits are included in the newer slf4j-api and that currently
look very useful for us:
- [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
Potential memory leaks if there is no underlying implementation
- [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add
test for all happy flow cases
-
[SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
EventRecodingLogger debug logs as TRACE
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}colored text{color}The proposed update is 1.7.25 (current) >
> 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18882:
Description:
{color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
The following commits are included in the newer slf4j-api and that currently
look very useful for us:
- [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
Potential memory leaks if there is no underlying implementation
- [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add
test for all happy flow cases
-
[SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
EventRecodingLogger debug logs as TRACE
was:
{color:red}colored text{color}The proposed update is 1.7.25 (current) > 1.7.36
(latest)
The following commits are included in the newer slf4j-api and that currently
look very useful for us:
- [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
Potential memory leaks if there is no underlying implementation
- [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add
test for all happy flow cases
-
[SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
EventRecodingLogger debug logs as TRACE
> Update the slf4j-api library in order to avoid potential leaks
> --
>
> Key: CASSANDRA-18882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18882
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:red}>{color}The proposed update is 1.7.25 (current) > 1.7.36 (latest)
> The following commits are included in the newer slf4j-api and that currently
> look very useful for us:
> - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html]
> Potential memory leaks if there is no underlying implementation
> - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html]
> Add test for all happy flow cases
> -
> [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)]
> EventRecodingLogger debug logs as TRACE
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18882: - Reviewers: Brandon Williams Status: Review In Progress (was: Patch Available) Sure! ||Branch||CI|| |[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18882-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1313/workflows/63415f9c-cd2b-4bf6-bfbf-e4a740f095e2], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1313/workflows/0329a86c-3278-4a84-b6f1-424f5cc001af]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18882-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1312/workflows/e931ad33-a7b5-4590-b071-81953ba1649e], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1312/workflows/1c9e9f4d-c453-4e71-8979-987bf047475e]| > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769692#comment-17769692 ] Maxim Muzafarov commented on CASSANDRA-18882: - [~brandon.williams] Hi, can you take a look at these patches as well? :-) > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch&q=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22&o=newest&f=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769690#comment-17769690 ] Brandon Williams commented on CASSANDRA-18878: -- I don't see any new regressions here, +1. > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769691#comment-17769691 ] Brandon Williams commented on CASSANDRA-18878: -- [~smiklosovic] can you take a look? > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18878: - Status: Needs Committer (was: Review In Progress) > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18827:
-
Status: Needs Committer (was: Review In Progress)
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769684#comment-17769684
]
Brandon Williams commented on CASSANDRA-18827:
--
+1
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769680#comment-17769680 ] David Capwell commented on CASSANDRA-18816: --- Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |cassandra-5.0|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-18816-cassandra-5.0-E73F65B6-7A0A-4D0A-BE22-CFCA00785A0A]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-18816-cassandra-5.0-E73F65B6-7A0A-4D0A-BE22-CFCA00785A0A]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/2607/]| |trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-18816-trunk-E73F65B6-7A0A-4D0A-BE22-CFCA00785A0A]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-18816-trunk-E73F65B6-7A0A-4D0A-BE22-CFCA00785A0A]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/2608/]| > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.x > > Time Spent: 13h 10m > Remaining Estimate: 0h > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18798) Appending to list in Accord transactions uses insertion timestamp
[
https://issues.apache.org/jira/browse/CASSANDRA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769677#comment-17769677
]
Henrik Ingo commented on CASSANDRA-18798:
-
Thanks! This somewhat confirms the theory then. The only exception is that this
isn't about loss of precision at all. All of those timestamps are unique and
the problem is just that the ListType isn't sorting at all now.
> Appending to list in Accord transactions uses insertion timestamp
> -
>
> Key: CASSANDRA-18798
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18798
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: Jaroslaw Kijanowski
>Assignee: Henrik Ingo
>Priority: Normal
> Attachments: image-2023-09-26-20-05-25-846.png
>
>
> Given the following schema:
> {code:java}
> CREATE KEYSPACE IF NOT EXISTS accord WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 3};
> CREATE TABLE IF NOT EXISTS accord.list_append(id int PRIMARY KEY,contents
> LIST);
> TRUNCATE accord.list_append;{code}
> And the following two possible queries executed by 10 threads in parallel:
> {code:java}
> BEGIN TRANSACTION
> LET row = (SELECT * FROM list_append WHERE id = ?);
> SELECT row.contents;
> COMMIT TRANSACTION;"
> BEGIN TRANSACTION
> UPDATE list_append SET contents += ? WHERE id = ?;
> COMMIT TRANSACTION;"
> {code}
> there seems to be an issue with transaction guarantees. Here's an excerpt in
> the edn format from a test.
> {code:java}
> {:type :invoke :process 8 :value [[:append 5 352]] :tid 3 :n 52
> :time 1692607285967116627}
> {:type :invoke :process 9 :value [[:r 5 nil]] :tid 1 :n 54
> :time 1692607286078732473}
> {:type :invoke :process 6 :value [[:append 5 553]] :tid 5 :n 53
> :time 1692607286133833428}
> {:type :invoke :process 7 :value [[:append 5 455]] :tid 4 :n 55
> :time 1692607286149702511}
> {:type :ok :process 8 :value [[:append 5 352]] :tid 3 :n 52
> :time 1692607286156314099}
> {:type :invoke :process 5 :value [[:r 5 nil]] :tid 9 :n 52
> :time 1692607286167090389}
> {:type :ok :process 9 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352]]] :tid 1 :n 54 :time 1692607286168657534}
> {:type :invoke :process 1 :value [[:r 5 nil]] :tid 0 :n 51
> :time 1692607286201762938}
> {:type :ok :process 7 :value [[:append 5 455]] :tid 4 :n 55
> :time 1692607286245571513}
> {:type :invoke :process 7 :value [[:r 5 nil]] :tid 4 :n 56
> :time 1692607286245655775}
> {:type :ok :process 5 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 455]]] :tid 9 :n 52 :time 1692607286253928906}
> {:type :invoke :process 5 :value [[:r 5 nil]] :tid 9 :n 53
> :time 1692607286254095215}
> {:type :ok :process 6 :value [[:append 5 553]] :tid 5 :n 53
> :time 1692607286266263422}
> {:type :ok :process 1 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 0 :n 51 :time 1692607286271617955}
> {:type :ok :process 7 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 4 :n 56 :time 1692607286271816933}
> {:type :ok :process 5 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 9 :n 53 :time 1692607286281483026}
> {:type :invoke :process 9 :value [[:r 5 nil]] :tid 1 :n 56
> :time 1692607286284097561}
> {:type :ok :process 9 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 1 :n 56 :time 1692607286306445242}
> {code}
> Processes process 6 and process 7 are appending the values 553 and 455
> respectively. 455 succeeded and a read by process 5
[jira] [Commented] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769676#comment-17769676
]
Brandon Williams commented on CASSANDRA-18827:
--
LGTM. I guess there's nothing we can do about eventlet except wait.
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18827-trunk]|[cqlsh
tests|https://app.circleci.com/pipelines/github/driftx/cassandra/1311/workflows/d71b1b3c-c4b1-4326-b52c-b7d05f871e73]|
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
[jira] [Updated] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18827:
-
Summary: Fix pytest deprecations in cqlsh tests (was: Fix pytest
deprecations)
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apac
[jira] [Comment Edited] (CASSANDRA-18798) Appending to list in Accord transactions uses insertion timestamp
[
https://issues.apache.org/jira/browse/CASSANDRA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769223#comment-17769223
]
Henrik Ingo edited comment on CASSANDRA-18798 at 9/27/23 3:41 PM:
--
Okay, finally got to the bottom of this. Report of findings follows:
TL:DR; Accord is correctly propagating the {{executeAt}} timestamp into the
legacy {{timestamp}} and {{executeNow}} fields. There's loss of precision
though, so appending to the list twice within the same millisecond is the
likely explanation of this particular symptom. Underneath this, it's however
the {{ListType}} itself that is broken, at least for the read path.
Part of the reason to write all of the below is that I'm seeking guidance on
the ListType. What is it even supposed to do?
h2. Accord
The ListType is internally like a table/partition of BTreeRow's, that are
sorted by their timestamp. This makes lists ecentualy consistent: The
application can append entries to a list from two clients simultaneously, and
the ordering of the resulting list, once all elements have "arrived", is
deterministic. The initial hyptohesis for my research was that the Accord
executeAt timestamp isn't correctly propagated into each list element
(BTreeRow). However, this is not the case:
Once an Accord transaction has determined its transaction id, called executeAt
in Cassandra, and we arrive at the write portion of the exeuction phase, we
have this:
{{ cfk.updateLastExecutionTimestamps(executeAt, true);}}
{{ long timestamp = cfk.current().timestampMicrosFor(executeAt, true);}}
{{ // TODO (low priority - do we need to compute nowInSeconds, or can we
just use executeAt?)}}
{{ int nowInSeconds = cfk.current().nowInSecondsFor(executeAt, true);}}
_modules/accord/accord-core/src/main/java/accord/primitives/Timestamp.java_
This eventually reaches
{{ public Row updateAllTimestamp(long newTimestamp)}}
{{ LivenessInfo newInfo = primaryKeyLivenessInfo.isEmpty() ?
primaryKeyLivenessInfo :
primaryKeyLivenessInfo.withUpdatedTimestamp(newTimestamp);}}
{{ // If the deletion is shadowable and the row has a timestamp, we'll
forced the deletion timestamp to be less than the row one, so we}}
{{ // should get rid of said deletion.}}
{{ Deletion newDeletion = deletion.isLive() || (deletion.isShadowable()
&& !primaryKeyLivenessInfo.isEmpty())}}
{{ ? Deletion.LIVE}}
{{ : new Deletion(new DeletionTime(newTimestamp -
1, deletion.time().localDeletionTime()), deletion.isShadowable());}}
{{ return transformAndFilter(newInfo, newDeletion, (cd) ->
cd.updateAllTimestamp(newTimestamp));}}
_src/java/org/apache/cassandra/db/rows/BTreeRow.java_
The only problem I can see is loss of precision: This call will use the hlc()
part of the executeAt timestamp, and not the node id (nor epoch). It seems
possible and even likely that two different nodes will append to the same list
during the same millisecond. After this, the ordering of those two (BTreeRow)
elements is deterministic but arbitrary, and not guaranteed to be the same as
the Accord transactions that wrote them.
Also note the loss of precision is unnecessary! Cassandra legacy timestamps are
microseconds, but Accord has only millisecond precision. A better
implementation here would be to use the last 3 digits of the timestamp field to
encode the node id, and maybe also epoch.
The Accord originated timestamps are easy to spot with their 3 trailing zeros:
{{$ tools/bin/sstabledump -d -t
data/data/myspace/listtest-8574ceb057c611eeb5787dbb261b6e16/nc-5-big-Data.db }}
{{[2]@241 Row[info=[ts=1695222739434337] ]: |
del(names)=deletedAt=1695222739434336, localDeletion=1695222739,
[names[177f79d0-57c8-11ee-b578-7dbb261b6e16]=Albert ts=1695222739434337],
[names[177f79da-57c8-11ee-b578-7dbb261b6e16]=Ebba ts=1695222739434337],
[names[3d4371d0-}}
{{57c8-11ee-b578-7dbb261b6e16]=poppari ts=1695222802794082]}}
$ tools/bin/sstabledump -d -t
data/data/myspace/listtest-8574ceb057c611eeb5787dbb261b6e16/nc-26-big-Data.db
[2]@0 Row[info=[ts=-9223372036854775808] ]: | ,
[names[6d8b88c0-5979-11ee-9ee4-1ff7dd1e5050]=HENKKA ts=1695408855885000]
h2. ListType
My understanding is that a ListType is expected to return the elements of the
list sorted by their timestamp. Some elements don't have a timestamp of their
own, in which case they use the timestamp from the row header + physical order.
When a ListType is read from disk and deserialized, a good point to start
observing what happens is in BTreeRow.Builder.build():
{{ public Row build()}}
{{ {}}
{{ if (isSorted || !isSorted)}}
{{ getCells().sort();}}
{{ // we can avoid resolving if we're sorted and have no complex
values}}
{{
[jira] [Updated] (CASSANDRA-18827) Fix pytest deprecations in cqlsh tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18827:
-
Reviewers: Brandon Williams
Status: Review In Progress (was: Patch Available)
> Fix pytest deprecations in cqlsh tests
> --
>
> Key: CASSANDRA-18827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18827
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Pytest reports several warnings regarding deprecated packages or methods:
>
> {noformat}
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:6:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> preserves_excinfo = (distutils.version.LooseVersion(greenlet.__version__)
>
> ../../../../../usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7
> /usr/local/lib/python3.10/site-packages/eventlet/support/greenlets.py:7:
> DeprecationWarning: distutils Version classes are deprecated. Use
> packaging.version instead.
> >= distutils.version.LooseVersion('0.3.2'))
>
> ../../../../../usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34
> /usr/local/lib/python3.10/site-packages/cassandra/io/asyncorereactor.py:34:
> DeprecationWarning: The asyncore module is deprecated and will be removed in
> Python 3.12. The recommended replacement is asyncio
> import asyncore
>
> cqlshlib/test/test_copyutil.py: 42 warnings
> /Users/brad/Cassandra/cassandra/pylib/cqlshlib/copyutil.py:147:
> DeprecationWarning: setDaemon() is deprecated, set the daemon attribute
> instead
> feeding_thread.setDaemon(True)
>
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_completion.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testcall_cqlsh returned ('\nNotice:
> Credentials in the cqlshrc file is deprecated and will be ignored in the
> future.\nPlease use a credentials file to specify the username and
> password.\n\nWARNING: cqlsh was built against 5.1, but this server is 4.1..
> All features may not work!\n', 0), which will be an error in a future version
> of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_cqlsh_output.py::testrun_cqlsh returned
> , which will be an error in a
> future version of pytest. Did you mean to use `assert` instead of `return`?
> warnings.warn(
>
> cqlshlib/test/test_unicode.py::testrun_cqlsh
> /usr/local/lib/python3.10/site-packages/_pytest/python.py:198:
> PytestReturnNotNoneWarning: Expected None, but
> cqlshlib/test/test_unicode.py::testrun_cqlsh returned object at 0x126c93700>, which will be an error in a future version of pytest.
> Did you mean to use `assert` instead of `return`?
> warnings.warn(
> {noformat}
>
> Resolution:
> * distutils Version class is used in cassandra-cql-tests.sh and was
> introduced in Cassandra [3.11.4
> title|[https://github.com/apache/cassandra/blob/cassandra-3.11.4/pylib/cassandra-cqlsh-tests.sh].]
> It appears to be checking that the version used by ccm is > 3.8 to enable
> cdc. Thus the code block can be dropped now in > 4.x.
> * Renamed testrun_cqlsh() to cqlsh_testrun() to avoid being picked up as a
> pytest
> Out of scope:
> * DeprecationWarning: distutils Version from greenlets.py appears to be
> eventlet issue *[#763|https://github.com/eventlet/eventlet/issues/763]*
> * DeprecationWarning: The asyncore module from asyncorereactor.py appears to
> come from the eventlet issue
> [#804|https://github.com/eventlet/eventlet/issues/804]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra
[jira] [Updated] (CASSANDRA-18798) Appending to list in Accord transactions uses insertion timestamp
[
https://issues.apache.org/jira/browse/CASSANDRA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henrik Ingo updated CASSANDRA-18798:
Bug Category: Parent values: Correctness(12982)Level 1 values:
Consistency(12989)
Complexity: Normal
Discovered By: Adhoc Test
Reviewers: Jaroslaw Kijanowski
Severity: Normal
Assignee: Henrik Ingo
Status: Open (was: Triage Needed)
> Appending to list in Accord transactions uses insertion timestamp
> -
>
> Key: CASSANDRA-18798
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18798
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: Jaroslaw Kijanowski
>Assignee: Henrik Ingo
>Priority: Normal
> Attachments: image-2023-09-26-20-05-25-846.png
>
>
> Given the following schema:
> {code:java}
> CREATE KEYSPACE IF NOT EXISTS accord WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 3};
> CREATE TABLE IF NOT EXISTS accord.list_append(id int PRIMARY KEY,contents
> LIST);
> TRUNCATE accord.list_append;{code}
> And the following two possible queries executed by 10 threads in parallel:
> {code:java}
> BEGIN TRANSACTION
> LET row = (SELECT * FROM list_append WHERE id = ?);
> SELECT row.contents;
> COMMIT TRANSACTION;"
> BEGIN TRANSACTION
> UPDATE list_append SET contents += ? WHERE id = ?;
> COMMIT TRANSACTION;"
> {code}
> there seems to be an issue with transaction guarantees. Here's an excerpt in
> the edn format from a test.
> {code:java}
> {:type :invoke :process 8 :value [[:append 5 352]] :tid 3 :n 52
> :time 1692607285967116627}
> {:type :invoke :process 9 :value [[:r 5 nil]] :tid 1 :n 54
> :time 1692607286078732473}
> {:type :invoke :process 6 :value [[:append 5 553]] :tid 5 :n 53
> :time 1692607286133833428}
> {:type :invoke :process 7 :value [[:append 5 455]] :tid 4 :n 55
> :time 1692607286149702511}
> {:type :ok :process 8 :value [[:append 5 352]] :tid 3 :n 52
> :time 1692607286156314099}
> {:type :invoke :process 5 :value [[:r 5 nil]] :tid 9 :n 52
> :time 1692607286167090389}
> {:type :ok :process 9 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352]]] :tid 1 :n 54 :time 1692607286168657534}
> {:type :invoke :process 1 :value [[:r 5 nil]] :tid 0 :n 51
> :time 1692607286201762938}
> {:type :ok :process 7 :value [[:append 5 455]] :tid 4 :n 55
> :time 1692607286245571513}
> {:type :invoke :process 7 :value [[:r 5 nil]] :tid 4 :n 56
> :time 1692607286245655775}
> {:type :ok :process 5 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 455]]] :tid 9 :n 52 :time 1692607286253928906}
> {:type :invoke :process 5 :value [[:r 5 nil]] :tid 9 :n 53
> :time 1692607286254095215}
> {:type :ok :process 6 :value [[:append 5 553]] :tid 5 :n 53
> :time 1692607286266263422}
> {:type :ok :process 1 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 0 :n 51 :time 1692607286271617955}
> {:type :ok :process 7 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 4 :n 56 :time 1692607286271816933}
> {:type :ok :process 5 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 9 :n 53 :time 1692607286281483026}
> {:type :invoke :process 9 :value [[:r 5 nil]] :tid 1 :n 56
> :time 1692607286284097561}
> {:type :ok :process 9 :value [[:r 5 [303 304 604 6 306 509 909 409 912
> 411 514 415 719 419 19 623 22 425 24 926 25 832 130 733 430 533 29 933 333
> 537 934 538 740 139 744 938 544 42 646 749 242 546 547 548 753 450 150 349 48
> 852 352 553 455]]] :tid 1 :n 56 :time 1692607286306445242}
> {code}
> Processes process 6 and process 7 are appending the values 553 and 455
> respectively. 455 succeeded and a read by proc
