[jira] [Commented] (CASSANDRA-19477) Do not go to disk to get HintsStore.getTotalFileSize
[
https://issues.apache.org/jira/browse/CASSANDRA-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830036#comment-17830036
]
Stefan Miklosovic commented on CASSANDRA-19477:
---
[CASSANDRA-19477-4.1|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19477-4.1]
{noformat}
java8_pre-commit_tests
✓ j8_build 3m 56s
✓ j8_cqlsh_dtests_py3 5m 12s
✓ j8_cqlsh_dtests_py3118m 35s
✓ j8_cqlsh_dtests_py311_vnode 9m 4s
✓ j8_cqlsh_dtests_py38 6m 47s
✓ j8_cqlsh_dtests_py38_vnode6m 8s
✓ j8_cqlsh_dtests_py3_vnode9m 18s
✓ j8_cqlshlib_cython_tests11m 55s
✓ j8_cqlshlib_tests 8m 6s
✓ j8_dtests 32m 16s
✓ j8_dtests_vnode 36m 21s
✓ j8_jvm_dtests 16m 18s
✓ j8_jvm_dtests_repeat41m 32s
✓ j8_jvm_dtests_vnode_repeat 41m 13s
✓ j8_simulator_dtests 2m 49s
✓ j8_unit_tests_repeat 3m 59s
✓ j8_utests_system_keyspace_directory_repeat 3m 45s
✓ j11_unit_tests_repeat0m 31s
✓ j11_jvm_dtests_vnode_repeat 38m 49s
✓ j11_jvm_dtests_vnode12m 37s
✓ j11_jvm_dtests_repeat39m 0s
✓ j11_jvm_dtests 16m 8s
✓ j11_dtests_vnode35m 43s
✓ j11_dtests 33m 55s
✓ j11_cqlshlib_tests 6m 15s
✓ j11_cqlshlib_cython_tests7m 10s
✓ j11_cqlsh_dtests_py3_vnode 5m 37s
✓ j11_cqlsh_dtests_py38_vnode 6m 10s
✓ j11_cqlsh_dtests_py385m 26s
✓ j11_cqlsh_dtests_py311_vnode 5m 46s
✓ j11_cqlsh_dtests_py311 5m 29s
✓ j11_cqlsh_dtests_py3 5m 20s
✕ j8_jvm_dtests_vnode 16m 54s
org.apache.cassandra.distributed.test.GossipTest nodeDownDuringMove
✕ j8_unit_tests 11m 19s
org.apache.cassandra.cql3.MemtableSizeTest testSize[skiplist]
✕ j8_utests_system_keyspace_directory 9m 35s
org.apache.cassandra.cql3.MemtableSizeTest testSize[skiplist]
✕ j11_unit_tests8m 6s
org.apache.cassandra.db.compaction.DateTieredCompactionStrategyTest
testDropExpiredSSTables
org.apache.cassandra.db.compaction.DateTieredCompactionStrategyTest
testFilterOldSSTables
org.apache.cassandra.cql3.MemtableSizeTest testSize[skiplist]
{noformat}
[java8_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4065/workflows/3c368b8e-2cc7-4c78-afe3-62b45253e416]
> Do not go to disk to get HintsStore.getTotalFileSize
>
>
> Key: CASSANDRA-19477
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19477
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Jon Haddad
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.1.x, 5.0-rc, 5.x
>
> Attachments: flamegraph.cpu.html
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> When testing a cluster with more requests than it could handle, I noticed
> significant CPU time (25%) spent in HintsStore.getTotalFileSize. Here's what
> I'm seeing from profiling:
> 10% of CPU time spent in HintsDescriptor.fileName which only does this:
>
> {noformat}
> return String.format("%s-%s-%s.hints", hostId, timestamp, version);{noformat}
> At a bare minimum here we should create this string up front with the host
> and version and eliminate 2 of the 3 substitutions, but I think it's probably
> faster to use a StringBuilder and avoid the underlying regular expression
> altogether.
> 12% of the time is spent in org.apache.cassandra.io.util.File.length. It
> looks like this is called once for each hint file on disk for each host we're
> hinting to. In the case of an overloaded cluster, this is significant. It
> would be better if we were to track the file size in memory for each hint
> file and reference that rather than go to the filesystem.
> These fairly small changes should make Cassandra more reliable when under
> load spikes.
> CPU Flame graph attached.
> I only tested this in 4.1 but it looks like this is present up to trunk.
>
--
This message was sent by
[jira] [Commented] (CASSANDRA-19150) Align values in rows in CQLSH right for numbers, left for text
[
https://issues.apache.org/jira/browse/CASSANDRA-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830032#comment-17830032
]
Arun Ganesh commented on CASSANDRA-19150:
-
Ping [~bschoeni] [~smiklosovic]
The patch is almost ready. Just a quick question. The patch will break almost
every test that depends on the cqlsh output. How should I go about fixing them?
> Align values in rows in CQLSH right for numbers, left for text
> --
>
> Key: CASSANDRA-19150
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19150
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Assignee: Arun Ganesh
>Priority: Low
> Fix For: 5.x
>
> Attachments: Screenshot 2023-12-04 at 00.38.16.png, Screenshot
> 2023-12-09 at 16.58.25.png, signature.asc
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Updated* Jan 17 2024 after dev discussion
> Change CQLSH to left-align text while continue to right-align numbers. This
> will match how Postgres shell and Excel treat alignment of text and number.
> -
> *Original*
> We need to make this
> [https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101]
> configurable so values in columns are either all on left or on right side of
> the column (basically change col.rjust to col.ljust).
> By default, it would be like it is now but there would be configuration
> property in cqlsh for that as well as a corresponding CQLSH command
> (optional), something like
> {code:java}
> ALIGNMENT LEFT|RIGHT
> {code}
> cc [~bschoeni]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-staging updated (b8c4937c9 -> 4b2dd127f)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard b8c4937c9 generate docs for fd550e9c new 4b2dd127f generate docs for fd550e9c This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b8c4937c9) \ N -- N -- N refs/heads/asf-staging (4b2dd127f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4883646 -> 4883646 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
