[jira] [Comment Edited] (CASSANDRA-7450) Make repair -pr work within a datacenter
[
https://issues.apache.org/jira/browse/CASSANDRA-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365083#comment-17365083
]
Laurenceau Julien edited comment on CASSANDRA-7450 at 6/18/21, 2:46 PM:
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
[https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html|https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html?hl=repai]
Apache documentation is OK
was (Author: julienlau):
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
[https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html|https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html?hl=repai]
> Make repair -pr work within a datacenter
>
>
> Key: CASSANDRA-7450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7450
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Sylvain Lebresne
>Assignee: Paulo Motta (Deprecated)
>Priority: Normal
> Labels: bootcamp, repair
> Fix For: 2.1.1
>
> Attachments: 2.1-CASSANDRA-7450-v1.txt, 2.1-CASSANDRA-7450-v2.txt,
> 7450-2.1-v3.txt
>
>
> As was noticed in CASSANDRA-7317, using '-pr' alongside '-local' for repair
> doesn't really work properly, and disabling the combination was definitively
> the right short time fix. However, the main goal of '-pr' is to make it easy
> to repair a full cluster without doing any duplication of work. Doing the
> same only within a data-center is obviously desirable.
> I think a reasonably simple solution would be modify the behavior of '-pr'
> when it's limited to only one DC. If applied to nodeX in dcY, instead of
> repairing only the "primary" range of nodeX for the whole ring, we'll repair
> that range but also all ranges that are "primary" for a node not in dcY and
> for which nodeX is the first node of dcY found in ring order. Basically we'll
> ensure that running 'repair -local -pr' on every nodes of a given DC will
> repair all ranges for the nodes of that DC without repairing the same range
> twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-7450) Make repair -pr work within a datacenter
[
https://issues.apache.org/jira/browse/CASSANDRA-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365083#comment-17365083
]
Laurenceau Julien edited comment on CASSANDRA-7450 at 6/18/21, 2:45 PM:
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
[https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html|https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html?hl=repai]
was (Author: julienlau):
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html?hl=repai
> Make repair -pr work within a datacenter
>
>
> Key: CASSANDRA-7450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7450
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Sylvain Lebresne
>Assignee: Paulo Motta (Deprecated)
>Priority: Normal
> Labels: bootcamp, repair
> Fix For: 2.1.1
>
> Attachments: 2.1-CASSANDRA-7450-v1.txt, 2.1-CASSANDRA-7450-v2.txt,
> 7450-2.1-v3.txt
>
>
> As was noticed in CASSANDRA-7317, using '-pr' alongside '-local' for repair
> doesn't really work properly, and disabling the combination was definitively
> the right short time fix. However, the main goal of '-pr' is to make it easy
> to repair a full cluster without doing any duplication of work. Doing the
> same only within a data-center is obviously desirable.
> I think a reasonably simple solution would be modify the behavior of '-pr'
> when it's limited to only one DC. If applied to nodeX in dcY, instead of
> repairing only the "primary" range of nodeX for the whole ring, we'll repair
> that range but also all ranges that are "primary" for a node not in dcY and
> for which nodeX is the first node of dcY found in ring order. Basically we'll
> ensure that running 'repair -local -pr' on every nodes of a given DC will
> repair all ranges for the nodes of that DC without repairing the same range
> twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-7450) Make repair -pr work within a datacenter
[
https://issues.apache.org/jira/browse/CASSANDRA-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365083#comment-17365083
]
Laurenceau Julien edited comment on CASSANDRA-7450 at 6/18/21, 2:45 PM:
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
https://docs.datastax.com/en/cassandra-oss/3.x/cassandra/operations/opsRepairNodesManualRepair.html?hl=repai
was (Author: julienlau):
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
> Make repair -pr work within a datacenter
>
>
> Key: CASSANDRA-7450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7450
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Sylvain Lebresne
>Assignee: Paulo Motta (Deprecated)
>Priority: Normal
> Labels: bootcamp, repair
> Fix For: 2.1.1
>
> Attachments: 2.1-CASSANDRA-7450-v1.txt, 2.1-CASSANDRA-7450-v2.txt,
> 7450-2.1-v3.txt
>
>
> As was noticed in CASSANDRA-7317, using '-pr' alongside '-local' for repair
> doesn't really work properly, and disabling the combination was definitively
> the right short time fix. However, the main goal of '-pr' is to make it easy
> to repair a full cluster without doing any duplication of work. Doing the
> same only within a data-center is obviously desirable.
> I think a reasonably simple solution would be modify the behavior of '-pr'
> when it's limited to only one DC. If applied to nodeX in dcY, instead of
> repairing only the "primary" range of nodeX for the whole ring, we'll repair
> that range but also all ranges that are "primary" for a node not in dcY and
> for which nodeX is the first node of dcY found in ring order. Basically we'll
> ensure that running 'repair -local -pr' on every nodes of a given DC will
> repair all ranges for the nodes of that DC without repairing the same range
> twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-7450) Make repair -pr work within a datacenter
[
https://issues.apache.org/jira/browse/CASSANDRA-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365083#comment-17365083
]
Laurenceau Julien edited comment on CASSANDRA-7450 at 6/18/21, 2:44 PM:
Datastax documentation may need an update because it still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
was (Author: julienlau):
It may be necessary to update the documentation which still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
> Make repair -pr work within a datacenter
>
>
> Key: CASSANDRA-7450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7450
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Sylvain Lebresne
>Assignee: Paulo Motta (Deprecated)
>Priority: Normal
> Labels: bootcamp, repair
> Fix For: 2.1.1
>
> Attachments: 2.1-CASSANDRA-7450-v1.txt, 2.1-CASSANDRA-7450-v2.txt,
> 7450-2.1-v3.txt
>
>
> As was noticed in CASSANDRA-7317, using '-pr' alongside '-local' for repair
> doesn't really work properly, and disabling the combination was definitively
> the right short time fix. However, the main goal of '-pr' is to make it easy
> to repair a full cluster without doing any duplication of work. Doing the
> same only within a data-center is obviously desirable.
> I think a reasonably simple solution would be modify the behavior of '-pr'
> when it's limited to only one DC. If applied to nodeX in dcY, instead of
> repairing only the "primary" range of nodeX for the whole ring, we'll repair
> that range but also all ranges that are "primary" for a node not in dcY and
> for which nodeX is the first node of dcY found in ring order. Basically we'll
> ensure that running 'repair -local -pr' on every nodes of a given DC will
> repair all ranges for the nodes of that DC without repairing the same range
> twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7450) Make repair -pr work within a datacenter
[
https://issues.apache.org/jira/browse/CASSANDRA-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365083#comment-17365083
]
Laurenceau Julien commented on CASSANDRA-7450:
--
It may be necessary to update the documentation which still states:
> {color:#1d1c1d}Additional guidance for {color}{{nodetool
> repair}}{color:#1d1c1d} options: Does not support the use of
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d}
> option unless the datacenter nodes have all the data for all ranges{color}
> Make repair -pr work within a datacenter
>
>
> Key: CASSANDRA-7450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7450
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Sylvain Lebresne
>Assignee: Paulo Motta (Deprecated)
>Priority: Normal
> Labels: bootcamp, repair
> Fix For: 2.1.1
>
> Attachments: 2.1-CASSANDRA-7450-v1.txt, 2.1-CASSANDRA-7450-v2.txt,
> 7450-2.1-v3.txt
>
>
> As was noticed in CASSANDRA-7317, using '-pr' alongside '-local' for repair
> doesn't really work properly, and disabling the combination was definitively
> the right short time fix. However, the main goal of '-pr' is to make it easy
> to repair a full cluster without doing any duplication of work. Doing the
> same only within a data-center is obviously desirable.
> I think a reasonably simple solution would be modify the behavior of '-pr'
> when it's limited to only one DC. If applied to nodeX in dcY, instead of
> repairing only the "primary" range of nodeX for the whole ring, we'll repair
> that range but also all ranges that are "primary" for a node not in dcY and
> for which nodeX is the first node of dcY found in ring order. Basically we'll
> ensure that running 'repair -local -pr' on every nodes of a given DC will
> repair all ranges for the nodes of that DC without repairing the same range
> twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9143) Fix consistency of incrementally repaired data across replicas
[ https://issues.apache.org/jira/browse/CASSANDRA-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340040#comment-17340040 ] Laurenceau Julien commented on CASSANDRA-9143: -- Hi, For those of us using old version, does someone have a script to share to manually fix the "repair" metadata of sstables based on a log of failed anticompaction and void running full repair ? Regards > Fix consistency of incrementally repaired data across replicas > -- > > Key: CASSANDRA-9143 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9143 > Project: Cassandra > Issue Type: Improvement >Reporter: Sankalp Kohli >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0, 4.0-alpha1 > > > We currently send an anticompaction request to all replicas. During this, a > node will split stables and mark the appropriate ones repaired. > The problem is that this could fail on some replicas due to many reasons > leading to problems in the next repair. > This is what I am suggesting to improve it. > 1) Send anticompaction request to all replicas. This can be done at session > level. > 2) During anticompaction, stables are split but not marked repaired. > 3) When we get positive ack from all replicas, coordinator will send another > message called markRepaired. > 4) On getting this message, replicas will mark the appropriate stables as > repaired. > This will reduce the window of failure. We can also think of "hinting" > markRepaired message if required. > Also the stables which are streaming can be marked as repaired like it is > done now. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
