[jira] [Created] (CASSANDRA-11049) Conflicting definitions of VERSION string when compiling cassandra_constants

2016-01-20 Thread Peter Butler (JIRA) 
Peter Butler created CASSANDRA-11049:


 Summary: Conflicting definitions of VERSION string when compiling 
cassandra_constants
 Key: CASSANDRA-11049
 URL: https://issues.apache.org/jira/browse/CASSANDRA-11049
 Project: Cassandra
  Issue Type: Bug
  Components: Configuration
Reporter: Peter Butler


When compiling c++ code, as generated via thrift (latest version of thrift from 
git repository as of January 19 2016), there are conflicting versions of the 
VERSION constant in cassandra_constant.*   The specific error is:

cassandra_constants.h:18:15: error: expected unqualified-id before string 
constant
cassandra_constants.cpp: In constructor 
‘org::apache::cassandra::cassandraConstants::cassandraConstants()’:
cassandra_constants.cpp:14:17: error: assignment of read-only location 
‘"1.0.0-dev"’
cassandra_constants.cpp:14:17: error: incompatible types in assignment of 
‘const char [8]’ to ‘const char [10]’

The location of the original definition is in the thrift include files in 
config.h:

/* Version number of package */
#define VERSION "1.0.0-dev"

and the 2nd definition is in cassandra_constants.cpp

cassandraConstants::cassandraConstants() {
  VERSION = "19.36.0";

Note that while the thrift version is up-to-date, the cassandra version we are 
using is older.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11049) Conflicting definitions of VERSION string when compiling cassandra_constants

2016-01-20 Thread Peter Butler (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109590#comment-15109590
 ] 

Peter Butler commented on CASSANDRA-11049:
--

P.S.  I should probably also point out that I also had to follow the hack shown 
at https://github.com/Orange-OpenSource/YACassandraPDO/issues/75 to resolve 
other discrepancies.  The hack in question is this, and is performed after 
running "thrift --gen cpp cassandra.thrift":

sed -i 
"s/apache::thrift::protocol::TInputRecursionTracker/::apache::thrift::protocol::TInputRecursionTracker/"
 gen-cpp/Cassandra.cpp gen-cpp/cassandra_types.cpp
 sed -i 
"s/apache::thrift::protocol::TOutputRecursionTracker/::apache::thrift::protocol::TOutputRecursionTracker/"
 gen-cpp/Cassandra.cpp gen-cpp/cassandra_types.cpp

> Conflicting definitions of VERSION string when compiling cassandra_constants
> 
>
> Key: CASSANDRA-11049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11049
> Project: Cassandra
>  Issue Type: Bug
>  Components: Configuration
>Reporter: Peter Butler
>
> When compiling c++ code, as generated via thrift (latest version of thrift 
> from git repository as of January 19 2016), there are conflicting versions of 
> the VERSION constant in cassandra_constant.*   The specific error is:
> cassandra_constants.h:18:15: error: expected unqualified-id before string 
> constant
> cassandra_constants.cpp: In constructor 
> ‘org::apache::cassandra::cassandraConstants::cassandraConstants()’:
> cassandra_constants.cpp:14:17: error: assignment of read-only location 
> ‘"1.0.0-dev"’
> cassandra_constants.cpp:14:17: error: incompatible types in assignment of 
> ‘const char [8]’ to ‘const char [10]’
> The location of the original definition is in the thrift include files in 
> config.h:
> /* Version number of package */
> #define VERSION "1.0.0-dev"
> and the 2nd definition is in cassandra_constants.cpp
> cassandraConstants::cassandraConstants() {
>   VERSION = "19.36.0";
> Note that while the thrift version is up-to-date, the cassandra version we 
> are using is older.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11049) Conflicting definitions of VERSION string when compiling cassandra_constants

2016-01-20 Thread Peter Butler (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109614#comment-15109614
 ] 

Peter Butler commented on CASSANDRA-11049:
--

Thanks for all the info.  Much appreciated.

> Conflicting definitions of VERSION string when compiling cassandra_constants
> 
>
> Key: CASSANDRA-11049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11049
> Project: Cassandra
>  Issue Type: Bug
>  Components: Configuration
>Reporter: Peter Butler
>
> When compiling c++ code, as generated via thrift (latest version of thrift 
> from git repository as of January 19 2016), there are conflicting versions of 
> the VERSION constant in cassandra_constant.*   The specific error is:
> cassandra_constants.h:18:15: error: expected unqualified-id before string 
> constant
> cassandra_constants.cpp: In constructor 
> ‘org::apache::cassandra::cassandraConstants::cassandraConstants()’:
> cassandra_constants.cpp:14:17: error: assignment of read-only location 
> ‘"1.0.0-dev"’
> cassandra_constants.cpp:14:17: error: incompatible types in assignment of 
> ‘const char [8]’ to ‘const char [10]’
> The location of the original definition is in the thrift include files in 
> config.h:
> /* Version number of package */
> #define VERSION "1.0.0-dev"
> and the 2nd definition is in cassandra_constants.cpp
> cassandraConstants::cassandraConstants() {
>   VERSION = "19.36.0";
> Note that while the thrift version is up-to-date, the cassandra version we 
> are using is older.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11049) Conflicting definitions of VERSION string when compiling cassandra_constants

2016-01-20 Thread Peter Butler (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109586#comment-15109586
 ] 

Peter Butler commented on CASSANDRA-11049:
--

OK thanks Carl I will try that.  And renaming the cassandra.thrift-specific 
VERSION string (as opposed to touching the one in thrift) will not adversely 
affect anything else?

> Conflicting definitions of VERSION string when compiling cassandra_constants
> 
>
> Key: CASSANDRA-11049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11049
> Project: Cassandra
>  Issue Type: Bug
>  Components: Configuration
>Reporter: Peter Butler
>
> When compiling c++ code, as generated via thrift (latest version of thrift 
> from git repository as of January 19 2016), there are conflicting versions of 
> the VERSION constant in cassandra_constant.*   The specific error is:
> cassandra_constants.h:18:15: error: expected unqualified-id before string 
> constant
> cassandra_constants.cpp: In constructor 
> ‘org::apache::cassandra::cassandraConstants::cassandraConstants()’:
> cassandra_constants.cpp:14:17: error: assignment of read-only location 
> ‘"1.0.0-dev"’
> cassandra_constants.cpp:14:17: error: incompatible types in assignment of 
> ‘const char [8]’ to ‘const char [10]’
> The location of the original definition is in the thrift include files in 
> config.h:
> /* Version number of package */
> #define VERSION "1.0.0-dev"
> and the 2nd definition is in cassandra_constants.cpp
> cassandraConstants::cassandraConstants() {
>   VERSION = "19.36.0";
> Note that while the thrift version is up-to-date, the cassandra version we 
> are using is older.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)