[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151548#comment-14151548 ] Vladislav Sinjavin commented on CASSANDRA-7159: --- Hi Jeremiah! Just a gentle reminder about the patch review. Thanks in advance. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Assignee: Vladislav Sinjavin >Priority: Trivial > Labels: lhf > Fix For: 2.0.11 > > Attachments: > CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch > > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119908#comment-14119908 ] Vladislav Sinjavin commented on CASSANDRA-7159: --- Also, as I see, there is no serializer and deserializer for CellNameType. So, probably it will need to be implemented too. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Assignee: Vladislav Sinjavin >Priority: Trivial > Labels: lhf > Fix For: 2.0.11 > > Attachments: > CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch > > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118172#comment-14118172 ] Vladislav Sinjavin commented on CASSANDRA-7159: --- Thanks everyone for the reply. I'm quite new in the C* project. It looks like to me reasonable a third way to store comparator in the "validation" metadata. So, about the process. - Do I need to create a separate ticket about this approach implementation? - And what about first part of this ticket there is a patch but still no comments about it. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Assignee: Vladislav Sinjavin >Priority: Trivial > Labels: lhf > Fix For: 2.0.11 > > Attachments: > CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch > > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[
https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115295#comment-14115295
]
Vladislav Sinjavin edited comment on CASSANDRA-7159 at 8/29/14 2:51 PM:
Hi Sylvain!
Once more:)
Sorry in advance for many questions. Trying to understand about the
CellNameType comparator. As I see right now there is many implementations of
this interface. How to correct create this instance to deserialize ByteBuffer?
I was trying in that way:
CompositeType composite = CompositeType.getInstance(Arrays.asList(new
AbstractType[]{UTF8Type.instance, UTF8Type.instance}));
CellNameType cellNameType = CellNames.fromAbstractType(composite, false);
But it didn't help.
Another way to get comparator is to get from CFMetaData, but I can't see any
chance to get instance of this object with the help of descriptor of data file.
was (Author: vsinjavin):
Hi Sylvain!
Once more:)
Sorry in advance for many questions. Trying to understand about the
CellNameType comparator. As I see right now there is many implementations of
this interface. How to correct create this instance to deserialize ByteBuffer?
I was trying in that way:
CompositeType composite = CompositeType.getInstance(Arrays.asList(new
AbstractType[]{UTF8Type.instance, UTF8Type.instance}));
CellNameType cellNameType = CellNames.fromAbstractType(composite, false);
But it didn't help.
> sstablemetadata command should print some more stuff
>
>
> Key: CASSANDRA-7159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7159
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Jeremiah Jordan
>Assignee: Vladislav Sinjavin
>Priority: Trivial
> Labels: lhf
> Fix For: 2.0.11
>
> Attachments:
> CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch
>
>
> It would be nice if the sstablemetadata command printed out some more of the
> stuff we track. Like the Min/Max column names and the min/max token in the
> file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[
https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115295#comment-14115295
]
Vladislav Sinjavin commented on CASSANDRA-7159:
---
Hi Sylvain!
Once more:)
Sorry in advance for many questions. Trying to understand about the
CellNameType comparator. As I see right now there is many implementations of
this interface. How to correct create this instance to deserialize ByteBuffer?
I was trying in that way:
CompositeType composite = CompositeType.getInstance(Arrays.asList(new
AbstractType[]{UTF8Type.instance, UTF8Type.instance}));
CellNameType cellNameType = CellNames.fromAbstractType(composite, false);
But it didn't help.
> sstablemetadata command should print some more stuff
>
>
> Key: CASSANDRA-7159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7159
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Jeremiah Jordan
>Assignee: Vladislav Sinjavin
>Priority: Trivial
> Labels: lhf
> Fix For: 2.0.11
>
> Attachments:
> CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch
>
>
> It would be nice if the sstablemetadata command printed out some more of the
> stuff we track. Like the Min/Max column names and the min/max token in the
> file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladislav Sinjavin updated CASSANDRA-7159: -- Attachment: CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch Patch for part of the task. MinMax tokens. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Assignee: Vladislav Sinjavin >Priority: Trivial > Labels: lhf > Attachments: > CASSANDRA-7159_-_sstablemetadata_command_should_print_some_more_stuff.patch > > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110717#comment-14110717 ] Vladislav Sinjavin commented on CASSANDRA-7159: --- Hi Sylvain! Thanks for you response. Just one more comment. About the min/max column names. Are you talking about the CFMetaData class and CellNameType comparator? Also want to ask, I finished with min/max token but still working on min/max column names. Do I need to create one patch or can upload for min/max tokens and continue working on min/max column names? thanks in advance. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Assignee: Vladislav Sinjavin >Priority: Trivial > Labels: lhf > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[
https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106710#comment-14106710
]
Vladislav Sinjavin commented on CASSANDRA-7159:
---
Hi Sylvain!
Thanks for your quick response.
About the min/max column names. With the help of the unit tests for the
SSTableMetadataViewer I found out that there is a ByteBufferUtil class and it
look's like it can deserialize correctly column names:
ByteBufferUtil.string(buffer). What do you mean that we can use comparator of
the sstable?
About the min/max token. Thanks for you help, I see this fields in the SSTable
class as you said but I can't see an easy way to get an instance of this object
just with the help of the *.db file.
Probably we can get an instance of the ColumnFamilyStore
(Keyspace.open(KEYSPACE1).getColumnFamilyStore("Counter1")) and then but I
think it's not a correct way. Please, could you advise?
Thanks in advance!
> sstablemetadata command should print some more stuff
>
>
> Key: CASSANDRA-7159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7159
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Jeremiah Jordan
>Assignee: Vladislav Sinjavin
>Priority: Trivial
> Labels: lhf
>
> It would be nice if the sstablemetadata command printed out some more of the
> stuff we track. Like the Min/Max column names and the min/max token in the
> file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105341#comment-14105341 ] Vladislav Sinjavin commented on CASSANDRA-7159: --- Hi! Sorry in advance maybe for my next trivial questions. I'm a quite new person in the C* world. But I'd like to contribute in this project and help it grow faster. So, Jeremiah, as I see you suggest two improvements: - min/max column names ; - min/max token. 1) As I see right now min/max column names is a part of the StatsMetadata object. And they have List type. Am I right that we need to deserialize it and print in comfortable format? 2) About the min/max token. I can't find such kind of information in stats metadata. Could you advise what is a purpose of min/max tokens and where they stored? Thanks in advance. Once more sorry if my questions are too trivial. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Priority: Trivial > Labels: lhf > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CASSANDRA-7159) sstablemetadata command should print some more stuff
[ https://issues.apache.org/jira/browse/CASSANDRA-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105341#comment-14105341 ] Vladislav Sinjavin edited comment on CASSANDRA-7159 at 8/21/14 12:47 PM: - Hi! Sorry in advance for my next questions. I'm a quite a new person in the C* world. But I'd like to contribute in this project and help it grow faster. So, Jeremiah, as I see you suggest two improvements: - min/max column names ; - min/max token. 1) As I see right now min/max column names is a part of the StatsMetadata object. And they have List type. Am I right that we need to deserialize it and print in comfortable format? 2) About the min/max token. I can't find such kind of information in stats metadata. Could you advise what is a purpose of min/max tokens and where they stored? Thanks in advance. Once more sorry if my questions are too trivial. was (Author: vsinjavin): Hi! Sorry in advance maybe for my next trivial questions. I'm a quite new person in the C* world. But I'd like to contribute in this project and help it grow faster. So, Jeremiah, as I see you suggest two improvements: - min/max column names ; - min/max token. 1) As I see right now min/max column names is a part of the StatsMetadata object. And they have List type. Am I right that we need to deserialize it and print in comfortable format? 2) About the min/max token. I can't find such kind of information in stats metadata. Could you advise what is a purpose of min/max tokens and where they stored? Thanks in advance. Once more sorry if my questions are too trivial. > sstablemetadata command should print some more stuff > > > Key: CASSANDRA-7159 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7159 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Priority: Trivial > Labels: lhf > > It would be nice if the sstablemetadata command printed out some more of the > stuff we track. Like the Min/Max column names and the min/max token in the > file. -- This message was sent by Atlassian JIRA (v6.2#6252)
