Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
lukasz-antoniak commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2191509703 @ajweave, @tolbertam, I have tried to solve my [comments](https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2135352720) and submitted PR to Andrew's fork: https://github.com/ajweave/java-driver/pull/1. Could you please review the changes and comment? I am not enforcing any of those, just trying cleanup already existing code a little. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1644818928
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -46,28 +47,46 @@ default void onSuccess(
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node) {}
+ /**
+ * @deprecated This method only exists for backward compatibility. Override
{@link
+ * #onSuccess(Request, long, DriverExecutionProfile, Node,
ExecutionInfo, String)} instead.
+ */
+ @Deprecated
+ default void onSuccess(
+ @NonNull Request request,
+ long latencyNanos,
+ @NonNull DriverExecutionProfile executionProfile,
+ @NonNull Node node,
+ @NonNull String requestLogPrefix) {
+// If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
+onSuccess(request, latencyNanos, executionProfile, node);
+ }
+
/**
* Invoked each time a request succeeds.
*
* @param latencyNanos the overall execution time (from the {@link
Session#execute(Request,
* GenericType) session.execute} call until the result is made available
to the client).
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
+ * @param executionInfo the execution info containing the results of this
request
* @param requestLogPrefix the dedicated log prefix for this request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
+ @NonNull ExecutionInfo executionInfo,
@NonNull String requestLogPrefix) {
-// If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
-onSuccess(request, latencyNanos, executionProfile, node);
+// If client doesn't override onSuccess with executionInfo delegate call
to the old method
Review Comment:
Good point. As long as we retain and deprecate the old method signatures
for backwards-compatability, I'm good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1644773185
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -46,28 +47,46 @@ default void onSuccess(
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node) {}
+ /**
+ * @deprecated This method only exists for backward compatibility. Override
{@link
+ * #onSuccess(Request, long, DriverExecutionProfile, Node,
ExecutionInfo, String)} instead.
+ */
+ @Deprecated
+ default void onSuccess(
+ @NonNull Request request,
+ long latencyNanos,
+ @NonNull DriverExecutionProfile executionProfile,
+ @NonNull Node node,
+ @NonNull String requestLogPrefix) {
+// If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
+onSuccess(request, latencyNanos, executionProfile, node);
+ }
+
/**
* Invoked each time a request succeeds.
*
* @param latencyNanos the overall execution time (from the {@link
Session#execute(Request,
* GenericType) session.execute} call until the result is made available
to the client).
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
+ * @param executionInfo the execution info containing the results of this
request
* @param requestLogPrefix the dedicated log prefix for this request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
+ @NonNull ExecutionInfo executionInfo,
@NonNull String requestLogPrefix) {
-// If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
-onSuccess(request, latencyNanos, executionProfile, node);
+// If client doesn't override onSuccess with executionInfo delegate call
to the old method
Review Comment:
@lukasz-antoniak and I thought we don't need the parameter `request`,
`executionProfile`, and `node` here, because they are all contained in
`executionInfo` object. So we can change it to:
```java
default void onSuccess(
long latencyNanos,
@NonNull ExecutionInfo executionInfo,
onSuccess(executionInfo.getRequest(), latencyNanos,
executionInfo.getExecutionProfile(), executionInfo.getCoordinator(),
requestLogPrefix);
}
```
If we leave it like it is, the user may be confused if the ones in the
parameters and the ones in `exeuctionInfo` Object are not consistent.
@absurdfarce @adutra How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
absurdfarce commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2174565098 A quick status update here: there's some overlap between the changes in this PR and some changes being proposed in @chibenwa's [PR](https://github.com/apache/cassandra-java-driver/pull/1623) to minimize the number of resolutions of ExecutionProfile in CqlRequestHandler. Since that PR is quite a bit smaller and simpler I'd like to get it in first and then rebase this PR against those changes; doing it the other way around seems like a lot more work :). I've mentioned this relationship to the other committers on ASF Slack so hopefully we can get the other PR in quickly... we'll see how that goes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
lukasz-antoniak commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2135352720
Good work @ajweave, sorry to keep you waiting. Two things to consider from
my end. Feel free to disagree since both are more of coding style category.
In request handlers (e.g. `CqlRequestHandler`), we very frequently do two
things with same arguments:
```
trackNodeError(node, error, NANOTIME_NOT_MEASURED_YET);
setFinalError(statement, error, node, execution);
```
Both methods create their own instance of `DefaultExecutionInfo` internally.
Shall we create the `ExecutionInfo` outside and pass it as parameter? Some of
the other parameters like `statement` or `node`, could be taken from
`ExecutionInfo` and not passed individually. When we use `NoopRequestTracker`,
we do not need to create `DefaultExecutionInfo` inside `trackNodeError`, but
still it would be needed in `setFinalError`, so we shall not degrade
performance in this case.
All of this can be done, because we decide to construct `ExecutionInfo` for
all exceptional executions, not only once resulting in `DriverException`.
Anyway, most of the time we would see `DriverException` being raised.
`DefaultExecutionInfo` has few optional parameters, but from what I see, we
use the constructor in different contexts. What do you think about making this
constructor private and expose `create(...)` methods to indicate what type of
`DefaultExecutionInfo` we are going to pass? Also, would move `pagingState`
calculation inside (currently code copied across different request handlers).
```
/** Use when driver failed to send the request to the server, or we did
not receive any response. */
public static DefaultExecutionInfo create(Request request, Node
coordinator, int speculativeExecutionCount,
int successfulExecutionIndex,
List> errors,
DefaultSession session,
InternalDriverContext context,
DriverExecutionProfile
executionProfile) {
return create(request, coordinator, speculativeExecutionCount,
successfulExecutionIndex, errors,
null, null, true, session, context, executionProfile);
}
/** Use when driver received the response, but operation result remains
unknown. */
public static DefaultExecutionInfo create(Request request, Node
coordinator, int speculativeExecutionCount,
int successfulExecutionIndex,
List> errors,
Frame frame, DefaultSession
session, InternalDriverContext context,
DriverExecutionProfile
executionProfile) {
return create(request, coordinator, speculativeExecutionCount,
successfulExecutionIndex, errors,
null, frame, true, session, context, executionProfile);
}
public static DefaultExecutionInfo create(Request request, Node
coordinator, int speculativeExecutionCount,
int successfulExecutionIndex,
List> errors,
Result resultMessage, Frame
frame, boolean schemaInAgreement,
DefaultSession session,
InternalDriverContext context,
DriverExecutionProfile
executionProfile) {
final ByteBuffer pagingState =
(resultMessage instanceof Rows) ? ((Rows)
resultMessage).getMetadata().pagingState : null;
return new DefaultExecutionInfo(request, coordinator,
speculativeExecutionCount, successfulExecutionIndex, errors,
pagingState, frame, schemaInAgreement, session, context,
executionProfile);
}
```
I was even thinking of changing the three `create(...)` methods into
different names like, `of`, `ofClientError`, `ofServerError`. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1596024998
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -52,20 +68,23 @@ default void onSuccess(
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
* @param requestLogPrefix the dedicated log prefix for this request
+ * @param executionInfo the execution info containing the results of this
request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
-// If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
-onSuccess(request, latencyNanos, executionProfile, node);
+ @NonNull String requestLogPrefix,
Review Comment:
Refactored to make requestLogPrefix the last arg in all the methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1596015592
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
* @param requestLogPrefix the dedicated log prefix for this request
+ * @param executionInfo the execution info containing the results of this
request
*/
default void onNodeSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
-// If client doesn't override onNodeSuccess with requestLogPrefix delegate
call to the old
-// method
-onNodeSuccess(request, latencyNanos, executionProfile, node);
+ @NonNull String requestLogPrefix,
+ @NonNull ExecutionInfo executionInfo) {
+// delegate call to the old method
+onNodeSuccess(request, latencyNanos, executionProfile, node,
requestLogPrefix);
Review Comment:
Changes to `ContinuousRequestHandlerBase` merged. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
adutra commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1595217254
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -52,20 +68,23 @@ default void onSuccess(
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
* @param requestLogPrefix the dedicated log prefix for this request
+ * @param executionInfo the execution info containing the results of this
request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
-// If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
-onSuccess(request, latencyNanos, executionProfile, node);
+ @NonNull String requestLogPrefix,
Review Comment:
Small request: would it be possible to keep the log prefix as the _last_
parameter? This has been kind of a tacit convention so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
ajweave commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2101654238 Sorry for the delay. I will get this done tomorrow. I appreciate the attention here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
SiyaoIsHiding commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2101624573 May you please merge apache/4.x to your branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1594781483
##
core/src/main/java/com/datastax/dse/driver/internal/core/cql/continuous/ContinuousRequestHandlerBase.java:
##
@@ -1590,18 +1597,20 @@ private void completeResultSetFuture(
private ExecutionInfo createExecutionInfo(@NonNull Result result,
@Nullable Frame response) {
ByteBuffer pagingState =
result instanceof Rows ? ((Rows) result).getMetadata().pagingState :
null;
- return new DefaultExecutionInfo(
- statement,
- node,
- startedSpeculativeExecutionsCount.get(),
- executionIndex,
- errors,
- pagingState,
- response,
- true,
- session,
- context,
- executionProfile);
+ this.executionInfo =
Review Comment:
It's a bit of work to set up. I ran all the tests against this branch, and
it passed all the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1587797662
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
* @param requestLogPrefix the dedicated log prefix for this request
+ * @param executionInfo the execution info containing the results of this
request
*/
default void onNodeSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
-// If client doesn't override onNodeSuccess with requestLogPrefix delegate
call to the old
-// method
-onNodeSuccess(request, latencyNanos, executionProfile, node);
+ @NonNull String requestLogPrefix,
+ @NonNull ExecutionInfo executionInfo) {
+// delegate call to the old method
+onNodeSuccess(request, latencyNanos, executionProfile, node,
requestLogPrefix);
Review Comment:
I also explored how to pass in ExecutionInfo from
ContinuousRequestHandlerBase, see
[here](https://github.com/SiyaoIsHiding/java-driver/compare/4.x...SiyaoIsHiding:java-driver:request-tracker-execution-info?expand=1).
How do you think of this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1586980425
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
* @param requestLogPrefix the dedicated log prefix for this request
+ * @param executionInfo the execution info containing the results of this
request
*/
default void onNodeSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
-// If client doesn't override onNodeSuccess with requestLogPrefix delegate
call to the old
-// method
-onNodeSuccess(request, latencyNanos, executionProfile, node);
+ @NonNull String requestLogPrefix,
+ @NonNull ExecutionInfo executionInfo) {
+// delegate call to the old method
+onNodeSuccess(request, latencyNanos, executionProfile, node,
requestLogPrefix);
Review Comment:
Can we do this in `CqlRequestHandler.NodeResponseCallback.trackNodeError`?
```java
private void trackNodeError(Node node, Throwable error, long
nodeResponseTimeNanos) {
if (requestTracker instanceof NoopRequestTracker) {
return;
}
if (nodeResponseTimeNanos == NANOTIME_NOT_MEASURED_YET) {
nodeResponseTimeNanos = System.nanoTime();
}
long latencyNanos = nodeResponseTimeNanos - this.nodeStartTimeNanos;
ExecutionInfo executionInfo =
new DefaultExecutionInfo(
statement,
node,
startedSpeculativeExecutionsCount.get(),
execution,
errors,
null,
null,
true,
session,
context,
executionProfile);
requestTracker.onNodeError(
statement, error, latencyNanos, executionProfile, node, logPrefix,
executionInfo);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
absurdfarce commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2087323844 Ping @SiyaoIsHiding for (hopefully) another review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
vanditsramblings commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1995012337 +1 , this would be a great addition , allowing more granular access to execution metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
ajweave commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1838710385 @hhughes , @absurdfarce , gentle reminder to review these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]
ajweave commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1802288303 Now that the donation to Apache is complete, I'd like to move forward with this change. @hhughes , @absurdfarce , please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
