[jira] [Comment Edited] (CASSANDRA-10358) Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter
[
https://issues.apache.org/jira/browse/CASSANDRA-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985731#comment-14985731
]
Andre Turgeon edited comment on CASSANDRA-10358 at 11/2/15 6:53 PM:
Thanks for the feedback [~slebresne]. I forgot to mention another requirement I
have: I need to control the level at which a SSTable is created.
How would you feel about having a SSTableWriter creation strategy? Something
like this:
{quote}
public interface SSTableWriterCreationStrategy {
SSTableWriter createWriter(File directory, CFMetaData metadata);
}
{quote}
I submitted a patch with more details.
was (Author: symbiosix):
Thanks for the feedback [~slebresne]. I forgot to mention another requirement I
have: I need to control the level at which an SSTable is created.
How would you feel about having a SSTableWriter creation strategy? Something
like this:
public interface SSTableWriterCreationStrategy {
SSTableWriter createWriter(File directory, CFMetaData metadata);
}
I submitted a patch with more details.
> Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter
> -
>
> Key: CASSANDRA-10358
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10358
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Andre Turgeon
>Priority: Minor
> Attachments: SSTableWriterCreationStrategy.patch, patch.txt
>
>
> I've created a patch for your consideration.
> This change to CQLSSTableWriter allows for a custom
> AbstractSSTableSimpleWriter to be specified.
> I needed this for a bulkload process I wrote. I believe the change would be
> beneficial for other people as well.
> Below are the reasons I needed a custom implementation of
> AbstractSSTableSimpleWriter:
> 1) The available implementations of AbstractSSTableSimpleWriter do not
> provide a way to specify the filename (or rather revision) of the sstable. I
> needed to control the name because my bulkload process write sstables in
> parallel (on multiple machines) and I wish to avoid name collisions.
> 2) I discovered a problem with SSTableSimpleUnsortedWriter where it creates
> invalid level-compaction-style sstables; It allows a partition to span 2
> sstables which violates the "no overlap of token ranges" constraint of level
> compaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-10358) Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter
[
https://issues.apache.org/jira/browse/CASSANDRA-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985731#comment-14985731
]
Andre Turgeon edited comment on CASSANDRA-10358 at 11/2/15 6:54 PM:
Thanks for the feedback [~slebresne]. I forgot to mention another requirement I
have: I need to control the level at which a SSTable is created.
How would you feel about having a SSTableWriter creation strategy? Something
like this:
{noformat}
public interface SSTableWriterCreationStrategy {
SSTableWriter createWriter(File directory, CFMetaData metadata);
}
{noformat}
I submitted a patch with more details.
was (Author: symbiosix):
Thanks for the feedback [~slebresne]. I forgot to mention another requirement I
have: I need to control the level at which a SSTable is created.
How would you feel about having a SSTableWriter creation strategy? Something
like this:
{quote}
public interface SSTableWriterCreationStrategy {
SSTableWriter createWriter(File directory, CFMetaData metadata);
}
{quote}
I submitted a patch with more details.
> Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter
> -
>
> Key: CASSANDRA-10358
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10358
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Andre Turgeon
>Priority: Minor
> Attachments: SSTableWriterCreationStrategy.patch, patch.txt
>
>
> I've created a patch for your consideration.
> This change to CQLSSTableWriter allows for a custom
> AbstractSSTableSimpleWriter to be specified.
> I needed this for a bulkload process I wrote. I believe the change would be
> beneficial for other people as well.
> Below are the reasons I needed a custom implementation of
> AbstractSSTableSimpleWriter:
> 1) The available implementations of AbstractSSTableSimpleWriter do not
> provide a way to specify the filename (or rather revision) of the sstable. I
> needed to control the name because my bulkload process write sstables in
> parallel (on multiple machines) and I wish to avoid name collisions.
> 2) I discovered a problem with SSTableSimpleUnsortedWriter where it creates
> invalid level-compaction-style sstables; It allows a partition to span 2
> sstables which violates the "no overlap of token ranges" constraint of level
> compaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
