[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 8/3/16 2:35 PM: |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-trunk?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/3/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/3/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. was (Author: aweisberg): |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-trunk?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.10 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 8/3/16 2:34 PM: |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-trunk?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. was (Author: aweisberg): |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-trunk?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.10 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 8/3/16 2:31 PM: |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-trunk?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. was (Author: aweisberg): |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.10 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 8/2/16 5:30 PM: |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[dtest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. was (Author: aweisberg): |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404078#comment-15404078 ] Marcus Eriksson edited comment on CASSANDRA-12228 at 8/2/16 2:43 PM: - Since 6696 the configuration sets how many flush writers there should be *per data directory* - so factoring in the number of data directories in the calculation is probably wrong (ie, with 10 data directories and 2 memtable flush writers you would get 20 threads actually doing writing to disk and 2 threads waiting on the writing, meaning we can flush 2 memtables concurrently) edit: re-read your yaml comment where you explain exactly what I wrote above :) - but why would we want more threads per data directory if we have more data directories? was (Author: krummas): Since 6696 the configuration sets how many flush writers there should be *per data directory* - so factoring in the number of data directories in the calculation is probably wrong (ie, with 10 data directories and 2 memtable flush writers you would get 20 threads actually doing writing to disk and 2 threads waiting on the writing, meaning we can flush 2 memtables concurrently) > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 8/2/16 1:45 AM: |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. was (Author: aweisberg): |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400133#comment-15400133 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 7/29/16 10:28 PM: -- There are some remaining issues with thread pool sizes. See [CASSANDRA-12071|https://issues.apache.org/jira/browse/CASSANDRA-12071?focusedCommentId=15400086=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15400086]. You still can't get multiple threads if you have a single disk due to TPE not spinning up additional threads if you are using an unbounded queue. Seems like this would be a good place to address the related issue. I also don't think this is minor it's pretty crippling for performance and you can't work around it by changing configuration values. was (Author: aweisberg): There are some remaining issues with thread pool sizes. See [CASSANDRA-12071|https://issues.apache.org/jira/browse/CASSANDRA-12071?focusedCommentId=15400086=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15400086]. You still can't get multiple threads if you have a single disk. Seems like this would be a good place to address the related issue. I also don't think this is minor it's pretty crippling for performance and you can't work around it by changing configuration values. > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
