[jira] [Comment Edited] (CASSANDRA-12701) Repair history tables should have TTL and TWCS
[ https://issues.apache.org/jira/browse/CASSANDRA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15560934#comment-15560934 ] Nate McCall edited comment on CASSANDRA-12701 at 10/10/16 1:07 AM: --- [~jjirsa] -+1 Patch looks fine.- Your linked tests have failures, but have nothing to do with these system tables and are on several recent builds. (Thanks, [~bradfordcp]!) EDIT: Was just discussing with [~jjirsa] and I'm wondering how this works in an "upgrade" scenario. Going to go poke around for some precedent and ping the dev list about such. was (Author: zznate): [~jjirsa] +1 Patch looks fine. Your linked tests have failures, but have nothing to do with these system tables and are on several recent builds. (Thanks, [~bradfordcp]!) > Repair history tables should have TTL and TWCS > -- > > Key: CASSANDRA-12701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12701 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Chris Lohfink > Labels: lhf > Attachments: CASSANDRA-12701.txt > > > Some tools schedule a lot of small subrange repairs which can lead to a lot > of repairs constantly being run. These partitions can grow pretty big in > theory. I dont think much reads from them which might help but its still > kinda wasted disk space. I think a month TTL (longer than gc grace) and maybe > a 1 day twcs window makes sense to me. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12701) Repair history tables should have TTL and TWCS
[ https://issues.apache.org/jira/browse/CASSANDRA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554246#comment-15554246 ] Jeff Jirsa edited comment on CASSANDRA-12701 at 10/7/16 6:10 AM: - Thanks for the patch [~bradfordcp]. Haven't reviewed, but pushing to CI | [Trunk|https://github.com/jeffjirsa/cassandra/tree/cassandra-12701] | [utest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-testall/] | [dtest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-dtest/] | | [3.X|https://github.com/jeffjirsa/cassandra/tree/cassandra-12701-3.X] | [utest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-3.X-testall/] | [dtest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-3.X-dtest/] | was (Author: jjirsa): Thanks for the patch [~bradfordcp]. Haven't yet reviewed, but pushing to CI and will review shortly. | [Trunk|https://github.com/jeffjirsa/cassandra/tree/cassandra-12701] | [utest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-testall/] | [dtest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-dtest/] | | [3.X|https://github.com/jeffjirsa/cassandra/tree/cassandra-12701-3.X] | [utest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-3.X-testall/] | [dtest|http://cassci.datastax.com/job/jeffjirsa-cassandra-12701-3.X-dtest/] | > Repair history tables should have TTL and TWCS > -- > > Key: CASSANDRA-12701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12701 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Chris Lohfink > Labels: lhf > Attachments: CASSANDRA-12701.txt > > > Some tools schedule a lot of small subrange repairs which can lead to a lot > of repairs constantly being run. These partitions can grow pretty big in > theory. I dont think much reads from them which might help but its still > kinda wasted disk space. I think a month TTL (longer than gc grace) and maybe > a 1 day twcs window makes sense to me. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
