[jira] [Comment Edited] (CASSANDRA-13720) Clean up repair code
[ https://issues.apache.org/jira/browse/CASSANDRA-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396044#comment-17396044 ] Ekaterina Dimitrova edited comment on CASSANDRA-13720 at 8/9/21, 1:26 PM: -- CI looks good. bq. Removing the unused startTime argument looks good to me, +1. Maybe the cmd argument in createQueryThread could also be removed, since it's not used anymore. I left the same comment about _cmd_ in _createQueryThread_ [here|https://github.com/apache/cassandra/pull/1126#pullrequestreview-720416704] last week. My only question is whether we want to do more cleaning of the warnings of that class or stick only to the unused arguments? was (Author: e.dimitrova): CI looks good. bq. Removing the unused startTime argument looks good to me, +1. Maybe the cmd argument in createQueryThread could also be removed, since it's not used anymore. I left the same comment about _cmd_ in _createQueryThread_ [here|https://github.com/apache/cassandra/pull/1126#pullrequestreview-720416704] last week. My only question is whether we want to do more cleaning of the warnings of that class or stick only to the unused arguments? > Clean up repair code > > > Key: CASSANDRA-13720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13720 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: Simon Zhou >Assignee: Simon Zhou >Priority: Normal > Fix For: 4.x > > > Lots of unused code. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13720) Clean up repair code
[
https://issues.apache.org/jira/browse/CASSANDRA-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374659#comment-17374659
]
Benjamin Lerer edited comment on CASSANDRA-13720 at 7/5/21, 8:22 AM:
-
{quote}wow, it's a long time{quote}
Sorry, for that. :(
We are working on some solutions to try to avoid that kind of problem in the
future. Right now we are going through our backlog of {{Patch Available}}
tickets.
I will just put the ticket {{In Progress}} so that we know you are working on
it.
was (Author: blerer):
{quote}wow, it's a long time{quote}
Sorry, for that. :(
We are working on some solutions to try to avoid that kind of problem in the
future. Right now we are going through out backlog of {{Patch Available}}
tickets.
I will just put the ticket {{In Progress}} so that we know you are working on
it.
> Clean up repair code
>
>
> Key: CASSANDRA-13720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13720
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Simon Zhou
>Assignee: Simon Zhou
>Priority: Normal
> Fix For: 4.x
>
>
> Lots of unused code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13720) Clean up repair code
[
https://issues.apache.org/jira/browse/CASSANDRA-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374659#comment-17374659
]
Benjamin Lerer edited comment on CASSANDRA-13720 at 7/5/21, 8:21 AM:
-
{quote}wow, it's a long time{quote}
Sorry, for that. :(
We are working on some solutions to try to avoid that kind of problem in the
future. Right now we are going through out backlog of {{Patch Available}}
tickets.
I will just put the ticket {{In Progress}} so that we know you are working on
it.
was (Author: blerer):
{quote}wow, it's a long time{quote}
Sorry, for that. :(
We are working on some solutions to try to avoid that kind of problem in the
future. Right now we are going through out backlog of {{Patch Available}}
tickets.
> Clean up repair code
>
>
> Key: CASSANDRA-13720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13720
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Simon Zhou
>Assignee: Simon Zhou
>Priority: Normal
> Fix For: 4.x
>
>
> Lots of unused code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
