[jira] [Comment Edited] (CASSANDRA-14119) uTest cql3.ViewTest timeout
[
https://issues.apache.org/jira/browse/CASSANDRA-14119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290936#comment-16290936
]
Jason Brown edited comment on CASSANDRA-14119 at 12/14/17 2:56 PM:
---
tbh, I've thought about it this morning, and moving {{ViewTest}} /
{{ViewComplexTest}} into {{long-test}} is essentially the same as bumping the
timeout. Worse, moving them into {{long-test}} reduces the likelihood of
execution (not everyone knows about nor runs {{long-test}}).
I think the better option here is to break up those tests. A reasonable
grouping of test methods into subclasses should be sufficient; you don't have
to go bananas.
I'll review as I've already commented enough here ;)
was (Author: jasobrown):
tbh, I've thought about it this morning, and basically moving {{ViewTest}} /
{{ViewComplexTest}} into {{long-test}} is essentially the same as bumping the
timeout. Worse, moving them into {{long-test}} reduces the likelihood of
execution (not everyone knows about nor runs {{long-test}}).
I think the better option here is to break up those tests. A reasonable
grouping of test methods into subclasses should be sufficient; you don't have
to go bananas.
I'll review as I've already commented enough here ;)
> uTest cql3.ViewTest timeout
> ---
>
> Key: CASSANDRA-14119
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14119
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jay Zhuang
> Labels: Testing
>
> It's failing a lot in
> [CircleCI|https://circleci.com/gh/cooldoger/cassandra/163#tests/containers/0],
> also locally:
> {noformat}
> $ ant test -Dtest.name=ViewTest
> ...
> [parallel] 2017-12-13 22:23:27
> [parallel] Full thread dump Java HotSpot(TM) 64-Bit Server VM (25.111-b14
> mixed mode):
> [parallel]
> [parallel] "Attach Listener" #453 daemon prio=9 os_prio=0
> tid=0x7fc6d0002000 nid=0xd16b waiting on condition [0x]
> [parallel]java.lang.Thread.State: RUNNABLE
> [parallel]
> [parallel]Locked ownable synchronizers:
> [parallel] - None
> [parallel]
> [parallel] "MutationStage-6" #404 daemon prio=1 os_prio=0
> tid=0x7fc584003800 nid=0xca90 waiting on condition [0x7fc69c816000]
> [parallel]java.lang.Thread.State: WAITING (parking)
> [parallel] at sun.misc.Unsafe.park(Native Method)
> [parallel] at
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:304)
> [parallel] at
> org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:87)
> [parallel] at java.lang.Thread.run(Thread.java:745)
> [parallel]
> [parallel]Locked ownable synchronizers:
> [parallel] - None
> [parallel]
> ...
> [junit] Testsuite: org.apache.cassandra.cql3.ViewTest
> [junit] Testsuite: org.apache.cassandra.cql3.ViewTest Tests run: 1,
> Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
> [junit]
> [junit] Testcase:
> org.apache.cassandra.cql3.ViewTest:testBuilderWidePartition: Caused an
> ERROR
> [junit] Timeout occurred. Please note the time in the report does not
> reflect the time until the timeout.
> [junit] junit.framework.AssertionFailedError: Timeout occurred. Please
> note the time in the report does not reflect the time until the timeout.
> [junit] at java.lang.Thread.run(Thread.java:745)
> [junit]
> [junit]
> [junit] Test org.apache.cassandra.cql3.ViewTest FAILED (timeout)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14119) uTest cql3.ViewTest timeout
[
https://issues.apache.org/jira/browse/CASSANDRA-14119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290936#comment-16290936
]
Jason Brown edited comment on CASSANDRA-14119 at 12/14/17 2:56 PM:
---
tbh, I've thought about it this morning, and basically moving {{ViewTest}} /
{{ViewComplexTest}} into {{long-test}} is essentially the same as bumping the
timeout. Worse, moving them into {{long-test}} reduces the likelihood of
execution (not everyone knows about nor runs {{long-test}}).
I think the better option here is to break up those tests. A reasonable
grouping of test methods into subclasses should be sufficient; you don't have
to go bananas.
I'll review as I've already commented enough here ;)
was (Author: jasobrown):
tbh, I've thought about it this morning, and basically moving {{ViewTest}} /
{{ViewComplexTest}} into {{long-test}} is essentially the same as bumping the
timeout. Worse, moving them into {{long-test}} reduces the likelihood of
execution (not everyone knows about nor runs {{long-test}}).
I think the better option here is to break up those tests. A reasonable
grouping of test methods into subclasses should be sufficient; you don't have
to go bananas.
I'll review the changes as I've already commented enough here ;)
> uTest cql3.ViewTest timeout
> ---
>
> Key: CASSANDRA-14119
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14119
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jay Zhuang
> Labels: Testing
>
> It's failing a lot in
> [CircleCI|https://circleci.com/gh/cooldoger/cassandra/163#tests/containers/0],
> also locally:
> {noformat}
> $ ant test -Dtest.name=ViewTest
> ...
> [parallel] 2017-12-13 22:23:27
> [parallel] Full thread dump Java HotSpot(TM) 64-Bit Server VM (25.111-b14
> mixed mode):
> [parallel]
> [parallel] "Attach Listener" #453 daemon prio=9 os_prio=0
> tid=0x7fc6d0002000 nid=0xd16b waiting on condition [0x]
> [parallel]java.lang.Thread.State: RUNNABLE
> [parallel]
> [parallel]Locked ownable synchronizers:
> [parallel] - None
> [parallel]
> [parallel] "MutationStage-6" #404 daemon prio=1 os_prio=0
> tid=0x7fc584003800 nid=0xca90 waiting on condition [0x7fc69c816000]
> [parallel]java.lang.Thread.State: WAITING (parking)
> [parallel] at sun.misc.Unsafe.park(Native Method)
> [parallel] at
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:304)
> [parallel] at
> org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:87)
> [parallel] at java.lang.Thread.run(Thread.java:745)
> [parallel]
> [parallel]Locked ownable synchronizers:
> [parallel] - None
> [parallel]
> ...
> [junit] Testsuite: org.apache.cassandra.cql3.ViewTest
> [junit] Testsuite: org.apache.cassandra.cql3.ViewTest Tests run: 1,
> Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
> [junit]
> [junit] Testcase:
> org.apache.cassandra.cql3.ViewTest:testBuilderWidePartition: Caused an
> ERROR
> [junit] Timeout occurred. Please note the time in the report does not
> reflect the time until the timeout.
> [junit] junit.framework.AssertionFailedError: Timeout occurred. Please
> note the time in the report does not reflect the time until the timeout.
> [junit] at java.lang.Thread.run(Thread.java:745)
> [junit]
> [junit]
> [junit] Test org.apache.cassandra.cql3.ViewTest FAILED (timeout)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
