[
https://issues.apache.org/jira/browse/CASSANDRA-14492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525752#comment-16525752
]
Patrick Bannister edited comment on CASSANDRA-14492 at 6/28/18 2:10 AM:
------------------------------------------------------------------------
The dtest test_number_separators_round_trip() in
cqlsh_tests/cqlsh_copy_tests.py already tests both of these features. Looking
further into why initial coverage analysis didn't catch that.
was (Author: ptbannister):
The dtest test_number_separators_round_trip() in
cqlsh_tests/cqlsh_copy_tests.py already tests both of these features. However,
since the test occurs in the context of COPY statements, it uses a different
code path: there's a separate integer formatting function used for COPY TO
statements, implemented in cqlshlib/copyutil.py, instead of the formatting
functions in cqlshlib/formatting.py.
It's interesting that we've implemented datatype formatting in more than one
place.
> Test use of thousands separators and comma decimal separators
> -------------------------------------------------------------
>
> Key: CASSANDRA-14492
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14492
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Patrick Bannister
> Priority: Major
> Labels: cqlsh, test
> Fix For: 4.x
>
>
> Coverage analysis showed no coverage for functions related to displaying
> numbers with thousands separators ("$100,000,000,000" instead of
> "$100000000000") and displaying numbers with custom decimal separators
> ("3,1415927" instead of "3.1415927").
> We should add a test that displays numbers like this, or identify an existing
> test that does it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
