[jira] [Comment Edited] (CASSANDRA-15050) JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821

2019-06-05 Thread Michael Shuler (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857200#comment-16857200
 ] 

Michael Shuler edited comment on CASSANDRA-15050 at 6/6/19 1:31 AM:


I can build on jdk8 and seem to be able to start {{./bin/cassandra}} after 
switching back to jdk7, but with the changes from CASSANDRA-14821, I don't 
understand how we can verify testing on jdk7 and jdk8, as this branch has 
always done, if build.xml now specifies we must use jdk8 in tests.
{noformat}
 
+
 
+
{noformat}

I'm unclear as to why such a breaking chnage was committed to the 2.2 branch - 
can we revert CASSANDRA-14821 [~ifesdjeen] to rework dual-JDK support for this 
branch or just leave it out entirely, going back to the previous working tests?


was (Author: mshuler):
I can build on jdk8 and seem to be able to start {{./bin/cassandra}} after 
switching back to jdk7, but with the changes from CASSANDRA-14821, I don't 
understand how we can verify testing on jdk7 and jdk8, as this branch has 
always done, if build.xml now specifies we must use jdk8 in tests.
{nofromat}
 
+
 
+
{noformat}

I'm unclear as to why such a breaking chnage was committed to the 2.2 branch - 
can we revert CASSANDRA-14821 [~ifesdjeen] to rework dual-JDK support for this 
branch or just leave it out entirely, going back to the previous working tests?

> JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
> -
>
> Key: CASSANDRA-15050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15050
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Michael Shuler
>Assignee: Ted Petersson
>Priority: Normal
> Fix For: 2.2.x
>
> Attachments: 15050-2.2.txt
>
>
> CASSANDRA-14821 introduced some errors on JDK7. The build fails as follows:
> {noformat}
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
> java version "1.7.0_80"
> Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ ant jar
> Buildfile: /home/mshuler/git/cassandra/build.xml
> init:
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
>    [mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
> maven-ant-tasks-localrepo:
> [copy] Copying 1 file to /home/mshuler/git/cassandra/build
> maven-ant-tasks-download:
> maven-ant-tasks-init:
> maven-declare-dependencies:
> maven-ant-tasks-retrieve-build:
> [artifact:dependencies] Building ant file: 
> /home/mshuler/git/cassandra/build/build-dependencies.xml
> [artifact:dependencies] Building ant file: 
> /home/mshuler/git/cassandra/build/build-dependencies-sources.xml
> [copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
> [copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
> [copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
>    [unzip] Expanding: 
> /home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar
>  into /home/mshu
> ler/git/cassandra/build/lib/jars
> check-gen-cql3-grammar:
> gen-cql3-grammar:
> [echo] Building Grammar 
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g  ...
> generate-cql-html:
> build-project:
> [echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
>    [javac] Compiling 45 source files to 
> /home/mshuler/git/cassandra/build/classes/thrift
>    [javac] warning: Supported source version 'RELEASE_6' from annotation 
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
>    [javac] Note: 
> /home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
>  uses o
> r overrides a deprecated API.
>    [javac] Note: Recompile with -Xlint:deprecation for details.
>    [javac] Note: Some input files use unchecked or unsafe operations.
>    [javac] Note: Recompile with -Xlint:unchecked for details.
>    [javac] 1 warning
>    [javac] Compiling 1171 source files to 
> /home/mshuler/git/cassandra/build/classes/main
>    [javac] Note: Processing compiler hints annotations
>    [javac] warning: Supported source version 'RELEASE_6' from annotation 
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' 

[jira] [Comment Edited] (CASSANDRA-15050) JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821

2019-03-12 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791023#comment-16791023
 ] 

Dinesh Joshi edited comment on CASSANDRA-15050 at 3/12/19 9:18 PM:
---

Can you add the exact steps to reproduce this? {{Consumer}} is available 
starting Java 8 and looks like your issue is in 2.2 backport.


was (Author: djoshi3):
Can you add the exact steps to reproduce this? `Consumer` is available starting 
Java 8 and looks like your issue is in 2.2 backport.

> JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
> -
>
> Key: CASSANDRA-15050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15050
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Michael Shuler
>Priority: Normal
> Fix For: 2.2.x
>
>
> CASSANDRA-14821 introduced some errors on JDK7. The build fails as follows:
> {noformat}
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
> java version "1.7.0_80"
> Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ ant jar
> Buildfile: /home/mshuler/git/cassandra/build.xml
> init:
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
>    [mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
>    [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
> maven-ant-tasks-localrepo:
> [copy] Copying 1 file to /home/mshuler/git/cassandra/build
> maven-ant-tasks-download:
> maven-ant-tasks-init:
> maven-declare-dependencies:
> maven-ant-tasks-retrieve-build:
> [artifact:dependencies] Building ant file: 
> /home/mshuler/git/cassandra/build/build-dependencies.xml
> [artifact:dependencies] Building ant file: 
> /home/mshuler/git/cassandra/build/build-dependencies-sources.xml
> [copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
> [copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
> [copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
>    [unzip] Expanding: 
> /home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar
>  into /home/mshu
> ler/git/cassandra/build/lib/jars
> check-gen-cql3-grammar:
> gen-cql3-grammar:
> [echo] Building Grammar 
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g  ...
> generate-cql-html:
> build-project:
> [echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
>    [javac] Compiling 45 source files to 
> /home/mshuler/git/cassandra/build/classes/thrift
>    [javac] warning: Supported source version 'RELEASE_6' from annotation 
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
>    [javac] Note: 
> /home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
>  uses o
> r overrides a deprecated API.
>    [javac] Note: Recompile with -Xlint:deprecation for details.
>    [javac] Note: Some input files use unchecked or unsafe operations.
>    [javac] Note: Recompile with -Xlint:unchecked for details.
>    [javac] 1 warning
>    [javac] Compiling 1171 source files to 
> /home/mshuler/git/cassandra/build/classes/main
>    [javac] Note: Processing compiler hints annotations
>    [javac] warning: Supported source version 'RELEASE_6' from annotation 
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
>    [javac] 
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:22:
>  error: package java.uti
> l.function does not exist
>    [javac] import java.util.function.Consumer;
>    [javac]  ^
>    [javac] 
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:203:
>  error: cannot find sym
> bol
>    [javac] private Consumer handler;
>    [javac] ^
>    [javac]   symbol:   class Consumer
>    [javac]   location: class OnException
>    [javac] 
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:204:
>  error: cannot find sym
> bol
>    [javac] OnException(Consumer handler)
>    [javac] ^
>    [javac]   symbol:   class Consumer
>    [javac]   location: class OnException
>    [javac] Note: Processing compiler hints annotations
>    [javac] Note: Writing compiler command file at