[jira] [Comment Edited] (CASSANDRA-15256) Clean up redundant nodetool commands added in 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102121#comment-17102121 ] Jordan West edited comment on CASSANDRA-15256 at 5/8/20, 12:16 AM: --- -Getting ready to commit this. Kicked off a build: https://app.circleci.com/pipelines/github/jrwest/cassandra/10/workflows/3fdc3194-bfea-4fa9-adbe-8ab5843add09- That branch was very out of date. Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 was (Author: jrwest): Getting ready to commit this. Kicked off a build: https://app.circleci.com/pipelines/github/jrwest/cassandra/10/workflows/3fdc3194-bfea-4fa9-adbe-8ab5843add09 > Clean up redundant nodetool commands added in 4.0 > - > > Key: CASSANDRA-15256 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15256 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Fix For: 4.0 > > > Both hintedhandoff and getendpoints had a 2nd command added that does the > exact thing but rewritten (and in getReplicas not as well) not just aliased > (like cf->tablestats). Also a minor cleanup is same command added multiple > times to nodetool command list. We should clean this up before 4.0 release > before people become reliant on the newly introduced command name. If we want > them renamed as that we should rename and link with alias like we do with > cf->table others. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15256) Clean up redundant nodetool commands added in 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102121#comment-17102121 ] Jordan West edited comment on CASSANDRA-15256 at 5/8/20, 12:17 AM: --- Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 was (Author: jrwest): -Getting ready to commit this. Kicked off a build: https://app.circleci.com/pipelines/github/jrwest/cassandra/10/workflows/3fdc3194-bfea-4fa9-adbe-8ab5843add09- That branch was very out of date. Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 > Clean up redundant nodetool commands added in 4.0 > - > > Key: CASSANDRA-15256 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15256 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Fix For: 4.0 > > > Both hintedhandoff and getendpoints had a 2nd command added that does the > exact thing but rewritten (and in getReplicas not as well) not just aliased > (like cf->tablestats). Also a minor cleanup is same command added multiple > times to nodetool command list. We should clean this up before 4.0 release > before people become reliant on the newly introduced command name. If we want > them renamed as that we should rename and link with alias like we do with > cf->table others. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15256) Clean up redundant nodetool commands added in 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102121#comment-17102121 ] Jordan West edited comment on CASSANDRA-15256 at 5/8/20, 12:45 AM: --- Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 Test failure notes: - the only java8 unit test failure is unrelated / flaky (no use of Nodetool in the test) was (Author: jrwest): Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 > Clean up redundant nodetool commands added in 4.0 > - > > Key: CASSANDRA-15256 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15256 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Fix For: 4.0 > > > Both hintedhandoff and getendpoints had a 2nd command added that does the > exact thing but rewritten (and in getReplicas not as well) not just aliased > (like cf->tablestats). Also a minor cleanup is same command added multiple > times to nodetool command list. We should clean this up before 4.0 release > before people become reliant on the newly introduced command name. If we want > them renamed as that we should rename and link with alias like we do with > cf->table others. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15256) Clean up redundant nodetool commands added in 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102121#comment-17102121 ] Jordan West edited comment on CASSANDRA-15256 at 5/8/20, 1:27 AM: -- Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 Test failure notes: - the only java8 unit test failure is unrelated / flaky (no use of Nodetool in the test) - dtest failure test_refresh_size_estimates_clears_invalid_entries is known was (Author: jrwest): Rebased on a recent trunk here: https://github.com/jrwest/cassandra/commits/nodetool_cleanup New build started here: https://app.circleci.com/pipelines/github/jrwest/cassandra/11/workflows/705761a6-389b-4c4e-a755-3ee1aecc4bf2 Test failure notes: - the only java8 unit test failure is unrelated / flaky (no use of Nodetool in the test) > Clean up redundant nodetool commands added in 4.0 > - > > Key: CASSANDRA-15256 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15256 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Fix For: 4.0 > > > Both hintedhandoff and getendpoints had a 2nd command added that does the > exact thing but rewritten (and in getReplicas not as well) not just aliased > (like cf->tablestats). Also a minor cleanup is same command added multiple > times to nodetool command list. We should clean this up before 4.0 release > before people become reliant on the newly introduced command name. If we want > them renamed as that we should rename and link with alias like we do with > cf->table others. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org