[jira] [Comment Edited] (CASSANDRA-15406) Add command to show the progress of data streaming and index build
[ https://issues.apache.org/jira/browse/CASSANDRA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152024#comment-17152024 ] Berenguer Blasi edited comment on CASSANDRA-15406 at 7/6/20, 1:48 PM: -- Ok so here's an opportunity for CASSANDRA-15502 or even as the quality 4.0 effort. Some scaffolding for cmd line tooling testing. Thx otherwise, pending CI lgtm. was (Author: bereng): Ok so here's an opportunity for CASSANDRA-15502 or even as they quality 4.0 effort. Some scaffolding for cmd line tooling testing. Thx otherwise, pending CI lgtm. > Add command to show the progress of data streaming and index build > --- > > Key: CASSANDRA-15406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15406 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming, Legacy/Streaming and Messaging, > Tool/nodetool >Reporter: maxwellguo >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.0, 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > I found that we should supply a command to show the progress of streaming > when we do the operation of bootstrap/move/decommission/removenode. For when > do data streaming , noboday knows which steps there program are in , so I > think a command to show the joing/leaving node's is needed . > > PR [https://github.com/apache/cassandra/pull/558] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15406) Add command to show the progress of data streaming and index build
[
https://issues.apache.org/jira/browse/CASSANDRA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152011#comment-17152011
]
Berenguer Blasi edited comment on CASSANDRA-15406 at 7/6/20, 1:42 PM:
--
Would it make sense to add some testing either in a junit hijacking
{{System.out}} and mocking things around in {{NodeToolTest.java}} i.e. Or even
in {{nodetool_test.py}} dtest? I am aware the nodetool tool doesn't have this
sort of testing atm (only some dtests) so we can use this as an opportunity to
kickstart now. You can also tell me you'd rather do this in another ticket as
it's not a quick fix :-) depending on how OCD on testing you feel on this one.
was (Author: bereng):
Would it make sense to add some testing either in a junit hijacking
{{System.out}} and mocking things around in {{NodeToolTest.java}} i.e. Or even
in {{nodetool_test.py}} dtest. I am aware the nodetool tool doesn't have this
sort of testing atm (only some dtests) so we can use this as an opportunity to
kickstart now. You can also tell me you'd rather do this in another ticket as
it's not a quick fix :-) depending on how OCD on testing you feel on this one.
> Add command to show the progress of data streaming and index build
> ---
>
> Key: CASSANDRA-15406
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15406
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Streaming, Legacy/Streaming and Messaging,
> Tool/nodetool
>Reporter: maxwellguo
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0, 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I found that we should supply a command to show the progress of streaming
> when we do the operation of bootstrap/move/decommission/removenode. For when
> do data streaming , noboday knows which steps there program are in , so I
> think a command to show the joing/leaving node's is needed .
>
> PR [https://github.com/apache/cassandra/pull/558]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15406) Add command to show the progress of data streaming and index build
[ https://issues.apache.org/jira/browse/CASSANDRA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144825#comment-17144825 ] Berenguer Blasi edited comment on CASSANDRA-15406 at 6/25/20, 10:53 AM: [~stefan.miklosovic] I was looking at this and wondering the same you did, why not backport it? Also for the 4.0 review it would be good to have CI ran. Wdyt? Edit: I just learned we don't do improvements on older branches. Apologies for the noise. 4.0 only it is :-) was (Author: bereng): [~stefan.miklosovic] I was looking at this and wondering the same you did, why not backport it? Also for the 4.0 review it would be good to have CI ran. Wdyt? > Add command to show the progress of data streaming and index build > --- > > Key: CASSANDRA-15406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15406 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming, Legacy/Streaming and Messaging, > Tool/nodetool >Reporter: maxwellguo >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.0, 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > I found that we should supply a command to show the progress of streaming > when we do the operation of bootstrap/move/decommission/removenode. For when > do data streaming , noboday knows which steps there program are in , so I > think a command to show the joing/leaving node's is needed . > > PR [https://github.com/apache/cassandra/pull/558] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15406) Add command to show the progress of data streaming and index build
[ https://issues.apache.org/jira/browse/CASSANDRA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072227#comment-17072227 ] Stefan Miklosovic edited comment on CASSANDRA-15406 at 4/1/20, 9:07 AM: Hi [~dcapwell], I think that this ticket will be more or less transformed just into a bug fix. I do not think that there is a need for a "command" for nodetool and having a lot of work before release anyway, it is not a good idea to introduce something completely new. As I see it, this ticket will be just about the introduction of global percentage into netstats output + I think I hit a bug when we stream entire SSTables and netstats is displaying it weirdly so that should be fixed too. was (Author: stefan.miklosovic): Hi [~dcapwell], I think that this ticket will be more or less transformed just into a bug fix. I do not thing that there is a need for a "command" for nodetool and having a lot of work before release anyway, it is not a good idea to introduce something completely new. As I see it, this ticket will be just about the introduction of global percentage into netstats output + I think I hit a bug when we stream entire SSTables and netstats is displaying it weirdly so that should be fixed too. > Add command to show the progress of data streaming and index build > --- > > Key: CASSANDRA-15406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15406 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming, Legacy/Streaming and Messaging, > Tool/nodetool >Reporter: maxwellguo >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.0, 4.x > > > I found that we should supply a command to show the progress of streaming > when we do the operation of bootstrap/move/decommission/removenode. For when > do data streaming , noboday knows which steps there program are in , so I > think a command to show the joing/leaving node's is needed . -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15406) Add command to show the progress of data streaming and index build
[ https://issues.apache.org/jira/browse/CASSANDRA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070979#comment-17070979 ] Stefan Miklosovic edited comment on CASSANDRA-15406 at 3/30/20, 1:50 PM: - I will assign this to myself temporarily (as it was unassigned), is somebody objects please feel free to raise your opinion here. Thank you. was (Author: stefan.miklosovic): I will assign this to myself temporarily, is somebody objects please feel free to raise your opinion here. Thank you. > Add command to show the progress of data streaming and index build > --- > > Key: CASSANDRA-15406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15406 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming, Legacy/Streaming and Messaging, > Tool/nodetool >Reporter: maxwellguo >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.0, 4.x > > > I found that we should supply a command to show the progress of streaming > when we do the operation of bootstrap/move/decommission/removenode. For when > do data streaming , noboday knows which steps there program are in , so I > think a command to show the joing/leaving node's is needed . -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
