[jira] [Comment Edited] (CASSANDRA-15624) Avoid lazy initializing shut down instances when trying to send them messages
[
https://issues.apache.org/jira/browse/CASSANDRA-15624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089774#comment-17089774
]
Gianluca Righetto edited comment on CASSANDRA-15624 at 4/22/20, 3:21 PM:
-
In talking with [~marcuse], he told me this is actually an improvement around
the in-jvm tests and it's not currently breaking any tests or making them
flakey.
I did some investigation and it seems that with the recent changes in
CASSANDRA-15501
([https://github.com/apache/cassandra/commit/16f639af94f56cdc7145299730278e27a9113e2e]),
the in-jvm Wrapper instance will now check if the delegate is null and prevent
any operations on a shutdown node. Instead of failing silently or throw an NPE,
it will now throw an IllegalStateException telling that "Can't use shut down
instances, delegate is null".
[~marcuse] Do you think there's anything else we need to tackle in this ticket?
/cc [~ifesdjeen]
Either way, being an improvement ticket, I don't think this is a blocker for
4.0 at this point and we can probably move it out. Any objections?
was (Author: gianluca):
In talking with [~marcuse], he told me this is actually an improvement around
the in-jvm tests and it's not currently breaking any tests or making them
flakey.
I did some investigation and it seems that with the recent changes in
CASSANDRA-15501
([https://github.com/apache/cassandra/commit/16f639af94f56cdc7145299730278e27a9113e2e]),
the in-jvm Wrapper instance will now check if the delegate is null and prevent
any operations on a shutdown node. Instead of failing silently or throw an NPE,
it will now throw an IllegalStateException telling that ""Can't use shut down
instances, delegate is null".
[~marcuse] Do you think there's anything else we need to tackle in this ticket?
/cc [~ifesdjeen]
Either way, being an improvement ticket, I don't think this is a blocker for
4.0 at this point and we can probably move it out. Any objections?
> Avoid lazy initializing shut down instances when trying to send them messages
> -
>
> Key: CASSANDRA-15624
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15624
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Marcus Eriksson
>Assignee: Gianluca Righetto
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> We currently use {{to.broadcastAddressAndPort()}} when figuring out if we
> should send a message to an instance, if that instance has been shut down it
> will get re-initialized but not startup:ed which makes the tests fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15624) Avoid lazy initializing shut down instances when trying to send them messages
[
https://issues.apache.org/jira/browse/CASSANDRA-15624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058532#comment-17058532
]
Ryan Svihla edited comment on CASSANDRA-15624 at 3/13/20, 9:13 AM:
---
[~ifesdjeen] yes I was looking into it and using it as an opportunity to learn
how the JVM dtests work. If you'd rather have someone more experienced with
that part of the code base involved though I'm happy to look for simpler issues
first.
EDIT handed it back, I can still review the codebase and if I come up with a
fix before someone else takes it..I'll submit a PR then, but that way I'm not
blocking someone else.
was (Author: rssvihla):
[~ifesdjeen] yes I was looking into it and using it as an opportunity to learn
how the JVM dtests work. If you'd rather have someone more experienced with
that part of the code base involved though I'm happy to look for simpler issues
first.
> Avoid lazy initializing shut down instances when trying to send them messages
> -
>
> Key: CASSANDRA-15624
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15624
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> We currently use {{to.broadcastAddressAndPort()}} when figuring out if we
> should send a message to an instance, if that instance has been shut down it
> will get re-initialized but not startup:ed which makes the tests fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15624) Avoid lazy initializing shut down instances when trying to send them messages
[
https://issues.apache.org/jira/browse/CASSANDRA-15624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058532#comment-17058532
]
Ryan Svihla edited comment on CASSANDRA-15624 at 3/13/20, 9:04 AM:
---
[~ifesdjeen] yes I was looking into it and using it as an opportunity to learn
how the JVM dtests work. If you'd rather have someone more experienced with
that part of the code base involved though I'm happy to look for simpler issues
first.
was (Author: rssvihla):
[~ifesdjeen] yes I was looking into it and using it as an opportunity to learn
how the JVM tests work. If you'd rather have someone more experienced with that
part of the code base involved though I'm happy to look for simpler issues
first.
> Avoid lazy initializing shut down instances when trying to send them messages
> -
>
> Key: CASSANDRA-15624
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15624
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Marcus Eriksson
>Assignee: Ryan Svihla
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> We currently use {{to.broadcastAddressAndPort()}} when figuring out if we
> should send a message to an instance, if that instance has been shut down it
> will get re-initialized but not startup:ed which makes the tests fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
