[jira] [Comment Edited] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833
[
https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214074#comment-17214074
]
David Capwell edited comment on CASSANDRA-16148 at 10/14/20, 5:17 PM:
--
I feel that
https://app.circleci.com/pipelines/github/jrwest/cassandra/71/workflows/a6356d72-d33c-449d-8561-332ec190910c/jobs/885
is because you didn't rebase... I added a lot line to all branches to detect
when we complete startup, and looks like it times out after 10m since it never
sees that log.
Confirmed, https://github.com/jrwest/cassandra/commits/jwest/16148 doesn't have
the commit which checks for the log.
was (Author: dcapwell):
I feel that
https://app.circleci.com/pipelines/github/jrwest/cassandra/71/workflows/a6356d72-d33c-449d-8561-332ec190910c/jobs/885
is because you didn't rebase... I added a lot line to all branches to detect
when we complete startup, and looks like it times out after 10m since it never
sees that log.
> Test failures caused by merging CASSANDRA-15833
> ---
>
> Key: CASSANDRA-16148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16148
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
>
> Three issues were caused by merging CASSANDRA-15833:
> 1. `GossiperTest#testHaveAnyVersion3Nodes` was failing on trunk:
> https://app.circleci.com/pipelines/github/jrwest/cassandra/53/workflows/95f9f401-1ef8-4b8d-9c64-3703d9669d95/jobs/771
> 2. python dtest ReadRepairTest#test_atomic_writes[blocking] was failing
> 3. In-jvm dtests being worked on as part of CASSANDRA-15977 uncovered an
> issue with how CASSANDRA-15833 changes interacted with in-jvm dtests running
> without {{Feature.GOSSIP}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833
[
https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205708#comment-17205708
]
Caleb Rackliffe edited comment on CASSANDRA-16148 at 10/1/20, 5:45 PM:
---
bq. This logic isn't correct as you need the release version of the node you
are adding, this method takes the release version of the current node (example:
node1 is 3.0, node2 is 4.0. node2 would update gossip to say node1 is 4.0).
Would the idea be to add something similar to {{getMessagingVersion()}} to the
{{IInstance}} API?
Otherwise, just minor notes in addition to what's already been discussed above:
* I'd move {{SimpleReadWriteTest#test15833()}} to {{ReadRepairTest}}, get rid
of the commented out cluster init, and throw a TODO onto it that indicates the
method should be removed when CASSANDRA-15977 merges. (CC [~adelapena])
* nit: If I'm interpreting all this correctly, {{haveMajorVersion3Nodes()}} is
really more like {{mightHaveMajorVersion3Nodes()}} ;)
* If we end up not needing Guava, can we switch to
{{java.util.function.Supplier}}?
* {{import com.google.common.base.Suppliers}} is unused.
was (Author: maedhroz):
bq. This logic isn't correct as you need the release version of the node you
are adding, this method takes the release version of the current node (example:
node1 is 3.0, node2 is 4.0. node2 would update gossip to say node1 is 4.0).
Would the idea be to add something similar to {{getMessagingVersion()}} to the
{{IInstance}} API?
Otherwise, just minor notes in addition to what's already been discussed above:
* I'd move {{SimpleReadWriteTest#test15833()}} to {{ReadRepairTest}}, get rid
of the commented out cluster init, and throw a TODO onto it that indicates the
method should be removed when CASSANDRA-15977 merges. (CC [~adelapena])
* nit: If I'm interpreting all this correctly, {{haveMajorVersion3Nodes()}} is
really more like {{mightHaveMajorVersion3Nodes()}} ;)
* If we end up not needing Guava, can we switch to
{{java.util.function.Supplier}}?
> Test failures caused by merging CASSANDRA-15833
> ---
>
> Key: CASSANDRA-16148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16148
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
>
> Three issues were caused by merging CASSANDRA-15833:
> 1. `GossiperTest#testHaveAnyVersion3Nodes` was failing on trunk:
> https://app.circleci.com/pipelines/github/jrwest/cassandra/53/workflows/95f9f401-1ef8-4b8d-9c64-3703d9669d95/jobs/771
> 2. python dtest ReadRepairTest#test_atomic_writes[blocking] was failing
> 3. In-jvm dtests being worked on as part of CASSANDRA-15977 uncovered an
> issue with how CASSANDRA-15833 changes interacted with in-jvm dtests running
> without {{Feature.GOSSIP}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833
[
https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204356#comment-17204356
]
Jordan West edited comment on CASSANDRA-16148 at 9/30/20, 10:10 PM:
Branch updated to address all 3 issues:
[branch | https://github.com/jrwest/cassandra/tree/jwest/16148] [tests |
https://app.circleci.com/pipelines/github/jrwest/cassandra?branch=jwest%2F16148]
was (Author: jrwest):
[branch | https://github.com/jrwest/cassandra/tree/jwest/16148] [tests |
https://app.circleci.com/pipelines/github/jrwest/cassandra?branch=jwest%2F16148]
> Test failures caused by merging CASSANDRA-15833
> ---
>
> Key: CASSANDRA-16148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16148
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
>
> Three issues were caused by merging CASSANDRA-15833:
> 1. `GossiperTest#testHaveAnyVersion3Nodes` was failing on trunk:
> https://app.circleci.com/pipelines/github/jrwest/cassandra/53/workflows/95f9f401-1ef8-4b8d-9c64-3703d9669d95/jobs/771
> 2. python dtest ReadRepairTest#test_atomic_writes[blocking] was failing
> 3. In-jvm dtests being worked on as part of CASSANDRA-15977 uncovered an
> issue with how CASSANDRA-15833 changes interacted with in-jvm dtests running
> without {{Feature.GOSSIP}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
