[jira] [Comment Edited] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376698#comment-17376698 ] Michael Semb Wever edited comment on CASSANDRA-16649 at 7/7/21, 6:56 PM: - CI full pipelines: - 3.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/894/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/894/] - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/895/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/895/] - 4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/898/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/898/] - trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/899/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/899/] Results are looking good. was (Author: michaelsembwever): CI full pipelines: - 3.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/894/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/894/] - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/895/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/895/] - 4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/898/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/898/] - trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/899/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/899/] > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374327#comment-17374327
]
Michael Semb Wever edited comment on CASSANDRA-16649 at 7/4/21, 4:51 PM:
-
CI jvm-dtest-upgrade
- trunk
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/605/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/605/]
(it ran 35 tests versus 46 tests on trunk, zero of which before were upgrades
to 4.1)
- 4.0
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/602/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/602/]
(it ran 35 tests versus 40 tests on cassandra-4.0)
- 3.11
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/601/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/601/]
(it ran 16 tests, same as cassandra-3.11)
- 3.0
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/604/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/604/]
(it ran 16 tests versus 18 tests on cassandra-3.0)
- 2.2
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/600/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/600/]
(it ran 10 tests, while ci-cassandra.a.o doesn't run this post-commit 🤷🏻‍♀️ )
Fixes required (patches above updated accordingly)
- fix to include dtest jar files that didn't include a patch version number in
their name,
- the supported upgrade paths updated for each path, tests that don't apply to
older (or newer) branches are removed
- better info logging in UpgradeBaseTest
All builds, including the "aborted" builds, look ok.
In the output of some of the failed tests above there is
{{"NoClassDefFoundError: com/vdurmont/semver4j/Semver"}} , but this happens
only on failures and against exceptions already found in the branches.
I also suspect there's a thorough review required of all the upgrade tests,
involving
- what upgrade paths (now and into the future) they are applicable to, and
- fixing asserts to be forward compatible with new upgrade paths.
was (Author: michaelsembwever):
CI jvm-dtest-upgrade
- trunk
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/605/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/605/]
(it ran 35 tests versus 46 tests on trunk, zero of which before were upgrades
to 4.1)
- 4.0
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/602/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/602/]
(it ran 35 tests versus 40 tests on cassandra-4.0)
- 3.11
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/601/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/601/]
(it ran 16 tests, same as cassandra-3.11)
- 3.0
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/604/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/604/]
(it ran 16 tests versus 18 tests on cassandra-3.0)
- 2.2
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/600/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/600/]
(it ran 10 tests, while ci-cassandra.a.o doesn't run this post-commit 🤷🏻‍♀️ )
Fixes required (patches above updated accordingly)
- fix to include dtest jar files that didn't include a patch version number in
their name,
- the supported upgrade paths updated for each path, tests that don't apply to
older (or newer) branches are removed
- better info logging in UpgradeBaseTest
In the output of some of the failed tests above there is
{{"NoClassDefFoundError: com/vdurmont/semver4j/Semver"}} , but this happens
only on failures and against exceptions already found in the branches.
I also suspect there's a thorough review required of all the upgrade tests,
involving
- what upgrade paths (now and into the future) they are applicable to, and
- fixing asserts to be forward compatible with new upgrade paths.
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> --
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> -
> https://github.com/apache/cassandra-in-jvm-dtest-api/compare
[jira] [Comment Edited] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373508#comment-17373508 ] Michael Semb Wever edited comment on CASSANDRA-16649 at 7/2/21, 8:30 PM: - Final patches - cassandra-in-jvm-dtest-api :: https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649_all - trunk :: https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649_all/trunk - cassandra-4.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649_all/4.0 - cassandra-4.0.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0.0...thelastpickle:mck/16649_all/4.0.0 - cassandra-3.11 :: https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/16649_all/3.11 - cassandra-3.0 :: https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/16649_all/3.0 - cassandra-2.2 :: https://github.com/apache/cassandra/compare/cassandra-2.2...thelastpickle:mck/16649_all/2.2 (I'm thinking we skip 4.0.0 as it's working fine and won't be around for much longer…) was (Author: michaelsembwever): Final patches - cassandra-in-jvm-dtest-api :: https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649_all - trunk :: https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649_all/trunk - cassandra-4.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649_all/4.0 - cassandra-4.0.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0.0...thelastpickle:mck/16649_all/4.0.0 - cassandra-3.11 :: https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/16649_all/3.11 - cassandra-3.0 :: https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/16649_all/3.0 - cassandra-2.2 :: wip (I'm thinking we skip 4.0.0 as it's working fine and won't be around for much longer…) > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373508#comment-17373508 ] Michael Semb Wever edited comment on CASSANDRA-16649 at 7/2/21, 7:50 PM: - Final patches - cassandra-in-jvm-dtest-api :: https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649_all - trunk :: https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649_all/trunk - cassandra-4.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649_all/4.0 - cassandra-4.0.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0.0...thelastpickle:mck/16649_all/4.0.0 - cassandra-3.11 :: https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/16649_all/3.11 - cassandra-3.0 :: https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/16649_all/3.0 - cassandra-2.2 :: wip (I'm thinking we skip 4.0.0 as it's working fine and won't be around for much longer…) was (Author: michaelsembwever): Final patches - cassandra-in-jvm-dtest-api :: https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649_all - trunk :: https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649_all/trunk - cassandra-4.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649_all/4.0 - cassandra-4.0.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0.0...thelastpickle:mck/16649_all/4.0.0 - cassandra-3.11 :: https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/16649_all/3.11 - cassandra-3.0 :: wip - cassandra-2.2 :: wip > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364119#comment-17364119 ] Alex Petrov edited comment on CASSANDRA-16649 at 6/16/21, 7:44 AM: --- Thank you for the patch and sorry for such a long delay with a review! +1 on both dtest and Cassandra changes, assuming the patch with semVer is coming up, and that commit with SNAPSHOT will get squashed away. Maybe we could replace it with a script that appends snapshot repositories for development purposes. was (Author: ifesdjeen): +1 on both dtest and Cassandra changes, thank you for the patch and sorry for such a long delay with a review. > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345079#comment-17345079 ] Michael Semb Wever edited comment on CASSANDRA-16649 at 5/18/21, 11:30 AM: --- Patches: - https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 - https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/489/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/489/] - https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649/4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/488/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/488/] was (Author: michaelsembwever): Patches: - https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 - https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/487/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/487/] - https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649/4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/488/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/488/] > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-rc, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
