[jira] [Comment Edited] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup

2021-07-07 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376677#comment-17376677
 ] 

Caleb Rackliffe edited comment on CASSANDRA-16774 at 7/7/21, 4:21 PM:
--

4.0.0 back-port committed as 
https://github.com/apache/cassandra/commit/68bf950f72d20be9f31fd3f91669be7e28c050e4

(Also changed release to 4.0-rc3.)

Thanks everyone!


was (Author: maedhroz):
4.0.0 back-port committed as 
https://github.com/apache/cassandra/commit/68bf950f72d20be9f31fd3f91669be7e28c050e4

> BinLog does not close chronicle queue leaving this to GC to cleanup
> ---
>
> Key: CASSANDRA-16774
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16774
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/dtest/python, Tool/fql
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-rc3, 4.1
>
>
> auditlog_test.py::TestAuditlog::test_archiving_fql  and 
> test_fql_nodetool_options fail from time to time due to the test relying on a 
> race condition; we do not close chronicle queue so rotation may not happen 
> before stopping archiver, the tests fail if rotation happens before stopping 
> archiver (which is done based off GC).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup

2021-07-06 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376136#comment-17376136
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-16774 at 7/7/21, 1:12 AM:
--

I haven't seen it before. It doesn't fail for me locally in 4.0.0. Considering 
that the failing assert is based on a grep in the logs, I would say probably 
there is some test flakiness somewhere and we should improve the test... I can 
take a look these days. This failing test doesn't exercise the code you changed


was (Author: e.dimitrova):
I haven't seen it before. It doesn't fail for me locally in 4.0.0. Considering 
that the assert is based on a grep in the logs, I would say probably there is 
some test flakiness somewhere and we should improve the test... I can take a 
look these days. This failing test doesn't exercise the code you changed

> BinLog does not close chronicle queue leaving this to GC to cleanup
> ---
>
> Key: CASSANDRA-16774
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16774
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/dtest/python, Tool/fql
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0.1, 4.1
>
>
> auditlog_test.py::TestAuditlog::test_archiving_fql  and 
> test_fql_nodetool_options fail from time to time due to the test relying on a 
> race condition; we do not close chronicle queue so rotation may not happen 
> before stopping archiver, the tests fail if rotation happens before stopping 
> archiver (which is done based off GC).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org