[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478874#comment-17478874
]
Francisco Guerrero edited comment on CASSANDRA-17133 at 1/19/22, 6:54 PM:
--
[~bereng], [~subkanthi] I have a patch on my local with two commits, one
reverts 17029, and the other one modifies the tests to verify the behavior with
int and long inputs (basically preserving the tests with long values introduced
in 17029).
Let me know if you'd like me to contribute that patch.
was (Author: frankgh):
[~bereng], [~subkanthi] I have a patch on my local with two commits, one
reverts 17029, and the other one modifies the tests to verify the behavior with
int and long inputs (basically preserving the tests with long values introduced
in 17029).
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478874#comment-17478874
]
Francisco Guerrero edited comment on CASSANDRA-17133 at 1/19/22, 6:53 PM:
--
[~bereng], [~subkanthi] I have a patch on my local with two commits, one
reverts 17029, and the other one modifies the tests to verify the behavior with
int and long inputs (basically preserving the tests with long values introduced
in 17029).
was (Author: frankgh):
[~bereng][~subkanthi] I have a patch on my local with two commits, one reverts
17029, and the other one modifies the tests to verify the behavior with int and
long inputs (basically preserving the tests with long values introduced in
17029).
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457138#comment-17457138
]
Benjamin Lerer edited comment on CASSANDRA-17133 at 12/10/21, 1:08 PM:
---
I had a look at the code and it seems that the mistake is mine. We did not need
to add those new functions in CASSANDRA-17029 as the functionality was already
there.
We had the following functions:
* toDate(timestamp)
* toTimestamp(date)
* mintimeuuid(timestamp)
* maxtimeuuid(timestamp)
Those functions were not overloaded so they will be the ones being picked up
but the code allow deserialization from integer to the timestampt type or the
date type.
by consequence adding new function was not needed and in fact lead to a
slightly different behavior. What I would suggest it to remove the methods
added by CASSANDRA-17029 and modify the tests to verify the behavior with int
an long inputs.
Sorry for not realizing that sooner. :-(
was (Author: blerer):
I had a look at the code and it seems that the mistake is mine. We did not need
to add those new functions in CASSANDRA-17029 as the functionality was already
there.
We had the following functions:
* toDate(timestamp)
* toTimestamp(date)
* mintimeuuid(timestamp)
* maxtimeuuid(timestamp)
Those functions were not overloaded so they will be the ones being picked up
but the code allow deserialization from integer to the timestampt type or the
date type.
by consequence adding new function was not needed and in fact lead to a
slightly different behavior. What I would suggest it to remove the methods
added by CASSANDRA-17029 and modify the tests to verify the behavior with int
an long inputs.
Sorry for not realizing that sooner. :-(
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:33 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed its fine because
the other functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
It obviously works when the number is bigint.
{code:java}
select maxTimeuuid(1564830182000) from emp; system.maxtimeuuid(1564830182000)
--
42d31e0f-b5de-11e9-7f7f-7f7f7f7f7f7f
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
The tounixtimestamp function which wasnt changed as part of this PR also has
the same problem.
{code:java}
// code placeholder
select toUnixTimestamp(123) from emp;
InvalidRequest: Error from server: code=2200 [Invalid query] message="Ambiguous
call to function tounixtimestamp (can be matched by following signatures:
system.tounixtimestamp : (timestamp) -> bigint, system.tounixtimestamp : (date)
-> bigint): use type casts to disambiguate"
{code}
It will definitely be great if we can check for int and cast to bigint, but not
sure where it can be done because the testAssignment function is first called.
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed its fine because
the other functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
The tounixtimestamp function which wasnt changed as part of this PR also has
the same problem.
{code:java}
// code placeholder
select toUnixTimestamp(123) from emp;
InvalidRequest: Error from server: code=2200 [Invalid query] message="Ambiguous
call to function tounixtimestamp (can be matched by following signatures:
system.tounixtimestamp : (timestamp) -> bigint, system.tounixtimestamp : (date)
-> bigint): use type casts to disambiguate"
{code}
It will definitely be great if we can check for int and cast to bigint, but not
sure where it can be done because the testAssignment function is first called.
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from ser
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:32 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed its fine because
the other functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
The tounixtimestamp function which wasnt changed as part of this PR also has
the same problem.
{code:java}
// code placeholder
select toUnixTimestamp(123) from emp;
InvalidRequest: Error from server: code=2200 [Invalid query] message="Ambiguous
call to function tounixtimestamp (can be matched by following signatures:
system.tounixtimestamp : (timestamp) -> bigint, system.tounixtimestamp : (date)
-> bigint): use type casts to disambiguate"
{code}
It will definitely be great if we can check for int and cast to bigint, but not
sure where it can be done because the testAssignment function is first called.
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
The tounixtimestamp function which wasnt changed as part of this PR also has
the same problem.
{code:java}
// code placeholder
select toUnixTimestamp(123) from emp;
InvalidRequest: Error from server: code=2200 [Invalid query] message="Ambiguous
call to function tounixtimestamp (can be matched by following signatures:
system.tounixtimestamp : (timestamp) -> bigint, system.tounixtimestamp : (date)
-> bigint): use type casts to disambiguate"
{code}
It will definitely be great if we can check for int and cast to bigint, but not
sure where it can be done because the testAssignment function is first called.
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:28 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
The tounixtimestamp function which wasnt changed as part of this PR also has
the same problem.
{code:java}
// code placeholder
select toUnixTimestamp(123) from emp;
InvalidRequest: Error from server: code=2200 [Invalid query] message="Ambiguous
call to function tounixtimestamp (can be matched by following signatures:
system.tounixtimestamp : (timestamp) -> bigint, system.tounixtimestamp : (date)
-> bigint): use type casts to disambiguate"
{code}
It will definitely be great if we can check for int and cast to bigint, but not
sure where it can be done because the testAssignment function is first called.
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:24 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
case INTEGER:
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:19 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:17 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
The reason is this logic here,
Because bigint and timestamp gets the WEAKLY_ASSIGNABLE when the parameter is
integer.
https://issues.apache.org/jira/browse/CASSANDRA-17029
{code:java}
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
{code}
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way, I will dig for the code that selects the function
based on the data type.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:16 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way, I will dig for the code that selects the function
based on the data type.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
// code placeholdercase INTEGER:
switch (nt)
{
case BIGINT:
case COUNTER:
case DATE:
case DECIMAL:
case DOUBLE:
case DURATION:
case FLOAT:
case INT:
case SMALLINT:
case TIME:
case TIMESTAMP:
case TINYINT:
case VARINT:
return AssignmentTestable.TestResult.WEAKLY_ASSIGNABLE;
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way, I will dig for the code that selects the function
based on the data type.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17133) Broken test_timeuuid - upgrade_tests.cql_tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456834#comment-17456834
]
Kanthi Subramanian edited comment on CASSANDRA-17133 at 12/10/21, 1:14 AM:
---
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
Its quite possible the user will encounter this, but I assumed that the other
functions work the same way, I will dig for the code that selects the function
based on the data type.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
was (Author: subkanthi):
[~brandon.williams] , I made the same change in the unit tests too, please see
here, because support for bigint was added to maxTimeuuid, the logic of picking
the right function throws the ambiguous error.
[https://github.com/apache/cassandra/pull/1275/files]
{code:java}
-- assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1234567) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
++ assertEmpty(execute("SELECT t FROM %s WHERE k = 0 AND t >
maxTimeuuid(1564830182000) AND t < minTimeuuid('2012-11-07 18:18:22-0800')"));
{code}
> Broken test_timeuuid - upgrade_tests.cql_tests
> --
>
> Key: CASSANDRA-17133
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17133
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Yifan Cai
>Assignee: Kanthi Subramanian
>Priority: Normal
> Fix For: 4.x
>
>
> Both CircleCI and Jenkins build failed at test_timeuuid with the following
> error.
> {quote}cassandra.InvalidRequest: Error from server: code=2200 [Invalid query]
> message="Ambiguous call to function maxtimeuuid (can be matched by following
> signatures: system.maxtimeuuid : (bigint) -> timeuuid, system.maxtimeuuid :
> (timestamp) -> timeuuid): use type casts to disambiguate"{quote}
> https://app.circleci.com/pipelines/github/yifan-c/cassandra/273/workflows/7a855174-823a-4553-ad09-25623747a58e/jobs/1884/tests#failed-test-0
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1272/tests/
> The change was added in CASSANDRA-17029.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
