[ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459880#comment-17459880
 ] 

Benjamin Lerer edited comment on CASSANDRA-17209 at 12/15/21, 1:51 PM:
-----------------------------------------------------------------------

[PR|https://github.com/apache/cassandra/pull/1363] and [CI 
runs|https://app.circleci.com/pipelines/github/blerer/cassandra/251/workflows/383d6001-09a0-4b57-b79b-e4863e6cbdec]


was (Author: blerer):
[PR|https://github.com/apache/cassandra/pull/1363] and CI runs for 
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/250/workflows/3586ea2c-b0f9-4b10-a0ee-f3026252d017]
 and 
[j11|https://app.circleci.com/pipelines/github/blerer/cassandra/250/workflows/c3cccf88-ca85-4a53-b02e-4808aee1bedc]

> Avoid unecessary array allocations and initializations in RequestValidations
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17209
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>            Priority: Normal
>             Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to