[jira] [Comment Edited] (CASSANDRA-17945) Fix StorageService.getNativeaddress handling of IPv6 addresses
[ https://issues.apache.org/jira/browse/CASSANDRA-17945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613722#comment-17613722 ] Ariel Weisberg edited comment on CASSANDRA-17945 at 10/6/22 5:09 PM: - TY [~brandon.williams]! Will find a second reviewer. was (Author: aweisberg): TY Brandon! Will find a second reviewer. > Fix StorageService.getNativeaddress handling of IPv6 addresses > -- > > Key: CASSANDRA-17945 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17945 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Andy Tolbert >Assignee: Andy Tolbert >Priority: Normal > > StorageService.getNativeaddress does not account for IPv6 addresses in the > case NATIVE_ADDRESS_AND_PORT is not present in gossip state for an endpoint > While upgrading a cluster using IPv6 addresses from 3.0 to 4.0 I noticed the > following in logs for upgraded nodes when processing down events for 3.0 > nodes that are going down as part of an upgrade: > > {noformat} > 2022-09-28 20:18:48,244 ERROR [GossipStage:1] > org.apache.cassandra.transport.Server - Problem retrieving RPC address for > /[0:0:0:0:0:0:0:d9]:7000 > java.net.UnknownHostException: 0:0:0:0:0:0:0:d9:9042: invalid IPv6 address > at java.net.InetAddress.getAllByName(InetAddress.java:1355) ~[?:?] > at java.net.InetAddress.getAllByName(InetAddress.java:1306) ~[?:?] > at java.net.InetAddress.getByName(InetAddress.java:1256) ~[?:?] > at > org.apache.cassandra.locator.InetAddressAndPort.getByNameOverrideDefaults(InetAddressAndPort.java:227) > > at > org.apache.cassandra.locator.InetAddressAndPort.getByName(InetAddressAndPort.java:212) > > at > org.apache.cassandra.transport.Server$EventNotifier.getNativeAddress(Server.java:377) > > at > org.apache.cassandra.transport.Server$EventNotifier.onDown(Server.java:438) > at > org.apache.cassandra.service.StorageService.notifyDown(StorageService.java:2651) > > at > org.apache.cassandra.service.StorageService.onDead(StorageService.java:3516) > at org.apache.cassandra.gms.Gossiper.markDead(Gossiper.java:1347) > at org.apache.cassandra.gms.Gossiper.markAsShutdown(Gossiper.java:590) > at > org.apache.cassandra.gms.GossipShutdownVerbHandler.doVerb(GossipShutdownVerbHandler.java:39) > > at org.apache.cassandra.net.InboundSink.lambda$new$0(InboundSink.java:78) > at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:97) > at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:45) > at > org.apache.cassandra.net.InboundMessageHandler$ProcessMessage.run(InboundMessageHandler.java:433) > > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) > [?:?] > at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > [?:?] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > [?:?] > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > [netty-all-4.1.58.Final.jar:4.1.58.Final] > at java.lang.Thread.run(Thread.java:829) [?:?]{noformat} > It appears that StorageService.getNativeaddress does not account for the fact > that an endpoint may be an IPv6 address, which required brackets when > specified with a port: > > [https://github.com/apache/cassandra/blob/cassandra-4.0.6/src/java/org/apache/cassandra/service/StorageService.java#L1978-L1981] > > > {code:java} > /** > * Return the native address associated with an endpoint as a string. > * @param endpoint The endpoint to get rpc address for > * @return the native address > */ > public String getNativeaddress(InetAddressAndPort endpoint, boolean > withPort) > { > if (endpoint.equals(FBUtilities.getBroadcastAddressAndPort())) > return > FBUtilities.getBroadcastNativeAddressAndPort().getHostAddress(withPort); > else if > (Gossiper.instance.getEndpointStateForEndpoint(endpoint).getApplicationState(ApplicationState.NATIVE_ADDRESS_AND_PORT) > != null) > { > try > { > InetAddressAndPort address = > InetAddressAndPort.getByName(Gossiper.instance.getEndpointStateForEndpoint(endpoint).getApplicationState(ApplicationState.NATIVE_ADDRESS_AND_PORT).value); > return address.getHostAddress(withPort); > } > catch (UnknownHostException e) > { > throw new RuntimeException(e); > } > } > else if > (Gossiper.instance.getEndpointStateForEndpoint(endpoint).getApplicationState(ApplicationState.RPC_ADDRESS) > == null) > return endpoint.addr
[jira] [Comment Edited] (CASSANDRA-17945) Fix StorageService.getNativeaddress handling of IPv6 addresses
[ https://issues.apache.org/jira/browse/CASSANDRA-17945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613106#comment-17613106 ] Ariel Weisberg edited comment on CASSANDRA-17945 at 10/5/22 6:57 PM: - +1 Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |cassandra-4.0|[branch|https://github.com/aweisberg/cassandra/tree/commit_remote_branch/CASSANDRA-17945-cassandra-4.0-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://app.circleci.com/pipelines/github/aweisberg/cassandra?branch=commit_remote_branch%2FCASSANDRA-17945-cassandra-4.0-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1980/]| |cassandra-4.1|[branch|https://github.com/aweisberg/cassandra/tree/commit_remote_branch/CASSANDRA-17945-cassandra-4.1-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://app.circleci.com/pipelines/github/aweisberg/cassandra?branch=commit_remote_branch%2FCASSANDRA-17945-cassandra-4.1-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1981/]| |trunk|[branch|https://github.com/aweisberg/cassandra/tree/commit_remote_branch/CASSANDRA-17945-trunk-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://app.circleci.com/pipelines/github/aweisberg/cassandra?branch=commit_remote_branch%2FCASSANDRA-17945-trunk-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1982/]| was (Author: aweisberg): +1 Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |cassandra-4.0|[branch|https://github.com/aweisberg/cassandra/tree/commit_remote_branch/CASSANDRA-17945-cassandra-4.0-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://app.circleci.com/pipelines/github/aweisberg/cassandra?branch=commit_remote_branch%2FCASSANDRA-17945-cassandra-4.0-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|unknown]| |cassandra-4.1|[branch|https://github.com/aweisberg/cassandra/tree/commit_remote_branch/CASSANDRA-17945-cassandra-4.1-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://app.circleci.com/pipelines/github/aweisberg/cassandra?branch=commit_remote_branch%2FCASSANDRA-17945-cassandra-4.1-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|unknown]| |trunk|[branch|https://github.com/aweisberg/cassandra/tree/commit_remote_branch/CASSANDRA-17945-trunk-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|https://app.circleci.com/pipelines/github/aweisberg/cassandra?branch=commit_remote_branch%2FCASSANDRA-17945-trunk-B2506A29-1AC4-4BA7-B996-435A46D1D211]|[build|unknown]| > Fix StorageService.getNativeaddress handling of IPv6 addresses > -- > > Key: CASSANDRA-17945 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17945 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Andy Tolbert >Assignee: Andy Tolbert >Priority: Normal > > StorageService.getNativeaddress does not account for IPv6 addresses in the > case NATIVE_ADDRESS_AND_PORT is not present in gossip state for an endpoint > While upgrading a cluster using IPv6 addresses from 3.0 to 4.0 I noticed the > following in logs for upgraded nodes when processing down events for 3.0 > nodes that are going down as part of an upgrade: > > {noformat} > 2022-09-28 20:18:48,244 ERROR [GossipStage:1] > org.apache.cassandra.transport.Server - Problem retrieving RPC address for > /[0:0:0:0:0:0:0:d9]:7000 > java.net.UnknownHostException: 0:0:0:0:0:0:0:d9:9042: invalid IPv6 address > at java.net.InetAddress.getAllByName(InetAddress.java:1355) ~[?:?] > at java.net.InetAddress.getAllByName(InetAddress.java:1306) ~[?:?] > at java.net.InetAddress.getByName(InetAddress.java:1256) ~[?:?] > at > org.apache.cassandra.locator.InetAddressAndPort.getByNameOverrideDefaults(InetAddressAndPort.java:227) > > at > org.apache.cassandra.locator.InetAddressAndPort.getByName(InetAddressAndPort.java:212) > > at > org.apache.cassandra.transport.Server$EventNotifier.getNativeAddress(Server.java:377) > > at > org.apache.cassandra.transport.Server$EventNotifier.onDown(Server.java:438) > at > org.apache.cassandra.service.StorageService.notifyDown(StorageService.java:2651) > > at > org.apache.cassandra.service.StorageService.onDead(StorageService.java:3516) > at org.apache.cassandra.gms.Gossiper.markDead(Gossiper.java:1347) > at org.apache.cassandra.gms.Gossiper.markAsShutdown(Gossiper.java:590) > at > org.apache.cassandra.gms.GossipShutdownVerbHandler.doVerb(GossipShutdownVerbHandler.java:39) > > at org.apache.cassandra.net.InboundSink.lambda$new$0(InboundSink.java:78) > at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:97) > at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:45) > at > org.apache