[jira] [Comment Edited] (CASSANDRA-4795) replication, compaction, compression? options are not validated
[ https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576457#comment-13576457 ] Pavel Yaskevich edited comment on CASSANDRA-4795 at 2/12/13 8:19 AM: - I don't think this is about right or wrong but rather about living by means instead of re-inventing broken bicycle. I'm not arguing or trying to convince, I'm simply saying that committed patch made situation even worse and it should be reconsidered all together. Also, if somebody ever had mistyped and didn't fix or used unrecognized attributes in replication strategy or compaction, after upgrade to 1.2.1 Cassandra just *wouldn't start up* which is also a "ridiculously bad user experience", this is why I think this patch should be reverted. Edit: I think that concerns DSE as well, because AFAIK they used custom attributes in the compaction strategy as well as in keyspace replication. was (Author: xedin): I don't think this is about right or wrong but rather about living by means instead of re-inventing broken bicycle. I'm not arguing or trying to convince, I'm simply saying that committed patch made situation even worse and it should be reconsidered all together. Also, if somebody ever had mistyped and didn't fix or used unrecognized attributes in replication strategy or compaction, after upgrade to 1.2.1 Cassandra just *wouldn't start up* which is also a "ridiculously bad user experience", this is why I think this patch should be reverted. > replication, compaction, compression? options are not validated > --- > > Key: CASSANDRA-4795 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4795 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Brandon Williams >Assignee: Dave Brosius >Priority: Minor > Fix For: 1.2.1 > > Attachments: 4795.compaction_strategy.txt, > 4795_compaction_strategy_v2.txt, 4795_compaction_strategy_v3.txt, > 4795.replication_strategy.txt > > > When creating a keyspace and specifying strategy options, you can pass any > k/v pair you like. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4795) replication, compaction, compression? options are not validated
[ https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560359#comment-13560359 ] Dave Brosius edited comment on CASSANDRA-4795 at 1/23/13 5:06 AM: -- not sure where CFPropDefs.validate gets used with cql3 ah, never mind. two CFPropDefs. was (Author: dbrosius): not sure where CFPropDefs.validate gets used with cql3 > replication, compaction, compression? options are not validated > --- > > Key: CASSANDRA-4795 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4795 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Brandon Williams >Assignee: Dave Brosius >Priority: Minor > Fix For: 1.2.1 > > Attachments: 4795.compaction_strategy.txt, > 4795.replication_strategy.txt > > > When creating a keyspace and specifying strategy options, you can pass any > k/v pair you like. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4795) replication, compaction, compression? options are not validated
[ https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553517#comment-13553517 ] Jonathan Ellis edited comment on CASSANDRA-4795 at 1/15/13 5:44 AM: I'd no-op it for backwards compatibility with user-provided ACS implementations. was (Author: jbellis): I'd no-op it for backwards compatibility. > replication, compaction, compression? options are not validated > --- > > Key: CASSANDRA-4795 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4795 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Brandon Williams >Assignee: Dave Brosius >Priority: Minor > Fix For: 1.2.1 > > Attachments: 4795.replication_strategy.txt > > > When creating a keyspace and specifying strategy options, you can pass any > k/v pair you like. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4795) replication, compaction, compression? options are not validated
[ https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553498#comment-13553498 ] Dave Brosius edited comment on CASSANDRA-4795 at 1/15/13 5:23 AM: -- the 'right'?? solution perhaps is to remove the cfs from AbstractCompactionStrategy ctor, and instead pass it into the various methods that need it. Problem there is that you'd need a 'postCreateInitialize(ColumnFamilyStore cfs)' on ACS, as SizeTiered and Leveled do things with cfs in the ctor, that would need to move to that method. It would also break backwards compatibility with potential client ACS's. was (Author: dbrosius): the 'right'?? solution perhaps is to remove the cfs from AbstractCompactionStrategy ctor, and instead pass it into the various methods that need it. Problem there is that you'd need a 'postCreateInitialize(ColumnFamilyStore cfs)' on ACS, as SizeTiered and Leveled do things with cfs in the ctor, that would need to move to that method. > replication, compaction, compression? options are not validated > --- > > Key: CASSANDRA-4795 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4795 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Brandon Williams >Assignee: Dave Brosius >Priority: Minor > Fix For: 1.2.1 > > Attachments: 4795.replication_strategy.txt > > > When creating a keyspace and specifying strategy options, you can pass any > k/v pair you like. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4795) replication, compaction, compression? options are not validated
[
https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553488#comment-13553488
]
Jonathan Ellis edited comment on CASSANDRA-4795 at 1/15/13 5:04 AM:
What if we required a static {{validate}} method on ACS subclasses that we call
with the options and maybe CFMetaData? Ugly, since there's no polymorphism on
statics, but since we're doing ACS creation via reflection anyway it's not
really a problem.
Edit: which is pretty much what you suggested with the difference being where
the logic lives. Either way WFM.
was (Author: jbellis):
What if we required a static {{validate}} method on ACS subclasses that we
call with the options and maybe CFMetaData? Ugly, since there's no
polymorphism on statics, but since we're doing ACS creation via reflection
anyway it's not really a problem.
> replication, compaction, compression? options are not validated
> ---
>
> Key: CASSANDRA-4795
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.0
>Reporter: Brandon Williams
>Assignee: Dave Brosius
>Priority: Minor
> Fix For: 1.2.1
>
> Attachments: 4795.replication_strategy.txt
>
>
> When creating a keyspace and specifying strategy options, you can pass any
> k/v pair you like.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
