[jira] [Comment Edited] (CASSANDRA-6237) Allow range deletions in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731275#comment-14731275
]
Benjamin Lerer edited comment on CASSANDRA-6237 at 9/4/15 7:18 PM:
---
Thanks for review [~JoshuaMcKenzie].
[~tjake] I did not forget your test.
commit: 2e3727e3ff682dbab734aaccf641360bc62a8561
was (Author: blerer):
Thanks for review [~JoshuaMcKenzie].
[~tjake] I did not forgot your test.
commit: 2e3727e3ff682dbab734aaccf641360bc62a8561
> Allow range deletions in CQL
>
>
> Key: CASSANDRA-6237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6237
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Benjamin Lerer
>Priority: Minor
> Labels: cql, docs
> Fix For: 3.0 beta 2
>
> Attachments: CASSANDRA-6237.txt
>
>
> We uses RangeTombstones internally in a number of places, but we could expose
> more directly too. Typically, given a table like:
> {noformat}
> CREATE TABLE events (
> id text,
> created_at timestamp,
> content text,
> PRIMARY KEY (id, created_at)
> )
> {noformat}
> we could allow queries like:
> {noformat}
> DELETE FROM events WHERE id='someEvent' AND created_at < 'Jan 3, 2013';
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-6237) Allow range deletions in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731256#comment-14731256
]
Benjamin Lerer edited comment on CASSANDRA-6237 at 9/4/15 6:59 PM:
---
* The results of the unit tests are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-6237-3.0-testall/6/]
* The results of the dtests are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-6237-3.0-dtest/6/]
I checked the DTests and the errors do not seems related to the changes.
was (Author: blerer):
* The results of the unit tests are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-6237-3.0-testall/6/]
* The results of the dtests are
[here|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-6237-3.0-dtest/6/]
I checked the DTests and the errors do not seems related.
> Allow range deletions in CQL
>
>
> Key: CASSANDRA-6237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6237
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Benjamin Lerer
>Priority: Minor
> Labels: cql, docs
> Fix For: 3.0 beta 2
>
> Attachments: CASSANDRA-6237.txt
>
>
> We uses RangeTombstones internally in a number of places, but we could expose
> more directly too. Typically, given a table like:
> {noformat}
> CREATE TABLE events (
> id text,
> created_at timestamp,
> content text,
> PRIMARY KEY (id, created_at)
> )
> {noformat}
> we could allow queries like:
> {noformat}
> DELETE FROM events WHERE id='someEvent' AND created_at < 'Jan 3, 2013';
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-6237) Allow range deletions in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631193#comment-14631193
]
Benjamin Lerer edited comment on CASSANDRA-6237 at 7/17/15 11:07 AM:
-
{quote}It's not clear to me why some user function tests changed, e.g. here and
here. Are these in scope for this ticket?{quote}
Statements are processed in 2 phases. They are prepared and then executed. We
try to preform the validation, as much as possible, in the preparation phase.
It was not always the case for Insert/Update/Delete statements. I fixed that in
my patch.
Some of the unit tests were using invalid statements but as they were only
testing the preparation phase no errors were thrown.
After my patch it was no longer the case. So, I had to make sure that the
statements were valid.
was (Author: blerer):
{quote}It's not clear to me why some user function tests changed, e.g. here and
here. Are these in scope for this ticket?{quote}
Statements are processed in 2 phases. They are prepared and then executed. We
try to preform the validation as much as possible in the preparation phase. It
was not always the case for Insert/Update/Delete statements. I fixed that in my
patch.
Some of the unit tests were using invalid statements but as they were only
testing the preparation phase no errors were thrown.
After my patch it was no longer the case. So I had to make sure that the
statements were valid.
> Allow range deletions in CQL
>
>
> Key: CASSANDRA-6237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6237
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Benjamin Lerer
>Priority: Minor
> Labels: cql, docs
> Fix For: 3.0.0 rc1
>
> Attachments: CASSANDRA-6237.txt
>
>
> We uses RangeTombstones internally in a number of places, but we could expose
> more directly too. Typically, given a table like:
> {noformat}
> CREATE TABLE events (
> id text,
> created_at timestamp,
> content text,
> PRIMARY KEY (id, created_at)
> )
> {noformat}
> we could allow queries like:
> {noformat}
> DELETE FROM events WHERE id='someEvent' AND created_at < 'Jan 3, 2013';
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-6237) Allow range deletions in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379081#comment-14379081
]
Jim Witschey edited comment on CASSANDRA-6237 at 3/25/15 1:13 AM:
--
How are range deletions expected to interact with batches? I have a dtest
[here|https://github.com/riptano/cassandra-dtest/blob/0d50f835c26bfcb71164a64fb1b80f4c3022e0b9/range_deletion_test.py#L63]
with a batch that succeeds:
{code}
BEGIN BATCH
DELETE FROM test WHERE partition_key = 1
DELETE FROM test WHERE partition_key = 2 AND i IN (0, 4)
APPLY BATCH;
{code}
and another
[here|https://github.com/riptano/cassandra-dtest/blob/0d50f835c26bfcb71164a64fb1b80f4c3022e0b9/range_deletion_test.py#L95]
with a batch that errors out:
{code}
BEGIN BATCH
DELETE FROM test WHERE partition_key = 2 AND i >= 3
APPLY BATCH;
{code}
I think the problem statement is the inequality.
The error on the dtest side is
{code}
ServerError:
{code}
was (Author: mambocab):
How are range deletions expected to interact with batches? I have a dtest
[here|https://github.com/riptano/cassandra-dtest/blob/0d50f835c26bfcb71164a64fb1b80f4c3022e0b9/range_deletion_test.py#L63]
with a batch that succeeds:
{code}
BEGIN BATCH
DELETE FROM test WHERE partition_key = 1
DELETE FROM test WHERE partition_key = 2 AND i IN (0, 4)
APPLY BATCH;
{code}
and another
[here|https://github.com/riptano/cassandra-dtest/blob/0d50f835c26bfcb71164a64fb1b80f4c3022e0b9/range_deletion_test.py#L95]
with a batch that errors out:
{code}
BEGIN BATCH
DELETE FROM test WHERE partition_key = 2 AND i >= 3
APPLY BATCH;
{code}
The error on the dtest side is
{code}
ServerError:
{code}
> Allow range deletions in CQL
>
>
> Key: CASSANDRA-6237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6237
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Benjamin Lerer
>Priority: Minor
> Labels: cql, docs
> Fix For: 3.0
>
> Attachments: CASSANDRA-6237.txt
>
>
> We uses RangeTombstones internally in a number of places, but we could expose
> more directly too. Typically, given a table like:
> {noformat}
> CREATE TABLE events (
> id text,
> created_at timestamp,
> content text,
> PRIMARY KEY (id, created_at)
> )
> {noformat}
> we could allow queries like:
> {noformat}
> DELETE FROM events WHERE id='someEvent' AND created_at < 'Jan 3, 2013';
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-6237) Allow range deletions in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121061#comment-14121061
]
Benjamin Lerer edited comment on CASSANDRA-6237 at 9/4/14 7:31 AM:
---
It is not big but I really would prefer to have 7016 and 4762 commited as I
believe that they impact some part of code that will be reuse.
was (Author: blerer):
It is not big but I really would prefer to have 7016 and 4762 commited as I
believe that they impact some part of code that will be reused.
> Allow range deletions in CQL
>
>
> Key: CASSANDRA-6237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6237
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Benjamin Lerer
>Priority: Minor
> Labels: cql, docs
> Fix For: 3.0
>
> Attachments: CASSANDRA-6237.txt
>
>
> We uses RangeTombstones internally in a number of places, but we could expose
> more directly too. Typically, given a table like:
> {noformat}
> CREATE TABLE events (
> id text,
> created_at timestamp,
> content text,
> PRIMARY KEY (id, created_at)
> )
> {noformat}
> we could allow queries like:
> {noformat}
> DELETE FROM events WHERE id='someEvent' AND created_at < 'Jan 3, 2013';
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
