[ https://issues.apache.org/jira/browse/CASSANDRA-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196653#comment-14196653 ]
Joshua McKenzie edited comment on CASSANDRA-8230 at 11/4/14 7:56 PM: --------------------------------------------------------------------- I'm in general a +1 to the latest branch, though I do have the following 2 concerns / thoughts: # This is making the inheritance hierarchy for tokens less consistent / clear rather than more. (3/5 Abstract, 2/5 Token). Rolling back some of the structural changes from CASSANDRA-8171 this soon makes me wary in general principle, though it seems quite reasonable in this case. # Do we have reason to believe that boxing/unboxing on tokens is a performance problem and that, if so, this patch addresses that problem? (edit: for point 2, clearly boxing is less performant than straight primitives and this would be an improvement but if we're not bottlenecking on this and/or it's a non-measurable problem...) was (Author: joshuamckenzie): I'm in general a +1 to the latest branch, though I do have the following 2 concerns / thoughts: # This is making the inheritance hierarchy for tokens less consistent / clear rather than more. (3/5 Abstract, 2/5 Token). Rolling back some of the structural changes from CASSANDRA-8171 this soon makes me wary in general principle, though it seems quite reasonable in this case. # Do we have reason to believe that boxing/unboxing on tokens is a performance problem and that, if so, this patch addresses that problem? > LongToken no longer needs to use a boxed Long > --------------------------------------------- > > Key: CASSANDRA-8230 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8230 > Project: Cassandra > Issue Type: Improvement > Reporter: Branimir Lambov > Assignee: Branimir Lambov > Priority: Minor > Fix For: 2.1.2 > > Attachments: 8230-2.1-v2.patch, 8230-2.1.patch > > > After CASSANDRA-8171 a token reference field is no longer a requirement for > tokens. This permits LongTokens to include a primitive long field, which > should noticeably improve the space and time efficiency of the > Murmur3Partitioner tokens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)