[jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
[
https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711162#comment-14711162
]
Aleksey Yeschenko commented on CASSANDRA-10046:
---
+1
> RangeTombstone validation missing on thrift
> ---
>
> Key: CASSANDRA-10046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: T Jake Luciani
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 3.0 beta 2
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation
> exception when a deletion with a slice that is not start == finish.
> We should add better validation to throw a clear exception sooner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
[
https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709205#comment-14709205
]
Sylvain Lebresne commented on CASSANDRA-10046:
--
Seems the upgrade tests have been reverted for now since they are posing
problem on cassci.
Now, I would suggest that we please review and commit this _without_ waiting on
those tests. In a perfect world, I would agree waiting on those test would be
nice, but in the meantime I'd like to really focus on fixing all outstanding
dtests because people are creating dtests regression faster than they are fixed
and the only solution to stop the bleeding is probably to get all dtests to
pass (so people stop being lazy at checking dtests and see they own regressions
before commit).
> RangeTombstone validation missing on thrift
> ---
>
> Key: CASSANDRA-10046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
> Project: Cassandra
> Issue Type: Bug
>Reporter: T Jake Luciani
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 3.0.0 rc1
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation
> exception when a deletion with a slice that is not start == finish.
> We should add better validation to throw a clear exception sooner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
[
https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706922#comment-14706922
]
Jim Witschey commented on CASSANDRA-10046:
--
The upgrade tests have been merged:
https://github.com/riptano/cassandra-dtest/commit/aa11378df41f0e21e8ca84b55e16caf50ae44227
> RangeTombstone validation missing on thrift
> ---
>
> Key: CASSANDRA-10046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
> Project: Cassandra
> Issue Type: Bug
>Reporter: T Jake Luciani
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 3.0.0 rc1
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation
> exception when a deletion with a slice that is not start == finish.
> We should add better validation to throw a clear exception sooner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
[
https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701757#comment-14701757
]
Tyler Hobbs commented on CASSANDRA-10046:
-
We should probably wait for the [upgrade
dtests|https://issues.apache.org/jira/browse/CASSANDRA-9893?focusedCommentId=14700943&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14700943]
to get merged in and run on this branch before committing.
> RangeTombstone validation missing on thrift
> ---
>
> Key: CASSANDRA-10046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
> Project: Cassandra
> Issue Type: Bug
>Reporter: T Jake Luciani
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 3.0.0 rc1
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation
> exception when a deletion with a slice that is not start == finish.
> We should add better validation to throw a clear exception sooner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
[
https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698816#comment-14698816
]
Sylvain Lebresne commented on CASSANDRA-10046:
--
For the record, this is a regression from CASSANDRA-9704.
This is also not a validation issue, as those test should be passing and we do
want to handle range tombstones whose start differ from their end.
As far as I can tell, the problem is in the
{{LegacyLayout.LegacyDeletionInfo.from}} method: it basically ends up
considering all RT as a in-row tombstone, which is definitively incorrect. And
in fact, that methods takes a {{DeletionInfo}}, so it can't have any in-row
tombstone by definition. So I think the simplest way to deal with this is to
have {{CassandraServer}} adds to a {{LegacyDeletionInfo}} object directly
(instead of a {{DeletionInfo}}) and have it deal with in-row tombstones
directly. Pushed a branch to do so
[here|https://github.com/pcmanus/cassandra/commits/10046].
CI results will be eventually avaible for the
[utests|http://cassci.datastax.com/view/Dev/view/pcmanus/job/pcmanus-10046-testall/]
and
[dtests|http://cassci.datastax.com/view/Dev/view/pcmanus/job/pcmanus-10046-dtest/].
Marking [~thobbs] as reviewer since he is the original author of CASSANDRA-9704.
> RangeTombstone validation missing on thrift
> ---
>
> Key: CASSANDRA-10046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
> Project: Cassandra
> Issue Type: Bug
>Reporter: T Jake Luciani
>Assignee: T Jake Luciani
>Priority: Minor
> Fix For: 3.0.0 rc1
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation
> exception when a deletion with a slice that is not start == finish.
> We should add better validation to throw a clear exception sooner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10046) RangeTombstone validation missing on thrift
[
https://issues.apache.org/jira/browse/CASSANDRA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682366#comment-14682366
]
T Jake Luciani commented on CASSANDRA-10046:
Incase this is a valid bug the issue is in the LegacyCellGrouper
https://github.com/apache/cassandra/blob/8c64cefd19d706003d4b33b333274dbf17c9cb34/src/java/org/apache/cassandra/db/LegacyLayout.java#L1140
We only support range tombstones with the same prefix or a collection name.
> RangeTombstone validation missing on thrift
> ---
>
> Key: CASSANDRA-10046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10046
> Project: Cassandra
> Issue Type: Bug
>Reporter: T Jake Luciani
>Assignee: T Jake Luciani
>Priority: Minor
> Fix For: 3.0 beta 1
>
>
> Currently a number of thrift tests fail due to a NPE
> {code}
> test_range_deletion
> test_batch_mutate_remove_slice_standard
> test_batch_mutate_remove_slice_of_entire_supercolumns
> {code}
> These errors all stem from the fact we aren't properly throwing a validation
> exception when a deletion with a slice that is not start == finish.
> We should add better validation to throw a clear exception sooner.
> I've already pushed a fix to dtest to ignore these tests in >= 3.0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
