[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[
https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610756#comment-17610756
]
Brad Schoening commented on CASSANDRA-10383:
[~smiklosovic] one of the unit tests in test_cqlsh_output.py is broken, and it
may have been this change.
FAILED
test/test_cqlsh_output.py::TestCqlshOutput::test_describe_columnfamily_output -
AssertionError: Sequences differ: ['CRE[491 chars] AND bloom_filt...
{noformat}
> self.assertSequenceEqual(dedent(output).split('\n'),
> table_desc3.split('\n'))
E AssertionError: Sequences differ: ['CRE[491 chars] AND
bloom_filter_fp_chance = 0.01', " AND [682 chars]p';"] != ['CRE[491 chars]
AND allow_auto_snapshot = true', ' AND blo[752 chars]p';"]
E
E First differing element 18:
E ' AND bloom_filter_fp_chance = 0.01'
E ' AND allow_auto_snapshot = true'
E
E Second sequence contains 2 additional elements.
E First extra element 33:
E " AND read_repair = 'BLOCKING'"
{noformat}
> Disable auto snapshot on selected tables.
> -
>
> Key: CASSANDRA-10383
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10383
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Snapshots
>Reporter: Tommy Stendahl
>Assignee: Stefan Miklosovic
>Priority: Normal
> Labels: doc-impacting, messaging-service-bump-required
> Fix For: 4.2
>
> Attachments: 10383.txt
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a use case where I would like to turn off auto snapshot for selected
> tables, I don't want to turn it off completely since its a good feature.
> Looking at the code I think it would be relatively easy to fix.
> My plan is to create a new table property named something like
> "disable_auto_snapshot". If set to true it will prevent auto snapshot on the
> table, if set to false auto snapshot will be controlled by the
> "auto_snapshot" property in the cassandra.yaml. Default would be false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601263#comment-17601263 ] Aleksey Yeschenko commented on CASSANDRA-10383: --- +1 > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config, Local/Snapshots >Reporter: Tommy Stendahl >Assignee: Stefan Miklosovic >Priority: Normal > Labels: doc-impacting, messaging-service-bump-required > Fix For: 4.x > > Attachments: 10383.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to true it will prevent auto snapshot on the > table, if set to false auto snapshot will be controlled by the > "auto_snapshot" property in the cassandra.yaml. Default would be false. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601187#comment-17601187 ] Stefan Miklosovic commented on CASSANDRA-10383: --- Thanks [~aleksey] for taking a look. I incorporated your comments into the PR. j8 precommit https://app.circleci.com/pipelines/github/instaclustr/cassandra/1271/workflows/ae9a6482-2980-45b7-956f-76030c89fe4d j11 precommit https://app.circleci.com/pipelines/github/instaclustr/cassandra/1271/workflows/30404e7e-aa1e-46e7-a04e-3b096d21a33a > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config, Local/Snapshots >Reporter: Tommy Stendahl >Assignee: Stefan Miklosovic >Priority: Normal > Labels: doc-impacting, messaging-service-bump-required > Fix For: 4.x > > Attachments: 10383.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to true it will prevent auto snapshot on the > table, if set to false auto snapshot will be controlled by the > "auto_snapshot" property in the cassandra.yaml. Default would be false. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584459#comment-17584459 ] Stefan Miklosovic commented on CASSANDRA-10383: --- Hi [~fibersel] are you going to work on this? I see you as a reviewer, otherwise I would like to finish this or explore where we stands as 4.0 is already out. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config, Local/Snapshots >Reporter: Tommy Stendahl >Assignee: Abuli Palagashvili >Priority: Normal > Labels: doc-impacting, messaging-service-bump-required > Fix For: 4.x > > Attachments: 10383.txt > > Time Spent: 10m > Remaining Estimate: 0h > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to true it will prevent auto snapshot on the > table, if set to false auto snapshot will be controlled by the > "auto_snapshot" property in the cassandra.yaml. Default would be false. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350259#comment-17350259 ] Tommy Stendahl commented on CASSANDRA-10383: [~paulo] Unfortunately not, its a long way down on my todo list today so its unlikely that I will find the time. So if someone like to work on this please go ahead. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Tommy Stendahl >Priority: Normal > Labels: doc-impacting, messaging-service-bump-required > Fix For: 4.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to true it will prevent auto snapshot on the > table, if set to false auto snapshot will be controlled by the > "auto_snapshot" property in the cassandra.yaml. Default would be false. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350125#comment-17350125 ] Paulo Motta commented on CASSANDRA-10383: - [~tommy_s] do you plan to resume this work on can someone else take it now that 4.0 is out? > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Tommy Stendahl >Priority: Normal > Labels: doc-impacting, messaging-service-bump-required > Fix For: 4.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097855#comment-15097855 ] Tommy Stendahl commented on CASSANDRA-10383: Is there a jira created for the new schema-change protocol? I did search for it but I couldn't find any. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Labels: doc-impacting, messaging-service-bump-required > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010695#comment-15010695 ] Tommy Stendahl commented on CASSANDRA-10383: To bad, but I guess that there is no way around it. I will redo my patch on 4.0 when possible and we can take it from there. Thanks for spending the time reviewing this so far. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Labels: doc-impacting > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[
https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008820#comment-15008820
]
Robert Stupp commented on CASSANDRA-10383:
--
Although the patch looks good, we have to delay it until 4.0.
Reason for that is that schema tables must stay unchanged within all 3.x
versions - otherwise the node that does not know about the new column will fail
do deserialize mutations. What we would need is a messaging-version bump, which
will not happen before 4.0.
There will be a new schema-change protocol without these limitations - but that
would require a messaging-version bump, too.
{code}
java.lang.RuntimeException: Unknown column allow_auto_snapshot during
deserialization
at
org.apache.cassandra.db.Columns$Serializer.deserialize(Columns.java:432)
~[main/:na]
at
org.apache.cassandra.db.SerializationHeader$Serializer.deserializeForMessaging(SerializationHeader.java:397)
~[main/:na]
at
org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.deserializeHeader(UnfilteredRowIteratorSerializer.java:190)
~[main/:na]
at
org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize30(PartitionUpdate.java:635)
~[main/:na]
at
org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize(PartitionUpdate.java:623)
~[main/:na]
at
org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:323)
~[main/:na]
at
org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:332)
~[main/:na]
at
org.apache.cassandra.service.MigrationManager$MigrationsSerializer.deserialize(MigrationManager.java:589)
~[main/:na]
at
org.apache.cassandra.service.MigrationManager$MigrationsSerializer.deserialize(MigrationManager.java:572)
~[main/:na]
at org.apache.cassandra.net.MessageIn.read(MessageIn.java:114)
~[main/:na]
at
org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:188)
~[main/:na]
{code}
> Disable auto snapshot on selected tables.
> -
>
> Key: CASSANDRA-10383
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10383
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Tommy Stendahl
>Assignee: Tommy Stendahl
> Labels: doc-impacting
> Attachments: 10383.txt
>
>
> I have a use case where I would like to turn off auto snapshot for selected
> tables, I don't want to turn it off completely since its a good feature.
> Looking at the code I think it would be relatively easy to fix.
> My plan is to create a new table property named something like
> "disable_auto_snapshot". If set to false it will prevent auto snapshot on the
> table, if set to true auto snapshot will be controlled by the "auto_snapshot"
> property in the cassandra.yaml. Default would be true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955145#comment-14955145 ] Aleksey Yeschenko commented on CASSANDRA-10383: --- Going to have an extra look of my own (at the schema parts mostly) - please don't commit until then. Thanks. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950474#comment-14950474 ] Tommy Stendahl commented on CASSANDRA-10383: I have created a new patch based on 3.2, you find it [here|https://github.com/tommystendahl/cassandra/tree/cassandra-10383-trunk]. * I have updated test_cqlsh_completion.py. * I have created unit tests in SchemaKeyspaceTest * I have extracted cfs.metadata.params.allowAutoSnapshot && DatabaseDescriptor.isAutoSnapshot() to a new method in CFS. * I have looked at the ThriftConversion and I see the problem when updating via Thrift, I added a solution for that but I'm not sure it should be done that way, I can remove it if you think its wrong maybe there is a better way. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949016#comment-14949016 ] Tyler Hobbs commented on CASSANDRA-10383: - New features should go into 3.2 (trunk) at this point. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[
https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948701#comment-14948701
]
Robert Stupp commented on CASSANDRA-10383:
--
Looked a bit deeper into the code and did a quick, successful test. Nice work +
the code itself looks really good!
* {{test_cqlsh_completion.py}} misses the new keyword (look out for
{{bloom_filter_fp_chance}} as a reference).
* I’d prefer to have a unit test for this change. You can add a separate unit
test class or extend {{SchemaKeyspaceTest}}. Issuing the operations that
trigger an auto-snapshot and use
{{Keyspace.getColumnFamilyStore}}+{{ColumnFamilyStore.getSnapshot*}} methods to
verify whether it works (in both cases).
* Thift API CF modification: I can think of a situation when updating the table
via thrift may reset the value (or not set the default value). Not sure whether
there should be some change in
{{ThriftConversion.internalFromThrift/fromThriftForUpdate/fromThrift}}.
[~iamaleksey] or someone else?
* Personally I’d like to move the several
{{cfs.metadata.params.allowAutoSnapshot &&
DatabaseDescriptor.isAutoSnapshot()}} tests into a new instance method in CFS.
Would also make unit testing easier.
* I'd favour adding this as a new feature for 3.0. Maybe even a bit too late
for new features for 3.0. But unsure whether to add this to 2.1/2.2 line.
> Disable auto snapshot on selected tables.
> -
>
> Key: CASSANDRA-10383
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10383
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Tommy Stendahl
>Assignee: Tommy Stendahl
> Fix For: 2.1.x
>
> Attachments: 10383.txt
>
>
> I have a use case where I would like to turn off auto snapshot for selected
> tables, I don't want to turn it off completely since its a good feature.
> Looking at the code I think it would be relatively easy to fix.
> My plan is to create a new table property named something like
> "disable_auto_snapshot". If set to false it will prevent auto snapshot on the
> table, if set to true auto snapshot will be controlled by the "auto_snapshot"
> property in the cassandra.yaml. Default would be true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943111#comment-14943111 ] Tommy Stendahl commented on CASSANDRA-10383: I have created a new patch based on 3.0, its availble [here|https://github.com/tommystendahl/cassandra/commits/cassandra-10383-30]. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940788#comment-14940788 ] Tommy Stendahl commented on CASSANDRA-10383: Yes, I realized yesterday that my patch wouldn't merge (don't know why I didn't check that before I submitted it). I plan to have a new patch up i a few days, not having to update thrift will make the change much simpler. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940022#comment-14940022 ] Robert Stupp commented on CASSANDRA-10383: -- Didn't look thoroughly at the patch/branch. But two things that I noticed: * Thrift API is frozen and shouldn't be changed (especially no new features) * APIs changed from 2.1/2.2 to 3.0+ and I guess that the patch cannot be merged cleanly from 2.1 via 2.1 to 3.0 and trunk. Can you provide a branch targeting 3.0, too? However, the change itself looks trivial and generally fine to me. > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933086#comment-14933086 ] ASF GitHub Bot commented on CASSANDRA-10383: Github user tommystendahl closed the pull request at: https://github.com/apache/cassandra/pull/54 > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > Attachments: 10383.txt > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10383) Disable auto snapshot on selected tables.
[ https://issues.apache.org/jira/browse/CASSANDRA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910197#comment-14910197 ] ASF GitHub Bot commented on CASSANDRA-10383: GitHub user tommystendahl opened a pull request: https://github.com/apache/cassandra/pull/54 Disable auto snapshot on selected tables (CASSANDRA-10383) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tommystendahl/cassandra cassandra-10383 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cassandra/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit c647b57abedda8e2c578cc0bab14d79ca0722b71 Author: tommy stendahl Date: 2015-09-28T08:24:18Z Disable auto snapshot on selected tables (CASSANDRA-10383) > Disable auto snapshot on selected tables. > - > > Key: CASSANDRA-10383 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10383 > Project: Cassandra > Issue Type: Improvement >Reporter: Tommy Stendahl >Assignee: Tommy Stendahl > Fix For: 2.1.x > > > I have a use case where I would like to turn off auto snapshot for selected > tables, I don't want to turn it off completely since its a good feature. > Looking at the code I think it would be relatively easy to fix. > My plan is to create a new table property named something like > "disable_auto_snapshot". If set to false it will prevent auto snapshot on the > table, if set to true auto snapshot will be controlled by the "auto_snapshot" > property in the cassandra.yaml. Default would be true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
