[jira] [Commented] (CASSANDRA-10397) Add local timezone support to cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147159#comment-15147159 ] Stefan Podkowinski commented on CASSANDRA-10397: Looks like you missed the timezone constructor argument in trunk: https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-10397#diff-c1c44ef355c4c9eae2d7d19aa38a2accL113 > Add local timezone support to cqlsh > --- > > Key: CASSANDRA-10397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10397 > Project: Cassandra > Issue Type: Improvement > Environment: Ubuntu 14.04 LTS >Reporter: Suleman Rai >Assignee: Stefan Podkowinski >Priority: Minor > Labels: cqlsh > > CQLSH is not adding the timezone offset to the timestamp after it has been > inserted into a table. > create table test(id int PRIMARY KEY, time timestamp); > INSERT INTO test(id,time) values (1,dateof(now())); > select *from test; > id | time > +- > 1 | 2015-09-25 13:00:32 > It is just displaying the default UTC timestamp without adding the timezone > offset. It should be 2015-09-25 21:00:32 in my case as my timezone offset is > +0800. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10397) Add local timezone support to cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147639#comment-15147639 ] Paulo Motta commented on CASSANDRA-10397: - bq. Looks like you missed the timezone constructor argument in trunk: Fixed this and also included subsecond precision support (CASSANDRA-10428) on trunk version. Tests look good now, marking as ready to commit: Commit info: - 2.2 patch is compatible with 3.0 - trunk patch is slightly modified due to conflicts - trunk patch was built on top of CASSANDRA-11135 since it modifies the same test, so that needs to be committed first. Thanks for the contribution [~spo...@gmail.com]! > Add local timezone support to cqlsh > --- > > Key: CASSANDRA-10397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10397 > Project: Cassandra > Issue Type: Improvement > Environment: Ubuntu 14.04 LTS >Reporter: Suleman Rai >Assignee: Stefan Podkowinski >Priority: Minor > Labels: cqlsh > > CQLSH is not adding the timezone offset to the timestamp after it has been > inserted into a table. > create table test(id int PRIMARY KEY, time timestamp); > INSERT INTO test(id,time) values (1,dateof(now())); > select *from test; > id | time > +- > 1 | 2015-09-25 13:00:32 > It is just displaying the default UTC timestamp without adding the timezone > offset. It should be 2015-09-25 21:00:32 in my case as my timezone offset is > +0800. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10397) Add local timezone support to cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153557#comment-15153557 ] Paulo Motta commented on CASSANDRA-10397: - damn! I originally had that fixed, but when rebuilding the patch on top of CASSANDRA-11135 to fix the new timestamp test (to support subsecond precision) I cherry-picked an older version, and then force-pushed against the correct commit. This [test resport|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10397-dtest/3/testReport/] shows that the test was indeed passing, oh well.. :) Anyway, many thanks for the fix patch [~stefania_alborghetti], the original fix was lost but it looks pretty similar to the one you attached. I submitted a cassci test run to be sure it won't fail again: ||trunk|| |[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-10397-fix]| |[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10397-fix-testall/lastCompletedBuild/testReport/]| |[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10397-fix-dtest/lastCompletedBuild/testReport/]| [~JoshuaMcKenzie] mind ninjaing the above patch if dtest looks good? Thanks! > Add local timezone support to cqlsh > --- > > Key: CASSANDRA-10397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10397 > Project: Cassandra > Issue Type: Improvement > Environment: Ubuntu 14.04 LTS >Reporter: Suleman Rai >Assignee: Stefan Podkowinski >Priority: Minor > Labels: cqlsh > Fix For: 2.2.6, 3.0.4, 3.4 > > Attachments: sub_precision_fix_trunk.diff > > > CQLSH is not adding the timezone offset to the timestamp after it has been > inserted into a table. > create table test(id int PRIMARY KEY, time timestamp); > INSERT INTO test(id,time) values (1,dateof(now())); > select *from test; > id | time > +- > 1 | 2015-09-25 13:00:32 > It is just displaying the default UTC timestamp without adding the timezone > offset. It should be 2015-09-25 21:00:32 in my case as my timezone offset is > +0800. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10397) Add local timezone support to cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154309#comment-15154309 ] Paulo Motta commented on CASSANDRA-10397: - Dtests look good, marking as ready to commit. > Add local timezone support to cqlsh > --- > > Key: CASSANDRA-10397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10397 > Project: Cassandra > Issue Type: Improvement > Environment: Ubuntu 14.04 LTS >Reporter: Suleman Rai >Assignee: Stefan Podkowinski >Priority: Minor > Labels: cqlsh > Fix For: 2.2.6, 3.0.4, 3.4 > > Attachments: sub_precision_fix_trunk.diff > > > CQLSH is not adding the timezone offset to the timestamp after it has been > inserted into a table. > create table test(id int PRIMARY KEY, time timestamp); > INSERT INTO test(id,time) values (1,dateof(now())); > select *from test; > id | time > +- > 1 | 2015-09-25 13:00:32 > It is just displaying the default UTC timestamp without adding the timezone > offset. It should be 2015-09-25 21:00:32 in my case as my timezone offset is > +0800. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10397) Add local timezone support to cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156311#comment-15156311 ] Stefania commented on CASSANDRA-10397: -- Thank you both! > Add local timezone support to cqlsh > --- > > Key: CASSANDRA-10397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10397 > Project: Cassandra > Issue Type: Improvement > Environment: Ubuntu 14.04 LTS >Reporter: Suleman Rai >Assignee: Stefan Podkowinski >Priority: Minor > Labels: cqlsh > Fix For: 2.2.6, 3.0.4, 3.4 > > Attachments: sub_precision_fix_trunk.diff > > > CQLSH is not adding the timezone offset to the timestamp after it has been > inserted into a table. > create table test(id int PRIMARY KEY, time timestamp); > INSERT INTO test(id,time) values (1,dateof(now())); > select *from test; > id | time > +- > 1 | 2015-09-25 13:00:32 > It is just displaying the default UTC timestamp without adding the timezone > offset. It should be 2015-09-25 21:00:32 in my case as my timezone offset is > +0800. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
