[jira] [Commented] (CASSANDRA-10468) Fix class-casting error in mixed clusters for 2.2->3.0 upgrades

2015-10-16 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960527#comment-14960527
 ] 

Benjamin Lerer commented on CASSANDRA-10468:


The code and CI look good to me. Thanks.
+1

> Fix class-casting error in mixed clusters for 2.2->3.0 upgrades
> ---
>
> Key: CASSANDRA-10468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10468
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Sylvain Lebresne
> Fix For: 3.0.0 rc2
>
>
> Three upgrade tests:
> - {{upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test}}
> fail on the upgrade path from 2.2 to 3.0. The failures can be found on CassCI 
> here:
> [cas_and_list_index_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/cas_and_list_index_test/]
> [collection_and_regular_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/collection_and_regular_test/]
> [composite_index_collections_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/composite_index_collections_test/]
> You can run these tests with the following command:
> {code}
> SKIP=false CASSANDRA_VERSION=binary:2.2.0 UPGRADE_TO=git:cassandra-3.0 
> nosetests 2>&1 upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test 
> upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test 
> upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test
> {code}
> Once [this dtest PR|https://github.com/riptano/cassandra-dtest/pull/586] is 
> merged, these tests should also run with this upgrade path on normal 3.0 jobs.
> EDIT: the following test seems to fail with the same error:
> http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/41/testReport/upgrade_tests.cql_tests/TestCQL/null_support_test/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10468) Fix class-casting error in mixed clusters for 2.2->3.0 upgrades

2015-10-15 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958673#comment-14958673
 ] 

Sylvain Lebresne commented on CASSANDRA-10468:
--

Correct, there is problems with the reversed case (on top of the one you 
mention, we also don't properly reverse the name comparator). Pushed a fix 
[here|https://github.com/pcmanus/cassandra/commits/10468-followup] that also 
include a unit test for all this.

> Fix class-casting error in mixed clusters for 2.2->3.0 upgrades
> ---
>
> Key: CASSANDRA-10468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10468
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Sylvain Lebresne
> Fix For: 3.0.0 rc2
>
>
> Three upgrade tests:
> - {{upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test}}
> fail on the upgrade path from 2.2 to 3.0. The failures can be found on CassCI 
> here:
> [cas_and_list_index_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/cas_and_list_index_test/]
> [collection_and_regular_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/collection_and_regular_test/]
> [composite_index_collections_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/composite_index_collections_test/]
> You can run these tests with the following command:
> {code}
> SKIP=false CASSANDRA_VERSION=binary:2.2.0 UPGRADE_TO=git:cassandra-3.0 
> nosetests 2>&1 upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test 
> upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test 
> upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test
> {code}
> Once [this dtest PR|https://github.com/riptano/cassandra-dtest/pull/586] is 
> merged, these tests should also run with this upgrade path on normal 3.0 jobs.
> EDIT: the following test seems to fail with the same error:
> http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/41/testReport/upgrade_tests.cql_tests/TestCQL/null_support_test/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10468) Fix class-casting error in mixed clusters for 2.2->3.0 upgrades

2015-10-14 Thread Benjamin Lerer (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956430#comment-14956430
 ] 

Benjamin Lerer commented on CASSANDRA-10468:


+1

> Fix class-casting error in mixed clusters for 2.2->3.0 upgrades
> ---
>
> Key: CASSANDRA-10468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10468
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Sylvain Lebresne
> Fix For: 3.0.0 rc2
>
>
> Three upgrade tests:
> - {{upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test}}
> fail on the upgrade path from 2.2 to 3.0. The failures can be found on CassCI 
> here:
> [cas_and_list_index_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/cas_and_list_index_test/]
> [collection_and_regular_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/collection_and_regular_test/]
> [composite_index_collections_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/composite_index_collections_test/]
> You can run these tests with the following command:
> {code}
> SKIP=false CASSANDRA_VERSION=binary:2.2.0 UPGRADE_TO=git:cassandra-3.0 
> nosetests 2>&1 upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test 
> upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test 
> upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test
> {code}
> Once [this dtest PR|https://github.com/riptano/cassandra-dtest/pull/586] is 
> merged, these tests should also run with this upgrade path on normal 3.0 jobs.
> EDIT: the following test seems to fail with the same error:
> http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/41/testReport/upgrade_tests.cql_tests/TestCQL/null_support_test/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10468) Fix class-casting error in mixed clusters for 2.2->3.0 upgrades

2015-10-13 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954633#comment-14954633
 ] 

Sylvain Lebresne commented on CASSANDRA-10468:
--

Trivial (one-line) patch pushed 
[here|https://github.com/pcmanus/cassandra/commits/10468]. The 
{{ClassCastException}} was due to a pretty stupid typo in 
{{BTreeRow.CellInLegacyOrderIterator}} that I introduced in CASSANDRA-10254, so 
my bad.

> Fix class-casting error in mixed clusters for 2.2->3.0 upgrades
> ---
>
> Key: CASSANDRA-10468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10468
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Sylvain Lebresne
> Fix For: 3.0.0 rc2
>
>
> Three upgrade tests:
> - {{upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test}}
> - {{upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test}}
> fail on the upgrade path from 2.2 to 3.0. The failures can be found on CassCI 
> here:
> [cas_and_list_index_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/cas_and_list_index_test/]
> [collection_and_regular_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/collection_and_regular_test/]
> [composite_index_collections_test|http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/43/testReport/upgrade_tests.cql_tests/TestCQL/composite_index_collections_test/]
> You can run these tests with the following command:
> {code}
> SKIP=false CASSANDRA_VERSION=binary:2.2.0 UPGRADE_TO=git:cassandra-3.0 
> nosetests 2>&1 upgrade_tests/cql_tests.py:TestCQL.cas_and_list_index_test 
> upgrade_tests/cql_tests.py:TestCQL.collection_and_regular_test 
> upgrade_tests/cql_tests.py:TestCQL.composite_index_collections_test
> {code}
> Once [this dtest PR|https://github.com/riptano/cassandra-dtest/pull/586] is 
> merged, these tests should also run with this upgrade path on normal 3.0 jobs.
> EDIT: the following test seems to fail with the same error:
> http://cassci.datastax.com/view/Upgrades/job/storage_engine_upgrade_dtest-22_tarball-30_HEAD/41/testReport/upgrade_tests.cql_tests/TestCQL/null_support_test/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)