[jira] [Commented] (CASSANDRA-10518) initialDirectories passed into ColumnFamilyStore contructor
[
https://issues.apache.org/jira/browse/CASSANDRA-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958812#comment-14958812
]
Marcus Eriksson commented on CASSANDRA-10518:
-
Ok, this lgtm (with a tiny nit), will commit once CI is done;
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-10518-dtest/
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-blake-10518-testall/
> initialDirectories passed into ColumnFamilyStore contructor
> ---
>
> Key: CASSANDRA-10518
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10518
> Project: Cassandra
> Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Minor
> Fix For: 3.0.0 rc2
>
> Attachments: 10518-v2.txt, initialDirectoriesFixV1.patch
>
>
> One of the goals of CASSANDRA-8671 was to let compaction strategies write to
> directories not used by normal tables, and the field
> {{ColumnFamilyStore.initialDirectories}} was added to make sstables in those
> directories discoverable on cfs instantiation.
> Unfortunately, in my patch, I passed the full list of directories
> {{initialDirectories}} into the ColumnFamilyStore constructor, effectively
> making these directories usable by any table. The attached patch fixes this,
> and elaborates on the correct usage of the usage of
> {{ColumnFamilyStore.addInitialDirectories}} in it's comment
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10518) initialDirectories passed into ColumnFamilyStore contructor
[
https://issues.apache.org/jira/browse/CASSANDRA-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956383#comment-14956383
]
Marcus Eriksson commented on CASSANDRA-10518:
-
Not sure I understand how you intend to use this
* afaict initialDirectories is only used to figure out the max generation in
createColumnFamilyStore(...)
* initialDirectories is static and we only add more directories to it - if you
have several tables with custom data directories, wont they all just be
appended?
> initialDirectories passed into ColumnFamilyStore contructor
> ---
>
> Key: CASSANDRA-10518
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10518
> Project: Cassandra
> Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Minor
> Fix For: 3.0.0 rc2
>
> Attachments: initialDirectoriesFixV1.patch
>
>
> One of the goals of CASSANDRA-8671 was to let compaction strategies write to
> directories not used by normal tables, and the field
> {{ColumnFamilyStore.initialDirectories}} was added to make sstables in those
> directories discoverable on cfs instantiation.
> Unfortunately, in my patch, I passed the full list of directories
> {{initialDirectories}} into the ColumnFamilyStore constructor, effectively
> making these directories usable by any table. The attached patch fixes this,
> and elaborates on the correct usage of the usage of
> {{ColumnFamilyStore.addInitialDirectories}} in it's comment
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
