[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204757#comment-15204757
]
Jim Witschey commented on CASSANDRA-10563:
--
What you did (https://github.com/riptano/cassandra-dtest/pull/858) looks good
to me. I'll be working on merging 8099_upgrade_tests and reviewing your PR
today.
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196286#comment-15196286
]
Paulo Motta commented on CASSANDRA-10563:
-
[~mambocab] I extended the
[upgrade_8099_test|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-10990-dtest/lastCompletedBuild/testReport/upgrade_8099_test/]
suite on [this
branch|https://github.com/pauloricardomg/cassandra-dtest/tree/upgrade_8099_test]
to include streaming legacy sstable tests in the context of CASSANDRA-10990,
which will be integrated soon. What's the preferred approach here? Should we
commit these tests as is for the time being or should I integrate the new tests
in the
[8099_upgrade_tests|https://github.com/pcmanus/cassandra-dtest/commits/8099_upgrade_tests]
branch ?
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121932#comment-15121932
]
Sam Tunnicliffe commented on CASSANDRA-10563:
-
On CASSANDRA-11087, [~thobbs] suggests
bq. Should we add a flag to the upgrade tests to control flushing before
upgrading? It seems like we want to test both behaviors (to ensure commitlog
replay is also covered), but there could easily be other legacy sstable reading
bugs out there.
Which seems eminently sensible (apologies in advance if that's already on the
table, I haven't been through [~slebresne]'s dtest branch yet).
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119299#comment-15119299
]
Sylvain Lebresne commented on CASSANDRA-10563:
--
I've pushed the updates to said branch.
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106416#comment-15106416
]
Sylvain Lebresne commented on CASSANDRA-10563:
--
Btw, can you make sure to integrate the last version of my branch
(https://github.com/pcmanus/cassandra-dtest/commits/8099_upgrade_tests) when
this is committed as I've been added new tests recently.
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106955#comment-15106955
]
Jim Witschey commented on CASSANDRA-10563:
--
[~slebresne] Would it be possible for you to rebase your new commits onto my
changes and push them to the {{riptano/pcmanus_review-8099_upgrade_tests}}
branch? I pushed it as a {{riptano}} branch so we could work together on it.
And, sorry I only mentioned this on GitHub last week and not on Jira, but could
you also document the new tests with docstrings and {{@jira_ticket}}
annotations where appropriate?
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091976#comment-15091976
]
Sylvain Lebresne commented on CASSANDRA-10563:
--
[~mambocab] Any news on the progress of this. We still have no (or almost no)
tests run by cassci that validate that 3.0 nodes are able to read 2.1/2.2
sstables properly, and that's kind of critical. Especially since we're adding
new such tests like in CASSANDRA-10743.
As reminder, the branch to merge (with adaptation so it runs on cassci
properly) is:
https://github.com/pcmanus/cassandra-dtest/commits/8099_upgrade_tests.
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10563) Integrate new upgrade test into dtest upgrade suite
[
https://issues.apache.org/jira/browse/CASSANDRA-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092189#comment-15092189
]
Jim Witschey commented on CASSANDRA-10563:
--
I let this fall on the floor; my apologies. I spent a few minutes on it this
morning and filed a PR here:
https://github.com/riptano/cassandra-dtest/pull/740
It's not ready for merge, it requires some style changes and possibly some
refactoring to use existing upgrade test code, pending review by [~rhatch].
> Integrate new upgrade test into dtest upgrade suite
> ---
>
> Key: CASSANDRA-10563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10563
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Jim Witschey
>Priority: Critical
> Fix For: 3.0.x
>
>
> This is a follow-up ticket for CASSANDRA-10360, specifically [~slebresne]'s
> comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-10360?focusedCommentId=14966539=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14966539
> These tests should be incorporated into the [{{upgrade_tests}} in
> dtest|https://github.com/riptano/cassandra-dtest/tree/master/upgrade_tests].
> I'll take this on; [~nutbunnies] is also a good person for it, but I'll
> likely get to it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
