[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985422#comment-14985422
]
Jim Witschey commented on CASSANDRA-10581:
--
It's a visibility issue -- outside of some kind of logging at startup, there's
no real feedback that you're successfully using JEMAlloc, unless there's
something I've missed.
I hadn't though about the minor release part of it, though. Adding a warning is
probably too much, I agree.
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
> EDIT: I described this in a way that isn't very clear to those unfamiliar
> with Robert's change. To be clear: You can still use JEMAlloc with Cassandra.
> The {{memory_allocator}} option was deprecated in favor of automatically
> detecting if JEMAlloc is installed, and, if so, using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985400#comment-14985400
]
Sylvain Lebresne commented on CASSANDRA-10581:
--
Are we convinced adding a new warning at every startup if you don't have
JEMalloc in a minor release (2.2) is a good idea? Won't this freak out people,
especially since there is no real mention of that new warning in the news file
(the only mention is the deprecation of the yaml option)?
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
> EDIT: I described this in a way that isn't very clear to those unfamiliar
> with Robert's change. To be clear: You can still use JEMAlloc with Cassandra.
> The {{memory_allocator}} option was deprecated in favor of automatically
> detecting if JEMAlloc is installed, and, if so, using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985435#comment-14985435
]
Sylvain Lebresne commented on CASSANDRA-10581:
--
I'm all for visibility, but it would a lot better to have in the log file imo.
Maybe we can set some custom environment variable based on our detection of
JEMalloc, or pass some system option to the binary, so that we can do such
logging.
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
> EDIT: I described this in a way that isn't very clear to those unfamiliar
> with Robert's change. To be clear: You can still use JEMAlloc with Cassandra.
> The {{memory_allocator}} option was deprecated in favor of automatically
> detecting if JEMAlloc is installed, and, if so, using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978730#comment-14978730
]
Jim Witschey commented on CASSANDRA-10581:
--
The documentation changes look good to me. If it's not already logged somewhere
that I missed it, could you add some kind of logging indicating when Cassandra
used JEMAlloc? As is, it's difficult to determine if it's actually used, as far
as I can tell.
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.x, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
> EDIT: I described this in a way that isn't very clear to those unfamiliar
> with Robert's change. To be clear: You can still use JEMAlloc with Cassandra.
> The {{memory_allocator}} option was deprecated in favor of automatically
> detecting if JEMAlloc is installed, and, if so, using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979047#comment-14979047
]
Jim Witschey commented on CASSANDRA-10581:
--
Yep, that's about what I had in mind, if that's the best visibility we can get.
I'm +1.
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.x, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
> EDIT: I described this in a way that isn't very clear to those unfamiliar
> with Robert's change. To be clear: You can still use JEMAlloc with Cassandra.
> The {{memory_allocator}} option was deprecated in favor of automatically
> detecting if JEMAlloc is installed, and, if so, using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979027#comment-14979027
]
Robert Stupp commented on CASSANDRA-10581:
--
Yes, it's difficult to include a check whether jemalloc is actually used. The
startup code in {{cassandra-env.sh}} preloads the library, which effectively
"links" jemalloc between the java runtime and OS {{malloc}}/{{free}} - i.e.
it's basically "invisible" whether jemalloc is used or not.
I've pushed commits for 2.2 + 3.0 with some logging to {{cassandra-env.sh}}
where preloading happens. Is this what you think of?
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.x, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
> EDIT: I described this in a way that isn't very clear to those unfamiliar
> with Robert's change. To be clear: You can still use JEMAlloc with Cassandra.
> The {{memory_allocator}} option was deprecated in favor of automatically
> detecting if JEMAlloc is installed, and, if so, using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation, remove in 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971348#comment-14971348
]
Jim Witschey commented on CASSANDRA-10581:
--
This should also be looked at and updated to reflect the new behavior:
https://github.com/apache/cassandra/blob/0d2ec11c7e0abfb84d872289af6d3ac386cf381f/conf/cassandra-env.sh#L311
> Update cassandra.yaml comments to reflect memory_allocator deprecation,
> remove in 3.0
> -
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.x, 3.0.0
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10581) Update cassandra.yaml comments to reflect memory_allocator deprecation
[
https://issues.apache.org/jira/browse/CASSANDRA-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971321#comment-14971321
]
Aleksey Yeschenko commented on CASSANDRA-10581:
---
bq. How do we want to handle the deprecation more generally? Warn on 2.2,
remove in 3.0?
Yep.
> Update cassandra.yaml comments to reflect memory_allocator deprecation
> --
>
> Key: CASSANDRA-10581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10581
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
> Fix For: 2.2.x, 3.0.x
>
>
> Looks like in 2.2+ changing the {{memory_allocator}} field in cassandra.yaml
> has no effect:
> https://github.com/apache/cassandra/commit/0d2ec11c7e0abfb84d872289af6d3ac386cf381f#diff-b66584c9ce7b64019b5db5a531deeda1R207
> The instructions in comments on how to use jemalloc haven't been updated to
> reflect this change. [~snazy], is that an accurate assessment?
> [~iamaleksey] How do we want to handle the deprecation more generally? Warn
> on 2.2, remove in 3.0?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
