[jira] [Commented] (CASSANDRA-10658) Some DROP ... IF EXISTS incorrectly result in exceptions on non-existing KS

2015-11-27 Thread Marcus Eriksson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029684#comment-15029684
 ] 

Marcus Eriksson commented on CASSANDRA-10658:
-

ok, +1

> Some DROP ... IF EXISTS incorrectly result in exceptions on non-existing KS
> ---
>
> Key: CASSANDRA-10658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10658
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> 2.1, 2.2 and 3.0 incorrectly throws {{InvalidRequestException}} on 
> non-existing keyspace for {{DROP TYPE IF EXISTS}}
> 3.0 incorrectly throws {{ConfigurationException}} for {{DROP AGGREGATE IF 
> EXISTS}} with type arguments.
> 3.0 incorrectly throws {{ConfigurationException}} for {{DROP FUNCTION IF 
> EXISTS}} with type arguments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10658) Some DROP ... IF EXISTS incorrectly result in exceptions on non-existing KS

2015-11-27 Thread Robert Stupp (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029649#comment-15029649
 ] 

Robert Stupp commented on CASSANDRA-10658:
--

bq. could you add tests for these as well?

The ConfigurationException was thrown from 
{{CQL3Type.Raw#prepare(java.lang.String)}} via 
{{DropFunction/AggregateStatement.prepare}}.
There are tests in UFTest and AggregationTest (testNonExistingOnes) that check 
for the correct message.
I've changed the test code to check for the exception class as well (pushed to 
the 3.0 and trunk branches).

> Some DROP ... IF EXISTS incorrectly result in exceptions on non-existing KS
> ---
>
> Key: CASSANDRA-10658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10658
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> 2.1, 2.2 and 3.0 incorrectly throws {{InvalidRequestException}} on 
> non-existing keyspace for {{DROP TYPE IF EXISTS}}
> 3.0 incorrectly throws {{ConfigurationException}} for {{DROP AGGREGATE IF 
> EXISTS}} with type arguments.
> 3.0 incorrectly throws {{ConfigurationException}} for {{DROP FUNCTION IF 
> EXISTS}} with type arguments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10658) Some DROP ... IF EXISTS incorrectly result in exceptions on non-existing KS

2015-11-26 Thread Marcus Eriksson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028379#comment-15028379
 ] 

Marcus Eriksson commented on CASSANDRA-10658:
-

bq. 3.0 incorrectly throws ConfigurationException for DROP AGGREGATE IF EXISTS 
with type arguments.
bq. 3.0 incorrectly throws ConfigurationException for DROP FUNCTION IF EXISTS 
with type arguments.
patch lgtm but could you add tests for these as well?

> Some DROP ... IF EXISTS incorrectly result in exceptions on non-existing KS
> ---
>
> Key: CASSANDRA-10658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10658
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> 2.1, 2.2 and 3.0 incorrectly throws {{InvalidRequestException}} on 
> non-existing keyspace for {{DROP TYPE IF EXISTS}}
> 3.0 incorrectly throws {{ConfigurationException}} for {{DROP AGGREGATE IF 
> EXISTS}} with type arguments.
> 3.0 incorrectly throws {{ConfigurationException}} for {{DROP FUNCTION IF 
> EXISTS}} with type arguments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)