[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052876#comment-15052876
]
Taiyuan Zhang commented on CASSANDRA-10718:
---
Sorry, wasn't aware of the dtest... will remember next time.
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 10718-3.x.txt
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052839#comment-15052839
]
Marcus Eriksson commented on CASSANDRA-10718:
-
just running the tests - we parse the output of compactionstats in dtests so I
had to change the output a bit, updated patch here:
https://github.com/krummas/cassandra/commits/marcuse/10718 and test runs here:
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-10718-dtest/
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-10718-testall/
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 10718-3.x.txt
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052807#comment-15052807
]
Taiyuan Zhang commented on CASSANDRA-10718:
---
Thanks :)
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 10718-3.x.txt
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052806#comment-15052806
]
Marcus Eriksson commented on CASSANDRA-10718:
-
ah, of course, will get it committed, thanks
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 10718-3.x.txt
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052800#comment-15052800
]
Taiyuan Zhang commented on CASSANDRA-10718:
---
{{tableNameToCountMap}} is a map inside {{resultMap}}. {{resultMap}} is
returned whenever the user reads from {{pendingTasksByTableName}}.
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 10718-3.x.txt
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052729#comment-15052729
]
Marcus Eriksson commented on CASSANDRA-10718:
-
[~firstprayer] thanks, looks like you missed actually adding up the currently
ongoing compactions from {{tableNameToCountMap}} in {{pendingTasksByTableName}}
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 10718-3.x.txt
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037511#comment-15037511
]
Marcus Eriksson commented on CASSANDRA-10718:
-
bq. Shall I change the getValue() method (and call hierarchy) to return a
Map>
You should probably add a new jmx method for this - I bet many operators graph
the current pending compactions jmx value and we don't want to break that.
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034335#comment-15034335
]
Tushar Agrawal commented on CASSANDRA-10718:
Need some help and guidance:
PendingTasks metrics comes from "pendingTasks" gauge in CompactionMetrics.java.
In getValue() method it is currently looping through all keyspaces and tables
to get the estimated remaining tasks.
Shall I change the getValue() method (and call hierarchy) to return a
Map> ? How this would be
displayed under JMX metrics?
What could be the other approaches?
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Tushar Agrawal
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029921#comment-15029921
]
Marcus Eriksson commented on CASSANDRA-10718:
-
[~tusharice] have a look at the current compactionstats nodetool command, it is
in {{CompactionStats.java}}
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10718) Group pending compactions based on table
[
https://issues.apache.org/jira/browse/CASSANDRA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022747#comment-15022747
]
Tushar Agrawal commented on CASSANDRA-10718:
Any pointers on where to look into code for this issue? I am interested in
taking this one.
> Group pending compactions based on table
>
>
> Key: CASSANDRA-10718
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10718
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
>
> Currently we only give a global number on how many compactions are pending,
> we should group this on a per-table basis, example:
> {code}
> $ nodetool compactionstats
> pending tasks:
> - keyspace1.standard1: 10
> - other_ks.table: 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
