[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032349#comment-15032349
]
Paulo Motta commented on CASSANDRA-10753:
-
LGTM, marking as "ready to commit!. Thanks!
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031357#comment-15031357
]
Stefania commented on CASSANDRA-10753:
--
CI has completed and it looks OK.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031239#comment-15031239
]
Stefania commented on CASSANDRA-10753:
--
bq. I still have some cqlshlib IO errors on trunk that I haven't had time to
investigate.
These were just problems introduced by CASSANDRA-7225, where a patch is already
available but not yet committed. I've rebased all patches to just before the
7225 commit to exclude these issues.
The timeouts when dropping keyspaces have also disappeared. The tests
themselves seem to run faster. My best guess is a chance in the driver.
All cqlshlib tests are clean on all branches now, at least locally on my box.
CI resubmitted and pending.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030805#comment-15030805
]
Stefania commented on CASSANDRA-10753:
--
bq. I guess we should be safe to update to the released 3.0.0 tag.
OK. There was a little bit of work to do because {{ColumnMetadata}} no longer
has a property called {{index}}. I still have some cqlshlib IO errors on trunk
that I haven't had time to investigate. I will resume mid next week.
bq. That's strange, it shouldn't take that long with such a small amount of
data even on HDDs IMO. Maybe it's a ccm problem? CASSANDRA-8816 reported
slowness on keyspace drop on Windows, so maybe you could run those tests and
check if they're failing in your machine? Is it possible to enable tracing on
drop keyspace statements? It would may be nice see what's making it so slow.
It's not a ccm problem because I am not using it; I'm using a simple
{{cassandra -f}}. I cannot reproduce the failures of CASSANDRA-8816. From what
I could see so far, the driver notifications were sent after several flush
operations. I will add more trace messages and investigate next week. For now
I've left the time-out to 20 seconds on all branches.
CI resubmitted on 2.2, 3.0 and trunk.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030277#comment-15030277
]
Paulo Motta commented on CASSANDRA-10753:
-
Submitted cassci runs for {{stef1927-10753-2.2-dtest}} and
{{stef1927-10753-3.0-dtest}}.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030001#comment-15030001
]
Paulo Motta commented on CASSANDRA-10753:
-
bq. By the way, do you know which version it is? I could not even find commit
3f15725 on any branch in the driver repository. Shouldn't we upgrade to a later
and more official version instead?
I think this was a custom build before c5354507aab471bd9f9f017138302693ea9e48ed
was merged into master. I guess we should be safe to update to the released
3.0.0 tag. There are some [instructions
here|https://github.com/datastax/python-driver/blob/master/README-dev.rst#packaging-for-cassandra]
here for creating the artifact.
bq. I also started noticing some timeout failures in the cqlshlib tests, on all
branches, when dropping keyspaces. Do you think this is normal?
That's strange, it shouldn't take that long with such a small amount of data
even on HDDs IMO. Maybe it's a ccm problem? CASSANDRA-8816 reported slowness on
keyspace drop on Windows, so maybe you could run those tests and check if
they're failing in your machine? Is it possible to enable tracing on drop
keyspace statements? It would may be nice see what's making it so slow.
bq. I'll start the dtests as soon as CASSCI is back.
Seems cassci is still not back, so we can restart it after it's back.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029749#comment-15029749
]
Stefania commented on CASSANDRA-10753:
--
I managed to launch the jobs once but there was an issue on 2.2 (should be
fixed now) and an unrelated failure on 3.0. We should restart
{{stef1927-10753-2.2-dtest}} and {{stef1927-10753-3.0-dtest}} but cassci is not
responding right now.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029366#comment-15029366
]
Stefania commented on CASSANDRA-10753:
--
Thanks for your review:
bq. In test_timestamp_output since the TZ property is ignored I guess we can
just remove the second equals statement which is the same as the first. What do
you think?
Agreed, removed.
bq. The max_window_size_seconds problem is also affecting 2.2, could you
provide a 2.2 patch? (It's not on jenkins but since we'll still maintain 2.2
for some time, I guess we should fix it).
To fix 2.2 I think we need the entire patch since according to [~aholmber]
[comment|https://issues.apache.org/jira/browse/CASSANDRA-9302?focusedCommentId=15027191&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15027191]
on CASSANDRA-9302 we should be running the current driver. So I backported the
entire patch to 2.2 (via cherry-pick of individual commits) and then upgraded
the bundled driver to the same as 3.0. By the way, do you know which version it
is? I could not even find commit {{3f15725}} on any branch in the driver
repository. Shouldn't we upgrade to a later and more official version instead?
I also started noticing some timeout failures in the cqlshlib tests, on all
branches, when dropping keyspaces. I did not notice them before and I think
it's because I just migrated to a loan laptop where I installed Linux on an
hybrid HDD rather than SSD. It takes a crazy long time to flush all tables
before the final KEYSPACE DROPPED notification is sent to the driver. For 2.2 I
needed at least 20 seconds but for 3.0+ it took up to 35 seconds so I increased
the timeout to 45 seconds in 3.0+. Do you think this is normal?
Here are the patches and CI, but CASSCI is currently down so I cannot start any
jobs:
||2.2||3.0||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/10753-2.2]|[patch|https://github.com/stef1927/cassandra/commits/10753-3.0]|[patch|https://github.com/stef1927/cassandra/commits/10753]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10753-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10753-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10753-dtest/]|
I verified the cqlshlib tests locally on all branches. I'll start the dtests as
soon as CASSCI is back.
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028923#comment-15028923
]
Paulo Motta commented on CASSANDRA-10753:
-
Looks good. Minor nits:
* In {{test_timestamp_output}} since the {{TZ}} property is ignored I guess we
can just remove the second equals statement which is the same as the first.
What do you think?
* The {{max_window_size_seconds}} problem is also affecting 2.2, could you
provide a 2.2 patch? (It's not on jenkins but since we'll still maintain 2.2
for some time, I guess we should fix it).
After that should be good to go. Thanks!
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10753) Fix completion problems breaking clqshlib tests
[
https://issues.apache.org/jira/browse/CASSANDRA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021381#comment-15021381
]
Stefania commented on CASSANDRA-10753:
--
I've attached a 3.0 patch but it is based also on a fix for CASSANDRA-9304,
without which the cqlshlib tests do not run due to import problems. The patch
applies to trunk without conflicts.
Here are the dtests:
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10753-3.0-dtest/
http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10753-dtest/
[~pauloricardomg] I think you did some related work can you take this ticket
for review?
> Fix completion problems breaking clqshlib tests
> ---
>
> Key: CASSANDRA-10753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10753
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.x
>
>
> The recent changes in the python driver APIs have caused some completion
> problems as indicated by 2 of these failing tests:
> http://cassci.datastax.com/job/trunk_cqlshlib/579/testReport/
> The third failing test, {{test_timestamp_output}}, has been failing for some
> time due to uncertainty on what to do regarding timezone conversion but it
> too can be changed to reflect the fact that we convert the timestamp to UTC.
> Finally, {{max_window_size_seconds}} was recently added to the compaction
> properties and this caused 2 more tests to fail. It cannot be seen on Jenkins
> because of the relative import problem introduced by CASSANDRA-9304.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
